summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-16tdf#126796 percent stacked image fixed for breezeandreas kainz
Change-Id: I6687d462de7e21e770220cc1e804a28231b9e38d Reviewed-on: https://gerrit.libreoffice.org/80866 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-16tdf#126060 Handle text camera z rotation while pptx import.Gülşah Köse
Change-Id: Ifa4589fb50affc4c5ffb52288db8533c98ec6dd9 Reviewed-on: https://gerrit.libreoffice.org/80587 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2019-10-16fix breeze dark theme issue in charts moduleandreas kainz
Change-Id: Idb145235f05a1916199768f4d6ef9fdc47a77084 Reviewed-on: https://gerrit.libreoffice.org/80867 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-10-16Disable chart doubleclick on mobileSzymon Kłos
To not show any dialog. Change-Id: Ie19df429b927f746d3fc511ab0aa7b489ec1fd18 Reviewed-on: https://gerrit.libreoffice.org/80851 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-16tdf#62955 - Allow searching a name with typing the first letterAndreas Heinisch
Grab focus of the TreeView when the macro chooser is created Change-Id: Idfe3d2435840103eb2fa0ec5d17efce0931cfabd Reviewed-on: https://gerrit.libreoffice.org/80095 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-10-16swap left/right for RTL scrolling hadjustmentCaolán McNamara
Change-Id: Ia1cb82c5fce09c71f9378690a35355cb6636e6ae Reviewed-on: https://gerrit.libreoffice.org/80858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-16Simplify insertion into stringMike Kaganski
Change-Id: I326422f09d59590533966a2956f5442e1ec694b5 Reviewed-on: https://gerrit.libreoffice.org/80864 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-16convert some Buffer.append to +Noel Grandin
by hand, because I don't feel like teaching this specific idiom to the plugin Change-Id: If400677dac842ca740c4532ed79f6f18f752b730 Reviewed-on: https://gerrit.libreoffice.org/80842 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16writerfilter: sync layout-in-cell vs wrap-though behavior with ww8 importMiklos Vajna
I removed the same check in the WW8 import in commit d630f69d90f15bc652a62648b05ea515de78d16a (Related: tdf#124601 DOC import: improve fLayoutInCell handling, 2019-09-26). There is no reason the DOCX import shouldn't do the same, just for consistency. Change-Id: I9e56a3fcd0b13ba08e347fbc06b0960ac21b372c Reviewed-on: https://gerrit.libreoffice.org/80856 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-16Replace define by constexpr in sft.hxx (vcl)Julien Nabet
+ add required vcl namespace prefix to a call from outside in fontsubset.cxx Change-Id: Ib8d5c2e5a409957221c81b17dafaf3323760e8e5 Reviewed-on: https://gerrit.libreoffice.org/80857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16loplugin:stringadd look through a couple more known-good methodsNoel Grandin
Change-Id: Ifbdb3e41eae665f7dcaf5301aaba2b6e4662cf48 Reviewed-on: https://gerrit.libreoffice.org/80855 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16sc: rowcol: migrate the Sc*IteratorNoel Grandin
Change-Id: I1e9a2b769d62ed3293de724ec50664bd8d22003e Reviewed-on: https://gerrit.libreoffice.org/80841 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-16Remove a FIXME for win95 in vcl/gdi/printJulien Nabet
Since LO requires Win7 at least Change-Id: I4f4ea9fa3b87b4fae3f4eabbf736c4a2e7db3d8b Reviewed-on: https://gerrit.libreoffice.org/80861 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-15tdf#128148 Add unit testMichael Weghorn
The implementation of 'SwEditShell::ApplyAdvancedClassification' helped to find out how to access the text in the header. Change-Id: If044eea2e7d012ef56c0fff38a17af4aa59fea25 Reviewed-on: https://gerrit.libreoffice.org/80815 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-10-15tdf#128148 SwDoc::Append: Copy page descs if any has header/footerMichael Weghorn
Don't only check the first SwPageDesc, but also its follows whether they have a header or footer and copy the page styles in this case, since otherwise the header/footer content can be wrong if the first page's page style doesn't have header/footer but a following one does. Change-Id: If5ef76a7faf93ad533976b501f35f171336615c8 Reviewed-on: https://gerrit.libreoffice.org/80814 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-15gandalf now has gcc9 / no devtoolsetChristian Lohmaier
Change-Id: I2e5ded126f99ea7eb79d2db57240203dd3025e67
2019-10-15Improve loplugin:stringadd diagnosticsStephan Bergmann
Change-Id: I8b87c4e56f10417acd538b765b3f8e4cc6e12fb9 Reviewed-on: https://gerrit.libreoffice.org/80844 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-15honour per-widget RTL overrideCaolán McNamara
Change-Id: I29a499d29a3c0fabc594efbd5f966b108659b166 Reviewed-on: https://gerrit.libreoffice.org/80853 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15database options page too tallCaolán McNamara
Change-Id: I79ce30e2254980994e64764525efc307c1a79db1 Reviewed-on: https://gerrit.libreoffice.org/80852 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15Fix typoAndrea Gelmini
Change-Id: I48a52bd1c7afe83fe02c9651963436b9c5e07ca0 Reviewed-on: https://gerrit.libreoffice.org/80849 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-15Improve loplugin:stringaddStephan Bergmann
...after 9b5dad13b56bdde7c40970351af3da3a2c3c9350 "loplugin:stringadd look for unnecessary temporaries". There was no reason to check for implicit MaterializeTemporaryExpr instead of explicitly written CXXFunctionalCastExpr, and checking for the latter makes it easier to report the casted-from type, which gives useful information how to change code that exhibits the warning. See the comments at <https://gerrit.libreoffice.org/#/c/80724/> "loplugin:stringadd look for unnecessary temporaries" for details. (And while at it, remove some commented-out debug code that is probably no longer relevant now.) Change-Id: I7d4cab85432885d617dd7114c75163c1eb376fc2 Reviewed-on: https://gerrit.libreoffice.org/80823 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-15back isShowing with IsReallyVisibleCaolán McNamara
Change-Id: Ibae8fa0d21cd2c0b49c3c8709087319502f70cb0 Reviewed-on: https://gerrit.libreoffice.org/80824 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15Related: tdf#124729 check for gtk_gl_area_get_error before continuingCaolán McNamara
Change-Id: Ib87f32c2fa8c561981920ea688ea723c8e59bead Reviewed-on: https://gerrit.libreoffice.org/80836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15use PCH for clang plugin source too, if enabledLuboš Luňák
This currently supports only building with Clang on Linux, as I'm lazy to handle the other cases (and Clang should be usually self-built anyway). The main compile time cost is in optimizing the code, but this still saves few seconds per source. Change-Id: Ib6c0fd874820af737ee1257cb5234fb78bc63ad8 Reviewed-on: https://gerrit.libreoffice.org/80810 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-15handle gracefully PCH reuse when there are no .pdb filesLuboš Luňák
In non-debug builds there are indeed no .pdb files to copy and reuse, and that's fine. Change-Id: I083a33ae81ac63b4e62f3a7cf0f8414996c6a843 Reviewed-on: https://gerrit.libreoffice.org/80812 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-15jsdialogs: handle dialog eventsSzymon Kłos
Change-Id: Icc092cd5b06168d9de8ebed891fc03491865dbad Reviewed-on: https://gerrit.libreoffice.org/80788 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2019-10-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Restrict warning to sys=UNIX Warning applies only to UNIX like systems Change-Id: I1fe93eef298bb7f3f00d0318edb4413672e93d1f Reviewed-on: https://gerrit.libreoffice.org/80831 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-15new loplugin:bufferaddNoel Grandin
look for OUStringBuffer append sequences that can be turned into creating an OUString with + operations Change-Id: Ica840dc096000307b4a105fb4d9ec7588a15ade6 Reviewed-on: https://gerrit.libreoffice.org/80809 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-15tdf#79007: Do not overwrite if only one of nBrightness...Xisco Fauli
...or nContrast is != 0 Thanks to M. Stahl Change-Id: I28a08f31ca1e93d7b06f56700baea0d8ab6c7de4 Reviewed-on: https://gerrit.libreoffice.org/80818 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-15only need an OutputDevice not a full vcl:WindowCaolán McNamara
Change-Id: I79e0a5877a531cd1b0badf3adcc721254ad441d9 Reviewed-on: https://gerrit.libreoffice.org/80820 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15Bin a fairly pointless unconditional NSLog() callTor Lillqvist
Change-Id: I7c1910c3e1bf345966ec289aaf5f9c9b6cbabc22
2019-10-15Can use pointer to const hereStephan Bergmann
Change-Id: I1960e0a460ec4eae4f8d4da526aad8db863087af Reviewed-on: https://gerrit.libreoffice.org/80813 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-15tdf#128096: only use CharBackColor for highlight if exporting to pptxXisco Fauli
Just in case, making sure highlight in docx export works as before Change-Id: Ied42da1c5f286b80fc754a06357960e8334a765f Reviewed-on: https://gerrit.libreoffice.org/80780 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-10-15Resolves: tdf#128137 cursor jumping during edit, etc.Caolán McNamara
The mbNeedUpdate hackery to block changes caused by the user was subverted by the async handling of the treeview selection. a) add a call to wait and process outstanding async events within the protected block b) move the needupdate down to the range manager to block updates during this block in CheckForFormulaString too c) when updating the visible rows, also update the selected rows even if they are not visible. Change-Id: I4c67d6cd2780f55d5eab5f856f6fda21703b4977 Reviewed-on: https://gerrit.libreoffice.org/80794 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15Resolves: tdf#128140 stabilize formula dialog widthCaolán McNamara
Change-Id: Ifdb80adfd4b399035ed793f8636f31b90cf50094 Reviewed-on: https://gerrit.libreoffice.org/80800 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-15move HAVE_FEATURE_DESKTOP/OPENCL to their dedicated headersLuboš Luňák
HAVE_FEATURE_OPENCL is included by a common Calc header and HAVE_FEATURE_DESKTOP is included by a common Writer header, causing pretty much their full rebuilds if any feature changes. Change-Id: If29bf78bd4fd70b37981e0826a577777fd255c89 Reviewed-on: https://gerrit.libreoffice.org/80776 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-10-15tdf#127964 PPTX import: fix shape fill handling: style vs slide backgroundMiklos Vajna
Regression from commit 943a534ac7cb3df513583e226c986dafd8ba246b (tdf#123684 PPTX import: fix wrong background color for <p:sp useBgFill="1">, 2019-04-23), the problem was that we didn't handle the case when a shape had an XML fragment like this: <p:sp useBgFill="1"> <p:style> <a:fillRef idx="1"> <a:schemeClr val="accent1"/> </a:fillRef> </p:style> </p:sp> i.e. the shape both wants to use background fill and it has a style declaring how to fill it as well. We gave the style a priority, while PowerPoint gives the background fill a priority. Fix the problem by not setting the fill from the style in case the background fill is already set. Change-Id: Ie1b56e5615219138a5b7ddd7a2b25295b991bc05 Reviewed-on: https://gerrit.libreoffice.org/80804 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-15Replace getDefaultValue by getColExprForDefaultSettingVal (postgresql)Julien Nabet
Change-Id: I8e0eea84a711ce45d991c07d7811094e33bcce38 Reviewed-on: https://gerrit.libreoffice.org/80787 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-15Add option to prevent graphic swap outSamuel Mehrbrodt
Change-Id: Icbfc21b219cd4ba582e798e5deda6ef7c81a2009 Reviewed-on: https://gerrit.libreoffice.org/80773 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2019-10-14Fix method name origin in SAL_WARN_IF(vcl/quartz/salgdi)Julien Nabet
Change-Id: I7fff6af5e521318324df63b32d4be7b0e0f12771 Reviewed-on: https://gerrit.libreoffice.org/80803 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-14lok: impress: show only supported transitions in the side paneMarco Cecchetti
Change-Id: I631ee8b101bacc4dec075100aa25158b71fbae40 Reviewed-on: https://gerrit.libreoffice.org/80681 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-14use common PCH for more librariesLuboš Luňák
Change-Id: I53164be413426691025a63cfba731cf5f9d1b7f8 Reviewed-on: https://gerrit.libreoffice.org/80790 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14fix incorrect gb_DISABLE_PCH_REUSE testLuboš Luňák
Change-Id: Ife41ea7ad19c03b8dca6afe8b15d0f3b752b533b Reviewed-on: https://gerrit.libreoffice.org/80789 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14remove -bigobj usage from sw rtf unittestsLuboš Luňák
They all have been split since the time the flag was added, and they seem to be small enough again. And this prevents a PCH CXXFLAGS mismatch when using the common PCH. Change-Id: If51d3969e11bb37777d49fe877671c1313721588 Reviewed-on: https://gerrit.libreoffice.org/80793 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14filter out cl.exe printing source file name also when not using depsLuboš Luňák
This is what filter-showIncludes.awk does as a side-effect, so this is for the --disable-dependency-tracking case. Change-Id: I0fd58ff4e343c6322e9cba641acd5fa2bf3816f4 Reviewed-on: https://gerrit.libreoffice.org/80731 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - More work on Xapian result page Added module dropdown fix TODO: Language Change-Id: I47012d6280694d87fb5d19e25c6052b8a7ed89c7 Reviewed-on: https://gerrit.libreoffice.org/80771 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-10-14tdf#128139: add missing nullptr checkMike Kaganski
Regression after ef2ec07b4113fdadf863352c832af657b5ae205c Change-Id: I5eed95e8136a812813145283e6b533a808324380 Reviewed-on: https://gerrit.libreoffice.org/80782 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-10-14Resolves: tdf#128134 page creation order affecting travelCaolán McNamara
the page is created before the page is moved to, so CanTravel gets locked. Only lock when the page is the current page Change-Id: Ic21fe3077a750e1279db8be0dd5c7f9112c999b1 Reviewed-on: https://gerrit.libreoffice.org/80779 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-14tdf#128138 sw_redlinehide: fix infinite loop in FindAttrsImpl()Michael Stahl
The code looked wrong previously, always assigning the end of the text node regardless of direction, but it turns out the improvement caused an infinite loop... let's just swap things after the loop, seems simpler than adding another if at the assignments. (regression from 4caef398af256be5f0c2a159129b528ee3702e5c) Change-Id: I098f5265fa86d6a2511a80a02230899a7a303a88 Reviewed-on: https://gerrit.libreoffice.org/80774 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-10-14Update git submodulesChristian Lohmaier
* Update translations from branch 'master' - update translations for master and force-fix errors using pocheck Change-Id: I69677c891cfbd2e5d91880a7020dbe4165cb8ac4
generated by cgit (git 2.34.1) at 2024-07-09 14:27:40 +0000