summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-11-20tdf#88351: Revert "coverity#704341 Logically dead code"Julien Nabet
This reverts commit 7b1f5cc16fdbc0c53d0b7f9e3f45decd1136f4fa. Change-Id: I85d4c45025817914d6b78458f24a343f3b05879c Reviewed-on: https://gerrit.libreoffice.org/31017 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-20Simplify this code.Tamás Zolnai
Change-Id: I2a82d99277114135c4dde8ef83fc454329411c21
2016-11-20Fix this unit testTamás Zolnai
Change-Id: Ia231c38cfce03449babc8bc6e72b049ea08b56ae
2016-11-20tdf59046 oox: fix incorrectly combined shapesMark Hung
1. Store the path of all polygons of a PolyPolygon in the same path element so it subtract overlapped area. 2. Set the size of the path as the bounding box of PolyPolygon so the points of the polygon scale and offset properly. Change-Id: If6e21d1ac0544b45ef68073cf14bcc08c1d7dbef Reviewed-on: https://gerrit.libreoffice.org/30982 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-20Revert "split cui screenshot test in manageable pieces"Julien Nabet
This reverts commit c3c0557801d8713fb99216bea37443471affc1f6. Hopefully make TBs green again Change-Id: Ifb574175fd3bbdce1520aea7953dd8fb95bed30b Reviewed-on: https://gerrit.libreoffice.org/31018 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2016-11-19Revert "Use rtl::Reference to wrap ScAccessibleEditObject here."Kohei Yoshida
This reverts commit da7aa2561297da42058da55ed2629d0df6fb03f3.
2016-11-20split cui screenshot test in manageable piecesNorbert Thiebaud
Change-Id: I7aa6e7afecc841aecbc1acaf1a7c14ba92c089ba Reviewed-on: https://gerrit.libreoffice.org/30981 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-11-20PivotMedian: ODS import / export of pivot table medianTamás Zolnai
Change-Id: I3b018f5a76bb3d89bcb6cbc34e4cb2f2057248d5
2016-11-20PivotMedian: Implement median as a new pivot table functionTamás Zolnai
Change-Id: Ife90c8f1c36980254de3cec6e395a6ba94d99fea
2016-11-20[API Change] PivotMedian: Add median to pivot table function typeTamás Zolnai
Change-Id: I675e81b5c13832ac0ff893a6e080241e6f1c8fd5
2016-11-20Display localized function names in Pivot Layout dialogTamás Zolnai
Same names which are displayed for pivot table placed on a sheet. Change-Id: Ic05d0dddea7d17101f253874dff15b8a49b87287
2016-11-20Remove some unused resource stringsTamás Zolnai
Change-Id: I8529aa491d37aef5e732909357ddf93372dde6d2
2016-11-20Remove unused macroTamás Zolnai
Change-Id: I407217703d285fc858208cbcdfae0fe84a30fcee
2016-11-19tdf#103969: Do fallback glyph rotationKhaled Hosny
Charters with vertical orientation Tr (transformed rotated) should be rotated does not provide a vertical alternate. We check this by seeing if the glyph we got from HarfBuzz is possibly a vertical alternate. Change-Id: I40a0956847bedef1d67ab02ccb27a97d049ba471 Reviewed-on: https://gerrit.libreoffice.org/30984 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2016-11-19tdf#48140 Replace CellAddress uno calls with direct accessBartosz Kosiorek
Change-Id: I4c8b36eaa29241f886810f9bff88ed9ca9d3192f Reviewed-on: https://gerrit.libreoffice.org/30979 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-19Use rtl::Reference to wrap ScAccessibleEditObject here.Kohei Yoshida
And avoid ScAccessibleEditObject from getting instantiated every time cell edit mode is triggered. Change-Id: Id214248c7b6fcc28ab33777e1c44cdfc07276620 Reviewed-on: https://gerrit.libreoffice.org/30991 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-19strip now obsolete comment partEike Rathke
... but keep the SdrDelayBroadcastObjectChange as it still serves during copying notes/captions. Change-Id: I8cf6a8045238af8d196a304ca4dfe20d4e407624
2016-11-19sc-perf: lock drawing layer during creation of captions for SaveEike Rathke
This gives an extra boost compared to commit 451c4cccc7e3ec3f1e046d3232cb52f6fc443f59 (see there for further details) as it eliminates broadcasts to accessibility and thus obtaining text forwarders and what not. ScPostIt::CreateCaptionFromInitData() compared to that commit from 145,055,889,118 to 63,386,691,509 Overall ScDocShell::SaveXML() from original state before that commit Before: 370,433,720,090 After: 107,468,180,524 Reduced to 29% or speed-up by factor 3.45 Change-Id: Ife86476c9654739ed9adf25e775f7568ea9934c2
2016-11-19We don’t use this with the new layout engineKhaled Hosny
Don’t wast time parsing GSUB table to populate a vector that we won’t use. Change-Id: I74dbb0f4d679cf06f22c1667899bcd3cae22c1d8
2016-11-19tdf#92076 oox - export PolyPolygonShape and PolyLineShape.Mark Hung
1. Export PolyPolygonShape and PolyLineShape. 2. Rename WriteBezierShape to WritePolyPolygonShape because ClosedBezierShape, OpenBezierShape, PolyPolygonShape,and PolyLineShape share the function and all use EscherPropertyContainer::GetPolyPolygon to get PolyPolygon structure and use WritePolyPolygon to write xml tags. Change-Id: I9ffdc26cf1f6fe8ea3b91b7b218d67f9e5585617 Reviewed-on: https://gerrit.libreoffice.org/30972 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2016-11-19tdf#48140 Remove not used UNO headers from filtersBartosz Kosiorek
Change-Id: I66e775b60343fe8ac772d8c0287ca19be58a7236 Reviewed-on: https://gerrit.libreoffice.org/30966 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2016-11-19TyposKhaled Hosny
Change-Id: Iff293841047a945107033ed81d4e81fb8bbe67b8
2016-11-19tdf#103891: Fix DX array calculationKhaled Hosny
This partially reverts: commit c49d5dea164b09b05a898495fa2dd48b7ca4f0e4 Author: Khaled Hosny <khaledhosny@eglug.org> Date: Fri Nov 11 18:24:11 2016 +0200 tdf#103765: Minimize the effect of rounding to int Instead of scaling the relative coordinates and accumulating rounding errors, scale the absolute coordinates. Also round to int instead of truncating. as it results in OutputDevice::GetTextArray() calculating wrong absolute DX array. Again the whole DX array thing is brain dead. Change-Id: Ia257b73062315b797b5ed52e434562fad3b3fb90
2016-11-19LOK - Calc: unit test for invalidation on row insertMarco Cecchetti
Change-Id: I999bcef29b90fafcd803243a967fcb8109e61db8 Reviewed-on: https://gerrit.libreoffice.org/30978 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-11-19sc-perf: bundle SdrObject::BroadcastObjectChange() calls during SaveEike Rathke
Test doc https://bugs.documentfoundation.org/attachment.cgi?id=128252 from https://bugs.documentfoundation.org/show_bug.cgi?id=103493 ScPostIt::CreateCaptionFromInitData() called through ScDocument::CreateAllNoteCaptions() Incl. Self Called Before: 326,418,830,114 487,308 6,645 After: 145,055,889,118 511,681 6,645 Reduced to 44% or speed-up by factor 2.25 Overall ScDocShell::SaveXML() Before: 370,433,720,090 After: 189,120,982,786 Reduced to 51% or speed-up by factor 1.96 There's still too much broadcasting to accessibility going on though.. Change-Id: I50555fd9751ac24006cc96b2fa8e82b32aba0748
2016-11-19LOK - Calc: unit test for invalidation on copy/paste to the doc bottomMarco Cecchetti
Change-Id: I92b6a3f1c3b3c6c260b25b046bd19b249be0db0b Reviewed-on: https://gerrit.libreoffice.org/30977 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-11-19LOK - Calc: use the tiled rendering area as visible area in PaintAreaMarco Cecchetti
This workaround is needed since the visible area in core is not the same which is used in the client. Change-Id: I82b23e689000c4d8106ffa01ed082ae3d629b1be Reviewed-on: https://gerrit.libreoffice.org/30976 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-11-19LOK - calc: now PgUp/PgDn offset is used only when PgUp/PgDn are pressedMarco Cecchetti
Change-Id: I340d747021bc794361d6b8eff76335345b60010c Reviewed-on: https://gerrit.libreoffice.org/30975 Reviewed-by: Marco Cecchetti <mrcekets@gmail.com> Tested-by: Marco Cecchetti <mrcekets@gmail.com>
2016-11-19tdf#103500 Import stretchy integral symbol from MathMLTakeshi Abe
as "intd". Change-Id: Ic8a4feef7a3a19c8ed5bca2f09f80901e2b6d343 Reviewed-on: https://gerrit.libreoffice.org/30953 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-11-18tdf#104015: PPTX import: Title shape does not inherit fill propertiesTamás Zolnai
...from slide master. The problem caused by that PPTX files contains not a one-level master slide set, but has two levels: one called slide master, other called slide layout. Slide layout inherit properties from slide master and normal slide inherit propetries from slide layout. Bug appeared because, slide layout inherited properties were not forwarded to the normal slide. Change-Id: I587582498cf4315087f9a576c1b7fc41ee23e2fd Reviewed-on: https://gerrit.libreoffice.org/30969 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2016-11-18coverity#1394416 ensure there's enough data to readCaolán McNamara
Change-Id: I9d2cf2e566dd10243a0ca72e6a9278bd2eaed57b
2016-11-18sd: assert SfxPoolItem::operator==Michael Stahl
Remove the defensive programming here. Change-Id: I27e89fe6e28ee3c0c2821083d825859d10f79bb0
2016-11-18editeng: assert SfxPoolItem::operator==Michael Stahl
Change-Id: Ia6c6f4f5af1e3a803b464ab410558984c3861a65
2016-11-18svl: assert SfxPoolItem::operator==Michael Stahl
Change-Id: Ia293c498682dd2ac86b15a74f06fd1ab389f9ba6
2016-11-18svx: assert SfxPoolItem::operator==Michael Stahl
Change-Id: I7a5898f0dffb4d25b6e1bb916b3c6b36374f9912
2016-11-18sax: these are for XMLSchema-2 duration/date/dateTime, not "ISO"Michael Stahl
ISO 8601 is a little more lenient in its lexical representation. Change-Id: I92834a2a1d3c0c37203c13d17e8ae42a1cfe9e1c
2016-11-18The PDF tests require HAVE_FEATURE_PDFIMPORTTor Lillqvist
Change-Id: Iac3d2206388fde23d2f3d7a05b23978851cf2800
2016-11-18Avoid division by zeroStephan Bergmann
...as happens during CppunitTest_sd_dialogs_test when displaying modules/simpress/ui/headerfootertab.ui: > sd/source/ui/dlg/headerfooterdlg.cxx:782:63: runtime error: division by zero > #0 0x7f270dc78b7f in sd::PresLayoutPreview::Paint(OutputDevice&, Rectangle const&) sd/source/ui/dlg/headerfooterdlg.cxx:782:63 > #1 0x7f274a56bb53 in PaintHelper::DoPaint(vcl::Region const*) vcl/source/window/paint.cxx:307:24 > #2 0x7f274a57be32 in vcl::Window::ImplCallPaint(vcl::Region const*, unsigned short) vcl/source/window/paint.cxx:613:17 > #3 0x7f274a577eee in PaintHelper::~PaintHelper() vcl/source/window/paint.cxx:547:30 > #4 0x7f274a57c305 in vcl::Window::ImplCallPaint(vcl::Region const*, unsigned short) vcl/source/window/paint.cxx:619:1 > #5 0x7f274a577eee in PaintHelper::~PaintHelper() vcl/source/window/paint.cxx:547:30 > #6 0x7f274a57c305 in vcl::Window::ImplCallPaint(vcl::Region const*, unsigned short) vcl/source/window/paint.cxx:619:1 > #7 0x7f274a589f0d in vcl::Window::Update() vcl/source/window/paint.cxx:1310:24 > #8 0x7f274b908d23 in ImplHandlePaint(vcl::Window*, Rectangle const&, bool) vcl/source/window/winproc.cxx:1593:18 > #9 0x7f274b8f9092 in ImplWindowFrameProc(vcl::Window*, SalEvent, void const*) vcl/source/window/winproc.cxx:2437:13 > #10 0x7f272e3c8662 in SalFrame::CallCallback(SalEvent, void const*) const vcl/inc/salframe.hxx:276:33 Change-Id: I2868a8b0a726544c9edbaab62a8929badf6d3845
2016-11-18Missing XComponent.dispose calls in screenshot testsStephan Bergmann
Change-Id: I5df25a16303719593d40f08d1e7c15e4636a2d02
2016-11-18xmlsecurity: clean up unused mxSecurityControllerMiklos Vajna
Change-Id: Ife64ab3683479baf152357a6167718f13c9b6089 Reviewed-on: https://gerrit.libreoffice.org/30964 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2016-11-18tdf#103960: The import of UCS2 data uses a different code path.Jan Holesovsky
The commit b297f7bbfed83f87398231740e910afe6ebfbb97 was too eager from this point of view, we shouldn't use SetSrcEncoding for UCS2 because in that case we end up with RTL_TEXTENCODING_DONTKNOW in eSrcEnc. Change-Id: Id8bcb08aee17c8258c074b481345a2795939edc0
2016-11-18Prefer to take the signature date from the XAdES SigningTime, if presentTor Lillqvist
Change-Id: I15a00a8c6f8c8e735694baa25e06ed4db0875d43
2016-11-18fdo#71409: Prevent the a11y code from creating an edit view instance.Kohei Yoshida
GetEditView() now creates one if one does not exist. Clearly that's not the behavior the original a11y code was expecting. This at least removes the duplicated focus events with F2 press on sheet cell, though I still see a fair amount of duplicated events firing in other places... Change-Id: Ib5310ce5c67ab862b3a8a7a6c912d164475d62fa Reviewed-on: https://gerrit.libreoffice.org/30946 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-18Use std::unique_ptr for pEditEngine.Kohei Yoshida
And rename it to mpEditEngine. Change-Id: Iacaad04ca476bfb5b5e35e6e29f372812c40b3bc Reviewed-on: https://gerrit.libreoffice.org/30945 Reviewed-by: Kohei Yoshida <libreoffice@kohei.us> Tested-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-18Use std::unique_ptr for EditView.Kohei Yoshida
Also rename pEditView to mpEditView. Change-Id: Iac3b35cd59960df5be5dd90532dc7e757652d50e Reviewed-on: https://gerrit.libreoffice.org/30944 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2016-11-18Blacklist for now some more problematic dialogs in CppunitTest_sw_dialogs_testStephan Bergmann
...where the instantiated SwEnvPreview expects to have a SwEnvDlg parent, and at least ASan/UBSan reports about that Change-Id: Ib21f0787e149547037a31a53d831d26b27aa5960
2016-11-18Make sure swui's pSwResMgr is initialized in CppunitTest_sw_dialogs_testStephan Bergmann
...to avoid -fsanitize=null at > sw/source/uibase/dbui/dbtree.cxx:147:18: runtime error: reference binding to null pointer of type 'ResMgr' > #0 0x7fd408581b70 in SwDBTreeList::SwDBTreeList(vcl::Window*, long) sw/source/uibase/dbui/dbtree.cxx:147:18 > #1 0x7fd408594596 in VclPtr<SwDBTreeList> VclPtr<SwDBTreeList>::Create<VclPtr<vcl::Window>&, long&>(VclPtr<vcl::Window>&, long&) include/vcl/vclptr.hxx:138:46 > #2 0x7fd4085827d8 in makeSwDBTreeList sw/source/uibase/dbui/dbtree.cxx:156:1 > #3 0x7fd443044214 in VclBuilder::makeObject(vcl::Window*, rtl::OString const&, rtl::OString const&, std::__debug::map<rtl::OString, rtl::OString, std::less<rtl::OString>, std::allocator<std::pair<rtl::OString const, rtl::OString> > >&) vcl/source/window/builder.cxx:1793:17 Change-Id: I02c5a0017b85254bf34f622b55f7db9d5d546b80
2016-11-18loplugin:datamembershadowNoel Grandin
Change-Id: I8a737a2f22c7be9630a1f7562b4309e687bb85f9 Reviewed-on: https://gerrit.libreoffice.org/30948 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2016-11-18sync ONDXPagePtr impl with current SvRef implCaolán McNamara
Change-Id: I85e62a8c634a681e2e53745e3bed52731e8740e0
2016-11-18Make this look less wiredKhaled Hosny
Change-Id: I20b6a5e6ecdf48e1ca8df2e7e86248eae666c9f1
generated by cgit (git 2.34.1) at 2024-07-19 03:17:07 +0000