summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-25tdf#130912: "Before" and "After" text swapped in footnotesJulien Nabet
Change-Id: I8022d3ec2385d35283711a144f6d610357790771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89387 Tested-by: Jenkins (cherry picked from commit ee4ddf428e2ef85c710e1851ab9b9e7a2316d51b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89426 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-25tdf#129553 sw_redlinehide: fix replace of paragraph breaks with $Michael Stahl
The problem is that in the special selections that replace paragraph breaks, the start and end node are actually different, hence have different text frames. (regression from 5e81b966778d82692b4763d892b457186a7f269d) Practically the end content index is going to be 0 typically which doesn't need mapping, but not sure if that's guaranteed anywhere. Change-Id: I77c95c2f3e55edcc7aca6f4540cae90b3be5d79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89050 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 83122add64ecbf0fd3ba30368d5d87bde3dac278) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88959 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25tdf#130760 Fix crash when clicking link to other slideSamuel Mehrbrodt
Change-Id: Ie8b0cfb852fe1abc49b80b1d2d9d2c3be1241701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89332 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 5e8b6d3b721ba8730bc7a5b335418340e3f89c3e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89285 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24tdf#130817 RTF doesn't set custom footnote stateJan-Marek Glogowski
RTFDocumentImpl::dispatchDestination detects the custom footnote and even sets NS_ooxml::LN_CT_FtnEdnRef_customMarkFollows in the character attributes of the context, but that is at least not handled in the DomainMapper later on, so we can't check for m_pImpl->IsInCustomFootnote() here. Change-Id: I26c02ea16d0e75ed5bfde0cda9e0c6a2d30261a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89240 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 38306ea92560c82b0d70bdc195267549a8bab830) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89143 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24tdf#125682 sw: don't insert empty page before first page with even numberMichael Stahl
This mostly reverts commit 14bb680949b47332d2921cc68f75340b31ad5c32 and replaces it by a hopefully better approach: if the first page in the document has an even number, it will become a right page, and "toggle" the document so that even pages are right pages and odd pages are left pages. This is closer to what Word does; the tests adapted in the above commit were actually regressions. Add a new function IsRightPageByNumber() to determine how the page number offsets should be interpreted. Also make it explicit that even/odd and right/left page are no longer synonymous by renaming various "Odd" variables. Historically documents that start with even page number didn't work well anyway; before the above commit you'd get a left page followed by a left page followed by a right page, which is clearly nonsense if the page style differs between left and right pages - so hopefully we can do without a compat setting for those. There is still one situation where an empty page is inserted before the first page: if the page style is "Left Page"; this appears to be impossible in Word so we'll have issues exporting that to Word formats anyway. Testing: Writer pre-commit; LO 5.4/OOo 3.3: 1.odd -> right, 2.even -> left 1.even -> left, 2.odd -> right + inserts a blank page on the right after reload: 1.even -> left, 2.odd -> left, no empty page Writer w/ commit; LO 6.0+: 1.odd -> right, 2.even -> left 1.even -> left, 2.odd -> right + blank page as first page (right) after reload: 1.even -> left, 2.odd -> right + blank page as first page (right) Word: 1.odd -> right, 2.even -> left 1.even -> right but left style, 2.odd -> left but right style [technically uses terminology even/odd instead of left/right, but if mirrored, the "inner margin" is always the same and leads to interpretation of left/right] Writer and Word appear to agree on inserting empty pages on SwFormatPageDesc items/Word section breaks: both even-ness of an explicit page number and "Left Page" only page style or explicit even/odd section break may insert empty page. A useful improvement would be to detect in Word import filters that the first page is even numbered and then invert the mapping of all of the page styles, i.e. odd header/footer->left instead of right, and if mirrorMargins, pgMar left -> inner instead of outer. Change-Id: Ibed0dbf888c120a3a7d11892f40d07ffb5bc0b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88978 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 509a02aa96f6d7620cb0bf06c20b3bfa0641be92) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89047 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-24Resolves: tdf#129446 explicitly pass the mouse event windowCaolán McNamara
instead of letting it pick the main-window as the event window Change-Id: I953968025717ac5ba6f41e8f2db90c9f4d24800f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88954 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24Resolves: tdf#130762 honour "wrap" in FormattedFieldCaolán McNamara
Change-Id: Iefd9a537aa358eab179cf6f0eeb6f80a9a77284a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 20c08e47f7c156a4726194215b389f4d0b165904) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88953 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24tdf#130814 preserve context before page breaksJan-Marek Glogowski
... and add a comment, so nobody tries to move these again. Change-Id: I79e6f7a1538d0839fd525870439facef3218ec65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89239 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 70a9c644c63248719f1f4248e288df7ee06635cc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89142 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24Update git submodulesStephan Bergmann
* Update helpcontent2 from branch 'libreoffice-6-4' to 5521fc8d7175abd8fe2b457c677c6fab38114778 - tdf#130426 Update documentation for Basic Chr and ChrW functions ...for <https://gerrit.libreoffice.org/c/core/+/89090> "tdf#130426 Support Basic Chr(&H8000), ..., Chr(&HFFFF) again" Change-Id: I425a55ba1b055f94d993bb99c5412cc0414dc48d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit bf2dff69f84ad28836924d3bf311910248aca1f9) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89126 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-24Postgresql native, fix readLogLevelFromConfigurationJulien Nabet
With: osl_getModuleURLFromFunctionAddress( reinterpret_cast<oslGenericFunction>(readLogLevelFromConfiguration), &fileName.pData ); The method retrieves the path to libpostgresql-sdbc-impllo.so, eg: file:///home/julien/lo/libreoffice/instdir/program/libpostgresql-sdbc-impllo.so but then instead of retrieving path + "postgresql-sdbc.ini" we obtained ".so" filename + "postgresql-sdbc.ini"=> libpostgresql-sdbc-impllo.sopostgresql-sdbc.ini Regression from 1bdb2b6f06c556b9af91dba4f29f3ac73190b09e author Noel Grandin <noel@peralex.com> 2013-11-04 13:51:21 +0200 committer Noel Grandin <noel@peralex.com> 2013-11-11 11:21:25 +0200 commit 1bdb2b6f06c556b9af91dba4f29f3ac73190b09e (patch) tree 1d941e17952cd891f5309fd862215dd09a84b001 parent 2f2416ff060c780ad87b4d3979112f52da2ae902 (diff) remove unnecessary use of OUString constructor in CONNECTIVITY module Change-Id: Ie7be4b1078760f94d34dd1f6cb9932bd7fa70962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89303 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit abf44a9ddd084952bde4609e3f6d386f7916b68a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89275 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-24tdf130839: Corrects second level left margin in SmartartGülşah Köse
Change-Id: Ifec339759427336fd53012e0a8a906d240be9654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89085 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit eeaa7aba6e7ace8b69d7056645b15be2f996d8fb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89277
2020-02-24tdf#130274 sw_redlinehide: fix ChgAutoCorrWord() if replaced text ...Michael Stahl
... is fully deleted. This crashes on English text with 'i'->'I' substitution. The assumption that there's some part of the found text that is not deleted is only correct for the case where tracked changes are hidden, but not when they are shown. (regression from 9926ea7dd07f1f3d012ddf97941a42bb7fa5717d) Change-Id: I0e81494659ea7e187101a703f64483dd68c73d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89151 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit b7922b56e2dcf1dc1abbf5574bcb672068fa8dbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89135 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-24Sifr: fix for tdf#130885: missing Slide Layout iconsrizmut
Change-Id: I96ae88b4e5c4fdfbc3b2e51ec342f7c5321eec58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89307 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit a9748a444e7a295a235f2db5a217884ccb4805c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89276
2020-02-23Breeze: Add many Base iconsrizmut
Change-Id: Iff8d95e7a5d18314420f5ef6437c4a9252717a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89297 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 749728631a5dfbdba06d467ba8664e971d1c8bc8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89273
2020-02-23Breeze: FIx for tdf#130879 (missing spacing char icons)rizmut
Change-Id: I06cec9c95dd803e4816ca7ef2f280802250e0511 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89294 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 9ed2845c964819b5bce42c2ea8d8a6e57f9c204b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89272
2020-02-23Breeze & Sifr: Fix for tdf#130875: add Envelope Orientation iconsrizmut
Change-Id: Ib76239b8259651367ca591b012a25abd89156231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89292 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit cf04fc4baac9dbade930259c5cbbca7e0f8db14d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89271
2020-02-23Breeze, Colibre. Sifr: Fix for tdf#130871rizmut
- Breeze & Sifr: Make dark previous light background Change-Id: I8bbb7ab7ea9e3dbcc60da6332fd82790fe9db73b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89260 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 5e258cace6ebe7053c50f2e3450290f23aa4084e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89270
2020-02-22tdf#128849 -- Add Sifr (Dark + SVG) to the icon theme listrizmut
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89243 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 4617a5b7ded7f5d0c67087d204e05a991a50ee41) Change-Id: I314f925c54a5ed30cd74e4fbbfba065a1b70c947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89145 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-02-22Sifr: Fix for tdf#122488 & tdf#130864rizmut
- tdf#122488 : Fix icons for insert row/column - tdf#130864 : Fix slide transition icons Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89246 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit ee8914cd0bf017e2d294a6d5d4f52587c0a8aef4) Change-Id: Ic779289ea6958abf62c1c2033bf6e5df5b3311d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89267 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-02-22tdf#130827 Qt5 report frame-relative cursor posJan-Marek Glogowski
Qt5Frame::GetPointerState expects the cursor position relative to the frame position. Change-Id: Icaf7dcd8fc80d712f5138a9f9b843ccf345c5543 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89244 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 4fe30879af391c32074a003a7a6ddd45431d212a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89268 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-22tdf#130831 Qt5 don't blit damage to empty imageJan-Marek Glogowski
This prevents the crash, but I'm not sure having an empty buffer image at this point is correct. But it doesn't look like anything is missing in the dialog and a crash is definitly worse. Change-Id: I7d0330b4e4a7ca64655a51c226e425e53ba12118 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89203 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 813cde918338bccc4f711230616340cad2c1d4a0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89140 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-22tdf#130499 Qt5 no qApp == main threadJan-Marek Glogowski
If there is no QApplication, we can ignore the GUI thread. Change-Id: I0d2faf4799d493ad0b6074b40242c443d4bc43dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89241 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit c6fb366e05370af553af2130b370909ed4495cff) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89141 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-22tdf#130841 resize to client size after SetPosSizeJan-Marek Glogowski
This fixes the hack of the native menu bar with a smaller client size in relation to the frame geometry. Eventually this should be replaced by proper mnTopBorder usage, but this currently isn't working. Change-Id: Ib5825d9c8f77e463fcb086e0373228fe91d8705a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89202 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit b26ca5b13733b46c2df0787502f885e15b390956) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89144 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-02-22Sifr: Fix for tdf#125510 missing highly visible iconsrizmut
Change-Id: Ic9d7a0291c6f1105d16d694d9dc8ab619d9f5ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89245 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit fef40fd13ec1739f5308d1ff3bcc2291e7a5d96f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89266
2020-02-21tdf#130573 labels exchanged in export to BMPNoel Grandin
In the commit below, I removed the 1-bit dithered output, so restore it. regression from commit b5699cd01b6a52906880c107bac6f3802ea7353d Date: Wed Feb 8 16:18:32 2017 +0200 convert BmpConversion to scoped enum Note that this bug has been around since LO5.4 which means that anyone who has adjusted their setting in officecfg/registry/schema/org/openoffice/Office/Common.xcs with key BMP runs the risk of having that setting now revert to its prior (documented) meaning. Change-Id: Ibbda8aefbac261ff37ffab7223714f5d0343c692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit f7323482ae38c5c4bc39edeea4d1a6e282f896a2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88794 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-21tdf#130799 DOCX import: fix missing inside vertical bordersSzabolcs Toth
caused by incomplete handling of tables with 1-column rows with merged cells. Have to check the rows below current to see if they contain also one cell, therefore form a column, or more than one cell, in which case do not remove vertical borders. Regression from commit: 8a2eb40abbd52d960dd21308157186be0ca9dd3d (tdf#129442 DOCX import: fix right border of 1-column tables). Change-Id: If9ca7ccd42255e78c61b6271e19262ab5cc8e439 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89081 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 111db716c23f9f8450eda58c13dd2423770fd15e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89134 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-6-4' to 0891e60ab601e2cfdf9c7a142c9a3538f7df01fa - Remove very old unused CSS Change-Id: I8af3443fb8db832ac2fc9a88dfb6fd779d3475ed Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89163 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 197930c8b95d59a9ac099b58672fa66e6d87bca4) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89139 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-21tdf#95495 DOCX import: fix inherited list level of custom stylesSzabolcs Toth
in DOCX export of MSO 2003, 2007 and 2010, where ilvl and outlinelvl settings are missing, based on the settings of the parent styles. Change-Id: I01d239db505d46a89d7f3b9118ef0b55697bc7fc CO-Author: Balázs Nádasdy (NISZ) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87328 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89216 Tested-by: Jenkins
2020-02-21tdf#130426 Support Basic Chr(&H8000), ..., Chr(&HFFFF) againStephan Bergmann
...after it had been broken by d5b7627a0e738c0866b819910153b96b611813f8 "tdf#62326 - Macros: Converting Hex strings of negative value". The corresponding help update is <https://gerrit.libreoffice.org/c/help/+/89100> "tdf#130426 Update documentation for Basic Chr and ChrW functions". Change-Id: I5f08b1ef907d840b491315a1f445f729b4999d0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89090 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 5fc8b470f22bc7a8a5dc9a6bd86a591090abfcf3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88965 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-21tdf#130776 Show the bullet on second level in smartart.Gülşah Köse
Change-Id: Ie35867862d30d490a97dc6f245b50c7311dafe50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88993 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit 7865c662a4fdc9dc07f59d6ecd76b9c56d0020ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88962
2020-02-20update creditsChristian Lohmaier
Change-Id: I35d24b2ace80622fc81935039a833121f1da2795 (cherry picked from commit be3de666fd452e5c9d61411ecd9d4815a99419b3)
2020-02-20update creditsChristian Lohmaier
Change-Id: I21a49cb649ebdc6b8af50f0b92decb77887e721c (cherry picked from commit 52ee72a0e5ea6e590a98d3388e1cf12fa75583b6)
2020-02-20tdf#129529 sw_redlinehide: infinite loop in SwLayHelper::CheckInsert()Michael Stahl
The bugdoc has this in meta.xml: meta:page-count="819" meta:paragraph-count="302" ... for which SwLayHelper::CalcPageCount() cunningly estimates a maximum of 0 paragraphs per page, and at that rate an infinite number of pages are required... Not sure what a reasonable minimum should be, paragraphs could be 16 pages long even with 64k limit, but it does appear unlikely. (regression from 7e8b4756d95057f069467b34e7849f9354856578 which disabled the use of the layout-cache in the bugdoc) Change-Id: Icd9ab145cc2f0714b50de9b5b4a1ef10ac1d49a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89106 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit a9f2f4b4c9e1fa4e4c4a69517c31d0b8e2063f01) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88964 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-20Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-4' to 862fedc0284368cd404a9157d20dda48f09f21f2 - another update of translations for 6.4.1 rc2 Change-Id: I3be9f0c9e9dcb3d45e0900ab788aebc542b72a92
2020-02-20tdf#130794 qt5: Actually, ignore non-spontaneous QEvent::ShortcutOverrideMichael Weghorn
In fact, the assumption in commit 034f56015c1c7a61faede33fb5306f63b5585632 ("tdf#126785 qt5: Ignore external QEvent::ShortcutOverride") was a fallacy and it's exactly the other way around: "Normal" typing leads to "spontaneous" events of type QEvent::ShortcutOverride, since those originate from outside, are triggered via X11 events or Wayland equivalent, and the non-spontaneous ones are the additional ones that happen when e.g. the Orca screen reader is enabled. In a short test, no non-spontaneous QEvent::ShortcutOverride ever occured when using LibreOffice a bit with Orca disabled on X11 or Wayland (and on Wayland also not with Orca enabled, since Qt accessibility is broken there, s. QTBUG-73945 [1]). (Side note: In a quick test with Qt 5.12.5 and Plasma on Wayland, 'xcbSourceDispatch' from Qt library's qxcbeventdispatcher.cpp was also used in the Wayland case to when processing the keyboard events). [1] https://bugreports.qt.io/browse/QTBUG-73945 Change-Id: I1be1977e67f84fa657f6fc197e0b91822b6a3a2a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89073 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 69e708868f6046cada955a16bca966370ce3218a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88960 Reviewed-by: Katarina Behrens <bubli@bubli.org>
2020-02-19Optionally generate PDBs for external libsJuergen Funk
also for C# Enables pdb generation for symbol builds, for: - cli_basetypes.dll - cli_cppuhelper.dll - cli_uno.dll - cli_ure.dll Not covered are: - cli_oootypes.dll - cli_uretypes.dll ..as sadly climaker generates those, and can't produce PDBs. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87727 (cherry picked from commit 1bbabd67720d6d2cfcca15d811c625562fcffad6) also for libxslt.dll Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87967 (cherry picked from commit 98c7c52e30a921a1bde3e4b2aa8c240d95ed577d) also for libxml.dll Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88156 (cherry picked from commit 52292c374c3a6a5b4d9c6ced616b0ddd505a5298) also for nss Enables pdb generation for symbol builds, for: - freebl3.dll - libeay32.dll - nspr4.dll - nss3.dll - nssckbi.dll - nssdbm3.dll - nssutil3.dll - plc4.dll - plds4.dll - smime3.dll - softokn3.dll - sqlite3.dll - ssl3.dll - ssleay32.dll Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88673 (cherry picked from commit 54acab919e7c7c5d60fc697bda54278861ac250e) all above Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> libxstl.dll: Reduce code when symboles enabled Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88157 Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 127d8c2abcae44869458b39a77f48c93bff8c327) Change-Id: I9db843a638cf9091fa49b21e27dcb578f98e95fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88933 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-19tdf#128921 tdf#130341 tdf#122053 qt5: Native PopupMenusMichael Weghorn
This implements native PopupMenus for the qt5 VCL plugin, which not only gives them the native look and feel, but also makes context menus faster (tdf#128921), accessible (e.g. to the Orca screen reader, tdf#122053), and makes them work for a case in Base's relationship dialog where entries in the non-native context menu were not selectable/clickable (tdf#130341). For now, this always shows the popup menu at cursor position, which can be changed by taking the Rectangle passed to 'Qt5Menu::ShowNativePopupMenu' into account if there should be any need. Change-Id: Ie52cbc682acacb92716ff51e8bf7f1ab07d34cf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88512 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 1e0b16f8695498e4eea7c2208aabf7e7664ce749) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88491 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-19tdf#130404 python3: add new windows .pyd modules for 3.7Michael Stahl
Unfortunately forgot that in b10be5d48433076f0b7238d818020f708553e114 Change-Id: I59043a576c45f9329a3fad9a5d50e7fefa901934 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88977 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit e62b9937ed33388055560ca0710990742b530aec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88950 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-19Resolves: tdf#130370 Do not increment sheet-local name on cut&paste / moveEike Rathke
This is a combination of 2 commits. Resolves: tdf#130370 Increment sheet-local name only for moved cells Probably that piece of code is not needed at all anymore since moving entire sheets and their names is handled differently nowadays. Needs further investigation. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88898 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 180fef2a54207555c39fb63ead5e66ba3a71a0cf) Related: tdf#130370 Let cut&paste/move of a sheet-local name reference ... ... reference the original sheet-local name instead of a same name on the destination sheet. In bugdoc https://bugs.documentfoundation.org/attachment.cgi?id=102780 that is the case when cutting Sheet2.B3 and pasting somewhere on Sheet3. That yielded formula =value with result 3. (after the fix of commit 180fef2a54207555c39fb63ead5e66ba3a71a0cf, before it was #NAME?). Now it yields the expected formula =Sheet2.value with result 2. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88939 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 0c6bf98cd94307ef7b0896e6643be6161691f9c9) d92778ea41544583e885eaccfbf82c26762925a5 Change-Id: I2ac115c18354371d0abbfc6cc972d16edcb41021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88946 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-19Resolves: tdf#130756 null deref in empty treeviewCaolán McNamara
Change-Id: Ie43081d5c1feb655ea1479476375ee7381f0a0ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88947 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-18Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-4' to bf63f313ef100e20d4c7e1f74ea90fc8f9b6387e - update translations for 6.4.1 rc2 and force-fix errors using pocheck Change-Id: I01b679e2a76c170a7f07a619cb0623cd170034fc
2020-02-18sw: fix splitting text frames wrt. footnotes in followMichael Stahl
When the simplified (thanks Vasily) bugdoc is loaded, it has 2 pages and the last text frame 6 on page 1 has N lines, but after hiding tracked changes and showing them again, page 1 has N-1 lines, the last line starting at offset 1064 moved to the follow frame 7 on page 2, and this is the only difference from the state after loading. Frame 6 is formatted exactly 3 times; the difference between the 1st and the 3rd time is that footnote number 8 (footnote frame 34) doesn't exist yet the 1st time, but is on page 1 at the 3rd time. This reduces the space available in the body frame from 14040 to 13817, and SwTextFrameBreak::IsInside() finds there's not enough space for the last line. Interestingly the sw_redlinehide didn't change anything here; this reproduces in the same way back to OOo 3.3. There's a few obvious ways to try and fix this: a) The footnotes that are anchored beyond the end of the current text frame are moved by RemoveFootnote() called later: 4 in SwTextFrame::RemoveFootnote() at sw/source/core/text/txtftn.cxx:508 5 in SwTextIter::TruncLines(bool) at sw/source/core/text/itrtxt.cxx:375 6 in WidowsAndOrphans::FindBreak(SwTextFrame*, SwTextMargin&, bool) at sw/source/core/text/widorp.cxx:338 This could be done earlier, in IsInside(), which already tries to do 2 other things to get more space, so it seems plausible that footnotes which are known not to be in the frame (including the line that doesn't fit) could be moved off the page. b) An approach similar to commit e37ffdd118da2d21c5e78e8c7b67252d0d1adc8c "tdf#125685 sw: disregard footnotes in follow table on table split" would be to temporarily add the footnotes anchored beyond the current frame to the available space, and leave them to actually be moved later. c) When RemoveFootote() is called and it does move a footnote, invalidate its anchor text frame so that it gets formatted again. This seems to have the highest risk of introducing loops though. Let's try out a) for now and see how it works. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88714 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 391613785ae6fbb735cf7a86ea2f6a93161a8769) sw: add test for 391613785ae6fbb735cf7a86ea2f6a93161a8769 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88882 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 6c53c86f3db0559eeb2bbb69051a8b6fb2863b11) Change-Id: I54b59637b79d67f5eca61f11bd575145f244381f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88691 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-18Update git submodulesAndras Timar
* Update translations from branch 'libreoffice-6-4' to 5b25ea8b2ac8175ff1974f56d84ed31fcd154d56 - Updated Slovenian translation Change-Id: I3238c05476a9930a43361d886a56cfc82bbda757
2020-02-18tdf#123971 don't clobber entire RowHeight range on updatesThorsten Behrens
Use start index from current loop variable, not full range; otherwise we're always clobbering values from (possibly higher) upper rows. Change-Id: I3add7c2358710f4ae3927e7b0a1c1ff544965a03 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88785 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit f55140c7376c330bcdac071592aada75e8781e19) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88787 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2020-02-18tdf#126785 qt5: Ignore external QEvent::ShortcutOverrideMichael Weghorn
For some reason, an extra external QEvent::ShortcutOverride event is triggered when a key is pressed and e.g. the Orca screen reader is enabled, which would result in duplicated input when handled as key input event as well. Therefore, ignore those ShortcutOverride events that are "spontaneous", i.e. "the event originated outside the application (a system event)". [1] [1] https://doc.qt.io/qt-5/qevent.html#spontaneous Change-Id: Ibccacb69c31d4d7ebd512c704f0e4df978c5281f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88852 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 034f56015c1c7a61faede33fb5306f63b5585632) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88790 Reviewed-by: Katarina Behrens <bubli@bubli.org>
2020-02-17Resolves: tdf#130123 let the expert config columns be resizableCaolán McNamara
Change-Id: I08572bfe92c99d6e2e6b8ea27856817a6dddf1f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88795 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-17tdf#130708: Firebird: fix wrong precision and scale for DECIMAL and NUMERICJulien Nabet
See https://firebirdsql.org/file/documentation/reference_manuals/fblangref25-en/html/fblangref25-datatypes.html Change-Id: I2377679bb925425ceb0bf80c5309005421fe2c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88778 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 4605dfa29649864638187940de4d1064ff056ac8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88786 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-17icon-themes: Backport from master to 6.4rizmut
Change-Id: Ia972e95e88b4470576571e20221316c2abc93442 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88768 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-02-16Update git submodulesKris van der Merwe
* Update dictionaries from branch 'libreoffice-6-4' to 2e25022c7405dc29aab47f26369bbcc21fbe6e68 - Updated Afrikaans dictionary Change-Id: I778714df63b70d9beacc2e48dc538afe88fd1c5f Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/88705 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-16Colibre: Update print related icons & mail merge toolbar iconsrizmut
Change-Id: I4f7e058029e53895dce71db829721c9e4cd224d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88769 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit c3fe53bd456e7e4ee7ea6ce22d653987ca510254) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88703
generated by cgit (git 2.34.1) at 2024-05-22 09:03:47 +0000