summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I4be3bce06e24fd10fef669e969788336bd2a1df6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101115 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I8286d532a4a1fdf964687991d6451caa49306204 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101119 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I6709fd9166ae0ddf4a50b4ad56a63e2c1a7192a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101109 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I8681bd1be07fe44ab017bce65807b9bf0afa7b42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101107 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typoAndrea Gelmini
Change-Id: Ib0e423f26428f5311d5f067177bd9457347e4971 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101111 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Silence some clang-cl loplugin:stringstaticStephan Bergmann
For one, do not warn about global declarations in included files, as generally not all uses of the variable are seen to decided whether it would be good to replace. That covers cases like > In file included from dtrans/source/win32/dtobj/DataFmtTransl.cxx:26: > dtrans/source/win32/dtobj/MimeAttrib.hxx(29,16): error: rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic] > const OUString CHARSET_UTF16 ("utf-16"); > ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ For another, do not warn about variables whose pData member is used. That covers cases like > sal/osl/w32/procimpl.cxx(347,20): error: rather declare this using OUStringLiteral/OStringLiteral/char[] [loplugin:stringstatic] > const OUString ENV_COMSPEC ("COMSPEC"); > ~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~ Change-Id: I75c1048098b63164bdb583695951f73964cb24f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101134 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-21fix unit-test with non-pdfium buildNoel Grandin
otherwise testSwappingPageNumber will crash accessing out of bounds element in vector. Change-Id: I07499e79d523931e1f3cc02a5150f033e1ea9578 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101094 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-21rhbz#1870501 crash on reexport of odgCaolán McNamara
where SdrObjects in a list have no navigation position set a regression from 450cd772aa734cfcb989c8cedd3c0a454db74a34 Fix fdo#64512 Handle xml:id correctly on multi-image draw:frames this just reverts that and adds the test case that crashed Change-Id: I1a49dab9578699c42fe845e8ec42de40159dec3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101074 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-21loplugin:stringstatic (clang-cl)Stephan Bergmann
Change-Id: I024c7437e876459e22a6f541405b87ac13e7dc99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101135 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-21cid#1466205 Logically dead codeCaolán McNamara
Change-Id: I965a998f9f1f08ba170a7ef0745d1c0da634c14a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101091 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-21cid#1466207 doc as false rather than intentionalCaolán McNamara
Change-Id: I3541fe1278f40e7b597ea1c46afd32987f84e40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101090 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-21cid#1466204 silence Unchecked return valueCaolán McNamara
Change-Id: I9ca7fe0c01c965457367df002c7e27aaf688c6ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101089 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-21-Werror,-Wunused-variable (clang-cl)Stephan Bergmann
Change-Id: Ic783ab10a3bc2139eef65351d515814374431e59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101131 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-21loplugin:simplifybool (clang-cl)Stephan Bergmann
Change-Id: I88f659da3d80bf83f544edd89933b582f06b2556 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101130 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: Ic3dd9e648d8006c68eb31f9577ad74e6dcbb1b1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101102 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: Icbe489976053571825aac7a95fdb53eae4907ec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101112 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21Fix typo in codeAndrea Gelmini
Change-Id: I77720baeb8d379589b9daee4ca10db56324051fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101123 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-21fix setting clip region for new Skia graphics objects (tdf#135487)Luboš Luňák
Set the clip region only after possibly creating the surface, because creating the surface sets the default clip region. Change-Id: I2c344397336fa487f55553f49e40704ef05b2100 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101077 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-08-21Pass -fno-lto unconditionallyStephan Bergmann
At least when building the libreoffice rpm on Fedora 33, the relevant -flto... flags are passed in via the global CFLAGS/CXXFLAGS, and no --enable-lto configure option is given. That caused this library to be built with LTO there, which in turn caused at least aarch64 to fail the %check step with > ### unexpected exception content! failed > ### unexpected exception content! failed > ### unexpected exception content! failed > exception test failed > oneway exception test failed > exception occurred: error: test failed! testtools/source/bridgetest/bridgetest.cxx:1176 > > > error: error: test failed! testtools/source/bridgetest/bridgetest.cxx:1176 > > dying...make[1]: *** [testtools/CustomTarget_uno_test.mk:25: workdir/CustomTarget/testtools/uno_test.done] Error 1 > make: *** [Makefile:166: CustomTarget_testtools/uno_test] Error 2 The easiest fix appears to pass -fno-lto unconditionally: For one, both GCC and Clang appear to support it since before our baseline versions (GCC: baseline 7.0.0, presumably supported since <https://gcc.gnu.org/git/?p=gcc.git;a=commit; h=d7f09764d7bc66b9997c811c22e11efc87b44792> "Merge lto branch into trunk" in releases/gcc-4.5; Clang: baseline 5.0.2 (at least on Linux), presumably supported since <https://github.com/llvm/llvm-project/commit/ 10d0868efb320fc33ced13b0abeea7070cd41635> "Driver: Support -fno-lto" in releases/3.0.x). For another, the other (few) places in the code that check ENABLE_LTO appear not to be relevant at least for that Fedora 33 rpm build, so there appears to be no incentive to make that build configure --enable-lto as an alternative to this fix. Change-Id: I4735403660e57ef73b99d6a8cc5945c6d8e2af73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101129 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-21Use [[nodiscard]] directly in LIBO_INTERNAL_ONLY codeStephan Bergmann
Change-Id: I31df55c7869fc4f0d37a4189d4b2f10e0a4f2bc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101095 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-21use fastparser in SdXMLStylesContextNoel Grandin
Change-Id: Idd15d117d71e607691bec9911ff0cc194ca5ce01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-21use fastparser in SwXMLMasterStylesContext_ImplNoel Grandin
Change-Id: I420312d8f58a42999c7d6c3048c391ff1f44a039 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101092 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-21Sukapura: update font color & 3d Shape color iconsRizal Muttaqin
Change-Id: If791dadbdbc423390b4add6086cf1fe12cd80339 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101126 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-21tdf#135028 icons for Style InspectorRizal Muttaqin
Change-Id: I44bb391d6b2df48bde6df5f5e44fce8a9c48f0a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101124 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-21Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d36d5b43e7274f678ce5fad89b42495fa6aed7e7 - tdf#122148 Clarify master slide objects visibility Change-Id: I7aeaad92aa6d46e82d83312808b0d9a542b0e76e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/101082 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-20cid#1466206 Uninitialized pointer fieldCaolán McNamara
Change-Id: Ib694d3a43dd9bc5a430124d9c95128c4c15e3c57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-20Use OSL_UNREACHABLEStephan Bergmann
...in those places that used some code conditional on ENABLE_LTO to work around (non-)unreachability wranings. This removes all uses of the ENABLE_LTO C/C++ macro, so it can go completely. Change-Id: I67544986cb2d3fcd8051caf87c5129bd1086408c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101087 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-20tdf#123390 DOCX import: fix SIGN formulaLászló Németh
Convert SIGN(x) to the equivalent, but portable Writer formula (0 < x) - (x < 0). Note: this is a temporary conversion, which supports only 1-level nesting of function calls. Adding SIGN to Writer core, it will be possible to remove portable conversion later. Change-Id: I88853fe865808427c966b8570a052b101fecdac0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101085 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-20Follow-up: tdf#132105 COUNTBLANK() count empty strings also in array/matrixEike Rathke
For Excel interoperability this somewhat is a *visual* blank, unlike ISBLANK() empty strings are counted as blanks. An empty string in a matrix can be either a formula result transformed to matrix, or literal input in an inline array. There's no way to differentiate the origin. Change-Id: Ib799e95517d95e1a7c28fc4335bd0040f3629ad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101083 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-08-20Resolves: tdf#132105 COUNTBLANK() handle external references and array/matrixEike Rathke
Change-Id: I6f39c67a20c0d683da9f14775ce8cbddf2f92349 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101079 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-08-20use fastparser in SvXMLNumFormatContextNoel Grandin
which requires making SvXMLStylesContext capable of doing both fast and slow-parser paths. Change-Id: I57428b10ac2d67bc233cc978c9a0c0c3755d60e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20Base addon toolbars on the regular ToolBarManagerMaxim Monastirsky
ToolBarManager already supported addon buttons because of the toolbar merging feature. Besides the cleanup, this gives access to addon devs to all toolbar features like aliases or style buttons. Change-Id: I7adf830ac71c7f5354a924d60a531d8001e37571 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101071 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-08-20tdf#132940 Crash in mergedlo!vcl::Region::operator=Noel Grandin
We had a SdrPageWindow accessing a SdPaintWindow that had already been freed. Turns that SdrPageWindow can be "patched" more than once given enough stuff going on in writer, so make the call sites restore the previous state as the stack unwinds. Change-Id: Ia1ef5c9b2f818b7873e8e739c9cdf257554e403a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20loplugin:unusedmethodsNoel Grandin
Change-Id: Ic3690d7f2a075d47ffed3db03ee6895ebdab441e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101070 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20loplugin:singlevalfieldsNoel Grandin
Change-Id: I4cd20d1a449196b68c7dbe153c60e68b9563bea9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101049 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20tdf#129542 the control is already anchored to header/footer contentCaolán McNamara
DisconnectFromLayout has unset its old anchor, if we don't insert it somewhere then its old anchor is null and we crash eventually. Seeing as we're already anchored into header/footer content, albeit only in the first view of a header/footer, then allow reconnecting to layout in that mode Change-Id: I0be4d167ee7d7b932318a1318954bed0da3a4fc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100686 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-20clean-up to commit: a8950d08a33e7aded31d4591c98a03d1edf8c5a4Tünde Tóth
Change-Id: Icfe1e3d7925a3e31fd8bc0185d6b898c61346766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100989 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-20add support for complex shapes in physics animation effectsSarper Akdemir
Makes it possible to represent complex shapes of LibreOffice in physics animation effects by closely approximating their geometry. Therefore enables more convincing animation effects. Change-Id: I807bbde92c143b8c96792b3d8bf9603a31216486 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100432 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-20make physics based animation effects importable-exportableSarper Akdemir
Makes physics based animation effects importable and exportable on content.xml. Uses one new xml token animatePhysics. Also adds a new animation preset called Physics Basic that is available under Emphasis animation effect category. Change-Id: I38b0511f973668655cff78becebe3f1e628d9083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100247 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-20tdf#135721 sw: fix SwSpellPopup::Execute() deleting flysMichael Stahl
Follow-up to ec579354af954867b829e7d08e4d752518c83728 : in 6.4, this is the location of the spell check menu code; not sure how to call this but it has the same bug... (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I0e6ce9c97d810f7c92dff320d403c986a947c266 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101073 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-20loplugin:virtualdeadNoel Grandin
Change-Id: Ib41d80d1e068d66edabdfb36061dd382dc34b04c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101046 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20tdf#135721 sw: fix spell check context menu deleting flysMichael Stahl
Kind of similar to e1629c210ad78310e3d48c0756723134a27b89df but the problem is at a higher level: SwTextShell::Execute() with SID_SPELLCHECK_APPLY_SUGGESTION should not DelLeft() + Insert() but just Replace(). (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I78487c7841ba22ccc6751240a8e55e08a86fba32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101014 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-20loplugin:constantparamNoel Grandin
Change-Id: I59a37e1d37fa749cba5159daa23fe663bcc55435 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101045 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20xmloff: ODF export of page style: don't export draw:fillMichael Stahl
... attributes on header-style and footer-style in strict ODF. Change-Id: Ic1af26b6112a5afbb70a82b29dbacd3dcec14ec3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101012 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-20sw: remove misleading initialisation from SwUndoInsLayFormatMichael Stahl
Change-Id: I5577b388b565cdab6dcf60721f0f90d2987dac05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101005 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-08-20use fastparser in StoredChapterNumberingRootContextNoel Grandin
Change-Id: I133f9885755ba594d8a136baa056f9ff96908a30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101018 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-20tdf#135187 DOCX import: fix table style at character formattingLászló Németh
applied also on paragraph level during import. Regression from commit 4d5c0eaf3e0d3d3bcd9e691fffee19b75f3d6631 (tdf#118812 DOCX import: fix table style preference – part 2) See also commit 5ac6f02fdc6015a5d78071570dee310febf95fc6 (tdf#105215 DOCX import: fix paragraph-length direct formatting). Change-Id: I14072c81fc4c54e376a004fa36ba76b56d2beb01 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100996 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-20use HighlightTextColor from Settings for thumbnailviewitem HighlightTextColorCaolán McNamara
so if an icon is selected, typically with a blue background, that the text is rendered with a matching color, typically white foreground Change-Id: I3397924ccf657a9d2bd3c03c51c339685c27d5ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101024 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-20Fix typo in commentAndrea Gelmini
Change-Id: Iacc4791157674fde0c2b76b024a7deceb2159e46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101011 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-08-20use fastparser in SdXMLHeaderFooterDeclContextNoel Grandin
actually, it can do both fast and slow parser paths for now, because it is used in a place fast-parser doesn't reach yet. Which means that I had to make SvXMLStyleContext also capable of handling both fast and slow parser paths. Change-Id: I24fd5bfb6603e93a5f752365c246ce47dabea8bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101017 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-08-12 16:57:39 +0000