summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-10-20sc: perf: avoid construction of collector for empty note columns.Michael Meeks
It is extremely common to have empty note columns; so shorten this path profile in: cool#7334 Change-Id: Ibfd550be1a5e8e98df8b4ede0d018c4f85300648 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158158 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: ucbStephan Bergmann
Change-Id: Ic3123585203ebcdf2fe791709d38551e7a326d04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158246 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: ucbhelperStephan Bergmann
Change-Id: Ib4b300e8b21f772c97dcb49d666f93d2821f0859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158247 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: unotoolsStephan Bergmann
Change-Id: Ia3722b27955e444b67a97c478739db696fa3dcaf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158249 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: testtoolsStephan Bergmann
Change-Id: Idc0de002b7ca4e370add311f91576adaaf354764 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158243 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20fix GBUILD_TRACE on cygwin, needs to have unix-style path for the logChristian Lohmaier
make's abspath function turns the path into windows-style, but that fails for appending to the log/the rule needs a unix-style path Change-Id: Ibb4a32bee10f7c69e8f57c1a771efc85ace283e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158238 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-10-20fix make GBUILD_TRACE=/path/to/log.json for non-macChristian Lohmaier
my previous patch to make it work on mac ( 4b67515418ee4f10071b3f0f2275ba37f32b0ae5 ) actually broke the timestamping for other platforms, as the date command no longer was treated as a shell-subcommand due to the lack of the additional $ to quote the statement.. Oups. But at least fixed within a year, people need to use it more! :-)) Change-Id: Id4e20fb11540824555ce4c04d3abed55be9185c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158236 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: testStephan Bergmann
Change-Id: I883d34c9562b48d987a16a0254272f3aeeb4bf5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158242 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: swStephan Bergmann
Change-Id: I85fff7ed6932c5fc196e18f24fa01074ba4837e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158241 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20tdf#157793 limit tdf#157635 fix to only larger palettesPatrick Luby
I don't know why, but the fix for tdf#157635 causes images with a palette of 16 entries to be inverted. Is this the only condition for masking out black pixels in non-transparent animation frames? Change-Id: I9550baab4dc4d9b75a21c8af2f6c0b5eb8e46c12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158214 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-10-20sw floattable: remove now unused FloattableNomargins compat flagMiklos Vajna
This was noop since commit 626fe9ab5ebebc4ef36e35f4aa597c03a3564d22 (tdf#157573 sw floattable: fix incorrect lack of left margin after table, 2023-10-18). Change-Id: I89a197313ac4ffbcff9bbff534e5411085282ac8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158237 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-20Typo in comment "af"->"of" in XReference.idlJulien Nabet
Change-Id: I99c52dcf7fe5db7226090c3685d27b2f333a16eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158235 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-10-20ofz#63374 avoid AbrtCaolán McNamara
Change-Id: I63e609e40a9453000a8f296f4b02f167902fd790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-10-20remove SAL_WARN in _setPropertyValueNoel Grandin
since so much code higher level code is now just asking for random properties and just catching the UnknownPropertyException for the cases where the object does not support that property Change-Id: I9198ec0c540252783015cffa088be30451f92c3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-20external/lxml: Fix --enable-python=fully-internal buildMichael Weghorn
After commit a4b4a90557f9fc1839fc0eb297f4c6a4e94c761a Date: Sun Jul 2 14:54:23 2023 +0900 lxml: upgrade to release 4.9.2 , my `--enable-python=fully-internal` build started to fail with Building lxml version 4.9.2. Building without Cython. Building against libxml2 2.9.14 and libxslt 1.1.35 Traceback (most recent call last): File "setup.py", line 207, in <module> setup( File ".../libreoffice/instdir/program/python-core-3.8.18/lib/distutils/core.py", line 108, in setup _setup_distribution = dist = klass(attrs) File ".../libreoffice/instdir/program/python-core-3.8.18/lib/distutils/dist.py", line 274, in __init__ warnings.warn(msg) UserWarning: Unknown distribution option: 'project_urls' make[1]: *** [.../libreoffice/external/lxml/ExternalProject_lxml.mk:26: .../libreoffice/workdir/ExternalProject/lxml/build] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:289: build] Error 2 and Julien reports the same in [1]. The above commit includes a patch to switch from setuptools to distutils. Possibly the distutils variant of the `setup` function doesn't know about the "project_urls" keyword argument (at least in our bundled Python version), so extend the patch to drop that from the `setup.py`. [1] https://gerrit.libreoffice.org/c/core/+/153863 Change-Id: Icfac9fb0a3c62d3b30c12bc23ddbc0f9b088d788 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158230 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: stocStephan Bergmann
Change-Id: Ic8c251b97f5e5bdf81599534384d86ac9904da53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158222 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20set accessible IndexHint in sdNoel Grandin
to avoid some more spurious SAL_WARN Change-Id: Iff1dfea4857e780d0b3739c7b1688eb7df243907 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158232 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-10-20CppunitTest_sd_png_export_tests: relax test even moreXisco Fauli
I misread https://gerrit.libreoffice.org/c/core/+/158181/3#message-f54ed5a8dcf1d68fea73ace5ff9851d3d5fe5a2f Change-Id: I31523af088f8fa83f43a8a49e449d27b0f230149 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158229 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-20Use getXWeak in toolkitMike Kaganski
Change-Id: I44a0ddd386ea6d262d6102b40f3e9837655068ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150877 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-10-20tdf#157590 sw floattable: avoid hang in the nested + row span caseMiklos Vajna
Regression from commit 905962db870e9d1cf1dcf3bd1be44c347cddafe1 (sw floattable: handle AllowOverlap==false in the layout, 2023-08-10), the document load resulted in a hang due to a layout loop. What happens is that SwTabFrame::MakeAll() first does a Split(), but the problematic row has cells with rowspans, and once this is combined with multi-page nested floating tables, we move all the content to the next page (we only leave a stub table frame on the old page), so the next time SwTabFrame::MakeAll() is called, we do a Join(), and this leads to a loop. The traditional Writer way here would be to add a loop control, but we can do a little bit better: nobody really asked for row span handling with nested floating tables, so just don't split rows with row span in this case, move the entire row forward instead. This is enough to avoid the layout loop, and a next iteration can still use SwFlowFrame::MoveBwd() / SwFlowFrame::MoveFwd() to split the complex row. The bug is fairly hard to hit, any naive simplification to the original bugdoc leads to a working layout. Carefully keeping the size of the document, it's possible to at least simplify the content of the table cells (while keeping their size unchanged), so we avoid half of the tables and half of the shapes for a faster test case. Change-Id: Ib14154200c45ecb7f59e85f9f4f1fe0124c4256e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158228 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-10-20Link Library_localedata_euro against salStephan Bergmann
<https://ci.libreoffice.org//job/lo_daily_tb_win/1555/> etc. recently started to fail with > localedata_an_ES.o : error LNK2001: unresolved external symbol __imp_rtl_uString_release > C:\cygwin\home\tdf\jenkins\daily_workspace\tb\build_master\instdir\program\localedata_euro.dll : fatal error LNK1120: 1 unresolved externals > touch: failed to get attributes of 'C:/cygwin/home/tdf/jenkins/daily_workspace/tb/build_master/instdir/program/localedata_euro.dll': No such file or directory > make[1]: *** [C:/cygwin/home/tdf/jenkins/daily_workspace/tb/src_master/i18npool/Library_localedata_euro.mk:10: C:/cygwin/home/tdf/jenkins/daily_workspace/tb/build_master/instdir/program/localedata_euro.dll] Error 96 Change-Id: I1440365f30bd876466de964f6bb313210e7a3928 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158227 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Link Library_localedata_es against salStephan Bergmann
<https://ci.libreoffice.org//job/lo_win_daily_symbols/1147/> etc. recently started to fail with > localedata_es_AR.o : error LNK2001: unresolved external symbol __imp__rtl_uString_release > C:\cygwin64\home\tdf\lode\jenkins\workspace\lo_win_daily_symbols\instdir\program\localedata_es.dll : fatal error LNK1120: 1 unresolved externals > touch: failed to get attributes of 'C:/cygwin64/home/tdf/lode/jenkins/workspace/lo_win_daily_symbols/instdir/program/localedata_es.dll': No such file or directory > make[1]: *** [C:/cygwin64/home/tdf/lode/jenkins/workspace/lo_win_daily_symbols/i18npool/Library_localedata_es.mk:10: C:/cygwin64/home/tdf/lode/jenkins/workspace/lo_win_daily_symbols/instdir/program/localedata_es.dll] Error 96 Change-Id: I8a6ef646df1fd8d26f3a8b2f84b098f9971ace2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158226 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20tdf#148952 sw: Add unit testVenetia
Change-Id: I151f3d59f924280311653de025560e6fd2a826c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157037 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: starmathStephan Bergmann
Change-Id: I964db94e75e19cb507508b15755e3595247b5524 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158221 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sfx2Stephan Bergmann
Change-Id: Ied8f0aff05ffd2f9e187fcb690789baf5fcf0c30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158220 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Revert change to Reference Mark behavior to avoid regressionMatti Tyrväinen
Hotfix for tdf#157287, unfixes tdf#81720. Setting the DontExpand flag would solve tdf#81720, but causes regression due to other code that depends on the old behavior. This patch restores the old behavior without reverting the UpdateFieldContent refactor included in 146941; testDontExpandRefmark is commented out for now. Change-Id: Ibaeacabec304473db63df9334e2fef46c6d9acc5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158059 Reviewed-by: Matti <matty@uef.fi> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: svtoolsStephan Bergmann
Change-Id: Ib4d0e05b802776c682676a7bdaebb5123f6c5013 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158224 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: svlStephan Bergmann
Change-Id: I31d46c2b75888474136ecd630fd3f817db189fb4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158223 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20CppunitTest_sd_png_export_tests: relax test a bitXisco Fauli
See https://gerrit.libreoffice.org/c/core/+/157763 Change-Id: I397adc22e29c595c3bfaf0331a1774f192f0fc85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158181 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-10-20dbaccess/source/core/inc/object.hxx unused since initial importJulien Nabet
Change-Id: Iad9c4f234833ce4c605040b9d0f9b86150791c99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158210 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: scStephan Bergmann
Change-Id: Ieed908bfa2cb6370ead922dfc00dbdb4f905f3cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158216 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: scaddinsStephan Bergmann
Change-Id: I964223021109dbafedc875ab5c016e0fdef411b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158217 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: sdextStephan Bergmann
Change-Id: I13d1279050de77e8ea054c6ee3a3bce97cec584b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158219 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: saxStephan Bergmann
Change-Id: I16c763164567293b096e132650c509cfc32fd407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158215 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: reportdesignStephan Bergmann
Change-Id: I5e45fd5d464db3cf038a844b955144649f980ba1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158208 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20tdf#86790: Add support for a word-style stylerefSkyler Grey
STYLEREF is a field type in Word which changes its content based on nearby paragraphs. For example, upon creating a styleref referencing "Heading 1" you will see the text of the nearest "Heading 1"-styled paragraph that is above the field. This patch implements STYLEREF in Writer as a cross-reference. By using "insert>cross-reference>styles" you'll be presented with a list of styles. Selecting one and clicking "insert" will create a field which has text from the "most relevant" instance of the style. To find the most relevant instance we first search up for paragraphs with the style, and if there are any we take the closest. If there weren't any, we search down for paragraphs with the style. This patch also updates our use of STYLEREF for chapters exported to docx by using it for all chapters not only those in headers and footers. This allows us to approximate more chapter field functionality even when moving between Writer and Word. Finally, this patch adds some tests for STYLEREF: - testTdf86790 tests that the "sample file with STYLEREF" document from tdf#86790 has the correct fields - testStyleRefSearchUp tests that the STYLEREF searches up when there are bits of text both above and below it - testStyleRefSearchDown tests that the STYLEREF searches down when there are bits of text below it only - testMarginalStyleRef tests that the STYLEREF searches from the page top when it is placed in a footer - testFootnotetyleRef tests that the STYLEREF searches from the reference mark when it is placed in a footnote Still TODO: - [ ] Update documentation - [ ] Implement reverse-searching (\l) and nondelimiter suppression (\t) - Probably these 2 will be in a followup patch Change-Id: I25dd7a6940abee5651a784b9059fe23b32547d6c Signed-off-by: Skyler Grey <skyler.grey@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157456 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-20sw layout xml dump: move SwAnchoredObject dumperMiklos Vajna
Next to the rest of the anchored object code. So it's more likely that it gets updated as SwAnchoredObject changes. Change-Id: Iff07da7a2679f4ea7b63ce18251140f4e46a0956 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158199 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: linguisticStephan Bergmann
Change-Id: I0866cdaffa7059c30a65373efcd37a91b1b6e63e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158205 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: ooxStephan Bergmann
Change-Id: Ic5bcb44fbe56804e23bcdfd039a77c010858ca02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158206 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: jvmfwkStephan Bergmann
Change-Id: I23ce970ad67047b0b22a9dda3dff047e5f59dff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158203 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: packageStephan Bergmann
Change-Id: I5d70d9291a64139bc2dc60c63173fef862a00f2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158207 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: i18npoolStephan Bergmann
Change-Id: If3eb4d8fb3068e26ce42c8cc751c2de38b5d04cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158202 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: salStephan Bergmann
Change-Id: If4a7951fd3f9f7f2e081e6b8ba482566260c3235 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158209 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20Extended loplugin:ostr: Automatic rewrite O[U]StringLiteral: frameworkStephan Bergmann
Change-Id: I0f17c569eddcdc30bfca4cdcd25cb05cf783ec23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158200 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-10-20wina11y: Drop now unused CMAccessible::get_String4Numbering etc.Michael Weghorn
`CMAccessible::get_String4Numbering` is unused since commit 2bf88c172c9c9d159344b95fb96073f4891a6c30 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Wed Oct 18 13:44:42 2023 +0200 tdf#157696 wina11y: Switch from custom to IA2 text attributes , so drop it. This means that `CMAccessible::get_StringFromAny` is then also unused, so drop it as well. Change-Id: I35abc94b2fc2ecec1789918fbf4ed6707a96c974 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158195 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-10-20tdf#114441 Convert use of sal_uLong to better integer typesAdam Seskunas
In ctrlbox.cxx, nCount and i were changed to sal_uInt32 because aFontSizeNames.Count() returns sal_uInt32. In valueset.cxx, nFirstItem and nLastItem are only used in a comparison with a value of size_t. They were both changed to size_t because nLastItem contains the product of tools::Long mnVisLines and sal_uInt16 mnCols where tools::Long can be 64 bit in some cases. Change-Id: Ib3f10cdf6ae81e96f28f13a0bb32699f26c8a0cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/157109 Tested-by: Jenkins Reviewed-by: Hossein <hossein@libreoffice.org>
2023-10-20Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to f7585dc09a544ff865dcf39f55cb81d77e9d73ba - tdf#155876 UI cmds Calc (05) + refactoring + Edit menu - Final Change-Id: I4ff166ba0d6d4d009eb97a8cdb3c361abf776612 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/158213 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-10-20lxml: upgrade to release 4.9.2Taichi Haradaguchi
* external/lxml/Wincompatible-function-pointer-types.patch: fixed upstream. * backport external/lxml/0001-Make-regexp-string-raw-to-correct-its-escape-sequenc.patch.1 from <https://github.com/lxml/lxml/pull/371>. Changelog: https://lxml.de/4.9/changes-4.9.2.html Change-Id: I8ea947b3b1fb30b9427d066bd41a5d4693ceedbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153863 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp>
2023-10-20tdf#157565 show tooltip if any parent window is the key windowPatrick Luby
Commit b69db38a38b09e158e8d46d8b717db85860ca874 caused tooltips to fail to appear if their immediate parent window was not the key window. So, look through the parent window's parent windows and, if any of those windows are the kwy window, show the tooltip. Change-Id: Icf1aed1144fdeac03b4b208de8ed8ee2db8ad4a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158212 Tested-by: Jenkins Reviewed-by: Patrick Luby <plubius@neooffice.org>
2023-10-20Do not forget to notify in cases when modified redline's start/end don't moveMike Kaganski
SwRangeRedline::SetStart/SetEnd call MaybeNotifyRedlineModification, which means that e.g. continuing typing at the end of the current redline would continue sending notifications. But as soon as cursor is moved (e.g. using arrow left, inside the current redline), the next modification is completely inside the current one, and would be simply deleted. In this case (and other similar), notifications weren't sent. This change tries to make sure that every such case is handled. In case of delete-inside-insert, when positions are equal, the current redline is deleted; MaybeNotifyRedlineModification is not called, to not crash. I don't know if this needs additional notification. Change-Id: I2a97354623a5a784928ce4e1f2c93606954bd11c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/158198 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-08-18 01:56:14 +0000