Age | Commit message (Collapse) | Author |
|
CMDOPTION_NONE is just ignored, so remove this parameter
Change-Id: If9de22a6b0522620a267cbc92b118f79e200d999
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152671
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I14f0ada21d328b3b6637709e403bfe973a7035b0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152670
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I8f68ecc7ccaecf84abbcda1bcdd65e2295baaf0f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152673
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
|
|
The bugdoc has a to-char anchored textbox. Changing the ancor type +
undo resulted in a new textbox position, which is not expected.
This is a problem since 7596e26fd259ce5445212949403e7cd32303b2bd (Add
SwTextBoxHelper::findShapes, 2014-06-24), previously the codepath was
not hit, since shape + content from DOCX was a fly format, not a draw
format + fly format.
Looking at the undo item implementation, in
SwUndoFormatAttr::RestoreFlyAnchor(), aDrawSavePt is initialized from
the old format (that we try to restore on undo), so in case that already
matches aFormatPos (which is initialized from the new format / doc
model), then adjusting the same position looks safe to skip, and that
solves our problem as well.
The whole problem area could be avoided if the draw layer would store
absolute positions in its undo actions, because then it would be harder
to get the abs Writer and the rel Draw undo actions out of sync, but
that would a larger rework.
Change-Id: Ia1c9f486e54f5967a34a1a269f8d234ae96d5bb6
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152627
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
While the selection with table at the end works for Copy, unfortunately
it doesn't work for Delete, because SwUndoDelete can't handle it,
and an empty SwTableNode+SwEndNode pair remains.
This needs some extra code, extract a SwDoc::DelTable() out of
SwDoc::DeleteRowCol() and call it from SwEditShell::DeleteSel() to
create separate SwUndoDelete objects per table, which appears to work.
(regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda)
Change-Id: I1534b100d31bc279bce298d3c2bd235cffc1f9d5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152628
Tested-by: Jenkins
Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
|
|
It will only be used *at most* once, but often will not be used at all.
Change-Id: I13b0e9ab8a4918c56a7e710c80d6d9d36019c605
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152644
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
After commit e855481ead996a3b8270fae91bd23d6c8d75ef25, these languages
are already ordered according to css::lang::Locale sorting implemented
there; but this ordering does not follow the UI language sorting rules.
TODO: put language without country/variant before respective languages
having country/variant.
Change-Id: Ic98b50ef4a500c799110611f7c35c74b4a239ed4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152641
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
... not the original id passed to the function. Theese corrected ids
are used e.g. in set_active_id.
Change-Id: I9967d52ed2362ace947ea21f526c4c0694f14476
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152640
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This was added in commit 1c99616f86f7d5b83b91edc225fc95fec227d710 (sw
floattable, crashtesting: fix PDF export of forum-mso-en3-26783.docx,
2023-05-02) to ensure that in case a floating table is not followed by a
text node, then inject one at a dmapper level.
Later commit 01ad8ec4bb5425446e95dbada81de435646824b4 (sw floattable:
fix lost tables around a floating table from DOCX, 2023-06-05) did the
same at a tokenizer level, as doing it in dmapper is too late in some
cases.
So keep the testcase from the first commit, but the changes to dmapper
can be dropped.
Change-Id: If5b702d99e81a3f939491b7ff9de1128da765cbf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152638
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ied72c83dbc364f96e5b78a3cb915b23a1751ac0e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152646
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...that, for unclear reasons, had been added to this declaration in
436f3f8eb5b45620842351a1f29ba49571043515 "tdf#38742 - Start Center: introduce
push pins to favorite documents", but without also adding it to the definition
in unotools/source/config/historyoptions.cxx, causing
> unotools/source/config/historyoptions.cxx:307:13: error: call to 'Clear' is ambiguous
> 307 | Clear(eHistory);
> | ^~~~~
> include/unotools/historyoptions.hxx:47:29: note: candidate function
> 47 | UNOTOOLS_DLLPUBLIC void Clear(EHistoryType eHistory, bool bClearPinned = false);
> | ^
> unotools/source/config/historyoptions.cxx:71:6: note: candidate function
> 71 | void Clear( EHistoryType eHistory )
> | ^
Change-Id: I7ad65d72be2c59da0ad6deaadefebf9662571433
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152637
Tested-by: Stephan Bergmann <sbergman@redhat.com>
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I879e4d93e1da222d9acabb776552ca1cf819574b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152136
Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
|
|
make CppunitTest_sw_core_text \
CPPUNIT_TEST_NAME=testDropdownContentControlPDF2
Still wrong/poor with this unit test:
-wrong font for rich/plain text content
-slightly offset (shifted right/shifted down) placement
(tested in Linux Evince anyway).
Change-Id: I586d46eaf5cdf9fbf44a6913f295c440240d180a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152634
Reviewed-by: Justin Luth <jluth@mail.com>
Tested-by: Jenkins
|
|
* Update helpcontent2 from branch 'master'
to c366e74f9df3dec75df5b6bb21297166599fbf1b
- tdf#154996 Add tabbed UI commands in Help page
+ refactoring
+ Add comments submenu
Change-Id: I465ea7c0518272e08f5af403f7502a1d10043b5b
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152632
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 0aef8c7bd50b6f82a196358584fabc91ebd64795
- tdf#154996 Add tabbed UI commands in Help page
+ refactoring
Change-Id: I0c8d979b42860c04d93b4ad6085bf41ac1aa5f0f
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152631
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
* Update helpcontent2 from branch 'master'
to 269d7afe0492c2e438c328de95de3ed445809260
- tdf#154996 Add tabbed UI commands in Help page
+ refactoring
Change-Id: I3b299d9d26fdf97b7ebc017f18af3624e6256e1e
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/152619
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: Ie837aec7e2b4b87665cc98200d38329ec2155c56
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152614
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I15f6aea604f5bc05ae8e2e13c1e79003512b707f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152613
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
And extract sorting and removing duplicates to a separate function.
Change-Id: I57ed8d3960eefb8df8128cdb461a0621ed998bbb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152612
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
(<https://github.com/llvm/llvm-project/commit/397f2e9ebee8d8e45547e90dd05228d7f965df67>)
Change-Id: I51acda5951f8250d1a1b47e1c2612199ae7338a2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152618
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
...while latest proper VS 2022 is 17.6.2
Change-Id: I300812fc9f5d380fb2c288bfa19b74502a5b0e2b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152620
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I5fa793ab979221252f66bdd38e6950c06a66b00a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152601
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
When exporting a shape with an axial gradient fill to OOXML, it is
converted to a linear gradient with multiple color stops. Versions
before MCGR had recreated it as axial gradient on import from OOXML.
But now LO is able to handle multiple color stops and so the linear
gradient from OOXML is imported as linear gradient in LO.
When such file is then written as ODF, the multiple color stops are
in elements in extended namespace and versions before MCGR do not
understand them. They show only the first and last color (which are
equal) and the gradient is lost.
With this patch LO converts the linear gradient back to an axial gradient
on export to ODF. The exported axial gradient is rendered in a version
with MCGR same as the linear gradient when opening the OOXML file. The
difference is, that versions without MCGR now render an axial gradient
with two colors.
Change-Id: I2b416b4cdca75d8327107a4f259d63c2e6e97ac3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152574
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
|
|
This reverts commit a38e1537cd06367783a43cc8d3b0e8d674b6e142.
Change-Id: Ic72f1acb7e38209e9b87a8fe80a39acb1eeacfe4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152547
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
|
|
Change-Id: I7479be100d2c0abd9484a4095b3b2acf958beffd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152616
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Since different services/categories may add same languages, they may
become duplicated in the resulting list. Avoid that using std::set.
Change-Id: I9a58341212a4f1190754683b032059408a2653cb
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152611
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I1fd4babe3d577d785015f921e5c8ed95ad4e8fec
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152610
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I91d70d72ea6cb18ed4fde2f3b3a3d037668767e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152615
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I4a8b40c1618421a0c1775d0585c53d90196f0937
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152608
Tested-by: Jenkins
Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
|
|
Change-Id: Ia777daa8ced1df43dd49280ee30269de2b191237
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152609
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
GetLineCount was a sal_uInt16 value, that allows only 65535 lines to be
counted. This is changed to sal_Int32 and also the underlying data type
for the lines number is changed from sal_uLong to sal_Int32, but not for
pages number. With this change, the maximum possible line number is now
increased to 2^31-1 = 2,147,483,647.
Change-Id: Ibee2d24e638204133f0ef085564016543f73d351
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/143173
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
The callback sends the updated theme color palette when the theme
changes or initially when the view is registered, so the client
should always have the up-to-date theme color palette stored, so
it can just show the color picker with the theme at any time without
the need to call the server.
Change-Id: I7cceccc46c2fad23ba89e6d3f3643e37f8dab292
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152589
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
The generation of theme colors generation code is moved to the
ThemeColorPaletteManager class, so it can be reused.
Also change the GetThemeColors return type from std::vector<Color>
to std::shared_ptr<theme::ColorSet> as we can now safely do that
and simplifies things.
Change-Id: I4a54bff889a1f97cb1e30467188dc69e07e8c518
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152588
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
which reduces the amount of data-movement we do in the following loop
when inserting into the sorted_vector.
Shaves 2% off the load time of a large document with lots of styles.
Change-Id: I8df4cc35edcc212613068af108b136c2d5acd219
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152600
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
The DOCX file has 3 floating tables: the first one is immediately
followed by a second one, and the second one also has an inner table.
The problem is that somehow dmapper thinks it's fine to merge the two
outer table together, than the inner table invalidates some of its cell
start/end references, so at the end the outer table conversion fails,
which means we only have 1 table, not 3.
This is a bit similar to commit 1c99616f86f7d5b83b91edc225fc95fec227d710
(sw floattable, crashtesting: fix PDF export of
forum-mso-en3-26783.docx, 2023-05-02), but here fixing the problem at
the dmapper level sounded too complex. Instead inject the text node
that'll serve as an anchor point at a tokenizer level.
With this, the DOCX version of the bnc#816603 bugdoc (the one that
started all workarounds in 2013) has one less overlapping table, but it
still has problems.
Change-Id: I54307b4c554da51bb55287e61bca700d8343d11c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152599
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
... XMLConstantsPropertyHandler and XMLTextMasterPageContext
See tdf#94879 for motivation.
Change-Id: I739c9d4f7e551f84e7a55c6c5eb5109af596f055
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152598
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
The use of comma breaks editing in Expert Configuration dialog, so users
effectively can’t use this.
After editing
<it>Celticmd,1571,-567,1571,-547,2126,559</it>
becomes
<it>Celticmd</it><it>1571</it><it>-567</it><it>1571</it><it>-547</it><it>2126</it><it>559</it>
Using colon instead of comma seems to fix this.
Change-Id: I4bba26fe9d94a33e62a0d34c3324daae0845c30b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152597
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
Reviewed-by: خالد حسني <khaled@libreoffice.org>
|
|
Change-Id: Ie2f9a38ece130bc0cdafedf2c188c4c755233eba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152501
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: I9494207b0bcdf121034f79d936aeadd95cecdf23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152494
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
|
|
Change-Id: Ie25dfed8d3178f71256b19d9ec3247dff6d0c704
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152593
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Its hhea.ascender and hhea.descender metrics are too small, but it does
not have USE_TYPO_METRICS bit set. Since usWinAscent/usWinDescent are
equal to sTypoAscender/sTypoDescender, we can use the former.
Change-Id: I638fa81483365f8c44278ee13ad57cd8cf8d8769
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152595
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
|
|
Just like in I61c4d8d4713b2b82ebb40d9de2a8a773405591ba, avoid the any
assumption on what the parent would do in its own implementation, and
return ourselves when we mean to.
The case of AtkObjectWrapper::get_name() is actually currently fine,
because AtkObject::get_name() does what we think it does, and
GtkWidgetAccessible doesn't override it, but it's safer not to rely on
those assumptions.
Change-Id: Ib500d8efa8501206da66c3cca4f6b93bd426cb7d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152457
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
AtkObjectWrapper::get_description() sets the AtkObject::description
field and chains up to its parent, expecting it to return that member
to the caller.
This is a questionable assumption, but that's what AtkObject does.
However, since f3b0a95f9c2f85604808c21485e46e43aebbbfed which fixed
tdf#150496, the direct parent is GtkWidgetAccessible, not AtkObject.
And the assumption about returning AtkObject::description doesn't hold
then, because GtkWidgetAccessible short-circuits the call if it can't
find the associate GtkWidget, which doesn't exist.
To fix this, return the member directly when we set it, but leave it
to the parent if we don't have anything better in case it could
actually do something useful, and because it's customary.
Change-Id: I61c4d8d4713b2b82ebb40d9de2a8a773405591ba
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152456
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Change-Id: I51b4c20eadc594057d5384bff51b4547da86129d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150837
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ieaed80e4621084baf531b794323b2742ccd80310
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152594
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Rename the function, remove prefix and suffix
Change-Id: Iaca0541d15a9162f11f8461892bf4c4454c9d674
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/151843
Tested-by: Jenkins
Reviewed-by: Hossein <hossein@libreoffice.org>
|
|
Change-Id: Icd70dd656d847f595cc1325ed0decb4941a82cde
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150857
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Id301a9321f77e5ccc1269a3b677e9faeb19a4011
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150841
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: I5d7c6b4b3d9440c6ae63a133e1b7d1374fa61063
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/150861
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
I have ccache 4.8.1 and it reports:
(/home/khaled/.config/ccache/ccache.conf) max_size = 30.0 GB
With a space between the number and the unit and the configure check
with then see a unit-less 30 and will warn:
ccache's cache size is less than 1GB using it is counter-productive: Disabling auto-ccache detection
Change-Id: I12bad9204feddfe06be7207d9367586da871a5e5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152592
Tested-by: Jenkins
Reviewed-by: خالد حسني <khaled@libreoffice.org>
|