summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-13bump product version to 6.4.4.2.0+libreoffice-6-4-4Christian Lohmaier
Change-Id: Ib2bfc7a732ff1932b707d98f38b0966261bac13d
2020-05-13update creditsChristian Lohmaier
Change-Id: Ia17d96dc31e86e8cce822c39f1e129a610ef0646 (cherry picked from commit 2fe850112624502b2d3c82cc634a73b877ebfb3e) (cherry picked from commit adcfadd8d279c5e22a73c25f194fafb0b6433312)
2020-05-13Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-4-4' to 5735d411302c81cd84fbc734cb39337026e2fe1f - update translations for 6.4.4 rc2 and force-fix errors using pocheck Change-Id: I23cb1eac4d444cc3a450b5dd4090413354fc8da1 (cherry picked from commit 41bf8bdf7ca135ccb088126c2fac1856d59437ca) - update translations for 6.4.4 rc2 and force-fix errors using pocheck Change-Id: I30c4689a5d78c1bda80e603b5bd5db35d296a44a (cherry picked from commit ae311ddff6c9c4ef21f2d9a19ebf8e5fa5d82411)
2020-05-13use the LinkManager persist to determine the RefererCaolán McNamara
Change-Id: I4e93878972492a93af368ffa0560412132431a24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93994 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-05-13limit forms to http[s]Caolán McNamara
Change-Id: I3ed0bc626f693ec03f610dc7361f93cad914c9d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93995 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-05-13sanitize properly Calc search bounds (tdf#132783)Luboš Luňák
The row/col handling seems really weird to me here in some places (like starting actually at startcol+1 in some cases). But at least properly limit the values to prevent out-of-bounds accesses. This also reverts 2670e980c7dbadbdc20ff23d57ad892951edc254. Change-Id: I5eb94f3841f3defa763046d5d5bec805abd97c62 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93634 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 58c87f8261abf4f1528a43dc501e956cb9c1d2f2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93543 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 3d0d78621b29fba0e95dc5b348d20bfd3234ebd3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93792 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com>
2020-05-12Resolves: tdf#130108 ensure we don't reuse the last SetSearchMask settingCaolán McNamara
Change-Id: Iddc4438b8bd30576be4531d47b6be0ac70847a9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93366 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit c8a4fa577e5daec6520a810b4df753a67d9dd5a8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93372 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12tdf#131956 dispose progressbar when its target is destroyedCaolán McNamara
Change-Id: Id54ac3a0ebfd360e4107583af7fb978aa69d3288 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93533 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 509c94f1a94d9a2faf835862c400cd78385a2549) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93542 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-05-12Revert "tdf#125609c10 vcl/button: enforce only one radio selected on init"Justin Luth
This reverts commit d35171456bc230efdaa9426da1398b2db7fa0df8, in order to resolve tdf#132581. Only applying this to LO 6.4 which is nearing stable. An attempt to find the real problem will be made for 7.0, but since this reverted commit is really obsolete, it can easily just be reverted. (It fixes a situation caused by a commit that has since been fully reverted. So it should still be a valid fix, but if it exposes other problems, it can easily just be removed to cover them up again...) Change-Id: I0d765ce0cc4ab2b9d282d36a239518d43d6015ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93522 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 64d7f805616fd781d87b49156860d96f081a5a45) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93532 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-05-07tdf#132187 sw: fix creation of frames on end node in CopyWithFlyInFly()Michael Stahl
The problem is that the rInsPos node is included in the range passed to MakeFrames(), but it already has a frame, so now it has 2 and that means the next call to MakeFrames() in this position will create all the frames twice. This is tricky because while in practice there is currently only one layout in theory there could be multiple, and then it could happen that RecreateStartTextFrames() will destroy the node's frame in one layout but not the other, while MakeFrames() always works on all layouts. Fix this by checking if all the existing frames survive RecreateStartTextFrames() and if it's not the case (like in tdf#130685) explicitly delete all the frames and including the node in MakeFrames(). (regression from 166b5010b402a41b192b1659093a25acf9065fd9) Change-Id: I1bba11da053fe1c6359b2f76f3a352e44c6a2a1d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93416 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 49f26e7dae550aff6ca90b3cda7f89e11ac8cfd4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93375 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit d8bea028093fe3d4c0c0af0afad20c2c03bb9855) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93379 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-06tdf#132282: Revert fix for tdf#131554Xisco Fauli
912217285b3058efa54c2336f91fda4efdad6ff0 fixed the root cause of tdf#131554 and 69b83dc2d3014dd9b18402534e15c937dc082464 is no longer needed The unittest still passes Change-Id: I7c723b0c3cc2b56022978bbeb8bf6b3f6f93f1c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93063 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93073 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 7df4ebf9a658681d02842b14187722ae8161cd7e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93140 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-05Resolves: tdf#130505 give default focus to the file name fieldCaolán McNamara
Change-Id: I2c78fa95e626029a4cfc7f8e2faf03d4a5d2dee8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93136 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit b065d68266a8b897bc2dab26135577d1d0e9a7ff) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93370 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-05-05Resolves: tdf#131898 we only want the text from column 0Caolán McNamara
in the fallback file picker Change-Id: I60527661f83fde135145249a14b4f3b35840fff8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93145 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 15eb7d3197e290efd3f2c43973c033dc754416c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93371 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Michael Stahl <michael.stahl@cib.de>
2020-04-29bump product version to 6.4.4.1.0+Christian Lohmaier
Change-Id: I747418a551be621e81f2bbcc432628aa9c070cdb
2020-04-29bump .gitreviewChristian Lohmaier
Change-Id: I5b983d5fd61a3e756cda320f7a48012797d3658a
2020-04-29Branch libreoffice-6-4-4Christian Lohmaier
This is 'libreoffice-6-4-4' - the stable branch for the 6.4.4 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 6.4.x release, please use the 'libreoffice-6-4' branch. If you want to build something cool, unstable, and risky, use master.
2020-04-29Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-4' to 58dd1a5ffadeee63b7fb61ceadd10c56521b6ed5 - tdf#128200 don't use invalid formula/identifier translations Change-Id: I9fe52162259437b8aa3e3f4493055c64f6038ae1 - update translations for 6.4.4 rc1 and force-fix errors using pocheck Change-Id: Idc31497ec85c5e0a5aae2cd7d8fbb11ef2043026
2020-04-29tdf#131733 Show only CN part of X.509 subject infocp-6.4-branch-pointGabor Kelemen
The problem was that the whole Subject info was returned from X.509 certs if they did not start with one of "CN", "OU", "O", "E" Instead of extending this list with random keys, pass the type of cert and only return the whole Subject info if it's an OpenGPG one, and process the info unconditionally if it's X.509 like before the OpenGPG integration Change-Id: I1aa5d7285e48b0f4a769a073cdfb7732e482792c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92675 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit bedba76adb9b1421a7d939cfef44b8194e987888) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93129
2020-04-29Resolves: tdf#132288 don't merge adjacent properties for spell checkingCaolán McNamara
spell checking relies on each attribute chunk being unmerged with identical adjacent chunks squash includes... nStartPosition and nEndPosition are always the same and tdf#132288 preservation of footnote depends on reverse iteration like TextCharAttribList::FindAttrib does which spell checking used before commit 243b5b392906042ab03800e0b5765e6f3513372c Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Jun 14 21:56:44 2019 +0100 weld SpellDialog converted to use an EditEngine instead of a TextEngine in order to be able to host it in a native widget Change-Id: Ia835fa054cad0dee4304f16724b9eb0c29b46102 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92772 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-29tdf#119087 Don't treat OOXML strict namespace as custom XMLSamuel Mehrbrodt
Change-Id: I5037ac09f57c92e02e330cbc906da3afbe4c747c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93056 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 9be543a27ab18427a1c4e66a70cc49b0332b6aa1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93128 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-29DOCX import: handle <wp:positionH relativeFrom="insideMargin">Miklos Vajna
This is the same as page, but it is from-left on odd pages and from-right on even pages, i.e. our "mirror on even pages" mode. (cherry picked from commit fccbb557add457db16e0556c3f0172cafc2cf981) Conflicts: writerfilter/qa/cppunittests/dmapper/GraphicImport.cxx Change-Id: I018e0ac165a3d802f64cfc314d5c5f58da3cb580 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93003 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-04-29Sifr Dark: tdf#32490: Missing Set Reminder iconsRizal Muttaqin
Change-Id: Ibc5121114db8921932f3225262517bba18014ff4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93072 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit f845f74afaf087a46c82ee4209e29caca0980b71) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93127
2020-04-29Sifr: Fix for tdf#32489: missing tiny DB actions iconsRizal Muttaqin
Change-Id: Ic9847d4d72b000f0ab9c906b91dc689a010aeead Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93068 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 8bd83405b0d4ba4db3437f757d507ec1d0c84254) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93009
2020-04-29Breeze, elementary, KJ: Add Modify Layer iconsRizal Muttaqin
- elementary: Update Step Over, Border Color icons Change-Id: I7a84f0186a26b873c409eb3c2b79ef4c4f994fb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93093 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 7fcc62022d6dd9e18f10b9e71296e7159f98d343) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93126
2020-04-28tdf#131979 Chart ODF import-export of Link to source formatBalazs Varga
setting also into data point styles, fixing lost numbering style of custom data points. (Only export into the data series style was supported previously.) Also fix tdf#131115 - FILEOPEN: Incorrect format of single data label Regression from commit: e57d90cd4e51a1353eafc87bb29cfe6076704a7c (tdf#129173 tdf#129175 Fix number format of data labels) Data point styles in older ODF files do not contain the 'link-data-style-to-source' property, so they used the data series style property during the import previously. Now we set the default false value, if the data point style contains a 'data-style-name' (number format). Change-Id: I4786e62ca75770ed632463bcf1275ece7ea793f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91967 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92653 Tested-by: Jenkins
2020-04-28tdf#132174 Chart DOCX import: fix label number formatBalazs Varga
The inner data table of charts has no own cell number format, unlike the MSO embedded XLSX, so we always have to set the link number format to false, if we have an inner data table. Regression from commit: 9c1063ba13028244346528e307d5563d6faf949d (tdf#129173 tdf#129175 Fix number format of data labels) Change-Id: I5e7865cb8c19fc6fae5b68305c7dc302516c0ad4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92695 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Tünde Tóth <tundeth@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit e0da00d655ecca5986eea3812a8a670c6adbc40f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93007 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-28tdf#132355 fix X axis position of stock chartsTünde Tóth
Set the ShiftedCategoryPosition for true in case of stock chart. Regression from commit: 111c260ab2883b7906f1a66e222dbf4dc3c58c4f (tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts) Change-Id: I7ced1b03158908e838f7bb44c89dea23c5b347b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92759 Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93045 Tested-by: Jenkins
2020-04-28tdf#132305: Teach Starmath MS_COMBOVERLINE = 0x0305Julien Nabet
Change-Id: I04b282d3f0dae68d459002f5a3822ac06fdb7986 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92698 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit be23b4a91504b81a19510f8562e92203b4317edf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92770 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-28tdf#78749 DOCX: import VML background imageAttila Bakos
of text boxes. DOCX relationship identifier wasn't handled earlier, only XLSX. Co-developer: Tibor Nagy Change-Id: I72f246e6f69d70d1e203087516ee93a57563f777 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91933 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 9283cd9e13cd3e0dd7d6b831d930128931862a40) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92771 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-28tdf#131446 DOCX import: restrict IncreasedAnchoredObjectSpacing furtherMiklos Vajna
Regression from commit 8b73bafbc18acb4dd8911d2f2de8158d98eb6144 (tdf#115719 DOCX import: increase paragraph spacing for anchored objects, 2018-02-14), this is another case where the workaround for the Word layout bug is not needed. tdf115719.docx and tdf115719b.docx are tweaked to have <wp:anchor ... behindDoc="1"> for 1 shape, as the original bugdoc has it. This allows us to render both the tdf#115719 and tdf#131446 bug documents the same way as Word does. (cherry picked from commit 249428202be04ab9a2271a9cd48922523fa03bc4) Change-Id: I0c3f197c3360882cd64f8dcf286c6051dc11d674 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92978 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-28tdf#131729 sw: handle no drawing objects when calculating overlap of objectsMiklos Vajna
Regression from commit d37096f59e7e0286e55008153591a60bab92b9e8 (Related: tdf#124600 sw anchored object allow overlap: add layout, 2019-09-19), we assumed that the anchor frame always has draw objects, but that may not be the case. That happens when dragging a to-character anchored object around, before the object is added to its anchor. (cherry picked from commit 4ba1909f12b49f020195b5e767045340717ce6df) Change-Id: I1271a6e498553838c3851864b7965a1ba28de663 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93002 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-27elementary: fix for tdf#125779: object handlers are too faintRizal Muttaqin
Change-Id: If1741e88178205aee9f46b0fa96ca29b61ac4d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92970 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit ce9caca8da371784e33638323792e42630b2a057) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93006 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-27tdf#132351 DOCX export: fix character formatting of numberingLászló Németh
with removed ListAutoFormat. Using untouched text portion of paragraph marker, DOCX export restored the changed character formatting of numbering with removed ListAutoFormat (see RES_PARATR_LIST_AUTOFMT in wrtw8nds.cxx). Follow-up of commit e4509d7db7562f7e4ab9366b915ed558291ac3de (tdf#127606 DOCX lists: fix unchangeable formatting) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92744 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry-picked from commit 7690f3269c89140930f49068133e7d061d475948) Change-Id: Ie576a204d86694296cb29185a5b130e87a518b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92801 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-27tdf#127606 DOCX lists: fix unchangeable formattingLászló Németh
of numbering symbols. It was not possible to modify the character format of numbering symbols, if it is different from the format of the list item, handled by ListAutoFormat compatibility paragraph attribute and APPLY_PARAGRAPH_MARK_FORMAT_TO_NUMBERING compatibility setting. Now changing character attributes removes ListAutoFormat, if it is applied on wholly list item(s) during editing. See commit 5ba30f588d6e41a13d68b1461345fca7a7ca61ac (tdf#64222 sw: better DOCX import/export of paragraph marker formatting) and commit df07d6cb9f62c0a2c4b29bd850d4efb4fcd4790b (handle direct formatting for numbering in .docx (bnc#875717)). (cherry picked from commit 6287845eab339a8eb3c660d648d012e9f1dcce30) Change-Id: I60dae1b9c084d0804e453f54df5c6bbafe479869 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92534 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-27tdf#131936 Correctly detect OOXML variant on importSamuel Mehrbrodt
Change-Id: I29a6b0454bf741ce8ad49078597b3412a83dedb9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92278 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit ff93e4977cb1e23f355d248a77e8d0e56bb0f4b9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92766 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-27tdf#91818 disable scrollbar in Start Center when it isn't neededRoman Kuznetsov
Change-Id: Ib3b7be6dd93a7f1c75f01ffe53ff7f7c19b14342 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92773 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Roman Kuznetsov <antilibreoffice@gmail.com> (cherry picked from commit 10dba26804cc0c14f74069c26112e75dacf3865b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92774 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-26Sifr: Fix for tdf#132404 too large Points iconRizal Muttaqin
Change-Id: I86c4b301a6111e5e8a2a5e043b48bdedfff2ca59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92922 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit abfe59f9d2d15512569263183f65da5b5a04627b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92777
2020-04-26tdf#132385: sql parser: don't drop clauses from window specificationJulien Nabet
bison rule window_specification: '(' window_specification_details ')' { $$ = SQL_NEW_RULE; $$->append(newNode("(", SQLNodeType::Punctuation)); $$->append($2); $$->append(newNode(")", SQLNodeType::Punctuation)); } ; makes it look like rule "window_specification_details" is a single node, but in reality it is a sequence of four nodes: window_specification_details: opt_existing_window_name opt_window_partition_clause opt_order_by_clause opt_window_frame_clause ; The result is that only the "opt_existing_window_name" clause was being put in the parse tree, and the other three were simply discarded. Since that will forever be a trap, and this is the only place where window_specification_details is used, we inline it into window_specification and remove it. Change-Id: I568904355174d2bc36155bde1d4dd09f57759cd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92776 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins
2020-04-25tdf#131496 vcl image lazy load: speed up vector images with custom pref sizeMiklos Vajna
This speeds up the loading of the bugdoc: - old cost: 6378 ms - new cost: 1891 ms (30% of baseline) Images were initially loaded at import time, but commit acb803b730f2c6bd82e39beab58949ec14f85eb0 (tdf#125591 DOC import: lazy-load metafiles with explicit size, 2019-06-11) changed this, so that they are lazy-loaded. That improved performance, but sometimes gave incorrect results. Then commit d8371cdfd092c6426c01aae130ea4eaa6d627a6f (tdf#127446 vcl image lazy-load: fix custom size handling of metafiles, 2019-09-30) fixed the correctness problem, but the loading was no longer lazy in the tdf#131496 case. This is an attempt to bring back lazy-loading for vector-based images, while maintaining the correct preferred size. The problem was that the PPT import triggered a vector -> bitmap conversion during load: #0 0x00007ffff03c7e36 in ImpGraphic::loadPrepared() (this=this@entry=0x1f88a90) at vcl/source/gdi/impgraph.cxx:1424 #1 0x00007ffff03c72c7 in ImpGraphic::ImplSwapIn() (this=0x1f88a90) at vcl/source/gdi/impgraph.cxx:1444 #2 0x00007ffff03c7535 in ImpGraphic::ensureAvailable() const (this=this@entry=0x1f88a90) at vcl/source/gdi/impgraph.cxx:1402 #3 0x00007ffff03c9481 in ImpGraphic::ImplExportNative(SvStream&) const (this=0x1f88a90, rOStm=...) at vcl/source/gdi/impgraph.cxx:1590 #4 0x00007ffff03bf9a8 in Graphic::ExportNative(SvStream&) const (this=this@entry=0x20534e0, rOStream=...) at vcl/source/gdi/graph.cxx:544 #5 0x00007ffff1c79a28 in svt::EmbeddedObjectRef::SetGraphicToContainer(Graphic const&, comphelper::EmbeddedObjectContainer&, rtl::OUString const&, rtl::OUString const&) (rGraphic=..., aContainer=..., aName="Object 1", aMediaType="") at svtools/source/misc/embedhlp.cxx:773 #6 0x00007ffff1c79b6f in svt::EmbeddedObjectRef::AssignToContainer(comphelper::EmbeddedObjectContainer*, rtl::OUString const&) (this=0x207ae90, pContainer=pContainer@entry=0x1f8de40, rPersistName=...) at svtools/source/misc/embedhlp.cxx:369 #7 0x00007ffff239f736 in SdrOle2Obj::Connect_Impl() (this=this@entry=0x20734f0) at svx/source/svdraw/svdoole2.cxx:984 #8 0x00007ffff23a6310 in SdrOle2Obj::Init() (this=this@entry=0x20734f0) at svx/source/svdraw/svdoole2.cxx:695 Try to defer that conversion by not doing a maVectorGraphicData->getReplacement() in ImpGraphic::ImplSetPrefSize(), rather just store the preferred size and apply it later when getReplacement() is called. This helps, because the above OLE-from-PPT case loads the graphic, but only to export it as SVM, so it doesn't need a vector -> bitmap conversion otherwise. (cherry picked from commit 952cc68929f863784c6b01c9dc071494892877d1) Change-Id: I24790c0a3e298d5fbb3faff35d529e79cc72845a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92156 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-23tdf#119187 fix: Top-aligned text in PPTX becomes bottom-alignednd101
Change-Id: Ic6c03e512ce3f6e240d86186fb16e24c86942343 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92051 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92725
2020-04-23Update language-subtag-registry to 2020-04-01Eike Rathke
Change-Id: I89ac10b243ac0babbe0d1bf24a7e0f732fe5a495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92755 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 11ef83aa64af7e366cd56856853a7b332a69d105) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92767 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-23tdf#132278 crash after opening an old fileNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: I7a37631094b91f4859326db054f285daa8dccbb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92740 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 4faf8ef2553aba31d6021abce604f7716d2ad229) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92544 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-23Resolves: tdf#131423 Handle Function Wizard max argument count correctlyEike Rathke
The function description's argument count includes the VAR_ARGS and PAIRED_VAR_ARGS logic. Limit the max arguments count to the actual supported number of arguments. Change-Id: I588bed4672ff84adddc4be94962b2537758c5247 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90849 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit d43d2662ff64c613740080e166d1046214edb0f0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91300 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-22tdf#131169: Retrieve right category in function wizardJulien Nabet
m_xFuncPage->GetCategory() takes into account "Last Used" + "All" so 13 categories (0 -> 12) whereas m_pFuncDesc->getCategory()->getNumber() doesn't take into account the 2 first (so only 0->10) So it's not +1 but +2 Change-Id: I4d37575a3b6615c76bfa173402191a8661714e95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92652 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4048ddc65a36fe0b8940019ded4fd1d58f907bcc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92541
2020-04-22tdf#127109 Writer: fix Undo entry "Delete $1"László Németh
Regression from commit b69c518df68ce673b28d589da6626bd3d860f309 (tdf#54819 keep style & numbering at tracked deletion) Change-Id: I3041cc5a70d00bea14d7be1c275bb7d2a22e768a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92614 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit cfac976e27f310014dcd866000c874014fd6b173) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92531 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-22tdf#131147 don't store redline ExtraData during UndoLászló Németh
to avoid of unwanted redline changes and assertion. Breaking redlines and storing extra data (formatting changes) need only for change tracking during editing, not in an ongoing Undo process. Regression from commit dc9a0b124272a6dc0a8d875d51b6f882e60a8a04 (tdf#127101 Change tracking: reject format at paragraph join). Change-Id: Id78251bc14821cc82d8f3d34eec63ba7bac68df0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92559 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 66b39ca79b36da8d5e151deab17a0fb7690eebe6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92530 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-22update creditsChristian Lohmaier
Change-Id: Ic21818bfa1b45f06344cbe92c5d57324654a5e04 (cherry picked from commit 6629d98a7a7f53bb02b2102b63f40325e460b5a9)
2020-04-22tdf#131951 related, improve perfNoel Grandin
similar to commit 9429dacc7ff93f99dd84532357020669df33a0c5 tdf#131951: automatically increase buffer size in a few places, let the OUStringBuffer handle large tokens, it has faster handling than repeatedly appending to an OUString Change-Id: I609b84b36e817fbcd6d366c53cd2e8b865216712 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92503 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92648
2020-04-21tdf#131951: automatically increase buffer sizePavel Klevakin
This will reduce number of string concatenations and therefore reading time of large data chunks. Change-Id: I6d59ba60270511edf03a604aef06dab0a1de2478 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92456 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92647 Tested-by: Jenkins
2020-04-21tdf#123346 DOCX VML shape export: fix arrow markerSzabolcs
In some cases at import there are extra space separated numbers at the end of the names of arrow objects. Remove these extra numbers before they could interfere with the choice of markers. See commit 2d3b7a07c02c90d2d64a630ab84886ef3096edfc (tdf#100491 fix DOCX import shape line with arrow marker). Co_Author: Balázs Regényi Change-Id: I2156502b0ce5cd755a731359398a40edabb603a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91375 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 68531e459e7a922319e6bfe8b7a5282ba0320182) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92535 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-04-28 01:13:58 +0000