summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-25Use for-range loops in some modulesJulien Nabet
jvmaccess, jvmfwk, l10ntools, libreofficekit and linguistic Change-Id: I9d290d1098b25ccb3aee19d2df18c18f4aa65105 Reviewed-on: https://gerrit.libreoffice.org/51495 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-03-25accessibility: simplify OCommonAccessibleTextArnaud Versini
Change-Id: Ied5520179d15f0a854c16b14f5a5e6b84cef1300 Reviewed-on: https://gerrit.libreoffice.org/51514 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Arnaud Versini <arnaud.versini@libreoffice.org>
2018-03-25tdf#116509 OpenGL: Slideshows with Transitions crashing ImpressNoel Grandin
regression from commit e5012e53b919ae4921d6d35660bde323a6f28417 use scanline when reading pixel data Change-Id: I1980a1acfedadbea706b93aed7452790e03257f2 Reviewed-on: https://gerrit.libreoffice.org/51803 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-25Fix copy-paste errorTor Lillqvist
Change-Id: I01b20482aefadb1a755cc1d2f5705b2f7f7cf739
2018-03-25Remove useless checkMike Kaganski
Change-Id: I9cfb8e7865e31b5c69e0b4b99426e96c7444224f Reviewed-on: https://gerrit.libreoffice.org/51820 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-25xmloff: export ruby-position in a more compatible way.Mark Hung
Export both style:ruby-position and loext:ruby-position. The later one only allows "above" and "below", obeying ODF standard while the former one allows "inter-character", which is added lately. Also use ODFVER_012_EXT_COMPAT so that loext:ruby-position isn't exported only in extended mode. Change-Id: I7b9208f289f8253a835b2f7751549206361274e0 Reviewed-on: https://gerrit.libreoffice.org/51007 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-03-24Updated coreAdolfo Jayme Barrientos
Project: help a86659f64cb346127159064202d9b6d3513ffe3e tdf#97622 Update help text to match new behavior Change-Id: I973ef76893f353317d8412fd3c26599b9fdaf9cf
2018-03-24tdf#97622: Apply Asian spacing only to Asian textKhaled Hosny
The option “Apply spacing between Asian, Latin and complex text” (which is on by default) should only apply the extra spacing if one side of the text is Asian since that is the requirement of CJK typography, but Writer seems to apply it to any script change (e.g. between CTL and Western). This matches the behaviour in edit engine wich was changed back in 2002 in commit e314e1b8aa3f1d98f2b33ce3f546d07eafa0f799. Change-Id: Ia9f7167251bce7166c4087b347788a7b89e8b347 Reviewed-on: https://gerrit.libreoffice.org/51208 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
2018-03-24Fix typosAndrea Gelmini
Change-Id: I6c515e716b232fecfe1750b806f0a5624f648de5
2018-03-24hook up focus eventsCaolán McNamara
Change-Id: I9f5835e86550bd3d728936e5525262697e01e5fc Reviewed-on: https://gerrit.libreoffice.org/51786 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-24remove notice about cite.phpdennisroczek
The extension Cite is distributed with MediaWiki 1.21 (released May 2013) and is integrated in core since MediaWiki 1.25. No need to keep that notice any longer. Change-Id: I8a91fbb45bc6f410b551c206177d63c584349c37 Reviewed-on: https://gerrit.libreoffice.org/51795 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2018-03-24rhbz#1559633: Treat EPERM same as EACCES when opening filesStephan Bergmann
For example, Linux open(2) with O_RDWR fails with EPERM if the file is flagged as FS_IMMUTABLE_FL. (And there is an #ifdef IOS "Horrible hack" block in openFilePath in sal/osl/unx/file.cxx that is apparently a workaround for a similar scenario where open returns EPERM instead of EACCES on iOS, and which can probably be removed again after this commit.) Change-Id: I00cbd28d4b83b223920776998e9245b6261bb748 Reviewed-on: https://gerrit.libreoffice.org/51788 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-24file.pm : quick build fixMike Kaganski
Regression from commit 2367557493c216be5b5e8156ba6493d440a10b0f Change-Id: If2d11856db8f7f341a8f3c2b3a73f7afdff6a621 Reviewed-on: https://gerrit.libreoffice.org/51792 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-23...in which case .. path segments need to be resolved in SearchPath, tooStephan Bergmann
...for cases like > In file included from vcl/source/outdev/hatch.cxx:32: > vcl/source/outdev/../gdi/pdfwriter_impl.hxx:47:10: error: replace "..." include form with <...> for inclusion of a source file not next to the current source file, or a header, vcl/source/outdev/../gdi/pdffontcache.hxx [loplugin:includeform] > #include "pdffontcache.hxx" > ^~~~~~~~~~~~~~~~~~ Change-Id: Ib486e0cf16a157b90f838536a15c40c2a34ef72b
2018-03-23Updated coreAdolfo Jayme Barrientos
Project: help 4740109668b5d2bbf67caef82fb38364abbc38bb Helponline: Prettify donation prompt Change-Id: Iedf3d560c2a8d1feabadcf3ce1be40f1b5e01989
2018-03-23Revert "tdf#116241 Customizing value highlighting colors"Szymon Kłos
This reverts commit fb29b8262488d045a926504725669a362bacb5bb. Change-Id: I338af7c108bb6386193550ef0603b406c4f7bd99 Reaseon: I will move this to more suitable place "application colors" and extend with protected cell backround. Reviewed-on: https://gerrit.libreoffice.org/51789 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2018-03-23Fix typoAndrea Gelmini
Change-Id: I278098108a8120b1b7a8115d8e5abc6d1ea57321 Reviewed-on: https://gerrit.libreoffice.org/51784 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-23tdf#116581: also read UTF16-encoded version string from TTFMike Kaganski
Change-Id: I47d8a755450b085be39346615f06cee4f920859f Reviewed-on: https://gerrit.libreoffice.org/51781 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-03-23Check isOkToRemoveArithmeticCast in loplugin:redundantfcast tooStephan Bergmann
...to avoid warnings like > C:/lo64/core/svx/source/table/accessiblecell.cxx(400,12): error: redundant functional cast from 'long' to 'sal_Int32' (aka 'long') [loplugin:redundantfcast] > return sal_Int32(0x0ffffffL); > ^~~~~~~~~~~~~~~~~~~~~ with clang-cl Change-Id: I4a48a9f10ad75f76a3c6ab6152ab279df9a3fbcc Reviewed-on: https://gerrit.libreoffice.org/51780 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-23msfilter: extract copy&pasted RTF code from sw and writerfilterMiklos Vajna
Both the hexdump and the OLE1 reader can be shared. Change-Id: I97d72a8deeb9c79fc8e8c4a73c613213badfa744 Reviewed-on: https://gerrit.libreoffice.org/51783 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-23Handle .. path segments in loplugin:includeform againStephan Bergmann
...after 119d8137695e38c16e9fad9f3ce8a774f58e4b9a "Revert 'Allow compiler plugins for online'", to fix cases like > In file included from vcl/unx/gtk3_kde5/gtk3_kde5_cairo.cxx:20: > vcl/unx/gtk3_kde5/../gtk3/cairo_gtk3_cairo.cxx:12:10: error: replace "..." include form with <...> for inclusion of a source file not next to the current source file, or a header, vcl/unx/gtk3/cairo_gtk3_cairo.hxx [loplugin:includeform] > #include "cairo_gtk3_cairo.hxx" > ^~~~~~~~~~~~~~~~~~~~~~ Change-Id: I12b3049862825f10834333b154c9343a3e3bec6d
2018-03-23sw XHTML import: support OLE2-in-RTF objectsMiklos Vajna
If you like layering things on top of each other, then this commit message is for you. So it's possible to have a PPTX file in the following wrappers: - wrap PPTX in a binary OLE2 container - wrap that in an OLE1 container - wrap that in an RTF fragment - wrap that in an XHTML fragment (in a ReqIF file) Turns out that only the RTF and OLE1 unwrapping was missing, the rest worked already, so implement the missing piece in a new SwReqIfReader namespace. Finally extend OleEmbeddedObject to be able to read its native data stream when the object is opened, reading it from the storage would fail, as the object already opened the storage stream. Change-Id: I2934c9fb7474e981ff6bb2f7eb253a3a86cfd98b Reviewed-on: https://gerrit.libreoffice.org/51772 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-23a11y crash with no chars selected in character mapCaolán McNamara
type gibberish in character map search box, click character map widget, crash Change-Id: Ifa3e4bce2d7e0b84cf3c5033eb819c73076daabe Reviewed-on: https://gerrit.libreoffice.org/51773 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23lok: don't post events on disposed windowPranav Kant
Change-Id: I7721380b1bb6e9ec21338a72523326d0cae6729e Reviewed-on: https://gerrit.libreoffice.org/51777 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: pranavk <pranavk@collabora.co.uk>
2018-03-23xmlsecurity: remove no longer needed Windows XP workaroundMiklos Vajna
Change-Id: Id3f024fefc0b2bd6f837ecfdd907f0d107600910 Reviewed-on: https://gerrit.libreoffice.org/51759 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-23Enable binary search for numeric values againEike Rathke
... as used in LOOKUP and VLOOKUP. This was disabled as a fallout from commit bad266fa06294f1dacec11ec02dfc6ae4ec8cdc4 CommitDate: Mon Feb 22 21:30:28 2016 +0100 ScQueryEntry::GetSearchTextPtr() with SearchType, tdf#72196 that changed the !bRegExp condition (which includes numeric) to bLiteral (which covers only text string) searches. Change-Id: I265286ffe75bc7cd9e660ab82b0e647d82865eb9
2018-03-23[API CHANGE] Fix typo in prop implemented by stardiv.UnoControls.FrameControlStephan Bergmann
There is exactly one implementation of css.frame.FrameControl (which demands a property named "ComponentUrl" not "ComponentURL"), and exactly one place where that property is used. So switch those two places to use the spelling of the property name as documented in the UNOIDL service. (Even though that can be considered an incompatible change, in the unlikely case that 3rd party code expects to be able to access the given implementation's property with the mis- spelled name.) Change-Id: I4fa3f21851b61079c09deea1a24aac22bc96f36f Reviewed-on: https://gerrit.libreoffice.org/51766 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-23Revert "Allow compiler plugins for online"Stephan Bergmann
This reverts commit b39e627be45f847554f11fdac040b6f4da4054ba. The assumed (see comment at <https://gerrit.libreoffice.org/#/c/46769/4/compilerplugins/clang/ plugin.cxx@633>) performance bottleneck of isSamePathname -> getAbsolutePath does show up in Flamegraph inspections of LO builds. But changing (non-member function) isSamePathname to only call getAbsolutePath if (PluginHandlder member function) isLOOLMode is true would need some code reorg, and Online development doesn't seem to make too much actual use of the plugin, so conclusion on IRC was to revert. Change-Id: I0f04fdcc87087dac516630ed5e48361f5ea332ca Reviewed-on: https://gerrit.libreoffice.org/51774 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-23use boost::optional in vclNoel Grandin
instead of allocating small objects on the heap via std::unique_ptr Change-Id: Iba1d9ad90dc5a31908027336f85046a9de6f5bc4 Reviewed-on: https://gerrit.libreoffice.org/51769 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23add set editable supportCaolán McNamara
Change-Id: I4ec9d3de426f760c38600d4960e2d37a3be8a9bb Reviewed-on: https://gerrit.libreoffice.org/51768 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23inherit from Control for focus supportCaolán McNamara
Change-Id: Idbcdaa97c2ff5f9d8f20270b09753693b03a67a6 Reviewed-on: https://gerrit.libreoffice.org/51767 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23loplugin:useuniqueptr in SwCursorNoel Grandin
storing a struct with two integer values in it, in a linked list, just seems inefficient Change-Id: I2913aa867cc978271d7778f06546d47fa6c57973 Reviewed-on: https://gerrit.libreoffice.org/51761 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-23loplugin:useuniqueptr in PPTWriterNoel Grandin
Change-Id: I5c099e97d51808d2dcaf6d1385d1e3cab2e2ddf2 Reviewed-on: https://gerrit.libreoffice.org/51762 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23loplugin:useuniqueptr in PPTExStyleSheetNoel Grandin
Change-Id: Ib830a1be4f840c06ebda9830351d82ad31706be1 Reviewed-on: https://gerrit.libreoffice.org/51738 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23Typo: ImplGetSelectEntryPos -> ImplGetSelectedEntryPosSamuel Mehrbrodt
Change-Id: I19233d37b2d72bef73659ddbb6d116d2632145c1 Reviewed-on: https://gerrit.libreoffice.org/51748 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-23blacklist should have been staticStephan Bergmann
Change-Id: I2f9172ba9d9724b39ce00f0e5a24a5d4032789a9 Reviewed-on: https://gerrit.libreoffice.org/51765 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-03-23loplugin:useuniqueptr in PluginSlideChangeNoel Grandin
Change-Id: I60474c40012c2afa2573bc5ba5013e46551d1309 Reviewed-on: https://gerrit.libreoffice.org/51760 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23ofz#7065 Integer-overflowCaolán McNamara
Change-Id: Ic8837d21d64dc6fd3623ab5d32bc902e6c34dd21 Reviewed-on: https://gerrit.libreoffice.org/51746 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-03-23comment: Word does not use tabs in footnote implementationJustin Luth
Tabs are inserted when LO exports to MS formats in an attempt to emulate its "magical" spacing which uses the paragraph margin. By default, the Footnote paragraph style has a paragraph margin of 0.60cm. A hanging indent places the footnote character before the margin, and thus a tab advances to the margin. So the emulation works well. The previous comment was misleading because it suggests that this was a Microsoft convention, but actually this is an OOo innovation. Change-Id: Ie8708998457bcb3363bbc760086cf2b41d3eb104 Reviewed-on: https://gerrit.libreoffice.org/51753 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-23tdf#116525 writer, no shadow around boxNoel Grandin
regression from commit 2ccde70d60d3a5074faf49260e8fe0ccdb91ff26 teach redundantcast plugin about functional casts because we are now passing the same variable as a both an in-parameter and an out-parameter Change-Id: I6454103fbc46530180cde5f725273e062eb2e25d Reviewed-on: https://gerrit.libreoffice.org/51757 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23Typo: GetSelectEntryPosLBB -> GetSelectedEntryPosLBBSamuel Mehrbrodt
Change-Id: Id1706d11143ee60216322db1ac51207e658000e1 Reviewed-on: https://gerrit.libreoffice.org/51749 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectItemId -> GetSelectedItemIdSamuel Mehrbrodt
Change-Id: Ieebb50b73f1f341c924693f3966f8cd2b09a136b Reviewed-on: https://gerrit.libreoffice.org/51750 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: GetSelectLanguage -> GetSelectedLanguageSamuel Mehrbrodt
Change-Id: Ia283812d4e9df87d875559af5366c2e36b19eab2 Reviewed-on: https://gerrit.libreoffice.org/51747 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23Typo: SplittTable -> SplitTableSamuel Mehrbrodt
Change-Id: I6c5947964b3765ea05debe8837bd2f3dc57ae6ed Reviewed-on: https://gerrit.libreoffice.org/51745 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-03-23loplugin:useuniqueptr in ScPoolHelperNoel Grandin
Change-Id: I12bb470b3c0af78aa713e7b28d59235b55507d24 Reviewed-on: https://gerrit.libreoffice.org/51737 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23Correct class nameJens Carl
Change-Id: Ie7e7ce72c264d9244bd0cb2e8e1f51fb6f4434d8 Reviewed-on: https://gerrit.libreoffice.org/51756 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-03-23loplugin:useuniqueptr in RichTextControlImplNoel Grandin
Change-Id: I3fcf9a4edf6dbed496bcc9160847e627777f04f1 Reviewed-on: https://gerrit.libreoffice.org/51740 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23loplugin:useuniqueptr in DocumentChartDataProviderManagerNoel Grandin
Change-Id: I4b6c5996bbf0be3998925655a44ba02bc197607e Reviewed-on: https://gerrit.libreoffice.org/51739 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23loplugin:useuniqueptr in AstStructNoel Grandin
Change-Id: Ib7416235e41192323e74061bfce6c162e87612f2 Reviewed-on: https://gerrit.libreoffice.org/51736 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-03-23loplugin:useuniqueptr in OutlineViewNoel Grandin
Change-Id: I6da98d8634076826cfdbe8d77fa72cb2b99ffe84 Reviewed-on: https://gerrit.libreoffice.org/51672 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-11 03:16:09 +0000