summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-05-08gbuild: work around GDB 10 bug with DWARF5 in split debug infomimo-7-0-branch-pointlibreoffice-7-0Michael Stahl
GCC 11 defaults to -gdwarf-5 and GDB can only read it if -gsplit-dwarf isn't used. Dwarf Error: wrong unit_type in compilation unit header (is DW_UT_split_compile (0x05), should be DW_UT_type (0x02)) [in module /workdir/CObject/desktop/source/app/main.dwo] https://sourceware.org/bugzilla/show_bug.cgi?id=27354 https://bugzilla.redhat.com/show_bug.cgi?id=1956475 Change-Id: Ie2ac7193a29a8f257cf6f1d711f9fa6941df48ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115054 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit dc8c8a4aa20ddd3139a25d5c052cac9bae944cb8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115193 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-05-06update creditsChristian Lohmaier
Change-Id: Ifa86e93a66d54d5ad8f288ba111cbe4ca1695415 (cherry picked from commit b6516acdb96a7417f0d58749723750d83547f98a)
2021-05-05tdf#141930 document set as unmodified if editengine didn't modify on keyeventCaolán McNamara
this appears to have always happened for cursor keys, and since commit 0154f04e8c64df937b793c73ac58d553637f324f Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Feb 24 14:32:21 2021 +0000 Resolves: rhbz#1931423 start update timer in IM events as well as keyevents also happens on Input Engine events which don't cause changes Change-Id: Ic5cdd9ef4f1bed1cc2b2c17fc847f196a9c6e23a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114930 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8e78b937fca92f5ed07383e69ceef71715a15fe1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115085 Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-05-05Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-0' to 64657573815f1d85d3cc4cf44272d6ba58128dda - update translations for 7.0.6 rc2 and force-fix errors using pocheck Change-Id: Ia3d84528857164d3f608be7c88b2b315b6c7b40a
2021-05-05tdf#139329: Shift widgets down and make hatch&bitmap list visibleKatarina Behrens
regression from commit cbe86ee37018dc4bf04783ecf70fef2863e61ad7 which inserted additional gradient colour picker but didn't adjust the positions of widgets below accordingly so in effect there were 2 widgets at position y=4 Sad that neither glade nor our own code detects this condition and e.g. asserts or warns this is the case Change-Id: I4c635eeb8b740765542631a5f0319bfe1a5d94d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115056 Tested-by: Jenkins Reviewed-by: Katarina Behrens <bubli@bubli.org> (cherry picked from commit c46a231b987b92bd866b415d1a0ba0d3a26a2457) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115074 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 4956d637401e07e9d562233d963739ec16d0d929) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115081
2021-05-03external/libwpd: Missing include for size_tStephan Bergmann
...as now reported when building with recent trunk GCC/libstdc++ on Linux: > In file included from WPXContentListener.cpp:26: > In file included from ./WPXContentListener.h:29: > ./WPXTable.h:56:31: error: unknown type name 'size_t'; did you mean 'std::size_t'? > const WPXTableCell *getCell(size_t i, size_t j) > ^~~~~~ > std::size_t Change-Id: Ic20240f01c7b0305cb87ababf53a3aaf66072d61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105324 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 8d378abf1de0a47517427c086da26588f846592a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/115000 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-05-03exteranl/coinmp: Fix build with recent GCC 11 trunkStephan Bergmann
It had started to fail for me now with > ~/gcc/trunk/inst/bin/g++ -DHAVE_CONFIG_H -I. -I. -O -MT CoinFinite.lo -MD -MP -MF .deps/CoinFinite.Tpo -c CoinFinite.cpp -fPIC -DPIC -o .libs/CoinFinite.o > CoinFinite.cpp: In function 'bool CoinFinite(double)': > CoinFinite.cpp:38:19: error: 'DBL_MAX' was not declared in this scope > 38 | return val != DBL_MAX && val != -DBL_MAX; > | ^~~~~~~ > CoinFinite.cpp:8:1: note: 'DBL_MAX' is defined in header '<cfloat>'; did you forget to '#include <cfloat>'? > 7 | #include "CoinUtilsConfig.h" > +++ |+#include <cfloat> > 8 | because of a missing -DCOINUTILS_BUILD. Which in turn was caused by workdir/UnpackedTarball/coinmp/CoinUtils/configure (see workdir/UnpackedTarball/coinmp/CoinUtils/config.log), which first tries to determine an ac_declaration that would apparently be a suitable declaration of `exit` without actually including <stdlib.h> in a C++ file. It settles on > configure:3551: ~/gcc/trunk/inst/bin/g++ -c -g -O2 conftest.cc >&5 > conftest.cc:15:17: warning: 'void std::exit(int)' has not been declared within 'std' > 15 | extern "C" void std::exit (int) throw (); using std::exit; > | ^~~ > <built-in>: note: only here as a 'friend' > configure:3557: $? = 0 (which generates a warning, but no error with the given g++ invocation). The determined ac_declaration value is then included in confdefs.h, causing the later > configure:4014: ~/gcc/trunk/inst/bin/g++ -o conftest -O3 -pipe -DNDEBUG -pedantic-errors -Wparentheses -Wreturn-type -Wcast-qual -Wall -Wpointer-arith -Wwrite-strings -Wconversion -Wno-unknown-pragmas -Wno-long-long -DCOINUTILS_BUILD -Wl,-z,origin -Wl,-rpath,\$$ORIGIN conftest.cc >&5 > conftest.cc:15:17: error: 'void std::exit(int)' has not been declared within 'std' > 15 | extern "C" void std::exit (int) throw (); using std::exit; > | ^~~ > <built-in>: note: only here as a 'friend' > configure:4020: $? = 1 > configure: failed program was: > | /* confdefs.h. */ > | > | #define PACKAGE_NAME "CoinUtils" > | #define PACKAGE_TARNAME "coinutils" > | #define PACKAGE_VERSION "2.9.11" > | #define PACKAGE_STRING "CoinUtils 2.9.11" > | #define PACKAGE_BUGREPORT "http://projects.coin-or.org/CoinUtils" > | #define COINUTILS_VERSION "2.9.11" > | #define COINUTILS_VERSION_MAJOR 2 > | #define COINUTILS_VERSION_MINOR 9 > | #define COINUTILS_VERSION_RELEASE 11 > | #define COIN_COINUTILS_VERBOSITY 0 > | #define COIN_COINUTILS_CHECKLEVEL 0 > | #ifdef __cplusplus > | extern "C" void std::exit (int) throw (); using std::exit; > | #endif > | /* end confdefs.h. */ > | > | int > | main () > | { > | int i=0; i++; > | ; > | return 0; > | } > configure:4045: WARNING: The flags CXXFLAGS="-O3 -pipe -DNDEBUG -pedantic-errors -Wparentheses -Wreturn-type -Wcast-qual -Wall -Wpointer-arith -Wwrite-strings -Wconversion -Wno-unknown-pragmas -Wno-long-long -DCOINUTILS_BUILD" do not work. I will now just try '-O', but you might want to set CXXFLAGS manually. to fail, because its g++ invocation including -pedantic-errors turns that > 'void std::exit(int)' has not been declared within 'std' warning into an error. There were similar build failures in the Cgl, > ~/gcc/trunk/inst/bin/g++ -DHAVE_CONFIG_H -I. -I. -I~/lo/core/workdir/UnpackedTarball/coinmp/CoinUtils/src -DCOIN_HAS_CLP -O -MT ClpCholeskyDense.lo -MD -MP -MF .deps/ClpCholeskyDense.Tpo -c ClpCholeskyDense.cpp -fPIC -DPIC -o .libs/ClpCholeskyDense.o > In file included from ClpCholeskyDense.cpp:11: > ClpHelperFunctions.hpp:16:4: error: #error "don't have header file for math" > 16 | # error "don't have header file for math" > | ^~~~~ > In file included from ClpCholeskyDense.cpp:11: > ClpHelperFunctions.hpp: In function 'double CoinSqrt(double)': > ClpHelperFunctions.hpp:81:13: error: 'sqrt' was not declared in this scope > 81 | return sqrt(x); > | ^~~~ and Clp, > ~/gcc/trunk/inst/bin/g++ -DHAVE_CONFIG_H -I. -I. -I.. -I./.. -I./../CglGomory -I~/lo/core/workdir/UnpackedTarball/coinmp/CoinUtils/src -I~/lo/core/workdir/UnpackedTarball/coinmp/Osi/src/Osi -I~/lo/core/workdir/UnpackedTarball/coinmp/CoinUtils/src -I~/lo/core/workdir/UnpackedTarball/coinmp/Clp/src/OsiClp -I~/lo/core/workdir/UnpackedTarball/coinmp/Clp/src -I~/lo/core/workdir/UnpackedTarball/coinmp/CoinUtils/src -I~/lo/core/workdir/UnpackedTarball/coinmp/Osi/src/Osi -O -MT CglLandPValidator.lo -MD -MP -MF .deps/CglLandPValidator.Tpo -c CglLandPValidator.cpp -fPIC -DPIC -o .libs/CglLandPValidator.o > CglLandPValidator.cpp: In member function 'int LAP::Validator::cleanCut(OsiRowCut&, const double*, const OsiSolverInterface&, const CglParam&, const double*, const double*)': > CglLandPValidator.cpp:66:22: error: 'fabs' was not declared in this scope; did you mean 'labs'? > 66 | double val = fabs(elems[i]); > | ^~~~ > | labs > CglLandPValidator.cpp: In member function 'int LAP::Validator::cleanCut2(OsiRowCut&, const double*, const OsiSolverInterface&, const CglParam&, const double*, const double*)': > CglLandPValidator.cpp:189:23: error: 'fabs' was not declared in this scope; did you mean 'labs'? > 189 | double smallest = fabs(rhs); > | ^~~~ > | labs subdirectories, and which happened to get solved by the same approach of removing problematic ac_declaration values from configure. I am not sure what all that magic of determining that ac_declaration value is supposed to be good for. There appears to be no trace of it in the corresponding configure.ac sources, so it likely was automatically added by some dated autotools (all three configure files mention "Generated by GNU Autoconf 2.59"). At least on a cursory look, the determined ac_declaration appears to only be used in configure itself, and not leak into the actual coinmp build stage, so dropping the problematic ac_declaration values is hopefully harmless. These three subdirectories were all that failed for me, but there might still be silent issues in other subdirectories when a problematic ac_declaration value would negatively affect other configure checks. (An alternative approach could be to regenerate all the configure files from their configure.ac sources with a recent autotools. But at least some of the existing external/coinmp/*.patch* already change such configure files, which would need to be adapted.) Change-Id: I0a33b0f654800e8288d3ca28e26a64efc23a3f6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103756 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 762aacc4e055fffbc605be81f66f2274dccb4be8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114999 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-05-03external/coinmp: C++17 no longer supports "register"Stephan Bergmann
...and GCC 11 trunk g++ now defaults to C++17, so compilation started to fail with that compiler Change-Id: I792e4c7ff59ad88e5571163d5b2362fdb349667d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99082 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit ad607d898f9826c6fa144783c93541a10ad4740c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114998 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-05-03external/liborcus: Missing includesStephan Bergmann
...as seen with recent GCC 11 trunk libstdc++: > orcus_xlsx.cpp: In function ‘size_t orcus::{anonymous}::get_schema_rank(orcus::schema_t)’: > orcus_xlsx.cpp:313:59: error: incomplete type ‘std::numeric_limits<long unsigned int>’ used in nested name specifier > 313 | return it == rank_map.end() ? numeric_limits<size_t>::max() : it->second; > | ^~~ etc. Change-Id: If92cfb565ed9344b2ec1403793d7aeff8bd019ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104074 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit a9976a958b2857e308c6598532151878615bfd9f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114997 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-05-02gbuild: don't use -Wunused-macros with sccacheMichael Stahl
In at least soltools, jurt and gperf generated files, build with GCC and sccache 0.2.16-alpha.0 reports spurious -Werror=implicit-fallthrough= due to comments and these go away by configuring sccache with rewrite_includes_only = true. But his results in cc1: error: ‘-fdirectives-only’ is incompatible with ‘-Wunused-macros’ so disable that like for clang-with-icecream builds. Change-Id: I6dec38e86aa6e22591d7a700a8daddf3fed88b16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111716 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 6fb9f368c6824a8ff7bc5bc5cf66fc2df7d055b7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114856 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-04-30tdf#137945: sc: Add UItestXisco Fauli
Change-Id: I6fa935d0c77556113ae087a67c2932ddcee12a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114871 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114935 Tested-by: Jenkins
2021-04-30apparmor: Fix "oopslash" typoRico Tzschichholz
Change-Id: I8b355bceadeebebc9e6fedbf92a35aa44a356e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114819 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit f616d96bd8ce8986e4cc204953db0467e6060b5c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114866 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 12c9b81927aae792743ce3dbc0b09fecdb15b33c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114870 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-29tdf#137945: Revert "use more FastParser in ScXMLContentValidationContext"Xisco Fauli
This reverts commit ae854970bf9c734df132797c0f23a7829efd167c. This is only reverted in libreoffice-7-0 branch. See https://bugs.documentfoundation.org/show_bug.cgi?id=137945#c2 Besides, this commit partially reverts d32289d715f7182b9e82a4d3fde9cfcf87517da3 < loplugin:unusedmethods > and be9f45ad69a510185971957e7643fd64b873e98d < loplugin:unusedenumconstants > since some methods and enumerations are needed after reverting the commit Change-Id: Ia71257a37d384e7eb6ba904a6a13f8ae5603a79b Change-Id: I04c74ceb6e38c54ea41464b8337016bb5f81d90d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114882 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29tdf#135997: fix toolbar controlMike Kaganski
This is the same as fc7b4bfeba39a2479c9a2c9c8ef5ced5ab3c0de7, just for the toolbar control (the older one was for special character dialog). The problem was present since 800ac37021e3f8859a52c5eebca261a5d3bc5a11. Change-Id: Ib86aa7336a3078ff28b417de37fbd5bc492c85c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114719 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit b27de500b1412bacefc7144b5222c307ca1ae0fe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114853 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2021-04-28update creditsChristian Lohmaier
Change-Id: Idd3d14c272c1eebca7207054dccbeae4632c51cc (cherry picked from commit 93a90a5b0558aeac847aefe06f49f68c00a26678)
2021-04-26tdf#132472: do not set text color when table style is 'Themed-Style-2'Xisco Fauli
and it has no Accent Regression from 2c3f7d4ee0a0b2bf6efc41670645bd361f1b76ef < tdf#107604 Handle predefined table styles. > Change-Id: Id9ab5b20825e2eaf8cc138c108608fe446f33db4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114477 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 54f7c32beca5a9c99d7316dc38818edad55f7415) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114497 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114649
2021-04-24elementary: tdf#141823 unify function iconsRizal Muttaqin
Change-Id: I01a3f6be32a02c8762d81d27c93b38760ebfc66e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114592 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-21tdf#139305 make both 'empty' widget and its treeview replacement the same sizeCaolán McNamara
so on flipping one visible vs the other the panel scrollbar position is equally valid for each mode Change-Id: Iae422c30eb8b752c407070b66852fe23fdc38912 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111925 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 0d20074eb112186e0e2fa4241b57777a335eb68c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114438 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-21tdf#86321: Revert "Resolves: #i123539# some optimizations for 3D chart..."Xisco Fauli
This reverts commit db1d2af02861b49e4f53d726d59cd71c20cee9b1 The commit was already partically reverted in bca8d8985666d3fd22b91eb280f9baaeb933c2d0 < Resolves: tdf#90583 3D pie-chart missing guide handles >. This partial revert broke the optimization introduced in db1d2af02861b49e4f53d726d59cd71c20cee9b1 <Resolves: #i123539# some optimizations for 3D chart...> for 3D charts like https://bz.apache.org/ooo/attachment.cgi?id=81810 Later, 3D charts were optimized again in 55a7e836a2db662a53adc4f8b98d08b06790c758 < chart2: When creating objects prevent setting object rects dirty > so the remaining code originally introduced can go. Import time of https://bz.apache.org/ooo/attachment.cgi?id=81810 is the same with and without this patch Change-Id: I25338d0dfb4b41651dfe05e7bfbd74c86091dacb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114313 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit eec03e848cb6874ce6d64dc0b8f45dbaf52e6c2b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114277 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114325
2021-04-20Better handling of filelocsStephan Bergmann
Change-Id: Ic9c06cb476942ceb7d0166f22103e2e88cc9c21f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114339 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 177dcfec4e833f83f1f11c7bdbfc6f1977ebcee7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114355 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-20bump product version to 7.0.7.0.0+Christian Lohmaier
Change-Id: Ide7b3ae495ba963637b5a8f2e1da3a8c486dae2c
2021-04-20Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-0' to 33b4a0389b295ea30030dda8510ed7f4895f8369 - update translations for 7.0.6 rc1 and force-fix errors using pocheck Change-Id: Id5c85dc0e0a4c8bfb067e1b2dd7c6a56bf0640fe
2021-04-20tdf#141525 Fix "Line with Arrow/Circle" insertion error.Jeff Huang
When you insert "Line with Arrow/Circle" from "Lines and Arrows", it will show "Line Starts with Arrow" instead of "Line with Arrow/Circle". This patch can fix this issue. (This issue exists at least since 6.3 series.) Change-Id: I827b9582951fe359d89245970e73d63f7697553f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113963 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com> (cherry picked from commit 2b498e380a91a536d177376e854cf3a6e2fb0b35) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114179 Reviewed-by: Po-Yen Huang <jeff@mail.ossii.com.tw> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 4ee3d213e8d3c4afdc3714b50def117dfe5c8023) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114275 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-19svx: fix crash in DefaultProperties::dumpAsXml()Michael Stahl
mpItemSet can be null Change-Id: I4192f84639116c550bba5303a5fc70528cb3e8c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114263 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 832b23d9376019619929764606276aacde1e329a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114273 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-19tdf#132901: do not add updatecheck to libmergedXisco Fauli
LibreOffice crashes if "online update" feature is not installed Regression from c63148ba139bd6b9ae7a0f9e24e51f29e5370963 < Revert "Revert "add some libs to libmerged"" > Change-Id: Ia18f50bc6baf830b2d3e0814645ef04283bfaa04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 6064446f828f8cd612f7d6660153b2eb1139239b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114272 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-18Colibre: Revise some iconsRizal Muttaqin
Change-Id: Id52445cc75293d44ac29a11692ad39f27472544b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114221 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> (cherry picked from commit 31bd90673226938ada8cc89875ca8db77233d3fe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114185
2021-04-16tdf#140639 cache FcPattern for font optionsCaolán McNamara
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> also includes... getFontOptions is always called with pitch of PITCH_DONTKNOW getFontOptions is called from only one location and there the pitch value is left at its default PITCH_DONTKNOW which is suspicious but that's the way it currently is Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> use original FontAttributes instead of an intermediate FastPrintFontInfo Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> hintstyle is unused left behind after... commit 561a02ec72cf963d7cd59cfb9a183c1032f0861b Date: Thu Jun 15 15:28:46 2017 +0200 loplugin:unusedfields in vcl part3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Change-Id: Ibb1b1e06630e505924e05ea4b5b454e58738d743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114140 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 365df37004630b68afafdc676e26f2599c2194a9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114011 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-14tdf#141623 Qt5+cairo init surface with widget sizeJan-Marek Glogowski
The QFont based rendering path directly uses the widgets size to initialize the QImage buffer image, so do the same for the Cairo surface, instead of the arbitrarily size of 640x480. Change-Id: I91326dab67cbbb5e75b78b02c34eaca61ad26482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113955 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 91c883e75436210ca8af95df1ca597caeeda8703) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113869 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 3f204ca2fed7614e1e12180af5ce5bfd88249eb7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113870 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-12Related tdf#117750: fix "Solarization" and "Aging"Julien Nabet
For solarization, regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=c38485279cd36da96ac81107d567ea4e779b2b96 author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:27:41 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:11 +0200 commit c38485279cd36da96ac81107d567ea4e779b2b96 (patch) tree ad9843a17f87271f9e0cf89643e2e6c3ee8a8de1 parent bcbf767bcfc024e2be839e0c0886f942dd068e4f (diff) vcl: ImplSolarize() to BitmapSolarizeFilter For aging, regression from: https://cgit.freedesktop.org/libreoffice/core/commit/?id=1ab12471f3a69c4d502e6271e84ddf8a981f507f author Chris Sherlock <chris.sherlock79@gmail.com> 2018-04-20 20:32:23 +1000 committer Tomaž Vajngerl <quikee@gmail.com> 2018-04-22 05:33:39 +0200 commit 1ab12471f3a69c4d502e6271e84ddf8a981f507f (patch) tree 6652276229ad1c3ffca48f7a31e1b77d2ea04b07 parent c38485279cd36da96ac81107d567ea4e779b2b96 (diff) vcl: ImplSepia -> BitmapSepiaFilter Change-Id: I4f350aa8b494caf55c9c810ac7fa9ed8db349725 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113926 (cherry picked from commit f3151e62bcc7cb66313df70a2ec8eed8ca8f2c88) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113858 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d41693f2eb48fce3d808f1719bbd60f2d2041203) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113868 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-12Related tdf#117750: fix UnsharpenFilterJulien Nabet
Change-Id: I372bb6baae747adb3b2d2a2b8fd39d1631b074ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113927 (cherry picked from commit 3d32e6a6ccfae56f379cb1dec6dcadf9aa8fa85f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113859 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 8a75c591ef0cb017c58a7f068d1ae6571f87bd90) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113867 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-12Resolves: tdf#139075 diagonal focus rects contain focus rects of old sizeCaolán McNamara
since... commit 356f6c5d89dd4dd92b2351898e07f99b96cb34cc Date: Tue Jan 15 08:55:00 2013 +0000 teach FrameSelector to be resizable Change-Id: I5ac4d1d12f60086349e7dbb3b78d29977f22c226 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113857 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-11Sukapura: tdf#141618 fix blured vertical line of Sukapura's anchor markerRizal Muttaqin
Change-Id: I11b3fca85ec00049dfe84df6cfb548a320e255cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113937 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> (cherry picked from commit d9f10d8f0f6bae31dd5ebd9fa00f989d17fc21da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113866
2021-04-11tdf#141600 fix blured vertical line of Colibre anchor markerRizal Muttaqin
Change-Id: I5acab0328fd40e7eb4043a77197d78925c38237a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113862 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-11Colibre: Revise some bullet/numbering iconsRizal Muttaqin
Change-Id: I6ff3e82cc02272e10314cc92e6ee584fcc50724c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113864 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-09tdf#141547: maQueryItems can be 0Mike Kaganski
E.g., fillQueryParam (sc/source/ui/unoobj/datauno.cxx) may clear it and leave empty if relevant input item is empty. Note how commit e4b924df8f9ad02c66549751cb8e123e420e8508 had changed the same checks in ScQueryEntry::IsQueryBy[Non]Empty. Change-Id: I552462c72e69ddce43711bcff645dc6c7b133db7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113783 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit a0d2fb3217094aa7158310f0bcf16093bcc4984f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113757 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 7ba4eeb2e9b8153eb17779c93492ab80a5cd4644) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113767
2021-04-07xmlsec: fix signing documents on WNTMichael Stahl
Duplicate ds:X509Certificate elements cause: warn:xmlsecurity.comp:9604:3820:xmlsecurity/source/helper/xmlsignaturehelper.cxx:658: X509Data do not form a chain: certificate in cycle: (regression from 5af5ea893bcb8a8eb472ac11133da10e5a604e66) Change-Id: I3d319a2f74dbec17b73f1c7bb8f4efe4e335f0ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113746 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit ae08aa8a095832ae2a88eac14f9680ac8d3a13b6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113752 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-04-07tdf#141297 : remove link to the fileArnaud Versini
Change-Id: I5c14f46f5fbd51d95eeb58ea0a6d3aa39afef3cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113597 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 7289b9a90f5f8349875856c552330d512004925e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113642 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 6494b99f09a29c22d51fb898423ced36ce02a9e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113645
2021-04-06tdf#139786 partial revert tdf#106181 XLSX export: output form controlsJustin Luth
Not every export is going to be to OOXML format, so don't just set ooxmlexport to true and remove the "if" clause (especially when leaving the comment that this is for DOCX only). This is a partial revert to 7.1 (and backported to 6.4.5) commit 577dd32b1c4eb0a4cff574fbabca987cb52b831b. Change-Id: If7ea32a236715ec779cac302773c4c9da19865a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113399 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit a3c5c0f7ce73001adab7475fde1f8ffec4eef48b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113484 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 4d63b046679539c1e0f5a6f44e87c9420d679f5b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113638
2021-04-06ofz: Segv on unknown addressCaolán McNamara
Change-Id: I6c69375a89781fc0b87230203335c861efb562f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113482 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-06tdf#141084 don't notify that the control has changed content until focus-outCaolán McNamara
while also keeping tdf#140239 working too Change-Id: I42833f6a4d2440781cf3f2297b78c6e313b3d239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113474 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit d0628bd6813de2685f4367118dc0f9ca036d1eaf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113477 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-05KJ: Improve small Select Outline Format iconsRizal Muttaqin
Change-Id: I18fd7e4656b12790ad8896cbe56f3896f4a178f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113435 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> (cherry picked from commit bc4f06a80a234ae4a90864a075df1e94ced3045a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113369
2021-04-01xmlsecurity: replace OOXMLSecParser implementationMichael Stahl
This is similar to 12b15be8f4f930a04d8056b9219ac969b42a9784 and following commits, but OOXMLSecParser has some differences to XSecParser, such as using a ds:Manifest, and requires a couple extra namespaces. Change-Id: I56e39d9609db8fcad50ca1632ff482c1f0a30ff5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113381 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit cc1d19f7bbaefa5fb22ebd1344112755068b93c9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113360
2021-03-31python3-ify hrcex & uiex (creation of pot files)Christian Lohmaier
Change-Id: I824c9ed536a1e852d6bd157fbd7d4766327b7bcd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113319 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 9dfd55dffc4cca6617b4ee67be9a8bfe96601c00) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113354 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-03-30tdf#140556 master document view not launching subdocument from context menuCaolán McNamara
Change-Id: I0ae61e51266ae050e340c1af99e0dd6a481e6ff9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113282 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-30Resolves: tdf#135364 ensure the window is released by a11y disposeCaolán McNamara
the window dtor wasn't called with a11y enabled, with the side effect that the pen color wasn't stored by the dtor Change-Id: I5f482f53d4d93f1e2632cacf7c0a7407f0df1450 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112956 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-03-29sw fr_FR AutoCorrect: fix crash using "Apply and Edit changes"Julien Nabet
Bad calling of SvxAutoCorrect::FnAddNonBrkSpace() in French documents, see tdf#140849 for a similar problem. Change-Id: I19b964fb8fe437c7f98342a873a456ffded75d82 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112120 (cherry picked from commit df41967a29c4f8243d1df2d9b23d7c41d4a13819) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112792 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-03-29tdf#122717: fix handling of zero width/height linesXisco Fauli
The code was introduced in 627c2469843c9461b665c4571f1214aca7fc36a4 < tdf#96674 drawingML import: fix handling of zero width/height lines > and later on removed by 36bade04d3780bc54c51b46bb0b63e69789658a5 < tdf106792 Get rid of SvxShapePolyPolygonBezier > with the comment "I doubt that the additional code to make a line not exactly hor/ver is needed. Checked and it is not needed, thus removed the change from tdf#96674 in shape.cxx." it turned out, it's still needed Change-Id: Ib64ee17227e3e588e94381abeabe5a2ff2e0b7d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113102 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 3e4eb070787d4d44b3bdc95046e5b231dbbef42b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113119 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 11d344f6271e4171f8006c2cb29372f612cbdc00) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113123 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-03-29Breeze: Add Save All & Save a Copy iconsRizal Muttaqin
Change-Id: I0371bf3fd30f451c8dbb3f62c1bbae4532755662 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113221 Tested-by: Rizal Muttaqin <rizmut@libreoffice.org> Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-03-28Sukapura: tdf#141282 fix wrong icon for Demote One Level with SubpointsRizal Muttaqin
Change-Id: I63ee5a71f52a51a1682f924982c68c33c60781be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113203 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org> (cherry picked from commit 2eb3c3ebfadc0927c0cdb2dad2c8f7716557ab3b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113212
2021-03-27Colibre: tdf#141284 Inconsistent Track Changes iconsRizal Muttaqin
Change-Id: Ib2ff76d83e49b6ba5c68d3b461c0608bd589f955 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113131 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>