summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-11tdf#135565 prepare font preview virtual deviceCaolán McNamara
make SalInstanceComboBox::create_render_virtual_device do more setup to have an appropiate default background. Change-Id: I43aeb6ffe85d21f11f3ebb1f981c0db67247e5db Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102424 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-11tdf#131581 inhibit updates during all_foreachCaolán McNamara
Change-Id: I8494b4c9175e427bfb89696d49c2da7607af37ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102380 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-10tdf#136238 speed up deleting large cross page tableNoel Grandin
Goes from more than 30s to less than 1s on my pc. We were getting stuck inside the loop in sw::UndoManager::AddUndoAction, because the RemoveOldestUndoAction was continually doing nothing because it was hitting the if ( IsInListAction() { assert(!"SfxUndoManager::RemoveOldestUndoActions: cannot remove a not-yet-closed list action!"); return; } code. Which means that there is some bug here, but I'm not sure what. We are deep inside the delete logic at that point, and it doesn't seem unreasonable to opportunistically delete some of the UNDO list at that point. So the real fix is just the conversion from a while loop to an if-check. Change-Id: Ie2707009dd6574b996421f67d952ab9fdaaaf6aa Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102378 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit da5c289a9cae5d914937f235694fd5b0cb92547f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102313 Tested-by: Jenkins
2020-09-10tdf#135042 update scrolledwindow vadjustment when resizedCaolán McNamara
Change-Id: I94408845b82c7202f74360168c66c4439e985124 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102271 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ebfd1c859f9da4318999a145d6af0fd33372dc6b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102299 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-10tdf#135950 crash in format->character with selected text in tableCaolán McNamara
Change-Id: I66e36a638d040d2a38ac234383d6f314a2ff4d88 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102309 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-10blacklist amd driver with vulkan version <= 2.0.49 (tdf#136553)Luboš Luňák
It's from 2018 and there are newer versions available (although maybe not for older Windows versions). Change-Id: Ib3e8973c90b6ef9eee160cd2436978741150a2f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102290 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 3f620e74aa00e34f773d97e9480a6532d9e8863e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102307 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-10Update Flatpak to org.freedesktop.Platform//20.08Stephan Bergmann
...see <https://github.com/flathub/org.libreoffice.LibreOffice/issues/129> "Update runtime to 20.08" Change-Id: I3eb60e7c020857209f30cbed24c60f6a0627f938 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102353 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 06e7d988b3099d545dd61f6e9c6b4f6e1ad66dae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102306 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-09tdf#119286 speed up find/replaceNoel Grandin
SvxSearchItem is very expensive to construct, so move it outside the primary loop. This takes the time from 6s to 3s for me. Change-Id: Ie6491761e69c4f787910d7ecfbd071b7e68efd35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102231 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 1159f58831c69680e9f10767d5358e13b66579dd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102300
2020-09-09allow xor mode with Skia drawTransformedBitmap() (tdf#136575)Luboš Luňák
I thought this wouldn't make sense, but the document uses invert and then VclProcessor2D::RenderBitmapPrimitive2D(), which simply uses DrawTransformedBitmap() with its transformation data (which is a no-op I'd guess). Still, don't bother with the possibly complicated finding out the bounds, just invalidate the whole area. Change-Id: I309953338f11d1c1c90c684bf0314e60bc44a249 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102267 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 8821bd663ed75fb2c9706b102e1d6f8ccfcf00f5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102298 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-09Resolves: tdf#136364 treat svSep type with ocUnion as range typeEike Rathke
So for RPN sv...Ref(ocPush), sv...Ref(ocPush), svSep(ocUnion), sv...Ref(ocPush) another svSep(ocUnion) instead of svSep(ocSep) is appended. Regression from commit a6032ff5418ad66cc8fec10c636e32b124ee7864 CommitDate: Thu Oct 11 11:26:37 2018 +0200 Resolves: tdf#90698 catch list (1;2) of non-references as error that introduced a conditional check on operands and operators. Change-Id: If5da3a781f24f891ff12c4a8f32a2ec92c6b4c8a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102276 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit e00e2be30436b636d93f8852bb6af44972638a7c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102295 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-09tdf#136471: Applying a spell checker suggestion adds the result ..Tamás Zolnai
also to the autocorrect replacement list Change-Id: I68d055fd55ffae210fff59ada1b925cdf7b34fb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102193 Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> (cherry picked from commit 36bd42e1e57604731fafd556331010578f9233fa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102204 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-09Resolves: tdf#136494 get preferred height after contents filled inCaolán McNamara
an empty widget appears to be less tall than one with content in the default Ubuntu theme Change-Id: I6b759b37d6706e6a4c3ded492d9c5b23f322e328 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102133 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-09tdf#134477 add VclMessageType::Other to indicate image-less generic InfoBoxCaolán McNamara
Change-Id: I76e86bf4d82b33771ea2900517712be57ae7f03d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102234 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-09Check range before accessing Calc sort userlistThorsten Behrens
Conflicts: sc/source/filter/excel/excrecds.cxx Change-Id: Ib5078dc4ce3f85be9b42320b60ef6fc40b684cb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102140 Tested-by: Jenkins Tested-by: Serge Krot <Serge.Krot@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102253 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-09-09tdf#127932 fix wrong page number in print progressJuergen Funk
- in ctor, reset start pages to non-inflated value after size calculation - update label, _then_ progress in setProgress() Change-Id: I66576e339de814922512b68167e6c0a9b1025378 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102031 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 63bf8f042abe3c0f6989f6763d13f5389182b816) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102280 Tested-by: Jenkins
2020-09-09tdf#108673 XLSX: Don't export invalid sheet references in cell validationSerge Krot
Change-Id: Id9d88f5e34f3017516f693505df4c3ce82b1890f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98479 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit a3b4831208da615789bd1e2d5660dd130807f504) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102127 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-09tdf#95640 XLSX: import/export of custom sort listsSerge Krot
Conflicts: sc/source/filter/excel/excrecds.cxx sc/source/filter/oox/autofilterbuffer.cxx sc/source/filter/oox/tablebuffer.cxx Change-Id: If5ffef39770bf7abd6e75e8de998d4a2b4749a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97399 Tested-by: Jenkins Tested-by: Serge Krot <Serge.Krot@cib.de> Reviewed-by: Serge Krot <Serge.Krot@cib.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102252 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-09-09tdf#134708 Text coloring of buttons within forms amendedThorsten Wagner
Change-Id: I55f91ff626a55ab588ac49a085070c0d9f919e68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99564 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 84b2849512bdb19597739d9515dd55e2d3ba9504) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101857 Reviewed-by: Thorsten Wagner <thorsten.wagner.4@gmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-08tdf#135149 sw: fix deleting textbox of as-char shapesMiklos Vajna
Regression from 7596e26fd259ce5445212949403e7cd32303b2bd (Add SwTextBoxHelper::findShapes, 2014-06-24), the problem was that in case the shape is as-char anchored, then DeleteSelection() returns false, and so the textboxes of the deleted shapes are not deleted. There is no real reason why deletion should be conditional on the DeleteSelection() result, so just move it outside that block, so textboxes are always deleted. (cherry picked from commit da4f9b77a6cd39b1ae5babdd476d1575c8b9371c) Conflicts: sw/Module_sw.mk Change-Id: Ib3bd444e9e96f9de0f68a9162ab39255ec5a6807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102220 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-08xmlsecurity: pdf incremental updates that are non-commenting are invalidMiklos Vajna
I.e. it's OK to add incremental updates for annotation/commenting purposes and that doesn't invalite existing signatures. Everything else does. (cherry picked from commit 61834cd574568613f0b0a2ee099a60fa5a8d9804) Conflicts: include/vcl/filter/PDFiumLibrary.hxx vcl/source/pdf/PDFiumLibrary.cxx Change-Id: I4607c242b3c6f6b01517b02407e9e7a095e2e069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-08tdf#112342 DOCX import: fix page break before image-only paragraphsAttila Bakos
Picture anchored to an empty paragraphs was moved to the previous page, because the deferred page wasn't handled here. Change-Id: I4a694dd443ca8b67c4addbcba3523bffecd21418 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99763 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit e520a4f988bf0ff81e75e37588182af92fed7631) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100945 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08Use PRODUCTNAME_WITHOUT_SPACES for SDKDIRNAMETor Lillqvist
Change-Id: I2e3e45ffba563dc1b13b3b66346debd9690d0abe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102217 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-08tdf#136455 unused ComboBox menu listening to GtkListStore and slowing insertsCaolán McNamara
Since tdf#131120 we don't use the original ComboBox menu, but it's still listening to additions to the ListStore and slowing things down (tdf#136455) Change-Id: Ie2383e1a4b28f0787559132d93236df5c641cb06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102119 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-08blind fix for testTdf130685 intermittent failureCaolán McNamara
Change-Id: If6f330ebbe63a5438769fda771d68afb1dcadf2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101977 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 37ee5d5a41c99cddae0652d839539df91f28f35d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101963 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-08intermittent forecast.ets.add.fods failureCaolán McNamara
valgrinding the forecast.ets.add.fods failure gives... a) mnSmplInPrd is 9 b) ScETSForecastCalculation::prefillPerIdx:476 fills mpPerIdx to index 8 with values. c) ScETSForecastCalculation::refill:791 (the bAdditive branch) due to nIdx = ( i > mnSmplInPrd ? i - mnSmplInPrd : i ) with i of 9 gives nIdx of 9 and uninit mpPerIdx[9] is used in the calculation. d) At line 799 (the !bAdditive branch) due to nIdx = ( i >= mnSmplInPrd ? i - mnSmplInPrd : i ) the nIdx used would be 0 not 9 under the same circumstances extending the initialization of prefillPerIdx to zeroing out the next index gives the same results as we usually get and test passes without a need to change it while avoiding the use of an uninitialized value. Change-Id: Ib4629b28ecf2389c0c7611137b756d4d2d9fd700 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101997 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e3545d491e2a2c4ff609a63385994f0c8d388edf) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101961 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-08blind fix for tdf129346 test intermittent failureCaolán McNamara
Change-Id: Ib3bc0ce0bdeee01c3c752d935e195f677b6f6d4c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101978 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 3b0f53beed3e0e21b0fc4d8efc38d404637404a0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101962 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-08tdf#120760 DOCX shape import: fix Z-order with behindDocSzabolcs Toth
DrawingML attribute relativeHeight contains z-indices for shape Z-order, but this depends on behindDoc, too. We can use z-index = relativeHeight - MAX_INT32 on shapes with behindDoc=true, as a simple workaround to get correct Z-order, because unsigned relativeHeight values stored in sal_Int32, and MIN_INT32 <= -MAX_INT32, and the temporary negative z-indices will converted by GraphicZOrderHelper. Note: this commit doesn't fix the old writerfilter implementation problem, that DOCX relativeHeight is an unsignedInt value according to W3C XML Schema, i.e. its maximal value is 4294967295 (MAX_UINT32), not 2147483647 (MAX_INT32). Co-authored-by: Balázs Regényi Change-Id: I54a72a95bc69b307b2835636fff376b0aa9bc45c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96614 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 6479096dc2bd40215ff80273b4d27cadb2688cb1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100947 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08pdfium: only init pdfium library one and destroy on LO exitTomaž Vajngerl
With more and more usage of PDFium, it is hard to keep track of the life-time of the PDFium library, so it can happen that a FPDF_DestroyLibrary happens when we still have another instance where PDFium is still use. The result of this is a crash. To prevent this, just initialize the library once and delete, when on LO exit. This can be improved in the future to only keep the library active when in actual use. [ Leaving out the vector graphic search bits, the motivation is to just have this in libreoffice-7-0, so that recent pdf sig verify improvements can be backported. ] (cherry picked from commit 067a8a954c8e1d8d6465a4ab5fb61e93f16c26c2) Conflicts: vcl/source/graphic/VectorGraphicSearch.cxx Change-Id: I5c7e5de7f8b97d10efb394c67c7a61b976c8d57c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102226 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-08tdf#136545 revert cairo canvas uses cairo for text rendering alreadyCaolán McNamara
This was the fallback path, so the problem must already exist in the uncommon fallback case. I think I know the best approach to take, but for the 7-0 case be conservative and restore the historic state. this reverts 770892a387361067d23ab08ed38690c50b8b9395 and associated code removal Change-Id: I0e61d934e4dae03442ca5910f802199a1d3d53f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102197 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-08tdf#136323 qt5: Remember accessible objectMichael Weghorn
'QAccessibleCache::insert' from the Qt library has a 'Q_ASSERT' checking that the corresponding 'QObject' for which the 'QAccessibleInterface' provides information is actually the same as the object passed as a parameter: QAccessible::Id QAccessibleCache::insert(QObject *object, QAccessibleInterface *iface) const { // ... QObject *obj = iface->object(); -> Q_ASSERT(object == obj); However, 'Qt5AccessibleWidget::object' so far was always returning 'nullptr', triggering this assert when using a Qt version not built with 'QT_NO_DEBUG'. To fix this, remember and return the object as needed. Change-Id: I4015b4c37aa8a073b02465df580a7235884e6cf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102196 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 4461d49c6cfce22c2c96185b0a1d07bfe9709268) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102125 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-07Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-0' to ef96ef3b0ec7c8ab41e66ef699eb3b7b0ff59c03 - update translations for 7-0 and force-fix errors using pocheck Change-Id: I9e06cb7ebd382546645ac29a6b54068c544a6407
2020-09-07tdf#134607 workaround – mac langpack: don't verify target locationChristian Lohmaier
for some reason the commands used don't work for some users Change-Id: Iecd5ffdfcb5c7d8cd5c4202fed0906ebf1ef68f9
2020-09-07xmlsecurity: avoid saying OK when the signature is partialMiklos Vajna
That's reserved for valid signatures (digest match, certificate validates and the signature covers the whole document). Also avoid "invalid" in the dialog when the digest matches and the signature is just incomplete. This now uses wording which is closer to Acrobat and also uses the same wording on the infobar and in the dialog. (cherry picked from commit e76d021ac44e7bf4de05899dc2694a96470bc707) Change-Id: I26e4781d555b65cf29aa8df2232e286917235dc1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102186 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-07tdf#136474 wait until mouse grab is dropped to trigger selection callbackCaolán McNamara
Change-Id: I495b90b9661c32ad3ec71c2a2455d1576fb8f918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102116 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-07rhbz#1875377 if sort order is equivalent keep order fontconfig presentsCaolán McNamara
there are two fonts in fedora 32/33 for regular Cantarell /usr/share/fonts/cantarell/Cantarell-Regular.otf and /usr/share/fonts/cantarell/Cantarell-VF.otf where VF is the Variable Font version. The Cantarell-Regular ones has a CFF table and export to pdf creates a font subset that works perfectly fine. The VF one does not have a CFF table and the fallback case doesn't work for pdf export. Both have the same version, use a stable sort to retain their relative order that fontconfig presents so we use the Cantarell-Regular version we would see if we didn't sort by version at all. Change-Id: I750006b980810fc59e0a152d42ae17f29f46e3b3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101970 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-07tdf#136032 - abort scan of a string beginning with a hashtagAndreas Heinisch
Abort scan of a string beginning with a hashtag, if a comma is found. Otherwise, the compiler raises a syntax error. If the string ends with a hashtag too, it will be parsed later checking for a date literal. Change-Id: I078a2302f5c65206367a00fbc584ffa7b9ede031 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102099 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 11292d1cc405e7c3b9e1f374cc7581a63a54b994) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101973 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-06Revert "tdf#136377: Replace yum by dnf for Fedora in readme.xrm"Julien Nabet
This reverts commit d96ca67b22e3b42cf79637d3f6497d02a9f48656. Reason for revert: It breaks the string freeze Change-Id: I7909b74a9bd4e8eafccbd56cb5a0a19d110a81e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102114 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-06tdf#132688 diacritics broken in lines with punctuationNoel Grandin
regression from commit 4b2d4f3c4a68361a6bc03c9ab110ce9376b14b20 tdf#119227 fix freeze when copying a large bulleted list Change-Id: I7d54b19c7a02c717426edce7896caaadf909154e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102000 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins (cherry picked from commit 18e4367c33f327cf09985105bde583cdcc7b2a46) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101972 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-04tdf#136377: Replace yum by dnf for Fedora in readme.xrmJulien Nabet
Change-Id: I62ec93d7051bbb795f01f6779f65d7fbf77a672a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101904 Tested-by: Jenkins Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101964 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-03tdf#136094 Handle background color in drawNativeControlMichael Weghorn
Make gtk3's 'GtkSalGraphics::drawNativeControl' take into account a control's background color, if any is explicitly set: Set background/fill color (in 'Edit::ApplySettings') also for the case where the control is drawn "natively", but don't draw the background in the generic 'Window::Erase' method for the case of native drawing; instead handle it when drawing the control itself. This adds an additional parameter to pass the background color to the relevant '{d,D}rawNativeControl' methods (defaulting to 'COL_AUTO') and implements the required handling to apply the background color for the gtk3 case. qt5/kf5 will probably be handled in an upcoming commit as well. Windows as well as the "gen" VCL plugin were not affected by the issue, so remain unchanged and just ignore the new parameter. In a quick test on on macOS, the rendering of the controls in the sample doc was broken beyond just the missing background colors (s. screenshot attached to tdf#136094); the behavior there also remains unchanged by this patch, the new parameter is ignored for now. Change-Id: I01923a504fea2367ae96032104f09099e35f410e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101284 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 2c9052802ea411dffbf5906c4914611fcbfbc6a5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-03tdf#136423 make SwXDrawPage::group work with a single shapeSamuel Mehrbrodt
No reason this should not work (and the implementation in Draw/Impress/Calc also works this way) Change-Id: Ic5bc7420e9025b45ed848dccf68b112c0c6c2cd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101842 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 3eb5318ed9ae8cf02804fbdc584a5f4b046db0ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101955 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-02tdf133647 tdf123386 tdf123389 fix DOCX table formula exportLászló Németh
Keep original DOCX table formula during round-trip using grab-bagging. This is a temporary solution until fixing formula export and a proposed solution for formula cannot be converted. Follow-up of commit 68e74bdf63e992666016c790e8e4cfd5b28d6abe (tdf133647 tdf123386 tdf123389 Improved .docx table formula import). Change-Id: Ia4759e250c06e9cc0495fb0b57fccd1ee1f50da9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100872 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101758
2020-09-02tdf#133163 DOCX: export formula cellsLászló Németh
as formula fields instead of exporting only cell text content. Only unmodified formula fields were exported from commit d42776e01b87f12fddbcf78101bca1e10a6e4f97 (tdf#118682 DOCX: export formula fields). Now newly added Writer formula cells or modified table formula fields imported from DOCX (which are converted to formula cells after formula editing) are exported. Change-Id: Iecec75b2a36b94c2d3aa998603ac10ea2f2b8d4e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100667 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101893
2020-09-02tdf#133564: Text coloring of buttons within non key windows on macOS amendedThorsten Wagner
Change-Id: I815fcf82440a7e5d14ae457cc659a5fe6a9f8c52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99946 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 4b1ecab984dc46ad7dfdd8a071c94553a6c03633) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99920 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-02tdf#118682 DOCX: export formula fieldsLászló Németh
Convert also cell references by removing parenthesization: =<A1>+<B1> -> =A1*B1 =SUM(<A1:ZZ99> -> =SUM(A1:ZZ99) See tdf#133647 for fixing import of cell references. Change-Id: I5082198aaf8230989f99984f8129b54867b77859 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100546 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101892
2020-09-02no polygon merge in Skia if they contain no straight lines (tdf#136240)Luboš Luňák
Merging polygons with beziers is even more expensive, and those are very unlikely to be parts of a larger polygon that are meant to line up perfectly. Change-Id: Ic9d641d3264b962896347ed52addeca2a0d5ea22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101742 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 7957a3c6ab6ba4b61b0a237b680e6393029cc426) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101859 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02do not try to merge a single polypolygon (tdf#136240)Luboš Luňák
Change-Id: Idad860288baf736caeefe9883d12ab50cca37dff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101702 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 8a930585b102eb9b63f7e43b646a8f07ad780ac3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101858 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-02Resolves tdf#135790 - Support for multiple %MOD1/2 entriesHeiko Tietze
While loop added Change-Id: I81386bb23381e5248f3c045ad2b998a92346ec34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101700 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit db5f204b1d3d96975d902b587d6d18bc06610eea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101860
2020-09-01tdf#134491 Calc sidebar alignment fixandreas kainz
Change-Id: I9ea341f5980dfc4998075a7f9d8f6432145c1d13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101588 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com> (cherry picked from commit 977a97f3148c0aece0a54304aae81ec44ced07e0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101468
2020-09-01tdf#133015 Add test for multicolumn textboxes.Gülşah Köse
Change-Id: I92d6af17313fb5a4a27fc8768b8f3fbe64db1816 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100452 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101751