summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-09-30bump product version to 7.0.2.2.0+libreoffice-7-0-2Christian Lohmaier
Change-Id: If7c43a3e9b1803bc46437cfb8a70ce4b55a01a68
2020-09-30tdf#134782 sw,unotools,officecfg: adapt configuration and UIMichael Stahl
Store AddParaLineSpacingToTableCells in configuration as "AddTableLineSpacing", consistently inconsistent like AddTableSpacing (the <desc> elements are not subject to translation). Adapt SwCompatibilityOptPage with some ugly hacks to allow 3 different states (TriState) for the corresponding checkbox that map to false/false, true/false and true/true. The checkbox widget doesn't allow to change *to* indeterminate but at least the status of the document can be displayed this way, with a non-obvious tweak to optcompatpage.ui to reference "checktri1" column. Change-Id: I5f32e05c93b5e16e782cba5d1d055809d9e5e251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103318 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 68aec8fd57eda8c05926b7f361dc102772f2c501) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103358 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit b8cbc02fbd4d8662de75d5a7a3bab6525caf766d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103583 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-30Related: tdf#136559 set multiple columns in model at the same timeCaolán McNamara
reduces time from 40s to 13s Change-Id: I01d6a4fcaa5a868f9b9f9292f4a7e99e216ea23b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103156 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 4475895d1b1da285bfe5bd73e383f1356d5e01b2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103570 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-30update creditsChristian Lohmaier
Change-Id: I84bfd619b2f8802bc311eaa221670a9cae904160 (cherry picked from commit fb9b3e68dc4bf88a1a2764cbcd6420dc2a475220) (cherry picked from commit e94ed51b3de0588dece1e0470ddcb600061ad67b)
2020-09-30Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-0-2' to dd96f1b0daacbabd978360110e13147144bcb1a8 - update translations for 7.0.2 rc2 and force-fix errors using pocheck Change-Id: Icc6c8d4e27bf80431ec26c8ceb37848058038c85 (cherry picked from commit 4a12b40c8751323705d82539be43d04990f934a9)
2020-09-30tdf#133358 fix crash in redoing indentCaolán McNamara
since... commit b070202b420129b5edd368420e0e50ec45261d01 Date: Tue Nov 20 18:26:18 2018 +0100 sw_redlinehide_4a: SwEditShell::IsMoveLeftMargin(), MoveLeftMargin() Change-Id: Ie28207747560153020341305015f1693f6ca9f50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103552 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit dc6e005c79b6c23b805dea44cd89fa83ea945f03) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103577 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit fdc92d35d95f5b89a333cc48fdc36108e1094973) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103582 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-09-29tdf#134782 sw: split AddParaSpacingToTableCells flag in 2Michael Stahl
commit 3cccdabf19a99fd3f657985c1822436d7679df2b "extend AddParaSpacingToTableCells with line spacing" changed how the ADD_PARA_SPACING_TO_TABLE_CELLS compat flag works, to improve interop with Word. This commit splits out the change as a separate new compat flag ADD_PARA_LINE_SPACING_TO_TABLE_CELLS ("AddParaLineSpacingToTableCells"), to preserve compatibility with ODT documents that were produced by LO < 6.4 (via SwXMLImport::SetConfigurationSettings()). New documents and WW8/RTF/DOCX import have both flags enabled. The combination false/true is invalid, and treated as equivalent to false/false. Change-Id: Ida20df8fe4a8192a714f91da95345f9726fd7d98 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103317 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 38aa699f265c17548769aaa4f20e1ae35d18f202) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103331 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit dc1ce5130a8df5017662c83be26bdada6098ee37) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103443 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-29Related: tdf#136985 SfxStringListItem::GetString() crash in empty caseCaolán McNamara
probably since... commit a573b8b21688d9681f4fa129ec37cf89954e9d1c Date: Sat May 21 16:14:56 2011 -0430 Replace List for std::vector in SfxStringListItem. Change-Id: I7060b5693ba08fa5f70cc5cb3ae1b7a4722a31a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103340 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 7c8f997321e136208e8983ab6ad78cc33891125f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103571 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-09-29tdf#136737 grid in change icon dialog ends up oversizedCaolán McNamara
Change-Id: Ib3d28fc967bf5e1b95d71ebe42e1fc540ea91ac3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d9ae83e596e94c4d4967c5de653c2060b0648c78) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102929 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2020-09-28Fix crash from broken font CMAP subtableJan-Marek Glogowski
ParseCMAP crashes on a broken CMAP subtable of a font used by the bugdoc of tdf#119074, which returns a negative offset (technically it's large positive offset turning into a wrong negative integer, which is still out of bounds of the CMAP overall size - you get the point). This simply ignores that broken subtable, checking for other existing ones. Regressed-by: c7482bc2904401e7d975b5721ec861b8589253f9 Change-Id: I95820fe3bb6bd2fe2e0cf9d4c3536abce31fd497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103033 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 9bf4c5ac49b73cc2a8c89a87ff87238c061a579d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103046 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 229aca48befa4bdb52041ce6d0dca16a87b778e4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103060 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-09-28Resolves: tdf#133812 Add the 'Result' style again used by the Subtotal toolEike Rathke
Necessary to also adapt the test case that checks for a defined number of styles. Regression from commit 7b0aed617f1e57335837cf56ef2d222a96f8270d CommitDate: Wed Sep 28 11:42:56 2016 +0000 Remove old cell styles from calc and commit 06f319937187f76ee402d53b3baa78c391c2af19 CommitDate: Sun Oct 2 13:51:26 2016 +0000 tdf#90937 Add a set of cell styles to calc Change-Id: I3e47d8e24d375a64d9056e7a85197b89173c8e41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103520 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 930d82550863430c9bef96ac307c3ff2cfefe4d8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103432 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 4cabc8e6574feb08cd7b80de9bc59c1c8f1797c3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103442 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-28tdf#134157 fix Edit with external tool causes a CPU hitTomofumi Yagi
Switch Idle to 100ms Timer for fixing the bug Change-Id: I85a9bdcb173edd28d952d8e91c1b93d748e69206 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102984 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit f110c037114f90d219ac8d149542bf96fe66a2f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103055 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 1d28170d94893171e2a358274cda62cd73f7b834) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103059 Reviewed-by: Tomofumi Yagi <yagit@mknada.sakura.ne.jp> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-28Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-0-2' to 287b08358accb5a99502502264216e038c22f0ec - update translations for 7.0.2 rc2 and force-fix errors using pocheck Change-Id: I3a4c88013d4b701e3f87370f33b7350a121b5bd5 (cherry picked from commit 3cd66665e066425ba507151b6ab90ca1f0eed00e)
2020-09-23tdf#135879 sw: fix bookmark dialog's Delete buttonMichael Stahl
(regression from cb5d18871b46ef4f7bc47eb4d71df5374d712575) Change-Id: Ic8c66504a760ef26fbf95a5a1a13b37346982024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103015 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit fefcad1186232b26180d095bbafdf8e8bdda8209) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103049 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 88084ceca708a343fc79249f91eb9de34d26b3e9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/103058 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-17tdf#136805 PDF export: re-add XMP basic meta dataJan-Marek Glogowski
VeraPDF complains about: <rule specification="ISO 19005-1:2005" clause="6.7.3" testNumber="1" status="failed" passedChecks="0" failedChecks="1"> <description>If a document information dictionary does appear at a document, then all of its entries that have analogous properties in predefined XMP schemas, shall also be embedded in the file in XMP form with equivalent values.</description> <object>CosDocument</object> <test>doesInfoMatchXMP</test> <check status="failed"> <context>root</context> </check> </rule> The regressing commit dropped the XMP Basic schema meta data (http://ns.adobe.com/xap/1.0/"). FWIW: xmp is the referred prefix, so we'll continue to use it. Regressed-by: d016e052ddf30649ad9b729b59134ce1e90a0263 Change-Id: I11b06fdafcb07732b92f0bd99b18afa3a9e498ef Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102888 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 06e35b3289090ec623fe5284976ee6f40681e1d5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102771 Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 4684f8e09ac540a85b843b2306a9e9edeb8c17ec) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102773 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2020-09-16bump product version to 7.0.2.1.0+Xisco Fauli
Change-Id: I9fa64ea4065fb63849458200058a20e8c3e1013f
2020-09-16Branch libreoffice-7-0-2Xisco Fauli
This is 'libreoffice-7-0-2' - the stable branch for the 7.0.2 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.0.x release, please use the 'libreoffice-7-0' branch. If you want to build something cool, unstable, and risky, use master.
2020-09-16detect if a cell still needs interpreting after Interpret()Luboš Luňák
https://bugs.documentfoundation.org/attachment.cgi?id=51878 after hard-recalc asserts because of not having cell dependencies non-dirty for threaded calculation. This is because Interpret() actually sometimes returns without computing a value for the cell, e.g. when it backs out because of a need to do iteration. This is handled when Interpret() is called from InterpretTail(), but ScDependantsCalculator does not handle this and considers all cells interpreted, unless it detected a problem. We've already fixed a number of such bugs, and given that there are still problematic corner cases after all this time, add code simply detecting this generic problem and avoiding threading in that case, with a SAL_WARN. This does not fix the problem itself, but at least now it's handled. Change-Id: I2f454b577f6516d2ce008005dbfbeb554e18d811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102156 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 4f36f2ccab6286ec09480caea602c0fa19195736) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102308 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-16tdf#96725: Add LSHandlerRank for the recently added AppleWorks DocumentTor Lillqvist
When submitting for the App Store Apple enforces that each document type in Info.plist has an LSHandlerRank. Change-Id: I1f963cef31e87ed2176178754490a1e2194e4743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102238 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102630 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-16tdf#135799: properly load arrays in user-defined types from imageMike Kaganski
This requires to reset Fixed flag temporarily, as in SbiParser::DefType for non-image case. And save the dimensions of the arrays in the custom types correctly: the dimensions are numbered from 1, not from 0. The existing unit test (that happened to not test anything actually) was fixed. Change-Id: I48c6b6d5d735d9972a2c0dd40345d5db75f87f39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100877 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102748
2020-09-16ofz#25684 keep ParseCMAP within legal areaCaolán McNamara
Change-Id: Iee18b5a9390b79efa67414ea2d229d2816c84e18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102756 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-16ofz#25696 OOMCaolán McNamara
Change-Id: Ia69e9ce1ca0156e960dddb7e0bf98dfd2be2d7cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102759 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-16tdf#131537 DOCX export: fix OLE "Display as icon"Daniel Arato (NISZ)
for example to avoid converting OLE icons of an ODF document to an icon-size embedded spreadsheet. When creating a new OLE object in Writer the user has an option called "Display as icon" which causes the actual contents of the OLE to be hidden when rendered in the document. This setting, referred to internally as the DrawAspect of the object, was imported fine, but when exported to a .docx it always had the value "Content" (corresponding to "Display as icon" being unchecked). Now OLE objects with "Display as icon" checked are saved with DrawAspect="Icon". A grab bag entry was previously used to let the DrawAspect setting flow through Writer from OOXML import to export. Now this workaround is no longer needed and is removed by the present commit. Change-Id: I46ea4fc95a26bcd1f85e19a506c0965f73d4257a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101711 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 07dcb0dab759d4ab535d99c0e6d326959906b87e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102652 Reviewed-by: Dániel Arató <arato.daniel@nisz.hu> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2020-09-15Update comma in decimal icons, ^ font colorRizal Muttaqin
Change-Id: I3cb10675d7220ea60c3ef1f6e931a84859126687 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102697 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit e8e14a2289783135f60813e316fcfded48e5f598) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102643 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-09-15tdf#131420 DOCX export: fix missing border of frameTibor Nagy
Co-authored-by: Attila Szűcs (NISZ) Change-Id: If6ce28aab938eaf22fe578f8880e139b7b4eb22c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100418 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 49e2bd6103669ca94d4e308fc08beed57f85c7e2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102754 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15tdf#134225 Chart view: fix moved date labelBalazs Varga
outside from pie chart. Do not need to check the sector size of a pie slice, before best fit algorithm, so we can use the CENTER position as a start position of BEST_FIT. Completion of c66cb6d6e4a843dc7c7d06e1c2c0723a6ff85fc5 (tdf#134029 Chart view: enable to move data label) Change-Id: Ie1a53784e7df2887282155113bf8bb607cdb09e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96945 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 57fedb272cfcad3436142dbe9eac2870e3c3e3d2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100054 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15Colibre: tdf#134928 remove red stripe from background color iconsRizal Muttaqin
Change-Id: If0aeb80c5307166d0db9f4f7ea34dfe2d59b9df2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102698 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 4ece7d97c4866b5e639caff5fb3bcec3dceceb8d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102644
2020-09-15tdf#135623: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I77bc9e22d294ecc218b1570e75742344ef1d2ea4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102668 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102715
2020-09-15tdf#133490: sw_uiwriter: Add unittestXisco Fauli
Change-Id: I8a0660922e29d0dfaf8b859d396b88997a46bc92 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102108 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 7b4b1cb7c753fadbc20892ef8cc961b7a61e8d19) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102648 Tested-by: Jenkins
2020-09-15oox smartart: handle <dgm:prSet ... custT="1"/>Miklos Vajna
Which defines that a data node has text properties as direct formatting, so autoscale should not happen. We decide autofit at a shape level, smartart defines custom text props at a data node level. So take the shape, go to its first presentation node, get its data node and see if it has custom text props. If not, continue to scale text down till it fits. smartart-autofit-sync.pptx is extended to contain a 3rd shape: the first two have their autofit scaling synchronized, while the 3rd has a fixed font size of 10pt. (cherry picked from commit 89b385c2336e5b3868d2a040e11134b349b7d010) Change-Id: I6caacdaab9a36072b9ad5021bd217c955b09b790 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102712 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-15oox smartart: add support for syncing font heights of multiple shapesMiklos Vajna
When 2 or more shapes have their text set to autofit and they have a constraint like: <dgm:constr type="primFontSz" for="des" forName="node" op="equ"/> Then make sure that the automatic font size is the same for all shapes and all content fits, by using the smallest scaling factor from all relevant shapes. Some rework is needed, because normally oox::drawingml::Shapes don't have access to their parents, at the same time there can be multiple SmartArts on a single slide, so storing the grouping info in the filter is problematic, too. Solve this by storing the grouping in the toplevel oox::drawingml::Shape and exposing them in XmlFilterBase just during the time the children of the toplevel shape of the SmartArt are added. This works, because we know SmartArts can't be nested. (cherry picked from commit 1bd3474c7c7945e1182dfbaca89be05ea98dd3e8) Conflicts: include/oox/core/xmlfilterbase.hxx Change-Id: I6c591eadc7166c7c42752650afdb7ee1e416cff6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102711 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-15svx UNO API for shapes: allow setting a max factor for autofit text scaleMiklos Vajna
This allows getting the scale factor from multiple shapes (that have text), seeing what factors they use and then setting the factor to the minimum of the values. Towards allowing both "autofit" and "same font size for these shapes" at the same time for SmartArt purposes. (cherry picked from commit 81345de4858d6e72ecb8fc6621396570f4a4ee93) Conflicts: include/svx/unoshprp.hxx Change-Id: I31a5e097c62e6e65b32956a4a32137bc3339c64c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102710 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-15svx UNO API for shapes: expose what scaling factor is used for autofit scalingMiklos Vajna
TextFitToSizeScale is 0 when the shape has no text or autofit is not enabled, 100 when there is autofit (but no scale-down), a value between the two otherwise. Towards allowing both "autofit" and "same font size for these shapes" at the same time for SmartArt purposes. (cherry picked from commit cd268f0047443ddbb22361cdc15093e881f83588) Conflicts: include/svx/unoshprp.hxx Change-Id: Iff88fcc4c2e67b543687b1d87d614622cbf2e38a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102709 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com>
2020-09-15tdf#135665 DOCX: import tight wrap setting of VML shapesDaniel Arato (NISZ)
The wrap setting that OOXML calls "tight" and LibreOffice calls "contour" (== true) was not supported by the import code, only the export. Change-Id: I48739ffaad48e28df05fd87a9b51a14238dc47e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101932 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 4b7ee7bd61f78be60211cc72ba36da987191266e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102124 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15tdf#135181 Calc print preview zoom slider print preview not transparent (gen)Noel Grandin
Change-Id: I7244f429194145df99a4b52fce144c6ec45f3b61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102168 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 00cffc20e40b2412c7e9867eed24c9834504e24f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102646 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15tdf#135184 add linecaps in chartsRegina Henschel
Chart is currently not able to interpret property linecap. But in case of linecap 'round' or 'square', line dashes lengths are adapted so that they look same as in MS Office (tdf#134053). This does not work, if the corresponding linecap property is not interpreted. Dashed border of data labels is not fixed because of bug tdf#135366. In addition I have fixed errors in prstDash detection, which I have noticed while creating unit tests. The unit tests cover file text, not visual appearence. Change-Id: I8cf2d2b2fc0923c2882f8148b4550bc363270480 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99562 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 74be8bb787a44464957e5d3105c8de6d36e81b4a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/101871 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15add Korean autocorrect items ㈜ & ㉿ tdf#132614DaeHyun Sung
add Korean autocorrect items(Bracket to enclose characters). Insert -> Conversion (주) -> ㈜ [U+321C] (KS) -> ㉿ [U+327F] In Korea, It usually used these marks. Popular word processor in Korea, such as MS Word, Hancom HWP, support these autocorrect items Change-Id: If6248689cea06bfc4182dd0bbea5e9d26286517d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102331 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 080c0ba99a0499f2033ccc10586e6ad5e8d8b542) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102642 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-15tdf#135682 sw: fix lost selection-all when doc starts with tableMiklos Vajna
Regression from commit c56bf1479cc71d1a2b0639f6383e90c1f7e3655b (tdf#105330 sw: fix lost cursor on undoing nested table insert, 2019-09-16), the problem was that the change reverted lcl_notifyRow() back to its original state, because it seemed the conditional notification is no longer needed. However, this broke the fix for tdf#37606 (ability to select-all when the doc starts with a table). Fix the problem by handling the starts-with-table case similar to a normal table selection, so there is still no need to restore the nested table visitor code but select-all works nicely with starts-with-table documents again. (cherry picked from commit 6f1e02c96b887750f974c187a82ecd6236e6a435) Change-Id: Icb823a39432d1774a63a0c633c172bba827ac76d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102704 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15tdf#132483: DOCX import: fix OLE anchoring positionBakos Attila
The relative orientation of OLE objects was not copied from the replacement object to OLE, resulting bad position. Co-authored-by: Attila Bánhegyi (NISZ) Change-Id: If62124e5a40218a224e047efbe86a09606b44af5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98493 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 54031e6a2912ebe723b4423b5d737c13c9bb03c5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102565 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-15rhbz#1878275 should use value_changed for spinbutton changesCaolán McNamara
Change-Id: I8d042eb9c288e9db69a49cb9e097b23cf765aae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102640 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-15crashtesting: failed on export of tdf118002-1.potx to pptxCaolán McNamara
because the bg isn't set a master isn't exported, so the endelement XML_sldMasterIdLst isn't exported and the document is broken so don't exit early if the propertyset isn't found and always call ImplWriteSlideMaster Modify the ppt variant PPTWriter::ImplWriteSlideMaster to do nothing on an empty propertyset allowing PowerPointExport:ImplWriteSlideMaster to output its XML_sldMasterIdLst on the last master Change-Id: I512ee10b3b3c80b6566827d708b737c6c502c3b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102451 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit b7756fdde63b1eef85ef13772fc3578e345d34dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102422 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-15tdf#136512 listen to style-updated on pEventWidget instead of toplevel...Caolán McNamara
m_pWindow to avoid infinite event loop under Linux Mint Mate 18.3 Change-Id: Iaeec4538c7a3c1d49042c4eeb6d30ffc6ab01af8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102416 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-15application level settings-changed event callbacks not triggeringCaolán McNamara
this was originally... ImplDelData aDel( pWinEvent->GetWindow() ); while ( aIter != aEnd && !aDel.IsDead() ) before commit 1db7af8bc9febdf72138fac533ec81d6983da729 Date: Tue Jan 26 22:10:52 2016 +0530 tdf#96888 - Kill internal vcl dog-tags ... back then if GetWindow was null ImplDelData.IsDead() was always false Change-Id: I1e75c27635532afa08ed43bf92bda35b34ae6320 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102423 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-09-14Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'libreoffice-7-0' to 34b00bb82652966efc92051785d099eaf0681f77 - Online help CSS: improve link colors so Olivier doesn’t hate me Change-Id: Ia03fdfe89ac578891458b19657486d398d4bc1b4 (cherry picked from commit 0b73d5eb91c2e1d1c179dccc9e81be0f0451c719) CSS: Separate this rule out of the block Change-Id: I1c7ea2603fcbb8a6668cde831848246bb4d1c3a4 (cherry picked from commit 1e21cf1fa77421ab7abd52d55af1662a6890766e) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/102392 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-09-14tdf#135623: modified generation of unique fly nameVasily Melenchuk
Modified lcl_GetUniqueFlyName() is right now always marks current fly format name number as used. Yes, this can lead to some gaps in numbering is some cases, but meanwhile guarantee that there will be no duplicates if format name does not match SdrObject name. Change-Id: If39ed993614ae1665deba21ae8d5e6bd542fb6e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102460 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 07a695ec1988ee8b02256cab2e07a1b429ead24b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102636 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2020-09-14tdf#133327 fix calc loading background color with many colsNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa tdf#50916 Makes numbers of columns dynamic. Change-Id: Ic9e1b31d74b11367a5ad1a82480ffe9467c37ad8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102535 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 4176beb7ef831152ce92ac3fa31314438635ec2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102634 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-13tdf#132561 fix png export from DrawNoel Grandin
fixes a regression from commit 61e8387fa8ab55a04b95839c7c385c163d6de1cd tdf#128992 Compressing PNG files with alpha channel get a black background Change-Id: I8a225f76072c49f64393bb4b28c4d92c6e85587e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b732e63a0a4b4dcf74995adf7b679d12ecc09db5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102567
2020-09-13tdf#133502 annotation has wrong positionNoel Grandin
regression from commit 20c5a2abb61c4246c6001b7b6d5bd69cd5882cfd use FastParser in DrawAnnotationContext Change-Id: Ifc4a8d6390d37edfb375f37d513418b77f38d842 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102515 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 35612c995d53d74e8b9ba44bc6e940cbb4dd0f60) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102568 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-09-12Resolves: tdf#107459 MATCH() in descending sorted array find last equal valueEike Rathke
... not reverse the first equal value. This only affected the array/matrix argument case, not cell references. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102493 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 6f80e2d37ce11e3ea728b7ce5987f912fdfa60b3) Conflicts: sc/source/core/tool/interpr1.cxx Change-Id: I0ff574a5132b6ee93789ac32f6c5de02465263f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102428 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-09-11tdf#134413 must add scrollbar width on turning it off to occupy the same spaceCaolán McNamara
when scrollbars have width Change-Id: I3f9f6951add23f8ac93a03cf3356add5a2b3ddd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/102288 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>