summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-08-18Update the reference rdbs to libreoffice-7.0.0.3Stephan Bergmann
LD_LIBRARY_PATH=/data/sbergman/lo-clang/core/instdir/program \ /data/sbergman/lo-clang/core/workdir/LinkTarget/Executable/unoidl-read --published \ /data/sbergman/lo-7.0/core/instdir/program/types.rdb \ >/data/sbergman/lo-clang/core/udkapi/type_reference/udkapi.idl * no changes LD_LIBRARY_PATH=/data/sbergman/lo-clang/core/instdir/program \ /data/sbergman/lo-clang/core/workdir/LinkTarget/Executable/unoidl-read --published \ /data/sbergman/lo-7.0/core/instdir/program/types.rdb \ /data/sbergman/lo-7.0/core/instdir/program/types/offapi.rdb \ >/data/sbergman/lo-clang/core/offapi/type_reference/offapi.idl * (XDcoumentHandler getting moved around now is a consequence of this being the first fully-automated generation of the file again after the manual modifications done by the preceding 214e6caf2c503d817c47ebcc419e4f7e33b336ac "[API CHANGE] remove BasicImport UNO interfaces" and ebb66ee09b6041cbf755f24e54f2d1a510bbc3d3 "Fixed update of the reference rdbs to libreoffice-6.4.0.3-buildfix1".) Change-Id: I841b6b5a059c78750fa7f02f9276c6b6f86c9afd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100892 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-18tdf#135016 DOCX export: fix unexpected error on save with undo/redoMiklos Vajna
Regression from commit d379d18666aa42031359ca8eb34b0021960347ae (oox: import WPS shape with text as shape with textbox, 2014-06-18), then problem was that when undo restored text deleted by cut, we ended up with an SwXShape that had no frame format. Fix the problem by deleting the cached old UNO wrapper after changing the association between a textbox's shape and text frame. An alternative would be to handle errors better when the TextBox UNO property is not of type bool, but that would still lead to silent data loss, so don't fix the problem that way. Change-Id: Id45ad292befc746e7c49a3b827c91efd069d29df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100876 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-08-18Dereference of nullptrMike Kaganski
... opening attachment 164348 from tdf#135799 Change-Id: I7d9b38bf34c7120fee39707ed99a0e6e2c2c84e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100878 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-18elementary & Colibre: tdf#131456 Orientation iconsRizal Muttaqin
- elementary: Update page margin & page size icons Change-Id: Ie5189a1b29ab791c6ec74a6c2c692d8864f8d9a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100890 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-08-17tdf133647 tdf123386 tdf123389 fix DOCX table formula exportLászló Németh
Keep original DOCX table formula during round-trip using grab-bagging. This is a temporary solution until fixing formula export and a proposed solution for formula cannot be converted. Follow-up of commit 68e74bdf63e992666016c790e8e4cfd5b28d6abe (tdf133647 tdf123386 tdf123389 Improved .docx table formula import). Change-Id: Ia4759e250c06e9cc0495fb0b57fccd1ee1f50da9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100872 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-17Don't forget to increment refcount when loading from imageMike Kaganski
Otherwise it will fail assertion in SbxValue::Clear, because SvRefBase::ReleaseRef would check that its current count is not zero. In release builds, not doing this would leak. Change-Id: I80dfc815f8a2b651ff290af10808212281abf246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100879 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-17tdf#135799: properly load arrays in user-defined types from imageMike Kaganski
This requires to reset Fixed flag temporarily, as in SbiParser::DefType for non-image case. And save the dimensions of the arrays in the custom types correctly: the dimensions are numbered from 1, not from 0. The existing unit test (that happened to not test anything actually) was fixed. Change-Id: I48c6b6d5d735d9972a2c0dd40345d5db75f87f39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100877 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-17tdf#134052:shadow appears solid instead of blurry in presentation modeA_GAN
Add shadow primitive id into the switch case to run ProcessPrimitive2DOnPixelProcessor function. Change-Id: I059771ba4c56eca50c74aad81c4dec193b454dca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100861 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-17tdf#135338 sw layout: show FirstLeft on very first left page style.Justin Luth
Although extremely unlikely, the Left Page style can have a different Left and FirstLeft. In the even more unlikely case that the document starts off using a left-page-only style, then the first header would not show on the first page, but only on all of the following left-only pages. So, of course, we want the very first visible page in the document to show the defined First header/footer. Change-Id: I7e74fdc085509fb8d6b80f36d1402309b9db9404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/99862 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2020-08-17Fix typosAndrea Gelmini
Change-Id: Id31299912b822baf9eecbb03cba53339f0528ae8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100867 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-08-17Add test for preserving page number when suappingTomaž Vajngerl
Change-Id: I1a7028d1768d0098aabbbc519d1b7936ddfc4a48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100838 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17move vector graphic search to View, so it works in multiple viewsTomaž Vajngerl
VectorGraphicSearch was instantiated for the Outline, which is the same for every view. The problem with this is that when we have multiple views, the search would interfere with each other, which is especially distracting in online when multiple users connect to the same document and try searching. This adds VectorGraphicSearchContext class, that is added to the View, which makes the search view dependent and multiple instances of VectorGraphicSearch are created, each one for its own view. Change-Id: Ia0f34647b30b35f4ddb84d33353990d635756905 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100837 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17loplugin:unusedmethodsNoel Grandin
Change-Id: I31002cc322c43498ef8c37f6b7f94ae1a8278ba9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100857 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17Remove redundant Invalidate()Michael Meeks
Probable merge error in CWS impressfunctions dc5479dcc39. Change-Id: Ifa8dc9dbeeecf2dd6da44909060b72a20a7042a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100783 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-08-17fix box2dtools build error for non debug buildsSarper Akdemir
Removed the asserts and moved the functions out of the box2DWorld class. Change-Id: Ifa58bceb2c64c1012e5d0e65bc12646312ab1c16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100856 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-08-17Always display highlighted JRE's locationStephan Bergmann
...when opening the Advanced options page and after adding a new JRE via the "Add..." button, not only after highlighting another JRE line. (I suspect this broke with 1aa246a8e8c7d974ab0f7bdfa16cda36cb700e03 "weld SvxJavaOptionsPage" towards LO 6.4.) Change-Id: I5f9b63e2d33a351eeef09712969b703f1e99ef7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100860 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to e8c9e70e057aec51c783b7230f1995020374d06f - update translations for master and force-fix errors using pocheck Change-Id: I9e806cc79950a35df80dc1ffeab84cd5f18dc861
2020-08-17inline some use-once typedefsNoel Grandin
Change-Id: I683175c1e788a2a4cfec9504dc8dc3ebfee7c5de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100858 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17vcl: save and load the page number when swapping the graphicTomaž Vajngerl
PDF vector graphic includes a page number, of the page that the graphic is rendering. This however isn't remembered when swapping out and back in the graphic, because the serialization format doesn't include it. This adds a version 2 of the serialization format, with an additional page number (page index) attribute. Also changes the GraphicTest to account for an additional 4 bytes written and the change of the checksum. Change-Id: Ic0fbfc4ad983f7880e06956da3b4664bd4b610d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100836 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-08-17Move compilerplugins-related .gitignore content to compilerplugins/.gitignoreStephan Bergmann
...and expand it to precisely match the three .dwo files, like had already been done for the corresponding .o files. (Those .dwo files are generated when -gsplit-dwarf is added to CLANGCXXFLAGS when manually overriding CLANGDEBUG=1.) Change-Id: Ib6f1c505c754d54201273f08f987a9451af75bc4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100855 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17Remove dead commentStephan Bergmann
...which had been dead ever since b525a3115f54576017a576ff842dede5e2e3545d "initial import" and whose removal has already been suggested in 04bb20f5ad182fd1aa8a4e2e7f569043be8405c1 "Fix typo" Change-Id: I57d1e284e9c38836dca620fd3d0058fc5c6f098e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100854 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17solenv/flatpak-manifest.in: Merge "Clean krb5 module"Stephan Bergmann
<https://github.com/flathub/org.libreoffice.LibreOffice/commit/0b374f83d160f64b47a802dde2b8aa2201671cd8> Change-Id: Ib7aa25f6296a49d3ffaa7055d4d5c055ce6dacbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100849 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17Related: tdf#135743 position combobox dropdowns correctly for RTLCaolán McNamara
Change-Id: I4f8e70e128fd8506e7f95291226fc52599f15896 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100758 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17tdf#135743 only overwrite our geometry with the valid entriesCaolán McNamara
Change-Id: I228ebfed17d922704d72529c714fde220b9d20cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100825 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17[API CHANGE] remove OSL_SIGNAL_USER_RESOURCEFAILURENoel Grandin
which is unused since commit 00657aef09d854c74fb426a935a3e8b1fc390bb0 Date: Sun Jun 11 20:56:30 2017 +0100 migrate to boost::gettext Change-Id: Ia66a3a729dc4999c95b96ae1754b07c372121370 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100810 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-17tdf133647 tdf123386 tdf123389 Improved .docx table formula importMichael Warner
Converts table formula syntax from MS Word to LibreOffice. This version uses the list separator of the document for the formula regexen; however, it does not convert the decimal or list separators in the case where the person opening the document is using a different locale from the author. Change-Id: I9600a0bea060a76705a7ad6b051ed4fdd50b9d40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98614 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-08-17sw: prefix members of SwNode2LayImpl, SwRetrievedInputStreamDataManager, ...Miklos Vajna
... SwXDrawPage and SwXShape See tdf#94879 for motivation. Change-Id: I0cfdc1a1b7e1667dccf8db29616b895a76b8fea5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100843 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-08-17tdf#132892 Revert "sw: paragraph-sign: erase metafields ... correctly"Caolán McNamara
This reverts commit b402d0112a0bb53221b847fa372bfa3f6390a0e2. Change-Id: I210d2fded01fb952d7384b78240e32d868b08575 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100753 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17tdf#135743 ignore size-allocations triggered by an embedded SalObjectCaolán McNamara
getting configured, we already ignored them for painting, do the same for the size-requests it output from our internal configuring Change-Id: I4c0153535459b089ba6c31e3d9f09bfae2545806 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100824 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-17"loplugin:stringstatic also look for local statics" macOS reduxStephan Bergmann
...plus addressing follow-up loplugin:stringconstant when inlining the literals at their sole call sites Change-Id: I727e2d3fe53e85af328afc5fba92e52fb63c49b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100839 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17Remove leftover debug includeStephan Bergmann
Change-Id: Idca54798ab5ad464f8a641eb6250cb20aa2147ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100840 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-17loplugin:loopvartoosmallStephan Bergmann
And while at it, merge the change from e2bd5afd726abd5df438b6b821416bd7cf496e4d "Make the C++/UNO bridge work to some extent on macOS on arm64" into the existing code in a better way, reviving the assertion that openMax will be non- negative when entering the loop. Change-Id: I4b4e173a79ae6a0bbbf07df87d46761e86f460c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100841 Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-08-17Use transparent buffer to correctly process transparency in metafilesMike Kaganski
Otherwise the transparency gets converted into b&w mask here before applying the gradient. Required for tdf#134052. Change-Id: Ife00f75024f7d776fdb11e16fcafbd237f07eb04 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100830 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-16tdf#134439 honor FN_PARAM_PAM argumentsCaolán McNamara
which was dropped by commit bba8e5aa6d1968e5279b3fe368c0f81145513d04 Date: Thu Mar 1 21:00:24 2018 +0100 tdf#116070: Use a valid PaM when confirming the dialog. when fixing commit 34527cec54ca634b831cfa5ac1098c4046818ac3 Date: Tue Jan 16 18:54:19 2018 +0100 lokdialog: Convert the Format -> Paragraph... dialog to async exec. so, go back to using pPaM instead of rWrtSh.GetCursor but make a copy of pPaM to avoid the crash of tdf#116070 Change-Id: I0aaaf5173c6be47dd306b77eacbb07d0e1c4eaf1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100670 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-16Pass $(verbose) into ExternalProject_icuStephan Bergmann
Change-Id: I4c93d4c4207645795812a0cafb64cbe32a7a520a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100823 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-08-16let tab switch between cellsCaolán McNamara
Change-Id: I12806e2afc022c079d9db758973b8d1bfc0c7107 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100752 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-16tdf#135342: filter list must include extensionsMike Kaganski
Regression after commit a0dcc8f78061d22d925f31ef8d03ca751ad6dc19. The commit had added extensions to the filter names sent to file dialog, but kept internal list of filter names aFilterEntryList without extensions. Then dialog returned the chosen filter's name in the form it was sent there, i.e. with extension; and that name couldn't be found in aFilterEntryList. So let's keep aFilterEntryList synchronized with the UI names in the dialog. Change-Id: Ic21d19d1a8d0b7f64ccfb517a7d0ee8ab36fc6a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100821 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-08-16Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 94dcf7ef3fdb4f4722d2cc3d3d8a5713bf45d7b3 - tdf#135688 Help page for Comparison Options Change-Id: I51c60ebfd39e5d90025cea1cea74a9a3dd3ce0ab Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100822 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-16tdf#133026: Additions: Set the maximum length for extension nameYusuf Keten
Change-Id: I52c6fe32e7737e1e0160cfd585d8616a035320c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100657 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-16tdf#135550 make XComboBox Item status changed event work againCaolán McNamara
Change-Id: I323a114d3b71a74267ee7a89c5fb29821611e57e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100751 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-08-16Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 4fc3877798e3160da8d340c065cb8d72c596e496 - Fix typo Change-Id: I3291e75e14af1c840ae1fe6e343341fae464a4b1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100782 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-16Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 7e5538c28f59d785d56d38987c07b0b2d1a77e2f - Fix typo Change-Id: I28353f846a0bc3c5d9bf8350b2228174780f3933 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100781 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-16Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to 3422c57c7f8b770def12ab81bf5cfd32749aa140 - Fix typo Change-Id: I43bea4f872ff58d0544114201703c5fd03f42328 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100780 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-16Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to b70626ee6892fa08ff71854ee5ac56716e2f7af4 - Fix typo Change-Id: I8c8fdfb65910b36072ac55aebcb2e4eabaeb7f48 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/100779 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-08-16loplugin:unusedmethodsNoel Grandin
Change-Id: I2dd10873be73256a3689233c7b1e37bde8f685ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:singlevalfieldsNoel Grandin
Change-Id: Ia5d4de61ecf77477e86032b86d67d6ffd011913e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100819 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:unusedfieldsNoel Grandin
Change-Id: I61fe1c43f4235eddfca80f2a8392c58d4b1380e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100818 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16tdf133275: Additions: Sorting menu ui implementationYusuf Keten
Change-Id: I41b0887d0bc6bf4618bd1cf9afd06f4b1ddbabb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100778 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-08-16loplugin:unnecessaryvirtualNoel Grandin
Change-Id: Iafad1df533d5fefd335066427a0fb9e2d8bfa91d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100817 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-08-16loplugin:virtualdeadNoel Grandin
Change-Id: Ic002692801113de5778826db5e3faf9869a48307 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/100816 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>