summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-07-08tdf#149913: add support for auto-start-reverseXisco Fauli
See https://svgwg.org/svg2-draft/painting.html#OrientAttribute Change-Id: Iedcca7bc79a54333c0f80927364caec82ce61167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136894 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-08lok: skip app background rendering for lok case.Michael Meeks
this is/was mis-placed and tends to make a mess of large sheets' tiles close to the bottom at ~2^20 rows. Change-Id: Iac0977d58428707ff56c0ac30a7740c0ed0b27c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136866 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-08tdf#149747 DOCX import: use UI style name for tracked changesTünde Tóth
instead of the programmatic style name, because rejection of tracked paragraph style changes was incorrect with an other UI than English UI. Follow-up to commit 0ad5d133bd75ccd3a04505aaac7ad3f2f9105f76 "tdf#132781 DOCX: export interoperable hyperlink style names" and commit 4248d759744f83a68d334a8b347124719a2886a8 "tdf#126243 DOCX: export/reject tracked paragraph style change". Change-Id: I3b3b163b2538732b2470162888083de0609895fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136624 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-08[API CHANGE] Drop css::accessibility::XAccessibleStateSetNoel Grandin
which is internal API, unused (as far as I can tell) by external users. This state is purely a bitset (as implemented by utl::AccessibleStateSetHelper) so we can just return it as a 64-bit value. This shaves significant time off the performance profiles of code that loads very complex shapes, because this state is frequently used, and we no longer need to allocate a return value on the heap for every call. Change-Id: Icf1b3bd367c256646ae9015f9127025f59459c2c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136786 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-08svgio: use IgnoreAsciiCase when checking these valuesXisco Fauli
They are also valid when uppercase OTOH, use equalsIgnoreAsciiCase along with trim() instead of startsWithIgnoreAsciiCase since " round " should be valid but "rounded" shouldn't Change-Id: If4060a23a1cf41833264051094103e37927d14c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136881 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-08tdf#149711 sw_redlinenum DOCX: import moveTo paragraph markLászló Németh
It was imported as an old paragraph with new content, resulting that e.g. rejecting a moved list item left an empty list item instead of removing the moved list item completely. Follow-up to commit 80694a8fcfeb86ed69425ab6954b353b9a0ae854 "tdf#149708 sw_redlinenum DOCX export: track inserted list items" and commit d32d9a2b3c5e3963f4a18f6c7bbf50fab2e9b2be "tdf#123460 DOCX track changes: moveFrom completely". Change-Id: Ia1997aeffeb45f89bb738c6faa95fb2efc54fd7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136886 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-08comphelper: replace tools::Long with size_tChris Sherlock
Change-Id: I1eba8e05bdc92fd689e368dd4fe0e79bc1f2b46f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135716 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-08sc: refactor and simplify PrintPageRanges::calculateTomaž Vajngerl
push more responisbility to PrintPageRangesInput with operator overloads and use ScRange instead of individual startRow, endRow, startCol, endCol and tab. Change-Id: Ia94c578c6dea48d65c59ceead2dc326faffc81ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135676 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2022-07-07do not write vspace/hspace attributes to reqifLuboš Luňák
These are not valid for the ReqIF-XHTML subset. Change-Id: Ie68560c49ba43b0f728c6e51eeb33b4829bded93 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136887 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2022-07-07svgio: fix copy-paste nameXisco Fauli
Change-Id: Ic29fc98f70dd14b07190fd559c54c13be5777975 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136883 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-07i18nlangtag: replace tools::Long with longChris Sherlock
Revert to long as originally used in commit e81359a9a324: "added registerImpl() re-entered warning" and then apparently accidentally broken in the mass conversion commit e25fd7782ad04: "long->tools::Long in hwpfilter..oox". Change-Id: I39c983ddec83c84953bc3db167793944c671894b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135714 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-07svgio: make readLocalUrl standard-compliantXisco Fauli
See https://bugs.documentfoundation.org/show_bug.cgi?id=149880#c12 Thanks to Mike Kaganski for the references Change-Id: Idb06cf40ee992dd73120ce051d8ba4f61faaadfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136877 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2022-07-07elide some string copiesNoel Grandin
Change-Id: I3e0d9f7e5a446689e007b9d01fb1c6bf9bc068e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136880 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-07tdf#149089 fallback GridMode.Mark Hung
If line pitch is not defined -> fallback to none. Otherwise if charSpace is not defined -> fallback to lines. Change-Id: I1df027f2e74baf0215567fb9a70c879522558346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136622 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2022-07-07tdf#149893: Color names are ASCII case-insensitiveXisco Fauli
See https://www.w3.org/TR/css-color-3/#html4 Change-Id: Ifdf887bad08ab606abef78fa8335bc49507f4a43 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136879 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2022-07-07Use a dedicated log area for a SAL_INFO in test codeStephan Bergmann
Change-Id: I8824129c0c40406b3e0dd65d163662eb3aea258f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136878 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-07related: tdf#149741 improve tooltips for adding Table rows and columnsSeth Chaiklin
also change accelerator letters for columns, to avoid a conflict with rows Change-Id: I99f36e654215f29fe1b4b2162fad4c6e12572c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134359 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2022-07-07tdf#139953 Apply and Edit Changes - drop first dialog go directly to EditAman Jha
Change-Id: I613f78b8327aa62495ce2563944e3277895eac7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136103 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Hossein <hossein@libreoffice.org>
2022-07-07Retire loplugin:toolslongStephan Bergmann
...which already carries some rather lengthy excludelists (indicating that the idea of "every `long` is wrong" is rather fishy), and now gets in the way of <https://gerrit.libreoffice.org/c/core/+/135714> "i18nlangtag: replace tools::Long with long" Change-Id: I5065064cf4ac61fe97a4c99ba4d493a807cdbf06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136852 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-07svg filter: transform animations: support for scale and translateMarco Cecchetti
Now the emphasis grow and shrink animation is supported. Now the animation engine is able to handle array of values instead of single value param when computing the next animation state. Change-Id: Ic200103c6c26a63de8eecc37dcd36ba1a2f0d391 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/134870 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a6ed16394c4a95cf204f38c30cb025bc99f00027) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136418 Tested-by: Jenkins Reviewed-by: Aron Budea <aron.budea@collabora.com>
2022-07-06Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to c2687d2f197c096563b19920262ded8ed15d2630 - update translations for 7.4.0 rc1/master and force-fix errors using pocheck Change-Id: I85614e5c08b7f31ebf654b85a50cf3b56c373d91
2022-07-06tdf#149880: handle url when it's inside the quotation marksXisco Fauli
Change-Id: I053323f9b48c8856d520095da0a4768ac03b0176 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136847 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-06fix variable typo in upload_symbols.pyChristian Lohmaier
Change-Id: I96e15bc4cc29262ce602a616e036a97f3e20916e
2022-07-06micro-optimisation in FastAttributeListNoel Grandin
Change-Id: If684357b8849258af213f06a52f71ea81ffac1e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136844 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-06shave some cost off SaxContextNoel Grandin
most of the time, we can skip the ref-counting associated with these string fields Change-Id: I7afc1aa08f3337d7c61478eab92abc2cdd2b9d1c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136843 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-06move old/unused plugins to storeNoel Grandin
noting that I have only plugins that I wrote or worked on extensively Change-Id: Ic4931a6ac2df7902cac3968900330a7ce4eb2d57 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136841 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-06tdf#149708 sw_redlinenum DOCX export: track inserted list itemsLászló Németh
Change tracking of the paragraph mark of an inserted list item wasn't exported. I.e. a new list item was exported as an old empty list item with new tracked text content. It was loaded with bad actual/original numbering, and rejection of the incomplete insertion left an empty list item in the list instead of removing that list item completely. Note: the problem was inherited from OOo. See also commit 508ed558948353a3eb8be9adf3588368e440f4cf "tdf#115524 sw_redlinenum: show original numbering of insertions" and commit 4e5f89d2d3511b6421b388ecaba2f61ada14d084 "tdf#119848 DOCX export: keep tracked deleted empty line". Change-Id: I869ba2f39749e188015f7c7371e5caf1d39060f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136838 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2022-07-06ScriptForge - (SF_FileSystem) new Normalize() methodJean-Pierre Ledure
Normalize a pathname by collapsing redundant separators and up-level references so that A//B, A/B/, A/./B and A/foo/../B all become A/B. On Windows, it converts forward slashes to backward slashes. The Basic Normalize() method invokes the _SF_FileSystem__Normalize() function located in the ScriptForgeHelper.py module for execution with the os.path builtin library The os.path.normpath() function can easily be executed directly from python user scripts. However the FileSystem.Normalize() method is proposed as well for Python scripts - for compatibility Basic/Python reasons - to manage the FileNaming notation Change-Id: I1e089612432bd2c75b2e76ffa984289ef7f9d75c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136835 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2022-07-06CppunitTest_sc_uicalc: just use insertStringToCell...Xisco Fauli
... like the rest of tests in sc_uicalc Change-Id: I2fbe812443c194ad89411d837ace49f4c0b825cb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136840 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-06tdf#149665: sc_ucalc: Add unittestXisco Fauli
Change-Id: I0273e499ee607a54cbd32296e568ad46b1c0c0ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136839 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-06tdf#90837 - clarify the error message re: over-writing readonly files.Michael Meeks
Change-Id: I757b29574526882da6e307cef51dfa70f6a1c4bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136833 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-06opencl: no need for unhelpful nullptr OUString * case.Michael Meeks
Change-Id: I0b3cad2247706901e1a6b9c3df7fbbc9f23ff987 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136816 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2022-07-05qt a11y: Implement QtAccessibleWidget::tableMichael Weghorn
Implement that `QAccessibleTableCellInterface::table` override by returning the parent, if it is a table. This turned out to be the missing piece when working on an implementation for the Qt library to expose the AT-SPI table cell interface for a11y objects that implement `QAccessibleTableCellInterface`, and testing the "GetTable" method by calling `acc.queryTableCell().get_table()` on a selected LO Calc cell in Accerciser's IPython console. Change-Id: I6144c613f31cafc338ccac739cd7db1bf314d4a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136836 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2022-07-05Resolves: tdf#149665 Strip first ' also for multiple '' if following is numericEike Rathke
... and prepend accordingly when editing content. Change-Id: I9b35c4e370323966400e8e7ef3bce95026052f10 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136837 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2022-07-05lok: vcl: introduce set_cursor_data methodHenry Castro
The ScEditWindow requires to assign a cursor, so the child widget can send cursor invalidation to client side. Change-Id: I429d484a311f217f2419e38d50f8d9a422640221 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/130446 Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136829 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-07-05lok: fix regression "WeldEditView::DoPaint" for dialog tunnelingHenry Castro
Change-Id: I1cb345b3911d03dc90acef2a17705d654a06deb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128622 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136830 Tested-by: Jenkins Reviewed-by: Henry Castro <hcastro@collabora.com>
2022-07-05Fix typoAndrea Gelmini
Change-Id: I500b02954de8ed0897a9e6b7ba0e77252a171085 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136824 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2022-07-05Related tdf#137145 tdf#137569 Capitalization + punctuation fixesAdolfo Jayme Barrientos
Change-Id: Icd8a631da83c86333c7e5bcee0069165899d3041 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136822 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-07-05sw: fix null derefs of GetCurrShell()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/SwContentFrame::Cut() Change-Id: I00267b480d9c123f68996572d2e6fdebc4fb383f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136834 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-05fix build with disable-avmedia.Michael Meeks
Change-Id: Ia57db9b2bcec4ff73e1332bb5b2197080343baa4 Signed-off-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136831 Tested-by: Jenkins
2022-07-05compact the RichString classNoel Grandin
Which reduces peak memory load from 495M to 455M when loading a large spreadsheet Change-Id: Iad78524bedf3db193820be2d507652abde59d67c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136827 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-05compact the RichStringPortion classNoel Grandin
Which reduces peak memory load from 548M to 495M when loading a large spreadsheet Change-Id: I74adfddd1722bba7a9dfae6dd0135e5f2b78b1a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136826 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-05remove span data storage from oox importNoel Grandin
We are not using it, and removing it reduces peak memory load from 648M to 548M when loading a large spreadsheet Change-Id: I683bfba6c8f151d8845bbd7d5f92cde2a9c17807 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136825 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-05sfx2: fix null derefs of SfxViewFrame::Current()Xisco Fauli
See https://crashreport.libreoffice.org/stats/signature/%60anonymous%20namespace'::lcl_tryLoadBibliography Change-Id: I80d764c4bbcf0c5affa3386fbb11f5a79e98b699 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136828 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-07-05sfx2: prefix m_ private memberHenry Castro
SfxFrameWindow_Impl class Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: I8171d04b65b24b111048a6a13e8db6af9120edf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136814 Tested-by: Jenkins
2022-07-05tdf#149741 Mirror insert column icons for RTL tablesMaxim Monastirsky
The usual approach of setting the respective property in *Commands.xcu won't work here, as that works with the paragraph direction, which doesn't have to be the same as the table direction. Change-Id: I9c4d49a5c553a8a74e7760d257167a0be42c89c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136818 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2022-07-05sal: fix invalid doxygenChris Sherlock
Change-Id: Ib26a695c88d02a0ce5a3c9974fae9f88d8ae89ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136783 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2022-07-05tdf#104428 Improve rendering of exploded donut chartsKurt Nordback
This bug shows an exploded donut chart with more than one series. The concern is that the standard pie/donut' explosion' rendering, with the shape of the pieces unchanged but the pieces translated outward, gives unsatisfactory results in the case of a donut with more than one series, where the translated 'exploded' pieces can overlap with the inner ring. This proposed fix renders this case differently, by increasing the radius of the exploded ring but keeping the pieces concentric with the inner ring. This commit also modifies the unit test values for donut_chart.ods. Change-Id: I713b1f3ce4697d46d29914410056f0aa83c6aa8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/135394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-05tdf#137544 reduce ref-counting trafficNoel Grandin
we can store a direct pointer here, shaves 5% off load time Change-Id: I418916df946f53ead28bb5cf76614a874283e7d2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136821 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2022-07-05tdf#137544 reduce unnecessary broadcasting when creating shapeNoel Grandin
we have just created the shape, so no need to do the expensive broadcast Change-Id: I3500f0fd007aa531a63f894aaf21372d602f8dbc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/136820 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>