summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-07-29sfx2: Re-enable the sidebars for LOKAshod Nakashian
This re-enables the sidebars for LOK, which were disabled to avoid overheads. Also, fixes a regression where editing stopped when loading a new view because the sidebar window creation killed the edit view. Revert "Avoid various desktop GUI elements when used from LibreOfficeKit" This reverts commit c0b70ec34d5e056bb92a66cbf83838923cb41fee. Also (added by Noel to the above commit) (1) Comment out parts DesktopLOKTest::testPaintPartTile test that trigger a crash. We are installing a callback that points to something on the stack, and then not removing that callback, resulting in calls to random stack memory. There is a further problem in the LOK code in that we cannot uninstall a callback when we have multiple views because the uninstall code in doc_registerCallback can only remove a callback for the __current__ view, which I do not fix here. (2) prevent code from accidentally creating empty entries in the mpCallbackFlushHandlers map, which is what happens when you use the index operator on map, which results in a crash in doc_registerCallback because the std::shared_ptr is empty. (3) In SdTiledRenderingTest, only turn off LOK via LibreOfficeKit::setActive(false) once the document has been torn down. Otherwise, we don't remove entries from the statically allocated s_pLOKWindowsMap map in vcl/source/window/window.cxx, which means that at process exit, we have dangling Window objects. Reviewed-on: https://gerrit.libreoffice.org/71165 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 88565c3662c6fde240c98a9b4f2ce6dfbcf4094e) Change-Id: I06b06a990f05c06b1889fa89b698dff6f494e09c Reviewed-on: https://gerrit.libreoffice.org/76466 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29weld SdTpOptionsMiscCaolán McNamara
Change-Id: I43db706b74811a18f573fe20cac041d320f9331c Reviewed-on: https://gerrit.libreoffice.org/76535 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScRedlineOptionsTabPageCaolán McNamara
Change-Id: I80151384f5e75eac08665f45ce87468e10fb987e Reviewed-on: https://gerrit.libreoffice.org/76553 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpContentOptionsCaolán McNamara
Change-Id: Ia0ad05337ae3195e565e4b913cdf34e9a32e9cea Reviewed-on: https://gerrit.libreoffice.org/76552 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpFormulaOptionsCaolán McNamara
Change-Id: I8d45dfc745dbb7f90346028eb29a432309db0845 Reviewed-on: https://gerrit.libreoffice.org/76547 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29rename DoubleField back to ScDoubleFieldCaolán McNamara
Change-Id: I3d3923f3131e13abde145f96468ade0d0c8cc142 Reviewed-on: https://gerrit.libreoffice.org/76546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29drop newly unused ScDoubleFieldCaolán McNamara
Change-Id: I2105306d1d865512a5fa2f8c862e7a21c384ee39 Reviewed-on: https://gerrit.libreoffice.org/76545 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld ScTpCalcOptionsCaolán McNamara
Change-Id: I4b5bd08a9ed04b9bceb08640a275dee02d6e9b36 Reviewed-on: https://gerrit.libreoffice.org/76544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Fix typo in codeAndrea Gelmini
"delimitter" It passed "make check" Change-Id: I54fb7200a71365675cefc506ea3c9f2c65bbff6d Reviewed-on: https://gerrit.libreoffice.org/76554 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29Drop ScDataPilotFieldObj::HasStringArkadiy Illarionov
Use comphelper::findValue instead Change-Id: I59a3ef2781643dfdb7ecbfe578fb9e1faebb0c42 Reviewed-on: https://gerrit.libreoffice.org/76502 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29Simplify Sequence iterations in sdArkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: If4b6d464fc393049dc8d7e5c3faf1cf66b6a369a Reviewed-on: https://gerrit.libreoffice.org/76480 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29Simplify Sequence iterations in sdextArkadiy Illarionov
Use range-based loops and STL algorithms Change-Id: I0ffc0c7481b35cf6a297f8123b567d4331ff1a3f Reviewed-on: https://gerrit.libreoffice.org/76478 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29Simplify Sequence iterations in sfx2Arkadiy Illarionov
Use range-based loops, STL and comphelper functions Change-Id: I6a0d18493db7a25e8b41925f2d45cb221b5065a7 Reviewed-on: https://gerrit.libreoffice.org/76074 Tested-by: Jenkins Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com>
2019-07-29weld ScTpLayoutOptionsCaolán McNamara
Change-Id: I02f36b18d3803a7539a66b95cfc5e485d30344d7 Reviewed-on: https://gerrit.libreoffice.org/76539 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29weld SdParagraphNumTabPageCaolán McNamara
Change-Id: I71802d3d8f6335480ea2f74f6812470a8c13b0b8 Reviewed-on: https://gerrit.libreoffice.org/76536 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29setup_native: document more obscure epmfile.pm inputMichael Stahl
Change-Id: I26ca5b61acef2474980f5e916e10bca3a18ceea3 Reviewed-on: https://gerrit.libreoffice.org/76557 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de>
2019-07-29Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'master' - Superfluous! Change-Id: Ic2339636853d6e36d11e20b6f6e46fca048eb568
2019-07-29Fix typoAndrea Gelmini
Change-Id: Ia12484339eff532112e5de4b9c95d41a61d25574 Reviewed-on: https://gerrit.libreoffice.org/72572 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-07-29weld SdTpOptionsContentsCaolán McNamara
Change-Id: I96296248aa1a91a248b44ce676ab45925a353cf3 Reviewed-on: https://gerrit.libreoffice.org/76534 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Resolves: tdf#126485 remove max limitCaolán McNamara
Change-Id: Ieda7b500c1c08d169bfbfa995b42d3761d2427d7 Reviewed-on: https://gerrit.libreoffice.org/76526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Expand collapsed sidebar when calling XSidebarProvider::showDecksSamuel Mehrbrodt
This UNO call did not work correctly when the sidebar was completely collapsed. Change-Id: I3de0b89d95aa81287c36911bbd52a9941d9886b3 Reviewed-on: https://gerrit.libreoffice.org/76525 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-29return early if no work to be doneCaolán McNamara
Change-Id: I79cef4af708220c962df48d0bcf347bdc1c8a218 Reviewed-on: https://gerrit.libreoffice.org/76524 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29Resolves: tdf#126510 - Expander sections are bad UXHeiko Tietze
GtkExpander replaced by GtkFrames Change-Id: I07130f7f070e45bf60ffb4fc26605b79556534b3 Reviewed-on: https://gerrit.libreoffice.org/76219 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2019-07-29revert bits of "loplugin:sequentialassign"Noel Grandin
from commit 0d36b32755ac662299e6a8165e9fa57311b74a2f Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun Jul 28 12:03:35 2019 +0200 loplugin:sequentialassign which were false positives and not meant to be committed Change-Id: I6f2f185bd3564c9329f5a0c78c9020f3ddb52d34 Reviewed-on: https://gerrit.libreoffice.org/76518 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29Fix typoAndrea Gelmini
"an API", to complete: https://gerrit.libreoffice.org/#/c/75984/ Change-Id: I441f89b44a96957ea254823b9f28086fa289cc54 Reviewed-on: https://gerrit.libreoffice.org/76036 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29Fix typosAndrea Gelmini
Change-Id: Iec31617554fae0f6c5a3d795a917ce9096d84405 Reviewed-on: https://gerrit.libreoffice.org/76521 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29Fix typosAndrea Gelmini
Change-Id: I11e3dc250c140b03bbc2d2d83a448e40a1624fe3 Reviewed-on: https://gerrit.libreoffice.org/76519 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-07-29revert part of "add some error checking to the UI file loading"Noel Grandin
revert part of commit cba5cd06c8ffd8628ae3d39efe715a5d8b3ac7e7 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Fri Jul 26 12:49:10 2019 +0200 add some error checking to the UI file loading because some places eg. "writer format->bullets and numbering" expect a silent return of nullptr for a missing button Change-Id: I5cf8fa64d703636a65dc96987688c283016c87e8 Reviewed-on: https://gerrit.libreoffice.org/76522 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29Add qrcodegen ui file to make fileShubham Goyal
The qrcodegen.ui file in https://gerrit.libreoffice.org/#/c/74167/ was forgetfully not added to make file, so here it is. Change-Id: If60cf8f4aa3ed670da026f7631199e82d9b5a3d4 Reviewed-on: https://gerrit.libreoffice.org/76376 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-29Avoid memcpy nonnull issueStephan Bergmann
...as started to get reported by <https://ci.libreoffice.org/job/lo_ubsan/1341/> > /jvmfwk/plugins/sunmajor/pluginlib/util.cxx:368:33: runtime error: null pointer passed as argument 2, which is declared to never be null /usr/include/string.h:43:28: note: nonnull attribute specified here > #0 0x2b710cdb4e35 in jfw_plugin::AsynchReader::execute() /jvmfwk/plugins/sunmajor/pluginlib/util.cxx:368:13 > #1 0x2b70c87b8a27 in salhelper::Thread::run() /salhelper/source/thread.cxx:40:9 > #2 0x2b70c87bac9f in threadFunc /include/osl/thread.hxx:185:15 > #3 0x2b70ba8bb89d in osl_thread_start_Impl(void*) /sal/osl/unx/thread.cxx:235:9 > #4 0x2b70bc47fdd4 in start_thread (/lib64/libpthread.so.0+0x7dd4) > #5 0x2b70bcdb4eac in clone (/lib64/libc.so.6+0xfdeac) during UITest_calc_tests6 Change-Id: I6505061192a8d6b9a68d72980fd134d161e5e1a3 Reviewed-on: https://gerrit.libreoffice.org/76516 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-29sw: SwSttNdPtrs -> SwStartNodePointersMiklos Vajna
Change-Id: I0d9dc35e4501977e4a64548b0ff8f46c3a3f8538 Reviewed-on: https://gerrit.libreoffice.org/76517 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-07-29Fix typosAndrea Gelmini
Change-Id: Ic2fb0772648b3f93c2fdfa4d2f663b6ede2ead51 Reviewed-on: https://gerrit.libreoffice.org/76507 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29Fix typosAndrea Gelmini
Change-Id: I94bfbfef24be46583c5c2877e468ed65c2bd5eb0 Reviewed-on: https://gerrit.libreoffice.org/76513 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-29weld SdPrintOptionsCaolán McNamara
Change-Id: I09cdf0b327e775bf8b87c353a4d46fa6320c12aa Reviewed-on: https://gerrit.libreoffice.org/76505 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-29find-unneeded-includes: warn first time user nicely about missing fileGabor Kelemen
Change-Id: Ibc0b818a410cf0aee19b1d2a42a53db9aff87638 Reviewed-on: https://gerrit.libreoffice.org/76461 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-07-29loplugin:sequentialassignNoel Grandin
Change-Id: I56a9bf698b60bd278c71cc632aacef2bd2f4c13f Reviewed-on: https://gerrit.libreoffice.org/76501 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-29Avoid -fsanitize=float-cast-overflowStephan Bergmann
...when converting sal_Int64 9223372036854775807 (i.e., 0xFFFFFFFFFFFFFFF) to double 9.22337e+18 (i.e., by rounding up to 2^63, represented as 0x43e0000000000000) and then back to sal_Int64 (for which it is now too large). Started to happen during UITest_writer_dialogs: > vcl/source/control/field.cxx:1116:35: runtime error: 9.22337e+18 is outside the range of representable values of type 'long' > #0 in MetricField::ConvertValue(long, unsigned short, MapUnit, FieldUnit) at vcl/source/control/field.cxx:1116:35 > #1 in svx::sidebar::PosSizePropertyPanel::SetPosSizeMinMax() at svx/source/sidebar/possize/PosSizePropertyPanel.cxx:1058:47 > #2 in svx::sidebar::PosSizePropertyPanel::MetricState(SfxItemState, SfxPoolItem const*) at svx/source/sidebar/possize/PosSizePropertyPanel.cxx:893:5 > #3 in svx::sidebar::PosSizePropertyPanel::NotifyItemUpdate(unsigned short, SfxItemState, SfxPoolItem const*, bool) at svx/source/sidebar/possize/PosSizePropertyPanel.cxx:735:13 > #4 in sfx2::sidebar::ControllerItem::StateChanged(unsigned short, SfxItemState, SfxPoolItem const*) at sfx2/source/sidebar/ControllerItem.cxx:67:26 > #5 in SfxStateCache::SetState_Impl(SfxItemState, SfxPoolItem const*, bool) at sfx2/source/control/statcach.cxx:412:24 > #6 in SfxStateCache::SetState(SfxItemState, SfxPoolItem const*, bool) at sfx2/source/control/statcach.cxx:326:5 > #7 in SfxBindings::Update(unsigned short) at sfx2/source/control/bindings.cxx:352:25 > #8 in svx::sidebar::PosSizePropertyPanel::PosSizePropertyPanel(vcl::Window*, com::sun::star::uno::Reference<com::sun::star::frame::XFrame> const&, SfxBindings*, com::sun::star::uno::Reference<com::sun::star::ui::XSidebar> const&) at svx/source/sidebar/possize/PosSizePropertyPanel.cxx:114:17 [...] Change-Id: I23a39181a241129f3c6c83e9934405509bd98292 Reviewed-on: https://gerrit.libreoffice.org/76512 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-07-29tdf#111703 Select the Organizer tab page when new styleJim Raykowski
Change-Id: Ib031bd1139ea9a8bf084a1ead17bc17f30565401 Reviewed-on: https://gerrit.libreoffice.org/76508 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-07-28weld ScTpCompatOptionsCaolán McNamara
Change-Id: Id67570b53604489fa0b2194a0f9ad0b67d535f0e Reviewed-on: https://gerrit.libreoffice.org/76487 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-28weld ScTpDefaultsOptionsCaolán McNamara
Change-Id: I2a4a053b38229b971fbf6fc8205680ce02132234 Reviewed-on: https://gerrit.libreoffice.org/76486 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-28weld SwLoadOptPageCaolán McNamara
Change-Id: Id415d2fc6a1476eb5adaf633a8c4932e267ba3b7 Reviewed-on: https://gerrit.libreoffice.org/76485 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-07-28loplugin:writeonlyvarsNoel Grandin
Change-Id: I00b495685cc9f74440051eafa2f8681a050a536e Reviewed-on: https://gerrit.libreoffice.org/76497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28loplugin:collapseifNoel Grandin
Change-Id: I69bfafa97c66ef944cc6ae35c7e2f66d0430d6a4 Reviewed-on: https://gerrit.libreoffice.org/76496 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28loplugin:oncevarNoel Grandin
Change-Id: I3c014f53607a849c743a2fd1aa47d03d5af978fb Reviewed-on: https://gerrit.libreoffice.org/76495 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-07-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#126528 Add Python in Organize scripts page Change-Id: I8d18f5e264fe11924a8ea234e82355913b0417d2 Reviewed-on: https://gerrit.libreoffice.org/76382 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-07-28Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'master' - Silence warning about ahelp without bookmark This UI item has another ahelp in the same page Change-Id: I7b76d7737467c9c0006c4e3536d5651741862a6f Reviewed-on: https://gerrit.libreoffice.org/76473 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-07-28tdf#126559: vcl_pdfexport unit test failureJulien Nabet
Revert back part of 3f7e8ddea89f6340cd18b5b34f5a7c5f503962be Some investigation is needed here Change-Id: I4fc0648bdef0df6cd2cd4b114dd479bc0a722fe6 Reviewed-on: https://gerrit.libreoffice.org/76500 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-07-28lok: send cell selection rectangle and cell area fill rectangleTomaž Vajngerl
Instead of text selection start/end for cell selection we send a cell selection rectangle event. This is needed so we're able to differentiate when to draw cell selection and text selection markers. In addition send cell fill area rectangle, which is the area where we need to hit to trigger area fill functionality in Calc. Change-Id: I54af958932815818a1a4d48364192ba43f1df7de Reviewed-on: https://gerrit.libreoffice.org/76491 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-07-28Fix typosAndrea Gelmini
Change-Id: I1b3f858cf56f93fc72f1508322c00647e12a4c43 Reviewed-on: https://gerrit.libreoffice.org/76481 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Jenkins
2019-07-28unit test for B2DPointTomaž Vajngerl
Change-Id: I86a9d555e4915658acf5829fbf7c8336255d6343 Reviewed-on: https://gerrit.libreoffice.org/76490 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-07 20:09:13 +0000