summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-14Add tooltips for protect bookmark/field commandsSamuel Mehrbrodt
Change-Id: I54954c20766bae2112571d92ad760f71d3bf2060 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88611 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-14tdf#89566 Replace navigation toolbox in Writer navigatorJim Raykowski
Replaces the navigation toolbox with the navigate by elements control. Change-Id: Idba18e63ac29f37d8e614b6459ea67b71b65c885 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87005 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-02-13writer table sidebar update for smaler height and better layoutingandreas kainz
Change-Id: Ide2b956879c469565b7fd220cdbe9a081bcaf145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88572 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-13Revert "Related tdf#130428: let's add some asserts"Armin Le Grand (Collabora)
This reverts commit 9811796aba7360fc5b7230a8b314a56fbf6ab27a. Revert "tdf#130428 SfxItemState::UNKNOWN replacements" This reverts commit cf4e87469baf13fb2766d0f2593fcc2b9b33bc9b. Change-Id: I976ade5e25db09e18297e46a5c92f8bc578399e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88610 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-13Restore simple undo and redo buttons for the basctl moduleMaxim Monastirsky
Changed in commit c34edadf5bd3d1d9f3c9c056af28b8964d8f1ca0 ("rework SvxUndoRedoControl to be a PopupWindowController"), but the dropdowns do not work in that module. These buttons used to be managed by SvxSimpleUndoRedoController, but that's no longer the case. The reason is that ToolBarManager::CreateControllers checks first for controllers registered in Controller.xcu, and only if none found it checks for sfx2 controllers. So SvxSimpleUndoRedoController by using a sfx2-style registration, has no chance to be ever selected for .uno:Undo or .uno:Redo. This commit removes the unused controller, and restores the previous behavior with the other controller. Change-Id: Ia774195511e41ab11562856fe1cf2ec7f170710a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88606 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-02-13weld FindTextFieldControlCaolán McNamara
Change-Id: Ib5861855d37c72d2be2b11b77173a141db90444e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13extract NaturalSortCompare from ListBoxCaolán McNamara
Change-Id: I260c83778aea06eba9ae774739c6dc31fe5366d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88613 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13nStyle is always set to WB_DROPDOWN | WB_VSCROLLCaolán McNamara
Change-Id: I8978d910cba881e8c0343111f600ba3f6aef9025 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88603 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130640: Revert "tdf#124983 In calc make printable page...Xisco Fauli
...borders also initially visible" This reverts commit caeb7b141280a65e60525f11a7e6514b76e12e11. Change-Id: I691934db79982c16bf0f43e7e38b00f3ab440a38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88616 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins
2020-02-13convert conststringvar plugin to shared infrastructreNoel Grandin
and move the duplicated hasExternalLinkage function to a common location Change-Id: I39a1990945666ff7a307b4ddd5e270da64ee1673 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88592 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-13Fix typoAndrea Gelmini
Change-Id: I63e1634114ca436d7fb4f8afe4cb7a0ac7824209 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88624 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-13improve debugger/valgrind handling in watchdogLuboš Luňák
This way it'll avoid incorrect lock-up detection also if the debugger is attached later when LO is already running. Change-Id: I9b762ee439a62631036ad2f09f4396cca0b5ba6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88609 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13factor out dialog hacksCaolán McNamara
Change-Id: Iceefc8d739fb93b97adfa1e35d8308f0c48f02e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88600 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13drop workben outdevgrindCaolán McNamara
Change-Id: I94978f84b45daec9ba7e782087e45182def234d6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88601 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13use TopLevelWindowLocker for the lock other windows problemCaolán McNamara
Change-Id: Ic5d279ff9271ca24d9d32728d63322e8acc2037d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88599 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13make sure SAL_SKIA=vulkan also overrides settingsLuboš Luňák
Change-Id: I2933fec07b594c47520087664f50d48184122818
2020-02-13remove 'ATI' from the driver listLuboš Luňák
The ATI brand has not been in use for a decade, and it's confusing to have both AMD and ATI there. All AMD gfx cards use the 0x1002 formerly-ATI PCI vendor ID, so just use AMD and that vendor ID. Change-Id: I9d60f1e86fe12a2e0fe9548c7c912d2d1ecec240 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88534 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13make OpenGL blacklist file code generic and use it for Skia/VulkanLuboš Luňák
Change-Id: Icc150b853f5d2d06afedcb7878f6a031aff57c2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88533 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13Add uno cmd to protect bookmarks in a documentSamuel Mehrbrodt
Change-Id: I7cc0dfa2b129d69d49b555495d77c2c710689e94 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88586 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13tdf#130563 Change the default dates format for Italian localeMarina Latini (SUSE)
Change the default dates format from the year with two digits to the year with four digits avoiding misleading interpretations of the years. The change applies to: it_CH, it_IT, fur_IT, lld_IT, sc_IT, vec_IT Change-Id: Ib0d2d72e84a162c0e8daee8d4702173013e60af6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88462 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-02-13weld ScZoomSliderWnd ItemWindowCaolán McNamara
Change-Id: I50ab530f24770dcb4df174e2a379b0d14d76b253 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88573 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13use what gtk reports as the held buttons for mouse moveCaolán McNamara
Change-Id: I52242eb652802913382551527763737d92127129 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88597 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13Add uno cmd to protect fields in a documentSamuel Mehrbrodt
Change-Id: Ifb9f757111a6fcbb283d2350ed2ccd42de19d5df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88585 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13chart: don't export LO_EXT hide-legend in ODF 1.2László Németh
Regressions from commit 7869b3d6e4b24a0567ad2e492038d74c03b06b7d (related tdf#51671, store new "hide legend" feature also in ODF) and commit a96ec04a07c35338f5f9a0cb361b9322e5ca9cec (tdf#130225 implement ODF export of deleted legend entries of pie charts) Change-Id: I1d2847ae3e3ab7ccfbdb3841d94a0c1d79ded31f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88593 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-02-13toplevel might not be a GtkWindow, no need to cast to GtkWindowCaolán McNamara
Change-Id: I3347bcff6f32e8eb61186216373a950b45ab1765 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88596 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13set-focus doesn't exist in GtkEventBox, only GtkWindowCaolán McNamara
Change-Id: I7e8ba4891a34fa585831e11fd4e2fcbbfe7b859d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88595 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#45589 sw: add tooltip to Formatting Aids dialog Bookmark labelMichael Stahl
Thanks to sdc.blanco for the suggestion. Change-Id: Ib9a1874eeba1e9e1bf594e725be6883e79ed9a67 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88541 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-13set up properly Vulkan context creation also for WindowsLuboš Luňák
This was somehow missing in aafe540f5a4c3593d8e56bbdbeb5f508994fe6d9. Change-Id: I5bdcc490b10c73ac4bc55aa6af29d08815cd18d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88532 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-02-13tdf#124176: Use pragma once instead of include guardsMohamed Sameh
Change-Id: I33a9c770142a2fcc2d899b5071cc45d5a42c8664 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88473 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
2020-02-13Get rid of some unnecessary llvm::StringRef -> std::string conversionsStephan Bergmann
(as discussed in the commit message of ce1d8e20a708ed031f2336770a41fbe501fe8225 "Adapt to '[ADT] Make StringRef's std::string conversion operator explicit'"; there are more of those that cannot easily be dropped, though). Change-Id: Ib2e223f7de96ad8859eab165daa759b480326c7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88582 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-13Prefer array over vector for 3 elements containerJohn Zhang
Change-Id: I3d9bb84e067fdda3486ee21cfd5b5ffa59bc8c5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86591 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-13tdf#130225 implement ODF export of deleted legend entries of pie chartsTünde Tóth
Follow-up of the following commits related to the new UNO property DeletedLegendEntries for pie charts: commit 86be3422cd55fa9e44104f1628648061bb6a3495 (tdf#129857 Chart OOXML export: fix deleted legend entries) commit 6e847aa817999ab18acd534f9e6a86685bb268fc (tdf#129859 XLSX import: don't show deleted legend entries) Change-Id: Id24cddefa83e50dde1ec6555d02891753483dd5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88018 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-13tdf#45589 sw: fix Formatting Aids options page for Writer/WebMichael Stahl
The pre-existing problem of the lone "tab" label was compounded by the new bookmark label. There is no Insert->Bookmark in Writer/Web so i guess the Bookmark checkbox shouldn't be shown. Change-Id: I5a2348599562bb20d7a8de916d0268a133771a0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88535 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-13tdf#130325 Fix listbox used as dropdownSamuel Mehrbrodt
In this case, the listbox is not used as a static widget, also not as a combobox with dropdown. Instead the listbox is placed in a popup to choose values from. Need to handle this case similiar to the combobox dropdown (Cursor movement only travels through items, Return selects one item). Regression from 7de9417d5f65d35227c7f80f6d587c2a56bde4e0 Change-Id: Idadc3da5847e12e1408203b13ab59eb53fe14eea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88581 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-02-13tdf#119138 Show custom chart title if autoTitleDeleted is missingGabor Kelemen
autoTitleDeleted might be omitted by generators other than Excel while providing custom title. mbAutoTitleDel is set only based on the attribute value and the default also varies on whether MSO 2007 or newer is the generator, see tdf#78080 ECMA-376 Part 1 at 21.2.2.7 says: A value of 1 or true specifies that the property is applied. This is the default value for this attribute, and is implied when the parent element is present, but this attribute is omitted. Change-Id: If3457fe850e13ae8af207bb9beceecc9e887b797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88151 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-13tdf#130623 host gtk FieldControl within the design viewCaolán McNamara
to make this work in master Change-Id: I96a4e7fc0993fbdcf28e2ccad17573b93f4f99dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88570 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130623 owner of FieldControl needs to set its allocationCaolán McNamara
which works fine automatically when its in a dialog (copy table) but not automatically when hosted inside the design view this will make the gen case work in master, and the gen and gtk case work in 6-4 Change-Id: I530cfa0a7e1f5b62c6812ffde255c1edf478930d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13Resolves: tdf#130593 set correct range for spinbuttonCaolán McNamara
Change-Id: I6691f2709aa4053798fcc1744f9f41c3c3866a33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88554 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13inherit MediaControl from InterimItemWindowCaolán McNamara
to de-dup some code Change-Id: I8bf20d4b57f3ec7bd2902f01e11278da8ded194b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13remove unneeded includes and update pchCaolán McNamara
Change-Id: I6b38e96e6eb509e9d1ea0acaf30cb2a542bdbc2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88546 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130161 detect if a node already had an expansion attemptCaolán McNamara
and so isn't in child-on-demand mode anymore, in which case in basctl new module/dialog children should be appended to it similarly to how they are added if had been expanded in the earlier attempt Change-Id: I75255fb743852c70e194bbf4828cd90b9112db79 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88544 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#130161 adding a document dialog or modules doesn't update catalogCaolán McNamara
in basctl UI, seems to be since... commit 44861f2435a0c487d4fb5b196f7e4fe7f9569396 Date: Fri Aug 17 07:29:20 2012 +0200 Object Catalog in Dialog Editor if it even really worked before that changed UpdateObjectCatalog to only get called for non-document changes Change-Id: I77a94bb4859cc399e86d75fdf2c9ca7c50288b35 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88543 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-13tdf#95495 DOCX import: fix inherited list level of custom stylesSzabolcs Toth
in DOCX export of MSO 2003, 2007 and 2010, where ilvl and outlinelvl settings are missing, based on the settings of the parent styles. Change-Id: I01d239db505d46a89d7f3b9118ef0b55697bc7fc CO-Author: Balázs Nádasdy (NISZ) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87328 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-02-13Hack to dynamically adapt to __cxa_exceptiom in LLVM 11 libcxxabiStephan Bergmann
(where the new change to __cxa_exception effectively reverts the change that prompted 7a9dd3d482deeeb3ed1d50074e56adbd3f928296 "Hack to dynamically adapt to __cxa_exceptiom in LLVM 5.0 libcxxabi") Change-Id: Iec4ef1dc188bea2223d99b1b7eb8adec636c98e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88583 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-13find-unneeded-includes: silence broken o3tl::optional -> std::optional proposalMiklos Vajna
This is just a workaround, see the upstream bugreport for the details. Change-Id: I2334fb3ad86db7f43bd49c694eea3c240316bfa0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88566 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-13aImmediateMacro is unusedStephan Bergmann
...ever since fdc50b0a1b9741c5610a2b6c793c8fcdf5573c76 "new loplugin:returnconstant" Change-Id: Ib7f8760a95112aa31e1dd2ae15229c42e5fee812 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88547 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-02-13tdf#57307 - Expand word boundaries to include connector punctuationsAndreas Heinisch
Include connector punctuations when adding a variable to the watch window using "Enable Watch (F7)" in order to add the correct variable name. Change-Id: Idaf7699dde3f4147d603c6aea4b2381e2af497a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88575 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-13mobile: Center inserted shapes on visible areaMuhammet Kara
Change-Id: I366ef5d01ee3afb072b1f67d24015c889a41f4b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88488 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-02-12tdf#130614: Revert "tdf#125520 Fix OLE objects drag&drop with 'Insert as Copy'"Xisco Faulí
This reverts commit e4cea049c80f4fd6d2a586e73fe9fa08ebd08371. Change-Id: Ic925cb5660df152208cdc63bfee62d82fe912717 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88493 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-12tdf#130610 docx export: handle bold as toggle propertiesSerge Krot
Change-Id: I4c60b7eab6430a64ea1c8bcf40d0036d0b38516f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88460 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins