summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-14Fix typoAndrea Gelmini
Change-Id: I314345471928d61b11cc88858f84146534c74d9a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88746 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14tdf#124443: show arguments' tooltip above if in Formula Bar's Input Lineayhanyalcinsoy
Change-Id: I33d52af9c2b1ac3f5cfe279ff17d487c70b8cf32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86226 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-02-14remove recently unused functionsCaolán McNamara
Change-Id: Ie7645d7f9b8350d3a993c40541747dc8ac817ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88730 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14calc alignment sidebar sync widthandreas kainz
Change-Id: Ib15b57e03d7a9fc83639b685ee872ee54ba8bb18 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88733 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-14clac cell appearance sidebar alignment updateandreas kainz
Change-Id: If9e2069ef514474fa748af9bec185c2437c33035 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88734 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-02-14remove MetricField use from swCaolán McNamara
Change-Id: Ib59efd309521db5dd568ae4f3353034839cb7e1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14remove MetricField use from cuiCaolán McNamara
Change-Id: I10729db9ae465a714657b58cbfa67bed47a6c7f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88726 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14rework SwNavigationPI to listen to two propertiesCaolán McNamara
SID_DOCFULLNAME as before, and FN_STAT_PAGE to keep track of the current number of pages to always keep the page spinbutton up to date instead of waiting until its focusin signal to change it. a true gtk spinbutton will have its + disabled unless it can be increased so it will need to have the current max uptodate before focusing in Change-Id: I29a5d93ae38c6a3d0e74994a466102af234bfd48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88707 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14don't use gtk_window_group_remove_window if widgets are not GtkWindowsCaolán McNamara
Change-Id: I80d01f29091d7cc06e82295e781ef7a53fb7776b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88739 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14Resolves: tdf#130414 don't crash attempting gtk_fixed_move if parent changedCaolán McNamara
Change-Id: I5b51f1fb0eccbdb1b3ad14ff7b36077a0016a838 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88738 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14drop unneeded includeCaolán McNamara
Change-Id: Iad7851542b9bb68eb0a5672c797a5b8ffb7deea8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88727 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14use fwd decl of SpinFieldCaolán McNamara
Change-Id: Ifea23e791ec53448a8591583f283b87430ef38c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88678 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14Prevent -Werror,-Wunknown-warning-option when building compilerpluginsStephan Bergmann
...with --enable-werror (seen it fail with a local build against a locally built Clang 5.0.2). (bin/gen-boost-headers faces a similar dilemma with Clang needing to silence -Wunknown-warning-option and GCC failing upon the silencing incantation. There, we were able to hack around that with a preceding #pragma GCC diagnostic ignored "-Wpragmas" Here, the easiest approach appears to be a new COMPILER_PLUGINS_COM_IS_CLANG analoguous to the existing COM_IS_CLANG.) Change-Id: I9036261fdd238c8a020a1d88b4e75fd444f9e030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88725 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14tdf#130655 callback interface for 3D and secure dashArmin Le Grand
Added same interface for 3D but just for lines, it uses no gaps. Added the security mechanism mentioned in the task in comment (2) to 2D and 3D Change-Id: I5da303c01562088682d95ee4f294c99e1f17bf6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88728 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-14sw: fix handling of table vs fly overlaps in the AddVerticalFlyOffsets caseMiklos Vajna
When a table overlaps with a fly frame, Writer creates a fly portion inside the relevant cell frame (increasing its height), and Word shifts the table down. Both are valid approaches, but the rendering result is different in case the table has a border. So keep the default unchanged, but in case the AddVerticalFlyOffsets compat flag (set by the Word importers) is set, avoid the overlap the Word way. Note that the table frame uses the full width (available in the body) even for e.g. 50% width tables, so check for the overlap using the print area, which does not always overlap. Finally, don't always require a valid frame area definition from the fly frame: - the mentioned i#46807 bugdoc currently doesn't need that check - the fly frame area definition becomes valid only after already positioning the table, leading to an overlap Keep that check for the non-compat case, though. Change-Id: I9202050befebf2efdbb5395ded6fcb52b378d8e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88724 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-02-14convert XMLEventsImportContext to fastparserNoel Grandin
for now, it supports both fast and non-fast methods, since it is constructed by both contexts Change-Id: I925c50be161b95ecebd951cb7038a938c848a15d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88715 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14Resolves: tdf#130658 there isn't a second column in non-exception modeCaolán McNamara
Change-Id: I35edf263251c087976aa9a2506bb23c083e1f7c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88718 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14tdf#122218: Baseline Xcode 9.3 ld presumably doesn't support -platform_versionStephan Bergmann
...according to <https://github.com/llvm/llvm-project/commit/ 25ce33a6e4f3b13732c0f851e68390dc2acb9123> "[driver][darwin] Pass -platform_version flag to the linker instead of the -<platform>_version_min flag": "In Xcode 11, ld added a new flag called -platform_version [...] This patch adopts the new -platform_version flag in Clang, and starts using it by default, unless a linker version < 520 is passed to the driver." So detect new HAVE_MACOS_LD_PLATFORMVERSION and adapt 645fe53be0dc36535dba0ed684e21ca4cda80d70 "tdf#122218: Hack to avoid blurry text with macOS SDK 10.15" accordingly. (This also changes the passed -platform_verion sdk value from 0.0 to 0.0.0, for cosmetic consistency with the default Clang behavior cited above. Also, after f67e5ef9a5c71f3b35b1c67eb72794e44cc15410 "Drop broken filter-out of -bind_at_load for Executable_soffice_bin on macOS" got included in the meantime, the surrounding ifeq in desktop/Executable_soffice_bin.mk can be combined now.) Change-Id: Ie1ddf2d618e2f1232c6b4e17ce17665851f3bd38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88717 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14sw: fix splitting text frames wrt. footnotes in followMichael Stahl
When the simplified (thanks Vasily) bugdoc is loaded, it has 2 pages and the last text frame 6 on page 1 has N lines, but after hiding tracked changes and showing them again, page 1 has N-1 lines, the last line starting at offset 1064 moved to the follow frame 7 on page 2, and this is the only difference from the state after loading. Frame 6 is formatted exactly 3 times; the difference between the 1st and the 3rd time is that footnote number 8 (footnote frame 34) doesn't exist yet the 1st time, but is on page 1 at the 3rd time. This reduces the space available in the body frame from 14040 to 13817, and SwTextFrameBreak::IsInside() finds there's not enough space for the last line. Interestingly the sw_redlinehide didn't change anything here; this reproduces in the same way back to OOo 3.3. There's a few obvious ways to try and fix this: a) The footnotes that are anchored beyond the end of the current text frame are moved by RemoveFootnote() called later: 4 in SwTextFrame::RemoveFootnote() at sw/source/core/text/txtftn.cxx:508 5 in SwTextIter::TruncLines(bool) at sw/source/core/text/itrtxt.cxx:375 6 in WidowsAndOrphans::FindBreak(SwTextFrame*, SwTextMargin&, bool) at sw/source/core/text/widorp.cxx:338 This could be done earlier, in IsInside(), which already tries to do 2 other things to get more space, so it seems plausible that footnotes which are known not to be in the frame (including the line that doesn't fit) could be moved off the page. b) An approach similar to commit e37ffdd118da2d21c5e78e8c7b67252d0d1adc8c "tdf#125685 sw: disregard footnotes in follow table on table split" would be to temporarily add the footnotes anchored beyond the current frame to the available space, and leave them to actually be moved later. c) When RemoveFootote() is called and it does move a footnote, invalidate its anchor text frame so that it gets formatted again. This seems to have the highest risk of introducing loops though. Let's try out a) for now and see how it works. Change-Id: I54b59637b79d67f5eca61f11bd575145f244381f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88714 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-14tdf#130655 added callback interface to ::applyLineDashingArmin Le Grand (Collabora)
This version of the tooling method allows to avoid collecting line snippets in a return value PolyPolygon. Instead, offer lambda functions to get callbacks for created snippets. The original method using a B2DPolyPolygon return value is adapted to already use this, so serves as example of usage and ensures that only one identical algorithm is used. Change-Id: Ie306968a895ad280fc2425fb40b3244769216ba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88684 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@me.com>
2020-02-14lok: Center shape on insert also for Desktop viewMuhammet Kara
Change-Id: I85c3fe3d0166eb42f46f2aa65d0319e582b851af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88489 Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Jenkins
2020-02-14tdf#121963: Add unittest (part 2)Xisco Fauli
Forgot to add the .cxx file. Thansk to Miklos for noticing Change-Id: I922680fde98f51f4339fb0e188310b0d7cc635a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88708 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 0b1d0df74b7b9dc98c18fccd375272f2dbe77256 - tdf#130620 add help about File associations - add entry for new "File Associations" button Change-Id: I598664d50fb9ad75cb3a48c8325c1616df43da75 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/88501 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-02-14split StringToMetric and TextToValue into fieldvalue.hxxCaolán McNamara
Change-Id: I5d1102f7a50a7a246df9f6de8b7a6df6557eb54d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88682 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14Optionally generate PDBs also for nssJuergen Funk
Enables pdb generation for symbol builds, for: - freebl3.dll - libeay32.dll - nspr4.dll - nss3.dll - nssckbi.dll - nssdbm3.dll - nssutil3.dll - plc4.dll - plds4.dll - smime3.dll - softokn3.dll - sqlite3.dll - ssl3.dll - ssleay32.dll Change-Id: I231fdc8e8ade7b7a8b85fc76536291e0546f2eac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88673 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-14Fix typoAndrea Gelmini
Change-Id: Id0bffcf1e58c7ecfff9814c00ec0de4e08a3d9ae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88710 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14Fix typoAndrea Gelmini
Change-Id: Ice82d39a0f523f3d535ecf2669edc3856c378e15 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88711 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14split out MetricField value conversion functionsCaolán McNamara
Change-Id: I67a33bd2a5cb06dc66e471918b5c378044a2eff2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88679 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14Drop broken filter-out of -bind_at_load for Executable_soffice_bin on macOSStephan Bergmann
We generally use -bind_at_load ("Sets a bit in the mach header of the resulting binary which tells dyld to bind all symbols when the binary is loaded, rather than lazily." according to Xcode 11.3.1 ld(1) man page) since 4c9c1957cfc7c9de3def35dab4dcd07e76992ddd "INTEGRATION: CWS geordi2q01: #i18350#: join changes from CWS ooo11rc3" (lacking any explanation; later carried over into solenv/gbuild/platform/macosx.mk). And we filtered out -bind_at_load for Executable_soffice_bin (and others, back then, which have become irrelevant by now) with 13be934b43266d3df966ce40c00316401cea7a90 "INTEGRATION: CWS geordi2q14: #111934#: merge CWS ooo111fix2" (again, lacking any explanation). However, the latter was effectively broken when 6df9c479f58ea94141a3a43eb7fd6fb4d1fd5c8b "gbuildize desktop" rewrote it in desktop/Executable_soffice.bin.mk as $(eval $(call gb_Executable_set_ldflags,\ $(filter-out -bind_at_load,$$(LDFLAGS)) \ )) lacking an "soffice_bin," at the end of the first line. Given that the soffice executable is apparently built with -bind_at_load ever since 2011, without causing any issues, lets assume that filtering it out is no longer necessary (if it ever was), and drop that. (Maybe it was once necessary for some reason when the file system layout of OOo/ LO executables and dynamic libraries was different. But today, the soffice executable finds its dependent libraries, sal and sofficeapp, via @executable_path just fine.) Change-Id: Ifa379237cce4fa6d5ea0e2c1f1d84263f9007c50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88680 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14tdf#121963: Add unittestXisco Fauli
Change-Id: I33435643d1f4c0af8c846094f9f40845d6327b60 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88627 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14tdf#130373 substitute color only works if left set to transparent.Noel Grandin
regression from commit e27be9dfbcf8636a7440f828435b1860dfa38977 Date: Wed Jul 3 15:07:44 2019 +0200 move some Bitmap replace logic inside vcl Change-Id: I0d985314367e26134c940e54f485db373d4c3642 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88675 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14tdf#130556: Add unittestXisco Fauli
Change-Id: Iab632cd3afe6bb1c5f90a700a452c6c4dad14261 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88617 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-14RTF/DOCX export: always set hyphenation to auto at document levelVasily Melenchuk
MS formats unlike ODT have also global setting for hyphenation params. Previous approach was to set this global value depending on default paragraph style settings. However, if hyphenation is enabled ony for specific other paragraphs, hyphenation in MS Word will not work. Let's try to set global hyphenation value to "auto" and explicitly enable/disable hyphenation on paragraph level. Change-Id: I199fa80eb1204930e2640dac0e90802b6b98597b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88536 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-14tdf#42949 Fix IWYU warnings in forms/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4afb3616c4f93155c187da11b2981b84d0984e9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87943 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-14use forward decls to reduce including unnecessary headersCaolán McNamara
Change-Id: Iaa25ac1ac99e0dcf09bce21f4bad8cb9b5568a1e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88633 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14weld SearchLabelToolboxControllerCaolán McNamara
and split out LabelItemWindow to reuse it Change-Id: Ie14f1bdc6d8684db088c018afd341e10bee9d977 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88623 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14don't need to include split.hxx or scrbar.hxxCaolán McNamara
Change-Id: I775e77a0f303d66ca571e1851205b8286c840bc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14move dialog.hxx to vcl/include/toolkitCaolán McNamara
Change-Id: Ia3877f58b6e5ccc4fb1621e6b928638e0c850e7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88602 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14de-duplicate some codeCaolán McNamara
Change-Id: I5900ee56cf5c80f00743060d1d22dfd3d383f1eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88622 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14weld SearchFormattedControl Item WindowCaolán McNamara
Change-Id: Ifda9e514ae0329a756ec365a40ec1ccfcfea14ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88621 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14weld MatchCaseControl Item WindowCaolán McNamara
Change-Id: I33a8d96c449e653284d570ef534dcc453f27ad5e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88619 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14drop need to include vcl/edit.hxx in cuiCaolán McNamara
Change-Id: I9479a7e8fc5b3897e48efc47dbae979137718bc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88618 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14move VCLXFileControl to toolkitCaolán McNamara
Change-Id: I39bb417fe7e033a8f368fa04d4a30b2388bcddfb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-14xmloff: create SchXMLImport instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I6b4a78317e2b228296c8e4794c776b617920ccfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88630 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-14Fix typoAndrea Gelmini
Change-Id: Id300274f334b13b54d792ed5f9813522c5ca6018 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88668 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-02-14deliver more useful message when I mess up a conversion to shared pluginNoel Grandin
Change-Id: I6b5fb2977965b5366d698d960a2c75845cbd6ea6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88589 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14tdf#122218: Hack to avoid blurry text with macOS SDK 10.15Stephan Bergmann
...by setting the LC_VERSION_MIN_MACOSX load command's sdk value to n/a in the soffice executable. See <https://bugs.documentfoundation.org/show_bug.cgi?id=122218#c167> for how this helps, even though I have no idea why it helps. (Adding that -platform_version linker option appears to generate warnings like > ld: warning: passed two min versions (10.13.0, 10.13) for platform macOS. Using 10.13. but which are probably harmless.) Change-Id: I043498c7ff2d148d4a7e1e0e9d46241b638f2eba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88667 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-02-14make unusedmember use the shared plugin infrastructureNoel Grandin
Change-Id: Ie2f5ada6e27544ca1bceabe6fcfe524063d3201f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88588 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14add some more libs to libmergedNoel Grandin
Change-Id: I9e1677c26cf082ed78765995bfa7f57ff50f8e7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88580 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-14tdf#130573 labels exchanged in export to BMPNoel Grandin
In the commit below, I removed the 1-bit dithered output, so restore it. regression from commit b5699cd01b6a52906880c107bac6f3802ea7353d Date: Wed Feb 8 16:18:32 2017 +0200 convert BmpConversion to scoped enum Note that this bug has been around since LO5.4 which means that anyone who has adjusted their setting in officecfg/registry/schema/org/openoffice/Office/Common.xcs with key BMP runs the risk of having that setting now revert to its prior (documented) meaning. Change-Id: Ibbda8aefbac261ff37ffab7223714f5d0343c692 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88528 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>