summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-01-27bump product version to 7.1.0.3.0+libreoffice-7-1-0Christian Lohmaier
Change-Id: I92f40f88d3532ef08430280c3e9afd8907f0b57f
2021-01-27NSApplication's appearance property exists in macOS 10.14 and later onlyTor Lillqvist
Change-Id: I12f586d91e40da130f59eeba3ab65e07eec088d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110013 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/110015 Tested-by: Jenkins (cherry picked from commit 02bb41dd5197503d0d8b7d8be0a8cd220c0d1c85) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109988 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 1f400d35d61076c460a28b2b83dddc9297f38140) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109991 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-27update creditsChristian Lohmaier
Change-Id: Ib58485cc97b61b6e8178b2c2b143a30e520cb373 (cherry picked from commit e2befe5302847a4bcb00c7429886aa2c5c7928bd) (cherry picked from commit 59ff6a79475bdf48765a16cf5f597757466a2748)
2021-01-27tdf#135014 sw: fix crash exporting numbering to DOCXMichael Stahl
It can happen that the default SwNumRule of a SwList isn't used by anything directly, but there are other SwNumRule associated with that SwList and then the DOCX export needs to export it as an abstract numbering definition. (regression from 632ee9aae6d5f3cf08b6d6b2789310c20db713b7) Change-Id: I6b1851980464aaa95bf731a60b7d11ab91cec7b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109303 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit cd1c9f5167e797807d6726219f06190657f58372) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109334 Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit d7c77b1b718ba0ca61e153bcf91237c9cf6d9b60) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109405 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-27tdf#138409 numerical ControlFormat strings shouldn't be localizedCaolán McNamara
i.e. input fr/de 12,34 should be stored as 12.34 Change-Id: I20c97d2d604998a40e3a15963aa3d8716101e3c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109750 Tested-by: Jenkins Reviewed-by: Lionel Mamane <lionel@mamane.lu> (cherry picked from commit c10b7b3c2e9743b284b0acb21a7dd219918d51ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109798 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-27tdf#139857 release mouse on launch context menuCaolán McNamara
Change-Id: I2baa635dbc81c326eecb1fc579a0f80901d4117d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109876 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-27Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-1-0' to cca436f445d5eabaa9d070b2deda49575d32be5c - update translations for 7.1.0 rc3 and force-fix errors using pocheck Change-Id: Iaa85d4328c1d285bd22323f9a7a03b192ebc2d18 (cherry picked from commit 6e03fc253fd37224ff37f4f12576653364a09b20) - Version 7.1.0.2, tag libreoffice-7.1.0.2 Change-Id: I265447b49e50862ac901d394925e04ec28e6cf08
2021-01-26Revert "sw: DOCX export: don't export numPr to style from outline numrule"Justin Luth
This reverts 7.1 commit 9e455724e50bf512683b1cddfeb7493e047c19ae. to fix regression bugs tdf#138780 and tdf#139089 Change-Id: I2a5bbcd990a6648667342cc989160582e0367f09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109864 Tested-by: Justin Luth <justin_luth@sil.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 32d11fb200d45cdacb973b625488d0b8bbee6d81) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109872 Tested-by: Jenkins (cherry picked from commit f2b04cd11cda4d9828e5af1a4160c08bab45496e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109879 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-26Update git submodulesAndras Timar
* Update dictionaries from branch 'libreoffice-7-1-0' to 9737c497edad371ae3c3507c8200d66844cb8d36 - update Danish dictionary Change-Id: I367128d4d4bd5080f6a39c0bfad085027ef9bea6 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/109874 Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Aron Budea <aron.budea@collabora.com> Tested-by: Aron Budea <aron.budea@collabora.com>
2021-01-25Resolves tdf#139501 - About screen exceptional widthHeiko Tietze
All strings wrap now Change-Id: If810e67e55eb23685ab4e14da9d5da1864229833 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109338 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-25tdf#138122 Add window scaling for retina displays on macOSThorsten Wagner
(1) Remove hack to make application look as if being linked against SDK 10.13 (2) Use quad storage size on virtual devices for displaying on retina displays thereafter (3) Apply workaround to downsample bitmaps from scaled layers (to be implemented) (4) Disable dark mode (to be implemented) (5) Provide new environment variables: VCL_MACOS_FORCE_WINDOW_SCALING: window scaling on non retina displays VCL_MACOS_FORCE_DARK_MODE: enable dark mode (macOS 10.14, iOS 13 and newer) VCL_MACOS_USE_SYSTEM_APPEARANCE: use light mode or dark mode (macOS 10.14, iOS 13 and newer) as configured by system preferences Change-Id: I99877cd62a98cb91bcbf27af62b043c31c5f5fc9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109072 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109495 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109557 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-22tdf#139298 New created query doesn't show any rowCaolán McNamara
regression from... commit 5f7cf9ccba25a94c275ec67936dc29f0adb4129a Author: Caolán McNamara <caolanm@redhat.com> Date: Mon Aug 10 19:49:25 2020 +0100 use InterimDBTreeListBox Change-Id: I755879699aa6fcc9b42b5845ae60406794e11cc2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109738 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21tdf#139332 reduce height of expert config dialogCaolán McNamara
to about the height of help, options Change-Id: Icf2bebb2f2cc5aabea3e1f702d7095de8c31d726 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109527 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 9a98581b1379c17719f75ae85d3afe20b653c0d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109581 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21Adapt solenv/flatpak-manifest.in to recent download.lst changesStephan Bergmann
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109565 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 2197f69f1b91ff13d0dcd078685ab23466241197) Merge conflicts: solenv/flatpak-manifest.in Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109632 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 3360f84050c46ff3ed862c2415e71469f479ce2f) Merge conflicts: solenv/flatpak-manifest.in Change-Id: I8e81fd375bd819a62a543960a2368e3bf965c8c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109728 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-21Community splash screen without EditionHeiko Tietze
macOS installer shows also just Community now Change-Id: Ia71d3b3a376f8e5e2254f2863ea61f065fb2d86f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109577 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-21tdf#136704 sw autofmt: prevent crash if no nextNodeJustin Luth
The second GetNextNode() was a nullptr that was being dereferenced. Now, when enter is pressed after some text followed by a colon, that line is made into a heading3, and the new blank line is properly using the text body paragraph style. Change-Id: If10dc85e490ac57fc150b3d541f5033dfd5293bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109413 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit fea7b531a4c9e8326a644cccc26325b16585675a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109519 (cherry picked from commit 4ef34f805c5682594a76802fff98889bd6052c3c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109583 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-01-21CGLayerHolder::getScale() can be constTor Lillqvist
(Will be required by upcoming bugfix.) Change-Id: I727b2b5f1035ae70d62d3c5339a814161e3ec92a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108663 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109494 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109556 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2021-01-20Resolves tdf#139521 - Hide image anchor option in Writer Web modeHeiko Tietze
Change-Id: Ic5298069fcabbd2c72eb43fdf270b69c53570298 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109524 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-20Update git submodulesRene Engelhard
* Update dictionaries from branch 'libreoffice-7-1-0' to 625cc9846854ed05246a007a24095b580eebf8cf - deb#979439 tdf#139193 recode it_IT/it_IT.dic to UTF-8 since that is what .aff is anyway/.aff specifies. Otherwise it doesn't work. Change-Id: I89fac7d4eeb7f0d4f8df316978c27c3a8677e2f5 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/109332 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: René Engelhard <rene@debian.org>
2021-01-18tdf#116394 writerfilter: append '=' if not a formula markerJustin Luth
Oops - a silly mistake to throw away the character if it didn't match a special purpose. There is no point in adding a unit test for this. Change-Id: I3b48af578ae96744405ec0919ff341d1c9b43f65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109426 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> (cherry picked from commit b232b422a3cfe3b410bbc75e0fffdfc238fd10e7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109397 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit d864b799e0460c2c8ada62fd598e7adcb1ac6700) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109409 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-18tdf#139643: fix missing PDF/UA flagJulien Nabet
Regression from: https://cgit.freedesktop.org/libreoffice/core/commit/vcl/source/gdi/pdfwriter_impl.cxx?id=a795886762a6a4aabd601183598c4e6c819bcb1f author Arnaud Versini <arnaud.versini@libreoffice.org> 2019-09-20 19:01:34 +0200 committer Arnaud Versini <arnaud.versini@libreoffice.org> 2020-02-08 15:03:07 +0100 commit a795886762a6a4aabd601183598c4e6c819bcb1f (patch) tree 93a58d738bf27a0c5f75f80dc7e651763916ee5f /vcl/source/gdi/pdfwriter_impl.cxx parent a2f62a861ba7036e689070c47f72214b1bdd49d4 (diff) Add minimum support for PDF/A3 here: sal_Int32 PDFWriterImpl::emitDocumentMetadata() { - if (!m_bIsPDF_A1 && !m_bIsPDF_A2 && !m_bIsPDF_UA) + if( !m_bIsPDF_A1 && !m_bIsPDF_A2 && !m_bIsPDF_A3 ) Change-Id: Id4b3b9a74ccf5a5abd9e7149cb09b3475dd4ffee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109399 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins (cherry picked from commit f1d7be7863e7d2d5aa3c3008bb9ec04780d5eb95) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109515 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-14bump product version to 7.1.0.2.0+Christian Lohmaier
Change-Id: I58e84404ccb6f7eb9690416513b73d224fd885d7
2021-01-14Branch libreoffice-7-1-0Christian Lohmaier
This is 'libreoffice-7-1-0' - the stable branch for the 7.1.0 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.1.x release, please use the 'libreoffice-7-1' branch. If you want to build something cool, unstable, and risky, use master.
2021-01-14Resolves tdf#139343 and tdf#139335 - Community/Enterprise flavorHeiko Tietze
* Switch CE/EE per --disable-community-flavor internally use HAVE_FEATURE_COMMUNITY_FLAVOR * Version info in about dialog shows text depending on this flavor * Start center also shows the brand image now * TDF builds use a brand image with TDF tagline in the about dialog * Brand images with just "Community" (no Edition) Change-Id: I363dd2b39df9aad951c9d79addf9bdedfc4a3495 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108980 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 2d69acfde50cb0e06a9a057939078fd102d371a3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109274 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2021-01-14Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-1' to 71869d4e313a0ea83cb90f1987b32e2f1b65e45f - update translations for 7.1.0 rc2 and force-fix errors using pocheck Change-Id: I643f6b7b2a613da42efd1c76a9e2a5ab847146da
2021-01-14tdf#136155 let the other elements in the dialog determine the final widthCaolán McNamara
Change-Id: Ib47db4f47a331b1f3754ca4974a9f3e5b14efc95 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109277 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14Resolves: tdf#138675 crash on checking if focus is in OFieldDescControlCaolán McNamara
use has_child_focus instead, which didn't exist at the time of... commit 3fc63a7463149685b04c676968a82bc00a48a9af Date: Fri Aug 28 10:29:55 2020 +0100 weld OTableBorderWindow and so sidestep that m_pActFocusWindow has always fallen out of sync when OFieldDescControl clears its contents Change-Id: I274131c314a00bdfec2e877a2baa3758d45c325f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109127 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-14Resolves: tdf#139299 crash on gaining focus during disposeCaolán McNamara
Change-Id: I5fd2b3cec7dd0c2c10c88006ef1812e57b547e0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109128 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-14tdf#139566: Fix select all (table + text) when document window looses focus.Tamás Zolnai
Without setting mbSelectAll properly the selection cursor is converted to a SwShellTableCursor, which can't handle if a selection is extended outside of the table. Change-Id: Ibd43097ac782b9fc02ff818d3911ebcd20efbd21 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109185 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109205 Tested-by: Jenkins (cherry picked from commit 68b1ae7b493eea4d77f36a0c8566ca0224f04798) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109123 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14tdf#128353 sd slideshow: fix handling of animgifs on slower machinesMiklos Vajna
Regression from commit 3e0092031b73bad107e3122d5d4be2f5bd487744 (tdf#112318 sd opengl: fix lack of initial animation, 2019-04-05), the problem was that in case a timer adds itself to the end of the scheduler queue during Scheduler::ProcessEventsToIdle(), then the idle trigger in SlideshowImpl::updateSlideShow() will never finish. The intention of invoking idles is to help vcl backends which do the actual painting in an idle, so actually it's enough to only process tasks which are already scheduled. That is enough for skia/gtk3/etc and avoids the problem with the animgifs. This is only a problem in debug builds or on slower machines: the animgif from the bugdoc wants to play a frame every 40ms, so in case processing the current tasks finishes faster than that, then the problem was not visible. (cherry picked from commit c33dd70aa7a6a5dc28b99f8af123548b02a77884) Change-Id: I7487cb9a79e7e5acc0b816eb4744a04559ae26ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109107 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14oox smartart: fix crash in pyra algorithm with a single child shapeMiklos Vajna
Regression from commit 14a56533ff2c9c859d22cd3039ada75b99e94bc0 (SmartArt Pyramid: Now lays out shapes, 2018-07-10), the added pyramid algorithm by first centering the topmost children, then decrementing the horizontal postion of each additional shape, with the end goal of having 0 horizontal position of the last children. This means that simply avoiding the division in the 1-child case leads to correct results, because in this case the only child is also the last child at the sane time. (cherry picked from commit f2e04fe98e313cffa3f98d55eae641415142a431) Change-Id: Ifd0027e9616b0909dbfde43e1555427b50de4dad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109183 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14tdf#139567 set no-show-all to TrueCaolán McNamara
so changing child vis to false before parent is shown 'sticks' as a final visibility of false Change-Id: Ieee4e4c7f7bddf6204c61ca788d316d52ef5a6dc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109247 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14tdf#113013 XLSX import: fix "Formula is" type conditional formattingTibor Nagy
rule when the formula contains a reference to another worksheet. Change-Id: I873fad97a88df64e885fef20d4259ef6bfeaa06b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108850 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit fcd96df8f648439ea191d8c2070e8b21ff0b1001) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109124 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14tdf#137083 consider negative width in DrawPageViewGridRegina Henschel
SdrPageView::DrawPageViewGrid is called too for a ScDrawPage of a RTL-sheet. In that case both the width of the SdrPage and the left edge of the passed rectangle are negative. The x-values for drawing the grid were wrong and a right-to-left sheet did not show the grid. The patch adds a case distinction with correct x-values for case RTL. Change-Id: I6d0c15bf7bbe8aff6ab2e72a440ba81f2e0e2281 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108989 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 7635a475130a0e9e3b0dded853348659d07a00d7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109119 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14tdf#83618 Make line spacing values agree crash fixJim Raykowski
The intent of this patch is to fix the crash reported at https:// bugzilla.redhat.com/show_bug.cgi?id=1913828 by reverting changes made to cui/source/tabpages/paragraph.cxx in commit 849b837d1a3b185a8dd893a8f6eaed53605bcab1 and changing the change made to svx/source/sidebar/paragraph/ParaLineSpacingControl.cxx to use the already available pointer to the current SfxViewFrame instead of calling the SfxViewFrame::Current function again. Change-Id: I0c440c576c2afe4fb98ed54d51d91ea16a7f902a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109113 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-14tdf#138995 DOCX import: fix handling of textbox zordersMiklos Vajna
Regression from commit d379d18666aa42031359ca8eb34b0021960347ae (oox: import WPS shape with text as shape with textbox, 2014-06-18), the problem was that a textbox's shape + textframe are internally 2 sdr objects, so once GraphicZOrderHelper knows the current shape should be on top of a shape+frame pair, it should suggest a larger ZOrder. This is necessary till there is no setter version of SwTextBoxHelper::getOrdNum(), which would allow import filters to ignore this complexity, but that would be a larger change. (cherry picked from commit 200cd2b99bee18962a970edc5d059286f6c3ea0e) Change-Id: Ibbb1bcd9301eb369f25f211120f62be7c59b0fd2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109184 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-13tdf#139074: Revert "WIN replace clipboard update thread with Idle" et alStephan Bergmann
This reverts commit 9617bc9544cd569066ff187c3672a87fe28fe17f "WIN replace clipboard update thread with Idle" plus follow-up commits f5ab8bcbfd20ecce4a358f62ee3f81b8b968a5de "WIN don't notify clipboard change with SolarMutex" and c921f9bd64187823af2356d7a8ceb77444c17219 "Release solar mutex before using an apartment-threaded COM object". The Gerrit Jenkins Windows builds had started to abort after timeout for almost all builds now. Going back to before the youngest of the above three commits, c921f9bd64187823af2356d7a8ceb77444c17219 "Release solar mutex before using an apartment-threaded COM object" did not improve things (see the <https://gerrit.libreoffice.org/c/core/+/109100> "Test build #1, DO NOT SUBMIT" chain, where three out of three of the Gerrit Jenkins Windows builds timed out). But going back to before the oldest of the above three commits, 9617bc9544cd569066ff187c3672a87fe28fe17f "WIN replace clipboard update thread with Idle", does look promising (see the <https://gerrit.libreoffice.org/c/core/+/109155> "Test build #7, DO NOT SUBMIT" chain, where three out of three of the Gerrit Jenkins Windows builds succeeded). So the hope is that reverting all three commits brings back a green master, allowing us to understand and fix the actual issue later. Change-Id: Ie83ba742f216396b49f561d19c2cda7758740502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109158 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 694b400f56842cd29ad1a960853cde5aef91e4f0) Additional information regarding the backport to libreoffice-7-1: c921f9bd64187823af2356d7a8ceb77444c17219 "Release solar mutex before using an apartment-threaded COM object" was never backported to libreoffice-7-1 so this patch only reverts 9617bc9544cd569066ff187c3672a87fe28fe17f "WIN replace clipboard update thread with Idle" and f5ab8bcbfd20ecce4a358f62ee3f81b8b968a5de "WIN don't notify clipboard change with SolarMutex" in libreoffice-7-1 branch. The backport was done using gerrit's interface by Xisco Fauli and no conflict was found while cherry-picking it. However, this change wasn't backported: --- a/vcl/win/dtrans/WinClipboard.cxx +++ b/vcl/win/dtrans/WinClipboard.cxx @@ -91,9 +84,6 @@ CWinClipboard::~CWinClipboard() uno::Reference<datatransfer::XTransferable> SAL_CALL CWinClipboard::getContents() { - DBG_TESTSOLARMUTEX(); - SolarMutexReleaser aReleaser; - osl::MutexGuard aGuard(m_aMutex); so it was added manually. See https://gerrit.libreoffice.org/c/core/+/109115 Change-Id: Ie83ba742f216396b49f561d19c2cda7758740502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109115 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-13elementary: tdf#139056 update VIOLET color to follow upstream brandRizal Muttaqin
Change-Id: I9d27b42eb2193089914b2bb55623236be158985d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109026 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 85e0f5449a115939ec38239c93f69f067cce48e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109121 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2021-01-12Update git submodulesAndras Timar
* Update translations from branch 'libreoffice-7-1' to 47577968ccfbc64b78536a117cf1134407bd015e - Updated Slovenian translation Change-Id: I7d23ae8c6d9b0e2c46b26fe315948c265e152b48
2021-01-12Avoid assertion failure related to cursor sizes on macOSTor Lillqvist
No idea why this assertion failure started to show up now (at least when viewing a presentation slide show). Anyway, apparently the code needs to handle 256x256 cursors, too, and not just 128x128 and 32x32 ones. Apparently the assertion failure is caused by icon-themes/colibre/vcl/res/null.png. Sadly I don't really understand the code around here, but this commit gets rid of the assertion failure, and that is good enough for me for now. This problem was reported in a comment in the otherwise unrelated tdf#138122, and the assertion failure caused a hang, which is not good, reported as tdf#139535. That general problem is not fixed by this commit. Change-Id: I1390f00e03e0766d54969d9d62311a55da8e8945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109083 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109164 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-01-12rhbz#1913070 null derefCaolán McNamara
its plausible that SfxViewFrame::Current() has returned null, use pSh->GetDispatcher() instead protected by null check against pSh Change-Id: Ibefdcabea09cb3a1a411678585af33a99f8a1c61 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109003 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-12rhbz#1902708 null derefCaolán McNamara
Change-Id: I718ac8a59e5cb18c840e458de8e9f877c6449fd8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109004 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-12Related tdf#123632: fix crash in accdoc (sw)Julien Nabet
Make sure to use gtk3 rendering - Open https://bugs.documentfoundation.org/attachment.cgi?id=149492 - Click F5 to open the navigator - Go to Images - Try double click the third and last image at least 15 times -> crash, here's part of bt: Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault. SwFrame::IsInTab (this=0x0) at sw/source/core/inc/frame.hxx:938 938 if ( mbInfInvalid ) (gdb) bt 0 SwFrame::IsInTab() const (this=0x0) at sw/source/core/inc/frame.hxx:938 1 0x00007fd7e78caf9c in SwAccessibleDocument::getExtendedAttributes() (this=0x7e4e090) at sw/source/core/access/accdoc.cxx:596 2 0x00007fd7e78cbf9d in non-virtual thunk to SwAccessibleDocument::getExtendedAttributes() () at sw/source/core/access/accdoc.cxx:708 3 0x00007fd7f18f90ad in attribute_set_new_from_extended_attributes(com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleExtendedAttributes> const&) (rExtendedAttributes=uno::Reference to (SwAccessibleDocument *) 0x7e4e180) at vcl/unx/gtk3/a11y/gtk3atktextattributes.cxx:1229 4 0x00007fd7f19113f3 in wrapper_get_attributes(_AtkObject*) (atk_obj=0x7df37d0) at vcl/unx/gtk3/a11y/gtk3atkwrapper.cxx:394 I put "Related" because I don't know if it corresponds to the initial bug but I used the attached file of the bugtracker Change-Id: Ief9fda9f7bcf277d18490169eee2e43fb046a1bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109051 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 003b45624788610fba98e3f3334f99140017e472) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109001
2021-01-12xmloff: "form:datasource" vs. "db:data-source"Michael Stahl
Recently xmloff started to use XML_DATASOURCE for "form:datasource" but it actually means "data-source". Add XML_DATA_SOURCE and use it for "db:data-source". (regression from 3de38e95561ab7ca114d9f3307702ba89c4e3e9a) Change-Id: I893efd3fb0fb7c19ae998442459bf36cb1da0b20 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109019 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit db283d2e3f5cd8be412c5204f358cd06af761b13) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109000 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2021-01-11set fill color when filling alphavdev area for gradients (tdf#138959)Luboš Luňák
When drawing a gradient to an alpha-enabled output device, make the area also opaque (=black in the alphavdev). Change-Id: I2ba1a598e0bf6291e5422253352a201e224af2b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108806 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 41cabebf9c95459c2c1912528446c45e70c3f203) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108906 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-10Bump copyright year to 2021Adolfo Jayme Barrientos
Change-Id: I3159bfc21a35fc80aef57c7d809d8ea8c62a732e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108566 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 1f1f68d6e8a32d8884e8de322e32c588a87964db) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108581 Tested-by: Jenkins Reviewed-by: Martin Srebotnjak <miles@filmsi.net>
2021-01-10tdf#96787: AutoCorrect: after deleting a replacement entry, it's still usedJulien Nabet
If specific acor<language>.dat exists in "user", don't use the initial one in "share" since the initial one will still contain the deleted entry. See detailed explanation here: https://bugs.documentfoundation.org/show_bug.cgi?id=96787#c21 Change-Id: Ic349159c93d9fc327f38a1d4e8187e3bdc16d08a Change-Id: If6b16641d04721f2945a8e920e2933d1b8baa90f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/109039 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit ae56dc05b27f05ffcee99845d661a237e70a7a51) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108998 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-10Update git submodulesAndras Timar
* Update dictionaries from branch 'libreoffice-7-1' to 0f14b92783008b49eedd6d3dbf40b7becd71746d - Updated Slovenian thesaurus Change-Id: I189ae0f22fe2fa73d04fd149b8defdd1d7bb1f15 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/109040 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit a706f520e612d1148c6d259b595ba4815be99f50) Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/108996 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-01-08tdf138773 Chart OOXML import: set text overlap to falseTünde Tóth
of category axis label, if the rotation is undefined in xml, to avoid e.g. missing rotation of them. Regression from commit: 21620f9d2f50e66dffc45a5afb539edb8d54434c (tdf#138194 Chart OOXML import: set text break to true) Change-Id: I5b03614eca547a206afc0d8118e3f6c055ed5348 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108792 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 2752fd1b665694a4db3a4e34c7fdc8780a86492e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108992 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-01-08openssl_headers depends on generated opensslconf.hStephan Bergmann
...at workdir/UnpackedTarball/openssl/include/openssl/opensslconf.h, as can be seen with failed builds like <https://ci.libreoffice.org//job/lo_tb_master_mac/35209>: [...] > [build PAT] openssl > [build C ] UnpackedTarball/mariadb-connector-c/plugins/auth/caching_sha2_pw.c > [build C ] UnpackedTarball/mariadb-connector-c/libmariadb/secure/openssl_crypt.c > [build DEP] LNK:Library/libclucene.dylib > [build LNK] Library/libclucene.dylib > In file included from /Users/tdf/lode/jenkins/workspace/lo_tb_master_mac/workdir/UnpackedTarball/mariadb-connector-c/libmariadb/secure/openssl_crypt.c:21: > /Users/tdf/lode/jenkins/workspace/lo_tb_master_mac/workdir/UnpackedTarball/openssl/include/openssl/evp.h:13:11: fatal error: 'openssl/opensslconf.h' file not found > # include <openssl/opensslconf.h> > ^~~~~~~~~~~~~~~~~~~~~~~ > 1 error generated. Change-Id: Ied1dcdd0afb6099e9218671c6a06c0edaafc931e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108928 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 0f7008e91f45cf8e3cee6f372ce012b38a795e26) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/108911 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>