summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-07-01GDB vcl.py: actually return a string in to_stringJan-Marek Glogowski
... and hopefully make it python2.7 compatible... definitly a "brown paperbag" fix... well it did work locally ;-) I just noticed, because Jenkins spilled some errors from GDB on hang with: Traceback (most recent call last): File "/.../instdir/program/libvcllo.so-gdb.py", line 23, in <module> module = importlib.import_module('libreoffice.' + mod) File "/.../python2.7/importlib/__init__.py", line 37, in import_module __import__(name) File "/.../solenv/gdb/libreoffice/vcl.py", line 101 print('STACK', end =", ") Change-Id: I500e8fea07e9865235e37673dee6374108fefbf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118237 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-07-01Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' to c608cc40ecc81cdd6ac9000dc890e3f788f2c094 - Czech Hunspell: fix several verbs of pattern "tisknout" Change-Id: I6d31f9658e2797ff678e36b887f1e2f03689f1c4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/118239 Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com> Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
2021-07-01Update git submodulesStanislav Horacek
* Update dictionaries from branch 'master' to bcf9aa0b95ca7770c5bb74801289477214213fb4 - Czech Hunspell: fix several nouns and adjectives Change-Id: Ifda579bcc6aec9786355837b42a74ea9b2edc1c4 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/118235 Tested-by: Stanislav Horáček <stanislav.horacek@gmail.com> Reviewed-by: Stanislav Horáček <stanislav.horacek@gmail.com>
2021-07-01tdf#142871 sw HTML export: avoid unwanted inner PNG for imagesMiklos Vajna
Regression from commit e76471c5ce725dae9abb6f78b7674c6f77df34f4 (sw XHTML / reqif export: export non-PNG graphic shapes directly, 2021-06-02), reqif wants to have a PNG fallback for non-PNG pixel formats, but this is not needed for plain HTML, make this reqif-only. Change-Id: I0fc1bc13ad4bf808afbe68407e7db802f910c7a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118233 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-07-01XLSX export: handle button form controlsMiklos Vajna
This builds on top of commit 94678a7b9c6b7e577c15adacc885e03551bcf17b (XLSX export: improve handling of checkbox (form controls), 2021-06-30), so now both checkboxes and buttons are handled during export. Change-Id: I278b4925414d29399401cc15ab3d944db88ee0c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118219 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-07-01tdf#143028 DOCX export: fix RangeY regression of preset shapesAttila Bakos (NISZ)
Use property name "RangeYMaximum" instead of "RangeXMaximum" in GetAdjustmentPointYValue(). Regression from commit 99a459dfdfd9f82ed3506708e131dd52a1a62384 (tdf#143028 DOCX: fix corrupt export of shape "bracePair" etc.) Thanks to Regina Henschel for reporting the problem. Change-Id: I2bdc4be9338d0fe4973a209ee97a4d5880aaac6e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118223 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-01Resolves: tdf#138432 Use locale's CharClass to parse numeric i18n contextEike Rathke
Change-Id: I1828f1b6f93228cd517a6a7bd9ae36584bd801a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118226 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2021-07-01tdf#143059 sw export: fix assert crashAttila Szűcs
Incomplete reset in SkiaSalBitmap::ResetAllData() was followed by a broken scaling of a dummy image without buffer/image data. SvxLineStyleToolBoxControl::statusChanged(....) creates a dummy image via GetBitmapForUISolidLine... deleted its image/buffer data immediately ("no line style" dummy image preview for the line style popup list). But the dummy image wasn't ready, it still needed postponed scaling processed by the GPU. This information wasn't reset by Erase, and without pixel data it couldn't be scaled, so this dummy image became a forever "not ready"/ "waiting to be scaled" image. There are parts in the code that require that the image is already scaled... These parts check if scalings are ended with the assert(mPixelsSize == mSize). Note: Use the following method to start LO with Skia in Linux SAL_USE_VCLPLUGIN=gen SAL_ENABLESKIA=1 ./soffice Co-authored-by: Tibor Nagy (NISZ) Change-Id: I5099eb8671a1c5d16668743f26feb47fe99cd70e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118204 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-01can allocate these SfxItemSet on the stackNoel Grandin
Change-Id: Ib2b89613ad3e8f2bcdd51bee10bab3559a64fce4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118208 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01exclude some tests for non-default DPINoel Grandin
Change-Id: I579a25040f42fd930a59079f430423806544752b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118222 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01svp: a bit more correct focus handlingJan-Marek Glogowski
Took me a while to realize, that the focus handling after closing a dialog was somehow broken. This isn't a really good solution, because we can still focus invisble frames, but that is at least needed for CppunitTest_sd_tiledrendering and the reason that crashes for non-headless VCL plugins. Change-Id: I272837bd965439c5c0cd9c8bcbc9d51e3018fdf3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118130 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-07-01sc: VclPtr, missing dispose (Page Style->Edit...->Header)László Németh
Test under Linux: 1) Open Format->Page Style; 2) disable checkbox "Same content on left and right pages"; 3) click on the button "Edit..." to open the Header dialog; 4) click on "Ok". Change-Id: I2ce403a7a37d71f8f6510b6ad00028bc9f7fc5a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118221 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-01sfx2::FileDialogHelper allocate SfxItemSet on stackNoel Grandin
and pass around the explicit sub-type, instead of doing static_cast in various places Change-Id: I28ba8fd6f5c9e2a1ffbf5ec091bcf0ebdd1d18b1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118210 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01BmpCombine::And is deadNoel Grandin
ever since commit ddd2639a482befb4a3bf1f75a88e66c21a691b67 Date: Sat Feb 27 15:50:37 2021 +0200 drop mask from BitmapEx Change-Id: I45fae0140067e2bfe5ce1ae2f5014ce733835ef1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118220 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01can pass this SfxItemSet around on the stackNoel Grandin
Change-Id: Ie2e67ec19cfacdfdd0a6dd85c464cfa326b6500d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118209 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01tdf#143028 DOCX: fix corrupt export of shape "bracePair" etc.Attila Bakos (NISZ)
Regression from commit 63cd67e5e18f01aca303131e148c80398a181a41 (tdf#92525 tdf#142398: fix export of simple custom shapes) Missing property in the shape export property list caused an exception. The return value false led to writing the shape transformation again, resulting a corrupt DOCX file. Optional values have been introduced and if one of the required value is unset, writing of the transformation happens only once. Thanks to Regina Henschel for reporting the problem. Change-Id: Ieae69bb1d2629fdbb91a84325cb100f0ad9d3e12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117763 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-01ofz#30657 Timeout, ignore duplicate images when fuzzingCaolán McNamara
Change-Id: I4471379ad60a96f63ff53a441b801d48197b021c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118216 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-01ofz#30762 TimeoutCaolán McNamara
Change-Id: Iffbf89de479d1038f21a45575957ea7212d6939c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118214 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-01loplugin:unusedenumconstants update resultsNoel Grandin
Change-Id: I6153a67cd041f7dbabb650ad0c0d30427a2e558b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118206 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01tdf#121509 DOCX export: fix corrupt shape anchoring in textboxAttila Bakos (NISZ)
MSO doesn't support shapes anchored to character in a textbox. Convert these shapes by re-anchoring them to the anchor point of the textbox (also recalculating their positions in simple cases), so Word can now open the exported document. Change-Id: I28b244975981d69c50e5d4a46249918af089bae5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117163 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-01Related: ofz#33724 detect earlier if comparison shape has no cshapeCaolán McNamara
Change-Id: I23e2c464ffda5de892ae78a188b4c25b81b61fd7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118213 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-01can flatten this a levelCaolán McNamara
Change-Id: I71742038c2a2ac8e335a404e99f5412430c0ff8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118212 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-01ofz#33724 compareParaShape will return 0 if input shape has no cshapeCaolán McNamara
so return early in that case and avoid the expensive loop Change-Id: Ibdde814322c6e9c094c3652c28e0d79887d1f5bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118211 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-01loplugin:unusedmethodsNoel Grandin
Change-Id: I3ff5333c1e73ca61b0a7339e4b7dcfce211b88e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118207 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01ScriptForge - Backdoor to alternate Python helper scriptJean-Pierre Ledure
While developing a new version of ScriptForgeHelper.py the dev should be sure to invoke the new version instead of the standard version shipped with its LO release. This can be done now by setting - in Python a specific ScriptForge class property ScriptForge.pythonhelpermodule2 = 'user#QA/ScriptForgeHelper.py' - in Basic a specific property of the root class _SF_.PythonHelper2 = "QA/ScriptForgeHelper.py" both in the test script Testing a new version of scriptforge.py can be configured entirely from the test script by inserting next statements import sys sys.path.reverse() sys.path.append('/home/jean-pierre/.config/libreoffice/4/user/Scripts/python/QA') sys.path.reverse() Change-Id: Iab6db518932e9dde9030b7e5bbe00a50dee31840 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118171 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-07-01address style concerns and better practices for pptx footer exportSarper Akdemir
Change-Id: I9954141fb24022487983f2f6ed37e3df2a98c482 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118072 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-07-01tdf#127978 - Don't URL encode filename for navigator's tooltipAndreas Heinisch
Change-Id: I70ea7fb739f14c5c60915acc6c66ea241f67524c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118197 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-07-01Update documentation for uno executableSamuel Mehrbrodt
After -r parameter was removed with 5a1d51139c580dc64578d36dc1b4a31a4e5e0ef8 Change-Id: I1961f35ea375e7fd7426958275de0809c8fc9e2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118087 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-07-01tdf#123936 Add formatting commits to .git-blame-ignore-revsSamuel Mehrbrodt
git log --oneline --author Hofer --grep Formatting --pretty=format:"%H" >> .git-blame-ignore-revs Change-Id: I7fea4396274e926e7866ddb25d68fd068ce345ed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118115 Tested-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2021-07-01tdf#139549 add test to commit 2ffdd37067926ddb841c6055205f267b96706945Tünde Tóth
(tdf#139549 DOCX import: document got modified at import time) to check the fixed position of the frame. Note: to test it under Linux, use SAL_USE_VCLPLUGIN=gen: $ make CPPUNIT_TEST_NAME=testTdf139549 CppunitTest_sw_ooxmlexport16 SAL_USE_VCLPLUGIN=gen Change-Id: I13ddfd5b5b4568bc7eb164cbda23f1d99fcab443 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118074 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-07-01avoid some dynamic_castsNoel Grandin
where we know the object must be of the destination type Change-Id: Ib5c7d1a55a89d77060e4064d3469f706f2ad7040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118166 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01fix indentCaolán McNamara
Change-Id: I8ee2ac371be458b08993f1e197a2f78986e03545 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-01getParaShape() adds bounds checking we don't need in this caseCaolán McNamara
Change-Id: I02f917169fcae0dc5bdfc55653cd21fe67eac9c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118200 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-07-01tdf#143081: fix Basic Replace() function crashes LOJulien Nabet
0x00007f19c0aa6e57 in rtl::OUStringBuffer::append(char16_t const*, int) (this=0x7fff100d0748, str=0x6f6f46a u"晦饖香©", len=-1) at include/rtl/ustrbuf.hxx:659 0x00007f19c0c3c8a8 in SbRtl_Replace(StarBASIC*, SbxArray&, bool) (rPar=...) at basic/source/runtime/methods.cxx:1321 see bt here: https://bugs.documentfoundation.org/attachment.cgi?id=173298 Calling xCharClass->toUpper may change words, eg: "Straße" becomes "Strasse" so the length of the word increases. In brief, we want to use the length of aSrcStr not aExpStr Change-Id: Ia291d47a2021efc7dd9162ca5cc72b7940fdd71e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118202 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-07-01xmlsecurity: remove last not needed direct pdfium dependencyMiklos Vajna
This module only calls pdfium indirectly via vcl. This was the last makefile which had such a not needed pdfium dependency. Change-Id: I25ff0be285a52480d3ac60344235af520f262c16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118199 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-07-01Improve preview of theme color sets - add color set nameTomaž Vajngerl
Change-Id: I1f7b3668ba9dfbab1da283741e99754de2d6be47 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118151 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-07-01Purge out rtl::math::setInfBaiXiaochun
Change-Id: I71af8273c672a4cbcbfefafffd0003ab266dcce6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118132 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-06-30svp: add ostream<< for SvpSalFrameJan-Marek Glogowski
... and also store the window title. Change-Id: I20d8b30f6e8e5c48740fe569d9689a117db11e6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118129 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-06-30tdf#70633 unset Alt if detected as AltGr in both KeyInput branchesCaolán McNamara
we are unsetting Alt if the modifier is AltGr in one SalEvent::KeyInput case but not in another. If I replicate the unset of Alt if AlrGr in the other place then both UTF-16 parts of the codepoint get accepted and the described input case works Change-Id: Ifa8a5afbb1853ef3d5f388fd5e7bd3bbc048e260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118170 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-30tdf#143113 fix crash in dndCaolán McNamara
Change-Id: Ifab741494e4cc6e51ca4cd89b57c3600d80dca44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118163 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-30ofz#35504 clamp input values in cgm filterCaolán McNamara
Change-Id: I96712b8dc8f8eaad3fb8fa6710d0f07fff61b592 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118137 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-06-30fix a size warningLuboš Luňák
d7855213ae60d79f converted this incorrectly, the code right above may set the size as (0,0), and before the commit the invalid size was only negative. Change-Id: I198d025f5c02780ae509f97782bc41ac77fa3407 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117376 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-06-30XLSX export: improve handling of checkbox (form controls)Miklos Vajna
This builds on top of commit fd238380ae7820f12ac1f7c52d0f7180a93f3ba3 (tdf#106181 XLSX export: output form controls, 2020-05-13) and adds the missing VML version which seems to be mandated by Excel 2019. It is not perfect (e.g. there is still an unwanted border around the checkbox), but the checkbox has a correct position and its label is readable, while it was just lost previously. Change-Id: I08198d068a0eb85061d138719cfc60d73c46398e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118168 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-06-30sfx2: try to fix lifecycle of SfxOfficeDispatchMichael Stahl
This can be created either from the global SfxApplication, or from a SfxViewFrame. Particularly in the latter case, the SfxDispatcher and SfxBindings members are owned by SfxViewFrame, so in case that is destroyed, the SfxOfficeDispatch must clear its pointers. It looks like the member pointers are checked before access already everywhere, so just listen at the SfxViewFrame. Change-Id: If08825734e94dd54e32cb77546684fd583c336ec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118162 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-06-30reduce cost of allocating and copying SvxNumRuleNoel Grandin
by using std::move to avoid copying unnecessarily Change-Id: I940b57c9a05c8d75b9a16291fc4f05756fdeea12 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118164 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30tdf#135316 optimise SwCharFormats::FindFormatByNameNoel Grandin
reduces load time by 10% Change-Id: Ic5c90588825592245d09f8ebe03b13e34676496a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/117699 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-06-30StylePresets: set bacground color for ValueSetTomaž Vajngerl
Change-Id: Ifbaab139235dbe2fdcebf278bce2c91c2b744aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118150 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-30swap text and background colors in colorsetsTomaž Vajngerl
Change-Id: I1e1da85d6c58e3ed5ab4c44c2ab0ae7c3b080251 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118149 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2021-06-30uitest: combine create_doc_in_start_center methodsXisco Fauli
Change-Id: I59ea0d0dbd203590e7cedec51d0481c953e5172b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118155 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-06-30indexing: add indexing export as an export filter for WriterTomaž Vajngerl
Change-Id: I26157a8ffeee80b03866569d3d3cec2a34fe377d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/118144 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-05 20:33:07 +0000