summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-09tdf#115084: fix sloppy mnemonic IDKatarina Behrens
Change-Id: I8f9df0baa2862eefada8fafeb384e0129df3f7e9 Reviewed-on: https://gerrit.libreoffice.org/50839 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 74a027f927289911b3b712c1ea0f350cf631b0ae) Reviewed-on: https://gerrit.libreoffice.org/50981 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-09tdf#115015: make crypto settings better fit allocated spaceKatarina Behrens
Oh dear how much do I dislike fixed size dialogs. Everytime they are enlarged to fit new content (esp. gtk3 is rather space-greedy there) someone starts to whine the dialog is now too large Doing what e6d7d7375221 does is not really an option, since there are some 30+ tabpages to try and test for optimal size here. And two more squashed commits: tdf#1155015: Make sure checkbox text really wraps for :wrap property to be effective, a reasonable height request is needed so the text is not forced into single line again tdf#115994: Extensions' option pages need fixed pref. size as they are fixed size .xdl-based dialogs mostly But because of tdf#115015 calculate this preferred size as approx. 14 text edits + some padding to make sure crypto settings will fit the allocated space Change-Id: I3ffb2d794f76781eb62186093b928289593585cf Reviewed-on: https://gerrit.libreoffice.org/50596 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-08Updated coreAndras Timar
Project: translations 962ce48869c8e511ef6034b4cfb857940b61165b followup of core 12a80d5 for Slovenian Change-Id: Ia14f821042850e4c4d4901ff3c4cbbbaa63bc00e
2018-03-08tdf#115420 WIN clean up WinSalFrames DC handlingJan-Marek Glogowski
We still don't return a SalGraphics object from AcquireGraphics without a valid DC. But internally we keep the WinSalGraphics objects around, so we now have to verify the DC before using it. In the end this also fixes the leak of the threaded SalGraphics of the frame. Change-Id: I267c96c04b7d00cb66a6c84c63d1373ebe0f529f Reviewed-on: https://gerrit.libreoffice.org/50908 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit c15ea73f960bbd3d2a4b0c43b467ac62eeba3505) Conflicts: vcl/win/window/salframe.cxx Also includes the following patch: WIN rename SalFrames SalGraphics pointers This renames mpGraphics => mpLocalGraphics and mpGraphics2 to mpThreadGraphics. Change-Id: I649b956abc9587f1be74872d439fefc5f5b21135 Reviewed-on: https://gerrit.libreoffice.org/50907 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 352bd98892c1cdf95756a49f38c84212eebffd7b) Reviewed-on: https://gerrit.libreoffice.org/50958 Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2018-03-08VCL canvas: fix another clipping mistake (related: tdf#115142)Thorsten Behrens
Follow-up to 5d710cf7dda27e78f237211fd92418be4dd1c551 - setupOutDevState() tends to set a clip, better not overwrite that. Change-Id: I52aa7db3ef12e9c2902016460e1bf4914328dc7c Reviewed-on: https://gerrit.libreoffice.org/50920 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit e8ed3dfc35975b9e57da7803168f3e2a117a4004) Reviewed-on: https://gerrit.libreoffice.org/50939
2018-03-08Support for GPG encryption in more ODF filtersKatarina Behrens
not only Writer but also Calc, Impress, Draw and Math Change-Id: I7f9fe86ffe5f9a812a5215617b9e673c73134202 Reviewed-on: https://gerrit.libreoffice.org/45472 Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de> Tested-by: Katarina Behrens <Katarina.Behrens@cib.de> (cherry picked from commit 9e5e92c4a1415aac8b0107950f577d1679499e62) Reviewed-on: https://gerrit.libreoffice.org/50923 Tested-by: Jenkins <ci@libreoffice.org>
2018-03-07Resolves: tdf#116116 vertically center line in allocated heightCaolán McNamara
Change-Id: Iee4cd859cdc52a2272f5b01c3e4a57336cc336a4 Reviewed-on: https://gerrit.libreoffice.org/50891 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-03-07tdf#115142 Revert "slideshow: clip shapes in secondary screen window"Michael Stahl
This reverts commit 99e373cd4c78084ded349f3e3de7b0504af2dd90. This is bogus as it actually does scaling and not clipping, and the actual clipping bug is in the VCL canvas, see following commit. Also should fix tdf#115652 and tdf#116196. Change-Id: Ief7be653a38626c9902ab5c7c453a133c2b9f882 (cherry picked from commit 0408a590311c837d5f0ab1abfb72a564a266ddac) Reviewed-on: https://gerrit.libreoffice.org/50885 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-07VCL canvas: fix clipping of gradients (related: tdf#115142)Michael Stahl
When using the presenter console, the secondary screen has a small view of the current slide, which is called a "Pane" in sdext. Clipping for this is done by sd::presenter::PresenterCanvas, which wraps the full-screen VCL canvas and has a MergeViewState() to intersect the clip region. The VCL canvas has a bug in its gradientFill() implemenation where it overrides the existing clip on the OutputDevice instead of intersecting it. This properly fixes the bug that was wrongly and badly attempted to be fixed by commit 99e373cd4c78084ded349f3e3de7b0504af2dd90. Change-Id: Id02678c2f134fe7b190866d6a6fff5b2e5e3aaff (cherry picked from commit 5d710cf7dda27e78f237211fd92418be4dd1c551) Reviewed-on: https://gerrit.libreoffice.org/50886 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-03-07tdf#115432 footnote separator position wrong (3rd attempt)Noel Grandin
My second attempt in commit dedf5e4f9000e271683dea9a0488e1b45b91176c "tdf#115432 footnote separator position wrong (2nd attempt)" managed to lose part of the change because of incorrect rebasing. Change-Id: I7b18f3e1602c617d1cb414ef0eb2ee456aeb58ee Reviewed-on: https://gerrit.libreoffice.org/50901 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit dcd95c6fff548c7ac46688244e44b95464fb297d) Reviewed-on: https://gerrit.libreoffice.org/50912
2018-03-07tdf#115432 footnote separator position wrong (2nd attempt)Noel Grandin
the first attempt (d4a8d91abd40dee7f7bd739a678a502a6e34cb59) incorrectly changed the type of a UNO property defined in a published IDL file. Change-Id: I75bc75dead0954d1faa6dfb6adab9f4c42c67cfc Reviewed-on: https://gerrit.libreoffice.org/50827 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 1163bcd5da3063e7e988ebf49d9b60dfd6f6c703) Reviewed-on: https://gerrit.libreoffice.org/50894 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-07tdf#116147 guard triggerRequestThreadAwareJan-Marek Glogowski
It didn't help putting a SolarMutexGuard into VCLXButton::ProcessWindowEvent, which was my first suspect in my own backtrace, as VCLXWindowImpl::OnProcessCallbacks releases it to process the callbacks. Since the gtk backend also guards all calls into the file picker code, I think it's save to do the same for the Windows picker. I have no idea where it is actually released again... Change-Id: I3ab3b47904dc3d0033739a82f7afd91e6e80403d Reviewed-on: https://gerrit.libreoffice.org/50783 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 3e38b81a65ced47595e9760bdc622d9434b72cc0) Reviewed-on: https://gerrit.libreoffice.org/50796 Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-07libxml2: upgrade to release 2.9.8Michael Stahl
Change-Id: Ic6802c16b740f6aee59ae2f74b7edcd37461f1f3 Reviewed-on: https://gerrit.libreoffice.org/50835 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit f775b5427bf085577feb5badb762156283d76ae5) Reviewed-on: https://gerrit.libreoffice.org/50841 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-07tdf#91680 Reserve space in margin for comments only if there are commentsGabor Kelemen
Change-Id: Ida08737cf537d85a94a72572e8cbc7e2bfad9333 Reviewed-on: https://gerrit.libreoffice.org/50505 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> (cherry picked from commit c77e01d63b4bd4805c4a499e4e0cab917d0eb403) Reviewed-on: https://gerrit.libreoffice.org/50803
2018-03-07Resolves: tdf#113805 insert special character fails in insert footnote...Caolán McNamara
etc. dialogs i.e. since commit 710a39414569995bd5a8631a948c939dc73bcef9 Date: Thu May 11 13:27:38 2017 +0530 GSoC: Glyph View and Recent Characters Control in Special Characters dialog Change-Id: Ia55f3fefe7c14327cff2e996ab0038dc52f9b017 it inserts into the document, extend the fix of commit 4020945651b4f3c636980e2103db440b5c55459c Author: Daniel <danielfaleirosilva@gmail.com> Date: Sun Sep 24 17:55:19 2017 -0300 tdf#111739 fix Selecting a custom character as a bullet symbol insertion to do the old thing that existing code depends on if this is not an "insert" dialog, and bubble that setting around from the callers Change-Id: Id8acf16955d0167beffae43e3b201e500ee7a929 Reviewed-on: https://gerrit.libreoffice.org/50781 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-on: https://gerrit.libreoffice.org/50799 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-07tdf#115353 Status bar: no cache in settextTamas Bunth
Change-Id: I6c1312bbba553be738e23cee0c76d589c809dff8 Reviewed-on: https://gerrit.libreoffice.org/50584 Reviewed-by: Tamás Bunth <btomi96@gmail.com> Tested-by: Tamás Bunth <btomi96@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/50743 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-07Resolves: tdf#115746 alt+f used twice in the writer menubarCaolán McNamara
Change-Id: I7d1589dbb51072aa328d91c0edee410fc69f2fe8 Reviewed-on: https://gerrit.libreoffice.org/50592 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-07tdf#115429 xmloff: ODF import: fix handling of unknown attributesMichael Stahl
... in SvXMLLegacyToFastDocHandler::startElement(), so that it does not create invalid "-1" tokens that end up stored as empty-string attribute names in SvXMLAttrCollection and ultimately exported as invalid XML. One surprising aspect is that the maNamespaceURL in struct UnknownAttribute stores the namespace prefix in the libreoffice-5-4 branch, as it lacks commit bb59a80ee6000d3922fa95262f67e291fd9d8ee2. The attributes are read and converted again in SvXMLImportContext::startUnknownElement(). Change-Id: Id081c677286a77ec50d9884cdbd9135cf4f6e5b6 Reviewed-on: https://gerrit.libreoffice.org/50589 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-06forcepoint #18 sw: fix condition for detecting section-in-table splitsMichael Stahl
The problem with the bugdoc is that SwFrame::GetNextSctLeaf() creates a follow frame for a section in a table, and puts it outside the table, below the page's body frame, while moving text frames that have the mbInfTab flag set into the follow frame. Checking for CanContainSplitSection() at this point doesn't make sense to me: if it's not allowed to split the section, we can't just split it anyway and put the follow outside the table. Just removing it fails in testTableInNestedSection() but it turns out that the problem there is that the mbInfTab flag is set on a outermost SwTabFrame itself, so we need to check the parent's flag instead to check if this frame needs to go into a cell. (regression from 652556ec3e9218655a67b4c4de4e26fbe81855de) Change-Id: I79663391fb1b2cb10f008676feb01a2607cfb33d Reviewed-on: https://gerrit.libreoffice.org/50804 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com> (cherry picked from commit 054be0850ed7574473452ed965001504caf0b5e2) Reviewed-on: https://gerrit.libreoffice.org/50821 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-06tdf#116171: Tunnel arbitrary rtl_TextEncoding from sc to sdbc:dbase connectionStephan Bergmann
...including those that have no corresponding textual IANA character set name representation, like RTL_TEXTENCODING_MS_950 which is apparently used in some DBase files. In the past, if eCharSet was RTL_TEXTENCODING_DONTKNOW in lcl_getDBaseConnection it was sent as an empty string CharSet property, which the receiving OConnection::construct translated back to else m_nTextEncoding = RTL_TEXTENCODING_DONTKNOW; so the net effect remains the same for that special case. Change-Id: I84eec8a93d000752b3c429976c58721ea9ea32a4 Reviewed-on: https://gerrit.libreoffice.org/50772 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 5ad62544bce42396faaae2bc79c7517af6ff085b) Reviewed-on: https://gerrit.libreoffice.org/50780 Reviewed-by: Eike Rathke <erack@redhat.com>
2018-03-05Update the reference rdbs to libreoffice-5-4-0Stephan Bergmann
LD_LIBRARY_PATH=.../master/instdir/program \ .../master/workdir/LinkTarget/Executable/unoidl-read --published \ .../libreoffice-5-4-0/instdir/program/types.rdb \ >.../master/udkapi/type_reference/udkapi.idl * no changes LD_LIBRARY_PATH=.../master/instdir/program \ .../master/workdir/LinkTarget/Executable/unoidl-read --published \ .../libreoffice-5-4-0/instdir/program/types.rdb \ .../libreoffice-5-4-0/instdir/program/types/offapi.rdb \ >.../master/offapi/type_reference/offapi.idl * plus manual fixup for now by re-applying offapi/type_reference/offapi.idl part of 00657aef09d854c74fb426a935a3e8b1fc390bb0 "migrate to boost::gettext" Change-Id: Iecebe43043ee2518a371b60795737436bbcb0941 (cherry picked from commit bc6f3c0fe95f9162fb14dc540fa2b4bc81af32bf) Reviewed-on: https://gerrit.libreoffice.org/50643 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-05Resolves: tdf#114675 return new EditPaM of insert position from SvxReadXML()Eike Rathke
Change-Id: I77027d74a0addaafaf19e2c2a8e9759d560951eb (cherry picked from commit a44e62b82c7598471da9a5254953067613806337) Reviewed-on: https://gerrit.libreoffice.org/50646 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-04Related tdf#116171: don't try to convert empty value in timestampJulien Nabet
Assert retrieved: warn:tools.datetime:3915:3915:tools/source/datetime/tdate.cxx:109: Date::setDateFromDMY - sure about 0 year? It's not in the calendar. soffice.bin: /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:62: sal_Int32 {anonymous}::ImpYearToDays(sal_Int16): Assertion `nYear != 0' failed. Thread 1 "soffice.bin" received signal SIGABRT, Aborted. __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 51 ../sysdeps/unix/sysv/linux/raise.c: Aucun fichier ou dossier de ce type. (gdb) bt 0 0x00007ffff73a26a0 in __GI_raise (sig=sig@entry=6) at ../sysdeps/unix/sysv/linux/raise.c:51 1 0x00007ffff73a3cf7 in __GI_abort () at abort.c:90 2 0x00007ffff739afca in __assert_fail_base (fmt=0x7ffff74eb890 "%s%s%s:%u: %s%sAssertion `%s' failed. %n", assertion=assertion@entry=0x7fffed7d43a4 "nYear != 0", file=file@entry=0x7fffed7d4368 "/home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx", line=line@entry=62, function=function@entry=0x7fffed7d4720 <(anonymous namespace)::ImpYearToDays(short)::__PRETTY_FUNCTION__> "sal_Int32 {anonymous}::ImpYearToDays(sal_Int16)") at assert.c:92 3 0x00007ffff739b042 in __GI___assert_fail (assertion=0x7fffed7d43a4 "nYear != 0", file=0x7fffed7d4368 "/home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx", line=62, function=0x7fffed7d4720 <(anonymous namespace)::ImpYearToDays(short)::__PRETTY_FUNCTION__> "sal_Int32 {anonymous}::ImpYearToDays(sal_Int16)") at assert.c:101 4 0x00007fffed75e7e2 in (anonymous namespace)::ImpYearToDays(sal_Int16) (nYear=0) at /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:62 5 0x00007fffed75eeb5 in Date::DateToDays(unsigned short, unsigned short, short) (nDay=0, nMonth=0, nYear=0) at /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:156 6 0x00007fffed75ee6d in Date::GetAsNormalizedDays() const (this=0x7fffffff0318) at /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:149 7 0x00007fffed760342 in operator-(Date const&, Date const&) (rDate1=0-0-0, rDate2=1899-12-30) at /home/julien/lo/libreoffice/tools/source/datetime/tdate.cxx:609 8 0x00007fffc7e8b705 in ScDatabaseDocUtil::PutData(ScDocument*, short, int, short, com::sun::star::uno::Reference<com::sun::star::sdbc::XRow> const&, long, long, bool, ScDatabaseDocUtil::StrData*) (pDoc=0x55555794c920, nCol=14, nRow=1, nTab=0, xRow= uno::Reference to (dbaccess::ORowSet *) 0x555557b5db08, nRowPos=15, nType=93, bCurrency=false, pStrData=0x7fffffff04b0) at /home/julien/lo/libreoffice/sc/source/core/data/dbdocutl.cxx:127 9 0x00007fffc892e963 in ScDocShell::DBaseImport(rtl::OUString const&, unsigned short, std::__debug::map<short, ScColWidthParam, std::less<short>, std::allocator<std::pair<short const, ScColWidthParam> > >&, ScFlatBoolRowSegments&) (this= 0x55555794c8c0, rFullFileName="/home/julien/lo/bugs/116171_dbffoxpro/addresses.dbf", eCharSet=63, aColWidthParam=std::__debug::map with 14 elements = {...}, rRowHeightsRecalc=...) at /home/julien/lo/libreoffice/sc/source/ui/docshell/docsh8.cxx:413 Change-Id: I240ddd435c148360dc9a874913596b4844d726dc Reviewed-on: https://gerrit.libreoffice.org/50732 Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit a77b493392ecdfe2e58bb0fcfa7363a8583dffe4) Reviewed-on: https://gerrit.libreoffice.org/50745 Reviewed-by: Lionel Elie Mamane <lionel@mamane.lu>
2018-03-03Updated coreYousuf Philips
Project: dictionaries eaeb462d78121c7b9ba7c9e6c6de94c5781c9fbd Update arabic dictionary to version 3.5 (2014-11-08) Files extracted from http://sourceforge.net/projects/ayaspell/files/dict_ar-3.5.2014-11-08.oxt/download Change-Id: Ic3ffb861a253f680e96e437b5dc2f3da4e392a21 Reviewed-on: https://gerrit.libreoffice.org/49028 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 476ebd97bbfdcf59f00cd832647b880ddfdfb252) Reviewed-on: https://gerrit.libreoffice.org/50675
2018-03-02forcepoint #16: fix heap-use-after-freeMiklos Vajna
PDFDocument::Tokenize() in the aKeyword == "obj" case allocates a PDFObjectElement, stores it as an owning pointer inside rElements, and also stores two non-owning references to it in m_aOffsetObjects and m_aIDObjects. So make sure those 2 other containers are also cleared then elements go away. LO_TRACE="valgrind" bin/run pdfverify <sample> doesn't report errors anymore after the fix. Change-Id: Ie103de3e24a1080257a79e53b994e8536a9597bc Reviewed-on: https://gerrit.libreoffice.org/50631 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Michael Stahl <mstahl@redhat.com>
2018-03-02forcepoint #17 nTextBreak is an index into pKernArray of len rInf.GetLen()Caolán McNamara
Change-Id: I3afeaf987cc5e75362560165fea7230904530933 Reviewed-on: https://gerrit.libreoffice.org/50629 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02Resolves: tdf#115951 wrong entry selected for numbering posCaolán McNamara
Change-Id: I4e317abb3cfceee2de4826f967a27d14fb3878ef Reviewed-on: https://gerrit.libreoffice.org/50356 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-02tdf#116018 fix mising shapes in .pub importDavid Tardon
Change-Id: I58447c13bf693ef0bf92922599f4318598f8b288 Reviewed-on: https://gerrit.libreoffice.org/50524 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-02ofz#6656 -1 isn't a good flag for all elements filledCaolán McNamara
Change-Id: I163de8fd943859fbf986da0928f3e3552d063a09 Reviewed-on: https://gerrit.libreoffice.org/50625 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-03-02forcepoint #14 check to see if we incremented at allCaolán McNamara
Change-Id: Ia4670adbddcc8501cf522be296b3061a3529f880 Reviewed-on: https://gerrit.libreoffice.org/50606 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-03-01tdf#115297: alternative fix for displaying 1bit imagesVasily Melenchuk
Previous fixes for 1bit monochrome / paletted images produced some regressions, so here is attempt to fix problem at the root. Partially reverted 66dbd4da3afcadb1393daf9be9cecff71b86509a and fixed in a different way without tdf#115297, tdf#114726 and related. Change-Id: I6849ed5ac41770ba905c930065c80e58509dba2e Reviewed-on: https://gerrit.libreoffice.org/50454 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 25cd843664919974f0d21ca7a0b02cc43e9eeabb) Reviewed-on: https://gerrit.libreoffice.org/50540 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-03-01test: add assertXPathNSDef()Miklos Vajna
Partial backport of Miklos' master commit f8da775795052ad2eb879970c115d2e2a2fe8c81 without the EPUB changes. Change-Id: Ic9dd105249a59200dba03bb30eda350a95aff263 Reviewed-on: https://gerrit.libreoffice.org/50588 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-01tdf#116102 Revert "tdf#109080 First page header/footer ODF (2/2)"Michael Stahl
Revert this on the libreoffice-6-0 branch; the patch to import the element by its new name was only added in LO 5.3.6, so probably 2 release cycles is too short for a change like this. This revert delays the change until LO 6.1. This reverts commit f1481007077723f7676f517db8df1363d070d459. Change-Id: Ib195cbbf0dd341db203608f259d42ca71e7e5939 Reviewed-on: https://gerrit.libreoffice.org/50562 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-03-01tdf#116072 Extend MidLetter in Hungarian word breakingLászló Németh
Now ”, (, ), ], ?, ! are MidLetter characters to handle (1)-ben, "ember(ek)ről", "„Tisza”-ban" etc. forms as words for better Hungarian spell checking. Change-Id: I47882e73af08531d14d555ced5dd4c98403686ec Reviewed-on: https://gerrit.libreoffice.org/50473 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 3cc58a5904604f0f2e9977a9508bab02518122ad) Reviewed-on: https://gerrit.libreoffice.org/50554 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-03-01Updated coreLászló Németh
Project: dictionaries 79b662808e98cda02dc4326f32cfce28fcbba7b8 tdf#116072 Improve Hungarian spell checking by better word breaking and ignore the special characters of the word forms, or break at the special character and check the word stem and affix (with a starting hyphen) separately: vár(hat)nak -> várhatnak „Tisza”-ban -> Tisza, -ban [Note: this removes false alarms in Writer, but extra grammar checking can help to check matching of the stem and the affix.] Change-Id: Icb810ccc1ecb84fea3ee5093100e2fdc874edb6c Reviewed-on: https://gerrit.libreoffice.org/50475 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 2b7711678410bc531e9d07b4d6f85bfb85f2116a) Reviewed-on: https://gerrit.libreoffice.org/50552 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com>
2018-02-28tdf#115429: declare fill-ruleJulien Nabet
Change-Id: I5eb93d08b1dd56db19038132b560ddf7ba174bc6 Reviewed-on: https://gerrit.libreoffice.org/49242 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> (cherry picked from commit 5222383c29d190218108c7c9e362a5a55af73a2f) Reviewed-on: https://gerrit.libreoffice.org/50480
2018-02-28tdf#115795 Solve wrong redirect behavior of "Get Online Help"Franklin Weng
When under locale zh-TW, Help > Get Online Help would use only "zh" as the parameter of LOLang and sent it to hub.libreoffice.org, which would redirect to Simplified Chinese forum instead of zh_TW ask.libreoffice.org forum. After discussing with Guilhem he refactored the behavior of the Hub, use LOlocale instead of LOLang, and keep LOLang for backward compatibility. The LibreOffice sent LOlocale instead to avoid this problem happening again. Change-Id: Ia9348cff88723210f693e65260bb987826a3f3ea Reviewed-on: https://gerrit.libreoffice.org/50503 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 7c1f11985c0b42981cf8600840fb87521ce5ad33) Reviewed-on: https://gerrit.libreoffice.org/50511
2018-02-28tdf#79546: Make sure temp copy of inserted media file keeps the same extensionTor Lillqvist
Inserting videos into Impress presentations with 'Insert>Audio or Video' did not work at all for me. This helps. It seems that the AVFoundation APIs are sadly rather picky about file name extensions. Why we need to make a temporary copy of the media file (which after all can be rather large) at all, when inserting it in a slide, I don't understand. But I am not going to dig into that now. Change-Id: I43fcfb5bb3ef0a2c0f8979ac3e7c458a84f180a1 Reviewed-on: https://gerrit.libreoffice.org/50390 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 1aa5a3874bf716acfbded2a09319dce5d4ce8c0d) Reviewed-on: https://gerrit.libreoffice.org/50440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-28tdf#115715 RTF import: ignore zero para indents in styles without parentsMiklos Vajna
The only reason the DOCX equivalent of the bugdoc was imported correctly is that these default zero margins are simply missing from the DOCX markup, suggesting Word ignores them. We now do the same, this way the stripped down document's 3 paragraphs all have different margins as expected. (Also rework the testTdf112211_2 testcase to test the original problem better: I verified that the layout is unchanged before/after this patch.) (cherry picked from commit 59363e639b67a8acbd6da240635de47921b2c955) Change-Id: I88d56c27c19e070e983c3392f99bca96597cd56e Reviewed-on: https://gerrit.libreoffice.org/50435 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-02-28Merge upstream fixes into solenv/flatpak-manifest.inStephan Bergmann
* <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ f5d97291e302d98c217c955c52b255795d4d4cad> "Bump runtime-version to org.gnome.Platform 3.26" * <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ 7d69e505165d4bbf5fa0b34b5fb2cbff9dfaf9bd> "For now, bundle gst-libav to be able to play mp4 videos in impress" Change-Id: I1924d84be7fe577e302b0c1b8c7e2971e8583d73 (cherry picked from commit 756c9f2317605e39d9cb058e650962acd2d81739) Reviewed-on: https://gerrit.libreoffice.org/50492 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-28tdf#115873 sd navigator: adapt IsEqualToDoc() to Fill() furtherMiklos Vajna
SdPageObjsTLB::Fill() populates the navigator tree list box, SdPageObjsTLB::IsEqualToDoc() determintes if it has to be refreshed or not. Commit f3c68cdf8f6a0273c62b493552f78af0138a44e8 (tdf#115873 sd navigator: allow selecting but not focusing on objects, 2018-02-21) already brought IsEqualToDoc() closer to Fill() with using the same iteration mode for the SdrObjects, but that's not enough. Fill() uses flat iteration, then checks for group shapes explicitly and visits them recursively. Change IsEqualToDoc() to do the same, this way selecting "Rectangle 3" in the testcase won't result in a jump back to "Slide 1" (as an effect of IsEqualToDoc() returning false for an up to date tree list box). Change-Id: If2543cbc282af06ba43d4804e7ed455c8b9828cd Reviewed-on: https://gerrit.libreoffice.org/50234 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit 1f159a4df7dcf9c4b1a35d16aee2303b8fa34b27) Reviewed-on: https://gerrit.libreoffice.org/50344 Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28tdf#115873 sd navigator: allow selecting but not focusing on objectsMiklos Vajna
There were also two cases here: - changing the selection with the keyboard or single-click only updated the selection in the navigator - pressing enter or double-click also selected the shape in the main window and gave the focus away Introduce a 3rd case for single-click: update the shape selection but doesn't give the focus away. This way double-click is not needed to sync navigator -> main doc selection but keyboard navigation should still work. An additional trick is to make sure that the current shell is the draw shell (and not the slide sorter) after navigation, so follow-up operations work with the selected object and not with the whole slide. Finally, a third related problem was that the selection jumped back to the item of the slide after clicking on a shape in the navigator. The reason for this was the navigator list was constantly cleared and re-filled in SdNavigatorWin::InitTreeLB(), as SdPageObjsTLB::IsEqualToDoc() returned false (even if the list was up to date) in case of shapes which had children but no name. Fix this by using the same SdrIterMode::Flat iteration mode that SdPageObjsTLB::AddShapeList() does, so the fill and the equality check of the navigator iterates the same way. Conflicts: sd/qa/unit/tiledrendering/tiledrendering.cxx (cherry picked from commit f3c68cdf8f6a0273c62b493552f78af0138a44e8) Change-Id: I0bfc3e8b49f7ef01d5797a68284616dcd2a81c5d Reviewed-on: https://gerrit.libreoffice.org/50158 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28tdf#115859 Export number format for chart seriesSzymon Kłos
Change-Id: I65d30c6b92a530eadbd6fabe87fa8bd3416fee20 Reviewed-on: https://gerrit.libreoffice.org/50395 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2018-02-28unotools: remove UseSHA1InODF12/UseBlowfishInODF12 from SvtSaveOptionsMichael Stahl
These config items and all client code were removed on the libreoffice-6-0 branch in commit 47c97efb78a574ba080e953ed219515ea71c2569 but some remnants remained in SvtSaveOptions (which had been converted to direct config access on master after libreoffice-6-0 branched). Office.Common.Save.ODF.UseSHA1InODF12 Office.Common.Save.ODF.UseBlowfishInODF12 Remove them from SvtSaveOptions too because it prints annoying warnings on every startup that the config items can't be found. Change-Id: Ia3c6dd332d556fa98236698302cf9379c9a96feb Reviewed-on: https://gerrit.libreoffice.org/50453 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-02-27set number of read bytes correctlyDavid Tardon
It was wrong if we read less than was expected. Thanks to Antti Levomäki and Christian Jalio from Forcepoint. Change-Id: I070c1731d1aace4c101fa01efed0c28734c44899 (cherry picked from commit 9534a8fe3e84bfcc7d0d2addac4dd8cd96746d99) Reviewed-on: https://gerrit.libreoffice.org/50462 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-27ofz#6576 check border param lenCaolán McNamara
Change-Id: Ie479ef953b7c0f4a30afdafa27a9be121a346562 Reviewed-on: https://gerrit.libreoffice.org/50456 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-02-27Resolves: tdf#116062 revert [fr-CH] to use previous single quote charactersEike Rathke
Even if that's not what should be used.. see sources in commit 4b938c558d004537cf73ca4319019ff64f052270 Date: Fri Feb 9 12:59:51 2018 +0100 Use angle quotation marks (Guillemets) for [*-CH], tdf#115493 related Change-Id: I733bc767ff4484c251f8624f90a5295875bf17ea (cherry picked from commit 0808618e0df0fab4479917e588c096bc8770c6c5) Reviewed-on: https://gerrit.libreoffice.org/50459 Reviewed-by: Laurent BP <laurent.balland-poirier@laposte.net> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-02-27forcepoint #10 pop empty stackCaolán McNamara
Change-Id: I96452a86187a6b03251614625445d1b18a5ee218 Reviewed-on: https://gerrit.libreoffice.org/50358 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-02-27tdf#114076: Expand ClipRange to next PixelBoundArmin Le Grand
Do this by going to basegfx::B2DRange, adding a single pixel size and using floor/ceil to go to full integer (as needed for pixels). Also need to go back to basegfx::B2DPolyPolygon for the creation of the needed MaskPrimitive2D. The general problem is that Writer is scrolling using blitting the unchanged parts, this forces this part of the scroll to pixel coordinate steps, while the ViewTransformation for paint nowadays has a sub-pixel precision. This results in an offset up to one pixel in radius. To solve this for now, we need to expand to the next outer pixel bound. Hopefully in the future we will someday be able to stay on the full available precision, but this will need a change in the repaint/scroll paradigm. Change-Id: Idb4a596bc298d1b80aab6f36ad4204afe94d54f7 Reviewed-on: https://gerrit.libreoffice.org/50369 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de> (cherry picked from commit c1230cede19ae3633e51c7ca780cb34d9dbaa20f) Reviewed-on: https://gerrit.libreoffice.org/50410 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-02-27tdf#97614 Fixing initialization code for Bluetooth and IP Server for Impress.Rostislav Kondratenko
Change-Id: Icc385fb760b8a5ff337f58dc95ba3c3f86805eaa Reviewed-on: https://gerrit.libreoffice.org/50108 Reviewed-by: Michael Stahl <mstahl@redhat.com> Tested-by: Jenkins <ci@libreoffice.org> (cherry picked from commit fb5f13671c50f7f84d654a779bc0ff07e31ce95e) Reviewed-on: https://gerrit.libreoffice.org/50413
generated by cgit (git 2.34.1) at 2024-07-01 14:00:13 +0000