summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-04-15store ptr to the original entries in SfxItemPropertyMapNoel Grandin
instead of copying them to a new data structure that is practically identical. Helps startup time since we build a ton of these when loading documents. And use o3tl::sorted_vector as a dense map data structure to reduce allocations and improve cache friendliness, since this is a build-once thing. Change-Id: I950be03b1a21c0c81c40f2677d4215f5e8e256cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114015 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15sw: avoid rel<->abs URL conversion in SwTOXAuthority::GetSourceURL()Miklos Vajna
Suggested at <https://gerrit.libreoffice.org/c/core/+/114104/2#message-5dce4cbf4bac90d4bad0726e50eb79cca0e40de9>, turns out we can clear the fragment of a relative URL without converting to an absolute one, which is less code and probably behaves better with a not yet saved document (empty base URL). Change-Id: I8cee210aada10a3e8049e5b7a6921f1be4445bb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114124 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-15sd: just use Color in these assertsXisco Fauli
if they fail, the output is much more readable since a080727522e04b8e1fc1641c892af9227d2e8dad < sd: improve output when asserting colors > Change-Id: I9f95943f35d095054ad5adaede5a8e53ce6cd69c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114138 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15fix serf dependenciesLuboš Luňák
RepositoryExternal.mk treats apr and apr_util as one external, but technically they are two, so both of it must be built for 'apr' to be ready to be used by serf. Change-Id: If00fb10a698fd926437e18ac0e4fa66b2722ebae Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114135 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-15tdf#141660 DOCX import: fix footnotes of deletionsLászló Németh
Footnotes of tracked deletions resulted exception during import. They don't need redline copying, because the anchor point (the footnote index) is already part of a redline. Note: handle also remaining unhandled w:footnote type "separationNotice", which could result shift of the footnote numbering. Regression from commit 9b39ce0e66acfe812e1d50e530dc2ccdef3e1357 (tdf#76260 DOCX import: fix slow footnote import). Change-Id: I01e06fb25aba4f97cca31b5da34f5a7a3f18a54a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114137 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-15loplugin:stringliteralvar look for assignmentsNoel Grandin
to O[U]String from char array literals, we can convert the char literals to O[U]StringLiteral and avoid a runtime allocation Change-Id: I15d8dddb2cd428b90740e39f20daf98e0941aa6d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114125 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-15sd: use hexadecimal representation for colorsXisco Fauli
Change-Id: I7fbed6f2acf7ad7f4bb30514d59521cd9fe2b42f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114136 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15Fix commentSamuel Mehrbrodt
Change-Id: Ia9af45c7e9a0805885eebc00e0540f2d69a1859b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114132 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-15sd: improve output when asserting colorsXisco Fauli
Change-Id: I1d36ec286ee3c94f37bd0f0050927177f80cbdb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114134 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-15Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 140f7c8bd3b901ee333f333c2b06c8261eae67df - Basic Toc cleanup - pt. 2 - reordering - adding missing topics Change-Id: Ie049e96f7849f2b96d56a189cdb163c089eb8fe8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113644 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 68c86864e16f72c84979f52623b731cb0307c372 - Mute l10n of embedded variables Change-Id: I699c2eb8fe0256b94dee225de056478330a2ea17 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114133 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-15ScriptForge - (SFDocuments) Fix SF_Base.OpenFormDocument()Jean-Pierre Ledure
When a Base form is: 1. opened with OpenFormDocument(), then closed 2. Opened manually in Edit mode, then closed 3. Reopened with OpenFormDocument() in normal mode - it again gets opened in Edit mode - its closure is not executed, neither by program nor manually The OpenFormDocument() method is simplified: the invoked loadComponent method may be executed even when the form is already open. It simply activates the form which is exactly the expected bahaviour. Additionally: - the opening mode is checked after the open and, if not matching the expected DesignMode argument, reset. - the alive check of a form (IsStillAlive()) does not require a database connection anymore Change-Id: I5f55e45b246867d19e514e0d820f164790dec300 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114092 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-04-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 1653fc7e7a458eea57fe1547650abc1a76a42c03 - Fix sort in Help pages + some L10n fix too Change-Id: Ib380ec77e7c5779b5008f155272f9f26a9cccac5 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114119 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-15tdf#141689 Fix crash in 'Central' moving avg functionSamuel Mehrbrodt
Change-Id: I2dc5e517d5e3ff6283c9ff66c9f32ee95d66ef45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114121 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-15Qt5 correctly focus the navigator windowJan-Marek Glogowski
Handle SalFrame::Show's bNoActivate. The missing implementation became visible with commit 001cf630f14109b4200b218161418350562713fa ("register navigator individually in each module that it exists in") Change-Id: I5edf43bdf2b0460410fdd846c7698d00299088bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114116 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-15enum class X11ShowStateJan-Marek Glogowski
Change-Id: I1e1f7f97bbb6d41f61a0ee9195cc84e0f680b741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114115 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-15vcl PDFiumLibraryTest: clean up not needed HAVE_FEATURE_PDFIUM ifdefsMiklos Vajna
This was already conditional in Module_vcl, so no need to have a duplicated check here. Which allows finally removing the HAVE_FEATURE_PDFIUM ifdef completely. New code can just call vcl::pdf::PDFiumLibrary::get() at runtime and see if the result is nullptr or not. Change-Id: I36508181865a31618e48cf7c2680d75465130dd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114108 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to a1a06717d857022304899fa8607af38b4ce57ac3 - Fix sort command in Help page (part) Change-Id: I2c47a3db2b81250d92bed88a13a8869012eeef76 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114114 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-15Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to 400078d391b11c921d1069e23e357b12595c0307 - Fix order of rendering for four Bessel functions in Calc help file ../01/04060115.xhp. Also removed a couple of unnecessary spaces at the beginning of sentences. Change-Id: Iecb5cd88887b6eb304114f40c843f094a27976c3 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114005 Tested-by: Jenkins Tested-by: Olivier Hallot <olivier.hallot@libreoffice.org> Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-15Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 26e5265ade24d7eeeaf7d120e0dbcb4cbc598fed - Fix sort order of Calc functions Change-Id: I8237b0d52b8b0f29fc35196d34648ed7b51669d1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114113 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14update serf to 1.3.9Luboš Luňák
Its build system has switches to scons, so build the library using gbuild. Change-Id: I45b784e65e4987c25baf3fa1477816c744663bf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114107 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-14Fix problems with LibreOffice document generation (local and portal)Hossein
* Fixed problems with LibreOffice local document generation script (mkdocs.sh) by interpreting backslash escapes when generating module links using "echo -e" and using double quotes around Markdown generated text. The result is placed at docs/ folder. * Fixed problems with LibreOffice portal document generation script (mkdocs_portal.sh and mkonedoc.sh) by doing above fixes and also adding code from the local document generation script. The result is placed at https://docs.libreoffice.org/ * Only the README.md files are processed, and not README* or readme.txt* * Fixed redmine #3515 "Remove non-necessary subfolders from docs.libreoffice.org" by excluding these 10 folders: "autom4te.cache dictionaries docs helpcompiler helpcontent2 include instdir lo translations workdir" Change-Id: Id230872b8583a575bfeb6fc77cc9f96d5982908f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113773 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2021-04-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 4eb5af3af3d74494e4303d6f695638604563411a - Add sort attribute in page Change-Id: I9e34484ac411e07bcdeb67f4602ee58d7860150a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114112 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14disable Skia if --disable -guiLuboš Luňák
There are link errors because of SkiaZone, and Skia is not even linked in for non-GUI. Change-Id: I942dbf79c2012b5dfd4259a7c4ecc680500174b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114111 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 81014e5cb46166183723ae911f6968e56b403107 - Fix sort command in Help pages After the introduction of the headings h1 ... h6 in the Help pages the sort command broke. It relied only in the <paragraph> tag for sorting, usually the first paragraph in the section. The patch extend the DTD to handle the new descendant="" attribute to select which tag to sort in the Help page Default is <paragraph> for backward compatibility. Pages with <sort> must be revisited. Change-Id: I3c6f243369429ed7824a68b11757dc15f4555c0f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114110 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to d5c6af3d35bef4a734dd38725f069b393d02379d - Fix broken link Change-Id: I7ba4bb85586d7207e8c6f83006b172662344c118 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114109 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14loplugin:unusedmethodsNoel Grandin
Change-Id: I9c1c6f27e35a66d8e3623c3ebb1618dceda60e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14static const char[] -> OUStringLiteralMike Kaganski
Change-Id: I77fcd3260fd0f3d4c1a05624a9e9ea1dfad3792f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114004 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-14IsInput is equal to IsInterrupt, so drop itJan-Marek Glogowski
Nobody is really interested in the reason for the interrupt. And since we already checked IsInterrupt() to get in this branch, mbFormatContentOnInterrupt is always true. Also because we want to finish layouting the current page, especially on Idle, according to commit aa355eeec8c5526c68b17d15192aef94062607d7 ("#i42586# ... - finish format of current page on interrupt."), so must ignore many (all?) IsInterrupt() checks. Change-Id: Ic1d576130a605348a86115ebeb1f016d8163c6f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114095 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-14tdf#115464 Added "prevent input" in export dialogAditya Pratap Singh
Change-Id: Ib3e863e4318a3877a36b8ae47dc9b09f3c4b8918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113422 Tested-by: Jenkins Reviewed-by: Aditya, Pratap Singh <adityapratapsingh51@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-14sw bibliography, refer to a page: also de-duplicate relative URLsMiklos Vajna
Relative URLs have to be converted to absolute ones, otherwise INetURLObject can't clear the mark (fragment) part of it. Then convert back, so the document remains portable. Change-Id: Idd9a3de045784a0430c20b689b2b3344b1e92cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114104 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-14Fix typosAndrea Gelmini
Change-Id: I93008d534b9b677ed131e4302e5df4391db4cafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114090 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-14SkBlendMode::kDifference causes AMD/Linux driver instabilityLuboš Luňák
Change-Id: I70de779c20185ac6efe8da7ad197c5e4c68a8d23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114091 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-14Revert "update Skia to chrome/m91" (tdf#141680)Luboš Luňák
The m91 snapshot seems to cause a number of Vulkan problems. My commit already worked around one, but there are apparently others, such as very slow startup, or a failed Skia assertion triggered by VCL Skia's copyArea(). This reverts commit 09d850e46903a528d4b08d3fdf03c3964d79fbc5. Change-Id: I4f1832ba76db15cab8eccbe115d21c989da3c841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114089 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-14sw: layout dump: sorted_objs of SwPageFrameMichael Stahl
Change-Id: I2bf8493744d054c513ab9b65136b6e29e9aa07f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114065 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-14Use mpStream consistentlyMike Kaganski
I had to check above that pStream indeed points to same object as mpStream, which is dereferenced in all other cases. Change-Id: Ib31fad9c163ae828afbcf657b0922bae1b1ed16a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114002 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-14Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 49d33b45fd6c0d6b4c514a95bb5aceab37199abf - Typo in sf_forms Change-Id: I8a70e9b81713a049f1e3ea96fd1dd8faefb0c615 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114003 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-04-14ofz#33235 Integer-overflowCaolán McNamara
Change-Id: I7a717a5bfdd58f22de3dcd61fe4aad67d1463a42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14static_cast after dynamic_castNoel Grandin
Change-Id: I77cbf11e26c91bf634d708117eb801c8d8057050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14reduce allocation in TextListStyle some moreNoel Grandin
These child objects do not need to use shared_ptr, since no-one else holds a pointer to them, and we always allocate them, so just allocate them inline the parent object. Change-Id: I96ab644a3a2f1e962df02d590c6a9944ef4a9ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14avoid creating an SfxItemSet hereNoel Grandin
Change-Id: I9bd65c5938c5a500acc026a95de186fdae33e2fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14reduce allocation in TextListStyleNoel Grandin
Change-Id: Id1bad0bf39b03bc6d4004c50c0f35b60d6753aa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14sw define bibliography entry dialog: set browse button visibility based on typeMiklos Vajna
Show the browse button exactly when the biblio entry type is a local file. This needs to always weld the browse button, just not showing it initially in the non-local-file-type case. Change-Id: I8965bb87d0d7c362695b27d5278c0e7b03158e73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114094 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-14add pitch to the patternCaolán McNamara
Change-Id: Ic32527feabb0405f17bd59779cf19553afaa1e7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14tdf#140639 cache FcPattern for font optionsCaolán McNamara
Change-Id: Ibb1b1e06630e505924e05ea4b5b454e58738d743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14Qt add additional info to ToolkitNameJan-Marek Glogowski
Adds the used font backend and the QPA platform name, so we don't need to ask / verify all time (and less chance of wrong info). Examples: - qt5 (qfont+xcb) => QFont text rendering + X11 backend - kf5 (cairo+wayland) => Cairo text rendering + Wayland backend Change-Id: I1102dd6d83b0ed48318ac5c31c8ca09d4fdd73eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113945 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5ba538ce7121b2733824ff71f0e553d004429247 - Refactor somedatabase Help files put in th right folder Change-Id: I4e396ce184abc6cc7f9d51fc283a8cba62fd9c82 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114087 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to f1c3329df60dd8e0d5fb495a1e2f12790eb7a829 - tdf#141474 InputBox Basic method signature Change-Id: Ie7e5a956e7871d964fb55d81ce639cff0f64642d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113643 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 2280caa5f5cf639b5c9f71797dfab0749fa29639 - Create SFDocuments.Form help page Change-Id: I7726950a477e94b91050180db318752e6a98d434 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113993 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14use original FontAttributes instead of an intermediate FastPrintFontInfoCaolán McNamara
Change-Id: Id8f8ea9b9d144d5bf9eace81ecc07e6b5dce6d41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-07 10:52:21 +0000