summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-04-14loplugin:unusedmethodsNoel Grandin
Change-Id: I9c1c6f27e35a66d8e3623c3ebb1618dceda60e24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113988 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14static const char[] -> OUStringLiteralMike Kaganski
Change-Id: I77fcd3260fd0f3d4c1a05624a9e9ea1dfad3792f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114004 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-14IsInput is equal to IsInterrupt, so drop itJan-Marek Glogowski
Nobody is really interested in the reason for the interrupt. And since we already checked IsInterrupt() to get in this branch, mbFormatContentOnInterrupt is always true. Also because we want to finish layouting the current page, especially on Idle, according to commit aa355eeec8c5526c68b17d15192aef94062607d7 ("#i42586# ... - finish format of current page on interrupt."), so must ignore many (all?) IsInterrupt() checks. Change-Id: Ic1d576130a605348a86115ebeb1f016d8163c6f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114095 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-14tdf#115464 Added "prevent input" in export dialogAditya Pratap Singh
Change-Id: Ib3e863e4318a3877a36b8ae47dc9b09f3c4b8918 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113422 Tested-by: Jenkins Reviewed-by: Aditya, Pratap Singh <adityapratapsingh51@gmail.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-14sw bibliography, refer to a page: also de-duplicate relative URLsMiklos Vajna
Relative URLs have to be converted to absolute ones, otherwise INetURLObject can't clear the mark (fragment) part of it. Then convert back, so the document remains portable. Change-Id: Idd9a3de045784a0430c20b689b2b3344b1e92cb5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114104 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-14Fix typosAndrea Gelmini
Change-Id: I93008d534b9b677ed131e4302e5df4391db4cafd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114090 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-14SkBlendMode::kDifference causes AMD/Linux driver instabilityLuboš Luňák
Change-Id: I70de779c20185ac6efe8da7ad197c5e4c68a8d23 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114091 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-14Revert "update Skia to chrome/m91" (tdf#141680)Luboš Luňák
The m91 snapshot seems to cause a number of Vulkan problems. My commit already worked around one, but there are apparently others, such as very slow startup, or a failed Skia assertion triggered by VCL Skia's copyArea(). This reverts commit 09d850e46903a528d4b08d3fdf03c3964d79fbc5. Change-Id: I4f1832ba76db15cab8eccbe115d21c989da3c841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114089 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-14sw: layout dump: sorted_objs of SwPageFrameMichael Stahl
Change-Id: I2bf8493744d054c513ab9b65136b6e29e9aa07f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114065 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-14Use mpStream consistentlyMike Kaganski
I had to check above that pStream indeed points to same object as mpStream, which is dereferenced in all other cases. Change-Id: Ib31fad9c163ae828afbcf657b0922bae1b1ed16a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114002 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-14Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 49d33b45fd6c0d6b4c514a95bb5aceab37199abf - Typo in sf_forms Change-Id: I8a70e9b81713a049f1e3ea96fd1dd8faefb0c615 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114003 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-04-14ofz#33235 Integer-overflowCaolán McNamara
Change-Id: I7a717a5bfdd58f22de3dcd61fe4aad67d1463a42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14static_cast after dynamic_castNoel Grandin
Change-Id: I77cbf11e26c91bf634d708117eb801c8d8057050 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114098 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14reduce allocation in TextListStyle some moreNoel Grandin
These child objects do not need to use shared_ptr, since no-one else holds a pointer to them, and we always allocate them, so just allocate them inline the parent object. Change-Id: I96ab644a3a2f1e962df02d590c6a9944ef4a9ce3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114085 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14avoid creating an SfxItemSet hereNoel Grandin
Change-Id: I9bd65c5938c5a500acc026a95de186fdae33e2fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114093 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14reduce allocation in TextListStyleNoel Grandin
Change-Id: Id1bad0bf39b03bc6d4004c50c0f35b60d6753aa8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114084 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-14sw define bibliography entry dialog: set browse button visibility based on typeMiklos Vajna
Show the browse button exactly when the biblio entry type is a local file. This needs to always weld the browse button, just not showing it initially in the non-local-file-type case. Change-Id: I8965bb87d0d7c362695b27d5278c0e7b03158e73 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114094 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-14add pitch to the patternCaolán McNamara
Change-Id: Ic32527feabb0405f17bd59779cf19553afaa1e7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114086 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14tdf#140639 cache FcPattern for font optionsCaolán McNamara
Change-Id: Ibb1b1e06630e505924e05ea4b5b454e58738d743 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114083 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14Qt add additional info to ToolkitNameJan-Marek Glogowski
Adds the used font backend and the QPA platform name, so we don't need to ask / verify all time (and less chance of wrong info). Examples: - qt5 (qfont+xcb) => QFont text rendering + X11 backend - kf5 (cairo+wayland) => Cairo text rendering + Wayland backend Change-Id: I1102dd6d83b0ed48318ac5c31c8ca09d4fdd73eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113945 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2021-04-14Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5ba538ce7121b2733824ff71f0e553d004429247 - Refactor somedatabase Help files put in th right folder Change-Id: I4e396ce184abc6cc7f9d51fc283a8cba62fd9c82 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114087 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to f1c3329df60dd8e0d5fb495a1e2f12790eb7a829 - tdf#141474 InputBox Basic method signature Change-Id: Ie7e5a956e7871d964fb55d81ce639cff0f64642d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113643 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to 2280caa5f5cf639b5c9f71797dfab0749fa29639 - Create SFDocuments.Form help page Change-Id: I7726950a477e94b91050180db318752e6a98d434 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113993 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14use original FontAttributes instead of an intermediate FastPrintFontInfoCaolán McNamara
Change-Id: Id8f8ea9b9d144d5bf9eace81ecc07e6b5dce6d41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114077 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14getFontOptions is always called with pitch of PITCH_DONTKNOWCaolán McNamara
getFontOptions is called from only one location and there the pitch value is left at its default PITCH_DONTKNOW which is suspicious but that's the way it currently is Change-Id: I7e4a487b800a0111133a0edd472731ffa5122177 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114076 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14tdf#100961 rtf import: fldlock is FIXEDFLDJustin Luth
This depends on another fix in this bug report for exporting. I'm not sure why I even bother trying to work on RTF stuff. I'm not really into black magic. Change-Id: If596cae011a261a80ca13962932bf25561c0f63f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114062 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-04-14sw define bibliography entry dialog: recognize relative file URLsMiklos Vajna
So that in case a file:// document has relative URLs, we show the type as local file (with a file picker), not as "www document". Change-Id: Id7a5d181dc6b2b9e6165d83bd294d7350bd4ce24 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114078 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-14lok: sc: Desktop: Function wizard isn't properly asyncMarco Cecchetti
Open another view of the same spreadsheet when the function dialog is open. Note how the document in the new view can't be edited. This patch avoids to have a view locked after creation when in an other view the formula dialog is open. See also commit 009d275. Change-Id: Ie51f414c4ad83ef20526d10be3251e174158096c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98823 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114060 Tested-by: Jenkins Reviewed-by: Marco Cecchetti <marco.cecchetti@collabora.com>
2021-04-14tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorAhmet Hakan Çelik
Change-Id: Ie7507e6beb470708bb4e52a7b926433043b80d85 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112133 Tested-by: Jenkins Reviewed-by: John Turpish <jbt@gmx.us> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-04-14android: Don't store whether spreadsheet in LibreOfficeMainActivityMichael Weghorn
LOKitTileProvider has that information, so query it instead and don't duplicate information in LibreOfficeMainActivity. Change-Id: I233986d6e94e5676464cb3399303efd545e33d32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114057 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2021-04-14hintstyle is unusedCaolán McNamara
left behind after... commit 561a02ec72cf963d7cd59cfb9a183c1032f0861b Date: Thu Jun 15 15:28:46 2017 +0200 loplugin:unusedfields in vcl part3 Change-Id: Iaf76a02a6f85e5bb3e72d0f4804d3cf4601dca64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114068 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-14Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to a26e51cc4e5af7eae340fcf20e31e991239def2d - tdf#141474 MsgBox function signature Change-Id: I4a9a49a3af3379f96ae95c19135a44e7ae5fd29a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113998 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2021-04-14Early return from ScInputWindow::setPosSizePixel() if no-opTor Lillqvist
This seems to fix https://github.com/CollaboraOnline/online/issues/1988 Change-Id: I5fd826647ce85b7ad2d93085fb0c2fa9db69e745 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114056 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114070 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-14tdf#126678 - Consider "Include formats" option during sortAndreas Heinisch
Change-Id: Ib972ad6c5042bde6b0c79bf10bace6baab1e935e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/111234 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de>
2021-04-14tdf#141556 Fix 100% CPU usage in Writer idle loopLuke Deller
Do not interrupt the idle layout processing unnecessarily, because if it is continually interrupted before making enough progress then it will keep resuming at the same page, never finishing, constantly using CPU. This is achieved with two changes: - Revert "tdf#123583 use TaskStopwatch for Writer Idle loop" (commit 383032c50a3e3354f04200ce984a47ab9d2c5c67) which introduced a stopwatch timer to interrupt idle processing every 50ms. This reversion restores the previous behaviour where idle processing is interrupted only when there is an input event. - Filter out TIMER events so that they do not interrupt the idle loop; this fixes both tdf#123583 and tdf#141556 Conflicts: sw/source/core/inc/layact.hxx sw/source/core/layout/layact.cxx Change-Id: Ic989631e5f32199209d64b66b72059253fc0167a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113825 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-14vcl VectorGraphicSearchTest: avoid HAVE_FEATURE_PDFIUM ifdefMiklos Vajna
This is entirely specific to pdfium, so don't build it in the no-pdfium case. Towards completely avoiding the HAVE_FEATURE_PDFIUM ifdef forest. Change-Id: I127fce64d4ba1fffe529daf927311ed4d42d745f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114067 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-13tdf#124176 Use pragma once in vclsarynasser
Change-Id: I30834d8686763d8972cb1579341eefb43ae300c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114052 Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2021-04-13tdf#134736 RemoveTransparenciesFromMetaFile ruins PDFExtOutDevData groupsCaolán McNamara
During pdf export PageSyncData::PushAction can be called to associate extra data with a given MetaFile MetaAction position. But RemoveTransparenciesFromMetaFile replaces that metafile with a rewriten one while the PageSyncData actions remain at the positions of the original metafile. So, if the metafile was replaced throw away the PageSyncData data as it's now useless. Maybe we should try and repair the PDFExtOutDevData by e.g. clearing the mActions and adding back the ones associated with a MetaAction that is passed through from the original to the copy ? Change-Id: Ie62e4e2d2ad29670764ce570033034724a005474 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114019 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-13flatten PropertyChangeNotifierNoel Grandin
which removes an allocation hotspot when loading lots of shapes Change-Id: I0121f5bc86c6dfeddcad13e81203a514151d61bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114051 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13cid#1474366 Untrusted loop boundCaolán McNamara
Change-Id: I943a65dcd0b8d4b1fcd9e7b8626e225159fa1d41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114017 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-13tdf#106852 (related) Remove stray manual button labelGabor Kelemen
This was (likely accidentally) added in 4c0c77f10c3967c720cb0511dc26986a5b003f33 This caused "Values Only" button to show up without an accelerator and translation Change-Id: I5e9de07583acc93410ab4ce774156d1c71c1042b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114034 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-13tdf#140818 "Default Character Style" -> "No Character Style"Seth Chaiklin
Change-Id: Iba0c7310c5fac08f8fa90ed8eb65e7c9403635b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112311 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-13tdf#79591: No need to use getStr hereMike Kaganski
7ea1bbe712cef48a97faffdf03b45f2812a93e62 had abused the C-style strings, and relied on the names containing zero byte to be truncated on the byte. However, that would only work for names with zero bytes, not with other control characters. Additionally, that prevented the initial names from correct round-trip. This reverts the older fix, and makes sure to handle the attributes with zeroes correctly (using memcpy instead of strncpy). It also removes several similar unneeded uses of getStr. Change-Id: I6c52874d99fe9eb9ccbe0c9a9b57e3b51c45a19f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114040 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-13we don't want this dynamic_cast in release buildsNoel Grandin
so wrap it in NDEBUG Change-Id: I3f6edddf8a3a16dcd337153cd75624e548459dd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114064 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13tdf#100961 doc/rtf export: save FIXEDFLD as fldlockJustin Luth
This fixes the 5.0 regression by commit a072b3533f44730565f42b45cfd9f77f44f506a9 fdo#59886 export fixed date and time fields to docx. which fixed it for DOCX, but broke it (a plain text dump) for DOC and RTF formats. We still can't READ fixed fields properly, (there is no impact/regression on import at all) but this at least works for MS Word, and gets us setup for properly importing. Change-Id: I8835fce06233a52f1433f02879196234f1355280 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114061 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2021-04-13tdf#107586: sc_subsequent_export: Add unittestXisco Fauli
Change-Id: I9f69b179e227ffeb56f9cc207618880cdd00331b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114055 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-13no need to make copies of these objectsNoel Grandin
when querying their values. The copy triggers heap allocation, which shows up when loading lots of shapes. Change-Id: I4b70e0c64b2397a97216065bd6da61daaac7f3ba Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114054 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13avoid a few string allocationsNoel Grandin
by moving the buffer creation to only when we actually need it Change-Id: If5efefdc90452f0e98227f12cb1314732f785606 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114047 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-13sw bibliography, refer to a page: fix biblio field relative URLsMiklos Vajna
Clicking always requires an absolute URL, so add functionality to get the absolute URL (even if the field has a relative one) and use that when handling a click. Change-Id: I05f8b11937eac7b6032750557f4066181c6e4520 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114059 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2021-04-13Missing dependencyMike Kaganski
Change-Id: I6bb96d9be4926e9ea024a2edb5d9b752b37dd2e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114000 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
generated by cgit (git 2.34.1) at 2024-07-12 03:31:23 +0000