summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-01-26Remove dynamic exception specificationsStephan Bergmann
...(for now, from LIBO_INTERNAL_CODE only). See the mail thread starting at <https://lists.freedesktop.org/archives/libreoffice/2017-January/076665.html> "Dynamic Exception Specifications" for details. Most changes have been done automatically by the rewriting loplugin:dynexcspec (after enabling the rewriting mode, to be committed shortly). The way it only removes exception specs from declarations if it also sees a definition, it identified some dead declarations-w/o-definitions (that have been removed manually) and some cases where a definition appeared in multiple include files (which have also been cleaned up manually). There's also been cases of macro paramters (that were used to abstract over exception specs) that have become unused now (and been removed). Furthermore, some code needed to be cleaned up manually (avmedia/source/quicktime/ and connectivity/source/drivers/kab/), as I had no configurations available that would actually build that code. Missing @throws documentation has not been applied in such manual clean-up. Change-Id: I3408691256c9b0c12bc5332de976743626e13960 Reviewed-on: https://gerrit.libreoffice.org/33574 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26Moved About dialog to DialogFragmentaleksandar-stefanovic
This makes the dialog more modular, and it takes no parameters instead of two. This is in the preparation of making the classes more independent on each-other's states, which is very important. Also, this follows the Android way of workflow better, since there is no "wrapper" class around the dialog, but instead the dialog is called directly. Change-Id: I7571480a040efaf202fae3929cfe76d65c19653e Reviewed-on: https://gerrit.libreoffice.org/33086 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-01-26Remove dead codeStephan Bergmann
...originally introduced with 7c35643da46ab9daabcdf7e69f3ccd0ad89c92fd "INTEGRATION: CWS npower6" and d06de306602566825b5fcfc20da120529fee73e4 "INTEGRATION: CWS npower8", respectively, but never added to sc/source/ui/vba/makefile.mk in the first place Change-Id: Ifdc56beefddfcc24b00c7c79003ed285e29dd8ca
2017-01-26[API CHANGE] offapi: remove unused xsec_fw UNO servicesMiklos Vajna
This is mostly just the offapi/ part, more C++ code can be removed in xmlsecurity/ after this. SignatureVerifier, SAXEventKeeper, SignatureCreator, XMLSignatureTemplate and XMLEncryptionTemplate was only used inside xmlsecurity, but they all are accessed directly already. Decryptor and Encryptor wasn't even used by internal code since they were added in commit 9f34fde7a8750b856570b5e855d2ecb226bf0c23 (libxmlsec, 2004-07-12). It seems to be unlikely that any of these non-published services were used by 3rd-party code, since they were specific to other xmlsecurity/ code, not generic functionality that could be useful in other contexts. Change-Id: I4bcfa88d11d2b92a440f6617193c6460125ce4fd Reviewed-on: https://gerrit.libreoffice.org/33569 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2017-01-26use rtl::Reference in OImageControlModelNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: If0e1380815e93015249cc19bc66b40befbfab50e Reviewed-on: https://gerrit.libreoffice.org/33570 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26loplugin: unnecessary destructor test..unotoolsNoel Grandin
Change-Id: I1fd8a3f39b875d1920759f42e37f4c9d6785d62e Reviewed-on: https://gerrit.libreoffice.org/33573 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26loplugin: unnecessary destructor swNoel Grandin
Change-Id: I27dcd289177bd6a63f07d75fb3cfd5c14fa2ee9d Reviewed-on: https://gerrit.libreoffice.org/33572 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26gbuild-to-ide finalized split of maintained codejan Iversen
Added "testIde-ide-integration" to allow test of new vs2013 generator. Change-Id: Ia7d286f06e287ce97faa0a262ee4f93172d4ed28
2017-01-26use rtl::Reference in ModelNoel Grandin
instead of storing both raw pointers and an uno::Reference Change-Id: I93871eaf9807d0fa846a4e1090d7ee7b1db01c5e Reviewed-on: https://gerrit.libreoffice.org/33571 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26Resolves: tdf#104153 crash on drag and drop pivot table fieldCaolán McNamara
now though sometimes it doesn't get removed at all, so a band aid for the moment Change-Id: I6ccbbe51fe9250af0f85c30a9d253269a18df457
2017-01-26Make test work with older ClangStephan Bergmann
For some reason, e.g. Clang 3.8.1 doesn't evaluate std::strlen here (though it apparently does in other places in this file). Change-Id: Ib2b7dcc1d7b6ae47ef285bd2edb65e399dc11b79 Reviewed-on: https://gerrit.libreoffice.org/33547 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2017-01-26loplugin:dynexcspecStephan Bergmann
Change-Id: I5e30befa9338bfd72e237e2bdb7c157526d32b85
2017-01-26loplugin:useuniqueptrStephan Bergmann
Change-Id: I5091c2b4550dee1f0b602a5337e17fe78b9d07f9
2017-01-26loplugin:useuniqueptrStephan Bergmann
Change-Id: I1fa141ee0d8d818f3ed5b31faa1ac578ba791e39
2017-01-26loplugin:salboolStephan Bergmann
Change-Id: I9c34c84d14084e84ab7d9fda78955cf2aebaf5dc
2017-01-26Stop working around broken IPv6 siteBryan Quigley
This basically reverts 324212ce01c10a8811d25c95d1ae6a83d8214f3d which forced wget to only use IPv4. dev-www.libreoffice.org's IPv6 support was broken for a while. It appears to be back to working. Change-Id: Ib235ddd5719089eaf9d4559bd913571fc46069d1 Reviewed-on: https://gerrit.libreoffice.org/33558 Reviewed-by: jan iversen <jani@documentfoundation.org> Tested-by: jan iversen <jani@documentfoundation.org>
2017-01-26fix useless assignJochen Nitschke
typo from commit a599196064003b724c8ffe3144b77292a4082df3 Date: Mon Sep 30 14:38:41 2013 +0200 covnert sc/source/filter/inc/namebuff.hxx from String to OUString '=' should have been '+=' was 'aScAbsName.AppendAscii( RTL_CONSTASCII_STRINGPARAM( "_ABS" ) );' Change-Id: Ic9c6dcd5c7871c35ae44e6be0f8314d073a863b3 Reviewed-on: https://gerrit.libreoffice.org/33556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26remove unused operatorsJochen Nitschke
Change-Id: Ic35d2071e844235bb755226c55d1e4bbbda4876c Reviewed-on: https://gerrit.libreoffice.org/33555 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26NameBuffer is deadJochen Nitschke
all getters are gone since commit 96d44c9b077a6cc8068067a795dc63248ab90fea Date: Wed Jul 22 10:20:03 2015 +0200 loplugin:unusedmethods sc Change-Id: I26b1ac6b24680d0a6045e9a93d40fbbd2caa6a4b Reviewed-on: https://gerrit.libreoffice.org/33542 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26use rtl::Reference in SmGraphicWindowNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Ib84809bee35c01fb590439174740d92bf4cd54bd
2017-01-26use rtl::Reference in SwXAutoTextEntryNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: I52c8827446d999d0a34b91ab17c056d4237d71a7
2017-01-26drop unused param from SV_DECL_PERSIST1 macroNoel Grandin
Change-Id: Ie1a0a49effc2d88a4d57cf0e5f3608c6bbf4afb6
2017-01-26add 'explicit operator bool' to our reference classesNoel Grandin
Change-Id: I91cfbe2646dcc55b98d2b809c49c9ea073f54f58 Reviewed-on: https://gerrit.libreoffice.org/33517 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-26tdf#103927: Share single standard VirtualDevice instance.Kohei Yoshida
To avoid creating excessive amounts of VirtualDevice instances. Also, since we now have VclPtr, we shouldn't need this bOwnerOfRefDev flag. Change-Id: I97a6f553a178b32bc173b83a6716185d126f97e1 Reviewed-on: https://gerrit.libreoffice.org/33508 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2017-01-25tdf#105520: "Selection Count" does not appear on Status bar when selectedTamás Zolnai
Change-Id: I6ade03b39aeafffa08cfbfcca4739cfe5a73d4ac Reviewed-on: https://gerrit.libreoffice.org/33561 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2017-01-25Resolves: tdf#94457 our EmfPlusSetPageTransform is malformedCaolán McNamara
we write a single short, resulting in a record of 0x000C in length MS-EMFPLUS spec has EmfPlusSetPageTransform as 0x0010 in length because we're not writing the 4 byte PageScale value. the previous pageunit unit we are writing is of value 1, which is UnitTypeDisplay, the same spec says... "The unit of measure for page space coordinates, from the UnitType enumeration. This value SHOULD NOT be UnitTypeDisplay or UnitTypeWorld" and footnotes that with... "Windows never writes those values to the PageUnit field, but they are accepted with undefined results." Change-Id: Ic8b5ec463b59aab28ae9897947dfcdbd35b22048 Reviewed-on: https://gerrit.libreoffice.org/33548 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25ofz: xpm parser is too slowCaolán McNamara
and keeps timing out on documents, this takes my example pathological case from a callgrind cost of 40875 to 1292 million, and as a side effect rhbz#1051121-xpm now look right Change-Id: I840705007acf329579f270c390328f80190c19e7 Reviewed-on: https://gerrit.libreoffice.org/33532 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25Updated coreLaurent Balland-Poirier
Project: help 7b98ed0680a6573ec9b5710ffceeac8df60e684e Basic: remove ^M Remove ^M characters at end of line remove tabulation characters Change-Id: I96345f88c732ad5c40a6143437cccf064aca0738 Reviewed-on: https://gerrit.libreoffice.org/33387 Reviewed-by: Olivier Hallot <olivier.hallot@edx.srv.br> Tested-by: Olivier Hallot <olivier.hallot@edx.srv.br>
2017-01-25sw: revert ToX hyperlinks to LO 4.3 behaviourMichael Stahl
Commit 94b296d5416dd71d721ad16216b50bce79e3dc04 changed this to potentially insert multiple overlapping hyperlink items. Unfortunately Writer can only have one RES_TXTATR_INETFMT on any given position in the paragraph, so the hyperlink hints inevitably overwrite each other. Revert this to do it the same way as the old code in LO 4.3 did: match the last unmatched link-start with the first link-end, and ignore all the link-start before the matching one, as well as the link-end after the matching one. This should prevent surprising formatting changes on index update, including entries spontaneously turning green, and there is no reason why the result of the new way is objectively better than the old one. Change-Id: I55be9c212c473908428fa8bd6487d136343fe852
2017-01-25sw: stop swapping start and end position of links in ToXMichael Stahl
This causes: sw/source/core/txtnode/thints.cxx:3198: +SwpHints::Insert: invalid hint, end < start Change-Id: I933c790127ab1469bb57c4d288dbb49be16ace19
2017-01-25Remove junkStephan Bergmann
left over from 232c0fb700efd31eff8cfee896437c481582ed0f "#115784# idlc: fixed commandline option processing." Change-Id: I41f81b1223cf72c0fcf8e84cdc7016e3aebf0c9d
2017-01-25move Image ctor variant with mask color to callersCaolán McNamara
Change-Id: I81a52aeb855edca823881360831b26e252780053
2017-01-25Remove unused macrosStephan Bergmann
Change-Id: Ib3f8f6cde75b6a605052a3d941380ab27db0f326
2017-01-25Fall back on o3tl::make_unique for nowStephan Bergmann
Change-Id: I58f688004804aed8b749b72caaa53afc06387ec7
2017-01-25Missing includeStephan Bergmann
Change-Id: I60177c2b10b973e9c8f09ea7c71d44df08e50cc4
2017-01-25Avoid calling log10(0)Stephan Bergmann
...to avoid UBSan reporting during CppunitTest_sc_addin_functions_test: [...] > Testing file:///data/sbergman/lo-san/core/sc/qa/unit/data/functions/addin/fods/imabs.fods: > warn:xmloff.style:14186:1:xmloff/source/style/xmlstyle.cxx:300: Here is a duplicate Style > scaddins/source/analysis/analysishelper.cxx:949:37: runtime error: value -inf is outside the range of representable values of type 'int' > #0 0x7f77717d11d6 in sca::analysis::ParseDouble(char16_t const*&, double&) scaddins/source/analysis/analysishelper.cxx:949:37 > #1 0x7f77717e39e5 in sca::analysis::Complex::ParseString(rtl::OUString const&, sca::analysis::Complex&) scaddins/source/analysis/analysishelper.cxx:1690:10 > #2 0x7f77717e317f in sca::analysis::Complex::Complex(rtl::OUString const&) scaddins/source/analysis/analysishelper.cxx:1664:10 > #3 0x7f777167fa79 in AnalysisAddIn::getImabs(rtl::OUString const&) scaddins/source/analysis/analysis.cxx:912:19 > #4 0x7f78148bd16a in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 > #5 0x7f78148b6b70 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 > #6 0x7f78148b3894 in bridges::cpp_uno::shared::unoInterfaceProxyDispatch(_uno_Interface*, _typelib_TypeDescription const*, void*, void**, _uno_Any**) bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:420:13 > #7 0x7f7772bdd096 in stoc_corefl::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) stoc/source/corereflection/criface.cxx:697:9 > #8 0x7f7772bdf45a in non-virtual thunk to stoc_corefl::IdlInterfaceMethodImpl::invoke(com::sun::star::uno::Any const&, com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) stoc/source/corereflection/criface.cxx > #9 0x7f77d3c63f17 in ScUnoAddInCall::ExecuteCallWithArgs(com::sun::star::uno::Sequence<com::sun::star::uno::Any>&) sc/source/core/tool/addincol.cxx:1466:31 > #10 0x7f77d3c631da in ScUnoAddInCall::ExecuteCall() sc/source/core/tool/addincol.cxx:1444:9 > #11 0x7f77d484504f in ScInterpreter::ScExternal() sc/source/core/tool/interpr4.cxx:2999:19 [...] Change-Id: Ie31d6374bdac3ae11784d925011c5a67802cdf56
2017-01-25Pass gb_VISIBILITY_FLAGS into external/breakpadStephan Bergmann
...to avoid UBSan (on Linux) reporting a ODR violation between google_breakpad::MinidumpDescriptor::kMicrodumpOnConsole (workdir/ UnpackedTarball/breakpad/src/client/linux/handler/minidump_descriptor.cc) defined in both the crashreport and sofficeapp dynamic libs. Change-Id: I686a6e2041c70f0aa17a774d705dc71d95d20183
2017-01-25fix index widget control positions on first viewCaolán McNamara
Change-Id: Ic70006d65100b0ed8b337d43ff81577fb4579192
2017-01-25use a std::unique_ptrCaolán McNamara
Change-Id: I1ab99995e35714d6ef3358400b0805723c44678c
2017-01-25valgrind: fix leakCaolán McNamara
since... commit e94d5233dd7939c54eb52fff456e817cecdf0a4c Date: Fri Mar 11 06:43:06 2016 +0100 work on sane lifecylce for SfxFilter which removed "delete pFilter" though it was pMediumFilter which was in question in this method Change-Id: I598dd44a8498ebd6b3e63d1c89147bee5ab3bb55
2017-01-25tdf#105502 sd increase font size: handle table selectionMiklos Vajna
In part of a table shape is selected, then only operate on the selected cells, not on all of them. Change-Id: I3a9ba2b99bcaa2e355b6fcdafdd142d4a809bce6 Reviewed-on: https://gerrit.libreoffice.org/33524 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-01-25Replaced empty spinner with the document titlealeksandar-stefanovic
Replaced empty spinner with the document title in the Main (viewer) activity. Had to edit the themes to not disable title, and edit the manifest to make the desired activities use that theme. If the theme is set in the "application" tag, it will apply the theme globablly. Also cleaned up and tightened the ToolbarController. Change-Id: I5099860787b5f84d01c98c5e53ade519c2f89cc4 Reviewed-on: https://gerrit.libreoffice.org/33306 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Aleksandar Stefanović <theonewithideas@gmail.com>
2017-01-25return earlyCaolán McNamara
Change-Id: Ia8504fdbc952b1e116bdca135a063d4d98be92be Reviewed-on: https://gerrit.libreoffice.org/33531 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25appears to be a missing break hereCaolán McNamara
Change-Id: Ifb04133b1946303879bf860003749996512bec91 Reviewed-on: https://gerrit.libreoffice.org/33530 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2017-01-25Resolves: tdf#105351 pass matching index key to conditional format dialogEike Rathke
Change-Id: I9d872140755c4ec0ae67349530b00f339057a356
2017-01-25tdf#105511: Unit testMike Kaganski
Change-Id: I1b988ca629bc93ff7d29c396d463f2967ed99b54 Reviewed-on: https://gerrit.libreoffice.org/33512 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2017-01-25loplugin: unnecessary destructor svxNoel Grandin
Change-Id: I7feed30eea4f7367943fa2d6e0d75be5ca209068 Reviewed-on: https://gerrit.libreoffice.org/33516 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-01-25sw: config item "OutlineLevelYieldsNumbering" has no effectMichael Stahl
... since CWS swqbf90 in 2005, so remove it, except for the entry in the property set. Change-Id: I5f82d1957a15bf5141108ac9821b813dd36f1995
2017-01-25sw: UseOldPrinterMetrics setting is deadMichael Stahl
Change-Id: Ib988c5a842b8eb1c3d1d24261e8f30a5d042ffd8
2017-01-25use rtl::Reference in SdLayerNoel Grandin
instead of storing both a raw pointer and an uno::Reference Change-Id: Id608c50cb4cb3a7cf7ad972303a3c5f9fc8e79b0
generated by cgit (git 2.34.1) at 2024-08-09 17:31:49 +0000