summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-01-24Fix typosAndrea Gelmini
Change-Id: I359c5aff8c90359783588d189de4e5b94224fa9c Reviewed-on: https://gerrit.libreoffice.org/48232 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-01-24tdf#115030 Formula use "dot" instead of "acute" math command.ekuiitr
Change-Id: I5a382f73a786f45ce0b83864b21e5e6ae357fad4 Reviewed-on: https://gerrit.libreoffice.org/48440 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-24Allocate ImpXPolygon::pPointAry as a true Point[]Stephan Bergmann
...as the default Point ctor already zero-initializes its members, remvoing the need for some memset calls (that cause -Werror=class-memaccess, "clearing an object of non-trivial type ‘class Point’" with upcoming GCC 8). Other such problematic memset calls are replaced with std::fill, which appears to produce adequate code with recent compilers (looked at GCC 7.2 and 8, Clang 7, at -O2), a tight loop of filling the memory with zeroes. A follow-up commit might want to use unique_ptr or vector for pPointAry. Change-Id: I566422b2213643ab762f0d87a25e745ec2f35ee4 Reviewed-on: https://gerrit.libreoffice.org/48488 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24loplugin:emptyif (clang-cl)Stephan Bergmann
Change-Id: I8ddf764f9e155c037e25855b7d6efc49eb494179 Reviewed-on: https://gerrit.libreoffice.org/48483 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24sal_Bool -> bool (remaining uses of css::uno::Any::has)Stephan Bergmann
Change-Id: I041540307d48083955a74d20f73219ac458037fe Reviewed-on: https://gerrit.libreoffice.org/48482 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24gtk3: single click with selection set doesn't unselectCaolán McNamara
this is a safe backportable fix, the unconditional nFlags |= SelectionEngineFlags::CMDEVT looks the real dubious thing to me, but only the gtk3 backend has swipe support so just returning immediately on a swipe definitely ok Change-Id: Iade26d0d9260ce76dfb2766ac9e5ca9fa9275bf4 Reviewed-on: https://gerrit.libreoffice.org/48527 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-24tdf#114913 Use master if char size wasn't setPaul Trojahn
The size returned by insertAt falls back to the master size if needed. Change-Id: I741b48616c6c848fc641c597cc72bf8b17e3cad4 Reviewed-on: https://gerrit.libreoffice.org/48456 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-01-24tdf#115153 the missing test documentMichael Stahl
Change-Id: I74724ba61aadfad19501a87ab548219ea0a1f236
2018-01-24tdf#115153 writerfilter: RTF import: fix vert orient of Word 6 shapesMichael Stahl
The bugdoc is affected by the change of default vertical alignment; apparently it's not even possible to set the vertical alignment of a Word 6 drawing object (\do) so we have to set the Word default. (regression from c79467ba954987f1d239c594c1e1b3af3f5515f6) Change-Id: I4084a7a7e2a55f864cb569e04632e034d59eefdb
2018-01-24Remove old comment left overEike Rathke
Change-Id: I5f6d47afc2f27b1033201b3fa280359a215f38b5
2018-01-24tdf#115129 change customize function tree expand collapse behaviorJim Raykowski
Change-Id: I6c20957fe3f95a8e63b30e5c733b99f71c193972 Reviewed-on: https://gerrit.libreoffice.org/48290 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-01-24This presumably always wanted to check for SAL_MAX_UINT16, not USHRT_MAXStephan Bergmann
The check against USHRT_MAX was introduced with 9c0344627f1767512ef5097c08e3ed7500d223da "INTEGRATION: CWS cmcfixes30: #i72614# crash in loading corrupt .doc", apparently to ensure the static_cast<sal_uInt16> in the call to ShortToSVBT16 below (which already was that same static_cast<sal_uInt16> back tehn) is OK. Change-Id: Ie385f0f490cab1c59bce07fa25bd9b92e3ad286a Reviewed-on: https://gerrit.libreoffice.org/48439 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24update creditsChristian Lohmaier
Change-Id: I50973ddb45ec9269eac4954026ff25e28289dc5d
2018-01-24Remove presumably dead < USHRT_MAX checksStephan Bergmann
...which are proably obsolete since 17e2497b6c679c89af84f586b79194cf4e18f2ab "INTEGRATION: CWS tl39: #i77024# chart2 with more than 26 columns" changed the members of SwRangeDescriptor from sal_uInt16 to sal_Int32. Change-Id: Ic383bc2d5f686af5b19a5ec2cd0351607958f672 Reviewed-on: https://gerrit.libreoffice.org/48470 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24[Pardus] tdf#108989 Add contextual validity command.Gulsah Kose
When cursor is in a cell has following validity attributes SC_VALID_WHOLE, SC_VALID_DECIMAL, SC_VALID_DATE, SC_VALID_TIME,SC_VALID_TEXTLEN, SC_VALID_LIST, SC_VALID_CUSTOM, Validity command appears on context menu. This patch is sponsored by ULAKBIM/Pardus project. Change-Id: I47c0de7b62befdf02c343c1419cf32441d8f4df2 Signed-off-by: Gulsah Kose <gulsah.1004@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/48067 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com>
2018-01-24Updated coreChristian Lohmaier
Project: translations 5634878ae8bfcd66bdf403e9ae009eab7312c611 update translations for 6.0.0 rc3 Change-Id: I4f1d4959997ff3e5522b8947985937a372cb96f0
2018-01-24-Werror=parentheses (upcoming GCC 8)Stephan Bergmann
Change-Id: I4522dc7929030c5da59f2ab030a806ebe7516bd1 Reviewed-on: https://gerrit.libreoffice.org/48403 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24Use a more conventional way of zero-initializing class membersStephan Bergmann
...to avoid upcoming GCC 8 -Werror=class-memaccess ("clearing an object of non- trivial type ‘class SalVisual’") Change-Id: Id9c5a6fa7e084b5abd549c99d07f05f183d56a52 Reviewed-on: https://gerrit.libreoffice.org/48402 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24Make ImplColorSet default ctor zero-initialize all membersStephan Bergmann
...allowing to simplify creating the pColorSet array (which might want to be improved even further, turning it into a unique_ptr or vector) Change-Id: Ic05bd987057a0844885ccfc6ca52700770a27282 Reviewed-on: https://gerrit.libreoffice.org/48401 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24Remove presumably dead < USHRT_MAX checksStephan Bergmann
...which are probably obsolete since 93cb1f8bb13e25586f61ba108e959376d90e91ed "INTEGRATION: CWS swwarnings" changed the parameters of lcl_CreateXCell from sal_Int16 to sal_Int32 (even though the < vs. <= and unsigned USHRT_MAX vs. signed sal_Int16 inconsistencies are suspicious). Change-Id: I14511cb7df1aa92630bf03d89d54609e7a440256 Reviewed-on: https://gerrit.libreoffice.org/48469 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24Add wiki header and footer to the outputXisco Fauli
Change-Id: Iec0be65f57cac06756f2e8101d3edb89b126e92f Reviewed-on: https://gerrit.libreoffice.org/48430 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2018-01-24Natvis: update SfxItemSet visualizer (m_pItems is now unique_ptr)Mike Kaganski
Change-Id: I862f6399a9a065ef725211b44f77400927db9a8f Reviewed-on: https://gerrit.libreoffice.org/48496 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-01-24lokdialog: Convert the Table -> Properties... to async exec.Jan Holesovsky
Change-Id: Iac937f5032ddaa614f8364a85b0b8db2a0828cbd Reviewed-on: https://gerrit.libreoffice.org/48454 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-24Adapt solenv/flatpak-manifest.inStephan Bergmann
...to e1026e267b4b1b0b0bd645c6bc212d6fa71544f8 "pdfium: update to 3312" Change-Id: I319b00d13d8657849967e08e605d6428f30c5c2e
2018-01-24writerfilter: use WW8 name for StyleIdJustin Luth
The sStyleIdentifierD for the default style is "Normal". FindStyleSheetByISTD uses sStyleIndentifierD for its comparison. SetCurrentParaStyleId() is used to save the WW8 provided name. Thus, the default style should do the same. The SetCurrentParaStyleId was added here by commit 4abb20ee162ff874cc143fd952f72d30ddc9d136 Author: Miklos Vajna Date: Tue Jun 19 17:36:28 2012 +0200 Also removing the static variable, since it serves no purpose. Change-Id: I58659e9d809c32dd799fb46217971707991b2803 Reviewed-on: https://gerrit.libreoffice.org/48034 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-01-24USHRT_MAX -> SAL_MAX_UINT16Stephan Bergmann
...presumably forgotten when the following cast of nTmp in the SetPosFromLeft call was changed from USHORT to sal_uInt16 in 7f33ed417b2e29e5470724ea76967f64699a2662 "removetooltypes01: #i112600# Remove tools types from sw" Change-Id: I42d93aeb86473d6ff69251035dc22bbadcd5ae0f Reviewed-on: https://gerrit.libreoffice.org/48466 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24Fix documentation for osl_executeProcess_WithRedirectedIOMilian Wolff
The file handle arguments are out parameters, not input parameters. Change-Id: Iad604e4df9e89a8f83c4cb6a3faa35ee20cd80aa Reviewed-on: https://gerrit.libreoffice.org/48450 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-24This presumably always wanted to check for SAL_MAX_UINT16, not USHRT_MAXStephan Bergmann
...ever since 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import", where the code read + if( nIndex < USHRT_MAX) + { + const SwFmtRefMark* pMark = GetDoc()->GetRefMark( (sal_uInt16) nIndex ); + if(pMark) + { + xRef = SwXReferenceMarks::GetObject( GetDoc(), pMark ); + aRet.setValue(&xRef, ::getCppuType((uno::Reference<XTextContent>*)0)); + } + } and already contained the cast to sal_uInt16 in the call to GetRefMark Change-Id: Ifd4c3ca0bd89a521c3eecda22435705396f61e16 Reviewed-on: https://gerrit.libreoffice.org/48464 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2018-01-24ofz#5621 Integer-overflowCaolán McNamara
Change-Id: I98f93101dc287b2ef285f3d9547d44dd06d2fe01 Reviewed-on: https://gerrit.libreoffice.org/48429 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-24tdf#115080 menu id collisionCaolán McNamara
21 collides with the pattern field menu id Change-Id: Ia90995861adabbe1615e24ee10defe25cee76c56 Reviewed-on: https://gerrit.libreoffice.org/48461 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-01-24Fix some IWYU warningsMiklos Vajna
Change-Id: I4b6e799c1afc2a762a3729ee89f3226c59a6eef8 Reviewed-on: https://gerrit.libreoffice.org/48462 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-24scripting: add missing vim modelines to python filesMiklos Vajna
Change-Id: Iedc3a8ab37deeb7a686fa709afb0cf350f815ec6 Reviewed-on: https://gerrit.libreoffice.org/48418 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2018-01-24Avoid upcoming GCC 8 -Werror=class-memaccess on css::util::DateTimeStephan Bergmann
...whose ctor already zero-initializes all members, so the first two memsets are unnecessary. And spell the third memset as explicit assignments. Change-Id: Ie5079711b152bac7f0a8d52d7889879157a35b5d Reviewed-on: https://gerrit.libreoffice.org/48390 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24fix kde4 vclplug buildNoel Grandin
by reverting parts of commit de8f6b25de6fbe813fe172542e7eff1596b37335 loplugin:unused-returns in vcl and reverting commit 78bb1a2a51a991f605ae5c51d813697673bbc67 Fix --enable-kde4 codeHEAD <noelgrandin> sberg, is that safe ^^ ? I was just about to push a partial revert of the commit that caused the breakage <sberg> noelgrandin, oops, I'd naively assumed that all impls of Dispatch had just always returned true Change-Id: Icbca450a76de30a04bc90a2887066840191c9d5f
2018-01-24Fix --enable-kde4 codeStephan Bergmann
...after de8f6b25de6fbe813fe172542e7eff1596b37335 "loplugin:unused-returns in vcl" Change-Id: I82414b20b7dbb9e7ba361c0f4d9451c74ea4d4f2
2018-01-24Remove presumably dead < USHRT_MAX checksStephan Bergmann
The original code of 84a3db80b4fd66c6854b3135b5f69b61fd828e62 "initial import" read + long nBoxOffset = lcl_GetLongBoxNum( sGetName ) + nSttBox; + long nLineOffset = lcl_GetLongBoxNum( sGetName ) + nSttLine; + + if( nBoxOffset < 0 || nBoxOffset >= USHRT_MAX || + nLineOffset < 0 || nLineOffset >= USHRT_MAX ) + return 0; + + if( nLineOffset >= long(pLines->Count()) ) + return 0; + + pLine = (*pLines)[ USHORT(nLineOffset) ]; + + // dann suche die Box + pBoxes = &pLine->GetTabBoxes(); + if( nBoxOffset >= long(pBoxes->Count()) ) + return 0; + pBox = (*pBoxes)[ USHORT(nBoxOffset) ]; casting nBox/LineOffset to USHORT, while the current code looks like it should work fine for larger values. Change-Id: I47bdf3963be6e84568a589711ce688b66f325db8 Reviewed-on: https://gerrit.libreoffice.org/48451 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24iOS, allow orientations for all devicesjan Iversen
Info.plist is no longer limited to ipad Change-Id: Ibe807183fab7e2820e5234fa7fa773fda2c32926
2018-01-24loplugin:useuniqueptr in OOo2OasisTransformerNoel Grandin
Change-Id: I6c1cabbf233e6d3d9fd37cdb5c66ffa17df2dd9c Reviewed-on: https://gerrit.libreoffice.org/48425 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in Oasis2OOoTransformerNoel Grandin
Change-Id: I7636bb09bfa728ae8031d57e52d2903f711e9cca Reviewed-on: https://gerrit.libreoffice.org/48424 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in ImageListsDescriptorNoel Grandin
Change-Id: I165af348b6d8863a4b1e5dd164d92c29f49d09c0 Reviewed-on: https://gerrit.libreoffice.org/48423 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in LayoutManagerNoel Grandin
Change-Id: I93383fcb5f0093416914722e25cd0faf70c040eb Reviewed-on: https://gerrit.libreoffice.org/48422 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in SvxBoxItemNoel Grandin
Change-Id: I0702a25c765fc8781b65320f44c0e0c3c56269a7 Reviewed-on: https://gerrit.libreoffice.org/48408 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in SfxCommonTemplateDialog_ImplNoel Grandin
Change-Id: I484cb863c054c71cb22b30d108c95692213c8451 Reviewed-on: https://gerrit.libreoffice.org/48407 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in FileDialogHelper_ImplNoel Grandin
Change-Id: I91f831be99284b61385cee42dc59efd0cf7f45ba Reviewed-on: https://gerrit.libreoffice.org/48406 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:unused-returns in drawinglayer..svxNoel Grandin
Change-Id: I033a78cc7fe7d8e5086f1c855c4aa371cc98dc7c Reviewed-on: https://gerrit.libreoffice.org/48400 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:constparamsNoel Grandin
Change-Id: I7c695073d9a9d3b7a641d6eb9fe01a47d8c3a504 Reviewed-on: https://gerrit.libreoffice.org/48392 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24loplugin:useuniqueptr in GroupData_ImplNoel Grandin
Change-Id: Icddaf78a58b74338ac763c12c8ac06f464986cac Reviewed-on: https://gerrit.libreoffice.org/48371 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24Silence upcoming GCC 8 -Werror=parentheses in external/boostStephan Bergmann
...reporting such delights as > [CXX] sal/cppunittester/cppunittester.cxx > In file included from workdir/UnpackedTarball/boost/boost/mpl/aux_/na_assert.hpp:23, [...] > from external/boost/include/boost/algorithm/string.hpp:25, > from sal/cppunittester/cppunittester.cxx:60: > workdir/UnpackedTarball/boost/boost/mpl/assert.hpp:188:21: error: unnecessary parentheses in declaration of ‘assert_arg’ [-Werror=parentheses] > failed ************ (Pred::************ > ^ where boost/mpl/assert.hpp contains > template< typename Pred > > failed ************ (Pred::************ > assert_arg( void (*)(Pred), typename assert_arg_pred<Pred>::type ) > ); Change-Id: I6976b2cc23f1d309d27d3fde9098b10c9d877599 Reviewed-on: https://gerrit.libreoffice.org/48386 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-01-24loplugin:unused-returns in vclNoel Grandin
Change-Id: I507320900a47f604d17ed7d402d531a7cbdf744e Reviewed-on: https://gerrit.libreoffice.org/48331 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-01-24USHRT_MAX -> SAL_MAX_UINT16Stephan Bergmann
...presumably forgotten when the following casts of nTmp in the SetBaseHeight etc. calls were changed from USHORT to sal_uInt16 in 7f33ed417b2e29e5470724ea76967f64699a2662 "removetooltypes01: #i112600# Remove tools types from sw" Change-Id: I75809e677835910b09b366f755361a667d097402 Reviewed-on: https://gerrit.libreoffice.org/48442 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-03 14:58:22 +0000