summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2022-01-26bump product version to 7.3.0.3.0+libreoffice-7-3-0Christian Lohmaier
Change-Id: Ic3d70cd48dc87763c2a14478578f9be18f656b69
2022-01-26tdf#146144 sw: add tooltip to table rows with change trackingLászló Németh
Showing "Row Deleted" and "Row Inserted" with Author and Date (of the associated SwRangeRedline: latest tracked deletion in deleted rows, and first tracked insertion in inserted rows). Follow-up to commit c6af542a31e167e5a01908d049e399ce06a5e4e4 "tdf#146120 sw: show tracked table changes with different color" and Change-Id: I913e234de1a60311306fbebdfb1ae16dcea7cd8c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126575 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 84fbb3398f7486f00e7b7dea415e1ea2510a9535) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128684 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-01-26update creditsChristian Lohmaier
Change-Id: Ib2d0e2477b932669ab55b36abcfc347d43dc8bcd (cherry picked from commit 65564103f619aa75eb1d1872546af78caf3144b6) (cherry picked from commit 6d3312d734b9cfafdb011e3b11b1c145f420d53a)
2022-01-26tdf#139638 sw_fieldmarkhide: hide fieldmark command in ModelToViewHelperMichael Stahl
The crash happened because the generated ToX text contained CH_TXTATR but the fieldmarks themselves were not copied. Just filter everything except the result of the fieldmark. Change-Id: I349e7793987624e64f5afe08dfa2ca977368156b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128605 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit ab6176e88f78d0b3aa2490fbc7858304c2d4a437) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128537 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128634 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-01-26tdf#146367 reintroduce approxAdd() similar handling with last summandEike Rathke
... to tie result to 0 eliminating opposite sign small equalish fractions. This does not "fix" all interim values of the bug's sample document, which repeatedly adds single values in sequence using SUM() and should use the + operator instead to benefit from approxAdd() for each, but maintains the better accuracy of Kahan summation in the not near equal zero cases. And the dreaded SUM(0.1;0.2;-0.3) also works again resulting in 0 with all permutations. Change-Id: I67188a6abbdb98212f070166ad02319c3d477e28 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128451 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 730b8aba72356bb8ba0066a5517b1224a4f1e232) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128433 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-01-26Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-3-0' to c3aca9260935e0e02b6d4cbd1239aaeb9b47ac97 - update translations for 7.3.0 rc3 and force-fix errors using pocheck Change-Id: Iedaea86e48ece63ca63d38dceac9b0d15091f38d (cherry picked from commit 59aa6716126252d64cbd897153f231389c05ac2d) (cherry picked from commit 22e60373393e60eacb736936c265807ca7e0f946)
2022-01-25tdf#146971 changing a11y desc to replace %PRODUCTNAME has perf issuesCaolán McNamara
so leave it alone, and do the conversion just for the originally report situation as a safely backportable change with a follow up to not allow us to get into this situation in the first place Change-Id: I4f95f85791d0f937e53d7541804870b2cbf62b44 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128820 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 4723360671758c3ac9e646382751d01b630a95d0) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128825 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-24Resolves: tdf#139974 Do not munge character after forced line breakEike Rathke
A classical +-1 error.. Change-Id: I8b6bc0843fa585d8a710c74f757098ab9c6f823d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128637 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 2cfa04cbf03fe5c2ce32a7384082cdc5de5a4785) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128541 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit 2b8946e52fa170c7df4bf71440e2ed63474db28f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128668 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-24sw_fieldmarkhide: disable layout cache if there are fieldmarksMichael Stahl
... similar to the "ShowChanges" check that is already done. This prevents a crash in SwLayoutCache::CompareLayout() on fdo38619-2.ott Change-Id: I1a90c45f041ae18beacd3fbd4dcbdae5ba86c317 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128556 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 3170fba5dff3ea5cc67ea94f51a0dd5458f01edd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128536 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128633 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-20Update git submodulesMartin Srebotnjak
* Update translations from branch 'libreoffice-7-3-0' to 18a77ec0b10fb37e7ef2f9bd2df3700dc1615140 - Updated Slovenian translation Change-Id: I711fd5967b87131791f356f1e66df5f75967e496
2022-01-20tdf#135843 tdf#146731 Fix the missing border handlingGülşah Köse
Reverts fa5ab8aa5d88e7128015127af75980a65f945cbb inside. And fix the missing border problem with better way. Reason of the problem is using ORIGCELL cell style for bottom and right of merged ranges is wrong. Eg: We have Row X Col 3X3 table. (0,1) and (0,2) merged. The right side of right border style should be same with (0,2). But ORIGCELL points (0,1) instead. In case we should use LASTCELL. Same reason is valid for bottom case. Change-Id: I5282083541f0bd02f3765943da4f34cabe05ef13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128493 Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> Tested-by: Gülşah Köse <gulsah.kose@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128498 Tested-by: Jenkins (cherry picked from commit 58c1afd0590463177de83a90a848a83d0cfcc058) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128532 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-18tdf#146747 InternalItems has to be null terminatedCaolán McNamara
Change-Id: I15c0afdcae3e9bc1412e6564c15df2196515052e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128427 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2022-01-18tdf#145321 Crash scrolling DOCX to bottomNoel Grandin
this is a consequence of commit d4dc6b5cfdb02ad00a06ad32650948648abe010d use std::vector for fetching DX array data which made pre-existing bugs easier to see. This crash made apparent that we have bad data ending up in SwDrawTextInfo. So I added some asserts there to catch that. However, that simply made apparent that there are bug(s) at a higher level that I have no idea how to to fix. So at the primary problem site in SwTextCursor::GetModelPositionForViewPoint I clamp the values to sane ones. Change-Id: Ic74f6944932bbfc22e8cf9addf9e7511755b18be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128497 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0e4bcbb67dda204ba78f99df68a63458c29e7470) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128441 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 68fa037b8f1300ffb950cc3ba4be4347f976eb83) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128446 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-17Resolves: tdf#146757 Use correct format index keys instead of wrong hackEike Rathke
The hack worked by accident as long as the internal index constants didn't change. Which was the case with commit f7d0c6b42a0a5ec98876006cd5048589219be741 CommitDate: Thu Sep 23 20:28:42 2021 +0200 Sort ZF_STANDARD_NEWEXTENDED_DATE_... into ZF_STANDARD_DATE category convertDateString() Standard + 36 == old ZF_STANDARD_DATE + 6 => DATE_SYS_DDMMYYYY unchanged convertDateTimeString() Standard + 51 == old ZF_STANDARD_DATETIME + 1 => DATETIME_SYS_DDMMYYYY_HHMMSS became wrong nothing (no format assigned, empty DATE slot) convertTimeString() Standard + 41 == old ZF_STANDARD_TIME + 1 => TIME_HHMMSS became wrong ZF_STANDARD_DATE_SYS_DMMMMYYYY (DATE_SYS_DMMMMYYYY) So time 08:00 double 0.33333... was converted to string "30 December 1899" which then numeric was 0. Change-Id: I642e0a977d4e167f78537d20624e86721e518c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128507 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 0d6ab8d4ea7226db53d07dc158e176fe962fd8d9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128528 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Lionel Mamane <lionel@mamane.lu> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-16Sync flatpak-manifest.in with FlathubStephan Bergmann
...including <https://github.com/flathub/org.libreoffice.LibreOffice/commit/65437462b575881703146b132d2ae6c7e998c1b6> "Merge pull request #174 from vroger11/patch-1: Add global-menu support for KDE and unity" Change-Id: Id9c9c9d63303fc7de12b47e12b1e32f6556f1f02 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128368 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 18220ad65bb989fdbfe73fa36ae03ef6466d7ee5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128338 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit f90618d38cc33c511f921aa940c0d65908146fef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128343 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-12bump product version to 7.3.0.2.0+Christian Lohmaier
Change-Id: I87837b4bbf4fb0862d5aa3e6e458a855dd2a8f0a
2022-01-12Branch libreoffice-7-3-0Christian Lohmaier
This is 'libreoffice-7-3-0' - the stable branch for the 7.3.0 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.3.x release, please use the 'libreoffice-7-3' branch. If you want to build something cool, unstable, and risky, use master.
2022-01-12ofz#43551 Use-of-uninitialized-valueCaolán McNamara
Change-Id: I2eb139f3bff296cff7d8f0e9a05f19df56b27ecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128327 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins
2022-01-12tdf#38235: fix sort failure for EvolutionJulien Nabet
Several issues to deal with: 1) The initial pb: "Error setting the source criteria. The column XXX must be visible as a column. SQL status: 01000, Error code 1000." => OEvoabResultSetMetaData::getColumnLabel was returning the nickname of the column with g_param_spec_get_nick we just want the column name to display and to use 2) SQL parsing in OCommonStatement::orderByAnalysis 2 "sub-issues": a) ENSURE_OR_THROW was testing SQL_ISRULE( pAscDesc, opt_asc_desc ) opt_asc_desc is defined in connectivity/source/parse/sqlbison.y with: opt_asc_desc: {$$ = SQL_NEW_RULE;} | SQL_TOKEN_ASC | SQL_TOKEN_DESC ; not sure if it should be kept but for DESC I had to use this: SQL_ISTOKEN(pAscDesc, DESC) b) Retrieve of ascending By default ascending is at true but then we tested the node with: if ( ( pAscDesc->count() == 1 ) && SQL_ISTOKEN( pAscDesc->getChild( 0 ), DESC ) But when we use DESC, it's directly a TOKEN so just this should suffice: bool bAscending = !SQL_ISTOKEN(pAscDesc, DESC); 3) CompareContacts wasn't taking into account bAscending since we use comparison function for g_slist_sort_with_data, I only used int nOrder = 1; // if descending sort, reverse order if (!sortCol.bAscending) nOrder = -1; and multiply the result with this to have the ad hoc order Change-Id: I3c360a5ef9cf0dc737a7ce4a138d2d2586abdca9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126698 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit ab864bd178a44208c98a2fd1b1248df5f1db1fc9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126967 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2022-01-12tdf#146375 Cannot rename user-defined categories in template managerNoel Grandin
Regression from commit 3624a703361b108d22448bd60a97733f05e37820 tdf#135316 remove OTempFileService pessimisation So fix two things here (1) make it so the tempfile service flushes the SvStream buffer and resets the file position, so we can read the data after writing it. (2) Simplify the UCB usage to just write the contents of the tempfile via the tempfile InputStream, which is simpler and safer Change-Id: I15ed3b02c2d6415d10a9579f66374e6268188d5c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128195 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128274 Tested-by: Jenkins
2022-01-12tdf#144270 sw: manage tracked table (row) deletion/insertionLászló Németh
in Manage Changes dialog window, where deleted/inserted tables and table rows were shown as multiple cell changes, as a regression. Now a single table deletion/insertion or deleted/inserted consecutive table rows are shown with a single tree item in the dialog window instead of showing multiple cell changes. Add new Action icons to the tracked table row insertion/deletion tree items (re-using table row deletion/insertion icons). Show cell changes as children of the single parent item tracked table row change. Accept/Reject and Accept/Reject All support 1-click acceptance or rejection of table (row) changes, instead of clicking on all cell changes of a single table (row) deletion/insertion. Regression from commit c4cf85766453982f1aa94a7f2cb22af19ed100be "sw: fix crash due to redlines on tables on ooo121112-2.docx". (cherry-picked from commit eebe4747d2d13545004937bb0267ccfc8ab9d63f) Conflicts: sw/inc/bitmaps.hlst Change-Id: Id03a8075cc6849b70a8d32e1a955b79e7d3a3246 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128326 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-12Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-3' to 6fbe45604f9be33a02b6abd15b9a520fde0be8ae - update translations for 7.3.0 rc2 and force-fix errors using pocheck Change-Id: I372f976206656723929dfd06c958afd839805a2c (cherry picked from commit 87e0eb58bfcb1cdfe04f26833376827a09c1e241)
2022-01-12tdf#146454 - Check for multiline string in setDataArrayAndreas Heinisch
Check for a multiline string in the setDataArray function. If that is the case, set a string or edit cell. Otherwise, just set a plain string in order to prevent performance issues due to the adjustments of the row height. Regression from b9e2c5d2a36fbd189c20448cadf4212edf02914d Change-Id: I9216b198b878fda5da29596d25504db853acd756 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127660 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 2d11710df6d81c03007d136667a443e09cc70eed) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128332 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-12tdf#146703 Fix URL encoding when querying extensionsGabor Kelemen
so that extension information files are properly downloaded such as: https://extensions.libreoffice.org/api/v0/Color Palette.json Change-Id: Ifb2688b1f09d91277b7d5fe065b0d0f8533310b0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128306 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 348e0651cc5add15ac03b11dde08057cf33f9b16) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128246 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-12ofz#43446 Undefined-shiftCaolán McNamara
Change-Id: Ibe3485983ecf764ca8b8e667b470c6b210b6d2d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128192 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 27e9de358b4afc6a89b09c173316cee0abfb471d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128233 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-12ofz#43509 use std::vector and at()Caolán McNamara
Change-Id: Id0c5e4ccc22b41caee95ca5f53f6ae7cf70490f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128237 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2022-01-12Update git submodulesMartin Srebotnjak
* Update translations from branch 'libreoffice-7-3' to 4888805130bd4303c5792fc8961947cde98d7017 - Updated Slovenian translation Change-Id: I61295497128d389d493a16057f06c1e6d8e5877e
2022-01-12tdf#146605 sw: try to fix SwSectionFormat notificationsMichael Stahl
SwSectionFormat no longer notifies via its SwModify to SwClient listeners, but only via SvtBroadcaster, so SwSection and SwSectionFrame need to be SvtListeners. This can be seen when changing the footnote-at-end setting in the section dialog, if the SwSection doesn't get the event the footnote numbers aren't adapted to a new restart value, if the SwSectionFrame doesn't get the event the footnote container isn't moved. This is of course not pretty but hopefully it will be refactored further in the future. (regression from commit 2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a) Change-Id: I93c616e209a01fc5d4c8eba701a6ddce5d5b432e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128257 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit cb188ce336e434c2b7002b3d8a41a681e73ae51a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128243 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-12sw: stop inheriting SwSectionData::m_bProtectFlag from parent sectionMichael Stahl
This is actually no longer inherited by accident since commit 2e32f4ed5af16a68c97a50806a42ffa2d10f1d7a because it replaced the SwSectionFormat::Modify()->ModifyBroadcast()->CallSwClientNotify()->CallSwClientNotify() with a call to GetNotifier()->Broadcast(), and apparently SwSection is a SwClient of SwSectionFormat but not a SvtListener. But some consider the new behaviour useful, as previously there was no way to un-protect a section inside an outer protected section at all, while in this way every section can have its own independent protection flag. (The m_bEditInReadonlyFlag is not used for this purpose, as it is only for the case when the document was loaded ReadOnly.) So make it more explicit by removing the SwSection inheritance code. A similar change was made for hidden flag in commit 91b0024965908c692bea40f47c58ea9d1bf8a596 Change-Id: I29d3c84309a84267573950775f2a1c6353623724 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128221 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 840cc7883849a10eea11a02a743848238723a3de) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128232 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2022-01-11editeng: avoid writing past the end of of pLine->GetCharPosArray()Miklos Vajna
Thread 1 "soffice.bin" received signal SIGSEGV, Segmentation fault. 0x00007ffff6df4951 in ?? () from /usr/lib64/libstdc++.so.6 (gdb) bt 10 #0 0x00007ffff6df4951 in () at /usr/lib64/libstdc++.so.6 #1 0x00007ffff6df5792 in __gnu_debug::_Error_formatter::_M_error() const () at /usr/lib64/libstdc++.so.6 #2 0x00007ffff47384bf in std::__debug::vector<int, std::allocator<int> >::operator[](unsigned long) (this=0x6b3dca0, __n=7) at /usr/include/c++/7/debug/vector:417 #3 0x00007ffff47b5440 in ImpEditEngine::ImpBreakLine(ParaPortion*, EditLine*, TextPortion const*, int, long, bool) (this= 0x1ce0040, pParaPortion=0x206a010, pLine=0x6b3dca0, pPortion=0x6b3e480, nPortionStart=0, nRemainingWidth=5093, bCanHyphenate=false) at editeng/source/editeng/impedit3.cxx:2041 #4 0x00007ffff47b1fb6 in ImpEditEngine::CreateLines(int, unsigned int) (this=0x1ce0040, nPara=0, nStartPosY=0) at editeng/source/editeng/impedit3.cxx:1352 #5 0x00007ffff47ad0c2 in ImpEditEngine::FormatDoc() (this=0x1ce0040) at editeng/source/editeng/impedit3.cxx:387 #6 0x00007ffff47bf516 in ImpEditEngine::FormatAndLayout(EditView*, bool) (this=0x1ce0040, pCurView=0x0, bCalledFromUndo=false) at editeng/source/editeng/impedit3.cxx:4190 #7 0x00007ffff47be333 in ImpEditEngine::SetUpdateLayout(bool, EditView*, bool) (this=0x1ce0040, bUp=true, pCurView=0x0, bForceUpdate=false) at editeng/source/editeng/impedit3.cxx:3927 #8 0x00007ffff46f059e in EditEngine::SetUpdateLayout(bool, bool) (this=0x1ce2b20, bUpdate=true, bRestoring=false) at editeng/source/editeng/editeng.cxx:1472 #9 0x00007ffff48ce5e3 in Outliner::SetText(OutlinerParaObject const&) (this=0x1ce0cc0, rPObj=...) at editeng/source/outliner/outliner.cxx:586 (More stack frames follow...) (gdb) frame 3 #3 0x00007ffff47b5440 in ImpEditEngine::ImpBreakLine (this=0x1ce0040, pParaPortion=0x206a010, pLine=0x6b3dca0, pPortion=0x6b3e480, nPortionStart=0, nRemainingWidth=5093, bCanHyphenate=false) at editeng/source/editeng/impedit3.cxx:2041 2041 pLine->GetCharPosArray()[ nPosInArray ] = rTP.GetSize().Width(); (gdb) print pLine->GetCharPosArray() [Thread 0x7fffd2010700 (LWP 5008) exited] $1 = std::__debug::vector of length 7, capacity 7 = {707, 1414, 2121, 2828, 3535, 4242, 4949} (gdb) print nPosInArray $2 = 7 Change-Id: I3a8121c0c0a3b0949e91eb53c0468f7e629b146f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128223 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 56ded398c9c72810f20b9da0aa98097739423180) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128231 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-11ofz#43458 avoid OOMCaolán McNamara
Change-Id: Id0e1e985c446c147a219ba2f5157a41deae656a4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128193 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit e28f4b6bccafb2b9f3c44dfabf36d1b822d85f84) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128235 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-11tdf#146534 pptx import: make Z rotation work with rotation transformSarper Akdemir
Expands previous idea from a9c5c0d814a266096483572b84c72875ef8efd77 (tdf#133037 OOXML shape import: camera rotation along Z) and uses it also for shapes that have a true bUseRotationTransform flag Also fixes same Z rotation exporting twice from InteropGrabBag to both spPr and textBody causing text overrotating on roundtrip. Change-Id: If0f192af029ca86b932a63613f961be1f5003c5b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127880 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128219
2022-01-11tdf#146306 wina11y: Retrieve accessible desc on demandMichael Weghorn
Adapt 'MAccessible::get_accDescription' to directly retrieve the accessible description on demand via the corresponding XAccessible, rather than keeping track of it in a class member. This simplifies the handling and makes it unnecessary to "manually" update the description on 'accessibility::AccessibleEventId::DESCRIPTION_CHANGED' events, since the new value will be queried next time it is needed anyway. This also fixes the problem that a significant amount of time was spent generating accessible descriptions for all newly inserted a11y objects when entering values into Calc cells with the NVDA screen reader in use, resulting in several seconds of delay. Querying up-to-date values from the underlying UNO interfaces on demand instead of doing extra manual bookkeeping in the winaccessibility code may be possible for more a11y attributes in addition to the accessible description handled in this commit, but each one will have to be looked at separately. Change-Id: I57f4c523ca8b10afad3f9c347c8ff5e9420ad968 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128006 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit fcf4a26275d7503835f9aa23cb94938809840300) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128165 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-11wina11y: Use existing method to update descriptionMichael Weghorn
The accessible description and the accessibile *action* description are two different things. 'AccObject::UpdateActionDesc' was (IMHO somewhat confusingly) handling both. Drop the handling of the accessible description from there and call the already existing 'AccObject::UpdateDescription' at the only call site of 'AccObject::UpdateActionDesc' in addition, which does exactly the same thing. Change-Id: I220df676f128a5db69ab4cebe7772d92f6b9b0ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128005 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128252
2022-01-11wina11y: Use separate local variable for action descriptionMichael Weghorn
Use a separate local variable for the accessible *action* description here, which is independent of the accessible description handled above. While at it, use '!OUString::isEmpty' instead of 'OUString::getLength() > 0'. Change-Id: I146d8603ed3decde68f8ce716ac13c04b0263040 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128004 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128251
2022-01-11PDF export of PDF images: preserve hyperlinksMiklos Vajna
The input file has a single page, with a full-page PDF image, which contains a hyperlink. Similar to pdfcrop, we used to wrap this into a form XObject, so page-level annotations like hyperlinks were lost. Explicitly merge page-level annotations from the source page to the page that contains the PDF image to preserve those annotations. Change-Id: I96e8bc9d33440b91f3514486d6a8bd75047546b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128108 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 1984a5c140cc3c7c291047dacf3bddd7061d2047) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128156 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-11tdf#135843 Fix the missing border handlingGülşah Köse
Adding +1 at that stage causes indexoutofbounds. But never throws that exception and tries to pull empty cell style instead. As a result we can not see the border. Actually no idea why +1 used here. Change-Id: Id54ba6445d022540173af3bbf5d679b7edefc55b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127990 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit fa5ab8aa5d88e7128015127af75980a65f945cbb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128163 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-11tdf#145059: sc: always write dxf node for color filter for XLSXVasily Melenchuk
If there is no dxf reference to color filter (for example if selected color is not in range of available colors for current range) Excel is not able to show color filter correctly: it is not marked as used filter, no ability to reset, etc. Change-Id: I65378ddd6f8f8233cda147ff9dcd28f455a58225 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127745 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit f0ad6ec2a23a36ade407db8cda36655ba2f144c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128159
2022-01-11test: move parseExportStream() from SdModelTestBaseXML up to MacrosTestMiklos Vajna
Move parseExportStream() from SdModelTestBaseXML up to MacrosTest, so oox/ test code can use it as well. Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126215 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit f36767fde87191258ea21f3faac0be6ad79328e0) Change-Id: I8ba7d6f3b535456ddaa7cd0f0bb5d56fce7a7766 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128173 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128255 Tested-by: Jenkins
2022-01-11tdf#134960 tdf#146419 use sorted array to list hyperlinks in NavigatorJim Raykowski
in document order The current approach of using layout position to list hyperlinks in document order works for single-page view but not for multiple-page or book view. This patch makes the list order layout independent by using SwPositions to sort the hyperlinks in document order. Change-Id: Ie09ac362aa0e8db813430de50c7f06f3072179f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127856 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit 1aa49bb9cf2b960312bf1e65ea1eee2521873a16) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128227 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2022-01-10tdf#145693 - Argument name should be 'charcode' instead of 'string'Andreas Heinisch
In addition, changed argument datatype from Int to Long. Change-Id: I702e09b6b8061d7cf00dd403e4681a0ab348d4c5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128100 Tested-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128212 Tested-by: Jenkins
2022-01-10Slightly optimize code handling anglesMike Kaganski
Change-Id: I8bc10513f6cd704abc7a2bbb17d8d0d8d2628401 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128187 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 1bdb4ddfc516d62f482f83fc6191e9585aa4786b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128230 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10tdf#73523 support WinBMPv3-NT version of BMP files (found in Visio files)Andras Timar
It is a special case when there are additional 12 bytes of color bitfields after the info header. See also the useful comments at https://searchfox.org/mozilla-central/source/image/decoders/nsBMPDecoder.cpp#47 It turned out we generate this type of BMP files internally from EMF files, but in that case the bfOffBits of BITMAPFILEHEADER struct points to the pixel data. In case of Visio, bfOffBits points to the color mask. There was no better solution than preventing jumping back in the stream. Change-Id: I97f0fd4f184ea77beeab8b22fc98fdb78472d9bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127920 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127927 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 3a0d539b3a8a76efc2cdac04c658645fe750bec4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128158 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10tdf#144890 Invalid selection area when text in LTR runNoel Grandin
In commit ec50b9e5eaec7c94df35617676077ef0d65cecc7 no need to allocate Sw2LinesPos separately on heap I made this change, // If there's no doubleline portion involved or start and end are both // in the same doubleline portion, all works fine, but otherwise // we need the following... - if( pSt2Pos != pEnd2Pos && ( !pSt2Pos || !pEnd2Pos || + if( (pSt2Pos || pEnd2Pos) && ( !pSt2Pos || !pEnd2Pos || pSt2Pos->aPortion != pEnd2Pos->aPortion ) ) I tried to follow the explanation in the comment, since the existing comparison of pointers made no sense, since the two objects would always be distinct. However, that appears to have caused this bug, so change the comparison to directly represent the original logic. Change-Id: I95d6d870cecd762d4eb809d371e4a61b6641c85e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128133 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 563af8fd15aa37e75af8882cccbdf8914ebe8e61) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128154 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10tdf#146621: handle an exception that may hang process at ExitProcess timeMike Kaganski
Change-Id: I3ffc2303ae1851ab909612ae9bb7f70a077b24fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128097 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 639419601a3730eb84d0922ef3a540c961b81910) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128157 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10tdf#130076 Fixed flip not working properly from fileDhiraj Holden
Added code to check whether the angles need to be changed when the section is flipped. Change-Id: I9cc3e16db74c6e9616385bc39849e4c73686b56c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127853 Tested-by: Jenkins Reviewed-by: Regina Henschel <rb.henschel@t-online.de> (cherry picked from commit 207d202ed2f1f44e5b62157b5a92ee5e8cc2c3e5) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128166 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10tdf#146556 feature 'drag-mirror' is brokenNoel Grandin
regression from commit 11e52fe2979b0947814a49b9c17ec373795cbf8e introduce Degree100 strong_int type where I tried to introduce a more efficient NormAngle36000 calculation, but it produces the wrong answer. Change-Id: Iefeb0849984bc59d3ce9191eaf6f064beba94c59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128143 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 4c4ce3dc2133199f0d804a686a1e0cd0c9124914) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128151 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10tdf#146392 fix --enable-pch=full buildscito
x509.h includes cert.h. But that doesn't know of LO using xmlsecurity/source/xmlsec/nss/nssrenam.h, which has a "#define CERT_DecodeDERCertificate __CERT_DecodeDERCertificate". So the PCH doesn't know of this rename and the compiler fails. move the include line into the file that needs it and the --enable-pch=full build works ok Change-Id: I247bd219cf47964490ded439ad51bd8e8e120c48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/127744 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins (cherry picked from commit 67fb363eed88b15eec7821fe604eb23d142d84cc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128161 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2022-01-10Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-3' to d043dac2a54fc09b29feb0787ff272f23e1356cb - update translations for 7.3.0 rc2/master and force-fix errors using pocheck Change-Id: I7ba555073adb5a8ddfcb37be8dd61c7df6ad5b40 (cherry picked from commit f6628660c35c8b21a632418e1363784b906f6ff9)
2022-01-10fix Options->LibreOffice->View->Visibility->Menu on Windows,Noel Grandin
impossible to set to Hide, regression from commit 131759a3db51140c21594308ed99c71aa7aba43a Date: Sun Jul 25 16:21:39 2021 +0200 use officecfg for menu options Change-Id: I5312be2963d15ab85c267ece073e52984b1a34de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128137 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 31872a382342060d6e1ecd9168b2a8c7a57d4717) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/128152 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-04-18 14:50:39 +0000