summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-08-30bump product version to 7.5.6.2.0+libreoffice-7-5-6Christian Lohmaier
Change-Id: I0b600b99ad9d7ecf437453e572fd8552972f5ed7
2023-08-30editeng: fix crash in EditDoc::FindAttribsXisco Fauli
check pNode before calling EditDoc::FindAttribs. This is the only place where EditDoc::FindAttribs is called from See https://crashreport.libreoffice.org/stats/signature/EditDoc::FindAttribs(ContentNode%20*,long,long,SfxItemSet%20&) Change-Id: I3ed0724b1113965c09c66413987bb85777ec9a16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156097 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8bb505d3e16deed2c7bb5636cfd765013ec23965) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156213 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-08-30update creditsChristian Lohmaier
Change-Id: Ie682a8747bb5f51115815ccd0ac9e26a4c4c32f9 (cherry picked from commit 92d8c2cecd452374d17072b7d6fee09e0313ea85) (cherry picked from commit 00277350d7911bdf10991b1b0a5b9b4746641672)
2023-08-30reportdesign: fix crash in ORptExport::exportSectionAutoStyleXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/rptxml::ORptExport::exportSectionAutoStyle(com::sun::star::uno::Reference%3Ccom::sun::star::report::XSection%3E%20const%20&) Change-Id: Ibe5a6de1888728fba22f8cc0d128dcb04da9ede9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156096 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins (cherry picked from commit 12c0f4e4d1fad69f09d3ff30a65b18a68b817d90) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156133 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7775f4d4965b6ab94b18c2e046fd9b2edcabef12) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156149 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2023-08-30Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-5-6' to 111c411350d11ce7ec80dacfd95b436a64d725fc - update translations for 7.5.6 rc2 and force-fix errors using pocheck Change-Id: I8b807185e71557bd479b5a64eafb8f0d2a23b32d (cherry picked from commit e36b64c9337f7977d392e0144ba47cb4ad45c453)
2023-08-30tdf#156419 sw: layout: don't prevent moving between linked flysMichael Stahl
... when there is a page break on the next page. Of course you can put a section into a fly, and then link multiple flys. (regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525) Change-Id: I5cb854fc7ee5caa2af4e04f4da2d8a8083c0d007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155842 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 987fe1175de2db53235cc6f2441335fcc3548d64) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155845 Tested-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit a445d8bda04c5daf3bb2d86bd25e53bca2646c90) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155994 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-30tdf#156725 sw: layout: don't prevent moving between columns ...Michael Stahl
... on the same page when there is a page break on the next page. The existing, presumably pointless/always-false in case of same page, check of WrongPageDesc() let me assume that this would only be reached if the current page and the target page are different, but that was a mistake. (regression from commit 325fe7ab507fd8f2ca17a3db32181edf30169525) Change-Id: I4df53b77bed006095c34976011aa0cd5e12879e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155809 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit db83c41d460103df5d80f5bd99816575c4ead5cd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155844 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 5320df43d1631d47e89a0999fe1bb3da8661fe3c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155993 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-30sc: fix crash in ScTransferObj::DragFinishedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScModule::GetDragData() Change-Id: Ic5cdc3e1796fa20ac84150a04bed539bc9ca7321 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156094 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 8b022db4cd397fd88f8078fc7f5ff85f21635155) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156216 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-08-30sc: fix crash in ScAttrDlg::PageCreatedXisco Fauli
See https://crashreport.libreoffice.org/stats/signature/ScAttrDlg::PageCreated(rtl::OString%20const%20&,SfxTabPage%20&) Change-Id: I3f89cc917648462f819eb35461055096a6eb3853 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156093 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit c46f00166027fa3eefc75f9cb13bf4afc887bf1d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156214 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-08-30python3: upgrade to release 3.8.18Michael Stahl
Fixes CVE-2023-40217 Change-Id: Ie08af471009b7f5c42aa6875dd4f9d886ad1d617 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156183 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit c1586ef57b5770f80ef200ab38ff4538c2dfb145) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156145 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 563e7c857e3b370099915b3fb1d620edf216c197) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156215 Reviewed-by: <20001722@ymail.ne.jp> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-08-30crashreporting: crash seen in FormNavigatorCaolán McNamara
set_text(rVclIter.iter, rText, col); ... m_xTreeView->set_text(*xEntry, pNameChangedHint->GetNewName()); ... m_pNavModel->Broadcast( aNameChangedHint ); Change-Id: I31275dd37de0146eae2ebb0931a5450e34fd21fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155991 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> (cherry picked from commit 4f984b803230784c8a87f793f45c4e76e7a5987c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155996 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-08-30Related: tdf#144906 unset g_DragSource if drag end callback never calledCaolán McNamara
a scenario I can reproduce with alt+f4 while dragging from the navigator Change-Id: I7123602e036fbe15e0ae8f9a7e1d5fc7483dc6c7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156138 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 48e3c7c7b115c08af80752af8f7302447872300b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/156148 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-08-30tdf#156681: Revert "tdf#152048: Fix underline width for Kashida-justified text"Xisco Fauli
This reverts commit 43a5400063b17ed4ba4cbb38bdf5da4a991f60e2. The idea is to revert it in libreoffice-7-6 and libreoffice-7-5 branches only since tdf#156681 is fixed in master by 507a8745870e9a755be3a72f59c6e9a9d811fdcf "vcl: Use doubles for glyph item coordinates" This commit also reverts 34df6c92e513c5f428eff7c9cb1d6b9831eeb323 "tdf#152048: Add test" Change-Id: Id246c388df45d16b9bce86d1827949c644fc8517 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155969 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155972 (cherry picked from commit d6f25135126b6506543e14d0208aea253ea8d085) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155926 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-08-30sw: prevent crash in TextContrastCheckTomaž Vajngerl
Change-Id: Idc8740a275b9f49aca08d8a3add9a88f9d53a220 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/152012 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit c53a8284cf1740af7035b952fbc040a785117319) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155789 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7f51cf11bca0b1712bf0877007c99cc0bfcee074) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155910 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2023-08-28Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-7-5-6' to c48debc9f0d5f1a827a08f39f34cdaeedde98201 - update tranlsations for 7.5 and force-fix errors using pocheck Change-Id: I5f8f86a45f12df496d356de1750d857bf9848ccf (cherry picked from commit c14953e4cafca9a57ebc846ca1b7174c44c76bb5)
2023-08-23update creditsXisco Fauli
Change-Id: I9747388a7b1514a165b2e6aad3e211139a0e4633 (cherry picked from commit 3a3060f6eb1f6d66fe230f919e560c28987135be)
2023-08-16bump product version to 7.5.6.1.0+Xisco Fauli
Change-Id: I2304e6f9e8f418b7752eb07c4f35fc54a2e5e6e9
2023-08-16Branch libreoffice-7-5-6Xisco Fauli
This is 'libreoffice-7-5-6' - the stable branch for the 7.5.6 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 7.5.x release, please use the 'libreoffice-7-5' branch. If you want to build something cool, unstable, and risky, use master.
2023-08-16update creditsXisco Fauli
Change-Id: Ife0d509b91f17510e6a32494e6456fe7043781ec
2023-08-16tdf#151866 sw: layout: prevent deleting newly created SwSectionFrameMichael Stahl
A section frame is created so that content can move back from another page into it. Apparently only the pPrv frame is on the same page, and formatting it in SwFrame::MakePos() moves it backward, then CheckPageDescs() sees a page with only empty section frames on it and deletes the whole page. (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb) Change-Id: I4f8e4debd4bcf993c9355dcfc3ced779fe6732ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155467 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 2f9e67d1e70bdc45dfc59554547bc3730481a757) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155475 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-16tdf#156551 tdf#150606 sw: layout: only invalidate SwTabFrame if it...Michael Stahl
... wants to move back. In this document, the table 1709 splits across 3 columns of the section 1702 with 1 row each, and when its follows are invalidated in CalcContent(), the later SwTabFrame::MakeAll() of the 1st follow joins the 2nd follow and invalidates the size of the section frame, causing a loop. So only invalidate if that actually looks necessary. (regression from commit 59987d3c77ec7dbf59fbea9f47cc226f4e8903f9) Change-Id: I360c8f697a7666a19a08d8ebcabbcfa3a7cdf844 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155452 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit a9b19f78f3cdcbf5c949a85b45877e903114cc54) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155409 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-16tdf#156546 sw: fix infinite loop in SwUndoInsert::RedoImpl()Michael Stahl
The problem is that SwUndoSaveContent::MovePtBackward() sets the point of a shell cursor to the document body's start node, which is not a valid position for a shell cursor; FindParentText() then loops forever. The purpose of this appears to be to move the point temporarily somewhere where subsequent inserting operations won't move it further, so that it can be restored to the start of the inserted stuff. Refactor a bit to use a temporary SwNodeIndex instead, which should work as nothing should delete the node it's pointing to. (regression from commit d81379db730a163c5ff75d4f3a3cddbd7b5eddda) Change-Id: I471bcced1741c77c07239ed124d4fd39ff7a7515 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155227 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 2d96d69322ac18f53668b75397c8587f94cd043b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155239 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-16Update git submodulesXisco Fauli
* Update translations from branch 'libreoffice-7-5' to 9756b7f8b028c50832712e0c7c0870e009c4040d - update translations for 7.5.6 rc1 and force-fix errors using pocheck Change-Id: I03025237ce24eb43bc1b8db8e4eaa24fd5abde88
2023-08-15openssl: upgrade to release 3.0.10Taichi Haradaguchi
Change-Id: Iee5716bdd111e2f30cb38d48a86104da52872dd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155382 Tested-by: Jenkins Reviewed-by: Taichi Haradaguchi <20001722@ymail.ne.jp> (cherry picked from commit 72f28e12b15823197e42265af1f8dda21224c90a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155392 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 6ce475503dacf47a34be8b19678befafa37bbfb1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155394
2023-08-15tdf#154265 Disable automatic slide advancement when moving backwardsSamuel Mehrbrodt
When a slide has a 0 second automatic slide advance setting, and you move back to that slide, it would immediately move forward again. Only enable automatic slide advancement when moving forwards. Change-Id: I3c901bed5323569f5cf52aeca5b3227c87b6e539 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155663 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de> (cherry picked from commit 850b66f969834e61f3cb1a1ccd4bfc15f23d558f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155695 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-11tdf#156270: use double for width/heightXisco Fauli
Otherwise 0.313159 is rounded to 0 Regression from commit 99f43923b66a98b75c78a50577f19293aa480998 Author: Xisco Fauli <xiscofauli@libreoffice.org> Date: Tue Apr 18 14:37:32 2023 +0200 sw: fix divide by 0 Change-Id: Ib8bf0a770834e0ff73d215c27788df7a3b98404d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155561 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 6ab45e1e2b256880d2f05b6669eb196e83682a14) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155489 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-08update creditsChristian Lohmaier
Change-Id: Id87aa5eb32e5f60f2c6a3148d762475fe87d78f0 (cherry picked from commit a921c4121d21e166f08b08d2aada3d7ea82235c0)
2023-08-08tdf#139164: Revert "tdf#54908 Make selection active if there's a selectionKhaled Hosny
(Writer)" This reverts commit 87d5c863109f7991e3f2f3a1eb970c00d5a27bd5. Making Writer print selection only by default is not something people expect, and it is not the default in any other application. Judging by the number of duplicates, it seems to have caught a lot of people by surprise, which is not a good UX. Change-Id: Ia7c8928c474d3390d7f7fee6e0c2e504a41d51b8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155422 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org> (cherry picked from commit fed82c416aba3380b8c8931f7d8e0ec359e52a2c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155400 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-07Resolves: tdf#156411 listen to "value-changed" not "changed"Caolán McNamara
we were listening to "changed" and querying the "value", but the value isn't guaranteed to have changed while the contents are being edited, only when "value-changed" arrives. Change-Id: I077051555813df48adae4259aa9a93d39c360dc3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154927 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins (cherry picked from commit 6057cc1df797b980f3d1d917befcb3256f3a9fb6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155144 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-07tdf#155526 Remove Insert R2 in all casesLaurent Balland
When opening a file containing a Moving average trend line, addRegressionCurve is not used, then MayHaveCorrelationCoefficient property is not correctly set. This change modify this property in all cases. Update property in firePropertyChangeEvent() as it is not possible in constructor: JunitTest_chart2_unoapi fails in MeanValue as SolarMutex is not owned Add QA test Change-Id: I13bdb81239a7362431edcf28bfc38ac4820a7776 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153859 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit 6fc12ad600a1ee10253c269a5988907a2894be76) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155174 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-04tdf#145743 sw: don't delete empty page with ColLocked sectionMichael Stahl
In MakeFrames(), the new frames are inserted into a section frame, before an existing frame; the existing frame is MoveFwd() to the next page, so the call to CheckPageDescs() finds the page frame empty and deletes it, along with the section frame. Check the mbColLocked flag set by MakeFrames() to prevent it. (regression from commit b9ef71476fd70bc13f50ebe80390e0730d1b7afb) Change-Id: I4e02a85314adaf07794fd6b5447bd78d39597b8d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155266 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit bd996a23bc4780579fc17e23d8f9f16e2af60289) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155246 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-08-04Fix handling of float vs. double valuesStephan Bergmann
...which had been broken ever since f424e55b4e66ffbee5b34f45ef5ea18d77c4d15c "INTEGRATION: CWS sixtyfour11 (1.7.22); FILE MERGED" had merged the typelib_TypeClass_FLOAT case into the typelib_TypeClass_DOUBLE case, and which caused > ==612573==ERROR: AddressSanitizer: dynamic-stack-buffer-overflow on address 0x7fff4e6b0700 at pc 0x7f45a9d77d9e bp 0x7fff4e6af3f0 sp 0x7fff4e6af3e8 > WRITE of size 8 at 0x7fff4e6b0700 thread T0 > #0 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:155:51 (instdir/program/libgcc3_uno.so +0x118d9d) > #1 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 (instdir/program/libgcc3_uno.so +0x112c1e) > #2 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:330:13 (instdir/program/libgcc3_uno.so +0x10e333) > #3 in stoc_corefl::(anonymous namespace)::IdlAttributeFieldImpl::get(com::sun::star::uno::Any const&) at stoc/source/corereflection/criface.cxx:141:9 (instdir/program/libreflectionlo.so +0x1f89e0) > #4 in non-virtual thunk to stoc_corefl::(anonymous namespace)::IdlAttributeFieldImpl::get(com::sun::star::uno::Any const&) at stoc/source/corereflection/criface.cxx (instdir/program/libreflectionlo.so +0x1fc5fb) > #5 in cppu::PropertySetMixinImpl::Impl::getProperty(com::sun::star::uno::Reference<com::sun::star::uno::XInterface> const&, rtl::OUString const&, com::sun::star::beans::PropertyState*) const at cppuhelper/source/propertysetmixin.cxx:563:24 (instdir/program/libuno_cppuhelpergcc3.so.3 +0x7d5059) > #6 in cppu::PropertySetMixinImpl::getPropertyValue(rtl::OUString const&) at cppuhelper/source/propertysetmixin.cxx:994:20 (instdir/program/libuno_cppuhelpergcc3.so.3 +0x7e462f) > #7 in reportdesign::OFixedText::getPropertyValue(rtl::OUString const&) at reportdesign/source/core/api/FixedText.cxx:143:34 (instdir/program/../program/librptlo.so +0x7452ad) > #8 in non-virtual thunk to reportdesign::OFixedText::getPropertyValue(rtl::OUString const&) at reportdesign/source/core/api/FixedText.cxx (instdir/program/../program/librptlo.so +0x7452eb) > #9 in rptui::OPropertyMediator::OPropertyMediator(com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, com::sun::star::uno::Reference<com::sun::star::beans::XPropertySet> const&, std::__debug::map<rtl::OUString, std::pair<rtl::OUString, std::shared_ptr<rptui::AnyConverter>>, std::less<rtl::OUString>, std::allocator<std::pair<rtl::OUString const, std::pair<rtl::OUString, std::shared_ptr<rptui::AnyConverter>>>>>&&, bool) at reportdesign/source/core/sdr/PropertyForward.cxx:68:119 (instdir/program/../program/librptlo.so +0xbbbdb7) > #10 in rptui::OUnoObject::CreateMediator(bool) at reportdesign/source/core/sdr/RptObject.cxx:878:31 (instdir/program/../program/librptlo.so +0xc16451) > > Address 0x7fff4e6b0700 is located in stack of thread T0 at offset 4288 in frame > #0 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:50 (instdir/program/libgcc3_uno.so +0x1181d7) > > This frame has 3 object(s): > [32, 104) 'data' (line 53) > [144, 160) 'longs' (line 162) > [176, 192) 'doubles' (line 166) <== Memory access at offset 4288 overflows this variable > HINT: this may be a false positive if your program uses some custom stack unwind mechanism, swapcontext or vfork > (longjmp and C++ exceptions *are* supported) > SUMMARY: AddressSanitizer: dynamic-stack-buffer-overflow bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:155:51 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) > Shadow bytes around the buggy address: > 0x7fff4e6b0480: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x7fff4e6b0500: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x7fff4e6b0580: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x7fff4e6b0600: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x7fff4e6b0680: 00 00 00 00 00 00 00 00 00 00 00 00 ca ca ca ca > =>0x7fff4e6b0700:[04]cb cb cb cb cb cb cb 00 00 00 00 00 00 00 00 > 0x7fff4e6b0780: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x7fff4e6b0800: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x7fff4e6b0880: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x7fff4e6b0900: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > 0x7fff4e6b0980: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 > Shadow byte legend (one shadow byte represents 8 application bytes): > Addressable: 00 > Partially addressable: 01 02 03 04 05 06 07 > Heap left redzone: fa > Freed heap region: fd > Stack left redzone: f1 > Stack mid redzone: f2 > Stack right redzone: f3 > Stack after return: f5 > Stack use after scope: f8 > Global redzone: f9 > Global init order: f6 > Poisoned by user: f7 > Container overflow: fc > Array cookie: ac > Intra object redzone: bb > ASan internal: fe > Left alloca redzone: ca > Right alloca redzone: cb > ==612573==ABORTING when opening <https://bugs.documentfoundation.org/attachment.cgi?id=174542> Example2Fields.odb attached to <https://bugs.documentfoundation.org/show_bug.cgi?id=144072> "LibreofficeBase crashed when 2 fields selected in report builder from different sections and width is adjusted 2nd time" and clicking "Edit..." in the context menu of the "RptTasks" report. Change-Id: I318765aede68353d475a0d672e0aea36ed12af29 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155286 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 3bcc14b4e2b226f97e937ca7a152218f8276ee39) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155294 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-04tdf#156473 wina11y: Fix invalid write due to row/col mismatchMichael Weghorn
With the grid control now reporting row/column headers due to the previous tdf#156473-related commits, this copy-paste mistake in commit 8a4271e168f70f9147b567189c1770a243e7fcb1 Author: Michael Weghorn <m.weghorn@posteo.de> Date: Fri Aug 5 09:49:02 2022 +0100 wina11y: Implement IAccessibleTableCell::get{column,row}HeaderCells was now causing hard to debug crashes when moving around in the table from the tdf#156473 sample macro with the NVDA screen reader running on Windows. Change-Id: I9fa30c1181d0fd21a85a73fd660c49667850d82b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155311 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 2b30d37bd555188733a006e1a5796461ab11d326) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155297 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-04Resolves: tdf#155716 grab focus when context menu is activatedCaolán McNamara
Change-Id: I194aba413d5adf07c8d78823f2f9a086f95cf248 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154924 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2023-08-02tdf#156100 tdf#156561 Revert to previous behavior for gtk popupsMichael Weghorn
In order to fix announcement of items in the popups with at least NVDA on Windows, commit dc0706cabfe39ddb6ea23d60ccfb756f2b9e6efb Date: Wed Mar 15 17:00:27 2023 +0100 tdf#140762 tdf#152671 Make dock win visible before showing popup made sure that the dock window is made visible before the popup is shown. That's problematic for the gtk implementations, though. On issue was addressed with commit 70642bb7afd2cee6f7ae6eff2936a35978bd0597 Date: Thu Apr 6 15:07:15 2023 +0100 tdf#154470 try moving the Show of the client to after the float positioning , but there's still an issue for the RTL case (tdf#156100). To unbreak that while leaving the announcement with NVDA working properly, effectively revert to the original behavior for the gtk VCL plugins (which have their own implementation for popup handling) for now. Further analysis of the root causes is planned in the context of tdf#156561, so hopefully the code paths can be unified again in the future. (One issue is addressed by Change-Id I62ab32342ef67c770ced9f0d2be867dc9355bd4a, "tdf#156561 wina11y: Handle CHILD event", but that's not enough by itself.) Change-Id: Ie67bded6c380695866d5343dab9d3f563ada057a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155125 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> (cherry picked from commit 3bb762c53ea79f8915a1b8fa39f3f5f57aa68c84) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155148
2023-08-02fixing a typo in sqlbison.yjucasaca
schema_glement_list is not registered, son can't be used. schema_element_list is registered and defined and seems to be the correct Change-Id: I7661532707ce6ddb32b95629192e9ba9847f21df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154766 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Lionel Mamane <lionel@mamane.lu> Tested-by: Lionel Mamane <lionel@mamane.lu> (cherry picked from commit f8a312617838e8626e6e406791ad8d0aac368f23) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155171 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 930c5dd29995a8711a62b2bd13a3d59833d8470d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155182 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-08-02tdf#156548: make truncated long bookmark name unique, and use it in hyperlinksMike Kaganski
Change-Id: I156359339ff8be85fe90cb6612eafdc6030c851f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155092 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155129 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2023-08-01Update to curl-8.2.1.tar.xzStephan Bergmann
...obtained from <https://curl.se/download/curl-8.2.1.tar.xz> Change-Id: I7260f79e2f72501869ff58c77f0d9dfa3ebdece1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155116 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 85c07891ad9424661d8e1adb8e93364e3964ce34) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155133 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-01Resolves: tdf#156462 ctrl+left in calc doesn't always jump to the correct cellCaolán McNamara
since: commit 9e2d48b9e04f7ea895fb095699c32ed8a44eb129 Date: Wed Mar 30 11:58:04 2022 +0200 reduce Calc's INITIALCOLCOUNT to 1 but: commit a680f6988482f13489d6c802b6078d43564ae934 Date: Wed Jun 7 22:48:01 2017 +0530 tdf#50916 : More refactoring in table1.cxx is likely also relevant wrt: "If nCol is in the unallocated range [nLastCol+1, MAXCOL], then move it directly to nLastCol" If the cursor is outside the allocated column range then the search started 1 cell to the left of the last allocated column Change-Id: I854173ad13d50e50d85e9902b31585e8ae3e2c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154910 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-01tdf#156528: Fix handling PDF page scaling factor after large pagesMike Kaganski
The map mode wasn't set when current page's user unit was 1, which meant that it used the unchanged value from the previous page, where it could be different. Change-Id: Id1f1515dceac25cddc12081a86fabf8b32d633f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155025 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 0b6fc1fdcc67cc6e13ca3c0e4c81742a43488ed6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155141 Reviewed-by: خالد حسني <khaled@libreoffice.org> Tested-by: Jenkins
2023-08-01Correct Esperanto {eo} group separator formats wrong since initial 2005 commitEike Rathke
Instead of # ##0,00 and similar it used # #0,00 that probably went unnoticed since ever because it generates an expected display string using the group separator at the right position; editing such format yielded the format code ##0,00 with the group separator flag set. Change-Id: Id6ebb533f43a49a9aea1dd9ba87230e5d59901ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155114 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 613c3524eb798392040c691d5c0e17fac0b654b8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155048 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> (cherry picked from commit b6ed7c7be2a94777ee9b1c4a5ddf77e3f5343efe) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155142 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-08-01Adapt test code to cURL 8.2.0Stephan Bergmann
...for which CppunitTest_ucb_webdav_core would fail with > ucb/qa/cppunit/webdav/webdav_local_neon.cxx:60:(anonymous namespace)::webdav_local_test::WebdavUriTest > equality assertion failed > - Expected: ?query#fragment > - Actual : /?query#fragment and > ucb/qa/cppunit/webdav/webdav_local_neon.cxx:89:(anonymous namespace)::webdav_local_test::WebdavUriTest2 > equality assertion failed > - Expected: ?query > - Actual : /?query because of <https://github.com/bch/curl/commit/5752e71080cb3aafa8b24c3261419345b832bc92> "urlapi: have *set(PATH) prepend a slash if one is missing". All that test code had been added with b03e070420606d407df2ec5e9dfa7043ecc46177 "ucb: webdav-curl: fix CurlUri::CloneWithRelativeRefPathAbsolute()", and it looks harmless for our use cases that cURL started to behave differently there now. So instead of accepting either of the outcomes depending on what cURL version is being used, just change the test code to not leave out the path-absolute in the calls to CloneWithRelativeRefPathAbsolute (which is documented in ucb/source/ucp/webdav-curl/CurlUri.hxx to take > /// @param matches: relative-ref = path-absolute [ "?" query ] [ "#" fragment ] and path-absolute cannot be empty as per RFC 3986 "Uniform Resource Identifier (URI): Generic Syntax"). Change-Id: If07a28598dfa047ebe89d8bcda19e8fcaa36aed0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155099 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155134
2023-07-31tdf#153115 sw: SwDoc::TextToTable(), first remove all redlinesMichael Stahl
The problem is that there are redlines that overlap the created table cell nodes. For the writerfilter-import-API TextToTable() that was solved by splitting the redlines, but that would take a lot of effort here as it's not known ahead of time where the cells start and end, so just get rid of the redlines. Another issue is that the temporary SwPaM in DocumentRedlineManager::AcceptRedline() caused ~SwIndexReg() assert. (reportedly regression from commit 471212d464f54054f7419ef1890267d0def852d9) Change-Id: I6b211b6c8e5c7e4bdab1dac858707d7d7fd85029 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154655 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit cd20d9512aa4f9fbe39fce48b3c49cdb13cca6e6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154621 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-31tdf#149555 sw: convert RANGE_IS_SECTION SwXTextRange if possibleMichael Stahl
The writerfilter import got an exception in SectionPropertyMap::CloseSectionGroup() because XTextRangeToSwPaM() can't handle RANGE_IS_SECTION SwXTextRange. (regression from commit 7ab349296dac79dad3fec09f60348efcbb9ea17e) Change-Id: I38b37fdec64f4699c0fa1a090c72a8676ff386a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155026 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 0f39ecfed57f3f32d4f5cadf50b7dd9de77f8d7e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154969 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-31tdf#156372 sw: Stop adding GetLower to every cell in header tableSatya
The code was doubling the lower spacing of the last paragraph in every cell of the table. This change is to not add the space when in tables, since that was intended to only apply to the last paragraph in the header. Change-Id: Ia8c2b31e3e56302735e858c39f80cc35e190af6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154643 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155101
2023-07-31follow python recommendation and pass SSL contextsCaolán McNamara
i.e. https://docs.python.org/3/library/ssl.html#security-considerations Change-Id: I67a0f9e1c25abc6644412b014f30933a7e681da2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155016 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 7c1bc868c506dd505a70400e87c394f2263da085) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155033 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-31ScriptForge (SF_Session) fix SendMail() w/o attachmentJean-Pierre Ledure
Fix error message when no attachment is passed to the method. Execution will continue now without trouble. Change-Id: I447af45db97f086963027c131c6b5fb9dab93c7a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155066 Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins (cherry picked from commit 1e94999d6198258d1451584e96810bd8fb294653) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155040 (cherry picked from commit ec03e4833659eab7918c026ab9e60e83dbc8c5be) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155042
2023-07-29tdf#142600 - External links dialog: list database rangesAndreas Heinisch
Regression from commit 462f9d1f589a7afd66d3fc61925467d3b68e5b31 where the database ranges were dropped. Change-Id: Ic0e453fc6fe62849d72b6acf88ed7ebd3c47775b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155009 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 2f2cd7558e1d01f9670436412d62d03f28bab2c1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/155031
2023-07-27tdf#146258 sw: invalidate section frame for new text frame at startMichael Stahl
SwFlowFrame::CalcUpperSpace() uses the first text frame inside to compute the upper margin of section frames. Before commit 69d2d24b3579ad21fb1ba2746f81a02f8bbfb984 this was working because a temporary SwTextFrame for the new SwTextNode was created and then deleted again, but while it was alive the SvULSpace item was copied and then it invalidated the section frame: 1 SwFrame::InvalidatePrt_() 2 SwContentFrame::Modify() at libreoffice-6-1/sw/source/core/layout/wsfrm.cxx:2336 3 SwTextFrame::SwClientNotify() ... 7 SwTextNode::Modify() 8 SwContentNode::SetAttr() 9 SwTextNode::SetAttr() 10 SwAttrSet::CopyToModify() 11 SwTextNode::CopyText() 12 SwTextNode::CopyText() 13 SwTextNode::MakeCopy() 14 SwNodes::CopyNodes() 15 sw::DocumentContentOperationsManager::CopyWithFlyInFly() 16 SwIntrnlSectRefLink::DataChanged() Now however nothing invalidates the section frame, so do it in InsertCnt_(), hopefully it works for columned sections too. (regression from commit 166b5010b402a41b192b1659093a25acf9065fd9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154594 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 34b607bb455bd30d3adf8e3f72182c7cc4d062ee) [commit 34b607bb455bd30d3adf8e3f72182c7cc4d062ee used wrong issue id] Change-Id: I339286ac37c9ee9a0bef730a73215bc139386514 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154614 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-27tdf#153319 sw: don't move footnotes to follow if portions in masterMichael Stahl
SwTextFrameBreak::IsInside() may be called in different situations, during formatting it should be possible to move the footnotes, but when called from SwTextFrame::CalcPreps() this is problematic as it does not format the lines, it iterates over existing lines. The problem is that the footnote frame is moved to the follow's page, but the footnote portion remains on the master, and then the follow is joined while the footnote frame's mpReference still points to it. (regression from commit 391613785ae6fbb735cf7a86ea2f6a93161a8769) Change-Id: I4290dcd242a7f5292ad4f50c1407c9cd88e80a6a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154557 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 7e9b2b71db72b8c4c9c6ca83d08d3b6b05775ac8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154545 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2024-05-08 04:19:32 +0000