summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2023-07-10tdf#147999: Fix canvas font width for fallback fonts on WindowsKhaled Hosny
For some reason we are getting the wrong font width for fallback fonts, which results in rendering them squished. This happens only with VCL canvas, but not with DX one, so it shows when hardware acceleration is disabled (either explicitly or implicitly when Skia is enabled). Change-Id: I5a45b1c1d68f4c6e6dd6b43371602af3330a7cd3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154272 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-10svgio: remove recurrent checkXisco Fauli
Change-Id: I1b346007f5ae5e95b559cae1a9e8fdd3f4d93502 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154271 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-10tdf#149673: only check opacity from parent...Xisco Fauli
... if it has a local css style Because it's the first in the style stack Partially reverts 3e0e67a152e9631574e28dacb6e06a96f03ebca2 "tdf#155932: tdf#97717: only apply opacity when primitive" Change-Id: I6a6bf08a519c84ac58c6111fd7da308cbf8a3021 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154270 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-10tdf#156201: just check one level up in the style stackXisco Fauli
Otherwise, the parent might also have a local css style Change-Id: Ib6d1340045f22861aee3e526d22d014eeb2f5d38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154248 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-10tdf#146273 Do not allow non-numeric values for Navigator "Go to"Matt K
This change modifies "SwNavigationPI::EditAction" and adds a new "connect_changed" handler "PageModifiedHdl" to the spin control (needed to intercept text handling). In both functions we perform checks to ensure that only numeric values can be entered and only values within the page range of the document. This now matches the behavior of the "Go to Page" feature. To go to the first page, just enter a character input. To go to the last page, just enter a value higher than the total number of pages. Change-Id: Ia020d72f4bed5b98b668ba95888bc4bc1d65e07d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154156 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2023-07-10svx: prefix members of GeoStatMiklos Vajna
See tdf#94879 for motivation. Change-Id: Id8d116bfa375f7dd30ca8dcdec0ee02df8105030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154234 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-07-10fix build: SkiaHelper.cxx missed W on -Wunused-parameterJustin Luth
The error message was vcl/skia/SkiaHelper.cxx:75:32: error: ‘-unused-parameter’ is not an option that controls warnings [-Werror=pragmas] 75 | #pragma GCC diagnostic ignored "-unused-parameter" This fixes commit f8c15850dbfaa46605e1e353ae1f49e69184e8a1 for gcc (Ubuntu 9.4.0-1ubuntu1~20.04.1) 9.4.0 Change-Id: Iae927e6c794e09cdab2d0fbd30a84a631800c9a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154247 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-10Drop unused WinFontInstance scaleKhaled Hosny
Unsed since: commit 7cb3e475f2fb0162c7290414509de4fb8fe57e30 Author: Jan-Marek Glogowski <glogow@fbihome.de> Date: Thu Sep 6 14:04:25 2018 +0200 WIN add SalGraphics* to WinFontInstance Change-Id: I7d14f2efce04c919cffee612b09833810ff3f78b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154240 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-10Move SwXDocumentIndexMark Java tests to C++anfanite396
Change-Id: I3aa19a10af87a6a41c9538dd6d743a8656a3a0b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153557 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-07-10Move SwXBookmarks Java tests to C++anfanite396
Change-Id: Ia640c59c97889c27f1c7b3ecf3b2630ac1d5e1f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154231 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-07-10Move SwXAutoTextContainer Java tests to C++anfanite396
Change-Id: Ib785d9c1d143f0f51247ae73f01d9ee6d3806947 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154230 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2023-07-10Remove duplicated entryStephan Bergmann
...that had been duplicated by c2fb518a6889fa9beac2d7e512ce3dcbf06c6d85 "update Japanese font order list", apparently by accident Change-Id: I194f73668f0cc2d3f10931a9cb56a2f523ec6c89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154200 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2023-07-10tdf#99562: Do not ignore last column from matrixXisco Fauli
Change-Id: I1dff65963e2c414d1771a1592159930150c513e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154241 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-10update skia to m116Noel Grandin
(from m111) SK_SUPPORT_GPU is now SK_GANESH GR_OP_ALLOCATE_USE_NEW was removed in skia m111 commit dd8f8ed3848cbe2032edc7ec08ef648a23e28ad9 Author: Mike Klein <mtklein@google.com> Date: Thu Apr 22 12:17:33 2021 -0500 clean up defines that do nothing the fast-png-write patch was removed. The underlying helper function we need was removed in commit 0ec4c84abd0b578a5c792b04b56653cbc325530e Author: Kevin Lubick <kjlubick@google.com> Date: Thu Apr 20 14:46:28 2023 -0400 Remove SkImageEncoder and SkImage::encodeToData So I updated our dump() function in SkiaHelper.cxx to use the new Skia API. The constexpr-template patch seems to be superceded by skia changes. SkOpts: :hash_fn has been replaced with SkChecksum::Hash32 commit 657ed9cf2379a950b925cb2aba7c85d6e1dd36ed Author: Brian Osman <brianosman@google.com> Date: Tue May 23 12:40:12 2023 +0000 Reland "Replace SkOpts::hash/hash_fn with SkChecksum::Hash32" The SkDebugf function needs to be exported from the library since it leaks out to calling code via some of the headers. Change-Id: I80ace8f25e660fa7889d22ef90676f47264d866c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154223 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-10lok: remove old hack for LanguageTool localesSzymon Kłos
Change-Id: I1098c51f03b4cdd4f21a635f7b6aae8e90fd9f9f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146779 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153962 Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154162 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-10Fix typoAndrea Gelmini
Change-Id: Ic70380a7a3d8cefca5214ea70b87e92772535c6c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154232 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-10sw floattable: enable AddVerticalFrameOffsets compat flag for DOCMiklos Vajna
The bugdoc has a floating table, followed by an inline table. The inline table should be on the second page, but instead it's on the first page, overlapping with the floating table. It seems this works already for DOCX since commit 50223ea6e212b60b7d33839c2753c5601fb50f95 (tdf#98987 sw: add AddVerticalFrameOffsets compat mode, 2016-03-31). Fix the problem by enabling the same compat flag for DOC, since the intention was to have this on for Word formats in general. The original bnc#816603 bugdoc still needs more work, though. Change-Id: If9b4e1d3feeeaa24d6e84fea9a10ecdfd995c18f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154235 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2023-07-10tdf#156135 - Add "Go to" action for "Avoid floating text" issue typeBalazs Varga
Change-Id: Ie98f291141f38ac5544c9e51a209fb9bf1f26d1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154107 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <samuel.mehrbrodt@allotropia.de>
2023-07-10tdf#62032 use style list level when changing styleluigiiucci
If a style S1 has a list level L1, and we change the style to S1 in a text node that has list level L2, the new text node list level must be L1 Change-Id: Ic25b222202cb2da3153fc5c3723998c9f7f01247 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153161 Reviewed-by: Ashod Nakashian <ash@collabora.com> Tested-by: Jenkins
2023-07-09No need to clean up the desktop, when the process is finishingMike Kaganski
It will be cleaned up anyway. Change-Id: I67b936ee0d89280555e6d595fd53957952900057 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154226 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-09tdf#153804 DOCX import: fix lost footnotes in case of commentsLászló Németh
Incomplete handling of m_bIsFootnote had a conflict with XNote stream COMMENTS (i.e. not FOOTNOTES and ENDNOTES) since commit 96a856f87f16cca2e039c973c18d57c8b9dca362 in DomainMapper::lcl_checkId(), resulting lost (order or content) of footnotes, when were comments in the document. Regression from commit 96a856f87f16cca2e039c973c18d57c8b9dca362 "tdf#152206 DOCX import: fix mixed first footnote". Change-Id: I8d6901e8db1e183b959fecd350d6a263e79b5591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154147 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2023-07-09qt: Check for SAL_VCL_QT_USE_QFONT in a central placeKhaled Hosny
Change-Id: I7f0a2cf8daaf72de02261e2a9a5c3a70f5a42270 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154224 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-09tdf#151273, tdf#151925: Don’t use QFont text layout by defaultKhaled Hosny
We were enabling QFont for qt5 VCL plugin by default, but it is buggy and some distributions seem to enabled qt5 VCL plugin even if we don't recommend it. Since the QFont code is incomplete and no one is working on it, lets make people’s life easier by making it always off by default. This removed the SAL_VCL_QT5_USE_CAIRO envvar and replaces it with SAL_VCL_QT_USE_QFONT that does the reverse. Also SAL_VCL_KF5_USE_QFONT is dropped in favor of SAL_VCL_QT_USE_QFONT. Change-Id: Id7471acd12fe277908f567140b63ae8d27b03033 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154222 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-09cppunittester: use a dedicated desktop on WindowsMike Kaganski
Since introduction of accessibility tests infrastructure in commit 0185ddd6d5f0324ba57b3fa36229103a6b27138e (Add infrastructure and basic tests including slight UI interaction, 2022-08-01) and the respective tests, running 'make check' on Windows produces pop-up dialogs, while these tests run. These dialogs distract, steal focus, swallow text that I type elsewhere, and may fail the tests if accidental user input interferes with what the tests check. This commit creates a dedicated system desktop for cppunittests, which would be isolated from the active desktop, yet allow creation of windows, thus not preventing accessibility testing. This way, it workarounds unavailability of svp vcl plugin on Windows. Change-Id: I83db54c82bfe98d14171355cc19cdd5767549fdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154194 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-08ScriptForge - (SF_Calc) fix typo in CopyToRange() methodJean-Pierre Ledure
Change-Id: I07db487d94c2d0a8f2ec5955f6e94b00911d25c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154214 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins
2023-07-08tdf137553: Fix advance width for text using Graphite fontsKhaled Hosny
This is a HarfBuzz bug and it was reported upstream. Change-Id: Ibf945d30f57c7fb847b63c40f5a7b2903958ab89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154213 Tested-by: Jenkins Reviewed-by: خالد حسني <khaled@libreoffice.org>
2023-07-08Fix typoAndrea Gelmini
Change-Id: I00578ea5123709ad8eee02fb8bc0c9a58ae31af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154205 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2023-07-08make SID_ATTR_TRANSFORM_POS_* and SID_ATTR_TRANSFORM_ROT_* SfxInt32Item tooCaolán McNamara
to be consistent with findings from: commit c64828a1cf55e9252e7acd236e3331f2635ae249 (origin/master, origin/HEAD) Date: Fri Jul 7 17:05:10 2023 +0100 ubsan: SID_ATTR_TRANSFORM_POS_X is SfxInt32Item not SfxUInt32Item Change-Id: I6c50e4d5363ff9d79b459abb6192f2cedb39709e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-08tdf#155705 sw a11y: Only handle paragraph's own spell check dataMichael Weghorn
When a paragraph is split across multiple pages, there are multiple accessible paragraphs on the accessibility layer, but there's still just a single text node in the underlying Writer core model. The `sw::WrongListIteratorCounter` used in `SwTextMarkupHelper` is for the whole text node, i.e. iterates over the spell check data from other pages (i.e. other accessible paragraphs) as well in that case. This caused invalid indices to be used when calculating the index within the current accessible paragraph again when iterating over all elements, causing a crash. Fix this by filtering out the elements that are outside of the accessible paragraph when handling markup information. Change-Id: If76cc60cc9ff5614d0bcbaff196ac34ec908936e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154109 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-08tdf#155705 sw a11y: Unify iterator use in SwTextMarkupHelperMichael Weghorn
Introduce a new helper method `SwTextMarkupHelper::getIterator` to get a `sw::WrongListIteratorCounter` and use that to deduplicate and unify handling in three methods. Change-Id: I81790c547f70f0649ce800bc481db70982dfa742 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154108 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2023-07-07give fodt2pdffuzzer more rope to play withCaolán McNamara
Change-Id: I30ee4e76e1ffb8cdec989f81d5bb43ed7bf7529e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154204 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-07ubsan: SID_ATTR_TRANSFORM_POS_X is SfxInt32Item not SfxUInt32ItemCaolán McNamara
in online, insert smiley face in to calc and drag it around the spreadsheet include/svl/itemset.hxx:162:20: runtime error: downcast of address 0x603001c19b30 which does not point to an object of type 'const SfxInt32Item' 0x603001c19b30: note: object is of type 'SfxUInt32Item' 00 00 00 00 68 3c 7a e8 56 7f 00 00 01 00 00 00 68 27 00 be 9e 2e 00 00 be be be be 2b cd bc 9c ^~~~~~~~~~~~~~~~~~~~~~~ vptr for 'SfxUInt32Item' SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior include/svl/itemset.hxx:162:20 in Change-Id: Icb4f86104e804d697d1b71822ee224fa08f7519a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154191 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2023-07-07gtk3 a11y: Use sal_Int32 consistently to fix i386 buildMichael Weghorn
... after commit 3b7db802731826b6cc3b55100470b0c61c1f2dfa Date: Thu May 4 10:06:14 2023 +0200 tdf#105404 [API CHANGE] add index to accessiblity change event Reported to fail like this: /home/rene/LibreOffice/git/libreoffice-7-6/vcl/unx/gtk3/a11y/atklistener.cxx:164:6: error: no declaration matches 'void AtkListener::handleChildAdded(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>&, const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, sal_Int32)' 164 | void AtkListener::handleChildAdded( | ^~~~~~~~~~~ In file included from /home/rene/LibreOffice/git/libreoffice-7-6/vcl/unx/gtk3/a11y/atklistener.cxx:29: /home/rene/LibreOffice/git/libreoffice-7-6/vcl/unx/gtk3/a11y/atklistener.hxx:54:10: note: candidate is: 'void AtkListener::handleChildAdded(const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessibleContext>&, const com::sun::star::uno::Reference<com::sun::star::accessibility::XAccessible>&, int)' 54 | void handleChildAdded( | ^~~~~~~~~~~~~~~~ Change-Id: I03caa5480ef133091ccd5c9ae682629cec3a789b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154190 Tested-by: René Engelhard <rene@debian.org> Reviewed-by: René Engelhard <rene@debian.org> Tested-by: Jenkins
2023-07-07lok: LanguageTool provides list of languagesSzymon Kłos
- it sends supported list to the LOK client - disables Spell Checker for locales supported by LanguageTool - duden protocol supports only german - initialize language tool config before usage to fetch correct list of supported languages Change-Id: Id9de8519303774163721def8661fa408da449348 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146665 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153960 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154161 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-07Prolongate hide timeout in call to Help::Show*, when reusing existing windowMike Kaganski
Otherwise, when moving mouse, and the tooltip follows it and updates its content, it would still hide after the initial timeout, only to re-appear on the next move. Change-Id: I3c93240f752301f2a86acabce54fe735d6e06550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154163 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-07tdf#153472 vcl: PDF/A export: produce valid XMP metadataMichael Stahl
* historically the PDF export claimed to produce PDF/A-1a, which was removed from the UI in commit ed4a0eed82e2f29e8163a445db992d22c6d07134 "tdf#62728 add PDF/A-2 support, change UI default to use that", and then reintroduced, presumably intentionally changed, as PDF/A-1b in commit 49cfcf777d03abf59557cad021b4e5c4445de3c0 "tdf#62728 Provide both A/1 and A/2 in PDF export dialog" Adapt the XMP metadata to always write "B". * if PDF/UA is enabled, veraPDF complains about the added pdfuaid:part: Specification: ISO 19005-2:2011, Clause: 6.6.2.3, Test number: 7 All properties specified in XMP form shall use either the predefined schemas defined in the XMP Specification, ISO 19005-1 or this part of ISO 19005, or any extension schemas that comply with 6.6.2.3.2. Change-Id: I77b9fb728476e85830e3771135ac5a269e96b306 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154169 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-07Update git submodulesChristian Lohmaier
* Update translations from branch 'master' to 99b28edb4e0f6459eca71faa64df163a63618bdc - update translations for master/7.6.0 rc1 and force-fix errors using pocheck Change-Id: I30df4b585f12a47e377eeaf1d6f07346aca1631a
2023-07-07related: tdf#155735: clamp RGB valuesXisco Fauli
So when a green matrix is used, everything becomes green. Also set alpha to 1.0 so at least a green matrix on black returns green and not black Change-Id: I9104c7511545fb244750b066bb1e996b6ce229f2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154167 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2023-07-07tdf#152484 cui,sw: if decorative is enabled, disable title/descriptionMichael Stahl
... in sw Frame Properties dialog and cui SvxObjectTitleDescDialog. Reportedly Word behaves weirdly if decorative is set and a description exists at the same time. Change-Id: I9fa149127bacc3567486334a14f42b05871a629f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154165 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2023-07-07Related: tdf#155708 Clean-up left over nCloseResponseToJustHideBalazs Varga
cont int variable in dialog header. Follow up (Clean-up) of a5c61b143d53bb10430b8a486874856c16a2d86c Change-Id: I13ddbad581ee920a72726e18ccb9e7daf4eb7887 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154164 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga.extern@allotropia.de>
2023-07-07Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 8bd42f2c52d4290b41ea5a0304184e2810098a09 - Fix typo on pagenumbering.xhp Change-Id: Ibdd64e92e7630707e97bff32764c72e952462f71 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/154175 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2023-07-07combine PixelToLogic+LogicToPixel into LogicToLogicNoel Grandin
avoiding some precision loss Change-Id: I946f4f820321f76fb7634c722a28035600bac359 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154157 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2023-07-07lok: remove duplicated locales for LanguageToolSzymon Kłos
Change-Id: I8fd1632f36a6c2c2d61331d6ce5dbd3cce83e2a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/146776 Reviewed-by: Henry Castro <hcastro@collabora.com> Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153961 Reviewed-by: Andras Timar <andras.timar@collabora.com> Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154155 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-07Load the locales from config file for languagetoolMert Tumer
Locales needs to be read again in the Preferences/Writing Aids section and since this is a network operation it can cause a problem. Better to list all the supported locales in the xcu and load it right away. Signed-off-by: Mert Tumer <mert.tumer@collabora.com> Change-Id: I2ced6789df2a1d6fa2996e2d6b7d2a18e266afac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154154 Tested-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-07tdf#69183 Pasting a table in Writer no longer inherits list formattingMatt K
The entry point of the paste is in SwFEShell::Paste as stated in the bug comments. This code calls "rClpDoc.getIDocumentContentOperations().CopyRange" which calls "DocumentContentOperationsManager::CopyImplImpl". In that function, there is a check for whether to propagate the formatting of a previous list in the document. All we do is add a check there to see if additionally it is a table we are pasting, and if so to ignore propagating the list format. Change-Id: I655f54c4df44385fc82976b37d3e21b5fabf45ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154149 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2023-07-07lok: formulabar: use position sent from clientSzymon Kłos
Change-Id: I0877cd9d5a5ba0319701e50bd5b9e5d63b23becd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153717 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Henry Castro <hcastro@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153988 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-07jsdialog: enable Insert Title Page dialogSzymon Kłos
we need to weld also RB_INSERT_NEW_PAGES so when we check it - JSDialog executor will make it active and RB_USE_EXISTING_PAGES inactive Change-Id: I0abc5b6610e301abb1d24ecea680f63358dc5584 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153189 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/153987 Tested-by: Jenkins Reviewed-by: Szymon Kłos <szymon.klos@collabora.com>
2023-07-07Fix .uno:CharBackColor status updateMaxim Monastirsky
We have the editeng pool set as our secondary, and it maps SID_ATTR_CHAR_BACK_COLOR to EE_CHAR_BKGCOLOR, which then can't be found in the switch in SwTextShell::GetState. But handling EE_CHAR_BKGCOLOR here will be very confusing for anyone reading this code, so let's map it back to the slot id. Without this fix, the current highlighting color isn't preselected in the toolbar dropdown. Change-Id: I85e5ceb6d2193f831928f224577d6f87e889981f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154102 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-07-07reportdesign: Fix setting font color from the toolbar dropdownMaxim Monastirsky
Seems like a recent regression from changing the argument name in PaletteManager::DispatchColorCommand. Change-Id: I2756a2c615398d40b15991cad2982cc80d6f6a99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154150 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2023-07-07Some refactor to combine code deciding bNoDelay valueMike Kaganski
Change-Id: Ie04288c14801dfc8090ed8bd92a85e426a66d654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/154153 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>