summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2024-02-09Version 24.2.1.1, tag libreoffice-24.2.1.1libreoffice-24.2.1.1Christian Lohmaier
2024-02-09bump product version to 24.2.1.1Christian Lohmaier
Change-Id: I8e914045c39aa05905d5ab17d0f1bf3b4a72b972
2024-02-09Branch libreoffice-24-2-1Christian Lohmaier
This is 'libreoffice-24-2-1' - the stable branch for the 24.2.1 release. Only very safe changes, reviewed by three people are allowed. If you want to commit more complicated fix for the next 24.2.x release, please use the 'libreoffice-24-2' branch. If you want to build something cool, unstable, and risky, use master.
2024-02-09tdf#159641 TreeView repaint problem with PgUp in kf5/genNoel Grandin
regression from commit be53f32655973c7a18824d5145eed992be788d2f Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Thu Mar 12 13:55:55 2020 +0200 rename vcl::Window::Update to PaintImmediately Change-Id: I74fc87e984e1f085d2351cbae033e51920608e3d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163154 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit 30fb8cde7579fb5da15c1d8da9611198f2f5ce78) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163149 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-02-09tdf#158586 writerfilter: RTF import: fix assert on ooo113308-1.rtfMichael Stahl
warn:legacy.osl:::writerfilter/source/dmapper/DomainMapper_Impl.cxx:1278: section stack already empty DomainMapper_Impl.cxx:9817: void writerfilter::dmapper::DomainMapper_Impl::substream(): Assertion `m_aContextStack.size() == contextSize' failed. Before substream(), there is one CONTEXT_SECTION, after there is an additional CONTEXT_PARAGRPAH. The first OSL_ENSURE is because RTFDocumentImpl::tableBreak() calls endParagraphGroup() but in the substream, startParagraphGroup() hadn't been called; fixing this also makes the assert failure go away. This worked previously because sectBreak() called endParagraphGroup() after reading the header substreams, but it seems dubious that a paragraph group started in the body should be used in the substream. (regression from commit 57abad5cf990111fd7de011809d4421dc0550193) Change-Id: I98864bca03b59099c17080c0a7582de2b77d41e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163096 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 6446d3e12440be39e6b55f8749038061a1b240da) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163137 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-02-09Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-24-2' to a90a713acbaa675695628c7553fbfc65d3847c30 - update translations for 24.2.1 rc1 and force-fix errors using pocheck Change-Id: I433166ed6b62867bae2999cd5c7130dd386b3cec
2024-02-09crashtesting: still seeing occasional impl_notifyEvent_nothrow failuresCaolán McNamara
e.g.: #0 0x00007f5a3a5d45fc in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent>::operator()(com::sun::star::uno::Reference<com::sun::star::document::XDocumentEventListener> const&) const (this=this@entry=0x7f5a38ffd680, listener=empty uno::Reference) at include/comphelper/interfacecontainer3.hxx:253 #1 0x00007f5a3a5d9427 in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::forEach<comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> >(comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::NotifySingleListener<com::sun::star::document::DocumentEvent> const&) (this=this@entry=0x7f5a3035ea08, func=...) at include/comphelper/interfacecontainer3.hxx:275 xListener = empty uno::Reference iter = {rCont = @0x7f5a3035ea08, maData = {m_pimpl = 0x7f5a30132260}, nRemain = 1} #2 0x00007f5a3a5d950e in comphelper::OInterfaceContainerHelper3<com::sun::star::document::XDocumentEventListener>::notifyEach<com::sun::star::document::DocumentEvent>(void (com::sun::star::document::XDocumentEventListener::*)(com::sun::star::document::DocumentEvent const&), com::sun::star::document::DocumentEvent const&) (this=this@entry=0x7f5a3035ea08, NotificationMethod=<optimized out>, Event=...) at include/comphelper/interfacecontainer3.hxx:290 #3 0x00007f5a3a5d39f9 in dbaccess::DocumentEventNotifier_Impl::impl_notifyEvent_nothrow(com::sun::star::document::DocumentEvent const&) (this=this@entry=0x7f5a3035e9c0, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:200 __func__ = "impl_notifyEvent_nothrow" #4 0x00007f5a3a5d3b83 in dbaccess::DocumentEventNotifier_Impl::processEvent(comphelper::AnyEvent const&) (this=this@entry=0x7f5a3035e9c0, _rEvent=...) at dbaccess/source/core/dataaccess/documenteventnotifier.cxx:233 rEventHolder = <optimized out> #5 0x00007f5a57cd95ba in comphelper::AsyncEventNotifierBase::execute() (this=this@entry=0x7f5a3010f670) at comphelper/source/misc/asyncnotification.cxx:139 so lets guard the OInterfaceIteratorHelper3 ctor. might as well use empty() to return early then, and align the OInterfaceIteratorHelper4 case with that. Change-Id: I138841840e032e6524792fb75168ccabc666b34c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit dd8dad09097225726cbcd878d95d5bd0aacdf042) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163101 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-09calc null-derefCaolán McNamara
probably seen after a sheet was deleted /lib/x86_64-linux-gnu/libc.so.6(+0x42520)[0x7f259a642520] /opt/collaboraoffice/program/../program/libsclo.so(+0x5b3db8)[0x7f25873b3db8] /opt/collaboraoffice/program/../program/libsclo.so(+0x4964a1)[0x7f25872964a1] this looks most likely: 00000000005b3db0 ScTable::ContainsNotesInRange(ScRange const&) const 0000000000496440 ScDocument::ContainsNotesInRange(ScRangeList const&) const Change-Id: Ib019fe8abc18538eee7096e1fe5589e83e4849da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163136 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 1fd89488d282cad8386af12064876f8ba0ac2956) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163145
2024-02-09tdf#158279 TOC links lost when converting .doc to HTMLNoel Grandin
regression from commit 8ce36e943f0e50970925b2dd77729ef6036b4a49 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Sun May 26 15:15:41 2019 +0200 move some searching inside IDocumentMarkAccess where I called the wrong method from inside Writer::FindPos_Bkmk The code was then removed in commit 7bad1516c5f2a85b5bae3f49261ac2494cbb7162 Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Wed Jul 17 05:41:08 2019 +0200 loplugin:unusedmethods Change-Id: I3f1e14a1e3ae2dd134738363e6b2679d2a2f418a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163095 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 0a32def8b519461b35b1e249d71ae9961b04400a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163029 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-09tdf#159478 read field comment in default encodingOliver Specht
If a symbol font is applied inside a field the command string was wrongly converted as symbol text. This is fixed by using a default RTL_TEXTENCODING_MS_1252 encoding. Change-Id: I11326ef3c79d6d74c720a2b4ac4987ee6716d912 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162844 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163120
2024-02-09tdf#159572 select font according to recent settingsOliver Specht
selection of a recently inserted special character applies the stored font to make sure the character is not inserted wit a font that doesn't contain the symbol Change-Id: Id61bfac3a2ff22dbdae8a5b83f000d3f0c3e992b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163004 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163128 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-02-09tdf#159560 paragraph break should be shown as pilcrow signOliver Specht
When non-printing characters are switched on at the end of the paragraph a pilcrow sign is shown. This is displayed using the font at the end of the character. If a symbol font is used that would result in a random symbol instead of the pilcrow sign (0x00b6). This is fixed here. Change-Id: I0d4ae9f439d2e34ca774d4e2cb188e94290808a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162983 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> (cherry picked from commit 297b47a7e0c191be22f90ab799b4b8bb8bdbaf59) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163142 Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de>
2024-02-09tdf#43848 fix selection in table with split/merged cellsOliver Specht
extends the selection of table cells to reach a more rectangular selection area Additionally tdf#155670 is taken care of by not showing the row selection cursor if row selection is not supported Change-Id: If31aa1030c91d81bc889d8aaa668e96c5328f03f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162508 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit aacf6f0e6059a3b24451da2782e0a0a420e89679) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163143
2024-02-08tdf#159483 sc HTML import: handle data-sheets-value attribute for the bool caseMiklos Vajna
Copy a cell with boolean TRUE and FALSE from google docs to Calc, the paste result is a TRUE and a FALSE string. The problem is that boolean is meant to be a float 0 or 1 with custom cell format, but we don't build this doc model. Fix the problem by ParseDataSheetsValue() to write the properties of the cell similar to what the normal HTML import would extract from our own markup, like: <td height="17" align="right" sdval="1" sdnum="1033;0;BOOLEAN">TRUE</td> This requires passing around both the value and the numbering properties, since the cell format just decides it's a boolean, but the cell value will decide if it's TRUE or FALSE. Change-Id: Id558ced56e02bbe24330d82c3998b047dc8febdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163108 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit f8c95cf93ce9ab8b9b78f3af03411d0cc2e195ba) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163144 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-08tdf#159595: Data validation without error check allows to enter wrong dataJulien Nabet
Change-Id: If5660f462a07ca571e05a44abcb0e378b6de613e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163064 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 9925937bb6b9be70befb8886ccc5665eff4ef227) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163020 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-08tdf#159254 import paper bin/paper source from rtf/docx filesOliver Specht
Imports \binfsxn and \binsxn from RTF and w:paperSrc from docx files and applies paper tray to the page style if the printer supports the imported tray value. Works only on Windows. Change-Id: Ie1170c58f7114f0dbf6bdd2721d4e077886cbe16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162236 Tested-by: Jenkins Tested-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163119
2024-02-08tdf#159601, tdf#159594: reuse target for symbols' childrenXisco Fauli
Regression from e7186b49a9a0b24ddc3b1c5384b5d9facb03518c "tdf#158445: support viewBox in symbol elements" Change-Id: Ie2198c47149def17fa3cb612046b61bf32e873bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163046 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 8b7dbf40a06bc900562887889c17606ae5ef0587) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163015 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-08improve loplugin:cow_wrapperNoel Grandin
some stuff was hiding inside templates Change-Id: I89fd1a926dd6bf96e35a74e5028165acae51c60c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162159 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163100 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-08tdf#159483 sc HTML paste: handle data-sheets-value here, tooMiklos Vajna
HTML import into Calc could already create text cells, but HTML paste with the same content remained auto-converted to numbers unconditionally. Turns out HTML paste goes via ScHTMLLayoutParser instead of the HTML import's ScHTMLQueryParser, so the data-sheets-value was ignored for paste. Fix the problem by extracting the old data-sheets-value handler from ScHTMLQueryParser to a separate ParseDataSheetsValue(), and use it also in ScHTMLLayoutParser. For the actual handling, still only text is handled, no other formats yet. Change-Id: I0b2bf4665af331d07624ed42e30a24e31bfca331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163068 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 543e52481e764b8e0eea6cf0123a77cf492bdf8e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163130 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-08CppunitTest_sw_a11y: disable test on Win ( 24.2 only )Xisco Fauli
This test fails in tb88-win when compiling libreoffice-24-2 branch but not with master branch, so disabling it just in the affected branch. Why it fails in one branch and not in the other is a mistery Change-Id: Iec37ffe5f90689012f4fc3041075cbe0b6dbd002 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163118 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-08tdf#159637: fix position of 'Windows Share' entryXisco Fauli
Started to happen after commit b91daea3c1a38883c06cdd63c6eababe1df9e61d Author: Michael Stahl <michael.stahl@allotropia.de> Date: Tue Nov 7 13:20:21 2023 +0100 tdf#146386 fpicker,svtools: remove FTP from Remote Files dialog Change-Id: I6ae78f96c1a1271de8cb2f0f114b92c3c213a068 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163115 Tested-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit a381e87d16496d9fee98d9ff49fa2a38cc5c8fb2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163140 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-08tdf#158440: do not extend transparent colorHenry Castro
Avoid to extend the area of transparent colors. Signed-off-by: Henry Castro <hcastro@collabora.com> Change-Id: Ie492e6fea2c3d8b785cfbb96fe7cfc31d87b9996 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163030 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit c44e12ddb952c78dd08aba1774863554d7ecc7fa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163024 Tested-by: Jenkins
2024-02-08Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-24-2' to 38966f0e280afefd34fa9ea29ee32af932450be0 - update translations for 24.2.1 rc1 and force-fix errors using pocheck Change-Id: I1f5249691eb8653b1c7437b927b9a0d8df5d2d31
2024-02-08Update git submodulesTaichi Haradaguchi
* Update helpcontent2 from branch 'libreoffice-24-2' to 1eed95f9a3d99dc12aa83fecbf7767630dfb79bd - Fix link to graphic_size_check page Fix a bug that the "Help Page Not Found" page is displayed when the Help button in the "Graphic Size Check" dialog is clicked. Change-Id: I6bf7c568b5f0dafc5d21de49d950b074cc09f442 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162645 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org> (cherry picked from commit 10c11a706ac08e4324a9439e42c748417c0e7f47) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/162898 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-02-08tdf#159458: make sure to update unexpanded URL when renaming libraryMike Kaganski
1. If passed new source URL is expanded (i.e., trying to expand it in SfxLibraryContainer::checkStorageURL didn't change it), previously aUnexpandedStorageURL was unchanged. It should be cleared - then it will be set automatically to the URL to lib info file. 2. Try to create the "variable" path (starting with "$(USER)/basic/") because this avoids absolute paths to the libraries, which make it harder to move the profile. Change-Id: Ie83ea9a32cfddf37727d238547663aeb72487ee3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162777 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 907d4107896234b2e7ebfd42f40cee3bd5b1d01e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162728 Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-02-08tdf#158326 - Auto Filter: separate sorting and removing of duplicatesAndreas Heinisch
Change-Id: Ide74895508af280f4b0c129689d852635e62dbff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160052 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit 6d0fddb697fd619d11da3469f4dd72782334f3bb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162891 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-08LOK: disable popup bubble for hyperlinksAndras Timar
Change-Id: I0ca21a90561affa453bd249c86e58793618f809e (cherry picked from commit 88fea772610a4feef018ba03fd19749841772225) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162287 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-02-08tdf#158740 fix crash by checking the end node's indexPatrick Luby
I don't know why m_nEndNode is larger than the size of the node array, but adjusting m_nEndNode to the last element in the node array stops the crashing. Change-Id: I425589457c6729b6689a7046f063154a2496e811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162035 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 9bfd8e69385930d8f558c767f7b29149324d1b70) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162211 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com>
2024-02-08missing dependency in CppunitTest_sw_a11yXisco Fauli
Similar to 41c9b2a81e9eb795aaecc8c52a8e7bce0a5a3c07 "missing dependency in CppunitTest_test_a11y" Change-Id: I4dc9d0a5c59dc95e68fd489b3e672ef6ed14355a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163112 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2024-02-08tdf#159581 sc: fix multi-sheet ScDocRowHeightUpdaterJustin Luth
Apparently it was caching the first sheet's row height, and applying it to every other sheet. AFAICS, the only time this ever ran against multiple sheets was during import time, so that is why it wasn't easily noticed before 24.2 when XLSX started using it on import. make CppunitTest_sc_subsequent_filters_test2 \ CPPUNIT_TEST_NAME=testTdf159581_optimalRowHeight Change-Id: Ic4e4dd335fa48d02acbc85cfad35feb8eca7597b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163066 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> (cherry picked from commit 9778d499df3d081314295ae099463870146b7a9c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163027
2024-02-08missing dependency in CppunitTest_test_a11yNoel Grandin
found while doing other builds - if the build ordering is very unlucky, acc is not built when this runs, the dynamic load fails in the accessibility factory fails, and we fall back to using the DummyAccessibilityFactory instead of the real one and the test will crash. Change-Id: Ic16fdbe17d50c6be26b5627a4f515c91e1f7f609 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163091 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 41c9b2a81e9eb795aaecc8c52a8e7bce0a5a3c07) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163026
2024-02-07ofz: Use-of-uninitialized-valueCaolán McNamara
keep a high water mark of the highest initialized level Change-Id: Ib799331c523209c4f165dc4c40317e25b6b0cc7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162624 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-07Don't reuse CertificateChooser instancesPatrick Luby
Reusing the same instance will, in the following case, lead to a crash. It appears that the CertificateChooser is getting disposed somewhere as mpDialogImpl in its base class ends up being null: 1. Create an empty Writer document and add a digital signature in the Digital Signatures dialog 2. File > Save As the document, check the "Encrypt with GPG key" checkbox, press Encrypt, and crash in Dialog::ImplStartExecute() Change-Id: I9aaa1bd449622e018b502d68c53d397255a1b61a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163065 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> Reviewed-by: Patrick Luby <guibomacdev@gmail.com> (cherry picked from commit f0a5cb1f77496d212a90b5303a9f4be8b8c0e283) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163025
2024-02-07tdf#157042: Revert "re-apply "optimize ConfigurationProperty::get()""Xisco Fauli
This reverts commit 3a4a00a51acca8f9b5e775547abff0c4dc9144d7. it's causing https://crashreport.libreoffice.org/stats/signature/%3Cname%20omitted%3E in libreoffice-24-2 branch ( See https://bugs.documentfoundation.org/show_bug.cgi?id=157042#c36 ) In previous branches, it was reported as https://crashreport.libreoffice.org/stats/signature/void%20rtl::str::release%3C_rtl_uString%3E(_rtl_uString*) See comment in 7b46c77366fb3effd2de9bf5ba11ebd3c064974a "tdf#157042: Revert "re-apply "optimize ConfigurationProperty::get()"" Change-Id: I3481c05b12b422404a38f0be1fea1ea69ffd0e46 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163061 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2024-02-06LanguageTag ctor can canonicalize against various known tagsCaolán McNamara
so can optimize skipping the _lt_tag_canonicalize path which ends up using a fairly expensive xmlXPathEval Change-Id: Ie96f16482d247f3731c1c8eac6d613736b8b289a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162596 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com> (cherry picked from commit 313836d19f46d0e046d1c2b8c593727b0b0192ea) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162814
2024-02-06tdf#159015 sw: layout: fix infinite loop in ::CalcContent()Michael Stahl
SwObjectFormatter::FormatObj() will just return if IsAgain() is set, so the while loop here won't make any progress. (regression from commit 191babee4f0ec643b80e96b0cd98c2d04ff96e4e) Change-Id: I1c194b148760ae05cf4dee1d5729be28e87d6ba0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162880 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 13865c4da30a3a2a5ab8efbd568c47952d3ffcee) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162894 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06tdf#123968 sw: fix assert on importing ooo62823-1.sxwMichael Stahl
svl/source/items/itemset.cxx:662: const SfxPoolItem* implCreateItemEntry(SfxItemPool&, const SfxPoolItem*, bool): Assertion `pSource->Which() == nWhich && "ITEM: Clone of Item did NOT copy/set WhichID (!)"' failed. XMLVariableInputFieldImportContext::PrepareField() first sets "Input" and then "SubType" property. Apparently i missed that *both* of these are mutable in the API, and both together determine whether the field is a RES_TXTATR_INPUTFIELD or RES_TXTATR_FIELD. So call SwXTextField::TransmuteLeadToInputField() also when the "SubType" is set, and adapt it to toggling 2 different things. Hmm... actually this will change these fields to be inline editable after ODF import, which was the intention all along. It turns out that there is even a unit test testTdf123968 for this; it works in the usual case, but in this case the input field is in a header, so in styles.xml, and the styles.xml is imported before content.xml and does not contain the variable-decls element, so the variable field type has the GSE_EXPR subtype (default?), and setting the "Input" property doesn't transmute it. (regression from commit 742baabbe4d077e1ba913a7989300908f4637ac7) Change-Id: Ib5757cda32287e51651f05f5b19e82d7be0431e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162941 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 99055ae98ef1fe67b8db4a8c3167a8acaeaac02f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163012 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06tdf#159507 editeng: support pasting HTML fragmentsMiklos Vajna
Commit ce53519f025158f8f64a4e8603c8c6e0dc35473a (cool#8023 editeng: support HTML paste, 2024-01-24) added support for pasting HTML files into Calc cells while editing, but this doesn't work when only a HTML fragment is provided, without headers and footers. The HTML code in ImpEditEngine::PasteText() was modeled after the HTML_SIMPLE case, which is some custom format from MSIE and that rejected the data in case the header didn't match, so the HTML case also required a HTML header in the above commit, but this doesn't work for HTML fragments. Fix the problem by just dropping the header check in ImpEditEngine::PasteText(), because that data already comes from the text/html slot of the clipboard, so there is already indication about the file format, even without the header. And without headers, it's almost impossible to recognize if the HTML fragment is a HTML one or not. Note that this is the HTML paste when a cell edit is active, the normal Calc HTML paste is a different codepath, in sc/. Change-Id: I4d37d80f947880fe22051c5fe84dc6bbc257e108 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162927 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins (cherry picked from commit 0503f6718f7686f3e2c93fc13af23e9fbfdace42) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162903 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06check that rtl_random_getBytes() was successfulMichael Stahl
... everywhere it is used to generate material for encryption. Change-Id: Id3390376bb2f3a5fa1bbfd735850fce886ef7db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162873 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit b85c2459ced6a41915dbaf567613fb5e244a0ada) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162890 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06writerfilter: fix missing paragraph break on tdf136445-1.rtfMichael Stahl
This causes an assert: crossrefbookmark.cxx:44: sw::mark::CrossRefBookmark::CrossRefBookmark(): Assertion `IDocumentMarkAccess::IsLegalPaMForCrossRefHeadingBookmark(rPaM) && "<CrossRefBookmark::CrossRefBookmark(..)>" "- creation of cross-reference bookmark with an illegal PaM that does not expand over exactly one whole paragraph."' failed. The problem is that there is an annotation at the end of a paragraph, and reading the annotation changes various members of DomainMapper_Impl, in particular m_bParaSectpr and m_bParaChanged, causing "bRemove" in DomainMapper::lcl_utext() to be erroneously true, removing the just inserted paragraph break again. Move all flags that are evaluated for bRemove to SubstreamContext. This causes one test failure, but it turns out that the new result is the same as in Word 2013. Test name: (anonymous namespace)::testTdf108947::TestBody equality assertion failed - Expected: Header Page 2 ? - Actual : Header Page 2 ? (regression from commit 15b886f460919ea3dce425a621dc017c2992a96b) Change-Id: I44a7a8928ab04c600d4d3c43bc4e4deeafe57d89 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162932 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 86ad08f9d25110e91e92a0badf6de75e785b3644) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162936 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06writerfilter: move members to SubstreamContextMichael Stahl
writerfilter: move m_bParaHadField to SubstreamContext Change-Id: Ie15e35d304a423bfa3d7b7ead71015d5ec1228d4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162839 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 4913812baeabd44b46302e54b73a227e760c688a) writerfilter: use SubstreamContext for all substreams <vmiklos> possibly just nobody needed that so far. could be some more general SubstreamContext, i don't see an obvious problem reusing that at more places. Change-Id: If0749155452f65f8dfc4ac2b10f91bb8e48a6b2b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162840 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 95b01848b18283fd2f903c982108ccdb8efee022) writerfilter: move m_bFirstParagraphInCell to SubstreamContext This is a change to set it for all substreams. Change-Id: I44ed9a5485000f40f8ccfe3ec885ef8f05f5aab2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162841 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 30323c813977eb0127251848fecd2532dce75749) writerfilter: replace members w/ SubstreamContext::eSubstreamType This should not change any behaviour. Change-Id: Ic970f0e1b6401119d875c9e811589b9c210e0c34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162842 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 992f7114ab8645fb5b7a22b5f974a95fe7be7712) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162933 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06tdf#158586 writerfilter: RTF import: fix \page \sect \skbnone w/ headerMichael Stahl
The problem was not fixed yet for the less-minimized bugzilla attachment where the sections contain headers and footers. What happened there is that first \page caused a deferred page break, then \sect and sectBreak() delayed-read the header substream and the \par in the header resets all the deferred break flags. Add the deferred break to an already existing Context class, and remove the direct members in DomainMapper_Impl in favor of always using the m_StreamStateStack. Probably this problem cannot occur for DOCX import, because it imports header/footer eagerly where the reference element is, and sectPr is before any runs that contain breaks in the same paragraph element. Change-Id: Iba971955e9cf0c398d416518e72d99307d3e1cfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162833 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 17e2c7226a73675d69febf0915aaeae61ad8e9f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162823 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06tdf#158586 writerfilter: RTF import: handle \sect in frame as \parMichael Stahl
This fixes the test testTdf158586_0 and testTdf158586_0B to look like in Word; the case appears a bit esoteric, hopefully Word won't actually create such documents? But Word will round-trip such bugdoc to a DOCX where the first w:p contains all of w:framePr and w:sectPr and w:br... Change-Id: I6ec09478a774e1e9c785e9482618c1afc388df0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162778 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit dbe78489e98d565b72a703524308523135ffdd67) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162822 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06tdf#158586 writerfilter: RTF import: fix \page \sect \skbnoneMichael Stahl
The problem is that \page is actually completely ignored in the bugdoc testTdf158586_1. If you delete the \sbknone then there is a page break but it's caused by \sect; the \page is still ignored. It is ignored because, first, the \page results in a deferred break in DomainMapper, then for \sect, the synthetic \par is dispatched and that moves the break from deferred to the top paragraph properties context, then sectBreak() calls endParagraphGroup() which just removes the top paragraph properties context. Remove the dispatchSymbol(RTFKeyword::PAR) for \sect, instead set a flag so that RTFDocumentImpl::sectBreak() does it. Add a new flag m_bParAtEndOfSection so that RTFDocumentImpl::parBreak() can suppress the startParagraphGroup(), so the deferred break remains present. This also fixes testTdf158586_lostFrame. (regression from commit 15b886f460919ea3dce425a621dc017c2992a96b) Change-Id: I82a00899a9448069832a0b2f98a96df00da75518 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162770 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 57abad5cf990111fd7de011809d4421dc0550193) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162821 Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
2024-02-06tdf#158409: RTF import: use current run props for fieldsVasily Melenchuk
Fields import was not using current run properties causing fallback to used style or default style what is wrong for RTF. Change-Id: I0189c6122b703a23ff910ee38da78aa05ac4d9f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/160387 Tested-by: Jenkins Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163057
2024-02-06Update git submodulesGabor Kelemen
* Update helpcontent2 from branch 'libreoffice-24-2' to f2ee21b4f0df120c737d7357e7d6dd2df92b4e9c - tdf#159568 Fix link to extensions page -> Dictionaries category Change-Id: I729264913b54c797193bb6b9c238c8d72a94608c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163045 Tested-by: Jenkins Reviewed-by: Gabor Kelemen <gabor.kelemen.extern@allotropia.de> (cherry picked from commit 3323d51dec401d59a5b0163294922d2487ba91a8) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/163014
2024-02-06tdf#159461 deadlock in Dialog "XML Filter Settings"Noel Grandin
revert commit 15405dc68b2e88b53585578567da13e3e99962db Author: Noel Grandin <noel.grandin@collabora.co.uk> Date: Mon Feb 20 15:43:41 2023 +0200 osl::Mutex->std::mutex in FilterCache There is much recursive behaviour going on here, via the configmgr and the listeners that FilterCache has. Change-Id: Ice003404dffad9e5e63bcff30c2ceede4f52cab8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162930 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit b23aec2266da4cc2b3f4a34037d3a073a36d3d83) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162905 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2024-02-06tdf#159566: match 'central' dominant-baseline to 'middle'Xisco Fauli
Inkscape also does it the same way Change-Id: I3e1cea091e7314886bbc9135c55698892239bec7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163006 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 358061b4a480ea763ea541094cef2112f917eb93) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/163013 Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2024-02-05tdf#147291 add more default certificate manager application for macOSPatrick Luby
Add the following applications to the macOS GUI servers list: - Trusted Key Manager - CertEurope - SCInterface Manager and SmartCard tools Change-Id: Iec78171c6e82f0a072f5f06b79606560a8cc03cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162942 Tested-by: Jenkins Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Reviewed-by: Stephan Bergmann <stephan.bergmann@allotropia.de> (cherry picked from commit 538f7b45c0c2c08124e9ea51a0947504f142a4f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162909
2024-02-05Resolves: tdf#156352 disable sorting while adding rowsCaolán McNamara
looks like the new row gets sorted immediately when added as an empty row into the first row, so accessing it by index later to set it text/id get an unexpected result. pause sorting while inserting the entries and enable it again when finished for the easiest fix. Change-Id: Ib028b193afbf2b9026841b19419e012b70448e39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/162906 Reviewed-by: Patrick Luby <guibomacdev@gmail.com> Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolan.mcnamara@collabora.com>
generated by cgit (git 2.34.1) at 2024-06-23 20:26:37 +0000