summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-04-20Breeze,elementary,KJ,Sifr: Fix for tdf#128689Rizal Muttaqin
- KJ: Update Group related icons Change-Id: Icdb23409a8026afd9acf7c6188353cd59cb7a0cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92553 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit e38c83af70ff1e077d28116702c55cad20cdef2a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92527
2020-04-20tdf#132185: field command does not necessarily end with spaceMike Kaganski
Change-Id: I5a5e54fb42e20855b75af7ab523465a032ab46e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92504 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 8c8b3a4f83f67882b284ddc3b3fe10d3fe6dedf4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92444 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-20Fix autorecovery using wrong directorySamuel Mehrbrodt
Autorecovery should save in the user profile in the "backup" directory. However, when that directory did not exist, the temp directory was used instead. Fix this, and create the requested directory if it did not exist. Change-Id: Ie298855a740932bc6e6c9f62d4b4bf1b52b80c58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92428 Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-20Qt5 implement DELETE_ITEMS action in file pickerAlexander Volkov
It is used to clear "Version" listbox before adding new items. Change-Id: I4cb9557c8f56d80c1dfac68dc2b5b45b5c69c2f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91982 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 3a22be0178b950ab3d21eadab2bc34e7ea93eec8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92174 Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-04-20Sifr: Update Display View icons tdf#125510Rizal Muttaqin
Change-Id: I755cafffc71268df0acc172fcf1ea45b81f06837 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92499 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 4a670f4284cd2131845ef940d10daedf57014ea4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92442
2020-04-19Resolves: tdf#131442 Sort must not contain matrix formula except 1x1 arrayEike Rathke
Change-Id: Idc7a9646a70c59fceee0b36426f38a938cf073ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91858 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit b1da67699bd05b26ee11460347ca7077d366c2fc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91723 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-19tdf#132210: fix Calc crash when closing spreadsheet fileJulien Nabet
make the dialog modal See bt: https://bugs.documentfoundation.org/attachment.cgi?id=159677 Change-Id: I75719fe241950f13c2e5d65c5d9078193e631ffd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92437 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-17tdf#130583: fix Switch in CalcJulien Nabet
Don't set bFinished to true too soon if there are still some params to take into account Change-Id: Ie7bdd6f316c08342d379d55bf3853774dd738e7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92345 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit bb3ea0ae51bb943f7bb3dca80eee153f9c55c03e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92432
2020-04-17tdf#132147: formula may be emptyMike Kaganski
"Regression" after commit ab285c743afa1c8769581871d7b56374fd8c49f1 author Noel Grandin <noel.grandin@collabora.co.uk> Sat Nov 02 18:59:49 2019 +0200 committer Noel Grandin <noel.grandin@collabora.co.uk> Sun Nov 03 17:11:14 2019 +0100 loplugin:stringadd tweak the plugin to be more permissive, then validate by hand afterwards which replaced strFor.replaceAt(0,1,"") with strFor.copy(1). Both methods are illegal on empty string, but the former asserted, then silently corrected wrong count; while the latter returns "br0ken". So the change actually revealed a pre-existing bug. Change-Id: Ic32b69d46e852f26e6c6ba819eed08bb79dce7a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92301 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit de1dadd591862e38242cc2de7a4a658a9a8b67ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92303 Reviewed-by: Eike Rathke <erack@redhat.com>
2020-04-17Update git submodulesAndras Timar
* Update translations from branch 'libreoffice-6-4' to 732b19f5f5bafd083e3a4654aad862551158bc12 - Slovenian fixes Change-Id: I0f40a860a6db51bdf01776a8424055aab8b67d2a
2020-04-16fix tree view cursor leakCaolán McNamara
Change-Id: I8660db3d5eddb1596529783e13dff130bb3d0858 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92008 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16tdf#131873 data table fills with extra columns during scrollCaolán McNamara
Change-Id: Iccdb113a609e0873fb68cfb52405993a0f4362bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91713 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16tdf#132097: fix Find Previous with direction columns crashes in specific caseJulien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=159553 nBlockPos vector is created with nLastCol + 1 elements, so if we click on a cell in a column which is after last value, the search will crash Change-Id: I9de688a8a80a45c3e5ddea6d2f461926e9777052 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92165 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 2670e980c7dbadbdc20ff23d57ad892951edc254) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92296 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16tdf#91565: Report builder, missing insert field iconJulien Nabet
in Add Field dialog. Since https://cgit.freedesktop.org/libreoffice/core/commit/?id=50cacaea4d8f2a27ea4d9e626dbb518a57eb9ffc, author Caolán McNamara <caolanm@redhat.com> 2016-09-27 09:47:00 +0100 committer Caolán McNamara <caolanm@redhat.com> 2016-09-27 10:43:36 +0100 commit 50cacaea4d8f2a27ea4d9e626dbb518a57eb9ffc (patch) tree a2cf1d1fb28231a6594e03e17c5e9ffe8748a655 parent e6fc195ae8a59d665395149ea5f06749c4c6a596 (diff) convert floating add field to .ui format it was easier to analyze the problem. Change-Id: Ica9adc19f370d6340d2f5fac552cf1b995b390e0 2c7dda5969d4018689446725dc3e179c6ddc74c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92228 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92323 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16Resolves: tdf#122491 ClassificationDialog::run() is not calledCaolán McNamara
when using DialogController::runAsync so the custom override isn't called so the special setup and save-on-ok aren't called. move the setup into the ctor seeing as the dialog is only run once after ctoring and add a OK handling that does the on-ok setting save and have setupValues call readIn on "m_aInitialValues" because that gets called after the ctor Change-Id: I8183fc4b0f5de2844562c971c86d655f2d4920ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92288 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-04-16tdf#132091 sw: fix fieldmark mess in SwCursor::SelectWordWT()Michael Stahl
The problem is that it selects both the field instruction and the field result; in the typical case where the instruction is empty, the separator won't be deleted (due to CalcBreaks) but the problem is that the cursor ends up before the separator, not after it. Also remove some silly defensive programming. (regression from ffb26b81e1c7ff1d64959200247bb2edd5a569da) Change-Id: I80b6cb1790b7102828f12b680631f928734ffa7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92284 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 1c94842e053a20a739a181d38a35c324df3e62a7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92293 Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de>
2020-04-16tdf#126828 hide macro organize dialog before launching macro editingCaolán McNamara
so the macro editor isn't forced behind the window with an active dialog Change-Id: Iae89f6910a8183bcf01872eef71c04bc993f1550 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92307 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit cac8694feab1ccb422294ed3e2f8b682e15835fb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92297 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-16tdf#131209 reload the notebook barJim Raykowski
Change-Id: Id5a1b63c0f907a8f20406d2fa1c08c1aff34b91c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91702 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 68c96a54fef93b9f735aeb6c9ae07171e934132a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92184 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16tdf#131193: MSO PP complains about an ODP saved as PPTAron Budea
pPara was supposed to be the first paragraph, as before the below commit. Regression from d458adeed0c34fae26fe7f3d6ecc9b75b431922f Change-Id: I50b993ff8f37fd5572d60fe5d103c3cf5e636a6b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92105 Reviewed-by: Arkadiy Illarionov <qarkai@gmail.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins (cherry picked from commit b267650fd097f16d1b31c87a11a497294ad4ee42) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92287 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-16Hack to dynamically adapt to __cxa_exceptiom in LLVM 11 libcxxabiStephan Bergmann
(where the new change to __cxa_exception effectively reverts the change that prompted 7a9dd3d482deeeb3ed1d50074e56adbd3f928296 "Hack to dynamically adapt to __cxa_exceptiom in LLVM 5.0 libcxxabi") Change-Id: Iec4ef1dc188bea2223d99b1b7eb8adec636c98e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88583 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit f4b6f6a8ae60bdec53512728d00853b73fa18500) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92022 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-16tdf#131812: fix exporting to html doesn't preserve RTL propertyJulien Nabet
Change-Id: I227e304c6868afe7a98dbd8e96487270d06ce1eb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92067 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 95460224f4f8443547dbf5cedbea008ea2639337) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92019 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-16Resolves: tdf#131996 set_sensitive should be set_activeCaolán McNamara
search and replace went wrong in: commit b94214350e6e3d0252c09f203a3ce7807a179f90 Date: Thu Jul 25 14:09:09 2019 +0100 weld SdPublishingDlg Change-Id: I10af85633758a6e4c354f6fc957624122dd01f3c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91901 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-16tdf#126828 don't crash fetching cmis properties from disposed SfxBaseModelCaolán McNamara
Change-Id: Ie064632667b40201e0d266c64e3068c4d1983c7d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92283 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit db677c854a37031235b0f42b4f4f48560149754f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92289 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-15sw: fix fly at-char deletion API behaviour changeMichael Stahl
28b77c89dfcafae82cf2a6d85731b643ff9290e5 changed at-char anchored fly selection. WollMux calls setString("") to remove one character in the first paragraph and a fly anchored at the start of the body text is deleted due to the new IsAtStartOfSection() check. It would be possible to treat deletion via API differently than via UI, as there is already a flag ExcludeFlyAtStartEnd but it would require passing the flag through 10 functions and also to store it in SwUndoDelete... The main intent of the IsAtStartOfSection() check was that Ctrl+A should delete every fly; this can be achieved by checking that everything was selected, so that selections only inside the first/last paragraph don't delete the flys at the edges. Change-Id: Id62e7d99a10b42eaecea5564372d29b6c43e3f7e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91993 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 971205dc2110c1c23ff1db1fc4041e2babf6fa9f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92169 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-04-15Breeze: Add support for Korean UI tdf#128689Rizal Muttaqin
Change-Id: Idbe742cdedc497ed9e0aec72cc69842b12d94aa6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92182 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-15Sifr: Add Korean UI tdf#128689Rizal Muttaqin
Change-Id: I8016e4c0ad97bf13934540d14697967d93e6d07e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92164 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 5431e8e25c6668480ebac11248f2aecbc0bda431) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92167
2020-04-15"General Internet Error" dialog appearing on gio mountCaolán McNamara
we get a GError of G_IO_ERROR_FAILED_HANDLED which is documented as "Operation failed and a helper program has already interacted with the user. Do not display any error dialog." PENDING seems to describe this state better than a generic error case and results in no error dialog. Change-Id: Iee382e49edaa0a734526659971e0339991e2c03e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92171 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-14tdf#132001 DOCX import: fix crash: redline in floating tableLászló Németh
Copying redlines to frame text was failed in tables inside frames. Skip these redlines temporarily. Regression from commit e8bae67b3dbcc90ace8264b6b1aefaf0ce459aba (tdf#125894: DOCX: import tracked changes in frames). Change-Id: I4f3ca2e95fb2e7637f8cf8dca1088a7727bcf98d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91985 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 1350832be533ce6627607b1aaabd2b3565e6e7b3) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92015 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14tdf#131907 Crash: reject/clear formattingNoel Grandin
regression from commit 0ef5c47547bec6319b853326603f3b807407fe78 sc: rowcol: tdf#50916 convert core/tool Change-Id: Ib8207f60d34e4257fc9a854f4e4d358951e24718 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92062 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit c076b99dd21edae0364cf9319a221a1d6a4bd487) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92170 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14tdf#104565 DOCX drawing object export: fix arrow positionsSzabolcs
Saving some arrows from ODT to DOCX scattered them around their correct position. This happened because of a function that recalculates the position of drawing objects when they are rotated, according to the rotation. It turns out we don't have to do this with lines and such. Co-Author: Balázs Regényi Change-Id: Iea6a34d15003cacc27a8030cb73511aba39225f6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90989 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 08a11f8fe19560b000c62da00d7425b4f500d605) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92166 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-04-14elementary: Fix for tdf#132080 Wrong Glyphs with Korean UIRizal Muttaqin
- Update line icons - Update Font Color icons Change-Id: I2bd9970c62669dc97a528c61df10566e83edb39a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92140 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit b8c2e08b68722972d65f08107d74ba4a10f713df) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92024
2020-04-12Resolves: tdf#132038 missing adjustment for rotationCaolán McNamara
Change-Id: Ib4702627578e06f209c9c58021971eb4e1ed39a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92082 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-04-11Sifr: Add more Korean UI icons: tdf#128689Rizal Muttaqin
Change-Id: I71a532667d4ef6b2db223fddc8afcf7384bfe7fd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92018 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-10Breeze,elementary,KJ,Sifr:+ DB Record support 4 RTL UIRizal Muttaqin
Change-Id: I292350c4f6cb886bb21404744a73dfd904aa9fb0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92040 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit b332452f01f19ca1065a2bef0b390ad5e92f4105) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92016
2020-04-10tdf#131966: chart legend attribs width and height unknown for ODF 1.2 (strict)Julien Nabet
Change-Id: Ie4cb7d2c9e5fb7bca88287fcaff03d5c9ca04b8b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91899 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-10Colibre: Fix for tdf#131974 & tdf#131975Rizal Muttaqin
- tdf#131974: Flipped Undo & Redo button in RTL UI - tdf#131975: Wrong icons for "Undo: Data Input" (.uno:RecUndo) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91944 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 5b56db7dcf471dc837fc05e92636579ef80a205c) Change-Id: I7c6e667df20cbe125da020f246d264626c48528c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91896 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-04-09Breeze, elementary, KJ, Sifr: Update localization supportRizal Muttaqin
- elementary: Update Chapter Numbering icons - elementary, KJ, Sifr: Revert Good, Neutral and Bad Cell Styles icons Change-Id: I610b17896841d84b964afbde994590633312e0f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91959 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 1bc3f2660d1df6aedb0560f5ff8cff2624ce9fe6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91903
2020-04-09sw: crashtesting: fix assert on ooo95711-1.odtMichael Stahl
Document is special and contains deletion that contains only a table, no paragraphs before or after it. The assertion is wrong in this case. It doesn't matter if the atParaEndNode is incremented because it's going to be on an end node either way. (regression from 91b2325808a75174f284c48c8b8afc118fad74e4) Change-Id: I3fe82f0ed0b7b213df036bb8026dc209c00123de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91873 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 6b2e925aa0dd389a613e182545de6550057374d4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91890 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-09tdf#131684 sw_redlinehide: fix SwUndoDelete for entire doc in sectionMichael Stahl
The problem is that in SwUndoDelete::UndoImpl(), at the start there is only one content node with a frame in the layout, and there is a special case with m_nReplaceDummy being set so this SwTextFrame gets deleted by the MoveNodes() call in line 969 that moves it into the newly inserted section. As a result of that, MakeFrames() won't do anything because it can't find an existing frame in the same section. In this case, MoveNodes() should leave the frame alone, as it is beyond the end of the deletion and excluded from MakeFrames() - if it wasn't merged before then it doesn't need action, if it was merged before (in a different document maybe) the RecreateStartTextFrames() ought to fix it. (regression from 723728cd358693b8f4bc9d913541aa4479f2bd48 which disabled immediate creation of frames in Copy_()) Change-Id: Iabe2fb1810b0df898b1f57b3d850c3503c79c5d0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91842 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 6c7245e789f973cf6dad03f7008ab3f9d12d350c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91886 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-04-09tdf#129372: PPTX: error at SfxBaseModel::storeToStorage: 0x20d(row,col)Julien Nabet
Teach starmath how to deal with surrogate pairs see https://en.wikipedia.org/wiki/Universal_Character_Set_characters#Surrogates + comments from: https://bugs.documentfoundation.org/show_bug.cgi?id=129372#c6 Here's the culprit character: 𝜕 %uD835%uDF15 I didn't dig why these 2 (found in reduced example attached to the bugtracker) didn't need this patch 𝑋 %uD835%uDC4B 𝑢 %uD835%uDC62 Change-Id: I3bf2322a9e7f1974aa8622a91812aeb11e613ace Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91941 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 11b57129b53e1e2d71a5f969e2417226b4e2ddd9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91900 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-09tdf#131969: Fix reading SHORT Orientation valueStephan Bergmann
<http://www.cipa.jp/std/documents/e/DC-008-2012_E.pdf> "CIPA DC- 008-Translation- 2012: Exchangeable image file format for digital still cameras: Exif Version 2.3" documents that the Orientation tag 0x0112 expects a count of 1 values of type SHORT (16 bit), and details that values <= 4 bytes are stored in the Value Offset field always using bytes starting from the left of the field. This is a regression introduced with 42c0e433aca68c669bc0f55af404b6bae1655fba "Avoid -fsanitize=misaligned-pointer-use". That commit had wondered why the original code had used OSL_SWAPWORD instead of OSL_SWAPDWORD when reading and writing such orientation values. It turns out that that original code had happened to work correctly when processing either little or big endian data on a little endian machine. (Though it would have worked incorrectly when processing either little or big endian data on a big endian machine.) And with 42c0e433aca68c669bc0f55af404b6bae1655fba, the code worked when processing little endian data on a little endian machine, but failed when processing big endian data on a little endian machine, as is the case for tdf#131669 on e.g. x86_64. (read32 has become unused and is thus removed.) Change-Id: I7992629048ac44c00ee703c75164f3d094773244 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91881 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> (cherry picked from commit fd5961cb0e2ebc2f5797f76a2b1f9fd52ca4b3ab) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91889 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-09All icons: fix for tdf#131975, Breeze, Sifr fix for tdf#131974Rizal Muttaqin
Change-Id: If39b5034896998a3137b913afadd05e6f4173331 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91882 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit ab751b456d334464b01ae6a6b25ebfd1f8e2fc91) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91891
2020-04-09Breeze: Fix for tdf#131984: missing icons for Writer's Data SourceRizal Muttaqin
Change-Id: I3516d55f08c3bdd857994db7704c2af0a20cc260 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91924 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 6209ac8094e3578bb2dfcbf5f7e2f302bd760926) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91895
2020-04-08Resolves tdf#127782 - New Print dialog is too highHeiko Tietze
Expander added Change-Id: Iea41f9cf335b75210de0acf5688fddd5e3dd3dbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86478 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit 96b4bf352b1dc43637080719c91eef61fef74bf8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91725
2020-04-08tdf#131594: switch line numbering off if w:countBy="0"Xisco Fauli
See https://bugs.documentfoundation.org/show_bug.cgi?id=131594#c0 for more info Change-Id: Ic57826eb5a440e83cea1d9bde5e9144727e3b6df Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91141 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 910197b8cf9b653c1b39b35b73424a36b7c1d1ae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91512 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-08Resolves: tdf#131715 don't keep trying the same page if we're already on itCaolán McNamara
return of false means we didn't change page for some reason, the idea is that it might be blocked to go to another page, in which case sync with what page we ended up on, but don't bother with that if the dest page would be the same as the current page Change-Id: I280128240601413fb6d027d001b2ecc9a4efa76f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91718 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-08tdf#131490 sw btlr: fix handling of vertical textMiklos Vajna
Latin text goes from l->r, then t->b. If we rotate to the right, then we get t->b, then r->l. Vertical text in vcl's Font means the individual glyphs are painted in a way that looks "non-rotated" in the tbrl case. btlr is not symmetric to this: if you rotate to the left, then Latin and vertical text is handled the same way, i.e. there is no compensation at a glyph level. This means that as far as vcl is concerned, the Font's vertical flag has to be true in the tbrl case, but no in the btlr one. Fix SwFont::SetVertical() to do this, which means that rotating at a character level or using the btlr text direction will result in the same rendering for a one-liner text. Regression from commit 89e5b431d468745da3a1eff14d48296107b9101b (sw btlr writing mode: implement DOC filter, 2019-03-28). (cherry picked from commit a8d26a0bb40c101394ded8061d1b58048153631b) Change-Id: I2619c77a3b2597dbf9feab6c7042e8d8c7454197 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91820 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-04-08elementary: Update Gallery folders and DB record iconsRizal Muttaqin
Change-Id: I2c0e9c70d9b25d8e7cabaf890cd6107dcdd7834d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91863 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 3168a1d790323c51765655d9da273d51db94b707) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91724
2020-04-07tdf#131190 Make custom page styles deletable again in CalcJim Raykowski
This is a combination of 2 commits. tdf#131190 Make custom page styles deletable again in Calc Here is a patch to return the ability to delete custom page styles in Calc. This was lost in commit 30c9bc76d0718f0c01d34f81845d88413645b42c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/90547 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit bb844eb299b614c1fa56e140630db070cf709a02) tdf#131190 Make custom page styles deletable again in Calc Return the ability to delete custom page styles in Calc. This was lost in commit 30c9bc76d0718f0c01d34f81845d88413645b42c ae402cc048fde7ffd3ca2696c08d5e54cc30d1be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91672 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> Change-Id: I18936585cfbe45e0254beb882adc8709781f57e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91404 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-04-07Resolves: tdf#131170 columns tagged as delimiter not columnCaolán McNamara
Change-Id: I889c3ba38776a63587a68c7827956b6747c08e38 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91715 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
generated by cgit (git 2.34.1) at 2024-07-04 16:08:11 +0000