summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-28tdf#122218 TDF builds for 6.4 are now done on Mojave with Xcode 11Christian Lohmaier
This allows the blurry-font workaround to be used that wouldn't work with Xcode 10 (the last available for HighSierra and minimum required for notarization) Change-Id: I95030ff8900351ca9ef1d9aab1e0d9f497bd4ab1
2020-02-28macOS: don't sign executables earlyChristian Lohmaier
macOS 10.14 and later (Mojave & Catalina) will treat signed exectuables as "restricted binary" and in turn will block any use of DYLD_LIBRARY_PATH settings, causing the build to fail with e.g.: dyld: Library not loaded: @__VIA_LIBRARY_PATH__/libuno_sal.dylib.3 Referenced from: /Users/cloph/build/workdir/LinkTarget/Executable/genconv_dict Reason: unsafe use of relative rpath @__VIA_LIBRARY_PATH__/libuno_sal.dylib.3 in /Users/cloph/build/workdir/LinkTarget/Executable/genconv_dict with restricted binary Change-Id: Ia90d8fa6f28f9a2c10f6b46eb1796e2730550119 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/81599 Tested-by: Jenkins Reviewed-by: Christian Lohmaier <lohmaier+LibreOffice@googlemail.com> (cherry picked from commit 1a73975918d5057336466733f3f0964c128bfcb7) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89678
2020-02-28sw: DOCX export: for SwDropDownField, don't write FORMDROPDOWNMichael Stahl
... because Word's funny limitation to 25 listEntry children causes data loss, as seen in commit d9634e3c9bfaf826b3d4d39e9a57d6c2d8d9a3dc "sw: DOCX export: limit FORMDROPDOWN listEntry to Word's abilities". Instead write SDT dropDownList, which appears to be able to store at least 26 listItem children without complaint from Word, so it's an improvement. Funnily domainmapper converts it to a form control on DOCX import. Change-Id: Ic0f24144cb2b5233f82c7b3bc67946a6e56448a8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89541 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit d55b26a093bdbced08985dbc7113190b52a8bc66) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89622 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-28tdf#130917 Invalid document after odt->docx with signaturelineSamuel Mehrbrodt
Change-Id: Idf80c41f1315e0690dabd5e8566b62fc64c3ee1a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89672 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins
2020-02-28Update git submodulesChristian Lohmaier
* Update translations from branch 'libreoffice-6-4' to d80a1a2c3f2450ec387e9fee797ad04d2acb8595 - update translations for 6.4.2 rc1 and force-fix errors using pocheck Change-Id: I3f80bc7dc8514b989740bf697ed3a9ef8865b5de
2020-02-28tdf#130071 tdf#127815 qt5: Use ExtTextInput only for multi-char key eventsMichael Weghorn
Only call the SalEvent::ExtTextInput callback for key input events if their text is longer than one character, in which case treating them as SalEvent::KeyInput would produce incorrect results, given that only the first character is set as the SalKeyEvent's mnCharCode below (s.a. tdf#124118). S.a. commit 61c8324394c690ced18ce692ab6d29c8031ad1a8 ("#88063# fixed event handling for redflag", 2001-06-12) which made events with text longer than 1 unicode char to be handled by SalEvent::ExtTextInput for the gen VCL plugin even if not in preedit mode. Process other key events by calling SalEvent::KeyInput callback, which e.g. makes shortcuts involving non-Latin characters (tdf#130071) and auto-insertion of non-breaking spaces when typing French text (tdf#127815) work. The gtk3 and gen VCL plugins also use the length of the text as one criterion to make a disctinction of whether to call SalEvent::ExtTextInput or SalEvent::KeyInput, s. GtkSalFrame::IMHandler::signalIMCommit and X11SalFrame::HandleKeyEvent. Those also take into account whether in preedit mode, but for the qt5 case, input method events when using e.g. ibus are handled in Qt5Widget::inputMethodEvent and the Qt5Widget::handleKeyEvent code path is not used anyway. Change-Id: I2f8925ea26a4fb5419226265c579242889e2a506 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89663 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Michael Weghorn <m.weghorn@posteo.de> Tested-by: Jenkins (cherry picked from commit 1c6ea413cb01c0b482f87e625ba208eec230618a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89670 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-28tdf#130989 we want to fill the menu when the menubutton is toggled onCaolán McNamara
Change-Id: I85615277d3367ac679315745b47c1a7327c61903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89668 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-28Breeze & Sifr: Fix for tdf#130939rizmut
Missing icons in Merge Cells dialog Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89498 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 79d396a2a64bec4e6c9aa514af40fdd67a62d8ce) Change-Id: Ic3dbf4cc8748455fe8086cdaf4b154cdc9ee9272 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89515 Tested-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-02-27tdf#130908 Chapter Numbering can't load custom styleNoel Grandin
regression from commit 83e97fef3fa4de900eda35d02168fcae01c85eed convert ImportStoredChapterNumberingRules to XFastParser and add some more debugging trace Change-Id: I224b9c442369a4c6a7746d7ff419f069d3430513 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89633 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 5320fccc290f338d344c5d3c75101c98057788cd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89583 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-27desktop: soffice --print-to-file generates PDF but names it ".ps"Michael Stahl
Both on Linux and Windows a PDF is generated. Change-Id: I076b57c34a87c17d34eb34f2ea87c6fd5fe590f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89645 Reviewed-by: Michael Stahl <michael.stahl@cib.de> Tested-by: Jenkins (cherry picked from commit 53a8e2f75da778c953b509efadca890ff0936c2f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89666 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27tdf#130679 Draw: Convert to polygon doesn't workNoel Grandin
regression from commit 1cd32bcf1b92bd53320717626601135623dadd55 Date: Mon Dec 10 11:28:59 2018 +0200 loplugin:useuniqueptr in vcl Change-Id: I7753f54822d0249d1fcda97581051d023969fc2f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89636 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit dc5be8f6020dd812664af250d03d2a14b9e8a3cb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89584 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27Resolves tdf#127508 - Flat table header in CalcHeiko Tietze
Amends 67fd62b3edc86c2891f279b25cf9919c4bbbbca1 with flat corner button Change-Id: Ia26aff0844069dd435cf4edd7524c19f5f0f22ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89365 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit d8c7864407249fd1ed69713dfdf4fa533a9efb0b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89575 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-27tdf#130959 crash when opening file with non-existing hyperlinksNoel Grandin
regression from commit 0ef5c47547bec6319b853326603f3b807407fe78 sc: rowcol: tdf#50916 convert core/tool Change-Id: I8cb8fa4c6abf7450386a284a26be0a6d3ab9a623 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89617 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 8f90d3bf33fde7759046a13282381bbd710357f1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89578 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-27check if edit can be enabled after setting cursor into treeCaolán McNamara
Change-Id: I264dc4db7e3ddc64faf0edec18d96d2c46ce00f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89438 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27tdf#130915 auto-select first entry when treeview filledCaolán McNamara
Change-Id: I3311e2e6f013de7adca5b473609b1dd64187a58f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89516 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27tdf#91219 sw: don't allow anchoring a shape+textbox into itselfMiklos Vajna
We already have code that detects this in the simple fly frame case, extend that to cover the "paired fly frame + draw shape" case as well. Change-Id: I4b3c1d600407436b239fee311ae6bfe837804241 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89381 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89536 Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-27Resolves: tdf#130825 Compare exclusive end, not inclusive end sheet numberEike Rathke
Change-Id: Id5c3056f4e4466ccb5ea3654e60869bf7788b7ca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89471 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit f2b18667c1a8c6a002a229d4ae09dc418dc567e1) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89522 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-27Fix @since tagStephan Bergmann
This UNOIDL entity had been included in libreoffice-6-4 prior to the first LO 6.4 release at libreoffice-6.4.0.3-buildfix1 with ad86ebb1f86f6347ccb9bbe40b0ca080562cbae8 "tdf#121658 Add option to not hyphenate words in CAPS". Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89564 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit bf749968d0bed09234192862bcc709c9ca7af66d) Conflicts: offapi/com/sun/star/style/ParagraphProperties.idl Change-Id: I34df2ebeb56fdfe72bc9e19cc77eddd8a97a5c59 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89602 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27WIN prevent deadlock in SetForegroundWindowJan-Marek Glogowski
As mentioned in various blogs, like Raymon Chens "The old new thing", 2008-08-01, "I warned you: The dangers of attaching input queues", using AttachThreadInput to steal the input from an other thread, so SetForegroundWindow becomes more reliable, can deadlock in that call in win32u.dll!NtUserCallHwndLock. Stackoverflow also has a multitude of suggestions and links in "Win32 SetForegroundWindow unreliable", to circumvent Windows focus-stealing prevention mechanisms. A customer is experiencing these hangs reliably and often when opening LO windows via Java UNO, because the Window and the UNO thread are different and trigger this code path. Removing the calls to AttachThreadInput fixes the problem for them. This has started lately and nobody really knows why. I also know other customers with a similar Java UNO setup, which don't experience them. For better foreground handling, the calling app eventually should either use AllowSetForegroundWindow or CoAllowSetForegroundWindow (for COM servers), to give up the foreground / input handling. So this just drops the AttachThreadInput calls. Change-Id: I8de0a17aaaa44c24b1ee728b2ef6ec3aea951c54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89527 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 518c0265efebf39ab6d1e90c4ec4e7cf52b701c6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89572 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-27elementary: Fix for tdf#130947rizmut
- Add missing Merge Dialog icons - Update collate for Print dialog Change-Id: I48a67800b2ffa3457465a06c74d93c8dfaa3c8c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89561 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 8e6ea7b596333ad4747f51003b049417e97097a4) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89577
2020-02-27Update git submodulesAndras Timar
* Update translations from branch 'libreoffice-6-4' to 876dd9620423bc1cb6794081e2ceb11eb7793d61 - Slovenian translation fixes Change-Id: Icdf79e4b86bacc2bdaf015edfb8e1d5d215cc984
2020-02-26tdf#130925 use the maximum document line number for the width calculationCaolán McNamara
not the max line number in the range currently getting rendered Change-Id: I447e4152ef6a1ec327a95a8260d1616940e5d6c4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89467 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit ca79c018f1e8bd0e1f42e3cef4b4f5893ef2e47f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89521
2020-02-26tdf#130657 OOXML chart import: fix charts without CrossBetweenBalazs Varga
by using default values for ShiftedCategoryPosition. Regression from commit 111c260ab2883b7906f1a66e222dbf4dc3c58c4f (tdf#127777 OOXML chart export: fix "CrossBetween" for not imported charts) Change-Id: Idd48a8343e7d6609b487daf7182e9716f2f5e01f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88709 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 8163f4ad81487ae187d00d3ce86214e520cb8b69) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89517 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-26Sifr: Update dark chart color, clean links.txt, remove similar iconsrizmut
Change-Id: I972c674909bfa45a4b3e1a70382fef60e7a71526 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89485 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 2cdaf50763b1d8e7f45c2e2d6cd93f29241e3f0c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89509
2020-02-26Resolves tdf#130742 - Flat ODF in start centerHeiko Tietze
Added fodt,fods,fopd,fodg to typeMatchesExtension Change-Id: Ife8139af87ecc5af8a5e98c9d9dd7830c3a3231a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89455 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit f4b5b12fbe7eb0260119445ac39a28427fef3ee6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89514 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-26tdf#130105 Chart OOXML Import: Fix data label positionBalazs Varga
The position of datapoint labels was overwritten with the position of series placement. Do not overwrite datapoint labels placement, if we have explicit datapoint label placement. Regression from commit: 70944a849dc59fa686e3f316a3983dbc8a47017f (tdf#109858: Override default point label placement setting...) Change-Id: Ic27c8a7eb93e8c3776389d1b3d285d120568f024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87137 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org> (cherry picked from commit a4cdd4d1266e77330d4745f369db85ee7dba265c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87594 Tested-by: Jenkins Reviewed-by: Balazs Varga <balazs.varga991@gmail.com> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-26tdf#130793 Fix import/export of image URLsSamuel Mehrbrodt
Change-Id: I329af3b0d5a81d9f31def9c2ad861d0e83e3714c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89439 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-26tdf#130915 second treeview doesn't use its checkboxesCaolán McNamara
so we end up with blank lines under gtk Change-Id: I869c451dafe8dab0227ab8c914500ea059634c3a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89435 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-02-26tdf#130483 prevent pasting cell exceeds the border.Mark Hung
When pasting a table onto another selected table, cells are cloned from source to target including their column span and row span. In the test case the target table can accomodate the first cell of the merged cells, while the rest go over the table boundary, hence causing some exception later. Change-Id: Iae78a9e1689571d4ea2f1ac4853f68c1f7dccb9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88737 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 5f90c8bc0270f692a38073b1e4aa9e3b6ba106ed) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89442 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-26Resolves: tdf#130922 don't crash removing non-existing elementsCaolán McNamara
Change-Id: Id05faf6537ae096d563c57dcde71cd65ae04152d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89431 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-26Resolves: tdf130874 reversed logicCaolán McNamara
Change-Id: I2ccac01f271ec803547ab36359f2273312df87e8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89436 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-25sw: DOCX export: limit FORMDROPDOWN listEntry to Word's abilitiesMichael Stahl
In theory wml.xsd says: <xsd:element name="listEntry" type="CT_String" minOccurs="0" maxOccurs="unbounded"/> In practice Word 2013 refuses to load a file with 26 listEntry in one FORMDROPDOWN field. Interestingly w:result w:val larger than the number of entries does not cause Word to complain. Go figure. Change-Id: I3a61533f9ee4ba3917a9c3bc55a483fd587f0471 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89358 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit d9634e3c9bfaf826b3d4d39e9a57d6c2d8d9a3dc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89432 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25tdf#130915 SvTreeList::Move needs to move from lower index to higherCaolán McNamara
the reverse doesn't work Change-Id: I0d84e6e44b26c0c4f1f0d221de3fad03c183f6ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89434 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-25sw: improve DOCX export of footnote separator a little moreMichael Stahl
The Writer footnote separator has configurable line thickness and spacing above and below; let's abuse the font size of the paragraph to approximate the height of the separator (in the bugdoc that's currently interesting there isn't a separator line so if it works in that case it's good enough). Change-Id: I7f33e5a226ecaa9f9ab233e003c71aaed145b638 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89228 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 12d88808fbde933c0498c895ddb74700c263bf0f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89138 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-02-25tdf#130912: "Before" and "After" text swapped in footnotesJulien Nabet
Change-Id: I8022d3ec2385d35283711a144f6d610357790771 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89387 Tested-by: Jenkins (cherry picked from commit ee4ddf428e2ef85c710e1851ab9b9e7a2316d51b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89426 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-25tdf#129553 sw_redlinehide: fix replace of paragraph breaks with $Michael Stahl
The problem is that in the special selections that replace paragraph breaks, the start and end node are actually different, hence have different text frames. (regression from 5e81b966778d82692b4763d892b457186a7f269d) Practically the end content index is going to be 0 typically which doesn't need mapping, but not sure if that's guaranteed anywhere. Change-Id: I77c95c2f3e55edcc7aca6f4540cae90b3be5d79b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89050 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 83122add64ecbf0fd3ba30368d5d87bde3dac278) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88959 Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-02-25tdf#130760 Fix crash when clicking link to other slideSamuel Mehrbrodt
Change-Id: Ie8b0cfb852fe1abc49b80b1d2d9d2c3be1241701 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89332 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> (cherry picked from commit 5e8b6d3b721ba8730bc7a5b335418340e3f89c3e) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89285 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24tdf#130817 RTF doesn't set custom footnote stateJan-Marek Glogowski
RTFDocumentImpl::dispatchDestination detects the custom footnote and even sets NS_ooxml::LN_CT_FtnEdnRef_customMarkFollows in the character attributes of the context, but that is at least not handled in the DomainMapper later on, so we can't check for m_pImpl->IsInCustomFootnote() here. Change-Id: I26c02ea16d0e75ed5bfde0cda9e0c6a2d30261a0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89240 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 38306ea92560c82b0d70bdc195267549a8bab830) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89143 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24tdf#125682 sw: don't insert empty page before first page with even numberMichael Stahl
This mostly reverts commit 14bb680949b47332d2921cc68f75340b31ad5c32 and replaces it by a hopefully better approach: if the first page in the document has an even number, it will become a right page, and "toggle" the document so that even pages are right pages and odd pages are left pages. This is closer to what Word does; the tests adapted in the above commit were actually regressions. Add a new function IsRightPageByNumber() to determine how the page number offsets should be interpreted. Also make it explicit that even/odd and right/left page are no longer synonymous by renaming various "Odd" variables. Historically documents that start with even page number didn't work well anyway; before the above commit you'd get a left page followed by a left page followed by a right page, which is clearly nonsense if the page style differs between left and right pages - so hopefully we can do without a compat setting for those. There is still one situation where an empty page is inserted before the first page: if the page style is "Left Page"; this appears to be impossible in Word so we'll have issues exporting that to Word formats anyway. Testing: Writer pre-commit; LO 5.4/OOo 3.3: 1.odd -> right, 2.even -> left 1.even -> left, 2.odd -> right + inserts a blank page on the right after reload: 1.even -> left, 2.odd -> left, no empty page Writer w/ commit; LO 6.0+: 1.odd -> right, 2.even -> left 1.even -> left, 2.odd -> right + blank page as first page (right) after reload: 1.even -> left, 2.odd -> right + blank page as first page (right) Word: 1.odd -> right, 2.even -> left 1.even -> right but left style, 2.odd -> left but right style [technically uses terminology even/odd instead of left/right, but if mirrored, the "inner margin" is always the same and leads to interpretation of left/right] Writer and Word appear to agree on inserting empty pages on SwFormatPageDesc items/Word section breaks: both even-ness of an explicit page number and "Left Page" only page style or explicit even/odd section break may insert empty page. A useful improvement would be to detect in Word import filters that the first page is even numbered and then invert the mapping of all of the page styles, i.e. odd header/footer->left instead of right, and if mirrorMargins, pgMar left -> inner instead of outer. Change-Id: Ibed0dbf888c120a3a7d11892f40d07ffb5bc0b68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88978 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit 509a02aa96f6d7620cb0bf06c20b3bfa0641be92) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89047 Tested-by: Xisco Faulí <xiscofauli@libreoffice.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-02-24Resolves: tdf#129446 explicitly pass the mouse event windowCaolán McNamara
instead of letting it pick the main-window as the event window Change-Id: I953968025717ac5ba6f41e8f2db90c9f4d24800f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88954 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24Resolves: tdf#130762 honour "wrap" in FormattedFieldCaolán McNamara
Change-Id: Iefd9a537aa358eab179cf6f0eeb6f80a9a77284a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89011 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit 20c08e47f7c156a4726194215b389f4d0b165904) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/88953 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24tdf#130814 preserve context before page breaksJan-Marek Glogowski
... and add a comment, so nobody tries to move these again. Change-Id: I79e6f7a1538d0839fd525870439facef3218ec65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89239 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 70a9c644c63248719f1f4248e288df7ee06635cc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89142 Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-02-24Update git submodulesStephan Bergmann
* Update helpcontent2 from branch 'libreoffice-6-4' to 5521fc8d7175abd8fe2b457c677c6fab38114778 - tdf#130426 Update documentation for Basic Chr and ChrW functions ...for <https://gerrit.libreoffice.org/c/core/+/89090> "tdf#130426 Support Basic Chr(&H8000), ..., Chr(&HFFFF) again" Change-Id: I425a55ba1b055f94d993bb99c5412cc0414dc48d Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89100 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit bf2dff69f84ad28836924d3bf311910248aca1f9) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/89126 Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-02-24Postgresql native, fix readLogLevelFromConfigurationJulien Nabet
With: osl_getModuleURLFromFunctionAddress( reinterpret_cast<oslGenericFunction>(readLogLevelFromConfiguration), &fileName.pData ); The method retrieves the path to libpostgresql-sdbc-impllo.so, eg: file:///home/julien/lo/libreoffice/instdir/program/libpostgresql-sdbc-impllo.so but then instead of retrieving path + "postgresql-sdbc.ini" we obtained ".so" filename + "postgresql-sdbc.ini"=> libpostgresql-sdbc-impllo.sopostgresql-sdbc.ini Regression from 1bdb2b6f06c556b9af91dba4f29f3ac73190b09e author Noel Grandin <noel@peralex.com> 2013-11-04 13:51:21 +0200 committer Noel Grandin <noel@peralex.com> 2013-11-11 11:21:25 +0200 commit 1bdb2b6f06c556b9af91dba4f29f3ac73190b09e (patch) tree 1d941e17952cd891f5309fd862215dd09a84b001 parent 2f2416ff060c780ad87b4d3979112f52da2ae902 (diff) remove unnecessary use of OUString constructor in CONNECTIVITY module Change-Id: Ie7be4b1078760f94d34dd1f6cb9932bd7fa70962 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89303 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit abf44a9ddd084952bde4609e3f6d386f7916b68a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89275 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-02-24tdf130839: Corrects second level left margin in SmartartGülşah Köse
Change-Id: Ifec339759427336fd53012e0a8a906d240be9654 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89085 Tested-by: Jenkins Reviewed-by: Gülşah Köse <gulsah.kose@collabora.com> (cherry picked from commit eeaa7aba6e7ace8b69d7056645b15be2f996d8fb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89277
2020-02-24tdf#130274 sw_redlinehide: fix ChgAutoCorrWord() if replaced text ...Michael Stahl
... is fully deleted. This crashes on English text with 'i'->'I' substitution. The assumption that there's some part of the found text that is not deleted is only correct for the case where tracked changes are hidden, but not when they are shown. (regression from 9926ea7dd07f1f3d012ddf97941a42bb7fa5717d) Change-Id: I0e81494659ea7e187101a703f64483dd68c73d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89151 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de> (cherry picked from commit b7922b56e2dcf1dc1abbf5574bcb672068fa8dbd) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89135 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-02-24Sifr: fix for tdf#130885: missing Slide Layout iconsrizmut
Change-Id: I96ae88b4e5c4fdfbc3b2e51ec342f7c5321eec58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89307 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit a9748a444e7a295a235f2db5a217884ccb4805c2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89276
2020-02-23Breeze: Add many Base iconsrizmut
Change-Id: Iff8d95e7a5d18314420f5ef6437c4a9252717a34 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89297 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 749728631a5dfbdba06d467ba8664e971d1c8bc8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89273
2020-02-23Breeze: FIx for tdf#130879 (missing spacing char icons)rizmut
Change-Id: I06cec9c95dd803e4816ca7ef2f280802250e0511 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89294 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit 9ed2845c964819b5bce42c2ea8d8a6e57f9c204b) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89272
2020-02-23Breeze & Sifr: Fix for tdf#130875: add Envelope Orientation iconsrizmut
Change-Id: Ib76239b8259651367ca591b012a25abd89156231 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89292 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id> (cherry picked from commit cf04fc4baac9dbade930259c5cbbca7e0f8db14d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/89271
generated by cgit (git 2.34.1) at 2024-07-04 00:52:45 +0000