summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-09-27tdf#42949 Fix IWYU warnings in xmlhelp/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I266367d4f9e2b9bf637fc103a5e4876bd6b1d2b9 Reviewed-on: https://gerrit.libreoffice.org/79261 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-27tdf#116685: Make the RICHTEXT take precedence over EMBED_SOURCE.Jan Holesovsky
Before this patch, copy in Calc, Paste in Writer produced an embedded sheet. I suspect is it not what the people usually want; working with the embedded sheets in Writer is non-intuitive, I suspect people will be happier with a normal table which they can style etc. appropriately. OTOH - this is a general change, so it might have some unwanted side-effects; let's see what if we get bugreports :-) tdf#127673 was related; but in my view, we shouldn't create the embedded objects in the first place. Change-Id: I73710168d8924fdd6275d65e20cf55f38971a3f9 Reviewed-on: https://gerrit.libreoffice.org/79606 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-09-27Removed duplicated includeAndrea Gelmini
Change-Id: I7571da9c657be845c62c9f452210f55fde67883d Reviewed-on: https://gerrit.libreoffice.org/79653 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2019-09-27Related: tdf#124601 DOC import: improve fLayoutInCell handlingMiklos Vajna
There were 3 problems here: First, SwWW8ImplReader::IsObjectLayoutInTableCell() should not use m_nProduct to determine the Word version. It depends on an undocumented field of the [MS-DOC] format and the bugdoc shows how it interprets a Word 2007-produced document as a Word 97 one. Instead, parse the cswNew field of the file header, which is a more or less documented way to find out if this file was produced by >=2000 or 97. See e.g. <https://docs.microsoft.com/en-us/openspecs/office_file_formats/ms-doc/841b5f72-487e-4fe7-8657-ec90d5af8750> where the Dop structure maps cswNew values to Word versions. Second, parse the fLayoutInCell correctly: it's part of a bitfield, with two variables: a bool and an other one which decides if the bool should be read at all. The bugdoc's case was evaluated as false, so do the proper parsing in that case and leave the existing logic as-is for now. Third, there doesn't seem to be a reason to exclude the wrap-through case for the fLayoutInCell -> follows-text-flow mapping. The bugdoc shows that Word interprects fLayoutInCell the same way for wrap-though objects, too. Change-Id: Iaddd5e522e0380b731899f32a17c14ce4442ac35 Reviewed-on: https://gerrit.libreoffice.org/79629 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-09-27xmloff: create XMLDrawContentExportOOO instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: Ib63744f720a886cd67b4158399e6bf91c6efb128 Reviewed-on: https://gerrit.libreoffice.org/79660 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-27loplugin:virtualdead in svxNoel Grandin
Change-Id: I8af09a2f0a4a8c7952c5855b2934f2d0a64d9740 Reviewed-on: https://gerrit.libreoffice.org/79638 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-27external/breakpad: glibc 2.30 declares tgkillStephan Bergmann
...so building against glibc-headers-2.30-4.fc31.x86_64 fails with > src/client/linux/handler/exception_handler.cc:109:12: error: static declaration of 'tgkill' follows non-static declaration > static int tgkill(pid_t tgid, pid_t tid, int sig) { > ^ > /usr/include/bits/signal_ext.h:29:12: note: previous declaration is here > extern int tgkill (__pid_t __tgid, __pid_t __tid, int __signal); > ^ > 1 error generated. Upstream commit <https://chromium.googlesource.com/breakpad/breakpad/+/ 7e3c165000d44fa153a3270870ed500bc8bbb461%5E%21/> "Fix double declaration of tgkill when using Android NDK Headers" looks like the perfect fit. Change-Id: I1b4805886fb7c770cf9733f34a31296e6b859d92 Reviewed-on: https://gerrit.libreoffice.org/79661 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-09-27tdf#127316 ww8export: use default escapement for AUTOJustin Luth
Previously it looked bad, but not horrendous when AUTO was 101. Now that AUTO is 13999, it is obviously wrong (in Word). Better to use the default of 33. Change-Id: If0e12d315346515ce6ec5ae4bcc4110efba14f9b Reviewed-on: https://gerrit.libreoffice.org/79651 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2019-09-27Resolves: tdf#127363 accept SEPT as SEP for SeptemberEike Rathke
Change-Id: Idc0fb30308ca32428125656dc8b2ce68e35c4770 Reviewed-on: https://gerrit.libreoffice.org/79655 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-09-26menubars add separator before AutoCorrectDlg for better visibilityandreas kainz
Change-Id: If72ec102fe23b661582c80a3c194c7c3925ca9d8 Reviewed-on: https://gerrit.libreoffice.org/79578 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-09-26tdf#126967:vcl: lok: avoid starting idle paint taskHenry Castro
In the Tiled rendering case the invalidation is handled by sending logic invalidate notifications to client side. Starting an idle paint task, it provokes an infinity loop that it does not have the chance to process client side messages (mpPollCallback). Change-Id: I6ef1bbd6270592eebfeef0c8a37945bf5ddd3580 Reviewed-on: https://gerrit.libreoffice.org/79537 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-09-26Resolves: tdf#127416 unparent iconset block on dtorCaolán McNamara
otherwise gtk keeps the widgets around Change-Id: I6227662e0a8a4d5a88f4ff6199d6fa06e5be8fe0 Reviewed-on: https://gerrit.libreoffice.org/79648 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26Resolves: tdf#127218 allow changes dialog to shrink when button text changesCaolán McNamara
original the dialog has super wide button contents when the initial size is calculated, and then the buttons are changed afterwards, but the dialog remains at its initial size. Change-Id: Ib29ab9ebdec01a93561a8b304572df60b6ad5ad2 Reviewed-on: https://gerrit.libreoffice.org/79634 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26drop unused SvLBoxColorString classCaolán McNamara
Change-Id: Id78deffe002444656588fee4252a7059989d184b Reviewed-on: https://gerrit.libreoffice.org/79631 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26Resolves: tdf#127262 validity out of order focus in and out problemCaolán McNamara
Change-Id: I06f5fd0ce32a9f2d799f6003b7d22b13e865b8c6 Reviewed-on: https://gerrit.libreoffice.org/79611 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26drop some unnecessary includesCaolán McNamara
Change-Id: Ia0ad992559ecd6f7a0436de2a636391c387beff8 Reviewed-on: https://gerrit.libreoffice.org/79604 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26CppunitTest_sw_uiwriter: improve limit in testTdf105330Miklos Vajna
The problem was that the cursor was invisible. I thought that we can assert that the cursor height is 12pt + the linespacing (276 twips), but turns out the exact value is subject to pixel-alignment, so it's not a good test to require equality. Instead, make sure that the height is at least the 12pt, which is explicitly defined in the document. That fails without the fix, and is a saner limit. Change-Id: I4f9f512542cefc6fa20d6fdf02e9eb5d2e1c1d5e Reviewed-on: https://gerrit.libreoffice.org/79636 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-26tdf#127316 docxexport: use default escapement for AUTOJustin Luth
Previously it looked bad, but not horrendous when AUTO was 101. Now that AUTO is 13999, it is obviously wrong. Better to use the default of 33. The import algorithm still could use some work since it round-trips as 51% and not 33%. Change-Id: Id984ea3e6e0b50014389ec8a86668b7a271b96f4 Reviewed-on: https://gerrit.libreoffice.org/79628 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Justin Luth <justin_luth@sil.org>
2019-09-26loplugin:virtualdead filter out some more stuff Noel Grandin
in the post-processing step Change-Id: I5c57f9ded6a52d541694c5972656e33bb7771de6 Reviewed-on: https://gerrit.libreoffice.org/79637 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26loplugin:virtualdead in vclNoel Grandin
Change-Id: I54cacce6d843f41f220ac5350868bd6d70dbc6b4 Reviewed-on: https://gerrit.libreoffice.org/79585 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26add property name when throwing css::uno::UnknownPropertyExceptionNoel Grandin
Change-Id: I17f06c9415b9d43b6d8896360e07216c2856367a Reviewed-on: https://gerrit.libreoffice.org/79627 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26tdf#76324 speedup copy operation with lots of comments in calcNoel Grandin
avoid performing a sort in AddShape, and cache some data to speed up the sort Makes it about 3 times faster for me, but is still pretty slow for that large test document Change-Id: I5c847e43ad5dd66caefcf12b9a624214767371b1 Reviewed-on: https://gerrit.libreoffice.org/79630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26loplugin:virtualdead in sw(2)Noel Grandin
Change-Id: Ib948148fa21d595faa8a4a86d4f47243755885ee Reviewed-on: https://gerrit.libreoffice.org/79588 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26weld ORelationDialog and DlgQryJoinCaolán McNamara
Change-Id: I15c0745d387e491dd05e14949d744d0a27a8dd49 Reviewed-on: https://gerrit.libreoffice.org/79600 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26get toplevel GtkWindow if parent is a child frameCaolán McNamara
Change-Id: I9645259dd8c7fb331b2efab3f441422ee1f07c12 Reviewed-on: https://gerrit.libreoffice.org/79599 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26update sd pchCaolán McNamara
Change-Id: I3175fa36f006c47933c96288e8e5812ba6d77bb9 Reviewed-on: https://gerrit.libreoffice.org/79592 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26drop unnecessary includesCaolán McNamara
Change-Id: Ie7dcf55a78ec896ba937c521b59c0a1f2bbb6e94 Reviewed-on: https://gerrit.libreoffice.org/79598 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26loplugin:virtualdead in swNoel Grandin
Change-Id: Ib96caad8a2bbfc4ff9a5191abbd49789d142d2eb Reviewed-on: https://gerrit.libreoffice.org/79587 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26weld DataEditorCaolán McNamara
Change-Id: I8b59140d2e2b0892f17159282a1aeb1a47008ba0 Reviewed-on: https://gerrit.libreoffice.org/79561 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26TODO rename to GetFrameWeldCaolán McNamara
Change-Id: I28527b6773075fe682682a4812cf86bb7ac13180 Reviewed-on: https://gerrit.libreoffice.org/79560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26weld SwAutoMarkDlg_ImplCaolán McNamara
Change-Id: I64fc2b503f76b61ea8c2f26c8170c72611935131 Reviewed-on: https://gerrit.libreoffice.org/79533 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26source/core/access: no more SwClientBjoern Michaelsen
- also, move BroadcastingModify up from TextNode to ContentNode Change-Id: I4e6e8767aaecb9cce20d5ec3da789532686dfe2a Reviewed-on: https://gerrit.libreoffice.org/79525 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-26SwAccessibleTable/SwAccessibleTableColHeaders: SwClient no moreBjoern Michaelsen
Change-Id: I0ca9f9d38f9f990fe4a41319d8dbd9b204544f49 Reviewed-on: https://gerrit.libreoffice.org/79506 Tested-by: Jenkins Reviewed-by: Björn Michaelsen <bjoern.michaelsen@libreoffice.org>
2019-09-26drop newly unused SfxModalDialogCaolán McNamara
Change-Id: Ia06713c9766a6731995c83ed0516535d13665ff1 Reviewed-on: https://gerrit.libreoffice.org/79526 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26survive focus change during disposeCaolán McNamara
Change-Id: I34b5941b01bc0880945aaae39e0b7c4beb4e0575 Reviewed-on: https://gerrit.libreoffice.org/79559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26tdf#42949 Fix IWYU warnings in sd/Gabor Kelemen
Recheck sd/ after recent refactorings and developments Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I6f0fd19c52889cbd85b387183e2136bca4a1eeca Reviewed-on: https://gerrit.libreoffice.org/79218 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-26Remove some unused includesMiklos Vajna
Change-Id: Ic28b4bdd401342d92b33913f7dab0ca875f8aab3 Reviewed-on: https://gerrit.libreoffice.org/79573 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-09-26writerfilter: fix crash on import of tdf113230-1.docxMichael Stahl
The SvxUnoTextBase::finishParagraph() returns null because there's no GetTextForwarder(); in any case the ListId property isn't supported by SvxUnoTextRange. (regression from 7992bd73a2307edce96a145e954f8e4c3ab9f57d) Change-Id: I8f63d805a593a5950c8cb08eaeebd34e977b4700 Reviewed-on: https://gerrit.libreoffice.org/79552 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2019-09-26loplugin:constmethod in scNoel Grandin
Change-Id: I78c4fb4acf21756f91582caee5e30e3ad1fc2ae4 Reviewed-on: https://gerrit.libreoffice.org/79543 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26Fix range selection in chart wizard for onlineSzymon Kłos
In the Online when range was selected in second step of the Chart Wizard, main window become unresponsive. This fix blocks doubled MouseButtonUp event and allows to fold/unfold multiple times the range selection dialog by allowing to use that window type in SetRefDialog. Change-Id: I9f64cf7a110ab9264bc53dd740f0caf576764714 Reviewed-on: https://gerrit.libreoffice.org/79570 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-26Allow dialogs to create multiple instances in OnlineSzymon Kłos
Change-Id: Ia4d5ff42cc7542319966523aa843e7494b544375 Reviewed-on: https://gerrit.libreoffice.org/79569 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-09-26drop unnecessary includes and update pchCaolán McNamara
Change-Id: Id7fa7d5b95c32fdc738a18208eb95eaec102d937 Reviewed-on: https://gerrit.libreoffice.org/79523 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26now drop TabPageParent intermediateCaolán McNamara
Change-Id: I47328f76342ac023628d9042bdfa8213a1c93d0c Reviewed-on: https://gerrit.libreoffice.org/79469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26disinherit OWizardPage and SfxTabPage from vcl TabPageCaolán McNamara
Now that there's no need to support weld/unwelded mixes of pages in dialog any more. inherit from a BuilderPage which contains a Builder and Toplevel container BuilderPage Activate and Deactivate replace TabPage ActivatePage and DeactivatePage, allowing disambiguation wrt SfxTabPage ActivatePage and DeactivatePage. Change-Id: I5706e50fd92f712a25328ee9791e054bb9ad9812 Reviewed-on: https://gerrit.libreoffice.org/79317 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-09-26tdf#127673 lok: On double-click, don't enter the embedded objects in Writer.Jan Holesovsky
There are all sorts of problems when we'd try to edit the embedded objects, like that that LOK thinks it is a separate view etc., so better to disable it for now, before we really need to edit embedded objects. Change-Id: Ie8c0249cb0ca8b25a2ac97c1ccec4a5a62cbb770 Reviewed-on: https://gerrit.libreoffice.org/79555 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-09-26gtktiledviewer: Turn an annoying assert into a compile-time check.Jan Holesovsky
So that people don't forget adding the enum values here... Change-Id: I0342e2ecca4d7d14641e44ca562b1999921182e8 Reviewed-on: https://gerrit.libreoffice.org/79554 Reviewed-by: Jan Holesovsky <kendy@collabora.com> Tested-by: Jan Holesovsky <kendy@collabora.com>
2019-09-26loplugin:constmethod in embeddedobj..extensionsNoel Grandin
Change-Id: Iec6a9ff8b62ac1986cca205435273b64b71f33cd Reviewed-on: https://gerrit.libreoffice.org/79539 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26loplugin:constmethod in vbahelperNoel Grandin
Change-Id: I40a59224286cb1eaece58f5f52b26f9191171be8 Reviewed-on: https://gerrit.libreoffice.org/79581 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26new loplugin virtualdeadNoel Grandin
to look for virtual methods where all of the implementations of that method do nothing useful Change-Id: I623456ade1c55fe8048d23f69cb692540378daa4 Reviewed-on: https://gerrit.libreoffice.org/79579 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-09-26tdf#127748: crash on modify a frame style, which has writing-mode bt-lrJulien Nabet
bt here: https://bugs.documentfoundation.org/attachment.cgi?id=154474 Change-Id: I6e6e0927ea85c4f0f4f59bf327ce5468fc428328 Reviewed-on: https://gerrit.libreoffice.org/79572 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
generated by cgit (git 2.34.1) at 2024-08-03 16:21:39 +0000