summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-05-06"resolved" is a better name than "isResolved" hereStephan Bergmann
...as the variable is true if any of the unresolved depedencies got resolved now, rather than anything specific that "is resolved" now. This partially reverts be729e772196f33543e21cb9bac21add87726b20 "tdf#94269: Replace 'n' prefix for bool variables with 'b'". Change-Id: I14c0b3872aaf320baedb349b1cfdd1ed29417dfc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93569 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-06Resolves: tdf#123801 captioning issuesCaolán McNamara
revert attempt to by default create a msword roundtrip friendly caption. commit 2333786aa0eaf70c45c80e546239fb3565b1b4e7 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Mar 20 11:48:28 2018 +0000 Resolves: tdf#116474 bring hidden text property under undo control commit ebd43aee5b9cf98ed96ce28985267ad0bc980b7a Author: Caolán McNamara <caolanm@redhat.com> Date: Fri Apr 7 13:41:38 2017 +0100 rework setting hidden property on line break commit feedd45ba2dd308af2d3a1b2f64681b9467535b6 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Oct 27 14:37:03 2016 +0100 in msword the hard-break between image and caption has a width commit ba401ee10be2fb051bc961680f35b04e4e77a32d Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Sep 1 09:39:37 2016 +0100 coverity#1372378 Dereference null return value commit 93ab0ff24cb71c36c9e7958046e96d7472b5af90 Author: Caolán McNamara <caolanm@redhat.com> Date: Thu Sep 10 15:46:57 2015 +0100 Related: tdf#93676 default to as-char inside captions Change-Id: I460046a10f36bed13e2f4651b4c0a9b9b0662015 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-06Colibre: tdf#132749 Add extra large localized iconsRizal Muttaqin
Change-Id: Ie4e869697e827f9a5262375258eb9ff0288f0dec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93560 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-05-06Remove support for "module" layersStephan Bergmann
f4d8090a484f99970f00bab2aa9b9f8d6cbe4fdc "Drop support for long-gone share/registry/modules layer" stated: "Support for 'module' layers in configmgr/source/components.cxx is still needed for gb_CppunitTest_use_filter_configuration in solenv/gbuild/CppunitTest.mk." But that need is meanwhile gone since e1b51e7beb7f9cfa7b574b9c2a69799e62963a09 "gbuild: use .xcd configuration files from instdir" removed gb_CppunitTest_use_filter_configuration. Change-Id: Ide8d69e79272df7c450edfb1e763e3dcc8f257e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93546 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-06Move all public Java classes to libreoffice.jarSamuel Mehrbrodt
This moves the classes from juh.jar and ridl.jar to libreoffice.jar The goal is to have one single jar (and Java module, will be added later) which developers can include to work with LO. juh.jar and ridl.jar are kept as basically empty jars with libreoffice.jar on its classpath to keep backwards compatibility. This is a continuation of ae855bf48163ff64d94cfc34aff8e37abdb5518d and a preparation to have Java 9 module support. Change-Id: Ifbbfb97f60373d14256e62ae3122913bd17d5bbb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-06make screenshot build failureCaolán McNamara
Change-Id: I9239bc2789e0c832059704837916881cb5a3756c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93550 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-06allow disabling Skia's Vulkan use in safe mode (tdf#132439)Luboš Luňák
Change-Id: I2991ace387356f049fba1a730041bbb4c62c876c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93562 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-06always build Skia optimized, unless --enable-skia=debugLuboš Luňák
In raster mode the performance may make quite a difference, this is the drawing library (that's now the Windows default) and LO developers mostly do not need to debug Skia itself. Change-Id: I42f0407d37a2294b062a41d94566e8a4f5f4354b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93557 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-06tdf#101181: implement glow effect also for SdrGrafPrimitive2DMike Kaganski
... using the implementation from f9fc420dceb1ece2c98767da16a21aaff771f140 that is already functional for SdrCustomShapePrimitive2D. For now, only for Draw/Impress. Change-Id: I4936e8276df2b21cb5c438e89c215b819e9b8a40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92636 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-06tdf#130778 revert Windows installer legend imagesRizal Muttaqin
- Tiny update for about.svg file Change-Id: I8dc6c3275ab05932f8825c675bcbc693d683f275 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93518 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-05-06tdf#132603: sw: Add unittestXisco Fauli
Change-Id: I2706ba434034aa4307619cde12f020deb40d669e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93509 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-06Template: add Draw BPMN templateandreas kainz
Change-Id: Ib3dca0ea391718bb92827764f197fe24143e9805 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93514 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-06Access2Base - Version number 7.0Jean-Pierre Ledure
Change-Id: Ia75b4e02bd6def84d66ae89c1c4a688e8a027c23
2020-05-06This comparison is redundant, radiuses are compared belowMike Kaganski
Change-Id: Idb98314877518beefdd12dd95bbbb055f3aa429d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93549 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-06Use default ctorMike Kaganski
Change-Id: I1f692f706f2e688384c01e99c14307190bf70104 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93548 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-05-06batch polyline drawing for basegfx::B2DLineJoin::NONE if small widthLuboš Luňák
For pixel-wide lines it should not make a difference. Change-Id: I28a9034eef9a81c6899c5fae679af5e413ee981c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93435 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-05-06Remove an unused includeMiklos Vajna
Change-Id: I8acfaceea2b0f88d5783ef864c294c048f0ab3e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93519 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-05-06pyflakes3: fix undefined name 'self' (wizards/access2base)Julien Nabet
Change-Id: I12083c0e85d9e9a63843b26648c4b5c8580efc7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93523 Tested-by: Jenkins Tested-by: Jean-Pierre Ledure <jp@ledure.be> Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2020-05-06sw layout: remove useless historical timelog commentsJustin Luth
While there can be value in seeing bug numbers to figure out why certain code was added, these comments seem to have no value, but are just a timelog of when a formatting change was made. Change-Id: I47ccef9c7e4cd5c76aeec46867424dd8c9d05e13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93441 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-06tdf#132373 Remove blinking character property from the UI/editorGabor Kelemen
So far from document body and Character properties tab only. Importing and exporting existing files still works. Change-Id: I42179b47c64fe5c7db0393d0d4373363d772b51e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92875 Tested-by: Jenkins Tested-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-06tdf#108493 DOCX import: fix hanging indent of listsLászló Németh
when its value comes from the numbering style, but the left indentation is overwritten by paragraph settings. The problem caused by that these settings are not independent in Writer core. Change-Id: I5d6759bb215b82dfcaa5cbd3e191ac7ea8a8bb00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93478 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-05-06Resolves tdf#132701 - macOS installer image must be 72dpiHeiko Tietze
See also 12b389e838743dec662c70c4772553a96ad4f9ac Change-Id: Ib46cd37e29beac4c18b2f9ce5a74b01f6c357cbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93500 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-05-06tdf#79082 Export paragraph tab stops to ooxmlSamuel Mehrbrodt
Change-Id: I7d25dc1ab3c960aafc07a3be69b54f5aceef23fe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93462 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-05-06Colibre: Fix for tdf#132735 wrong Smooth Image Filter iconsRizal Muttaqin
Change-Id: Idfbb526c570eb9438cda9f798cd24ea28e491a5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93513 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-05-06Sukapura: fix for tdf#128689 wrong Korean vertical text iconsRizal Muttaqin
Change-Id: Ic21bc2091184087b711f2ee4d2ec4a5451681faf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93457 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-05-05tdf90341 Clean up excessive const_cast'ingMesut Çifci
Change-Id: I6ab4f077325b7d8b9651475a5b776e7c3ddd9636 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93472 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-05Disable -Wstringop-overflow in --enable-optimized builds with GCCStephan Bergmann
This reverts commit e287fde52fb9de5bdf1d00c8a3fbfcca7db9892c "Silence bogus -Wstringop-overflow with GCC trunk towards GCC 10", as that workaround, which happened to work for some revisions of GCC trunk towards GCC 10, no longer works for GCC 10 release candidates, see <https://gcc.gnu.org/bugzilla/show_bug.cgi?id=92893#c9> "[10 Regression] Unhelpful -Wstringop-overflow warning for a trailing one-element array". (Using -Wstringop-overflow=1 instead of the -Wstringop-overflow=2 default would have still caused bogus warnings, requiring -Wno-stringop-overflow.) Change-Id: I9b7342748c18da32f509b4a0e0653aede8447657 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93499 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-05-05Resolves: tdf#131536 TEXT() support empty format string mimicking ExcelEike Rathke
Change-Id: Iffc37179cafb8b8bcfa1232e7aa54ae119ab5846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93504 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-05-05sw from-bottom relative orientation: fix calculation of position limitsMiklos Vajna
Create a new Writer doc, insert a rectangle with height = 10cm, try to position it 2cm above the bottom of the page, so that would be -12cm, but we limited the metric field to -2cm because 2cm was the page margin. Teach SwFEShell::CalcBoundRect() about text::RelOrientation::PAGE_PRINT_AREA_BOTTOM, then this will work without problems. Change-Id: Ib6ddccc1512d39fff5bff2e989973b156a6c2bf7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93501 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-05Gallery: add styles support to bpmn gallery itemsandreas kainz
Change-Id: I80e94b07fb4b5665bc4c677d1accb6939c131af7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93498 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-05-05fix line width in DrawPolyLine() with matrix (tdf#132498)Luboš Luňák
For backends that do the object-to-device coordinates transformation directly, it's necessary to also convert the size of line width. But simply multiplying it with the matrix can also rotate the line width "vector", making it e.g. negative. So don't use just the X coordinate, use vector length for the transformation, which is ok. In fact it doesn't even make sense to treat width as a vector, because a width simply is not a vector (and for this reason it's also not actually used). Change-Id: I1241c9cb29155df105170d568a879ebc32b11a5f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93203 Reviewed-by: Tomaž Vajngerl <quikee@gmail.com> Tested-by: Jenkins
2020-05-05writerfilter: cleanup out-of-order xText <-> xCrsrJustin Luth
This looks mostly like copy/paste proliferation of a pointless test for xText after it has already been used. Since this has already been working for years, there is no point in testing if xText.is(), since it would have crashed if it wasn't during the xCrsr definition. Change-Id: I6a032c0bdc7bb587f223f191623a2e3885d444bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93412 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-05-05tdf#118655:Move Wildcard/Comments option above Regular expressionsAditya
Place "Wildcard/Comments" option in find and replace dialog above "Regular expressions" option and the "sounds like (Japanese)" option in place of the older location of "Wildcard/Comments". Change-Id: I83dffb0689f128ad31b9223bc98ecc5914e4bf41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93410 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-05-05remove unused nSearchFamily and nMask membersCaolán McNamara
and so SetSearchMask which doesn't have any effect anymore Change-Id: I0b7f402ce0317971d5196fc448fe2945a6a292f5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93393 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05if we create a new style remove any old style with the same nameCaolán McNamara
surely the current searchmask should have no effect on the remove seeing as a new style is going to be created unilaterally Change-Id: I4a8d05be26a3a2711ae6f377f034a9155100e831 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93496 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05drop newly unused SfxStyleSheetIterator::GetSearchFamilyCaolán McNamara
Change-Id: I19eeb705e1eff352cd9f95f63f65b81732c6c591 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93495 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05drop newly unused SfxStyleSheetBasePool::GetSearchMaskCaolán McNamara
Change-Id: Ifa719bf33b64b407d74d68df4d1b825ba9f1b89f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93494 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05use SfxStyleSearchBits::Auto as fallbackCaolán McNamara
instead of SfxStyleSheetBasePool::GetSearchMask() Change-Id: I2ca3ccc775f30f0ffa99f6cc2c41c69c6d401010 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93493 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05we end up making a nFamily style, not the style of GetSearchFamilyCaolán McNamara
so use that as the filter Change-Id: I91ef5b07ccbe9a4ceafa86e2331ea72bebe38145 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93492 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05help states that SfxNewStyleDlg lists SfxStyleSearchBits::UserDefined stylesCaolán McNamara
Change-Id: Ibf89d0ff1154b943a5650ac6cd6aa64a084c15cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93491 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05use SfxStyleSearchBits::All for SfxNewStyleDlg in writer, like calc doesCaolán McNamara
Change-Id: I44399a617b07acb93ca33d537bcfcc5554e1ede5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93490 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05Update git submodulesLibreOfficiant
* Update helpcontent2 from branch 'master' to 6522d1a261301211b35885ee9709f64f9a587edb - tdf#131416 Syntax diagrams - Print & Select Case statements - GoSub,GoTo, On…GoSub/GoTo statements - section reuse + x-refs Change-Id: I785d46013d7e8e9f571b2a2d2abaa3e2e41d223f Reviewed-on: https://gerrit.libreoffice.org/c/help/+/93376 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-05-05Icons: fix for tdf#128689 wrong Korean vertical text iconsRizal Muttaqin
Change-Id: I21b4f1c11f65554b5bc7fc15c71770be49e33882 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93476 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-05-05don't need to save and restore the search mask if it doesn't get changedCaolán McNamara
Change-Id: I19ee6a916017cb49092a2b74bc2bfd9b99b8c72d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93489 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05tdf#132187: sw: Add unittestXisco Fauli
Change-Id: I767f96fd8d373df9b8cbecd9cb75ed114166d0f8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93485 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-05-05Fix typoAndrea Gelmini
Change-Id: Id033f67d886665dcb2cb7755f8461cfd3ea5cebe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93488 Tested-by: Jenkins Reviewed-by: Andrea Gelmini <andrea.gelmini@gelma.net>
2020-05-05sw from-bottom relative orientation: add UIMiklos Vajna
And fix the value of LAST: it seems this went wrong in commit c2fc91664f71c447209d2cd29c0df1d7faba4927 (Convert LB flags to scoped enum, 2016-05-14), where the upper limit went from 0x80000000 to 0x080000, which means it started to matter if we allow equality or not. Other places compare LAST without allowing equality, so leave that unchanged and instead give LAST its own value. Change-Id: I0ceac18475f5f50b792c7a8442648c9ba2a25236 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93477 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-05-05use GetFamilyItem_Impl to determine the active familyCaolán McNamara
Change-Id: I1ddb4a0312f87cb549e5a054f79a72210af082a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93475 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05SearchMask doesn't have a bearing on whether to enable/disable tree dragCaolán McNamara
Change-Id: Id537a7a57adc6245025abb899fc9cfa61fb33d42 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-05-05Prefill doc count in mail merge's "Send Email" dialogMichael Weghorn
Initialize the last document number with the doc count in the "Send Email Documents" mail merge dialog, just as is done for the "Print Merged Documents" and "Save Merged Documents" dialogs already. While at it, also set maximum value for the "from" spinbutton for the "Print Merged Documents" dialog. Change-Id: Idbd6d07eb7a21f2abf27ee06e7170125e1c706f4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93459 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>