summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2016-05-12rejig for legibility, no logic changeCaolán McNamara
Change-Id: I73418e29dd85488613ea5c54ca8d505715ed3cbf
2016-05-12in non-debug build, leave sPath emptyStephan Bergmann
(avoid -Wimplicit-fallthrough with NDEBUG) Change-Id: I60332c4b05c805a7972189774283cdd518f77af0
2016-05-12loplugin:stringconstantStephan Bergmann
Change-Id: I5515f35871b23b67564d5eda52bf3323e7e047bb
2016-05-12Massage code to avoid warningsStephan Bergmann
Change-Id: I847e1a109bd20e64161a7735ee30b2fe1ca507b0
2016-05-12WaE: -Werror=logical-op dynamic_cast dbg test is on the result not inputCaolán McNamara
Change-Id: Ib3750fe1d2ce480beb5b4c512ed74701f29eecfc
2016-05-12Massage code to avoid warningsStephan Bergmann
Change-Id: Id86085e60c588d80ae50e8e5af07f2065b89048c
2016-05-12Replace comment with SAL_FALLTHROUGHStephan Bergmann
Change-Id: I9ccba0369453af3b4b3328b9fca94429369c6524
2016-05-12Replace comment with SAL_FALLTHROUGHStephan Bergmann
Change-Id: Ibc5937b852ee8220d5d347e18a824df4c97ade40
2016-05-12dbaccess: replace boost::bind with C++11 lambdasMichael Stahl
Change-Id: I468f9c7af9c8c8189c51790e0301dd8c60a9f83c
2016-05-12sdext: replace boost::bind with C++11 lambdas, part 2Michael Stahl
Change-Id: Ife5fbf7a7a41182de00dca339cba160e3bb0062f
2016-05-12warn to info for something that isn't a surpriseCaolán McNamara
Change-Id: I7427d2970d81d700f1ecc3e48c33ffb5a8045f2c
2016-05-12mpDefDialogParent is not used since 2002Caolán McNamara
i.e. commit c0ae87cb5f2989bc4b8dff4907994d513ee87e39 Author: Stephan Schäfer <ssa@openoffice.org> Date: Tue Oct 22 08:39:05 2002 +0000 #103442# choose DefDialogParent on-the-fly and so calling SetDefDialogParent doesn't achieve anything Change-Id: I2ec72da47b2dac03fdddbdb9eba5ae4bf205eb22
2016-05-12Massage code to avoid warningsStephan Bergmann
Change-Id: Iec529b4750770c52aa0a746390ba272ce6390fb5
2016-05-12Replace comment with SAL_FALLTHROUGHStephan Bergmann
Change-Id: Iff490d06eaf73e0b55bfb7aa6c41b5fd3851ea44
2016-05-12Missing SAL_FALLTHROUGH (see comment above)Stephan Bergmann
Change-Id: I25d7c76462699e0f206e622841744fef9527108b
2016-05-12simplify SalGraphics::copyArea flags argumentNoel Grandin
Change-Id: Iaaef4d90d7fe817a32cd51652d41c2e49c8909a4 Reviewed-on: https://gerrit.libreoffice.org/24832 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12clang-tidy modernize-loop-convert in swNoel Grandin
Change-Id: I1f4a0ad6658bd3154c48940296aa8edc1ea1612c Reviewed-on: https://gerrit.libreoffice.org/24876 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12clang-tidy modernize-loop-convert in svxNoel Grandin
Change-Id: I09e5243e5dff46ceccef1a707e648ee9cb0c37c5 Reviewed-on: https://gerrit.libreoffice.org/24875 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12Convert SFX_EXTRA to scoped enumNoel Grandin
Change-Id: I57fa684d91d10a132c718152ca646edd1c7bd189 Reviewed-on: https://gerrit.libreoffice.org/24882 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12convert SFXWB file dialog flags to scoped enumNoel Grandin
Change-Id: I1ab5191dc582c46785da58d50b2e68c30b5cbc9b Reviewed-on: https://gerrit.libreoffice.org/24881 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12Convert RulerType to scoped enumNoel Grandin
Change-Id: I2233b70e5413bfa3156011e1b3306d539003795b Reviewed-on: https://gerrit.libreoffice.org/24879 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noelgrandin@gmail.com>
2016-05-12loplugin:stringconstantTor Lillqvist
Change-Id: I9eed9713a0d208e7aa4cdddc0cedb97edf831239
2016-05-12loplugin:defaultparamsTor Lillqvist
Change-Id: I4905e4c1dd72dabe2229d99742ee0012295a9742
2016-05-12-Werror,-Wimplicit-fallthroughTor Lillqvist
Fix "fallthrough annotation in unreachable code". Clang is clever enough to know that code after assert(false) is unreachable in a non-NDEBUG build. Seriously, micro-optimisation of the case that should never be reached? Change-Id: I10d7ae60895437be52c27aa93539d17e0f091ac4
2016-05-12Silence bogus GCC 5.3 -Werror=strict-overflowJulien Nabet
Thank you Stephan for the hint! Change-Id: I22b5a9c9e65297cba5a2894e46d2fee59825a045 Reviewed-on: https://gerrit.libreoffice.org/24900 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-12Convert FLG_* to scoped enumTakeshi Abe
Change-Id: If767fff10a0bb28735578b4ec3dcf7b9e2d326a2 Reviewed-on: https://gerrit.libreoffice.org/24872 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Takeshi Abe <tabe@fixedpoint.jp>
2016-05-11sal: -Werror,-Wimplicit-fallthroughMichael Stahl
Change-Id: Id8262e735b9f95d8b476a4939c362648e2a4328a
2016-05-11-Werror=unused-variable for non debug buildJulien Nabet
Change-Id: I110ae4973e98b0fa3c8c5273e778eab9ddcd7476 Reviewed-on: https://gerrit.libreoffice.org/24899 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2016-05-11Resolves: tdf#99464 set what parent the dialogs are dialogs forCaolán McNamara
With nullptr a parent is searched for and assigned (unless NoParent is set which means no parent) since... commit dd46727b99d4bb5135451aa7e5e1bdb197373843 Author: Caolán McNamara <caolanm@redhat.com> Date: Tue Apr 5 15:27:38 2016 +0100 Resolves; tdf#87120 no keyboard navigation inside floating windows lets try and treat these the same as we do normal toplevels like dialogs if they popup with GrabFocus. This way focus can be set on widgets inside the floating windows, and so keyboard traversal of widgets etc all works. I believe an active menu is allowed as a parent (which I'll investigate and see if we can fix or revert that if necessary), but its good practice to explicitly set the right parent rather than depending on what happens to be on top anyway. Change-Id: I744f6d9bc133058a4a9db94d6c27d2e36e22179e
2016-05-11slideshow: tweak ListenerOperations<std::weak_ptr<ListenerTargetT>>Michael Stahl
Pretty sure FuncT(...value_type) is wrong since value_type is std::weak_ptr which does not implicitly convert to a callable pointer; this caused build failure on Mac OS X with clang/libc++. Change-Id: Id9de4a7825347a84cce2aab5367a457a003bb352
2016-05-11slideshow: replace boost::mem_fn with C++11 lambdasMichael Stahl
A bit more verbose but we have less than 10 mem_fn now so better elimintate them all so hopefully we can get rid of the corresponding boost warning patches. Change-Id: I79e2f9994841125916d92bdce9973d956f2a68ce
2016-05-11sd: replace boost::mem_fn with C++11 lambdaMichael Stahl
Change-Id: I5502730d042d385033f34ae888835637376ffb44 Reviewed-on: https://gerrit.libreoffice.org/24887 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-11sdext: replace boost::bind with C++11 lambdasMichael Stahl
Change-Id: I2a30e764b96530e21d5ff201b18f98d1cd334a6d Reviewed-on: https://gerrit.libreoffice.org/24888 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Stahl <mstahl@redhat.com>
2016-05-11sc: Add new param, DontTerminateEdit, to .uno:SavePranav Kant
... which determines if current editing mode before save should be terminated with save or not. Change-Id: I49318013f1244eb8681a19ed3da50fbecd336a3d
2016-05-11lokdocview: Add debug info; paintTile rendering timePranav Kant
Change-Id: Icdb14e9a5fedb3dcfbad502e323b333c3dbcc534
2016-05-11tdf#98924 In windows, change the keyboard layout per applicationJuergen Funk
reint the key maps when in windows change the language for the application Change-Id: I71045386b4fe4d6db5572effa07a2f01ce79e74f Reviewed-on: https://gerrit.libreoffice.org/23556 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-11Enable Clang -Wimplicit-fallthroughStephan Bergmann
...now that all intended ones are marked as SAL_FALLTHROUGH. Change-Id: Ibc76299cdac0d33285a47b106e7a548a5efffcbd
2016-05-11Mark dubious fallthrough cases as "SAL_FALLTHROUGH; //TODO ???"Stephan Bergmann
Would be great if people knowing about the respective code areas could look into these, and either change them into plain "SAL_FALLTHROUGH;" or "break;". Change-Id: I6bd5e04bbb84452bea57d10946522b456c2ad5f0
2016-05-11Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I4394a2e54da7c8a0e998db818211b0935b4cb1cd
2016-05-11SAL_FALLTHROUGH is intended hereStephan Bergmann
...given 8100100298b877765e1781fb0eed285e82749ad1 "fdo#80167 RTF export: don't loose page breaks" (and confirmed by Miklos on IRC) Change-Id: Ib70df00c565c5ec163fb13ead501d2100743d2dc
2016-05-11set parent window of windows system file picker on save(as)Oliver Specht
If no parent is provided the Windows system file picker uses either the current foreground window or the desktop. The decision depends on the thread id of the foreground window. To make sure the document window is used as parent this is now also sent to the system file picker as it was already done for the internal file picker. Change-Id: Id589cbc1f91db30e065175aaea42ef1512ffb1b9 Reviewed-on: https://gerrit.libreoffice.org/24635 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-11Looks like SAL_FALLTHROUGH is intended hereStephan Bergmann
...given 3006acbabc363af9dfe7deab11759678ababb7b9 "New: Vertical flag" Change-Id: I99c89017f43aeb6f7cf2808dffc498b99d8765fc
2016-05-11tdf#98981 added initialization of e-Mail configuration QueryBoxOliver Specht
Change-Id: I96a742439825ae422bc345294c2964159d168d3f Reviewed-on: https://gerrit.libreoffice.org/24650 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2016-05-11Fix horrible codestyleSamuel Mehrbrodt
Change-Id: I3bbeb625abd9ba130fc6fea97689ead682fa074b Reviewed-on: https://gerrit.libreoffice.org/24893 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2016-05-11Missing break in switchStephan Bergmann
caused by c2ea2e6ca99395cc6d9ea8f2edf009252dc87957 "coverity#704901 Dereference after null check" Change-Id: I7e53493bcb2857ccc840429cd2fd2e802180aa19
2016-05-11Looks like SAL_FALLTHROUGH is intended hereStephan Bergmann
...given how 85789fbad4d47007e27db277839fdc12b9eb09a7 "Fix #85710#: Changing content anchor but not anchor type" changed the code Change-Id: Id19b277ecbc4f39577cc622a486c58ee15bdc520
2016-05-11Add SAL_FALLTHROUGH, where apparently appropriateStephan Bergmann
Change-Id: I34629f1f4c77aaf12bb9b668b24f98e8d3e8eaef
2016-05-11Missing break in switchStephan Bergmann
The case SID_CURRENTDOC used to harmlessly fall through to case SID_ATTR_SIZE://XXX ??? break; which was removed with ebabf6d1fa648d62dd63529e9fe64dcb631caee8 "fdo#86018 Don't do anything when clicked on placeholder in statusbar", making it erroneously fall through to the case SID_PRINTPREVIEW instead. Change-Id: Ib7792ed4198ea3e25696a63f0d7ab4df78848e6a
2016-05-11sd: remove pointless micro-optimizationMichael Stahl
Change-Id: Ib5c9e79d21969922feeed5cd1908f238608401e4
2016-05-11loplugin:implicitboolconversionTor Lillqvist
Silly fix for "Implicit conversion (IntegralCast) from 'bool' to 'gint8' (aka 'signed char')". The GLib TRUE is defined as !FALSE, thus it is a bool value, which the loplugin doesn't then like being assigned to a 'signed char'. Change-Id: I04ae41c0ff89adad8962954e04215026b5f79c4c
generated by cgit (git 2.34.1) at 2025-02-26 18:19:12 +0000