summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-07-10replace usage of whitelist with allowlistThorsten Behrens
Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Common::Misc::OpenCLWhiteList -> OpenCLAllowList Change-Id: I65636b19b13e4af1e4851f70e78053f3443d6bb1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98181 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-10replace usage of blacklist with denylistThorsten Behrens
.. and a few cases of instead doing blacklist->excludelist where that made more sense. Background and motivation: https://tools.ietf.org/html/draft-knodel-terminology-02 [API CHANGE] officecfg::Office::Canvas::DeviceBlacklist -> DeviceDenylist [API CHANGE] officecfg::Office::Canvas::BlacklistCurrentDevice -> DenylistCurrentDevice [API CHANGE] officecfg::Office::Common::Misc::OpenCLBlackList -> OpenCLDenyList Change-Id: Ia35e25496bf0cc0692d5de4cb66bfc232d3a869e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98180 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-10tdf#100348 add fill to fontwork in export to pptxRegina Henschel
This patch adds fill to the characters in a Fontwork shape in export to pptx. It does not contain export to docx and not import. Change-Id: Ie7c8a35380a845f513516636c4f60ee307eacd50 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98187 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-07-09tdf131562: sc_macros_test: Add unittestXisco Fauli
Change-Id: I08e8dd0230a6c900d0a88a015d066bffc2e8e8b5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98475 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-09cid#1401334 Uncaught exceptionCaolán McNamara
Change-Id: I6530f653f80bb3db73cef28340db2ffcac3573d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98421 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09Resolves: tdf#134674 object inserting using dialogs SdrModelCaolán McNamara
not the target Documents one Change-Id: I07088bddc7c15109e7d377f86c6d0a7819faa658 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98423 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09tdf#124454: sc: Add unittestXisco Fauli
Change-Id: Id7b606c0e7e3621ea855af325c755876e11ebc66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98429 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-09eventattacher: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I61ae7e662c984961b507bf0394fcf8cf25496f0b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98218 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-09Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 290bab91dab73ea80e595c3b284926c7e01b35d1 - tdf#131416 How to read syntax diagrams Change-Id: Ic8ec05c75658f600f5ea1509acb482cc3db5d796 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/98343 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-09Use OUString::toChar(), tdf#107885 follow-upEike Rathke
Change-Id: I7615f878d800ae0ad68b68dd1ffedb0471c537f9
2020-07-09cid#1448269 Dereference null return valueCaolán McNamara
Change-Id: I9644d5e3845533fe8117f152c047cc381b3b2c48 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98417 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09tdf#107885 - VBA AutoFilter can't compare stringsAndreas Heinisch
During the creation of table fields from an auto filter search criteria, check if the search text is numeric in order to search either for strings or numeric values. Change-Id: I6f334e7fd06c03850a535a0d54438577d15ccac4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/91834 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-07-09tdf#134688 run error dialog async and keep the events in the one event loopCaolán McNamara
instead of a sub loop which helps to not lose the mouse release where the dialog was shown on the mouse press Change-Id: If0baf15e85aff7a28ca058e2626b58802d0dad08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98439 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09uitest : Fix the old demo of writer commentsAhmed ElShreif
This test case is added as the old test case here: https://gerrit.libreoffice.org/c/core/+/96295 makes some randomly fail. I tried to fix this in the new test case . By trying to run the old test case multiple times locally . The problem was when you execute Command to add new comment . Sometimes the comment doesn't have enough time to be created and added as a child in the MainWindow Object So test case fails . So the fix was to use this function: "ui_test.wait_until_child_is_available(parent, childName)" This will make sure that that the comment was created successfully and added as a child in the MainWindow to be selected in next lines . I tried to run the test case again multiple times in my laptop and it never fails . Change-Id: I51e4b0802f3fa92139cbc6cdc7092c119e49d1b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96752 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2020-07-09stray remaining emfio_component_getFactory callCaolán McNamara
Change-Id: I37279fbca3bf83cf2c5609ddf9956ee915ae0b30 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98424 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1448540 Dereference null return valueCaolán McNamara
Change-Id: Ic5692d2bf5be11881792d7dbfb00b11af927b5e4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98416 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465229 Unchecked return valueCaolán McNamara
Change-Id: I7e12612f1aa2570df8f5b0347f19dcb96532aa26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98415 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465230 Dereference null return valueCaolán McNamara
Change-Id: I494fc9e36324c1940dbc551c2c7d86df70f30711 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98414 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465231 Improper user of negative valueCaolán McNamara
Change-Id: I984ae1103152a396cd157c3721a3739455b95997 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98412 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465232 Dereference null return valueCaolán McNamara
Change-Id: I221af4bce9c5cadabef0acb27177e5bf91f08cd1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98411 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09tdf#134562 Added check for textnodeShivam Kumar Singh
Change-Id: I0a38de547747f04a61a66c9ef62e59a68c4e1826 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98225 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-07-09cid#1465234 Unchecked return valueCaolán McNamara
Change-Id: I56d59de5c65144283595b044142ff3f8988a02a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98409 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465233 Unchecked return valueCaolán McNamara
Change-Id: I078f20bd607110cd526ce40a6391affd238a14d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98410 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465235 Dereference null return valueCaolán McNamara
Change-Id: I73efddfeca873e43f1505790eebf260c27e248de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465236 Uncaught exceptionCaolán McNamara
Change-Id: I1303fe8ac9a5eecc06d9622893c8643d87120a58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98407 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465237 silence Dereference after null checkCaolán McNamara
Change-Id: I7014da07d88861e4f08fb9e1006dccb6fc2ad245 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98406 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09Revert "tdf#128526: Make the read-only notification a bit more verbose"Samuel Mehrbrodt
This reverts commit 6c102b0a12ed911b207d8b1da421f2b916c2bcdf. Reason for revert: The Infobar has an "Edit Document" button which lets you edit the document without first saving it in another place. So at least in that place this verbose message is confusing. Change-Id: I3bcdd389a560ac4c8ee0f86ca13573bbc05f2ebb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98075 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Jenkins
2020-07-09cid#1465239 silence Explicit null deferencedCaolán McNamara
Change-Id: I35135f6522ea64d0a8d7063949cd006278ec6080 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98404 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09cid#1465238 Uninitialized scalar fieldCaolán McNamara
Change-Id: Ia0ffb4bad265aabe396ef94e3d9c2bbe79993b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98405 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-09Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5907932eac35843d0cd88adea09ba8890ed59884 - Fix Help after translator review. Many thanks to Mikel Tõnnov. Change-Id: I2858f436fe6fecaac6f50c6912883b5c9c46d050 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/98393 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-07-09scPrintTwipsMsgs: Use top-left of output-area as the refpointDennis Francis
We can't use the transformed version of editeng origin, since it need not be in client view area depending on text alignment, which is unusable as far as the clients are concerned. Top-left corner of output-area is always guaranteed to be in client view area independent of text-alignment settings. Change-Id: I5bd20d2b52e146371de4b605bf7934b7e7d6fc5a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98131 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-09lokit: Avoid sending wrong edit-cursor/selection messages when...Dennis Francis
the EditView's output-area needs to be tweaked temporarily to render it to a tile which is meant for another view. Change-Id: I2b8fc1986c247ce65c18ea64e3b43d25625c7e9c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98129 Tested-by: Jenkins Reviewed-by: Dennis Francis <dennis.francis@collabora.com>
2020-07-09Docs: Add missing propertySamuel Mehrbrodt
Change-Id: I1f4a0602f23cba86adbf627b0881ae5034db0af8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98188 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-07-09unotools: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I7a68484564aea9b416c12d5364d20ff8af77f40b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98380 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-09tdf#134225 Chart view: fix moved date labelBalazs Varga
outside from pie chart. Do not need to check the sector size of a pie slice, before best fit algorithm, so we can use the CENTER position as a start position of BEST_FIT. Completion of c66cb6d6e4a843dc7c7d06e1c2c0723a6ff85fc5 (tdf#134029 Chart view: enable to move data label) Change-Id: Ie1a53784e7df2887282155113bf8bb607cdb09e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96945 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-09There is no com_sun_star_comp_dbaccess_DatabaseDataProvider_get_implementationTor Lillqvist
Change-Id: I90f61ca1209a213757e60346ce77aff6912c8b58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98398 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-09There is no com_sun_star_comp_dba_ODatabaseContext_get_implementationTor Lillqvist
Change-Id: Ic22eb0c075c195d4480c8757642d902003bd22d1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98397 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-07-09desktop: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: Id332d79c29c8e5f668663070d83aba596f017908 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98390 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-09tdf#60684: graphic type content must correspond with graphic type extensionJulien Nabet
Change-Id: I8075b1b44aa400268b4022decb2a56770c81d83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98239 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-07-09framework: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: Ia2d9447b687f0792d9d3a98d30cd2b8fe54049ee Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98388 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-09jsdialog: export cursor visibility for text areasSzymon Kłos
Change-Id: I404e496a6f68f5cc2e2e628b51c759be49c7fecd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/97729 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Szymon Kłos <szymon.klos@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98231 Tested-by: Jenkins
2020-07-09clean up macro usageNoel Grandin
Change-Id: I06669718f692cc5e9e209b4e490365f4f016afdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98389 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08tdf#134606 DOCX table import: fix gridBefore + nestingLászló Németh
Nested tables in a table row with gridBefore could result of broken outer table, if the row doesn't contain text before the nested table, resulting invalid TextRange for insertion of gridBefore cells. Regression from commit 70274f86cdc1c023ffdd0130c262c1479262d76b (tdf#116194 DOCX import: fix missing tables with w:gridBefore) Change-Id: I6bb3948b6522d8785a1ea0ccf8d7c7f3c2bde189 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98320 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-07-08Resolves: tdf#124454 exec the matrix operator on values converted from stringsEike Rathke
Effectively a fallout from the matrix operations rework started for tdf#89387 that did not convert strings at all and subsequent work converted the string according to settings but did not apply the current operator on the result. Change-Id: I90c8963021396fd9a46b063f6aee96283f89271a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98385 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2020-07-08Fix typoAndrea Gelmini
Change-Id: I2a5a231d7e58c3a84651c70cdf561c81b56a651a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98250 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-07-08query if the cursor can be moved up or downCaolán McNamara
Change-Id: I47c09ff5f76c873cf30e608a134f90b42040a0c3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98387 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08expand to cover subwidgetsCaolán McNamara
Change-Id: Ib0765e6a38c6dc6cdb32eefc013b432f3cf36db2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98386 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-07-08tdf#134264: sw: Add unittestXisco Fauli
Change-Id: I373b2549a067452056f649213c32d5983212580c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98378 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-07-08framework: create instances with uno constructorsNoel Grandin
See tdf#74608 for motivation Change-Id: I6237016000dc05eacb14e59815b53cd44fbfce0c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98384 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-07-08lok: set to export PDF bookmarks by default when save-as a PDFTomaž Vajngerl
Change-Id: Ieb182b9a0d1f18a29a83ce369881578c06e217ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/98211 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>