Age | Commit message (Collapse) | Author |
|
not a pointer
Change-Id: I09e356d9230e2cf386349aad028a41548cb050ea
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113965
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
So that nOrdNum doesn't cause -Wshadow in
SwDrawVirtObj::AddToDrawingPage().
Change-Id: Ie7b1401f5c3cb07bfa653c4268dbdce7ba7abea5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113966
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
Tested-by: Jenkins
|
|
Change-Id: Ie22ff468f1220a2d2a526b9d00dcfbec4048557b
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113961
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I488f994fc890cacd20a6fdc224a098fe0caf3070
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113960
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id3728ac0011d3deed7e56081e3a854c7fa5336f3
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113959
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If6d56c9f2fcaf47e1756e8645098ad86987c8b64
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113958
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
and similar
VCLXFormattedSpinField can drop SAL_DLLPUBLIC_RTTI
Change-Id: I72cf9eeb1a0cba45089692bc81ae0c79a32bbef5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113957
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
This patch enables word-wrap by default for Basic Shapes, Block Arrows, Flowchart Shapes and Callouts.
However, it does not enable word-wrap by default in some object gropus in the Gallery. These groups will be handled in a future patch.
Change-Id: I9158bce92d26766a3b281e13758bf388b54b4f7f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/106650
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
Change-Id: I4d2c6ec9824b5c397f287d9fdc11000c3c597762
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113570
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
In the define name dialog, the input itself should show the error
message in a tooltip. In addition, the possibility to test the tooltip
text in python was added.
Change-Id: I9bd7d2b2be8300aa366971f8a1f115e8ae19fb98
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113513
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
since we are iterating over the tree, use an iterator to speed
up subsequent lookups.
Takes my load time from 26.2s to 24.3s
Change-Id: Iac86c9f60d447cb7679913a0585c9631f845c3e4
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113948
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
This was changed in
commit a182dea0413c467b834f206f9cb91dc3f56acd35
tdf#139533 re-word a tip of the day
and "You can" was added to the beginning of all sentences that start
with "Create...". However this particular one is phrased as a question,
and "You can create...?" is obviously grammatically incorrect.
Fix this by combining the two sentences of the tip into one, and drop
the unnecessary and inaccurate note in parentheses.
Also add a link to the help page about creating master document.
Change-Id: Ib6e92b2a7772378e4b7b67e40bdd2e2791d4f07a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113392
Tested-by: Jenkins
Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
|
|
File > Properties: Document Location is now a hyperlink
opening the file browser for local files or the internet
browser for remote content
Change-Id: If3de16172e12aa1a3f4acc7504a2b3dd78677c09
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113839
Tested-by: Jenkins
Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
|
|
A follow-up for 5ebccaa07589383653dbd65e58204a82dd3cde09 and
5a11edc795d8a3ef1e15fc4e251f594911403131
Change-Id: I58c1f518967cb98bd7edecd655d5be0d4657a1ee
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113938
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Those are leftovers; they're unused since
commit a23bd42e9b2f6401c710ac95afcc3aa8f360d65c
Date: Tue Apr 6 14:26:06 2021 +0200
android: Drop custom file abstraction + UI
Change-Id: I898391cfccd465e4d18d51ee07ee847978872ef1
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113885
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
It just calls the parent class method anyway.
Change-Id: I802e75ad650b71d6daa08494ff812985bb844a5f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113884
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Previously, the document was always closed in
LibreOfficeMainActivity's 'onStop' and loaded anew in
its 'onStart' method.
In order to not lose user changes, there was also
a caching mechanism in LOKitTileProvider, also triggered
in 'LibreOfficeMainActivity#onStop'.
This means that e.g. each time a switch to another
Activity/app happened, a cache document with the user
modifications in it should have been created for
restoration. That did not really seem to work
particularly well in a few tests, as also described
in tdf#95517 ("changes reset after show Settings").
The documentation aboue Activity lifecycle says [1]
> The entire lifetime of an activity happens between the first call to
> onCreate(Bundle) through to a single final call to onDestroy(). An
> activity will do all setup of "global" state in onCreate(), and release
> all remaining resources in onDestroy(). For example, if it has a thread
> running in the background to download data from the network, it may
> create that thread in onCreate() and then stop the thread in
> onDestroy().
This changes the handling to load the document in the
'onCreate' method and clos it only in 'onDestroy',
i.e. the document remains open while e.g. switching
to another Activity or app, thus making it unnecessary
to try to restore state as good as possible in 'onStart'.
An invalidation of the view (via 'LOEvent.REFRESH')
generally seems to be enough.
(Well, sometimes there is an issue with
invalidation/repaint and single tiles remain black,
but that happened previously - when the whole doc
was loaded anew - just the same way).
This allows dropping some extra handling needed
to try to restore the previous state, along with the
caching mechanism in LOKitTileProvider (that had some
other issues, e.g. it didn't reliably create the cache
file, since the file extension was not always set, and
'LOKitTileProvider#cacheDocument' was relying on that
to derive the document type).
I am not sure whether I missed any aspect that the
previous implementation was trying to solve, but
at least these scenarios I found and tested worked
as expected with the change in place:
* user changes still present after switching between apps
(s. tdf#106648 "Android: save current work when onSaveInstanceState is
called")
* for the Calc case, the sheet that was selected before
switching apps is still selected (s. tdf#101689
"Android Viewer calc returns to first sheet")
* user changes no longer get lost when selecting a menu item
(s. tdf#95517 "changes reset after show Settings")
* case where the user leaves the app by pressing Home, and starts it again
(as described in commit 83386129f5be002f2649db81bba4c468c7f6e4de
"android: Fix the application lifecycle.")
[1] https://developer.android.com/reference/android/app/Activity#activity-lifecycle
Change-Id: If59734cbfd62673884786066c94e2c2a1d6a916e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113883
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Always create a local copy of the original document
to work with, rather than doing a different handling
depending on the type of the URI used to specify the
file to load.
This will also simplify adding support for "Save As"
in upcoming commits, where the temporary
file can remain the same and only the URI for the
actual document will need to be changed.
Change-Id: I2587611fa56b76d8a5384ac25c57335e8d12e987
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113882
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Make 'example.odt', 'license.txt' and 'notice.txt'
(which can be opened via the "About" dialog)
resources of the app by copying them to a new directory
'res_generated' instead of into assets, and include
'res_generated' into resources, then use an
'android.resource://' URI instead of a 'file:///assets/'
one in AboutDialogFragment.
The latter does not work with when passed as a parameter
to 'ContentResolver.openInputStream'.
Adapt/Simplify 'LibreOfficeMainActivity#copyFileToTemp' to
make loading those docs using the 'android.resource://'
URI work and use the existing 'copyStream' method for copying from
the input to the output stream.
This is in preparation for upcoming commit with Change-Id
I7731ef81a4242fa0ce3b3fd8ced1683a6a6bee8c,
"android: Always create a temporary local copy of the doc".
Change-Id: I7731ef81a4242fa0ce3b3fd8ced1683a6a6bee8c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113881
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Drop the fallback of opening 'example.odt' when
no file to open was given.
I see no valid way how that fallback should be
reached, so write an error log message instead,
just in case there is still a way to get there.
Change-Id: I8b8040ba0099cba9196f65982f09c67791be01c2
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113880
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Extract method 'copyStream' used to copy the
temporary file to the actual document URI when
saving.
It will also be used for copying the other way around
when initially opening the document.
Change-Id: I5382f4a7c49b454ff38fb8f95afab3c39145c11f
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113879
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Add a 'mDocumentUri' member in LibreOfficeMainActivity
to store the document URI rather than retrieving it from
the Intent using 'getIntent().getData()' all the time.
This is also in preparation to make it possible to change
the URI later, e.g. when doing a "Save As".
While at it, also switch to readonly mode for the
fallback to 'DEFAULT_DOC_PATH' (though I don't think
this should be relevant anyway).
Change-Id: I629bad1d743e458191dcfa2b1371ea4b280e7b13
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113878
Tested-by: Jenkins
Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
|
|
Implements SAL_VCL_KF5_USE_QFONT to switch the used font backend,
like SAL_VCL_QT5_USE_CAIRO for the qt5 backend.
Change-Id: If3f163973c2e251eafe3bd734fd7525a8127cbcf
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113946
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
This was hiding tdf#141623, when I decided to implement the override
to run the kf5 VCL plugin with the qfont text rendering.
Change-Id: Id1fcd363bd77a756cb27e3a171c872ce792da5ad
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113956
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
The QFont based rendering path directly uses the widgets size to
initialize the QImage buffer image, so do the same for the Cairo
surface, instead of the arbitrarily size of 640x480.
Change-Id: I91326dab67cbbb5e75b78b02c34eaca61ad26482
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113955
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I49c3b06e9b54d9d6657b64b153907f995e572a19
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113951
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia6fc35fa8e6c43686b84e441ea3949b7ecbb78a0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113954
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Idef5a50733bc4bdef45ea613b4833df0b9d7c9e0
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113952
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
New class to run from Python DDL + DML SQL commands
on databases embedded in or connected to Base documents.
GetRows() is hardcoded as an exception (cfr. bug #138155) in
_PythonDispatcher() - SF_PythonHelper.xba
to be able to return 2D arrays to Python.
Fix returned empty arrays in the Basic-Python engine:
the standard bridge ignores them and returns a null byte
sequence instead of an empty tuple.
Change-Id: I336ea0b585b759b998af0871d25bfd384a2e66ae
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113953
Tested-by: Jean-Pierre Ledure <jp@ledure.be>
Tested-by: Jenkins
Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
|
|
Change-Id: I3f7bd1befffb45b12bc178f9addf1445a6c33921
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113944
Tested-by: Jenkins
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I993442061ac59e1ecd86b7d97a3e52c561987878
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113942
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: Ic95b84ceb91ccadf9d4f2dd763a4f4ec7b379381
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113950
Tested-by: Caolán McNamara <caolanm@redhat.com>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I560a5ff4caf204cc46d6cfb5f7680328295020fd
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113949
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
* Update helpcontent2 from branch 'master'
to d055e8d2ab5182def772050c8abdc54725a7814a
- Help Pages for Calc’s “IM” Functions, Improved Equations
I have recently spent some time updating the pages
of the Calc Functions Wiki that relate to the
processing of complex numbers.
There are 25 functions in Calc’s Add-In category
that have names beginning with the letters “IM”
and these are all concerned with processing
complex numbers of the form “a+bi”.
Of these 25, there are 6 trigonometric functions
(IMCOS, IMCOT, IMCSC, IMSEC, IMSIN, and IMTAN)
and 4 hyperbolic functions (IMCOSH, IMCSCH,
IMSECH, and IMSINH). For these 10, the current
help pages include equations to assist the
user’s understanding of the function’s purpose.
I feel that some of these equations should be
replaced with more appropriate equations that
reflect how the software functions (see
/core/scaddins/source/analysis/analysishelper.cxx)
and these proposed changes are listed below.
Change-Id: Ie0e4957e374570d60be00bcbe9b9015acab5e3a1
Reviewed-on: https://gerrit.libreoffice.org/c/help/+/113935
Tested-by: Jenkins
Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
|
|
Change-Id: I5c6bd57f2ffbce4a8adf794c46aeb62cae5c6604
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113947
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: If26562a7d5bede1dea414cbe24871b1dd75bfe23
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113943
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id41c5632b3532e84f4486625e9bd4731c86f0272
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113936
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: I99a7cdede74c4e8a661579467624f21fcf9132df
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113931
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia4c0f2727c0278496c68f54eca3046a924fa21e9
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113930
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I22d73bb5a6e4d215dc35acdd4ded47d29882671e
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113941
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
...using Java 1.4 java.util.logging.Logger instead also for the last remaining
uses in reportbuilder.
(The mention in swext/mediawiki/src/THIRDPARTYLICENSEREADME.html was presumably
a leftover from 4b6ceed4a4a9b152905a8b1712ffb9bd61373c16 "swext: Wiki Publisher
does not use those apache-commons libraries".)
Change-Id: Ia0bc598fe5844ced11cae497548ec7d09453a99d
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113939
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I11b3fca85ec00049dfe84df6cfb548a320e255cc
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113937
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
* Update dictionaries from branch 'master'
to 96ecb3d82f441c8ba38e7f773c5941e502acaf1c
- Add Esperanto dictionary
Signed-off-by: Carmen Bianca Bakker <carmen@carmenbianca.eu>
Change-Id: I1852b0eedc9b397c43f213dab60ff08e44b01678
Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/110415
Tested-by: Andras Timar <andras.timar@collabora.com>
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
Change-Id: I197ccc8f24cae23c7056245b009f1aac90895040
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113940
Tested-by: Julien Nabet <serval2412@yahoo.fr>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
...ever since a41a4a22f1a7e82ab64f28b71f5ce6acc1c04921 "remove now unneeded
apache-commons libs"
Change-Id: I197063d6a2f34d4800383ead1f55da47054e67af
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113831
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I6ff3e82cc02272e10314cc92e6ee584fcc50724c
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113934
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: I5acab0328fd40e7eb4043a77197d78925c38237a
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113933
Tested-by: Jenkins
Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
|
|
Change-Id: Ibd75c6dd71d93322bd77995547e735c2d4849602
Signed-off-by: Ashod Nakashian <ashod.nakashian@collabora.co.uk>
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113223
Tested-by: Jenkins
Reviewed-by: Andras Timar <andras.timar@collabora.com>
|
|
Because when loading number formats from ODF literal text is
enquoted that resulted in duplicated formats that differed only in
quoted literals vs unquoted literals with identical functionality,
but unnecessarily polluting the number formats list.
Since
commit 5d1042cbd25b22babaf8b30bc4edff6f70750b5e
CommitDate: Sat Apr 10 03:49:37 2021 +0200
ODF load: use AAA/AAAA instead of NN/NNN(N) for implicit
secondary calendar
these predefined format codes now load actually identical.
Change-Id: I02b5367ecd8ddab4419a56ba4d1c3ac4233142b5
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113925
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
if possible, which will probably have a better word-at-a-time
algorithm.
Change-Id: Ia338a0aad81ef450d482701139f131d6d577b737
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113922
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|