summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-12SvNumberFormatsSupplierServiceObject: default to LANGUAGE_SYSTEMEike Rathke
... instead of LANGUAGE_ENGLISH_US that will be ultimate fall-back anyway if no match is found. Change-Id: Ice6495e54fa0a1e275769fcfdf1e0e932e22944e Reviewed-on: https://gerrit.libreoffice.org/61729 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Eike Rathke <erack@redhat.com>
2018-10-12Resolves: tdf#119739 switch date field input to NF_EVALDATEFORMAT_FORMAT_INTLEike Rathke
To evaluate date input against date acceptance patterns in the order first format locale, if any, then formatter (system) locale. The slight drawback is when the field has no content there is no indication of that the format's locale's patterns would be preferred, whereas the old NF_EVALDATEFORMAT_INTL_FORMAT preferred the default locale's patterns. The big advantage is that editing a date actually uses the patterns associated with the presented display string. Change-Id: Id3f11e26a0e32b95f26b69a681433deb87b7c6b0 Reviewed-on: https://gerrit.libreoffice.org/61726 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-12tdf#119992 sw: compare sub-strings in SwTextGlyphsKey comparisonMiklos Vajna
Time till the layout reaches idle, before: 77.412 seconds After: 26.221 seconds (33% of baseline) for me. Change-Id: Idd0c5255070c836fde2fb048b02c851f5f2321e4 Reviewed-on: https://gerrit.libreoffice.org/61724 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-12tdf#119739 split ConfigManager::getLocale(), getUILocale(), getWorkLocale()Eike Rathke
To prevent further confusion which is which, dbaccess UserInformation already got that wrong since ever. /org.openoffice.Setup/L10N/ooLocale is the UI locale. /org.openoffice.Setup/L10N/ooSetupSystemLocale is the work locale. Confusingly due to legacy when the setup program was a separate binary that picked the UI ooLocale and later set up the default (system) work locale as well. Change-Id: I9a05ad39f5fb65c54076ff5789ba7a2cc06ad23a Reviewed-on: https://gerrit.libreoffice.org/61725 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-12tdf#118572 dispose instead of LazyDeletorCaolán McNamara
Change-Id: Ib52a1d6ffee0354cc7749f2535a05821d73149c5 Reviewed-on: https://gerrit.libreoffice.org/61716 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12coverity#1440239 Uncaught exceptionCaolán McNamara
Change-Id: I2b744d70ab426fbf26bcb3762aafaa569d0aafc7 Reviewed-on: https://gerrit.libreoffice.org/61675 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12HTML and image copy into qt5 clipboardKatarina Behrens
Change-Id: I1c26db35b801694fcc3935baab842027eac1e561 Reviewed-on: https://gerrit.libreoffice.org/61611 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-12Simple translation passing by...Andrea Gelmini
Change-Id: I643e8bdf6b88d53f41008e41ac04fbf49696c3a2 Reviewed-on: https://gerrit.libreoffice.org/61707 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2018-10-12Fix typoAndrea Gelmini
Change-Id: I89ce64cfb8ea6777ac70583942d76dbc59eaf65b Reviewed-on: https://gerrit.libreoffice.org/61717 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-12Fix typosAndrea Gelmini
Change-Id: I678b545f2a266365fb700b3f75b3d939d28348d6 Reviewed-on: https://gerrit.libreoffice.org/61603 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-12clarify when XInitThreads is calledCaolán McNamara
and make the minor version checks more sensible Change-Id: Ieee6750e4e8dd79213a0befb040ce7b8a815e357 Reviewed-on: https://gerrit.libreoffice.org/61713 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12drop some unused headersCaolán McNamara
Change-Id: If7cedab43231103f7435ce57a0eb3a4d047becb4 Reviewed-on: https://gerrit.libreoffice.org/61714 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12Support image paste from qt5 clipboardKatarina Behrens
Change-Id: Ie1894d9549227c73c6da6688b0540c85d4593a2b Reviewed-on: https://gerrit.libreoffice.org/61589 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-12Support HTML paste from qt5 clipboardKatarina Behrens
Change-Id: I23b615bf0720fdcdb1849e7890956c1d9f1a79c1 Reviewed-on: https://gerrit.libreoffice.org/61516 Tested-by: Jenkins Reviewed-by: Katarina Behrens <Katarina.Behrens@cib.de>
2018-10-12weld SdPresLayoutDlgCaolán McNamara
Change-Id: I04dddf836eccf16a6335b63c3350e97335d2fb58 Reviewed-on: https://gerrit.libreoffice.org/61710 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12add id column to liststoresCaolán McNamara
Change-Id: I4a0cc9cbdd0a82219878301a78e610c2dce1c685 Reviewed-on: https://gerrit.libreoffice.org/61709 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12weld ODbaseIndexDialogCaolán McNamara
Change-Id: I5cf97cc9f0b7123675bd2dbeb472419ffda9a459 Reviewed-on: https://gerrit.libreoffice.org/61708 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12tdf#118621 - Optionally disable floating header/footer menuheiko tietze
UNO command UseHeaderFooterMenu introduced Change-Id: I4be009e08bc66dc675c7c903552c6376e22639f1 Reviewed-on: https://gerrit.libreoffice.org/61706 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-12tdf#120420 fix for overwide Ubuntu 16.04 GtkSpinButtonsCaolán McNamara
Change-Id: I581a7f4e8e10b8002fee5ddf9b24fdb867b2235e Reviewed-on: https://gerrit.libreoffice.org/61694 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12sw: new unit test for XTextContentVasily Melenchuk
Change-Id: Ic5f6740b145a473f69052489ce6c48894f33c74d Reviewed-on: https://gerrit.libreoffice.org/61351 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-12tdf#120506: Get rid of unnecessary accentcolor parsing for personasMuhammet Kara
Change-Id: I64534fd3d7de90debb9e49e8c636c5fbfac787bf Reviewed-on: https://gerrit.libreoffice.org/61668 Tested-by: Jenkins Reviewed-by: Muhammet Kara <muhammet.kara@pardus.org.tr>
2018-10-12loplugin:constfields in reportdesign,sal,saxNoel Grandin
and improve the rewriter so I spend less time fixing formatting Change-Id: Ic2a6e5e31a5a202d2d02a47d77c484a57a5ec514 Reviewed-on: https://gerrit.libreoffice.org/61676 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-12XInitThreads only when running under XCaolán McNamara
Change-Id: I5068b5229e88da3b1f00b03a2f1c1aea67526de9 Reviewed-on: https://gerrit.libreoffice.org/61703 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12weld OPasswordDialogCaolán McNamara
Change-Id: Id08853ec1789a7a3a361263a4a61329a849f8658 Reviewed-on: https://gerrit.libreoffice.org/61704 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12Improve sentencesSamuel Mehrbrodt
Change-Id: I9d5c657f53d23b2801b0e90584a4b8613dd93235 Reviewed-on: https://gerrit.libreoffice.org/61671 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-12Conditional formatting: Allow to set the icon set CF via .uno: command.Jan Holesovsky
When .uno:IconSetFormatDialog gets a parameter, it directly creates the icon set conditional formatting with pre-selected values. Change-Id: I75dda90e5ea9c191254acc24c564cda7b27243a5 Reviewed-on: https://gerrit.libreoffice.org/56429 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-on: https://gerrit.libreoffice.org/61669 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2018-10-12coverity#1440241 silence Dereference after null checkCaolán McNamara
Change-Id: I6c4f4b626c02de3cd69c32dcb4ffea282c0ebff5 Reviewed-on: https://gerrit.libreoffice.org/61683 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12set m_nSizeAllocateSignalId to 0 when not installedCaolán McNamara
Change-Id: I1023f5b51fefd86d7faa749c9488a7fcaeeaf3ff Reviewed-on: https://gerrit.libreoffice.org/61695 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-12sw: create DocxExport instances with an uno constructorMiklos Vajna
Change-Id: I34e674e4f3225e724fd9ed6d513fb66c2d5ebdd9 Reviewed-on: https://gerrit.libreoffice.org/61696 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-12Remove unnecessary mutexStephan Bergmann
CMimeContentType::m_ParameterMap isn't modified after construction Change-Id: Ib3dbfbd4212ed0d7e8a9f29c655f935d3fc4f1bf Reviewed-on: https://gerrit.libreoffice.org/61698 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-12Remove undefined member function declarationsStephan Bergmann
...that had accidentally not been removed along with the definitions in b75e3ded1f73c943fb09f117e476e367ac0c3413 "tdf#120158: Base CMimeContentType on INetMIME::scanContentType" Change-Id: If94c0c413b891480c12a098c7b15caa1422213b0 Reviewed-on: https://gerrit.libreoffice.org/61697 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-10-12More SAL_INFO("sal.file", ...) tweaksTor Lillqvist
Change-Id: I999d641b54a53c5a737e82d67a0a1ffa769afd24 Reviewed-on: https://gerrit.libreoffice.org/61700 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-10-12clang-tidy misc-throw-by-value-catch-by-referenceNoel Grandin
Change-Id: I04750771b63551fd3df522753a4ed21b8d5c42f3 Reviewed-on: https://gerrit.libreoffice.org/61680 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-12uitest for bug tdf#118208Zdeněk Crhonek
Change-Id: Ibe9a09dae281ea1bcd1da17bfaa9dfef051ddab8 Reviewed-on: https://gerrit.libreoffice.org/61692 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2018-10-12tdf120224 docx export: don't double up field bookmarksJustin Luth
fields are internal bookmarks. When the exporter runs through the bookmarks, it will already write out a bookmark entry, so don't output a separate one for the fieldmark. Change-Id: I84af2989035507ac745d028f1585d60d8823ff8b Reviewed-on: https://gerrit.libreoffice.org/61616 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-12tdf120224 writerfilter: consume excess bookmark from fieldsJustin Luth
Although this follows a very different code path, copy the ww8 import idea of "consuming" the bookmark of a BOOK_FIELD. This is particularly important for textcontrols, especially since LO keeps duplicating bookmarks as it adds another bookmark for the field name at each save. Existing unit tests that this matches are fdo53985.docx and tdf111964.docx. I expected more, but apparently most fields don't contain or represent any bookmarks. This patch is for import only. A followup patch stops the creation of duplicate bookmarks during export. Change-Id: I1e11980e52dc523393fd6d621191228d676e9a17 Reviewed-on: https://gerrit.libreoffice.org/61615 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-12tdf#117721 draw ui: modify Optimize/Distribute RowHeightJustin Luth
Optimize row height: Adjust the height of the selected rows to match the height of the tallest row in the selection (fit to content), without shrinking the table. (Optimize rows is a new feature for Draw. My initial implementation was replaced by setMinimalRowHeight. This option is now the same as minimizing row height and then distributing rows evenly except that it adds the benefit of preventing the table from shrinking.) Distribute rows evenly: Adjusts the height of the selected rows to match the height of the tallest row in the selection (regardless of the content), causing the table to grow. (Previously, Distribute rows worked like Optimize now does, but the documentation indicates that it should work this way.) Change-Id: I49b9f9b5d1f9d3e8d2267ba0d49a9901585b4095 Reviewed-on: https://gerrit.libreoffice.org/61473 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-12tdf#64242 sw optimal column width, not minimizeJustin Luth
Optimize column width: Adjusts the width of the selected columns to fit the entire column's content, without changing the width of the table. Any leftover space is distributed proportionately, with thin columns growing slightly, and wide columns growing much wider. Change-Id: I9b8436814fc103d52fdd5ce3d88c6442dbb72d50 Reviewed-on: https://gerrit.libreoffice.org/60905 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-12We don't need to handle iOS specially in DisconnectStorage_Impl() after allTor Lillqvist
Now that we make sure UserInstallation/user directory exists, a "backup" directory will be created there, and the edited document's backup file placed in it, and not beside the original document location (which wouldn't work on iOS). Change-Id: Ibc0a6e7f0b596cc3d02774878cd8c3d53fda0c3e
2018-10-12Avoid superfluous directory levelTor Lillqvist
Don't bother with a 'userinstallation' subdirectory. It is a subdirectory called "user" of the UserInstallation value that will be used for our stuff anyway. Change-Id: Idb6b5992bfda73ed7af80274b0de8ad7b43c241c
2018-10-12Make sure the UserInstallation/user directory exists on iOS (and Android)Tor Lillqvist
If it doesn't exist lots of things go very badly. Took a while for me to understand the mechanism, sigh. Change-Id: I40300587a5f422876cbda68c5aa98a23ed707135
2018-10-11tdf#119580 sc: Use the regular object popupmenu for chartsMaxim Monastirsky
Context menu of a chart is supposed to be the same as for other ole objects, except the additional .uno:ExportAsGraphic. Given that .uno:ExportAsGraphic is hidden when non-chart object is selected, we can just place it in the regular ole object popupmenu (done already), and use that menu also for charts. Discussion is in https://gerrit.libreoffice.org/60128 . Change-Id: I8a07c550998e1db0d2af7f87c625dbd258454bdd Reviewed-on: https://gerrit.libreoffice.org/61678 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-11Remove superfluous separatorMaxim Monastirsky
Change-Id: I12f7ebf8cb40c5c1ea40509ac38ae977e1abca89 Reviewed-on: https://gerrit.libreoffice.org/61677 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2018-10-11tdf#120528: check for empty mpMouseEvent in ScDataTableView::MouseButtonUpMike Kaganski
The preceeding mouse button down event could happen in a different (closing) window, like context menu. Change-Id: I630b827fb5fe05399ca8436ea79210f4642a56d4 Reviewed-on: https://gerrit.libreoffice.org/61691 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-11ofz#10853 no config available during fuzzingCaolán McNamara
Change-Id: Ice48111756d2e5950093fabc28359f7a4e490220 Reviewed-on: https://gerrit.libreoffice.org/61693 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11weld DlgFilterCrit and DlgOrderCritCaolán McNamara
Change-Id: Icb96b47cb20a1a80877f693156a3395aba4c70d5 Reviewed-on: https://gerrit.libreoffice.org/61685 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-11Further SAL_INFO("sal.file",...) tweaksTor Lillqvist
Now it should be fairly close to the (IMHO) ideal: One SAL_INFO("sal.file") per file system system call. (Not read() and write().) Sure, on Linux one could just use strace, but my interest at the moment is debugging what goes on on iOS. Change-Id: I19ec0404c0c15a957de96d98376b4338b48a8cbd Reviewed-on: https://gerrit.libreoffice.org/61687 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2018-10-11elementary: update existing /add 32px fontworkshapes, form icons, etcRizal Muttaqin
Change-Id: Ie6545844546dc78d14e1fabdf28f4e1938cf2dd3 Reviewed-on: https://gerrit.libreoffice.org/61642 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins
2018-10-11loplugin:simplifyboolTor Lillqvist
Change-Id: Icb25fd00296f0584fdd503ad0e840870f8bc6774
2018-10-11Resolves: tdf#120476 need to be resizable if number of tabs is variableCaolán McNamara
across runs Change-Id: Ie77512557c10f564ed9d2dab837b134e9b4834a1 Reviewed-on: https://gerrit.libreoffice.org/61672 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>