summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-05-04Resolves: tdf#123948 add English (Zambia) [en-ZM] to language listEike Rathke
Change-Id: I6632cacb7e713d4c7aaaedd50267b9e6029b0389 Reviewed-on: https://gerrit.libreoffice.org/71768 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-05-04tdf#124953: Use rangelist's combined range top-left address...Dennis Francis
as origin address in the conditional format formula on xlsx export. Excel seems to get confused if anything else is supplied as the origin in the formula. For example, before this patch, for a condfmt range over the range-list [A3:C5 E1:F2], the origin address used in the formula (for text search type entries) is A3. <conditionalFormatting sqref="A3:C5 E1:F2"> <cfRule type="containsText" dxfId="0" priority="1" operator="containsText" text="ABC"> <formula>NOT(ISERROR(SEARCH("ABC",A3)))</formula> </cfRule> </conditionalFormatting> In this patch we use the top-left cell address(A1) of the combined range "A1:F5" as the origin address. <formula>NOT(ISERROR(SEARCH("ABC",A1)))</formula> Change-Id: If08a859bc361f925148ff463758d03ebbc41c0ac Reviewed-on: https://gerrit.libreoffice.org/71312 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-04tdf#122590: follow-up : import x14:cfRule prioritiesDennis Francis
If there are x:cfRule's and x14:cfRule's with matching range-list, then insert the conditional-fmt entries into the document in the order of the priorities. That is don't just append the x14:cfRule entries to the document after the x:cfRule entries are inserted. There was also a off-by-one bug in the priority export of x14:cfRule entries. This caused the priority numbers to be duplicated. This is also fixed. Change-Id: I5b0d11c4456b2966b808f6ee589075a870f43768 Reviewed-on: https://gerrit.libreoffice.org/71311 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-04tdf#122590 Import and export xlsx x14:cfRule element for type = cellis.Gülşah Köse
Change-Id: I3d940269ec25657b64c714400a2828781dd9dd3e Reviewed-on: https://gerrit.libreoffice.org/69713 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-05-04Fix typoAndrea Gelmini
Change-Id: Id7303279e86f5c5303bfe32bc843c59a9d7e2813 Reviewed-on: https://gerrit.libreoffice.org/71778 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-04Fix typoAndrea Gelmini
Change-Id: Ia21f12ac5fc872ca7c04e61e795b9f9f049a3dbe Reviewed-on: https://gerrit.libreoffice.org/71777 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-05-04Related tdf#45904: Remove already converted testsJens Carl
Change-Id: I86da1a0d85e2c08e654877b66c733f7548c29397 Reviewed-on: https://gerrit.libreoffice.org/71771 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-04Restore old quick-check behaviour...Jan-Marek Glogowski
that was changed in commit 5cb3a6da2a61 ("Move and fix Asian kerning unicode point check"). Change-Id: I96e815462a154e241eb8d871025e94304d458ffc Reviewed-on: https://gerrit.libreoffice.org/71487 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-05-04Fix typoAndrea Gelmini
Change-Id: I414fe36966ddcabad356f856c9285736ba089233 Reviewed-on: https://gerrit.libreoffice.org/71775 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-04Fix typoAndrea Gelmini
Change-Id: I3de19930394846273294e1574baf522ae1c1c3c9 Reviewed-on: https://gerrit.libreoffice.org/71776 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-04Fix typoAndrea Gelmini
Change-Id: I7fc62743f171d32098591b5600b4cd8b477872cb Reviewed-on: https://gerrit.libreoffice.org/71780 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-04Fix typoAndrea Gelmini
Change-Id: Ib04fe75d60647c938225700dd25a3e7e031437dd Reviewed-on: https://gerrit.libreoffice.org/71781 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-04Fix typoAndrea Gelmini
Change-Id: I4aa1d3cfb9a80b6ee0c557c98e65bb511913a5ee Reviewed-on: https://gerrit.libreoffice.org/71779 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-04tdf#105881 Toolbar keyboard navigation fixesJim Raykowski
This patch makes toolbar keyboard navigation wrap to the begining or end toolbar item and enables access to the overflow menu using the keyboard. Change-Id: I5975b0f731beb00cf26f8e8a33e6ea4fa9322881 Reviewed-on: https://gerrit.libreoffice.org/71718 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-05-03tdf#124565: calc: copy/paste manual row heightVasily Melenchuk
Row height being pasted is not sufficient without knowing if it is auto height or was set manually. Change-Id: I3c892fbe3ea5a54e7468fb23b993fa19370f85af Reviewed-on: https://gerrit.libreoffice.org/71706 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-05-03Compile the DebugEventInjector code always, not only when OSL_DEBUG_LEVEL > 0Tor Lillqvist
Otherwise if you happen to compile vcl/source/app/svmain.cxx with OSL_DEBUG_LEVEL > 0 but not this file, you get an undefined symbol DebugEventInjector::getCreate(). In general I think our intent is that ideally it should be possible to compile an arbitrary selection of source files with OSL_DEBUG_LEVEL=0, and others with OSL_DEBUG_LEVEL=1. (For debugging functionality that does require consistency across the codebase, we have DBG_UTIL.) Note that DebugEventInjector::getCreate() will be called from InitVCL() only when svmain.cxx is compiled with OSL_DEBUG_LEVEL > 0, though. So for a "production" build with no debug compilation, this change has no run-time effect. Change-Id: I3411edfbbbaae21561363634e5eec5ac0cf53418 Reviewed-on: https://gerrit.libreoffice.org/71757 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2019-05-03Resolves: tdf#125105 missing can-focusCaolán McNamara
Change-Id: I201b658cd0c643fbcaf2ec1411b2a2991eca36dd Reviewed-on: https://gerrit.libreoffice.org/71758 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03ofz#14552 direct-leakCaolán McNamara
Change-Id: I8509b5805baca5b6357d7e266c05e3ff4404f4c1 Reviewed-on: https://gerrit.libreoffice.org/71754 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03rewritting in a more conventional wayAdrien Ollier
- mnPos is modified only if mbLoopTerminated is true - using new and delete operators is less efficient than building an object on the stack - skipping a line makes instructions clearer Change-Id: I9bec0cf02a581c1e0033880fcad83f17e83ea3f2 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/71652 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-03makes implementation of Animation::operator =(const Animation&) conciseAdrien Ollier
Using the logical AND, we can evaluate all the expressions from left to right into a single and condensed expression. Change-Id: I973061dcd34322c29565a478bf9b7ba757965231 Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr> Reviewed-on: https://gerrit.libreoffice.org/71651 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-03libreofficekit: send show/hide messages for dialogsSzymon Kłos
Change-Id: I2b3ff5e5122b2be099be500ac544bf81f8d1b2ae Reviewed-on: https://gerrit.libreoffice.org/71544 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-05-03Resolves: tdf#124552 - Sentence selection UNO actionheiko tietze
UNO command SelectSentence / FN_SELECT_SENTENCE added executing SelSentence() Change-Id: Idcd528cf2915b30a59a9916dcff14d60d01dcd74 Reviewed-on: https://gerrit.libreoffice.org/70411 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com> Tested-by: Maxim Monastirsky <momonasmon@gmail.com>
2019-05-03ofz#14119 make erasing bitmap fasterCaolán McNamara
Change-Id: I6adb2618926bab652244c33acf870907e5fc159e Reviewed-on: https://gerrit.libreoffice.org/71748 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03tdf#120585: use applyColor and make it transparency-awareKatarina Behrens
An overloaded drawPolyPolygon for zero transparency case used to exist and it used applyColor to fill cairo path. It was removed by commit 7034311dce663c895577267110baadbec312d491 and the new transparency-aware drawPolyPolygon missed cairo_set_operator call that is present in applyColor. This works OK most of the time but breaks sometimes when no transparency (~no antialiasing) is involved. To fix that add transparency argument to applyColor and use it where applicable Change-Id: Ib1b077e38e7f5d30778434d45be67284407a7d16 Reviewed-on: https://gerrit.libreoffice.org/71700 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03Related: tdf#124942 upgrade epoxy to 1.5.3Caolán McNamara
https://github.com/anholt/libepoxy/issues/180 sounds very similar and 1.5.3 apparently fixes that Change-Id: I009f5bc82f9e8326a7028ed29d86733cce649d15 Reviewed-on: https://gerrit.libreoffice.org/71733 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03tdf#125095 return DND_ACTION_NONECaolán McNamara
we've already responded to the drop and drop action, we don't want any further action to take place. Change-Id: Ib1f271d8c74e49d4d00a0b143711b3f30b093b0b Reviewed-on: https://gerrit.libreoffice.org/71744 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03unipoll: get SolarMutex lock counting right.Michael Meeks
lo_startmain drops the SolarMutex without taking it, interestingly. Change-Id: I2280e2fa6acb8739f970983032db72a8241d1c4f Reviewed-on: https://gerrit.libreoffice.org/71741 Tested-by: Michael Meeks <michael.meeks@collabora.com> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2019-05-03improve assert message in XMLDiffNoel Grandin
Change-Id: I561dca23621075753185d7ea2afc5fd174cd2b3d Reviewed-on: https://gerrit.libreoffice.org/71728 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03block/unblock notify events around TextView selection changeCaolán McNamara
Change-Id: I1075c0dea8e651536ffee5a12c6c12424f91de84 Reviewed-on: https://gerrit.libreoffice.org/71730 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03Add Support for .NET 4.8Tomoyuki Kubota
*Before this patch, Windows SDK came with .NET 4.5 and .NET 4.6.1 or later was ignored. * the author of this configure.ac did not seem to understand that WOW6432Node should be given to reg_get_value_64 instead of reg_get_value_32. sometimes the code redundantly fetched the same entry WOW6432 (for 64 bit, wrongly passed to 32bit) and the 32 bit one. I removed the duplicate. Change-Id: Iff972d727907c480ef927d53fa1f53557fdeb1fd Reviewed-on: https://gerrit.libreoffice.org/71268 Reviewed-by: Michael Stahl <Michael.Stahl@cib.de> Tested-by: Michael Stahl <Michael.Stahl@cib.de> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-05-03GCC trunk towards GCC 9 still emits a bogus -Wstringop-truncationStephan Bergmann
Change-Id: I1e9e439558025030f79e070680831f1139675993 Reviewed-on: https://gerrit.libreoffice.org/66869 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-03The -fvisibility-ms-compat hack is no longer needed for UBSan on Linux...Stephan Bergmann
...with latest Clang trunk towards Clang 9. All the no-longer necessary hacks are made conditional on new NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY, which is still set for UBSan builds with older Clang on Linux (but which should eventually be purged). Various classes needed additional SAL_DLLPUBLIC_RTTI annotations, as building with UBSan instrumentation can generate references to RTTI symbols from additional places like outside a dynamic library that used to hide those symbols by default (but used to not hide them for old UBSan builds thanks to the -fvisibility-ms-compat hack). The odr-violation suppressions in solenv/sanitizers/asan-suppressions (which is not referenced from anywhere in the code base, but meant to be included in an ASan/UBSan build's ASAN_OPTIONS env var) are also no longer needed when NEED_CLANG_LINUX_UBSAN_RTTI_VISIBILITY is false. Change-Id: I24ec3e388b0cbab50dbe2bf008d9569bff7bf25a Reviewed-on: https://gerrit.libreoffice.org/70829 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-03Resolves: tdf#125080 crashing adding a ref to a non-VclPtrCaolán McNamara
Change-Id: I72a0deaab3d86ac0772092ab5f60bcace7632847 Reviewed-on: https://gerrit.libreoffice.org/71729 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03block/unblock notify events for TextView text/selection changeCaolán McNamara
Change-Id: I7745c04b9331b98c9c405544fe262c24ed066ddd Reviewed-on: https://gerrit.libreoffice.org/71731 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-05-03sw: reduce accuracy of double compares in testFDO74215Michael Stahl
This failed several times recently on Mac in Jenkins. - Expected: 14.7945205479452 - Actual : 14.8 - Delta : 0.001 Change-Id: I966b8085bf4120afb0a09e50f85ada4e5d8d488c Reviewed-on: https://gerrit.libreoffice.org/71725 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-03tdf#125088 Make button text white for blue buttons on macOSAndrew Hyatt
Change-Id: I6479b8b1544c5aa8a582854f4db4b4c4c01c28ed Reviewed-on: https://gerrit.libreoffice.org/71710 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-05-03tdf#123285 sw_redlinehide: fix SwAutoFormat::DelMoreLinesBlanks()Michael Stahl
The "Delete spaces and tabs at end and start of line" AutoFormat option was deleting the wrong characters: on the 2nd line, it deletes the spaces as it should, but on subsequent lines the selection is off by the number of characters that have already been removed. The range indexes are now integers, so not automatically corrected on deletions like the SwIndex they were before; in this case, where only plain characters are deleted, it should suffice to iterate the ranges in reverse order to avoid the problem. (regression from 180e5f515c9cd21fb8057c797a480eca7d9ed260) Change-Id: Ie8e08c00803d94e700cd5b64f29edb0b841eda2b Reviewed-on: https://gerrit.libreoffice.org/71686 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-03tdf#125039 sw_redlinehide: keep shape selected when changing anchor typeMichael Stahl
Avoid the problem by not moving the drawing object to the invisible layer, which isn't necessary because it will be inserted immediately anyway. (regression from 214e6ed5286566e689a4ef13a9115e2ad38fff57) Change-Id: I9936de990d1db56fa4c00c37d05b4ed2923790ff Reviewed-on: https://gerrit.libreoffice.org/71685 Tested-by: Jenkins Reviewed-by: Michael Stahl <Michael.Stahl@cib.de>
2019-05-03Fix building compilerplugins with Clang trunk towards Clang 9Stephan Bergmann
...after <https://github.com/llvm/llvm-project/commit/ f19a8b05171a67a290e7d3bd6eba0c95c7b3259c> "Replace ad-hoc tracking of pattern for an instantiated class-scope" removed ASTContext::getClassScopeSpecializationPattern. None of the affected plugins are enabled by default (nor checked by solenv/CompilerTest_compilerplugins_clang.mk), so just make sure they still compile, leaving any potentially necessary adaptions to another commit. Change-Id: I7102851409e78eff284b50337f7ad0f721e1e548 Reviewed-on: https://gerrit.libreoffice.org/71702 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-05-03Use hasElements to check Sequence emptiness in sfx2..svxArkadiy Illarionov
Similar to clang-tidy readability-container-size-empty Change-Id: Icabd773f3b924d465b33e8581175f1fcf70c282e Reviewed-on: https://gerrit.libreoffice.org/71704 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03clang-tidy modernize-avoid-c-arrays in accessibilityArkadiy Illarionov
Change-Id: Ic9c759fa78d47f0a8b989464ce1f65438da9064b Reviewed-on: https://gerrit.libreoffice.org/70478 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03Fix loop conditionArkadiy Illarionov
Change-Id: I8061e2bf839a4864eb5af1adb92b4b669e71e98c Reviewed-on: https://gerrit.libreoffice.org/71697 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-05-03NB Tabbed compact writer update print tabandreas kainz
Change-Id: I0ff8c4cb5e0ebc408e827e852d6e6134c42a3382 Reviewed-on: https://gerrit.libreoffice.org/71707 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-05-03tdf#68339 Other: BASIC Syntax errorJens Carl
Allow expressions (operands) of comparison operators prefixed with the Logical Operator "Not". Change-Id: I1b070e2288dac26b1f1186d38cf5d2f4ad99a406 Reviewed-on: https://gerrit.libreoffice.org/71332 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-03Add XServiceInfo tests to ScCellSearchObjJens Carl
Change-Id: I0ce55a8a6771a0c774c0009f0001fb00cfcc23b7 Reviewed-on: https://gerrit.libreoffice.org/71714 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-03Enable testing of multiple service namesJens Carl
Enable testing of multiple service names of the object supports this, by storing all possible names in a vector. Change-Id: Iff2c974cc30a0729cb26b07002582e0786a4de44 Reviewed-on: https://gerrit.libreoffice.org/71713 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-05-02Resolves: tdf#124605 ditch "if operand 1 is Empty, result is operand 2"Eike Rathke
It has been like that since the initial import but is utter nonsense. It might had (doubtfully) served some early StarBasic compatibility quirk, but is wrong and was implementation defined buggy behaviour. The Option VBASupport 1 even explicitly disabled it. In future we may want to implement the VBA Nothing value for an SbxEMPTY at least for boolean operators, but this for Calc user defined macro functions might even need a distinguished SbxEMPTYCELL or such. Or an explicit SbxNOTHING. Change-Id: I28919d982d0e60b9b840a12271dc717effa59662 Reviewed-on: https://gerrit.libreoffice.org/71701 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-05-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Mute unnecessary translations in fiter names Changed to allow translation of filter names and media types Removed randomness for paragraph ids to spare retranslation Change-Id: If73d4799537b2d91ec9fe58584033b46eeeb9e04 Reviewed-on: https://gerrit.libreoffice.org/70671 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-02Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' - tdf#102265 Decouple some Impress/Draw Slide/Page material Convenient way to do renames: find . \( -name '*.xhp' -or -name '*.mk' \) -exec \ sed -i 's/sdraw\/main0104/sdraw\/main_insert/g' {} + Change-Id: I3a8a59ac57ca3b29219962fc503f1d7ba5230a6d Reviewed-on: https://gerrit.libreoffice.org/71703 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-05-02writer: sync global and print toolbars between dif UI layoutsandreas kainz
Change-Id: I226db3f1a9cd6bed12db8edcb37ae6a6dcc999bc Reviewed-on: https://gerrit.libreoffice.org/71656 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
generated by cgit (git 2.34.1) at 2024-07-11 17:49:08 +0000