summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-11-04external: update pdfium to 4306Miklos Vajna
Change-Id: Ic10cf99fa412f8f0b3475e82d0a1839a7f04bd08 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105272 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-04loplugin:unusedmethodsNoel
Change-Id: I58fb6477222a26455f5db0a7d972c46f290c085c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105261 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-04use fastparser in XMLEmbeddedObjectImportContextNoel Grandin
Change-Id: I5fc61239e60a3129b350895293760a345baf3ce5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105260 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-03Avoid UBSan pointer-overflowStephan Bergmann
...as seen with recently introduced UITest_writer_tests UITEST_TEST_NAME=compareDocuments.compareDocuments.test_tdf137855, but where the unsigned sal_uLong (aka sal_uIntPtr) value is apparently meant to wrap around and address an element of m_pMemory at a negative index from m_pBDiag: > sw/source/core/doc/doccomp.cxx:832:13: runtime error: addition of unsigned offset to 0x6250014a90d0 overflowed to 0x6250014a90b8 > #0 in (anonymous namespace)::Compare::CompareSequence::Compare(unsigned long, unsigned long, unsigned long, unsigned long) at sw/source/core/doc/doccomp.cxx:832:13 > #1 in (anonymous namespace)::Compare::CompareSequence::CompareSequence((anonymous namespace)::CompareData&, (anonymous namespace)::CompareData&, (anonymous namespace)::Compare::MovedData const&, (anonymous namespace)::Compare::MovedData const&) at sw/source/core/doc/doccomp.cxx:794:5 > #2 in (anonymous namespace)::Compare::Compare(unsigned long, (anonymous namespace)::CompareData&, (anonymous namespace)::CompareData&) at sw/source/core/doc/doccomp.cxx:605:25 > #3 in (anonymous namespace)::CompareData::CompareLines((anonymous namespace)::CompareData&) at sw/source/core/doc/doccomp.cxx:440:17 > #4 in SwDoc::CompareDoc(SwDoc const&) at sw/source/core/doc/doccomp.cxx:1877:13 > #5 in SwEditShell::CompareDoc(SwDoc const&) at sw/source/core/edit/editsh.cxx:877:34 > #6 in SwView::InsertMedium(unsigned short, std::unique_ptr<SfxMedium, std::default_delete<SfxMedium> >, short) at sw/source/uibase/uiview/view2.cxx:2377:39 > #7 in SwView::DialogClosedHdl(sfx2::FileDialogHelper*) at sw/source/uibase/uiview/view2.cxx:2574:26 [...] Using std::make_signed_t where its canonic type happens to be `long` requires a workaround for old Clang to avoid a false > CXXFunctionalCastExpr, suspicious cast from 'sal_uLong' (aka 'unsigned long') to 'std::make_signed_t<decltype(d)>' (aka 'long') [loplugin:toolslong] warning. Change-Id: I07413ba06051f75d80832a4772ab1c541805b259 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105234 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-03Resolves tdf#137059 - Use application colors for font previewHeiko Tietze
Background is set to document's application color now (options > application colors > document) to provide a true WYSIWYG experience (except for modifications to the page background color). Change-Id: Ifd78e667f3eeff3573ff09bcb4d2a9634dd49c99 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105011 Tested-by: Jenkins Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03ofz#26943 detect if FormatOfJustInsertedApo was deletedCaolán McNamara
move FrameDeleteWatch for reuse in the doc filter Change-Id: I6e53549a837968cb738b5188e8670dd3e38a9c0e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105264 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03presumably 'true' is sufficient in all casesCaolán McNamara
Change-Id: I9366193085a4c46ef64f0a9660e51b8678ca35f9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105252 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03vclplug_qt5 doesn't appear to need to link to vclplug_x11Caolán McNamara
Change-Id: I7f4c3fb210996c0ce66d3d9448a3954ce1aaa525 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105256 Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Jenkins
2020-11-03tdf#128877 DOCX import: fix lost position of image cropped to shapeMiklos Vajna
Regression from commit f4ba484183a1e7b9824f10580d633466c266828f (ooxml import: supprt cropping to shape, 2019-05-13), which changed the type of a cropped-to-shape image from drawing.GraphicObjectShape to drawing.CustomShape. drawing.GraphicObjectShape worked because GraphicImport::lcl_attribute() in writerfilter/ had a check for drawing.GraphicObjectShape and did an explicit setPosition(). Doing the same for bitmap-filled custom shapes would be an option, but it would be ugly: scaling/translation/rotation/mirroring can only work together if they are only applied once, and that should happen in oox/, that's why we already have a mechanism to send the position from writerfilter/ to oox/ for WPS shapes. (<a:xfrm> contains the size, but not the position of the shape, so oox/ in itself could not know the position.) Fix the problem by improving ShapeContextHandler instead the pass the position from writerfilter/ to oox/ for <pic:pic> as well, the same is done for <wps:wsp> already since commit 6c4f737ec88a4f4dc5da8b2295ca5e7de2d4c24f (DOCX drawingML shape import: fix position when CustomShapeGeometry is set, 2013-11-21). Change-Id: I74a60136d0ca8383e58948711b47858823f42437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105263 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-11-03tdf#87474: sc: Add UItestXisco Fauli
Change-Id: I2c915372076228164e6322fad84643971ea4e105 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105257 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03Reordered token.hxx.dante
It will be easier to follow the list. Minor changes respecting set ( added it/s owns tokens to setminus, setquotient ). Change-Id: I879675db8634a54ff3f16e7c00e4aedcaeb429cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105242 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-03Added hexadecimal number and color support for starmath.Dante DM
Adds hidden command on guy hex number wich allows to use numbers of base 16 and also 0-9-A-Z. Added support for custom RGB colors on hexadecimal on starmath via command color hex colornumber. Improved RGB color handle on starmath. Changed the way the color is handled on starmath. Colors keywords won't give errors. They have been moved to an independent tokens list so starmath will load tokens faster. Changed the way the font size is handeled on starmath. This won't change anything, just related with the structural change. Implemented premature support for rgba colors on math. This change only adds the possibility on the parser, node and node visitors. For now end-user can not access it since in a future there'll be work to do on the renderer to add full support. Added hex entrie on the docking window. Changes made on Color.hxx, will save some nanoseconds on build. If you are interested on allowing rgba and do the job on the renderer (and all the other stuff than there are a lot of .GetRGBColor()), you may find usefull color hex colnum. Since transparency setting is ignored, the hexadecimal color has hidden support for it since did not instore the max value (255 + 255*256 + 255*256*256) and everything is loaded into the sal_uInt32. Change-Id: Iafb38b142fffa329ca468e3d62643154fcdd2bbf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/104630 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-03add pdf to DRAWDOCS for bash-completionRene Engelhard
Change-Id: I02195cb235774d205e9f9cc8821b897a841fa54f
2020-11-03tdf#137912 update toolbarmode previewsandreas kainz
Change-Id: Ic326758b3c25a4acd22dd5a029619b1972f43267 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105245 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-03Resolves: tdf#137215 restore original modality before dialog loop endsCaolán McNamara
Change-Id: I83467e28534b781c51b8d75a023e41f3c6a03903 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03downgrade to SAL_INFOCaolán McNamara
happens a lot and doesn't indicate a problem anyone needs to fix Change-Id: Ie0c36b61855545629641306820447d5d96b8d841 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105250 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03Update git submodulesIlmari Lauhakangas
* Update helpcontent2 from branch 'master' to 9e62afaaebac009fcfee18ef998f0db3baf953b4 - Fix macro example for While...Wend Change-Id: I09aa5a76319fb018d429028c88d4ed964f59e8f0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105262 Tested-by: Jenkins Reviewed-by: Ilmari Lauhakangas <ilmari.lauhakangas@libreoffice.org>
2020-11-03loplugin:unusedfieldsNoel
Change-Id: Ia8e2a7ce75bfded98e85fa583d1404710069d335 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105249 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-03Resolves: tdf#136611 chart doesn't support corner style or capsCaolán McNamara
Change-Id: Ibee5b90fff28504d87462b3839bb58dfc6911a39 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105248 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03remove pimpl in SfxBroadcaster/SfxListenerNoel Grandin
and provide an optimised copy constructor, we can avoid a bunch of work. Change-Id: I3a373fbbfab02455e6a65e9036b3629366174379 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105205 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-11-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 5e05fa7961c2ee91399a4b4b211331555a2b94fe - Fix vocabulary (line -> row) Change-Id: I9937e9fdce99eae607af991fc5c6311c79204af6 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105213 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-03tdf#137886 condition for asian and ctl property seems wrongTomoyuki Kubota
Change-Id: Ifc11f3bbcc499143904ac7c206674cc692cf5239 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105054 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-11-03Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to d937c9de1e07f4cc6c5bfe77b687a3537da86f01 - update help pages for customizing menus and context menus ( shared/01/06140100.xhp ) Change label: "Function" --> "Available Commands" Change "function" -- "command" in Function description Change "function" --> "command" in "Right Arrow" to be consistent with "Left Arrow" and "Available Commands" Add label and description for "Assigned Commands" Remove redundant sentence from "Target" now that "Assigned Commands" is added. Reduce hierarchical level for submenu items "Add", "Remove" Add image for "gear" icon update to: <h1>,<h2>,<menuitem> ( shared/01/06140300.xhp ) Replace "Function" label (and description) with embed from ( shared/01/06140100.xhp ) Add "Assigned Commands" label and description with embed from ( shared/01/06140100.xhp ) Add "Right Arrow" label and description with embed from ( shared/01/06140100.xhp ) Remove redundant sentence from "Target" now that "Assigned Commands" is added. update to: <h1>,<menuitem> Change-Id: I505b366a79f832c40328ad441867f9ba84af8a7a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105212 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-11-03tdf#91762: sd: Add UItestXisco Fauli
Change-Id: Ia3c75206a5207a95162970ac6607be96dac9fcb7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105243 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03loplugin:unnecessaryvirtualNoel
Change-Id: I71c49cb66177547ce6f5bd4ab702c7d9d358a426 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105244 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03Colibre svg shape icons add css parameterandreas kainz
Change-Id: I132fc552720fca7c0ee138b8485a60913061e394 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105236 Tested-by: Jenkins Reviewed-by: Andreas Kainz <kainz.a@gmail.com>
2020-11-03ucbGet needs a non-null interaction handler after allStephan Bergmann
In db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download https files", I had not further investigated why using the (GUI) interaction handler within utl::UcbStreamHelper::CreateStream would lead to deadlock during UITest_sw_options (UITEST_TEST_NAME=optionsDialog.optionsDialog.test_moreIconsDialog). Instead, I had passed a null XInteractionHandler into utl::UcbStreamHelper::CreateStream, assuming that would solve whatever the issue was (and it did make the UITest pass). However, that caused the AdditionsDialog to not be populated at all, with > warn:cui.dialogs:26878:26950:cui/source/dialogs/AdditionsDialog.cxx:95: Reading <https://yusufketen.com/api/Templates.json> failed with 0x20d(Error Area:Io Class:General Code:13) (see comment at <https://bugs.documentfoundation.org/show_bug.cgi?id=137922#c1> "Extensions button in Template choose does not show anything"), because interaction requests like com.sun.star.ucb.CertificateValidationRequest were not handled properly. As it turns out, the real reason for the deadlock was that the UITest quickly closes the dialog, causing the main thread to block at m_pSearchThread->join(); in ~AdditionsDialog waiting for the SearchAndParseThread to finish, while SearchAndParseThread::execute encountered a CertificateValidationRequest that needs to be handled and thus blocks in UUIInteractionHelper::handleRequest (uui/source/iahndl.cxx) waiting for the main thread to process the PostUserEvent. In an ideal world, the UCB would allow to cancel the download request issued from ucbGet while that download is waiting for the CertificateValidationRequest to be handled, and the AdditionsDialog CloseButtonHdl would initiate such cancellation. Lacking that, just keep the Close button disabled until the SearchAndParseThread has finished downloading. (Pressing the Close button earlier, ~AdditionsDialog would have blocked the main thread anyway until SearchAndParseThread had finished downloading, so this should not actually worsen the user experience. And the UITest now blocks waiting for the Close button to become enabled before pressing it; there would already be UITest.wait_until_property_is_updated available, but it has a hard-coded timeout which might or might not be relevant in existing uses of that function, so leave it alone and repeat the relevant code without an unhelpful timeout here.) This means that the additional utl::UcbStreamHelper::CreateStream overload introduced in db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download https files" is not necessary after all, so remove it again. Two further items that should be looked into: * Should ucbGet pass the AdditionsDialog into utl::UcbStreamHelper::CreateStream as css::uno::Reference<css::awt::XWindow> xParentWin argument (which defaults to null)? * There might be similar deadlock issues involving ucbDownload, which can also be called (indirectly) from SearchAndParseThread::execute. Change-Id: I8d549066940fa4f259a814a31ec7c62960e0db8f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105169 Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2020-11-03Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 0d798e62a062274573818ef3a9442db82730b1e2 - update help page for Edit - Links to External Files - updated "generic" explanation used by all modules with "links_text" variable. This explanation is now embedded in the overview of the Edit menu help page for all modules. - added module switch (after generic explanation), to indicate which specific kinds of links can be edited. (Kudos to Mike Kaganski for essential help) - change label: Links --> Links to External Files - also in access command in edit_menu - reorganize controls to correspond to dialog order - move paragraph about double-click to under "Source" heading - move <notes> to end of page -- they are not directly relevant to the command, but the information is generally relevant to those who would use this command, and not found currently elsewhere. - remove sys-specific warning about local cache (thanks again Mike) - add embed about "Close" command - removed "verknuepfungentext" variable and updated sdraw to use "links_text" like other modules (this was only place where that variable was used). - update to: <h1>,<h2>,<warning>,<note> - add some <keycode> to edit_menu Change-Id: Idea3c38569f139a8d2e51de3c75a238c5fc35cf8 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/104677 Tested-by: Jenkins Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk>
2020-11-03check-missing-unittests: use regex and simplify codeXisco Fauli
Change-Id: Ica37de1adad0e97d1efd5f3f699d570af97ca90e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105188 Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03tdf#137617: sc: Add UItestXisco Fauli
Change-Id: I544a221e7b3c76bb046235768d3fdcb700805579 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105239 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03Update git submodulesStanislav Horacek
* Update helpcontent2 from branch 'master' to 1f43f06696448efd5b6bf076be0162e66361643a - update removing background color in options as it is in UI Change-Id: I9caf493f4318b36de27873af6fb757766b887f55 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105097 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2020-11-03I am sure the fill-column value of 102 here was accidentalTor Lillqvist
I can't think of any reason to use such a pointlessly seemingly specific value. Let's just use the round number 100, as for source code (see TEMPLATE.SOURCECODE.HEADER). Change-Id: If61af553f8142dfcba31e775d050d167f89c010b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105235 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-03Drop the #undef ABSOLUTE FIXMEStephan Bergmann
c4bee547b02fbe3d07b1e9ee203c73e48f86e6bf "tdf#133026: Additions: Better Search Function" does not tell which #include had brought in the macro definition. It might have been the #include <curl/curl.h> that has meanwhile been dropped with db6c7a486395304f38e9ea52951f576f34749cbc "Use UCB instead of cURL to download https files". Change-Id: Ib9cf761ca11e5cb7496b21dc04faee3491ef9dcf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105073 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-11-03Related: rhbz#1893846 GetActiveWrtShell can return nullCaolán McNamara
Change-Id: I862f562d0f799defde49a3a0eefcdc11b925a404 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105203 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03duplicate redundant linesCaolán McNamara
Change-Id: I5766aee2a07879d3064387f72a87c38ce431e9be Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105202 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03extract cleanup piece to its own functionCaolán McNamara
this is from a failed campaign against tdf#122894 Change-Id: I639d65394cadca6ca70613dfd13691fd7b5f5104 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105191 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03Resolves: rhbz#1893846 if last close had insert, index dialog openCaolán McNamara
when starting a new writer document Change-Id: I83131c01aa53208a321abade48d48a6f7965d0ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105201 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-11-03tdf#137814: Rename Properties to Page/Slide PropertiesAyhan Yalçınsoy
Change-Id: I0fa4c981a1dd833f14c134a33911ee31eb81748c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105186 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-03Rearrange mnemonic keys in Export as PDF dialogMing Hua
While fixing tdf#133403, commit c42dc1be0c3161e621ed0a667ae6b047f8bb23d4 also introduced new mnemonic keys that clash with existing ones. This patch rearrange those newly introduced mnemonics (O for outlines) as well as others so that there are no double-used keys. Change-Id: Ia82316741995cc2a9d430bc51680ce84bec340bb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105209 Tested-by: Jenkins Reviewed-by: Ayhan Yalçınsoy <ayhanyalcinsoy@pisilinux.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-11-03tdf#135893 sw paste: fix copying fly frame in textbox twiceMiklos Vajna
Regression from commit c7307c77254557646f33017af915f6808a861e29 (fdo#82191 sw::DocumentLayoutManager: copy textbox content of draw formats, 2014-08-15), the problem is that the fly+draw format copies the fly content recursively already, so when we would copy all special formats of the document, the inner fly frame is copied twice. This is normally not a problem for fly frames (where you can't select multiple fly frames at the same time), nor a problem for draw frames (which have no sw content), but it's a problem for the combination of these, TextBoxes. Fix the problem by ignoring fly frames which are anchored in such TextBoxes: we do the same for fly frames which have an associated draw format already. Change-Id: I3376beb414f91abfa6f3f5640f825ccae34911c2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105204 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-11-03writerfilter: remove leftover commentMichael Stahl
Change-Id: Idb6dbb7ccb9a254def6029bb9ba84a3b02015d70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105196 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-11-03tdf#105967 sw change tracking: fix line break symbol in empty lineLászló Németh
At line break symbol of inserted or deleted empty lines, paint strikeout/underline based on redline color. Keep also the underline and strikeout formattings of the line break symbol in neutral color (NON_PRINTING_CHARACTER_COLOR), if they are not affected by change tracking. Note: in non empty lines, remove also the colored (not NON_PRINTING_CHARACTER_COLOR) underline/strikeout, if it's not based on redlining, fixing the double colored lines on the neutral color line break symbol. Follow-up of db25f1e2e3ae7a078f8f3c080ff3c4802f83b853 (tdf#105967 sw change tracking: fix pilcrow in empty line). Change-Id: I565a10154f5ecbefeb00fe3e17a53f74f2f84e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105206 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-11-03Colibre: Update Slide/Page Background and Page Size iconsRizal Muttaqin
Change-Id: I26771535e4305a59e8ee00302c85dfeb4f2aed2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105231 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-11-03tdf#137896: sc: Add UItestXisco Fauli
Change-Id: I38d2d31f28bfbabc8003a11520ad26e3df2a29a5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105199 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03uitest: test creation of range names from uiXisco Fauli
Change-Id: I3897a8a4dc77b5d41b3b64a03146c121fee5c83b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105229 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-11-03i386 is not used at all on macOS since many yearsTor Lillqvist
Change-Id: I6e9b61da73509f40575640209082defc34bcbf63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105230 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-11-02Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to f9f9dd593ca29d23fec10381f3fd70e3bebfd8d1 - tdf#137221 make corrections in help page for using "Page line-spacing" + embed new sentences from Glossary at top of page + correct the procedure for enabling for a page + add explanation about "Reference Style" + separate explanation for Paragraphs and Paragraph Styles - embed the repeated part in Paragraph Styles. + add links from menu sequences to relevant help pages. - remove "related topics" and its one link, which went to the Paragraph help page, which is now made as a link in the menu sequence. [Thanks to Regina Henschel for controlling technical accuracy.] Change-Id: I75715e6b035b12912318504c6186a689f248a82a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/105053 Reviewed-by: Seth Chaiklin <sdc.blanco@youmail.dk> Tested-by: Jenkins
2020-11-02move SwCondCollCondChg on top of SfxHintBjoern Michaelsen
... and get rid of ModifyNotifications along the way. Change-Id: I10fc9d24743d50cef771ff63dae004d31dce1846 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105195 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-02sw/source/core/layout/atrfrm: Remove remaining uses of ModifyNotificationBjoern Michaelsen
Change-Id: I344ec4b834c52f45c27a88b501c6048853437f36 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105197 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
2020-11-02ndtbl: remove remaining use of ModifyNotificationBjoern Michaelsen
Change-Id: I31ccf872fbfaad9867e7e193491a525df46952e0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/105198 Tested-by: Jenkins Reviewed-by: Bjoern Michaelsen <bjoern.michaelsen@libreoffice.org>
generated by cgit (git 2.34.1) at 2024-07-02 18:30:27 +0000