summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-03-25tdf#124172: Use the MacOSXSpell library on iOS, tooTor Lillqvist
The code needed just a small amount of ifdefs to use UITextChecker on iOS instead of NSSpellChecker. Change-Id: I19edfffd3cc317a79beacc0b94668a6fd5ea3b32
2019-03-25sfx2: missing includeMiklos Vajna
Change-Id: I3778f8e6870c31c15a6c04e720414def47f7fc6c
2019-03-25fix grayscale jpeg writing in pdfexport (tdf#121615)Luboš Luňák
If the bitmap to be written is non-8bit, e.g. in case of using OpenGL (on Linux the test requires "SAL_FORCEGL=1 SAL_USE_VCLPLUGIN=gen", on Windows it's probably the default case), then the bitmap is not in native format for 8bit. This was done correctly by 45e8e0fbee40f that introduced it but somehow it got lost later (I can't even find where). Change-Id: Ib1810cb9cf12e373c1cb41da40fa28e96ad7db28 Reviewed-on: https://gerrit.libreoffice.org/69213 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-25tdf#42949 Fix IWYU warnings in include/sfx2/[a-D]*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I444cb71bc3d045072a4b1f9eed279ed7e425a0d4 Reviewed-on: https://gerrit.libreoffice.org/69481 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25Converters for OOXML orients and relationsPatrick Jaap
Change-Id: I8e3ade11881d88e937b1a55598813b2265cafd95 Reviewed-on: https://gerrit.libreoffice.org/69522 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25tdf#124112 Insert drawing object in chart crashes LibreOfficeNoel Grandin
regression from commit 6be7e2e9dd8027d284f1b00ef6e3b4654eec7d79 Date: Thu Aug 30 13:54:33 2018 +0200 pass SdrUndoAction around by std::unique_ptr Looks like previously this memory was just leaked, so fix that and the crash Change-Id: I5eb5c104dccd82cef30af533ce1fe8546ced0ea0 Reviewed-on: https://gerrit.libreoffice.org/69648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-25tdf#124318 FILEOPEN: XLS Hyperlink URL incorrectNoel Grandin
regression from commit 52f69445c55c9af8ad97bee6da335b4592d56d4d Date: Wed Aug 1 17:03:18 2018 +0200 loplugin:stringloop in sc Change-Id: I7d481ea27866fc146c5de9d027aa7bb308f14e52 Reviewed-on: https://gerrit.libreoffice.org/69652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-25avoid a crash with an editor-forced matrix formula (tdf#123479)Luboš Luňák
Normally when ScInterpreter has bMatrixFormula set, pMyFormulaCell is set as well (done in the ctor). But in some rare cases, this may not be so, and some functions such as ScRandom() already check for this. But not all do, tdf#123479 specifically crashes because ec97496525f82f added AssertFormulaMatrix() to force bMatrixFormula be set without pMyFormulaCell being set, and ScColumn() doesn't handle this case. Fix this by trying to pass ScFormulaCell* to ScInterpreter when AssertFormulaMatrix() is used, this should ensure the result in the formula editor fits better the edited formula. Since there still may be cases when the cell is not set (e.g. editing a new formula), also handle that case gracefully. Ideally ScSimpleFormulaCalculator should pass ScMarkData to ScInterpreter in such cases so that those functions use that when they can't use GetMatColsRows(), but currently the handling of selections is rather poor in the formula edit dialog: Non-array formulas are simply entered in one cell and the selection is ignored, in case of a multi-selection there's an error dialog only after the dialog is closed, and the result field of the dialog is rather small and doesn't scroll, so e.g. matrix result of ScRandom() wouldn't show more than one item anyway. Given that tdf#123479 is a priority bug, better just fix it and possibly handle selections better somewhen later. Change-Id: I5fcbe1e358fac3623d4917eb0ead8eae00a1e153 Reviewed-on: https://gerrit.libreoffice.org/69161 Reviewed-by: Dennis Francis <dennis.francis@collabora.com> Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Luboš Luňák <l.lunak@collabora.com>
2019-03-25sw: prefix members of SwUndoSetFlyFormatMiklos Vajna
Change-Id: I64701255f3c0d0eb05e9962819deaef9aa8127c3 Reviewed-on: https://gerrit.libreoffice.org/69644 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-25We can simply use DBG_UTIL now after efc29fbb6d458f5fd3660a36e2ff1592608fcbacTor Lillqvist
Change-Id: I74cce2d3fb4661ea9a44d0b166ca98dfade53056 Reviewed-on: https://gerrit.libreoffice.org/69604 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-25Removed executable permission on data filesAndrea Gelmini
Change-Id: Ic21b28fd094f706dd7b1de32907d75e28f27494a Reviewed-on: https://gerrit.libreoffice.org/69558 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-25Fix typoAndrea Gelmini
Change-Id: I889e7809e8ae48f770afd376cc2d6eca3442b189 Reviewed-on: https://gerrit.libreoffice.org/69642 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-25remove debugging leftoverNoel Grandin
Change-Id: I656d769f8cfd332172b2a73e9d8eb8a911eac2f8
2019-03-25Sifr icon theme update _lcandreas kainz
Change-Id: I76d9431b0c763ab012f60b89390de216b445c301 Reviewed-on: https://gerrit.libreoffice.org/69609 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-25new loplugin:unoqueryNoel Grandin
look for places we are doing code like: Reference<XProperty>(model, css::uno::UNO_QUERY)->getAsProperty() which might result in a SIGSEGV is the query fails Change-Id: I5cbdbc9e64bd0bed588297c512bf60cbacb9442e Reviewed-on: https://gerrit.libreoffice.org/69044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-03-24Fix compilation for !HAVE_FEATURE_DBCONNECTIVITY caseTor Lillqvist
Change-Id: If907624a7c52e7f11d74a9f50078068d0f80dc5f
2019-03-24tdf#124240: make type in TOC translatableJulien Nabet
Change-Id: Ie3e713786b096657571d0abe0806b1d45d2b5341 Reviewed-on: https://gerrit.libreoffice.org/69585 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-24Sifr icon theme update lc_andreas kainz
Change-Id: Id5c80072ac15a1cf2b04fdbcc94e4d506570491a Reviewed-on: https://gerrit.libreoffice.org/69593 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-24Make some .ui strings translatable / not translatableGabor Kelemen
Found with bin/ui-translatable.sh Change-Id: I63d613a946c32821c836aaeda897b9713cc681f7 Reviewed-on: https://gerrit.libreoffice.org/69595 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-24ui-translatable.sh: fix item tag detection for liststoresGabor Kelemen
Previously this script did not find the untranslated liststore items that tdf#124240 is about Change-Id: Ie46d99d246eee316fdda95bdf2d1d3a9aacbc907 Reviewed-on: https://gerrit.libreoffice.org/69596 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-03-24Resolves: tdf#122114 remove support for ~/.recently-used fileArkadiy Illarionov
Change-Id: Ie91f0bf21e6f5c3f7a7aa4ae3d1dff6cc8e15a86 Reviewed-on: https://gerrit.libreoffice.org/69597 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-24Extend timeout for .uno:AutoCorrectDlg UITestsStephan Bergmann
...which often timed out for the ASan+UBSan Jenkins build, so lets hope that it was just an issue with a too short timeout there Change-Id: Ie50eb1cc16e9444d1392c95ef5c6d810b9e4bd17 Reviewed-on: https://gerrit.libreoffice.org/69599 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-24weld SvxSearchDialogCaolán McNamara
I have to use the other way to specify an a11y role, both are implemented in the vcl parser, but in my gtk3-3.24.7 the role tag crashes the gtk parser, while the other route works fine. The CONTENT_FLOWS_TO accessibility relation is another additional complexity over the norm Change-Id: Ia096bcbe9f00f9944e4e4d5ad9bb1a52d19c7b3f Reviewed-on: https://gerrit.libreoffice.org/69569 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-24Fix typoAndrea Gelmini
Change-Id: I2a71473c872d4c69de728857e74a4a7c1b89fb36 Reviewed-on: https://gerrit.libreoffice.org/69594 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-03-24tdf#124237 Qt5 get link colors from themeJan-Marek Glogowski
... which includes normal and visited link colors. Change-Id: Id53850c4700f71d007b59289b135d3c031348f2d Reviewed-on: https://gerrit.libreoffice.org/69591 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-03-23ComboBoxes have subwidgets in them, combine together for has_focusCaolán McNamara
Change-Id: Id57190ebf478641ad2a1ac79ef6a01fbb69af1ed Reviewed-on: https://gerrit.libreoffice.org/69592 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-23Consistently make generator invocation $(QUIET) tooStephan Bergmann
Change-Id: I5251f130aafdebdb4698ef4513b1dcf9f3bdf454 Reviewed-on: https://gerrit.libreoffice.org/69571 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-03-23ofz#13881 Integer OverfloWCaolán McNamara
Change-Id: I90dc8be47cff080bc4e8242c2ae0961c2bc92aba Reviewed-on: https://gerrit.libreoffice.org/69588 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-23Introduce new lockfile handler for MSO like lockfilesTamás Zolnai
* Implement writing of MSO lockfiles * Grab the already implemented parsing code (tryMSOwnerFile method) and put it together into one class * Add tests about the generated URL for lockfiles and the lockfile content * MSO lockfiles are not written yet by LO, next step is to integrate this code into the locking mechanism. Change-Id: I3b0ed1975cd57dfd006d4e1890b23c307890de5c Reviewed-on: https://gerrit.libreoffice.org/69582 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-23factor out the adding to an atk relation set codeCaolán McNamara
Change-Id: Ie81cfaab1fac15648fc8ba89391bdedd5c1e6c90 Reviewed-on: https://gerrit.libreoffice.org/69590 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-23Sifr icon theme update lc_andreas kainz
Change-Id: Ia2001181f2bf2ab1964b0858c311e7846f4d7521 Reviewed-on: https://gerrit.libreoffice.org/69573 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-03-23tdf#123072 Qt5 just use data from QFontDatabaseJan-Marek Glogowski
This way we can skip the intermediate QFont creation, which takes a much longer. The database information is actually sufficient. Change-Id: Ie5ab163edf6a1712d45b0738bb2e4822f2e3298c Reviewed-on: https://gerrit.libreoffice.org/69579 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-03-23tdf#123072 Qt5 don't register unknown PSP fontsJan-Marek Glogowski
LO's own font handling backend has some additional font styles, which are unknown to Qt, probably because it uses some stricter handling to decide which fonts are "usable", and because Qt seems to not know about some style types AFAIK. The main problem is QFontDatabase::addApplicationFont, as this seems to parse the whole font instead of a kind of registration, which takes ages for something like the Noto CJK style variants. As a workaround this drops the registration of all the additional PSP fonts. Both Qt5 and PSP use fontconfig but there is definitly some difference here, which needs to be resolved in some other way at some point. Change-Id: Id63cd0258ff56ee988323551820500b2c72a12be Reviewed-on: https://gerrit.libreoffice.org/69576 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2019-03-23KJ & elementary: Add more Writer's menubar items, add redact icons, ↵Rizal Muttaqin
i#119731, tdf#53524 Change-Id: If4c8de085701af503a43a143c7eec5263e36d59b Reviewed-on: https://gerrit.libreoffice.org/69580 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2019-03-23formatting fixesLuboš Luňák
Change-Id: Ie8ceead5cba72abf32e57e214e677dbf478941d4
2019-03-23Qt5 fix Qt5Instance::IsMainThread()Jan-Marek Glogowski
... and I was wondering why Qt5 didn't start anymore. Looks like it was already broken in my initial commit :-( Now there is also no more need for the KDE5SalInstance "variant". Change-Id: I035d31eaf191b3f2a4255869cea25394470d0dd0 Reviewed-on: https://gerrit.libreoffice.org/69577 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2019-03-23tdf#123937 XML Filter Settings Dialog: Move "help" and "close" buttonsAlexander Farrow
Move the "help" and "close" buttons to the bottom of the dialog. The "help" button will be at the bottom left. The "close" button will be at the bottom right. Change-Id: I496a3c95dd4761d8a360ad85fc5af03d0c53f131 Reviewed-on: https://gerrit.libreoffice.org/69468 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2019-03-22tdf#123832: Try to prevent/control hung wusa.exe while installing UCRTMike Kaganski
Reportedly under some circumstances execution of wusa.exe may hang for very long time (available logs show more than 90 min). LO MSI installer waits for wusa.exe indefinitely in its deferred inst_msu custom action; during this wait, one can't abort the installation. There is an evidence [1] that stopping WU service prior to wusa launch might prevent this hang. The patch does two things: 1. It stops running WU service prior to wusa launch. 2. It adds a check for user input by executing MsiProcessMessage twice a second, and checking its return value, to allow early return in case user cancels the installation. This is a blind shot, since I cannot reproduce the problem myself. [1] https://superuser.com/questions/1044528/ Change-Id: I8bf4ce52b3e9d98a4f90af3abcc49ac63b6a0e40 Reviewed-on: https://gerrit.libreoffice.org/69487 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-03-22Remove listening in ScDocument::SetString() and ScDocument::SetValue()Eike Rathke
They now unnecessarily duplicated the start listening with the changes that introduced ScColumn::StartListeningUnshared(). Also the ScColumn::BroadcastNewCell() now is sufficient as it is called after StartListeningUnshared(). Change-Id: I0495ce5fe47daa068974c7b70ec28e0530c080f1 Reviewed-on: https://gerrit.libreoffice.org/69570 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2019-03-22Unit test for cut copy move intersecting a formula group run, tdf#120013Eike Rathke
Change-Id: Ice7e1e42dba7bfbc2db6a60e4457c3610430b87e Reviewed-on: https://gerrit.libreoffice.org/69568 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-03-22Use RegexMatcher.find(pos, status) call on old ICUTomáš Chvátal
The RegexMatcher.find(status) is new since icu 55 and this works even on the old releases thus revert there to the available albeit slower call. Change-Id: I964c10efd15515b04ac9037cda3b5b309910baf5 Reviewed-on: https://gerrit.libreoffice.org/69311 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2019-03-22Unfloat: Move the button to the top of the frameTamás Zolnai
User can find it easier in this position. Change-Id: I38fd782485a180e0d5223b52cc2c6ee061661600 Reviewed-on: https://gerrit.libreoffice.org/69562 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-22Related: tdf#124109 vcl: make glyph item caching work with kashida glyphsMiklos Vajna
This was broken because GenericSalLayout::LayoutText() sets the SalLayoutFlags::KashidaJustification flag as a side-effect of building the glyph list. So in case we cache the list and not build it, the flag will be missing. This means that later in GenericSalLayout::ApplyDXArray() kashida glyphs won't be inserted. With this, the workaround in sw can be removed. Change-Id: Ic18211bf50ca673daa238e8950a381915e4b3096 Reviewed-on: https://gerrit.libreoffice.org/69566 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-22GraphisObjectTest: Remove some unused test documentsTamás Zolnai
Change-Id: Id97a35cdef93f4e1b21e4c3d22918f1bae42aea9 Reviewed-on: https://gerrit.libreoffice.org/69563 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-03-22opengl's drawBitmap() should also scale properly if needed (tdf#123372)Luboš Luňák
If the bitmap to be drawn will need to be scale for drawing, OpenGL handles this by scaling, but the scaling is of poor quality. Other backends scale in such a case with a good quality, and e.g. opengl's drawAlphaBitmap() also does the same check, so copy that check to drawBitmap() as well. Change-Id: If6a457c69c6676d03fa4046b9910683f51479d21 Reviewed-on: https://gerrit.libreoffice.org/69556 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-22Resolves: tdf#124264 Close should be CancelCaolán McNamara
Change-Id: Idf3cac2c8a37850ac254553164b57c777c2fd850 Reviewed-on: https://gerrit.libreoffice.org/69560 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-03-22FIX: Use correct table x/y postion in docx exportPatrick Jaap
Until now we exported the original x/y position values of the table from the grabbag. Ignoring users actions like moving the table around. Now, we compute the position from the parent frame and write the actual position in the docx file. Change-Id: I25a09f9c7c8fbe49acbd19e2b1440c7fa90b8aff Reviewed-on: https://gerrit.libreoffice.org/67969 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-03-22tdf#119905 Infobar text overlapRasmus Jonsson
Make SfxInfoBarWindow text wrap (WB_WORDBREAK) by default. Make SfxInfoBarContainerWindow stretch to fit its content (the wrapped text) Change-Id: Ib6f68011b4f2a4813dc5e0316281583b9ac641ee Reviewed-on: https://gerrit.libreoffice.org/69482 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2019-03-22Related: tdf#124109 sw: save one vcl layout call in SwFntObj::DrawText()Miklos Vajna
Commit 436b829f5b904d76039db0818cff5dedf1ae89f1 (sw: save one vcl layout call in SwFntObj::DrawText(), 2018-08-16) did this unconditionally, which broke kashida justification. Re-introduce the same mechanism, but this time opt out in the kashida case to keep that working. This means that for Latin scripts we are back to 2 layout calls (instead of 3) for each keypress in Writer. Change-Id: I890f0ab04d1f5dce561f1536d7c8a6d67a639813 Reviewed-on: https://gerrit.libreoffice.org/69557 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-03-22Update git submodulesCaolán McNamara
* Update helpcontent2 from branch 'master' - Resolves: tdf#122479 no extended tooltips for Reset and Standard buttons a) in the ahelp HID_TABDLG_STANDARD_BTN hid is used instead of SFX2_HID_TABDLG_STANDARD_BTN b) there are multiple entries for HID_TABDLG_STANDARD_BTN, the second one describes some wizard previous buttons and the third one is definitely describing an expander button, not standard buttons c) HID_TABDLG_RESET_BTN likewise is unsed instead of SFX2_HID_TABDLG_RESET_BTN and appears in two places, the second of which is tagged with "what's this" and "A confirmation query does not appear. If you confirm the dialog with OK all settings in this dialog are reset." so: use a hid of "." which means to apply to all the previously seen bookmarks hids since the last ahelp current bookmarks are those within the current section add another bookmark for the "options/more" expander, which isn't currently linked to by anything but could be if desirable in the future drop the second text describing Reset button which has no bookmark in its section Change-Id: I8c89ea7a5588dc22c29ccdd78118b9288a609563 Reviewed-on: https://gerrit.libreoffice.org/69559 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-08-14 02:53:10 +0000