summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-06-11ofz#23300 infinite loopCaolán McNamara
Change-Id: I0ee67e8efefa48942357340cae46bd7ece27e5b7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96085 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-11tdf#101856 copy missing bookmark propertiesSerge Krot
- in case of undo/redo - in case of copying bookmark Change-Id: Ia21f42973b0e7c2cc4abfe2febe9818509aec4d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96064 Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-11crashtesting: sw: fix export of ooo24576-1.doc and ooo79410-1.sxw to odtMichael Stahl
Crashes because an at-char fly has its anchor node deleted, and during deletion of its text frame its SwAnchoredObject is updated, which asserts because of inconsistent anchor node in the fly and mpAnchorFrame; the immediate cause of the inconsistency is that SwNodes::RemoveNode() changed the fly's anchor node. The root cause is that in the sw_JoinText(bJoinPrev=true) code, a fly anchored at the end of the deleted node isn't moved to the surviving node. SwTextNode::JoinPrev() uses different arguments to ContentIdxStore::Save(), so use the same here. The implementation of several ContentIdxStore functions, including ContentIdxStoreImpl::SaveFlys(), ignore positions that are equal to the passed nContent index, so passing in SwTextNode::Len() looks wrong. (crash is regression from 98d1622b3721fe899c4e1faa0b4cc35695253014) Change-Id: I3a4d54258611da6b15223273a187c39770caa8e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/93583 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-11tdf#132431: sc: Add unittestXisco Fauli
Change-Id: I4ecae9e29827a29680c9f082a9602fc181b0b56e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96024 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-11When running make debugrun separately for UITest it needs LANG=CTor Lillqvist
Change-Id: I175ff33704bb1f709a59d53d3e11aa54f45d9b8b
2020-06-11don't need to treat floating toolbars differently for set-focusCaolán McNamara
We don't seem to need this anymore, probably commit ea1182c8c2c42c0c527e232f7e392196796940d7 Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Jun 10 12:16:17 2020 +0100 grab focus to style combobox when parent gets focus was the right fix Change-Id: If5d966bfb3fcb47ba09f81b1e786df76a7561bf0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96071 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-11Resolves: tdf#133862 crash in customize toolbar in embedded mathCaolán McNamara
Change-Id: I2fc7f3620145e48516c3ca73c0a5d08dce11d78a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96054 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-11tdf#132254 sw: fix block selection copy reversed orderMichael Stahl
The problem is that SwEditShell::CopySelToDoc() relies on the passed target SwPosition being after the target range by CopyRange(), but due to an erroneous update of aInsPos in CopyImplImpl() it was at the beginning of the target range. (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: Ie0846bd44f9349517878efcca996440bede05611 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96063 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-11initialise ScMatrix once instead of twiceNoel Grandin
initialise the mdds matrix inside ScJumpMatrix once instead of twice Change-Id: Ic6883418d965a093c76ab5dbf4c8780c174f10bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96067 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-11fix my own mistakeTomoyuki Kubota
Change-Id: I01f3b405e91175ab0ef532505bf9f275073d2fc0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96044 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-11typo in commentStephan Bergmann
Change-Id: I60bcfa3182ce67ab50195ae6e7436839afe62c87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96028 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-11^ Conditional format, Impress' place holder, hyperlink dialog iconsRizal Muttaqin
Change-Id: Ib4b920335495cc7646537d58fb644ddb307faf70 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96072 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-11Make it possible to just build the native code for Android, no Java bitsTor Lillqvist
Change-Id: Ic25b8d72c9e60c0bee04765d51565c2864ec25ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95850 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-11tdf#133268Rizal Muttaqin
- Update Calc's Paste Special - Update Emoji - Update images of Draw/Impress export as HTML - Add Save All - Update Merge Cell image Change-Id: I73a3c9ff28dffe1e83f63385abf19ecd970f8df1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96058 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7c42a667bf18ea2ce2f88e11978a13b3860c7689 - Unmute L10N in string Change-Id: I89116a7fb1e94ded67629d5e4f397a2ff292eaa4 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96073 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-11sd signature line: inform infobar if a cert is already selectedMiklos Vajna
In case a pdf is opened for signing, the infobar has a button to start the signing. If a signature line is already inserted and the user picked a certificate, then let's call the infobar button's action "finish signing", since the signature list and the certificate chooser won't appear in this case. (The actual behavior when you click on the button is still unchanged, though.) Change-Id: I50ee2455c91cdee26612a6b8239dbb6772401877 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96060 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10tdf#132597: sw: Add UItestXisco Fauli
Change-Id: I0f577b5124c871e9ba766958d81511ad3ad0e5e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96014 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-10let the parent toolbar decide the focus of the buttonsCaolán McNamara
Change-Id: I481fbc1b65b806cdb9eb41d6648fe9476f1326fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96020 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10grab focus to style combobox when parent gets focusCaolán McNamara
Change-Id: Iaee1a8399e8e4f70a52ce99be113e9e7607a5ab7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96019 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10PPTX export, custom shape, bitmap fill: fix source vs fill rect confusionMiklos Vajna
Commit 682ab832522b1349f1714bcb16f6e83468ea2920 (drawingML export\import: cropping of shape's fill texture, 2014-02-12) improved the DOCX filter, so the fill rectangle of a custom shape with bitmap fill is handled. The problem is drawingML has a source rectangle (similar to our crop rect) to limit the usage of the bitmap, and also it has a fill rectangle in case some margin is wanted around a stretched bitmap. We don't have a mapping for the later. Fix the problem by limiting the above work for DOCX, this way PPTX's source rectangle won't be turned into a stretch's fill rectangle. This way no unwanted margins will appear around the image -- those margins can be large enough that the image effectively disappears on export. Change-Id: Ic35063545a56eec9eaf885bbd397a854705d134f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96025 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10Fix webdav lock refresh returning 0 instead of true when successfulJulian Kalinowski
With commit 58b84caca87c893ac04f0b1399aeadc839a2f075, the NeonSession.LOCK returns "theRetVal" from ne_lock_refresh when successful. But when there is no error, theRetVal will be NE_OK, which is 0, so the method returns false instead of true. This results in lock refresh being stopped after the first refresh, so WebDAV servers will unlock the file after the lock timeouts. Users will see error messages regarding lock timeouts and lost updates are possible. Fix this by adding a return statement when theRetVal == NE_OK. Change-Id: Ie43131fca96e1cfbe932444906b742958a719b26 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96023 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-10tdf#133858 opening spreadsheet with large array formula takes 10 minsNoel Grandin
the spreadsheet has lots of SUM(IF over a whole column. Which results in us allocating a matrix with 1 million rows, which is rather slow to process. So reduce the matrix to the data that is actually there. We can only do this for some opcodes, because other opcodes act differently when referencing empty space, so for now I only perform this optimisation for the opcode in use in this spreadsheet. This takes the load time from 5m to 3s on my machine. Change-Id: I41fe9afcb0fbdf2a928a19c44a0f291a1247a41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96022 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10loplugin:buriedassign in swNoel Grandin
limited this only fixing assignments inside "if" statements, since other things are harder to change Change-Id: If3188a3e3d5fcd94123211c97fee097ece5e2797 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95990 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10Update git submoduleszdposter
* Update dictionaries from branch 'master' to de00c9bd1dd88e8361b606996b0773d30bee772c - upgrade Slovak spellchecking Change-Id: Id3bc65f957187d2c2ba98ba76a1ed4e9fab72c97 Reviewed-on: https://gerrit.libreoffice.org/c/dictionaries/+/95999 Tested-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Andras Timar <andras.timar@collabora.com>
2020-06-10sd signature line: localize signature graphicMiklos Vajna
Now the svg template is free from user-visible strings. Change-Id: Ibdbb73bbd1a1088a66dc25a5669df567b338b375 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96021 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10tdf#132845 discard pending page change if user clicks in documentCaolán McNamara
Change-Id: Icce91c9afac143190dc5c7d823d745dc2434c1a1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96013 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10tdf#132725 sw: SwUndoDelete: don't group if flys are be deletedMichael Stahl
The fly would not be deleted by CanGrouping() but would be deleted later in RedoImpl() via the IsAtStartOfSection() check so just force a new Undo action in this case. (regression from 91b2325808a75174f284c48c8b8afc118fad74e4 and 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I68f9f6b7fd0306bc0853a370b1030463a0024edc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96002 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-10Improve a SAL_WARN messageStephan Bergmann
Change-Id: I31f809e5f6fec109bd0fb58e8290323500d44f13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96001 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-10CppunitTest_sc_uicalc: minimize test documentXisco Fauli
See https://gerrit.libreoffice.org/c/core/+/90265 Change-Id: I014b424d760e0236cbeaa39ea1b03b57809a22bd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96000 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10tdf#42949 Fix IWYU warnings in shell/Gabor Kelemen
Except for MAC/WIN specific parts (i.e. most of it) Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia14fb27c047e0e69f81386212aa25344f1297e05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95663 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-10uitest: Add support for Calc / Format cell / background color selectorShiko
- Add wrapper for the color-win set - Add the factory function in the correct class - Add a demo for cell background color and recent color selector - Extend the ability of ComboBoxUIObject to be able to select with text Change-Id: Ie84ba7fff2f84c3fec7f5adbb5b1cdc6c80729f7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95667 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
2020-06-10fix reseting WeakReference when moving a ref to another ref.Tomaž Vajngerl
In ViewIteratorImpl::Reverse we std::move a reference, to a local variable, however the reference was not reset correctly, which caused a crash. The issue is that a mpWeakConnection in WeakReference always needs to be non-null as shown in reset(reference_type* pReference) method. In the move constructor of WeakReference, we just std::move the reference like: mpWeakConnection = std::move(rWeakRef.mpWeakConnection); This means rWeakRef.mpWeakConnection will be reset to null, which is not what is expected, so what is missing is to instantiate rWeakRef.mpWeakConnection by calling reset(nullptr) or using the added reset() method. This also adds a test for LOKit PDF search as this is the case where the crash has been reproduced. It happens because of a call to: ... std::move(maPosition.mxObject); in the method ViewIteratorImpl::Reverse() Change-Id: I43692554ba4f6231d00091269b7c902ab5cbc11f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95995 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-10Adapt to new Clang trunk -Wuninitialized-const-referenceStephan Bergmann
> error: 'error' diagnostics seen but not expected: > File compilerplugins/clang/test/unusedfields.cxx Line 143: variable 'x' is uninitialized when passed as a const reference argument here and > error: 'error' diagnostics seen but not expected: > File compilerplugins/clang/test/writeonlyvars.cxx Line 93: variable 'm_bar10' is uninitialized when passed as a const reference argument here since <https://github.com/llvm/llvm-project/commit/ 170b6869b563dd3393d99f3e03d389b9058d5f24> " [Clang] Add a new warning to warn when passing uninitialized variables as const reference parameters to a function" Change-Id: I27136e387f7a14fd24a3639187b668d6ed283070 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95994 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-10blacklist old intel driver 0.16.2 for Vulkan (tdf#132681)Luboš Luňák
Change-Id: I3d2e0f6a1f43fe44a8396b53806e2f2c59c46d6c
2020-06-10PPTX import: handle adjust values from both the shape and its placeholderMiklos Vajna
The direct problem is a crash in CustomShapeProperties::pushToPropSet(), the code just hoped that the input file doesn't have more adjust values than the # of adjust values we allocate based on the preset type. Fix the crash, but there is a deeper problem here... The shape can inherit custom shape properties from a placeholder, then later it can have its own custom shape properties. When it comes to adjust values specifically, we used to just append own adjust values to the end of the list. This way we got the double of expected adjust values. And later rendering took the N expected adjust values from the start of the 2N element list, so we used the adjust values of the placeholder, not of the actual shape. Fix this by clearing the custom shape geometry once we know we have our own preset geometry. Change-Id: I09f669bf59c33b552b906733d323eba7af5548e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95993 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10Use xmlFreeDoc since pXhpFile is a xmlDocPtr (l10ntools/treemerge)Julien Nabet
Change-Id: I32fb8824aa91464d2198c76ba9357c82ec87a0ff Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95666 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-10sd signature line: set graphic of signature shapeMiklos Vajna
All placeholders are replaced, but the template is still English-only. Change-Id: Ia361447ff0a69fa0f80db4af07274d1a764a3d64 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95991 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-10detect inconsistent SUMIFS() ranges when range reducing (tdf#132431)Luboš Luňák
03b352b9599514e4e244e1907510713cf1331284 introduced reducing of the SUMIFS range to the cells that actually contain data, but tdf#132431 introduces incorrect ranges that lead to negative indexes, and correctness checking of ranges comes only after the use of these indexes. Change-Id: Ia13db83d222310d470a0a8ecef51dbdd7992d479 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95898 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-06-10tdf#132137 Rename Default Style in Calc.Srijan Bhatia
Change-Id: I0f7c5ffc64b2387fbb63bb5724594480d3135f58 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95484 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-10tdf#91250 Chart DOCX Import: Fix decimal place formatting issueBalazs Varga
Use UNLIMITED_PRECISION in case of GENERAL number format of CATEGORY axis labels in embedded charts, just like Calc does. Change-Id: I30cb50955c67824bd1aa88fb139618ce0f0974fc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95802 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#133632 Chart DOCX Import: fix percentage number formatBalazs Varga
Set the LinkNumberFormatToSource to false only if we have an inner data table and the labels are shown as values. Regression from commit: e0da00d655ecca5986eea3812a8a670c6adbc40f (tdf#132174 Chart DOCX import: fix label number format) Change-Id: I879c5d81709995bfa49c18e0c84aaf6dc3dea41c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95493 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#133065 tdf#133602 DOCX export: fix OLE wrap regressionAttila Bakos
caused by commit 2150fdc7d0f63288ac56c33cb898589512057642 (tdf#131539 DOCX export: fix position of OLE objects). The wrap setting of the anchored OLE object were not preserved. Note: It needs also z-order export for background mode. Co-authored-by: Tibor Nagy Change-Id: I7f8c48019157dda00bcc97a490c5f582eccf1b22 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94220 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10ignore WB_DIALOGCONTROL state of parent if we're a floating windowCaolán McNamara
for tab key cycling When WB_DIALOGCONTROL is set the control has sub controls in it and pressing tab cycles through those widgets, and back to the start. If a WB_DIALOGCONTROL control is inside a WB_DIALOGCONTROL control the toplevel container is the one that processes the tab. But we don't want a floating popup window, like ScCheckListMenuControl, which has its own toplevel floating window, to pass the tab key to its parent ScGridWindow for that to process, we want it to stop at the ScCheckListMenuControl level so it will cycle back to ScCheckListMenuControl's first child after passing the last one, not into some other child of ScGridWindow. ScGridWindow is unusual as a document window to have WB_DIALOGCONTROL set for its own reasons: i.e. "WB_DIALOGCONTROL needed for UNO-Controls" so this problem does't arise in other applications Change-Id: Ib1f02ca4b0bf5bf3b2ed00b5838f8df2e3eb5b7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95957 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-10tdf#132597 sw: fix inconsistent handling of ExcludeFlyAtStartEndMichael Stahl
IsDestroyFrameAnchoredAtChar() checks the position but the only caller, SwUndoInserts::UndoImpl(), really wants to exclude the entire nodes, see IsCreateUndoForNewFly(). (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I763ad3b7d82af03f6910dcf34315f793d090c62e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95952 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-10tdf#130802 SwTextBoxHelper::syncFlyFrameAttr: fix draggingAttila Bakos
Dragging the selected shapes resulted broken text boxes: the text showed outside of the shapes. This is fixed in the case of paragraph, character and page anchoring. Co-authored-by: Tibor Nagy (NISZ) Change-Id: Iaea65ee26bad60c09ada4875636416d4a7c7e80b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95136 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#133641 sw: fix crash double-clicking CH_TXT_ATR_FORMELEMENTMichael Stahl
Only search for separator if there is one. (regression from 1c94842e053a20a739a181d38a35c324df3e62a7) Change-Id: I6697faa7cb83cab48084f9710f8c5018b9e738e2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95905 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-10tdf#133457 DOCX import: fix frame position regressionTibor Nagy
caused by commit f5636817e7677a3081263df9004940a7d5ac54af (tdf#112287 DOCX frame import: fix default vAnchor). Co-authored-by: Attila Bakos (NISZ) Change-Id: I6fe16ff274d6a2fa4a335c7790ecd0f01641a6fb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95035 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#130805 SwTextBoxHelper::create: fix frame position in shapeAttila Bakos
Text frame added by menu option "Add Text Box" of a shape was misplaced if there were more paragraphs after the shape anchor position. Co-authored-by: Tibor Nagy (NISZ) Change-Id: I8a47aff57d3a60f7dbd2a1b75296e2664a1f745f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94822 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-10tdf#133268 Update Calc's conditional format iconsRizal Muttaqin
Change-Id: I7057d813c125bd075ebdd9d6bd5879cd1d8b9980 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95966 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-10Revert "enable backtraces for unit tests on macos"Noel Grandin
This reverts commit 756c027198adc5212d46d72e0628c90698652af5. Reason for revert: It never did work (was a test), and it cannot work because cores are all stored in /cores under mac, which means we cannot tell which cores belongs to which unit tests, or even if it belongs to the current build on jenkins Change-Id: I866173a41077dbb40d61fb81953d7a92f7d0789e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95888 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>