summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-06-13gpg4libre: update gpgme, libassuan and libgpg-errorThorsten Behrens
seen upstream & removed here: - external/gpgmepp/add-gpgme_set_global_flag-wrapper.patch - external/gpgmepp/version.patch - external/libgpg-error/clang-cl.patch - external/libgpg-error/libgpg-error_gawk5.patch Change-Id: Iea2b681fa839ae55cb954c2ad3edf4291b149dbe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/61322 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-06-12Language list: + Aka (CAR); Yaka -> Yaka (Congo), + Yaka (DRC) [yaf-CD]Eike Rathke
Change-Id: I4bf1e1affa046fcc9c7f06c8bbf6a40fc9c26cf9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96167 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com>
2020-06-12crashtesting: assert on reexport of form-submission.odtCaolán McNamara
Change-Id: Ib239171d7aa9d0e5202025149dca1e0cab4bd2b6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96231 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12PopupMenuFloatingWindow is now unusedCaolán McNamara
Change-Id: Ie8fa026becb1899e466fb0e7dbb987290788aaf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12OKButton and CancelButton can be toolkit-only classes nowCaolán McNamara
Change-Id: Icaf90c19217e4f8e5dad0e3542e6d54fc509de54 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95224 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12weld checklistmenuCaolán McNamara
rework the "menu" to be a treeview using hover selection instead of a custom set of widgetry, and drop the newly unused custom a11y code Change-Id: Ie7d9b7875ce00843b3f262882816cebb472bf681 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95223 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12add SPACE keycode to uitesting listCaolán McNamara
Change-Id: I3f330409b994d85ab5605ae3e8a184851902f811 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96205 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12send deselect in hover-selection when in SelectionMode::Single modeCaolán McNamara
Change-Id: I89753455127fd23e60ef9fb489b2c435ff6800b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96166 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12allow hover-select to unselect when mouse outside treeviewCaolán McNamara
Change-Id: Id991d4c3cdbb6a97c0024430bbff9ccbb29a2d52 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96165 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12don't skip first column on toggle column check anymoreCaolán McNamara
Change-Id: Id9083ec432cba556538605692021d8c348322a16 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96164 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-12return directlyDavid Tardon
Change-Id: Ia5ebadfd825b0cbd106893f0b7b25e28b878dfeb
2020-06-12return directlyDavid Tardon
Change-Id: I727a34213fef5adefdc6c1a046d47a7f37cfdcd0
2020-06-12use dynamic_castDavid Tardon
Change-Id: Iac420c2dd37be392ae817e0433de68c983546667
2020-06-12drop misleading commentDavid Tardon
Change-Id: I2ae4b9dbcf3134ec5301d14c32d6904817d350fb
2020-06-12rename variableDavid Tardon
Change-Id: I24e0902998420685656a350cb849a19d8c7a8a35
2020-06-12cast to the right typeDavid Tardon
This makes paragraph formatting in LWP documents work again (for the first time since 3.3). Regression from commit d2a1c2d4cfa51b6ee8a7f38baa258633fae9ec6d "fix what there is to fix" Change-Id: I057aeb996837f7c19815de8a5379861ce3c0e8cd
2020-06-12tdf#76817: DOCX import: fix custom chapter numberingLászló Németh
When one of the parents of the default Heading style has got custom paragraph style instead of the default Heading 1 – Heading 10, apply direct numbering again to avoid bad or missing numbering. Change-Id: I7e94600b5ac2cbf593a95eda6c0d6cd9d731dd75 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96199 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-12tdf#76817: DOCX import: fix chapter numberingLászló Németh
Imported headings got also redundant custom direct numbering, resulting broken automatic chapter numbering: applying standard Heading styles on paragraphs using the associated toolbar menu, Manage Styles dialog window or Ctrl-1–Ctrl-4 shortcut keys, it didn't result continuous numbering. Co-authored-by: Justin Luth <justin_luth@sil.org> Change-Id: Ic1ba5070fa4c387ad527aec05234a4da90fab751 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96198 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2020-06-12tdf#132744: sw: Add unittestXisco Fauli
Change-Id: Ic6c3b5558e33064bc1a7d8ed2b3ea285afab6a87 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96200 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-12Breeze: tdf#133753: base point, Calc left to right imagesRizal Muttaqin
Change-Id: Id3325fbafb4c5e7591f0b28b17aef5b3ba454570 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96190 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-12Sifr: tdf#126122 differentiate Indent and Promote/DemoteRizal Muttaqin
Change-Id: I280c34263888e43f83d59bc6a0167b25cfa244d3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96192 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-12tdf#131912 sw: fix spell check correct deleting flysMichael Stahl
* SwEditShell::ApplyChangedSentence() should not call DeleteAndJoin() + InsertString() but ReplaceRange() * ReplaceRange() and SwUndoReplace need to set a new flag DelContentType::Replace to tell SwUndoSaveContent::DelContentIndex() not to delete flys but instead record the previous anchor positions * SwUndoReplace::UndoImpl() should also not call DeleteAndJoin() + InsertString(); instead call ReplaceRange() for the start node and then DeleteAndJoin() for any regex "\n" that were inserted (regression from 28b77c89dfcafae82cf2a6d85731b643ff9290e5) Change-Id: I485d79510ae233213cb4b208533871934c5e5ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96201 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-12CppunitTest_sw_uiwriter: fix failing unittestXisco Fauli
When I wrote cd47dba9aa4b91bb0edf0744561d29e2eef61cc9, the image got removed when the paragraph was removed. I assumed that was the expected behaviour but it turned out it was actually a bug (tdf#132321) At the same time I pushed cd47dba9aa4b91bb0edf0744561d29e2eef61cc9, Michael S pushed be2f539012d818eaa2d40a9cf199b53d32e1dee4, that is why cd47dba9aa4b91bb0edf0744561d29e2eef61cc9 fails in master now Change-Id: I3d1df064d44388b00a871a9e1786a2febb824bf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96196 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-12android buildfix - xo_component_getFactory is no moreChristian Lohmaier
192721b6c7698d1db2d9d404c6f30b2eb9224796 removed the factory Change-Id: I4397d656ff9e6fa56539d949f7609061309edd7d
2020-06-12tdf#133673 fix webdav lock refresh with Auth:NegotiateJulian Kalinowski
NeonSession::NeonAuth requires an AuthListener to be set in the RequestEnvironment (RE). After a HTTP 401, the Negotiate challenge should be handled. The whole RE however is reset in HandleError, which is called after every request. Usually, this is not a problem because the RE is re-set at the beginning of almost all requests (PUT, GET, PROPFIND, ...). But when refreshing locks this is not the case, as the LockStore does not know any RequestEnvironment. NeonSession::NeonAuth is then called in a post-send hook after a HTTP 401, the AuthListener is null and in consequence Neon's ah_post_send does not return NE_RETRY. So there will be no retry with the correct authorization header. This patch removes the reset of the RequestEnvironment in HandleError, thus keeping it in the session for further use. Change-Id: Ib1a5eff08072f9ef003e760c5f40d9ad26c6cad1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96191 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-12tdf#133898: get a context in default ctr (i18npool/calendarImpl)Julien Nabet
See bt here: https://bugs.documentfoundation.org/attachment.cgi?id=161882 Change-Id: If5a6c5e2b52af9ef97af9522296aaa58352cfa69 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96161 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-12fix ASAN in SharedStringPoolNoel Grandin
regression from commit 3581f1d71ae0d431ba28c0f3b7b263ff6212ce7b optimize SharedStringPool::purge() and fix tests which results in us potentially de-referencing an already de-allocated OUString object in the first loop in purge(). So switch to a different strategy, which only needs one data structure, instead of two. Change-Id: Iaac6beda48459643afdb7b14ce7d39d68a93339c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95226 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-11Sukapura: tdf#133753 Calc left to right images, FontWork dialog imageRizal Muttaqin
Change-Id: Id76fa7c340fe058d9a8db8da16f3740ab06e8c1f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96089 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-11tdf#126122 differentiate between indent and promote iconsRizal Muttaqin
Change-Id: Ib0e0296bba69df2b7079df54fb74bcedfb6b1415 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96160 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-06-11tdf#133459 Fix import of fields with user defined number formatsMaxim Monastirsky
commit 59ace23c367f83491a37e844d16f7d716eff6346 ("tdf#101710 Fix invalid style:data-style-name attribute") had a side effect of exporting user defined number formats under <office:styles> instead of under <office:automatic-styles> (which is valid, and what Calc does since forever). As it turned out, this didn't work well for fields: - For fields inside headers or footers, their number format wasn't imported at all. The reason here is that fields use the XMLTextImportHelper::GetDataStyleKey method to resolve data styles, and that method checks only automatic styles. Actually it resolves also styles from <office:styles>, because SvXMLImport::SetAutoStyles has a special code that merges styles from <office:styles> into automatic styles during content.xml reading. The problem is that headers and footers have their contents stored inside styles.xml, and no merging happens at this stage (unless it's a flat odf file). One way to solve this could be to explicitly check for styles from <office:styles> in XMLTextImportHelper::GetDataStyleKey (e.g. see previous gerrit patchsets, or XMLTableStyleContext::GetNumberFormat) I chose to simply modify the condition in SvXMLImport::SetAutoStyles, so that merging happens anyway. - Fields whose format resolution depends on the merging of SvXMLImport::SetAutoStyles, did import the number format itself, but not its language setting. This can be in one of three ways: (a) Fields in the document and the header, when both use the same format. In this case the format is stored once in styles.xml, so at least the consumer from content.xml depends on merging. (b) Field in the document with a user defined format - a regression of the above commit. Now stored in styles.xml under <office:styles> instead of in content.xml under <office:automatic-styles>. (c) Field in a header with a user defined format - depends on merging as a result of the above fix. The reason here is that the merging isn't done with the original SvXMLNumFormatContext objects, but with a newly created fake ones, which only have the format id correct (with the assumption that those formats already imported, and calling code could just find them by the id). The problem is that the fields code uses XMLTextImportHelper::GetDataStyleKey to get the language setting from style objects, and set the IsFixedLanguage property according to it, while we know that those fake objects don't have the language correctly set. Try to fix that problem by setting the correct language on those fake objects. Change-Id: Ibb362df019921e040708d3bda83bf155535ec7af Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95612 Tested-by: Jenkins Reviewed-by: Maxim Monastirsky <momonasmon@gmail.com>
2020-06-11tdf#132725: sw: Add unittestXisco Fauli
Change-Id: I3d4405dbe77d9f4d9bece8023cc01a7fa0ac463c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96122 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-11Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 7c55241a443bdbfaa46613ddd456edfeb9f5e1b3 - Fix applicaiton color and h1 underline CSS Change-Id: Ia8a18f4a8e1bd12c40a092528e68ec2f12846ac1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96162 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-11allow tabbing between native widgets in floating windowsCaolán McNamara
i.e. in the calc autofilter menu-alike popups Change-Id: I93fc74325b8d39807e5126fc694addd3d0a50d53 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-11tdf#132321 sw: adapt fly at-para deletion to at-char wrt. sectionsMichael Stahl
971205dc2110c1c23ff1db1fc4041e2babf6fa9f changed at-char selection to check that not only the start is at the start of the section or the end is at the end of the section, but that both are true. Let's do this for at-para flys too for consistency, changing what was introduced with 91b2325808a75174f284c48c8b8afc118fad74e4. Change-Id: I1ec93b076d729288ce0809d1cfc24379aa9591ab Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96125 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-11tdf#132744 sw: fix subtle difference when checking end of sectionMichael Stahl
In a few places, such as CopyFlyInFlyImpl() and DelFlyInRange(), the passed start/end positions aren't necessarily from a cursor but can be section start/end nodes instead. (regression from 971205dc2110c1c23ff1db1fc4041e2babf6fa9f) Change-Id: I1fb24f1f9d027aa3685ac5a7459891cb8c2b9a41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96124 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-11loplugin:unnecessaryvirtualNoel Grandin
Change-Id: I40c03b338e00d8a62b8b243d8467b43342c4b093 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96115 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-11restore parent grab mode instead of assuming it should be falseCaolán McNamara
Change-Id: If20de104a058ef3bb5642cb4ecdb7c5c6f931efe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96126 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-11Use comphelper::ScopeGuard to reliably uninitialize COM hereMike Kaganski
Change-Id: I60ccdf51731352b1749109a40c7ad61220a67d84 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96135 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-11increase a radiobutton text area in Windows installer dialogRoman Kuznetsov
Change-Id: I3e2a2dbb7913bc0e35f0eb676f39afba53e1d0d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95970 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-11tdf#133862: sw: Add UItestXisco Fauli
Change-Id: Id08dc6fbbdb59888ecab29e922d84db75f97e779 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96087 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-11Drop configurability of libnumbertext useTor Lillqvist
It was fairly pointless to be able to --disable-libnumbertext. Besides, disabling it broke the ordinal page (etc) numbering feature: "1st", "2nd", "3rd", etc showed up as "Ordinal-number 1", "Ordinal-number 2", "Ordinal-number 3" etc. Change-Id: I645169054a8fdc8dac89cd48b6c369fd61749467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96119 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-11tdf#88205: Adapt uses of css::uno::Sequence to use initializer_list ctorFatih
Change-Id: I4f87f1735fbb61125f4c3bdd0239b28c6df400de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/94471 Tested-by: Jenkins Reviewed-by: Fatih Budak <budakf@itu.edu.tr> Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-06-11loplugin:simplifybool (macOS)Stephan Bergmann
Change-Id: Iae0a2966aa6394e16c2ba3d4155d90bac373472f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96118 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-11loplugin:simplifypointertobool (macOS)Stephan Bergmann
Change-Id: I414eaf0e61be09ccf12d04577c89dbcdb845f85f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96117 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-11Use o3tl::safeCoInitializeEx and counterpart (dbaccess/adodatalinks)Julien Nabet
+ add calls to o3tl::safeCoUninitializeReinit in error case blocks Change-Id: I781f174a43cd1c6b827299657a667fbb34f50143 Change-Id: I9895db229814837f0c0d756bca2c52c54d3d2e9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95690 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-11tdf#132563 - Convert parameters of type SbxEMPTYAndreas Heinisch
During the construction of the parameter list of a method, convert parameters of type SbxEMPTY to their requested type, since missing parameters are handled differently in StepEMPTY, where separate parameter information (SbxMISSING) is added. Change-Id: Ie1e027cfdd652404ec29bd3d05e7daf533468936 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96088 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Jenkins
2020-06-11loplugin:unusedmethodsNoel Grandin
Change-Id: I1050fabdc0c98bbb0cc1d81a41c5b6ac3404cacf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96111 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-11tdf#119114 Add writerperfect / epub screenshotOlivier Hallot
Create writerperfect screenshot Change-Id: I59d33d7e60cbe7326f3ebd8fbe57e1a4545c31c9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95008 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-11Update git submodulesAlain🐍Romedenne
* Update helpcontent2 from branch 'master' to 7c39ebe635e48c0362375c731724d6f8bd15971a - Typo in Basic script Change-Id: I73108c42e82a1e11606e373f1fce0f6a94198f7e Reviewed-on: https://gerrit.libreoffice.org/c/help/+/96094 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-11sw: follow-up: fix other calls of ContentIdxStore::Save(Len())Michael Stahl
Presumably these have the same bug as sw_JoinText(). Change-Id: I77a794be92f36cf2163f819d3941d70e69eb2f27 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/96057 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>