summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-04-29loplugin:stringadd simplify some *StringBuffer operationsNoel Grandin
pulled from a larger patch which I created with a more permissive variant of this plugin Change-Id: I7abf1f3f09e84703b6e0e52fe9587dff691b2187 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114875 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29rename A field in ::Color to TNoel Grandin
because it's actually transparency, not alpha, and having proper naming helps my limited brain keep track of stuff better when debugging And have both the stream operator and the debugging printer print out alpha values, for consistency. Change-Id: I9bc9ffcb71d554603591935e4043a3fb14646ebd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114886 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to 4ee2f0f82f99a865e765309eda367d5fc016674b - sf_basic py2bas bridge It includes Basic functions rework in order to - share content, - correct Basic keywords argument names tdf#141474 - accommodate Python lowercased arguments. Change-Id: If59a82444a8e001b02d085f5e10e0053666f8485 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114008 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-04-29tdf#141967 bail early in Activate if disposingCaolán McNamara
because focus bounces around the dialog as its being torn down widget by widget Change-Id: I2afd094bb13929c25268168175c142ca8e0074e1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114880 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29lok: Disable the "AutoInput" again.Jan Holesovsky
This partially reverts "lok: sc - suppress LOK editengine events for the calc input bar." The feature itself is very problematic in Online: 1) causes unwanted jumps to other cells, 2) causes the selection blinking in the cell when typing, and 3) it is very annoying in the form that in which it is implemented in LibreOffice anyway, compared to other office suites. Let's disable it, and enable again when we address the above issues. This (partially) reverts commit 91319ad56887f932b2da334db560d5d0a79a0280. Change-Id: I2234455c29069f74d13896474f3499035935931b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113047 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Jan Holesovsky <kendy@collabora.com> (cherry picked from commit 65990058f041c3f1d280a69d411eb4ceacf5a721) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/113112 Tested-by: Jenkins
2021-04-29vcl: print dialog: remove broken codeXisco Fauli
This was introduced in 149807eb6100090e178505ba4a264bb38eba1e0c < Resolves tdf#127782 - Print dialog height > trying to fix the problem of the window size not being remembered after reopening the dialog, however, the problem is still reproducible in master with GEN, thus, remove this code Change-Id: I65f327fa692cd3e2b5597d04e9e15abc952fe6d9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114874 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-04-29tdf#141970 Revert "tdf#129606: Round the mean of the two subtractions"Mike Kaganski
This reverts commit d5ebe7c3089ab9f4d3fe0707169fc1ce024cdb70, and brings number of inexact values in testing back to lower numbers (see test document in the bug). Change-Id: I5cfb34b7260fc6e4866585af6a2a50e79696eea2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114861 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-29Update git submodulesRafael Lima
* Update helpcontent2 from branch 'master' to c8cf56ede34cc13a90a930aab505828ee196005c - Create SFDocuments.Base service help page Change-Id: I2bf6bb4e28ed4390c26f9409dddd2aabd1dc878a Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114509 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com>
2021-04-29do not apply line dashing in drawinglayer (tdf#136957)Luboš Luňák
basegfx::utils::applyLineDashing() is not as good as the actual VCL backend dashing, and there are some rounding errors because of all the canvas transformation matrices or whatever, which leads to the drawing problem. So use LineInfo to carry the dashing information. As a part of this change, also make LineInfo use doubles instead of ints. The use of transformation matrices means that the values may be fractional and less than one. Change-Id: Ia5ac7d266cab344b7137052c81fbd96c1ce28003 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114710 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-29Revert "tdf#136957 Use bigger dots for better handling in presentation mode."Luboš Luňák
This change was a workaround and a follow-up commit will handle the problem in a better way. This reverts commit 5d80f679e1891f98ef964efa1166c90d001c5806. Change-Id: I24a98a0828d3b6fbd014d58f37bf4da40d7dfdfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114711 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-29reuse SmEditWindow already present in SmCmdBoxWindow in testsCaolán McNamara
Change-Id: I48f15d584e15269336b289c8204588384f2f6998 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114838 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29can stack-allocate thisNoel Grandin
Change-Id: I53de9926bb3eb662ab6f9065bf1d9190df76c0c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114879 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29use unique_ptr in TextEditOverlayObjectNoel Grandin
Change-Id: I0deb52ee36a16aad91a5f945a6d92c1aa18a58a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114878 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29Update git submodulesAlain Romedenne
* Update helpcontent2 from branch 'master' to a4aacdb16a5c386147c6e7a2c1c1f47843b3a805 - document SF_String isIBAN() 7.2 method Change-Id: Icdf0bdc74ea5deced0f31ee01061e46ff8b805f1 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114713 Tested-by: Jenkins Reviewed-by: Rafael Lima <rafael.palma.lima@gmail.com> Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-04-29tdf#141954 Enable l10n in Formatting bar customizationOlivier Hallot
Change-Id: I3683b947ca9c431febb18fd01ea4a13660e4e07d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114825 Tested-by: Jenkins Tested-by: Gabor Kelemen <kelemen.gabor2@nisz.hu> Reviewed-by: Gabor Kelemen <kelemen.gabor2@nisz.hu>
2021-04-29rename ECKEN -> CORNERNoel Grandin
Change-Id: I24438213431bd2866e2bcefc8a054a03bc975ef4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114841 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29Fix typo SID_TEMPLATE_ADDRESSBOKSOURCE->SID_TEMPLATE_ADDRESSBOOKSOURCEJulien Nabet
Change-Id: I6a23cdd71dc3476c415e710dad4a33c9d0c20202 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114839 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-29tdf#48025 sc: fix broken filter criteria when deleting columnsTünde Tóth
The autofilter criteria weren't remain with the filtered column when we deleted a column left of the filtered column or the filtered column itself. Change-Id: I0eb103ea5569d82eac4d81bce1b31b0c3bbcbf41 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114483 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-29tdf#131162 Rearrange Impress/Draw General settings pageGabor Kelemen
so that checkbox labels fit in languages where they have long translations such as French, German, Hungarian Change-Id: I44107df00fbd969cd3afca016c96e4a1af86842d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114445 Tested-by: Jenkins Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2021-04-29cid#1473812 Untrusted value as argumentCaolán McNamara
Change-Id: I95877c014d16426622e7114384c8e189c140943c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29Let's call it "traceeventrecording" and not "profilezonerecording"Tor Lillqvist
It is not just ProfileZone events any longer that are recorded. Change-Id: I9c2b5817fca8f8a23ebd571cbaccb9ac063ec73b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114848 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-29cid#1477405 Initialize membersTor Lillqvist
Change-Id: I6e546875cf61394e0001000994fccbd8d6626428 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114837 Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-29KJ: tdf#141885 New Paste As Link iconsRizal Muttaqin
Change-Id: I3022897dcdc4ce50c44f483a688787ec47b9b8b9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114827 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-29Add SAL_WARN in case ProfileZones are overlapping and not hierarchicalTor Lillqvist
Change-Id: Id09904db762b6d931ab23cce16e55d5213079516 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114834 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-29tdf#65724 PPTX import: fix internal hyperlink to slideTibor Nagy
Internal hyperlinks were lost, if they refer slides using their names. Change-Id: Ic464300adb1e6e50bd4d61d957306592b7b22b14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114139 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-29ScriptForge - (scriptforge.py) dates passed as UNO datesJean-Pierre Ledure
In replacement of the ISO format, to avoid any misinterpretation of strings containing accidentally a date, from now on, dates are exchanged between Basic and Python as com.sun.star.util.DateTime structures. The year boundaries are [1900 - 9999]. The code managing the Python-Basic protocol has been changed on both sides. The Basic service receives the - CDateFromUnoDateTime() - CDateToUnoDateTime() methods, equivalent with their Basic homonyms. Change-Id: Ib6ded20c24ff71d3349d242f72bd7b88f69a2661 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114815 Tested-by: Jean-Pierre Ledure <jp@ledure.be> Tested-by: Jenkins Reviewed-by: Jean-Pierre Ledure <jp@ledure.be>
2021-04-29allow push/pop multiple levels of freeze/thawCaolán McNamara
so can freely protect a block with freeze/thaw regardless of current freeze/thaw state Change-Id: I1bd60bfc02fe784e36ae371a737f4fdfb15a0888 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114615 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29tdf#111903 tdf#137152 PPTX export: fix placeholdersAttila Bakos (NISZ)
Empty placeholders were exported as white empty custom shapes, losing their visibility and usability. Note: export of properties hasn't been implemented, yet. Change-Id: Ie8bd6a611f5fb43bcaa55f6b2f5b07daf731b163 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114331 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org>
2021-04-29freeze without thawCaolán McNamara
which was already SetUpdateMode(FALSE) without matching SetUpdateMode(TRUE) in: commit d32b3a714fe55892bdead03502c5a9b0e77fa61d Date: Sat Oct 31 00:36:06 2009 +0100 #i106421#: move svx/source/cui to cui and then remove the outside freeze/thaw pair, which may in practice have worked around the unbalanced inner freeze/thaw, from SvxEventConfigPage::SelectHdl_Impl in favour of the inner freeze/thaw so the select can work on a thawed treeview Change-Id: I6dbcfd000f717047354e7cdcfb9b3a502e1fbbe5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114822 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-29Sifr: tdf#141885 New Paste As Link iconsRizal Muttaqin
Change-Id: Ibc53c19f2b57dec500fbb74dd5c097b01664171e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114828 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <rizmut@libreoffice.org>
2021-04-29Make the nested AsyncEvent work more reliablyTor Lillqvist
We must take into consideration that somebody might hold on to a hard reference to such an object. Thus it is not enough to drop the references to it from its parent, that is not necessarily enough to make it destruct. Instead have the parent explicitly cann a function on the children than generates their end events. Also add some documentation. Change-Id: I38180c85072c76af8964c48fa19132b8e1178ee1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114813 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-29Add AsyncEvent::finish() to end a nested AsyncEvent before its parent endsTor Lillqvist
Add unit testing of that, too. Change-Id: Iae5fb6da0b7fcabe8f555d800f065b6f5b4b9982 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114771 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-29Fix syntax error in generated JSONTor Lillqvist
Change-Id: I035a86aa587302985416e65dc6063090f99b49b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114770 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-29Introduce Async trace events and a unit testTor Lillqvist
Async events are ones that emit separate 'b' (begin) and 'e' (end) traces. (Compare to the Complete event that emit a single 'X' trace that contains both the start timstamp and the duration.) There are two kinds of Async events: Freestanding ones that are not related to other events at all, and nested ones that have to be nested between the 'b' and 'e' events of a parent Async event. Still needs some work, at least a way to end a nested AsyncEvent (cause it to emit the 'e' event) before it gets destructed thanks to the parent being destructed. Change-Id: I3721fa701ad32639b1edc1cfa8db7acde5caf9b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114756 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2021-04-29Replace magic numbers in SwFlyFrame::UpdateAttr_()Miklos Vajna
By using the same SwFlyFrameInvFlags constants that SwFlyFrame::SwClientNotify() already does. Change-Id: Ib0775c34cb4b1c6bec4455216ebb2dea3976d007 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114820 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-04-29remove support for BITMASK in vcl backendsNoel Grandin
Rather use a proper alpha channel if we need transparency. This is another small step towards merged alpha in our vcl layer. I suspect the intent in a lot of this code was to save memory. Which have been a thing way back then, but these days our backends mostly end up doing a copy-and-convert to a real alpha channel anyway, so the existing code is actually now a pessimisation. Change-Id: I4a2bcbb2f76b841f05bc00580f364492829c69de Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114808 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2021-04-29tdf#137679 Use Kahan summation for interpr2.cxxdante
The changes in the text files are in the latest decimals. Those should be more accurate now. Change-Id: I3814e1939f71debd5ddde9408a025af7a0a2cac5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114737 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-29tdf#137741 Add ability to navigate by fields from Navigate By controlJim Raykowski
Change-Id: I3cc464a3d5097b4e0438ea22ebf6daad5a2f2a86 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/112144 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2021-04-29tdf#135997: make sure that the two lists are same lengthMike Kaganski
This fixes the strange assumption that when searching the two lists (character names and font names) independently, the two found positions will necessarily correspond to each other. Instead, the positions of the match must be the same, which is implemented now. Also the input from configuration is sanitized. Change-Id: I920de7414387e181e11183b8a22776a72b6be419 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114722 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-29tdf#135997: fix toolbar controlMike Kaganski
This is the same as fc7b4bfeba39a2479c9a2c9c8ef5ced5ab3c0de7, just for the toolbar control (the older one was for special character dialog). The problem was present since 800ac37021e3f8859a52c5eebca261a5d3bc5a11. Change-Id: Ib86aa7336a3078ff28b417de37fbd5bc492c85c6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114719 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-29apparmor: Fix "oopslash" typoRico Tzschichholz
Change-Id: I8b355bceadeebebc9e6fedbf92a35aa44a356e09 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114819 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-04-28Skia understands that linewidth == 0 means hairlineLuboš Luňák
Change-Id: Ic5aea464d6414fc2218179143d16121ef293bdfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114816 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2021-04-28createPixelProcessor2DFromOutputDevice won't return nullCaolán McNamara
nor will createProcessor2DFromOutputDevice Change-Id: I1e0359ef2f94eeaf2da9a89d9e9dfb615587d3da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114814 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-28tdf#116384 only drag hyperlink if user's not currently setting the selectionCaolán McNamara
which is what writer does for normal text. Under gtk it's common on selecting by dragging the mouse over a hyperlink for one or two letters of the hyperlink to get selected before that selection then gets dragged as dnd. Under gen StartDragWidth is 2 by default so the drag kicks in before enough text has been selected for writer to select anything, but under gtk gtk-dnd-drag-threshold is used for StartDragWidth and that is 8 by default making it easy to select one or two characters before the gesture is recognized as a possible drag. it seems sane to do the same as for normal text and not dnd if the user is still using the mouse to set a selection Change-Id: I971d429acaf8a5a656c5ce58f52632979b94e40a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114817 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-28tdf#141904 Blue row number for autofilter only when pTab is not NULL.tushar
Change-Id: Ibdf1efbff34bc58912a5a776d47ccfd784d3111e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114647 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2021-04-28Related: tdf#130326 skip calling Refresh if its already just calledCaolán McNamara
Change-Id: I80d3ae7f10b56dfe53a4ab5101ae771b47848092 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114651 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-04-28Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 914fe5ffbb1a3fde750cf37cbc44008994cf3b42 - Improve link Change-Id: I209a986ce8a6b7ff995724eec0de55393f518050 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/114723 Tested-by: Jenkins Reviewed-by: Alain Romedenne <alain.romedenne@libreoffice.org>
2021-04-28Fix typosAndrea Gelmini
Change-Id: Ide3cd321f756cc685f50b6572de446da56ab5072 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114809 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2021-04-28tdf#137679 Use Kahan summation for interpr1.cxxdante
Includes changes for using kahan sum in ParamIfsResult. Change-Id: Iedfdd867e316d6c99146450cc3f7ac1d855b33e9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/114676 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2021-04-28update creditsChristian Lohmaier
Change-Id: Idd3d14c272c1eebca7207054dccbeae4632c51cc
generated by cgit (git 2.34.1) at 2024-08-01 12:35:49 +0000