summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-10-07Use correct directory for some data files on iOS: share/filter, not filterTor Lillqvist
Change-Id: Idd7d675872b73454d78576ed231fe90644dbe4c5 Reviewed-on: https://gerrit.libreoffice.org/78142 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> Reviewed-on: https://gerrit.libreoffice.org/78999
2019-10-07We need UNO components from libmswordlo.aTor Lillqvist
They are needed for .docx and .rtf export at least. No idea how we have managed without it previously. Change-Id: Iff9224f92520e19d9baa691a9e7cd3c944004eed Reviewed-on: https://gerrit.libreoffice.org/78125 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit 1a0bd0c6914bf93733c7ab3a27741fc1dc0e3f26) Reviewed-on: https://gerrit.libreoffice.org/78996 (cherry picked from commit 98deb6e96f547e8eedff40c992fefe3514021447)
2019-10-07tdf#126964: Set background colours to white in IosSalFrame::UpdateSettings()Tor Lillqvist
Change-Id: I92110a7a501571d7fd707dc33502ff553f02ae5e Reviewed-on: https://gerrit.libreoffice.org/77823 Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit e84c42ee32d1a23729c65b534c4418e2043f706d) Reviewed-on: https://gerrit.libreoffice.org/78994 (cherry picked from commit 1e7a3f82324c3b855c2b3c1f8d4dec73c5162806)
2019-10-07Add the guesslang component (to apps) in case it is essentialTor Lillqvist
(I saw warnings about it missing in the iOS app.) Change-Id: Ib286b107e529e80ec36ffb87059f4f5923867abe Reviewed-on: https://gerrit.libreoffice.org/77399 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> Tested-by: Tor Lillqvist <tml@collabora.com>
2019-10-07Add libexttextcat, needed by the guesslang componentTor Lillqvist
Change-Id: Id13ddee66a70d8cd293940f7eea8597257d169c5 Reviewed-on: https://gerrit.libreoffice.org/77398 Tested-by: Jenkins CollaboraOffice <jenkinscollaboraoffice@gmail.com> Reviewed-by: Tor Lillqvist <tml@collabora.com> (cherry picked from commit aa0b785946ba39bbce419a6b356a7ce07349501c)
2019-10-07DialogClosed doesn't existCaolán McNamara
Change-Id: I3f098cf0b364abb1423b5cecb8cca763f053fa4b Reviewed-on: https://gerrit.libreoffice.org/80336 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07Remove unnecessary(?) memsetStephan Bergmann
...that was there ever since 7b0b5cdfeed656b279bc32cd929630d5fc25878b "initial import", while 2e93541d00f9d4aaa6ad2aeb35ee0c901d216cc0 "Resolves: fdo#69220 crash in doc (ww6)" introduced a WW8PLCFxDesc default ctor that initializes all members (even though it initializes some of them to non-zero, but lets assume that that doesn't matter here). Change-Id: I21a75675d59ded81ccb17397f8c464efdfc3d78f Reviewed-on: https://gerrit.libreoffice.org/80316 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-07cid#1454631 Logically dead codeCaolán McNamara
Change-Id: Ie2850a38db3d2e343d9fc19e245eb97238196110 Reviewed-on: https://gerrit.libreoffice.org/80339 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07openssl 1.0.2tCaolán McNamara
Change-Id: Ideb980a07632e75e2bc7fffa851b8419e727c13b Reviewed-on: https://gerrit.libreoffice.org/80340 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07lok: comments: fix hidden text cursor and sudden document scrollMarco Cecchetti
On Android, SwAnnotationWin::Rescale leads to invoke ImpEditEngine::UpdateViews which hides the text cursor. Moreover it causes sudden document scroll when modifying a commented text. Not clear the root cause, anyway skipping this method fixes the problem, and there should be no side effect, since the client has disabled annotations rendering. Change-Id: I572a9c6b3fe39473a596209413945d777bd79506 Reviewed-on: https://gerrit.libreoffice.org/80244 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2019-10-07tdf#127777 OOXML chart export: fix "CrossBetween" for not imported chartsBalazs Varga
Newly created or ODF charts were still exported incorrectly, because ShiftedCategoryPosition was stored in the view code. Now it is removed to the model using ChartTypeTemplate::adaptScales. See also commit 6027ec08fd5df2e09e34ff61b3777ad2cc8304b3 'tdf#127777 OOXML chart export: fix X axis position setting "CrossBetween"' Change-Id: I7cd69e311833bf9f24f3a600ee7c6312285a7738 Reviewed-on: https://gerrit.libreoffice.org/80160 Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2019-10-07cid#1454632 silence Uncaught exceptionCaolán McNamara
Change-Id: I577cfdfde9076a3c6273c9af1f0b35108a0a0160 Reviewed-on: https://gerrit.libreoffice.org/80338 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07sw: fix Android buildMiklos Vajna
/home/vmiklos/git/libreoffice/master-android/sw/source/core/txtnode/txtedt.cxx:1203:41: error: loop variable 'rImplicitChange' has type 'const std::pair<int, int> &' but is initialized with type 'std::__ndk1::pair<long, long>' resulting in a copy [-Werror,-Wrange-loop-analysis] Just use auto, the copy that was happening here was not intentional. Change-Id: I2f98519f7891bd52ccf560ba0707ad8eef415e06 Reviewed-on: https://gerrit.libreoffice.org/80364 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07[DECL|IMPL]_ABSTDLG_BASE now unusedCaolán McNamara
Change-Id: I111d96da3615f5084f10b4e81dd10bc559c29757 Reviewed-on: https://gerrit.libreoffice.org/80335 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07Fix typoAndrea Gelmini
Change-Id: Ice72d00eb402a291f9a9e262a582493e316864fc Reviewed-on: https://gerrit.libreoffice.org/80358 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-07vcl: fix Android buildMiklos Vajna
UNX is defined for Android. Other code in the same file has guards like: #if !defined(ANDROID) && !defined(IOS) but this is already in an #ifndef IOS block, so just check for ANDROID. Change-Id: I73f92ef5702ec1f1385e2ffa0ea3dbedf7d3b6a2
2019-10-07tdf#127958 crash adding 2 or more files into writer master documentNoel Grandin
clean up the memory management here, the SfxMedium wants to own the passed-in SfxItemSet Change-Id: I1bafa520ca7b833c4d2df7593649c3720c46e2ce Reviewed-on: https://gerrit.libreoffice.org/80332 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07cid#1454634 silence Unchecked return valueCaolán McNamara
Change-Id: Ica5c87b1b217716d2522dd5b97ca73d8748d5f48 Reviewed-on: https://gerrit.libreoffice.org/80330 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07cid#1454626 Uninitialized scalar fieldCaolán McNamara
Change-Id: I953bf3828cf3c5df5335dbc9b1ee2142aff4047b Reviewed-on: https://gerrit.libreoffice.org/80329 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-07enable -Wrange-loop-analysis on clangNoel Grandin
Change-Id: I2095308943c94ad16c110d5fac47715398eb5d39 Reviewed-on: https://gerrit.libreoffice.org/80187 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-07related tdf#99602 writerfilter TODO: subscript - use ParaStyle fontsizeJustin Luth
The existing code handled two situations: 1.) if both position(escapement) and fontsize set via direct properties 2.) if fontsize came from the document default properties. That misses both paragraph style fontsize (very common) and character style fontsize. This patch adds checking for the paragraph style's fontsize. Change-Id: I25312cd4544cfd1be09b21c96a270cb05e4f5b8f Reviewed-on: https://gerrit.libreoffice.org/80179 Reviewed-by: Justin Luth <justin_luth@sil.org> Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-10-07sw: prefix members of SwElemItemMiklos Vajna
See tdf#94879 for motivation. Change-Id: I54473674ff0e8928249059efdfb06f90ab7d2ad1 Reviewed-on: https://gerrit.libreoffice.org/80331 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2019-10-07Fix FIXME in swcache.hxxJulien Nabet
by getting rid of useless IsAvail() function Change-Id: I7c3bbf74a9ef3aaa792936ef2b4887021226dd2a Reviewed-on: https://gerrit.libreoffice.org/80327 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-06fix android buildCaolán McNamara
Change-Id: Ied0e3affd81ea6072d1852dac73ef08f96760271 Reviewed-on: https://gerrit.libreoffice.org/80328 Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-06Related: tdf#127935 set default activate handler to toggle row expansionCaolán McNamara
Change-Id: I2bbfb1445b8d2e748f642cdf4723d41b7f072e2b Reviewed-on: https://gerrit.libreoffice.org/80305 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-06we can use Span for the cache key hereNoel Grandin
Change-Id: I77894e3c5e3d68cb2a12abcc0b09f2c042664ba0 Reviewed-on: https://gerrit.libreoffice.org/80315 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-06convert equals() to operator== in xmlreader::SpanNoel Grandin
Change-Id: Ic6a8eae344c06be87e2bc4bf7f242a2d18ebc8ad Reviewed-on: https://gerrit.libreoffice.org/80312 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-06the PCH in compilerplugins should also depend on the MakefileLuboš Luňák
Otherwise it may not get rebuilt in Jenkins when flags in the Makefile change. Change-Id: I9a06c5bbfd4af2714497c5658d8c523a6c929f68 Reviewed-on: https://gerrit.libreoffice.org/80318 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-06replace throw with abortLuboš Luňák
There is nothing catching the exception anyway, and this fails to compile if compiling the plugin with Clang's CXXFLAGS (which include -fno-exceptions). Change-Id: Iad9316ad9613e4fd66d0e5a16fd71bbb8066cc2b Reviewed-on: https://gerrit.libreoffice.org/80299 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2019-10-06tdf#124456: Make Ant configure.ac check more robustDennis Schridde
Change-Id: Iee16dd23c7881756663e8b6a67e4391186a6e430 See-Also: https://bugs.gentoo.org/682156 Reviewed-on: https://gerrit.libreoffice.org/80233 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-06Replace SystemEnvData pToolkit/pPlatformName strings with enumsStephan Bergmann
(and streamline those data members' names) Change-Id: Ifdd596c7a54dd507045d412c30b463468c2f798b Reviewed-on: https://gerrit.libreoffice.org/80313 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-06improve SfxPoolItem operator== implementationsNoel Grandin
(*) make them all call the superclass operator== (*) make the base class check which and typeid to ensure we are only comparing the safe subclasses together (*) remove a couple of operator== that were not doing anything useful Change-Id: Ia6234aed42df04157a5d6a323dc951916a9cb316 Reviewed-on: https://gerrit.libreoffice.org/80308 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-06SystemEnvData::nSize is no longer read and can be removedStephan Bergmann
...since 5926b22b5dc33490d23d594b129eb8a70b94ffb0 "The SystemEnvData passed into the canvas factories appears to be unused". (And the user-provided SvpSalObject ctor can be removed, at which point the use in SvpSalInstance::CreateObject should be written without "()" to avoid loplugin:subtlezeroinit. Change-Id: I4392fa2d697b29c814d7b577a7b1f8c984c05e70 Reviewed-on: https://gerrit.libreoffice.org/80298 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-06Optimize getNamespaceId (xmlreader)Julien Nabet
Adding a map to cache values allows me 20s -> 13s to start LO Change-Id: If343225def253e29696b96f223cdcb54d0d8525d Reviewed-on: https://gerrit.libreoffice.org/80290 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-10-05Update git submodulesKohei Yoshida
* Update helpcontent2 from branch 'master' - XML Source is no longer an experimental feature. See abb6ee1d2a0f40a4a29c60fb0c71c5644294d658 in the core repository. Change-Id: I486931b9519200a922bd82dfb051c1500ada12d0 Reviewed-on: https://gerrit.libreoffice.org/80309 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com>
2019-10-05ofz#17212 Floating point exceptionCaolán McNamara
deploy a workaround, bug logged against boost as: https://github.com/boostorg/boost/issues/335 Change-Id: I9791133e926dd474ddc5960a33fd90592ce3dcb3 Reviewed-on: https://gerrit.libreoffice.org/80304 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05Let's bring XML Source out of the list of experimental features.Kohei Yoshida
Change-Id: I872a047fe3791253aa52b19d544fb5f26ff22f9d Reviewed-on: https://gerrit.libreoffice.org/80296 Tested-by: Jenkins Reviewed-by: Andras Timar <andras.timar@collabora.com> Reviewed-by: Kohei Yoshida <kohei@libreoffice.org>
2019-10-05only MultiLineEditSyntaxHighlight uses UpdateDataCaolán McNamara
and only the VclMultiLineEdit one which hides the Edit one so remove the unused Edit UpdataData related functions leaving the VclMultiLineEdit set Change-Id: Icd9a633d28907b3e5a3d52771b31574984e64d92 Reviewed-on: https://gerrit.libreoffice.org/80228 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05FileControl can be private inside svtoolsCaolán McNamara
Change-Id: I52edd5166edc9aceeafffed898835fe5bc46880c Reviewed-on: https://gerrit.libreoffice.org/80232 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05Resolves: tdf#127946 pass in argument for dialog parentCaolán McNamara
Change-Id: If1e8339277cedf2577934246a568ecc869355a9e Reviewed-on: https://gerrit.libreoffice.org/80291 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05The SystemEnvData passed into the canvas factories appears to be unusedStephan Bergmann
It was passed in as aArg[1] ever since d551190e8311242eadda4a3e82efff160175cb04 "INTEGRATION: CWS canvas05", but I can't find any current use of that specific argument in canvas/source/ (assuming that all the factories are implemented there), nor can I find any trace in the git history of it ever havig been used. That means that Window::GetSystemDataAny is unused now and can be removed. Change-Id: I16efe548afb5cc3e0606cffea135f7e6674d5def Reviewed-on: https://gerrit.libreoffice.org/80295 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05tdf#127935 Make double click expand/collapse entry in option treeJim Raykowski
Also makes keyboard use to expand/collapse work Change-Id: I5b9d065ebe4a612ebe9658feb9ff71c504de7982 Reviewed-on: https://gerrit.libreoffice.org/80173 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05don't need button.hxx hereCaolán McNamara
Change-Id: I6c3225e28a05633fb68d5a08e2134c1251308717 Reviewed-on: https://gerrit.libreoffice.org/80231 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05move file picker only code to fpickerCaolán McNamara
Change-Id: I47cc2cb7db396a06a2abeffe4a5d40a039f21c58 Reviewed-on: https://gerrit.libreoffice.org/80222 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05The checks should apparenty be maArguments.getLength() >= 5Stephan Bergmann
...given that maArguments[4] is accessed two lines further down, in both cases. Looks like typos in b6a7c4da52acf45a7b69d1e81cf9548f8552752e "INTEGRATION: CWS canvas05". Change-Id: Iee8a111126f2b81c9e586fe8e3c569fbd81dd8f4 Reviewed-on: https://gerrit.libreoffice.org/80289 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05ofz#17448 avoid OOMCaolán McNamara
Change-Id: Ie709eb0ce7c3987081b4b01fd96e7f99e7a48c27 Reviewed-on: https://gerrit.libreoffice.org/80240 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05ofz#16306 avoid timeoutCaolán McNamara
Change-Id: I668b590d7abf466b90a1123ef9c8b9fed1a907ed Reviewed-on: https://gerrit.libreoffice.org/80251 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-10-05simplify SfxAllEnumItemNoel Grandin
It is just a data carrier for an array of values for SID_ATTR_PATHNAME, it does not need associated enum logic. Change-Id: I547cd5580d02eb9c261feeb3545e31910a4ed644 Reviewed-on: https://gerrit.libreoffice.org/80253 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-10-05Drop bogus memsetStephan Bergmann
..that is both bad and unnecessary since 8003f8694ac7c4bc117f7ce692339534d37681f0 "loplugin:useuniqueptr in oneToOneMappingWithFlag" changed oneToOneMappingWithFlag::mpIndex from an array of raw pointers to an array of std::unique_ptr. Change-Id: I247a619ebd7804a8a4faee2797f8c4753f9c4ec6 Reviewed-on: https://gerrit.libreoffice.org/80288 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-10-05Convert some SID in sd to SfxUInt16ItemNoel Grandin
Some, like SID_NAVIGATOR_PAGE were incorrectly using SfxAllEnumItem, and others did not need to use SfxAllEnumItem. Change-Id: I0f61dcdda8bbc021667db3cf78141778f7b85087 Reviewed-on: https://gerrit.libreoffice.org/80252 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
generated by cgit (git 2.34.1) at 2024-07-12 16:25:48 +0000