summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-02-08Use OUStringLiteralStephan Bergmann
Change-Id: I6fd5f86288b303c8e3ce1cd072368df578e5e6a9
2017-02-08Use OUStringLiteralStephan Bergmann
Change-Id: I720f70f81db92d75cdd83aa20a1cbf5a311b092b
2017-02-08Use OUStringLiteralStephan Bergmann
Change-Id: I20685c733b12ef2a7efc894091a6e40d1347ac84
2017-02-08rtl_str_shortenedCompare_WithLength -> OString::startsWithStephan Bergmann
Change-Id: I3eabdeba10d8d1064f00b817b04f03aad8a6b352
2017-02-08Clean up curious by-4/by-2 loop indicesStephan Bergmann
...that had been like that ever since ff09f8d6ef2c613037f039dbcafcad6b76243a48, "MWS_SRX644: migrate branch mws_srx644 -> HEAD" at least, for no apparent reason. Change-Id: I6f8bd44179b232b7b39e493d443a443a60522a5c
2017-02-08Use OUStringLiteralStephan Bergmann
Change-Id: I905fe6553f0ad7f0d2dd1ac1bc771b2d42f35fe2
2017-02-08Use OUStringLiteralStephan Bergmann
Change-Id: I15580bd0395145f9554cd3a155c4825ba95005b3
2017-02-08Drop bogus check for escaped $Stephan Bergmann
This apparently wanted to check whether the $ starting a potential pattern occurrence was escaped by a preceding $. However: * The check itself was broken, erratically looking into sPattern instead of _inout_rFileURL for the $. * The check was bogus, as it would have misinterpreted e.g. "$$$(loggername)". * The resulting string is documented (in officecfg/registry/schema/org/openoffice/Office/Logging.xcs) to be passed through css.util.PathSubstitution. However, neither the PathSubstitution service's documentation (in offapi/com/sun/star/util/PathSubstitution.idl) nor its implementation (SubstitutePathVariables::impl_substituteVariable in framework/source/services/substitutepathvars.cxx) appear to support esacping $ with a preceding $. So it looks more reasonable to remove the check completely here. Change-Id: I445493d444904cd54f166adcbf870a918d1f9982
2017-02-08Remove newly-unnecessary #includes from cppumaker-generated filesStephan Bergmann
...after e57ca02849c3d87142ff5ff9099a212e72b8139c "Remove dynamic exception specifications" dropped uses of UNO exception types from those generated files. This needed first adapting client code that implicitly depended on those #includes in the generated files it included ("Add missing #includes": 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, a34d9150b419ee7471b96599d877ff1091d6b567, fed3783e77e00635e50622e7229b06c9e25451f1). Change-Id: Ia1defda2d586b69092f53feef3644875192cbea4 Reviewed-on: https://gerrit.libreoffice.org/34014 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-08oox, sfx2: can use std::move() hereMiklos Vajna
Change-Id: I0add196f79045e8cb7280b2b7d1d8620e4ec669e Reviewed-on: https://gerrit.libreoffice.org/34013 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins <ci@libreoffice.org>
2017-02-08loplugin:unusedenumconstants read-only constants in xmloffNoel Grandin
Change-Id: I88afb3b4b3aa7d823c46062ead894561a66ac275 Reviewed-on: https://gerrit.libreoffice.org/33995 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08remove unused constants from RES_MSGNoel Grandin
Change-Id: I3eaa1f051440a91c8c5b4996e28dea4e0d3933e5 Reviewed-on: https://gerrit.libreoffice.org/33994 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08remove unused SCHATTR_DIAGRAM_STYLENoel Grandin
and associated SvxChartStyleItem and SvxChartStyle Change-Id: I1564a4583125dd32af71e4eff338dfcefc6517c4 Reviewed-on: https://gerrit.libreoffice.org/33988 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-08loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: I9b9a6af2a7ff2dd64c474ec7f2dd084d4feb76f0
2017-02-08loplugin:useuniqueptr (clang-cl)Stephan Bergmann
Change-Id: Ic774c9ad174ea522da85585cd1d36f89ca6b1d64
2017-02-08Add missing #includesStephan Bergmann
...like 6dce9c6757823b9e89863716ae70ff4e8ddd4e60, for Windows-only code Change-Id: I35f37aae2e6f55ff8ed82afc710a9b59a43b028c
2017-02-07Revert "remove ugly operator* in DynamicErrorInfo"Michael Stahl
This reverts commit b5e3f8a5fa98a249ecd50021c33cf2a5c7a3b4fc. The problem is this: ==24217== Conditional jump or move depends on uninitialised value(s) ==24217== at 0x29A25FCE: SfxObjectShell::SetError(unsigned int, rtl::OUString const&) (objmisc.cxx:220) ==24217== by 0x29A35E6E: SfxObjectShell::ImportFrom(SfxMedium&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) (objstor.cxx:2300) ==24217== by 0x29A3705C: SfxObjectShell::DoLoad(SfxMedium*) (objstor.cxx:765) ==24217== by 0x29A6BC48: SfxBaseModel::load(com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&) (sfxbasemodel.cxx:1802) The commit is bogus because it introduces a DynamicErrorInfo::GetErrorCode(), which overloads ErrorInfo::GetErrorCode(), which is used at least in DynamicErrorInfo_Impl::RegisterEDcr() and used to return a constructor argument of DynamicErrorInfo but now returns pImpl->lErrId, which is what this statement is trying to initialize. Ultimately this causes my clang+ASAN build to fail because the uninitialized error code happens to be detected as a mere Warning: Test name: testMathMalformedXml::Import assertion failed - Expression: !xComponent.is() - loading succeeded: sw/qa/extras/ooxmlimport/data/math-malformed_xml.docx Change-Id: I9141144e0bc356ee54279948f2fce036d1831a86
2017-02-07Revert "create ErrorHandlerFlags scoped enum for error handling flags"Michael Stahl
This reverts commit 05e78bde26d8b8b257ed22a0ce20c5b386a629d1. Depends on the other commit that needs reverting
2017-02-07sfx2: if the exception thrown by filter isn't known...Michael Stahl
... then don't silently ignore it but just abort. Evidently this cannot happen, because if it were a real possibility the author of this exception handler would have at least called SetError here. Change-Id: Iaa5f1f1d4cac388ae08214f6031a8bc279e6fceb
2017-02-07ofz: get the font info early inside leak disabled codeCaolán McNamara
cause we don't have a tear-down to release it Change-Id: I86a72288a1ed03bf5fc5b6a00d9067f3f1063580
2017-02-07Remove duplicate documentation commentStephan Bergmann
Change-Id: I5215f4a27a5fde9e34ba1dce0a6f68f8dfbf0f97
2017-02-07Always use split button for .uno:CharBackColorMaxim Monastirsky
Change-Id: I4dd01ec8692fff77a94d6fa698e438581f6dbf37
2017-02-07tdf#105631 Notebookbar doesn't use wide buttonsMaxim Monastirsky
So we want non-split behavior only in SidebarToolBox, not in the derived NotebookbarToolBox. Change-Id: I064bbe59b97da301a13889ad78a31227cfd693ee
2017-02-07SDK, just stop tampering with my term's titleStephan Bergmann
Change-Id: If053466ed5f2e74ea4b73719f6e07789c055998d
2017-02-07Blind fix for buildStephan Bergmann
Change-Id: I0e992eb2e10c71de1e04b9283a012c8e8f229612
2017-02-07Clean up C-style interface nonsenseStephan Bergmann
Change-Id: Ie9a1e106f5270fd307d211fa334449c698acf25d Reviewed-on: https://gerrit.libreoffice.org/34010 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2017-02-07remove CREATE_OSTRING macroJochen Nitschke
Change-Id: I7d5e1570918adc3b0cf2063d9735414233011a81 Reviewed-on: https://gerrit.libreoffice.org/34009 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
2017-02-07tdf#104870 - keep reference on the TitleBar while setting title.Michael Meeks
Unlikely to fix the issue, but may help. Change-Id: I3c319f550e86f2ab731b072d86d258dca12d34fa Reviewed-on: https://gerrit.libreoffice.org/33998 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2017-02-07bubble the original gtk surface type through renderingCaolán McNamara
this may make scrolling a tad faster Change-Id: I0c2cc9df85932e25dbfed88727d3b83d299671c7
2017-02-07tdf#79236: Add uitestXisco Fauli
Change-Id: I916438d688ec24c67b581bf2e025215dda228e97 Reviewed-on: https://gerrit.libreoffice.org/34000 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2017-02-07Remove MINGW_CLIB_DIR left-overStephan Bergmann
...after b28f25aa9eeed71bd3f399a9c8fc4f1497b92e82 "MINGW_CLIB_DIR is unused" Change-Id: I8395d492120455378ec001e37428a645aa879440
2017-02-07Remove HAVE_NON_CONST_NPP_GETMIMEDESCRIPTION left-overStephan Bergmann
...after 4c18af27bf95b332ee2006cfc0bbf469fb1a84d4 "tdf#96398 kill remaining NPAPI support for plugins _inside_ LO" Change-Id: Ide62fa142108562c191ca95ab307638178476fea
2017-02-07Remove GNOMEVFS left-oversStephan Bergmann
...afer b40b6010077f875565ce90cd995222451e37321c "ditch gnome-vfs2 support" Change-Id: I0a57da5f2d810e78837035c86ee1f03ae33aacd8
2017-02-07flatten ShellResource resourceCaolán McNamara
Change-Id: Ib071a21778289f4dc68273cb305d38bf260a31a7
2017-02-07Remove DBUSMENUGTK left-oversStephan Bergmann
...after 4e7f9650e2a32b648cbd50ab113955920f960354 "remove ancient lo-menubar implementation now that we have the shiny new one" Change-Id: I49e7a5489279aaf3469d14c4e9d75245203c5937
2017-02-07convert resources containing strings to stringarray resourcesCaolán McNamara
Change-Id: I61e815a9545f55a3b886322e7d2c0d50040584bd
2017-02-07Related: tdf#105371 we can do this with a sizegroupCaolán McNamara
Change-Id: Ie37a3d960ec244033f2b05e7a902c7a23ba9b94d
2017-02-07Replace macro with functionStephan Bergmann
Change-Id: Icb4488ea38b99a329a071063292db4001799ecc8
2017-02-07configmgr: add SAL_CONFIG_WINREG_RETAIN_TMP variable.Michael Meeks
Windows registry dumping behaves very strangely, and in hard to debug ways - this should help in-the-field debugging of this in future. Change-Id: Ia35d58a8be36d1b683db39ae7d2128a3ccfd10a5 Reviewed-on: https://gerrit.libreoffice.org/33992 Reviewed-by: Michael Meeks <michael.meeks@collabora.com> Tested-by: Michael Meeks <michael.meeks@collabora.com>
2017-02-07Bring back initui.hrcStephan Bergmann
...presumably missing from 19ea3db6d33e8e1de57104e42796454757facd45 "revert unready stuff" Change-Id: I74ab88dc1bd1bdd92d8bebc3120d036f032f5049
2017-02-07Made lcl_DrawDashedRect() more readable and faster a bitgkorepanov
Change-Id: I58e06f090248e034541e276f11cecef8b26e874a Reviewed-on: https://gerrit.libreoffice.org/33394 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-07revert unready stuffCaolán McNamara
Change-Id: I2b112a17a2bc70bfe4d5a6af7964a3c1d7eacf9b
2017-02-07interim convert to ResArrayCaolán McNamara
Change-Id: I74c8ad1242611321401f6282dfbce3205977394a
2017-02-07flatten ShellResource resourceCaolán McNamara
Change-Id: I6094f86eb7da89ba5e21be909417b23f9f375351
2017-02-07convert resources containing strings to stringarray resourcesCaolán McNamara
Change-Id: I8a306b417dcf533a148e34a6314e37589dcdda12
2017-02-07bubble the original gtk surface type through renderingCaolán McNamara
this may make scrolling a tad faster Change-Id: I5f11f9b3196c3d42c82ac03bc332ef84189f3737
2017-02-07there is no cnt (chaos) resource file anymoreCaolán McNamara
Change-Id: I97f0606c6003ca12c651841ec26145728fc5c808
2017-02-07replace calculation to get RID_SVXERRCODE with RID_SVXERRCODECaolán McNamara
presumably a hackaround from old deliver-headers era Change-Id: Idbaeec7bb8523776045ce5355235a4397b2195e4
2017-02-07Fix check_flies.py to be more pythonicEdmund Wong
Change-Id: Id5f44aaa97539b7ec97b81b39da30bd8d170c011 Reviewed-on: https://gerrit.libreoffice.org/33139 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Björn Michaelsen <bjoern.michaelsen@canonical.com>
2017-02-07tdf#105286 use alternative font when glyph is not vertical.Mark Hung
In vertical layout, a vertical font is selected. For windows, that means prepending a '@' to the font name. Switch back to the one without '@' in order to display characters that needs to be rotated 90 degrees in vertical layout correctly. Change-Id: I4e0361929f898eddc671b739b36a12dd26d68018 Reviewed-on: https://gerrit.libreoffice.org/33064 Tested-by: Jenkins <ci@libreoffice.org> Reviewed-by: Khaled Hosny <khaledhosny@eglug.org>
generated by cgit (git 2.34.1) at 2024-07-13 07:07:14 +0000