Age | Commit message (Collapse) | Author |
|
Similar to bug 105625, the cursor should be considered outside
of a fieldmark when it is at the start. A delete at the start would
normally delete the entire form field, but in this case the section
is supposed to be protected, so deleting should be forbidden.
This atStart situation is already looked for when the document is
not protected. However, when the section is already protected, then
a different code path is followed, and there the start position
was ignored and thus became an editable part of the page,
allowing the user to easily delete the field by mistake.
LO6.2's commit 63ec2e8d07dff652a68c9dc96859c4c61f26b9df
accurately identfied that this is in a protected section,
and so exposed this missing scenario.
Related idea: Also added a unit test to ensure that Protect_Form
keeps protecting the formfields as well.
A test document in the bug report, containing a combobox and checkbox,
confirms that this fix is good for all three types of fieldmarks.
Change-Id: Ida08163f3376e55c620d6670da160832e79cd252
Reviewed-on: https://gerrit.libreoffice.org/71927
Tested-by: Jenkins
Reviewed-by: Justin Luth <justin_luth@sil.org>
|
|
Synchronize sub menu Tools > Macros by adding "Edit Macros" across the
different applications menus.
Change-Id: I16185034955d889afe8a508a3522bb0a63f29545
Reviewed-on: https://gerrit.libreoffice.org/71827
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: andreas_kainz <kainz.a@gmail.com>
|
|
Found with bin/find-unneeded-includes
Only removal proposals are dealt with here.
Change-Id: I89c77656ea4021cb16bd122cb1dd1cd803390c3d
Reviewed-on: https://gerrit.libreoffice.org/71765
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: Ibe4ef82cf719afd008f1be23ed4a0e953c61d73f
Reviewed-on: https://gerrit.libreoffice.org/72010
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I2b5827c3f6fd7630655d4658844792462f80767e
Reviewed-on: https://gerrit.libreoffice.org/72016
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Use range-based loops
Change-Id: I4d3be75bb83c74267b9dec6f1dcdc105c292be9d
Reviewed-on: https://gerrit.libreoffice.org/72011
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: I05c627f590e7794c1ba11b66021dc30aa3285eb0
Reviewed-on: https://gerrit.libreoffice.org/71941
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
Change-Id: If7f51a657606da8aea4bcf01f13468c6ac2086a8
Reviewed-on: https://gerrit.libreoffice.org/71901
Tested-by: Jenkins
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
...in preparation for another change using a top-level namespace ucb
Change-Id: I3a92d64806bc570bdfd4fe06e672cb6ce2049e7e
Reviewed-on: https://gerrit.libreoffice.org/71987
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I0c594c232a3004c83a33f0948593850dd924caad
Reviewed-on: https://gerrit.libreoffice.org/72020
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
This is intended to replace the ImplPixelFormat in macOS and
OpenGL backends, which are duplicated. It'll also come in
handy for other situations in the future.
Also ImplPixelFormat4 (4-bit Palette) in the macOS backend
doesn't work and never has worked correctly (bug at writing).
This fact was discovered while testing the ScanlineTranformer,
which was based on the ImplPixelFormat* code.
Change-Id: I96a172bd61c2cc116ab3e8b9f47f23f945243e96
Reviewed-on: https://gerrit.libreoffice.org/71992
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I4b4fc85024d64f94197bd0fd25ed8ba0ada004ba
Signed-off-by: Adrien Ollier <adr.ollier@hotmail.fr>
Reviewed-on: https://gerrit.libreoffice.org/71807
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
Change-Id: I88a32792c19a8d16c400dd2a189c4941149ff941
Reviewed-on: https://gerrit.libreoffice.org/72019
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
Change-Id: I77133378411c573dd1075d40c7e113b305b3dbba
Reviewed-on: https://gerrit.libreoffice.org/72017
Tested-by: Jenkins
Reviewed-by: Jens Carl <j.carl43@gmx.de>
|
|
...after 7764439f85f23efb4510b41e795abd1e4c9089e9 "WidgetDefinition: add
'action' state for the PushButton" introduced code that downcasts that
suspicious ImplControlValue to a PushButtonValue
Change-Id: I3ed24cc4a862d53ad5b6e95b4707bab7947ce7ba
Reviewed-on: https://gerrit.libreoffice.org/71998
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
Tested-by: Jenkins
|
|
Change-Id: Idfefe7598df0b2e382be84aa5bfc8b60201768a7
Reviewed-on: https://gerrit.libreoffice.org/71991
Tested-by: Jenkins
Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
|
|
e.g fdo58094-1.mml
since...
commit 13894996601daf10d133f4a71eb0b26794d782bc
Date: Sat May 4 21:46:31 2019 +0200
handle empty Rectangle better in starmath
Change-Id: I01d11352b8bc9f6dcf6d6565fa41b84d549f620f
Reviewed-on: https://gerrit.libreoffice.org/71963
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: I66db4b9f800eb2e3e0b81d4e8f9c2b7f742d23cf
Reviewed-on: https://gerrit.libreoffice.org/71953
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Ia29abf667b1d010692e89b3b8c23614a4b345669
Reviewed-on: https://gerrit.libreoffice.org/71962
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
As seen in sw/source/core/inc/layact.hxx
Change-Id: Icc4281cd57b0cd8310a1044f6106691a5d1cd3c4
Reviewed-on: https://gerrit.libreoffice.org/71884
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Change-Id: I1c10010eb7fd33a03f477af0cba03ae74859b174
Reviewed-on: https://gerrit.libreoffice.org/71959
Tested-by: Jenkins
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Rearrange objects in code to correspond to actual layout & conform to
rest of file.
Change-Id: I9c86000f335c2d5305286b42b9cd434e922f07c6
Reviewed-on: https://gerrit.libreoffice.org/70340
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
+ rearrange code to correspond to actual layout in dialog
Change-Id: I4a83f230e1d523a5d03121338de0466e9a61852e
Reviewed-on: https://gerrit.libreoffice.org/70608
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Remove warning suppressions.
Create svx.false for false warnings.
Rearrange objects in code to correspond to their actual
position on the screen.
Add new label for part entry box.
Change-Id: I2a7293024427e65cca2ea754fac4fe1bc7d6d0bd
Reviewed-on: https://gerrit.libreoffice.org/70338
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: I059393357c3b0d91e30c16df066fb6dd8ba28ab9
|
|
Change-Id: Ic2093aaea6e71559ba49e248f9afd5d86bcb0b67
Reviewed-on: https://gerrit.libreoffice.org/71949
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ieaa50a2eba17145180ddd5d2bfc77add4801c43a
Reviewed-on: https://gerrit.libreoffice.org/71929
Tested-by: Jenkins
Reviewed-by: Muhammet Kara <muhammet.kara@collabora.com>
|
|
__cxa_demangle uses malloc/free for memory management, see
<http://itanium-cxx-abi.github.io/cxx-abi/abi.html#demangler>
Change-Id: I57f8465d1c70fbef4537068fd3aefc52295e1c63
Reviewed-on: https://gerrit.libreoffice.org/71942
Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: I25327cfcafc9e1f2e88b388677853c638dd9b0e6
Reviewed-on: https://gerrit.libreoffice.org/71946
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Improve the conversion method to do something reasonable with
empty Rectangle.
Use the conversion method in more places.
Change-Id: I48c13f3d6dae71f39f03f7939101e545c8125503
Reviewed-on: https://gerrit.libreoffice.org/71853
Tested-by: Jenkins
Reviewed-by: Regina Henschel <rb.henschel@t-online.de>
Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
|
|
Change-Id: I6213bd2b10746416a5e0bc9029c49b0b09a8b0a4
Reviewed-on: https://gerrit.libreoffice.org/71947
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
Change-Id: Ia7e47e8398a0022a281de2b8866e779d471909b0
Reviewed-on: https://gerrit.libreoffice.org/71951
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Noel Grandin <noel.grandin@collabora.co.uk>
|
|
by disabling their in-row splitting using loop control.
Change-Id: Ibd93213fa0ce45458ce188de20da982e4abc17c5
Reviewed-on: https://gerrit.libreoffice.org/71920
Tested-by: Jenkins
Reviewed-by: László Németh <nemeth@numbertext.org>
|
|
Change-Id: I344300807b0bfce0b779b2d64337dad96eee86c9
Reviewed-on: https://gerrit.libreoffice.org/71945
Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com>
Tested-by: Jenkins
|
|
Change-Id: Iea5bd392f82e26e3c60ca332ae4bea942888e236
Reviewed-on: https://gerrit.libreoffice.org/71928
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I7abab185624c5a6a6e28334dd680fafece7abfab
Reviewed-on: https://gerrit.libreoffice.org/71940
Tested-by: Jenkins
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Iba7c216f28700e8899d76942a4a0a8b77ed3c549
Reviewed-on: https://gerrit.libreoffice.org/71930
Tested-by: Jenkins
Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
|
|
Replace OSL_VERIFY with if-statement and SAL_WARN.
Change-Id: I356a875e1364f3d16f562f3cfa0b41e0939e43d5
Reviewed-on: https://gerrit.libreoffice.org/71923
Tested-by: Jenkins
Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
|
|
Change-Id: Ieec62c2793419ee82ecd6f95497e710900ad9be1
Reviewed-on: https://gerrit.libreoffice.org/71886
Tested-by: Jenkins
Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
|
|
So wall clock time formats less likely display a one-off value,
duration formats are too rarely used if the expected duration is
less than 24 hours.
Change-Id: I9b0872420699b17e3ed3f20993f8cfe02761f862
Reviewed-on: https://gerrit.libreoffice.org/71909
Tested-by: Jenkins
Reviewed-by: Eike Rathke <erack@redhat.com>
|
|
The RANK() results depended on the floating point representation
of time differences (durations), which for visually equal MM:SS
display values don't have to be equal if similar durations result
from different start and end times. Change that to a well defined
duration in seconds.
Change-Id: Ib69a6b43f48abd2d4fe605021acfd2800e75b5e1
Reviewed-on: https://gerrit.libreoffice.org/71926
Reviewed-by: Eike Rathke <erack@redhat.com>
Tested-by: Jenkins
|
|
Also remove special-casing for 64-bit libraries introduced in commit
92dfaaa0bfd08de58ccf9387c805ade24c04b41b, which is obsolete with 6.01.
Change-Id: Ia5befa99788321292b1a4343c2dbb5d8fbba08c9
Reviewed-on: https://gerrit.libreoffice.org/71915
Tested-by: Jenkins
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
Change-Id: Ib07c606083b833389fcb82aac57ca8535d6e861f
Reviewed-on: https://gerrit.libreoffice.org/71916
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
|
|
Change-Id: I43ba5d6591be6ad782bc72bac1938ae9763c7103
Reviewed-on: https://gerrit.libreoffice.org/71900
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: Idefeaeb8dbe53f6709d2f9655c2bbcd1486632cc
Reviewed-on: https://gerrit.libreoffice.org/71921
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
Tested-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8d705a0d31f36242f8a93591a2c0fc69ee6847a0
Reviewed-on: https://gerrit.libreoffice.org/71911
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
|
|
Change-Id: I8b080ad44f10e52fa5a726bd7cdf7dd8ff7e2dd4
Reviewed-on: https://gerrit.libreoffice.org/71913
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
|
|
This includes some not-so-nice lifetime handling of the button
"clicked" connection handling. I decided to keep the code in
one place, simply always forcing a disconnect on show, instead
of a more "optimized" code version in SetFrame.
First we try to get the icon from the system theme, but use LO's
own icon theme as a fallback.
Change-Id: Ic0459623ec907b9a54bef4670bf65cf587cd47ea
Reviewed-on: https://gerrit.libreoffice.org/71784
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
|
|
Change-Id: I1f145558fe9d86682e03481fb2800386d04d2b1d
Reviewed-on: https://gerrit.libreoffice.org/71904
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|
|
Change-Id: Id3b2e769afb32a6a5214ae6feae8d7251d676af5
Reviewed-on: https://gerrit.libreoffice.org/71906
Tested-by: Jenkins <ci@libreoffice.org>
Reviewed-by: Caolán McNamara <caolanm@redhat.com>
Tested-by: Caolán McNamara <caolanm@redhat.com>
|