summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2021-12-03tdf#137466: docx: support w:placeholder & w15:color in w:sdtPrVasily Melenchuk
Content controls in Word can contain some other elements which are not supported by Writer. Put them into grabbag and write back to DOCX on save to avoid losing quite sensitive data. Test testSimpleSdts is modified: testcase is actully containing 4 sdt elements with ids in input and output. Change-Id: I1f9addd03ed828bf375ccac5188a004f011e8a0d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125271 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> Reviewed-by: Vasily Melenchuk <vasily.melenchuk@cib.de> (cherry picked from commit 7db38a496a5e458ec12888ddbf63c603706ae3fc) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126000 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-03tdf#145964 related: also drop special-casing in TransferableHelper::SetStringMike Kaganski
Follow-up to commit 5fb9f4ffa9284c7248e2e82210506babaad4044d Change-Id: I46d5ea404f77ac5ff67b6ee6a42afee13274a481 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126174 Tested-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126181 Tested-by: Jenkins
2021-12-03tdf#145964: Windows format name is FileNameW for Unicode stringsMike Kaganski
Otherwise SIMPLE_FILE clipboard format arrives encoded in ACP, and fails for any characters not representable in ACP. Change-Id: Ice8cfd98955e3ef49682aa21b41a313786b291f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126131 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 5fb9f4ffa9284c7248e2e82210506babaad4044d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126133 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-03tdf#140912 Better handling of the picture placeholders.gulsahkose
To see icon and placeholder text at the center of picture placeholder shape, we set the TextContourFrame and GraphicCrop properties. Change-Id: I49e3d08c9020e593232c60c97af3f45fb620075e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126165 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com> (cherry picked from commit 7b3be7f6f3d800e2ad86f5a043e6e9b21ed4409f) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126141
2021-12-02undo "allow vcl gen menus to have non-square images"Caolán McNamara
This reverts commit 06f36cc7ca8fc056dd8cf4d8cdbe682f9a003cef ended up not using this so don't need the extra complexity Change-Id: I64a2d6f620cc864a75523be6612c5cf2086f7a00 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126211 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-02Related: tdf#145901 use x11 popover replacement for all non-menubutton casesCaolán McNamara
replacement from inside real popover under x11 as in autofilter case doesn't work. Change-Id: Ie4ba95645a8094732b9bad9829426e77375d63ad Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126208 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-02Related: tdf#144410 submenu indicator misplaced under x11 gtkCaolán McNamara
so drop the GtkTreeViewColumn expand and go back to setting the size via the size-allocate, but for wayland launch it in a callback because setting the column widths during the size-allocate callback doesn't work as hoped for and the indicator is misplaced. Change-Id: I58a7a11cb1a1c065cee364f932cebddfb9ea453c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126207 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-02use smaller squares for smaller checker patternsCaolán McNamara
Change-Id: Ib46b0906a0adf52f3806b269976ad15d280a28e7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126146 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-02don't need to have a specific mbCanHaveSubMenu mode anymoreCaolán McNamara
since the gap in the vcl treeview separator problem is fixed Change-Id: I105167127588c11895d81dd2aea3c9e119170069 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125952 Tested-by: Caolán McNamara <caolanm@redhat.com> Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit bc4e3a1ef4df033a7a5e3526de4edf51dacdb839) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126206 Tested-by: Jenkins
2021-12-02nss: upgrade to release 3.73Michael Stahl
Fixes: CVE-2021-43527 Memory corruption via DER-encoded DSA and RSA-PSS signatures Change-Id: I5c3f169c57fc2763029b07ad7e325b2f53b7e28f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126218 Tested-by: Thorsten Behrens <thorsten.behrens@allotropia.de> Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit c8e21d246bcb4289cb25c82be440cd07b7418436) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126233 Tested-by: Jenkins
2021-12-02Call CountNonFilteredRows() only if necessary, tdf#124103 follow-upEike Rathke
i.e. only for different row selections or the first time. Also const as const can and reference rRange vs aRange naming. Change-Id: Iee926eeefa7ae5db1e6b8cff768a0c7c106c3476 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126189 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins (cherry picked from commit 31d038966de5db78bd31dfd1008ee02c050d510a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126228
2021-12-02Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'libreoffice-7-3' to c0c813639a014d4ac3a9a3f3cb113bd1dab71a90 - tdf#117868 Help contents for sep= in CSV files Change-Id: I6ac919fd95b9c30be3f1f2aa7bc18efd40b6d2d7 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126188 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 4973d1a792d20d77e7401c1d2b1fe9821695297d) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126231
2021-12-02Update git submodulesAdolfo Jayme Barrientos
* Update helpcontent2 from branch 'libreoffice-7-3' to aab06144bd2b80cffc77df8ebb8b58ffc89468cb - Related: tdf#145728 Update help strings for QR and Barcode dialog Also, I removed the Wikipedia link. Besides having grammatical problems, I don’t think these links are a fit for our documentation. We would do a bigger service for our readers having all the needed information right into our pages, where we can control it better. Change-Id: Iaf96727ae5127ad622a2887aeea4c81b262d4ede (cherry picked from commit fe3d13ce1750ba2cd5bc64ff76d20a11e93e446e) Reviewed-on: https://gerrit.libreoffice.org/c/help/+/126222 Tested-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-12-02tdf#145819 Revert logic of the image-with-rotation dialog: sc & sdGabor Kelemen
Change-Id: I906e83ada98fd7a583872a2eaa76d7fd04a5401b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126110 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> (cherry picked from commit 970cbb120a62e952e80348b8e94478600241273a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126143
2021-12-01tdf#124103 count non-sequentially selected rows or columns in statusbarscito
Count non-sequential cells if either rows or columns remain the same and are sequential. Examples: A1, A2, A4 -> 3 rows, 1 column A1, A2, A4, B4 -> do not show any count (as before) A1, B1, D1 -> 1 row, 3 columns A1, B1, D1, D2 -> do not show any count (as before) Change-Id: Ib8f20d560e4dc4a2b673c6e0962397563d803519 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125979 Tested-by: Jenkins Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 6382f51d2a4d9a3ec8eef2471467ab0dbf7a8294) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126142
2021-12-01tdf#144244: fix crash when FILESAVE a calc file after delete some columnsJulien Nabet
see bt here: https://bugs.documentfoundation.org/attachment.cgi?id=176507 Regression from 3238606c8470f3eaeada3fc601e186ec5cfac925 tdf138138 Apply shape shift also to NoRotatedAnchor The 'normal' anchor (as on screen) is connected to the snap rectangle, the NoRotatedAnchor is connected to the logic rectangle. They differ, if the shape is transformed, e.g. rotated. Error was, that values of the 'normal' anchor were applied to NoRotatedAnchor instead of calculating the shift of NoRotatedAnchor independently. The error becomes only visible on save, because there the NoRotatedAnchor is used. Effected shape types are legacy shapes, text boxes and transformable OLEs. I have not tested, whether this fix would work for LO 7.0 too. Let's apply the same controls as we do with ScDrawObjData retrieved with GetObjDataTab Change-Id: I73cb3dd3c47a7ec55667e498d4a62842ce63d861 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125852 Tested-by: Jenkins Tested-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-by: Eike Rathke <erack@redhat.com> (cherry picked from commit 1d45f84bd08c8d196fcf3c9baaf2cad010884e5c) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126139 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-12-01CURLE_QUIC_CONNECT_ERROR requires curl >= 7.69.0Jan-Marek Glogowski
This new error code replaced several CURLE_FAILED_INIT in curl commit cbb5429001084df4e71ebd95dbf748c3c302c9f7 ("ngtcp2: Add an error code for QUIC connection errors"). Instead of escalating the curl version further, just mask it with CURL_AT_LEAST_VERSION; this way my Ubuntu 20.04 schroot can still use the system CURL for the build... Change-Id: I24afd32737e2ab74d9e4ce1722012d522ae010bf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126158 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de> (cherry picked from commit 70a479abe267c0bd4c0c0fd1e945d8e6e4856af2) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126132 Reviewed-by: Michael Stahl <michael.stahl@allotropia.de>
2021-12-01tdf#145952 don't crash with LO_COLLECT_UIINFO set in autofilterCaolán McNamara
Change-Id: I27c474c522554c825c0296cdf711d481d22fd024 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126129 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-01make autofilter a row shorter, now it has extra menu itemsCaolán McNamara
for the filter by color options, which have pushed its height up taller than it used to be. I think it would be better to make more submenus here to shrink its height down further, but that's not attempted here. Change-Id: Idb484bd77d2cca6e175d997955b0967720d94ec6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126106 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-12-01gtk[3|4] calculate row height closer to what gtk appears to doCaolán McNamara
we're getting slightly more lines than requested visible in f.e. the calc autofilter drop down Change-Id: I9ca16eb5ec6848499997a6fceec1d0ead693efce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126104 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-30gtk[3|4] allow anything that would enable positioning onscreenCaolán McNamara
Change-Id: I68a96c4ae860c705108f4aaaf23e4bd05badf849 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126127 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-30center vertically so if there is only one entry it doesn't look oddCaolán McNamara
Change-Id: I97ae6145d0139bd33f33d298803c7e787fd717a7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126061 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> (cherry picked from commit f08ef920b744b5eb41ac96ab3dc58a23c27e3ab9) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126087
2021-11-30tdf#145901 constrain gtk autofilter within calc windowCaolán McNamara
so its all visible as much as possible under wayland Change-Id: Iad82f9ab63d57a93361e773a159c2716e13d59f1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126105 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-30SwNavigator: keep entries selected on right-clickJim Raykowski
when click position is on a selected entry unless root is in the selections then select root entry only Fixes regression from commit c4016f246fde835c0cfdabbb7cc35bc6dd48fb24 Applies to root content navigation view for content types where multi- selection is possible. Change-Id: I3eb3b3f1eaaee39543700b8b7e3087d2795b3cdb Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126017 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com> (cherry picked from commit cb14adfd8cd593da4c429fcefba48531c10e47ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126100 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-30tdf#145873 Fix FILEOPEN: EMF file not displayed #2Hossein
The previous patch 149bd802623d6d83ec9aa04514b938494f7f01f6 only partially fixed the problem, and the size of the graphical objects was wrongly calculated. This patch fixes this problem. The fix can be tested with: make CPPUNIT_TEST_NAME="testTdf145873" -sr \ CppunitTest_vcl_pdfexport This test exports the PPTX to PDF and checks the size of the objects. The previous test for this issue which exported to SVG is removed, as it could not test the current situation. Change-Id: I97bed99811eaf8236ded84ffe0c1a7d3d1b5bad5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125924 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 20d5e320801606856c1d05c4f34d9fa82371aac8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126102 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-30ofz#41510 make sure BackgroundColoredObjects doesn't contain dead objectsCaolán McNamara
Change-Id: I42a96a998736b9921c6416eb76b39029279c8bca Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126099 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-30use DrawGradient() instead of doing it manually (tdf#145796)Luboš Luňák
Change-Id: Ib771eb2ae35f68c81ef1fdcb1e4e3bf5d24a0dcc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126109 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com> (cherry picked from commit 53486d831784285b42860882a6b270eb847ff7aa) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126103 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2021-11-30tdf#145819 Revert logic of the image-with-rotation dialogGabor Kelemen
Change-Id: Ibca1092699e3a7edd37161f421f3d369a4eb49a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126070 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> (cherry picked from commit cda9a5af36977420bae34737cd7b52cddb3226ef) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126096 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-30docx export: preserve spaces in field instructionsVasily Melenchuk
MS Word is putting spaces between field mark and field instruction text. Writer preserves these spaces, but without xml:space="preserve" they are not displayed by Word later. Change-Id: I480e6febf0ee278b56e9dfc6e0430c5fd5bdfd71 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125875 Tested-by: Jenkins Reviewed-by: Thorsten Behrens <thorsten.behrens@allotropia.de> (cherry picked from commit 42c6e2eb529ec7ca66684bbf4603bace95d33556) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126004 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-30tdf#145873 Fix FILEOPEN: EMF file not displayedHossein
EMF can have WMF embedded inside it. The sample PPTX file contains an EMF file consisting of several GDIcomment records in which embed a Placeable WMF file without some records related to the size of the WMF. It reaches pStm->SetError( SVSTREAM_FILEFORMAT_ERROR ); in emfio/source/reader/wmfreader.cxx:1982 which causes to the problem in loading the file. With this fix, the EMF file will be displayed. Without the fix, the EMF file will be displayed as blank. Regression from commit 5e4e1cdb1e14354b42838e1dfcf82873b3071896 tdf#88163 Fix font size for placeable wmf files The fix can be tested with: make CPPUNIT_TEST_NAME="testTdf145873" -sr \ CppunitTest_sd_svg_export_tests Change-Id: I04babd5029ba123fdd03758eef2be69faf45fda8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125796 Tested-by: Jenkins Reviewed-by: Bartosz Kosiorek <gang65@poczta.onet.pl> (cherry picked from commit 149bd802623d6d83ec9aa04514b938494f7f01f6) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125842 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-30tdf#118063 - Writer: Deselected line spacing items remained checkedAndreas Heinisch
The state of the attributes for line spacing within comments and textboxes are now read and set correctly. Line spacing menu items were removed from Calc in Bug 136071 (ce9e965b3fc3744b99afee07f6d56860852af5e4). Change-Id: Ie20a8529d84a14d549e1985471f684b88e21819b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125880 Tested-by: Jenkins Reviewed-by: Andreas Heinisch <andreas.heinisch@yahoo.de> (cherry picked from commit fcee6b02ebfcb82f3c191b1e6ef12ef9a3487711) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126005 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-30tdf#54465 tdf#139336 sw: add compat. flag for footnote in columnAttila Szűcs
Add compatibility option FOOTNOTE_IN_COLUMN_TO_PAGEEND to keep layout of old ODT files, where multicolumn sections have footnotes in columns, growing sections to the full page. Note: Multicolumn page styles or not evenly distributed multicolumn sections, or footnotes not collected at the end of the sections still use footnotes in columns, so they don't need this compatibility option. Follow-up to commit 4c31b4ef2083087a822c3ae648fd09acc67d2f88 "tdf#139336 sw: fix extra pages of multicolumn sections with footnotes". Co-authored-by: Tibor Nagy (NISZ) Change-Id: I7d6a1f804b555dc5372767014b8fb5e3fa57ba9b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125442 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 41cc1d2c0c0c3bfa5ba341311f68df05375859fb) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126001 Reviewed-by: Attila Szűcs <szucs.attila3@nisz.hu> Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org> Tested-by: Jenkins
2021-11-30tdf#145578, tdf#145587 revise calculations for WEEKS Add-In functionWinfried Donkers
The calculations now follow the documentation for WEEKS in https://wiki.documentfoundation.org/Documentation/Calc_Functions/WEEKS. Change-Id: Ifede6e2ec2d9cfb7301fd5eb53bf7b6f187053bc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125319 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 105196aa00bc0d3e426796f6729a8e7e51271e56) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125993 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-30tdf#97899 DOCX import: allow character formatting only of numberingTünde Tóth
After the DOCX round-trip of a numbering created in Writer using direct formatting (e.g. using Toggle Ordered/Unordered List icons), it was not possible to format only the numbering or bullets, e.g. selecting and formatting them by positioning the text cursor on the numbering. Set CharStyleName property during the DOCX import to allow this formatting. Note: default list styles of Writer is still not supported, resulting missing numbering after DOCX import. Change-Id: I6f2c5d6e0d63b15e9c28367181af1e9e083ae68d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125649 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 7b8ae6f90c37c18ff724c0751b5f73cca6ae02ac) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125999 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-30close menu a followed by open menu b should not cancel open menu bCaolán McNamara
Change-Id: I9c708811d9eea04a2421c97a97d7dce14fdc8e63 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126088 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-30fix mysqlc test after Sequence::operator[] changeNoel Grandin
Change-Id: I247aeceaa4100295beec8107385d2ae28765dde8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126054 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> (cherry picked from commit 7e79b8c933516daed62382d0d60c34653ebedc4d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126094 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-29tdf#117280: fix multiple Macro execution when triggered by Document print eventJulien Nabet
Change-Id: Ibfebcc1a31464b2610afea2035e3d723a0c79167 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126018 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr> (cherry picked from commit 774c6a6e1603bf3f12f1573b0778e0f0f9783169) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126006 Tested-by: Jenkins
2021-11-29tdf#64991 speed up loading large RTL documentsNoel Grandin
takes load time from 20s to 17s for me Several loops are very hot, so store the count()/size() value, instead of calling it on every iteration. Change-Id: I8c0b01721d27e4335dd613cf276dcdd0103633ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/120945 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit bec2de27f676092bffdf8a639497602a9d13f675) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125994
2021-11-29ucb: webdav-curl: don't read from XInputStream during uploadMichael Stahl
Nextcloud will reply to a PROPFIND request with "100 Continue" and then after the data is uploaded it will send a "401 Unauthorized" if the auth header is missing in the headers to which it replied with "100 Continue". In the next call to ProcessRequestImpl(), reading from the stream returns no data because it's at EOF, and because of the Content-Length header the server will hang forever waiting for data. So copy the stream to a temporary buffer and use that for multiple calls to ProcessRequestImpl(). Change-Id: If5943a32c4cf50259fe1f84013141765cb5bd891 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125923 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@allotropia.de> (cherry picked from commit 2fae5ab2a8cefa758c631d6ae23847089b68800d) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126003
2021-11-29gtk3: set anchor_hints for gdk_window_move_to_rectCaolán McNamara
Change-Id: Id7d79e0b505cfaadf1dbae770b69eea46b43157c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125988 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-29speed up Fraction::operator*= a littleNoel Grandin
for my test spreadsheet this reduced the time spent in Fraction by 30% Change-Id: Ib14a93284dbd6c6ea2349c1754979135463ca61b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125878 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 05766922e7e4262b98e9c3f8d83cdfdaa49d3f7a) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125997
2021-11-29tdf#133996 speed up opening of ODS with autofilter + conditional formattingNoel Grandin
inline some hot methods, and use OUStringLiteral to avoid repeated construction of an OUString, saves about 3% Change-Id: I6d09ade4e08a94ed5dd49a8882e26bb5786409d5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125873 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit bf74eb1d1623a51805f91a973bc9f726d14dd7a8) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125998
2021-11-29OInterfaceContainerHelper3 needs to be thread-safeNoel Grandin
Change-Id: I11b84917033073d29268e61175faf43cbd5b1168 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125986 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> (cherry picked from commit 17aa192818caeb9af1381051a2dfda9568f7ce07) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125995
2021-11-29tdf#118045 PPTX export: fix proportional line spacingTibor Nagy
If line spacing differs from the default 100%, export it as direct paragraph formatting (similar to the other paragraph style properties). Change-Id: Id5db9ae36018c8a20b832470685bdfbba19d80f3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125438 Tested-by: László Németh <nemeth@numbertext.org> Reviewed-by: László Németh <nemeth@numbertext.org> (cherry picked from commit 5db7694a6377d32bdef293b4ece27b471c3ea427) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125992 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-29tdf#145831: fix typo in PNGAndrea Gelmini
Change-Id: I206ac72d56409b3516f49798fb7f10b3a4c3d721 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125680 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Signed-off-by: Xisco Fauli <xiscofauli@libreoffice.org> Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126016
2021-11-29cid#1494452 sfx2: fix null ptr deref in SfxInPlaceClient_Impl::saveObject()Miklos Vajna
Null-checking "this->m_pClient" suggests that it may be null, but it has already been dereferenced on all paths leading to the check. Add the missing check at a previous usage. (cherry picked from commit d9105d434ac6127f151843c7a7dbcd16257fcc0b) Change-Id: I8ebb4f41b9c83d59e65563c26729e899d45881b4 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/126014 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2021-11-29tdf#126356 partial Revert "sc tiled editing: Mapping has to beJustin Luth
turned off after drawing the buttons." This partially reverts LO 5.0 commit 342d84218c17da40d0a4f96bc3b07b536d64517a which comments: Also - we are actually never call with something else than MAP_PIXEL, so let's kill the resetting of the mapmode; let's see if some obscure corner case bites us here. Several bug reports have indicated artifacts on screen, all coming from the use of autofilter, and in these cases the map mode is 0 (Map100thMM), so I restored the whimsically removed logic. Change-Id: I9bb5d7418fc4083ed71139a64329b11fa1e4cc13 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125879 Tested-by: Jenkins Reviewed-by: Justin Luth <jluth@mail.com> (cherry picked from commit bed6b7356e4bba1604ee5f760c80acc16ae54bae) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125894 Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2021-11-28tdf#145728 Update UI Strings about QR and BarcodeMing Hua
In commit d37a44a9ebdafec1435f98194417a1d8cc8208b5 (tdf#141193 Added support for bar codes in qrcode dialog box[API Change], 2021-10-29) which added support for one-dimensional "CODE_128" barcode in addition to the previously supported 2D QR code, the various labels and tooltips in UI were not fully updated accordingly. This commit should update all QR and barcode related UI strings to match the new status, mentioning both "QR and barcode" where emphasis or detail is desired, and just "code(s)" where brevity is desired. Also use one-word "barcode" instead of "bar code" everywhere for consistency. Change-Id: I4530e4ffee5155b12551d7b819031c3869d7ab2d Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125925 Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com> Tested-by: Jenkins (cherry picked from commit cf6823ea07047ad7681262e94721f88e768f5845) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125987
2021-11-28Resolves: tdf#145863 crash on click after quick double clickCaolán McNamara
Change-Id: I18862328a3239424de80b478a09f568b5dcef1ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125901 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2021-11-28Revert "tdf#129183 sw: textboxes in group shapes - part 3"Stephan Bergmann
This reverts commit eabcfb3f18a6944d9ad89cecd3eb3ca7a2259cf3. Conflicts: sw/source/core/doc/textboxhelper.cxx It caused UITest_writer_tests4 to fail in an ASan build with > ==2987325==ERROR: AddressSanitizer: heap-use-after-free on address 0x6130000e5048 at pc 0x7f20cb3112ac bp 0x7f1e62de92d0 sp 0x7f1e62de92c8 > WRITE of size 8 at 0x6130000e5048 thread T47 > #0 in SwFrameFormat::SetOtherTextBoxFormat(SwTextBoxNode*) at sw/inc/frmfmt.hxx:106:77 > #1 in SwTextBoxNode::~SwTextBoxNode() at sw/source/core/doc/textboxhelper.cxx:1680:30 > #2 in SwFrameFormat::~SwFrameFormat() at sw/source/core/layout/atrfrm.cxx:2564:9 > #3 in SwDrawFrameFormat::~SwDrawFrameFormat() at sw/source/core/layout/atrfrm.cxx:3455:1 > #4 in SwDrawFrameFormat::~SwDrawFrameFormat() at sw/source/core/layout/atrfrm.cxx:3453:1 > #5 in SwFrameFormats::DeleteAndDestroyAll(bool) at sw/source/core/doc/docfmt.cxx:2115:9 > #6 in SwDoc::~SwDoc() at sw/source/core/doc/docnew.cxx:565:28 > #7 in SwDoc::release() at sw/source/core/doc/doc.cxx:118:9 > #8 in rtl::Reference<SwDoc>::clear() at include/rtl/ref.hxx:196:19 > #9 in SwDocShell::RemoveLink() at sw/source/uibase/app/docshini.cxx:444:16 > #10 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:372:5 > #11 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1 > #12 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1 > #13 in SvRefBase::ReleaseRef() at include/tools/ref.hxx:163:29 > #14 in tools::SvRef<SfxObjectShell>::~SvRef() at include/tools/ref.hxx:56:36 > #15 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() at sfx2/source/doc/sfxbasemodel.cxx:245:5 > #16 in void std::destroy_at<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15 > #17 in void std::allocator_traits<std::allocator<IMPL_SfxBaseModel_DataContainer> >::destroy<IMPL_SfxBaseModel_DataContainer>(std::allocator<IMPL_SfxBaseModel_DataContainer>&, IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:537:4 > #18 in std::_Sp_counted_ptr_inplace<IMPL_SfxBaseModel_DataContainer, std::allocator<IMPL_SfxBaseModel_DataContainer>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:528:2 > #19 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:168:6 > #20 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:705:11 > #21 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1154:31 > #22 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::reset() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1272:9 > #23 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:757:13 > #24 in SwXTextDocument::dispose() at sw/source/uibase/uno/unotxdoc.cxx:549:19 > #25 in SfxBaseModel::close(unsigned char) at sfx2/source/doc/sfxbasemodel.cxx:1482:5 > #26 in SwXTextDocument::close(unsigned char) at sw/source/uibase/uno/unotxdoc.cxx:562:19 > #27 in SfxBaseModel::dispose() at sfx2/source/doc/sfxbasemodel.cxx:718:13 > #28 in SwXTextDocument::dispose() at sw/source/uibase/uno/unotxdoc.cxx:549:19 > #29 in gcc3::callVirtualMethod(void*, unsigned int, void*, _typelib_TypeDescriptionReference*, bool, unsigned long*, unsigned int, unsigned long*, double*) at bridges/source/cpp_uno/gcc3_linux_x86-64/callvirtualmethod.cxx:77:5 > #30 in cpp_call(bridges::cpp_uno::shared::UnoInterfaceProxy*, bridges::cpp_uno::shared::VtableSlot, _typelib_TypeDescriptionReference*, int, _typelib_MethodParameter*, void*, void**, _uno_Any**) at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:233:13 > #31 in unoInterfaceProxyDispatch at bridges/source/cpp_uno/gcc3_linux_x86-64/uno2cpp.cxx:413:13 > #32 in binaryurp::IncomingRequest::execute_throw(binaryurp::BinaryAny*, std::__debug::vector<binaryurp::BinaryAny, std::allocator<binaryurp::BinaryAny> >*) const at binaryurp/source/incomingrequest.cxx:235:13 > #33 in binaryurp::IncomingRequest::execute() const at binaryurp/source/incomingrequest.cxx:78:26 > #34 in request at binaryurp/source/reader.cxx:85:9 > #35 in cppu_threadpool::JobQueue::enter(void const*, bool) at cppu/source/threadpool/jobqueue.cxx:100:17 > #36 in cppu_threadpool::ORequestThread::run() at cppu/source/threadpool/thread.cxx:164:31 > #37 in threadFunc at include/osl/thread.hxx:189:15 > #38 in osl_thread_start_Impl(void*) at sal/osl/unx/thread.cxx:264:9 > #39 in start_thread at <null> > #40 in __GI___clone3 at <null> > > 0x6130000e5048 is located 328 bytes inside of 376-byte region [0x6130000e4f00,0x6130000e5078) > freed by thread T47 here: > #0 in operator delete(void*, unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:164:3 > #1 in SwFlyFrameFormat::~SwFlyFrameFormat() at sw/source/core/layout/atrfrm.cxx:2912:1 > #2 in SwFrameFormats::DeleteAndDestroyAll(bool) at sw/source/core/doc/docfmt.cxx:2115:9 > #3 in SwDoc::~SwDoc() at sw/source/core/doc/docnew.cxx:565:28 > #4 in SwDoc::release() at sw/source/core/doc/doc.cxx:118:9 > #5 in rtl::Reference<SwDoc>::clear() at include/rtl/ref.hxx:196:19 > #6 in SwDocShell::RemoveLink() at sw/source/uibase/app/docshini.cxx:444:16 > #7 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:372:5 > #8 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1 > #9 in SwDocShell::~SwDocShell() at sw/source/uibase/app/docshini.cxx:362:1 > #10 in SvRefBase::ReleaseRef() at include/tools/ref.hxx:163:29 > #11 in tools::SvRef<SfxObjectShell>::~SvRef() at include/tools/ref.hxx:56:36 > #12 in IMPL_SfxBaseModel_DataContainer::~IMPL_SfxBaseModel_DataContainer() at sfx2/source/doc/sfxbasemodel.cxx:245:5 > #13 in void std::destroy_at<IMPL_SfxBaseModel_DataContainer>(IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/stl_construct.h:88:15 > #14 in void std::allocator_traits<std::allocator<IMPL_SfxBaseModel_DataContainer> >::destroy<IMPL_SfxBaseModel_DataContainer>(std::allocator<IMPL_SfxBaseModel_DataContainer>&, IMPL_SfxBaseModel_DataContainer*) at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/alloc_traits.h:537:4 > #15 in std::_Sp_counted_ptr_inplace<IMPL_SfxBaseModel_DataContainer, std::allocator<IMPL_SfxBaseModel_DataContainer>, (__gnu_cxx::_Lock_policy)2>::_M_dispose() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:528:2 > #16 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:168:6 > #17 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:705:11 > #18 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1154:31 > #19 in std::__shared_ptr<IMPL_SfxBaseModel_DataContainer, (__gnu_cxx::_Lock_policy)2>::reset() at ~/gcc/trunk/inst/lib/gcc/x86_64-pc-linux-gnu/12.0.0/../../../../include/c++/12.0.0/bits/shared_ptr_base.h:1272:9 > > previously allocated by thread T10 here: > #0 in operator new(unsigned long) at ~/github.com/llvm/llvm-project/compiler-rt/lib/asan/asan_new_delete.cpp:95:3 > #1 in SwDoc::MakeFlyFrameFormat(rtl::OUString const&, SwFrameFormat*) at sw/source/core/doc/docfmt.cxx:756:33 > #2 in SwDoc::MakeFlySection_(SwPosition const&, SwContentNode const&, RndStdIds, SfxItemSet const*, SwFrameFormat*) at sw/source/core/doc/doclay.cxx:171:33 > #3 in SwDoc::MakeFlySection(RndStdIds, SwPosition const*, SfxItemSet const*, SwFrameFormat*, bool) at sw/source/core/doc/doclay.cxx:337:19 > #4 in SwXFrame::attachToRange(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&, SwPaM const*) at sw/source/core/unocore/unoframe.cxx:2821:29 > #5 in SwXFrame::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:3115:9 > #6 in SwXTextFrame::attach(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unoframe.cxx:3346:15 > #7 in SwXText::insertTextContent(com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, unsigned char) at sw/source/core/unocore/unotext.cxx:615:15 > #8 in SwXText::insertTextContentWithProperties(com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unotext.cxx:1472:5 > #9 in non-virtual thunk to SwXText::insertTextContentWithProperties(com::sun::star::uno::Reference<com::sun::star::text::XTextContent> const&, com::sun::star::uno::Sequence<com::sun::star::beans::PropertyValue> const&, com::sun::star::uno::Reference<com::sun::star::text::XTextRange> const&) at sw/source/core/unocore/unotext.cxx > #10 in SwTextBoxHelper::create(SwFrameFormat*, SdrObject*, bool) at sw/source/core/doc/textboxhelper.cxx:100:29 > #11 in SwXShape::setPropertyValue(rtl::OUString const&, com::sun::star::uno::Any const&) at sw/source/core/unocore/unodraw.cxx:1165:25 > #12 in SdXMLShapeContext::SetStyle(bool) at xmloff/source/draw/ximpshap.cxx:701:27 > #13 in SdXMLCustomShapeContext::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at xmloff/source/draw/ximpshap.cxx:3545:5 > #14 in SvXMLImport::startFastElement(int, com::sun::star::uno::Reference<com::sun::star::xml::sax::XFastAttributeList> const&) at xmloff/source/core/xmlimp.cxx:805:15 > #15 in (anonymous namespace)::Entity::startElement((anonymous namespace)::Event const*) at sax/source/fastparser/fastparser.cxx:468:27 > #16 in sax_fastparser::FastSaxParserImpl::callbackStartElement(unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:1304:21 > #17 in (anonymous namespace)::call_callbackStartElement(void*, unsigned char const*, unsigned char const*, unsigned char const*, int, unsigned char const**, int, int, unsigned char const**) at sax/source/fastparser/fastparser.cxx:331:18 > #18 in xmlParseStartTag2 at workdir/UnpackedTarball/libxml2/parser.c:9658:6 > #19 in xmlParseTryOrFinish at workdir/UnpackedTarball/libxml2/parser.c:11453:14 Change-Id: I752190e05fc3c282b75021724527f623f56ee6a6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125977 Tested-by: Jenkins Tested-by: René Engelhard <rene@debian.org> Reviewed-by: Stephan Bergmann <sbergman@redhat.com> (cherry picked from commit 4fb7967fb2e67717f79eb87519c1444a82350a83) Reviewed-on: https://gerrit.libreoffice.org/c/core/+/125906
generated by cgit (git 2.34.1) at 2024-08-18 10:05:28 +0000