summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-01-10use more std::make_sharedNoel Grandin
found using 'git grep', I tried using clang-tidy, but it only successfully found a tiny fraction of these Change-Id: I61c7d85105ff7a911722750e759d6641d578da33 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86526 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-10these don't need to be shared_ptrNoel Grandin
and fix the naming while I'm here Change-Id: I4ba612875a0d98bedda41e34e1c73af7900b98e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86525 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-10tdf#42949 Fix IWYU warnings in svx/inc/ and svx/source/inc/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ic19dbb807b6c35e7772878e53a4f00bbb8688b7c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85788 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-10tdf#88713 Fix navigating navigator remindersJim Raykowski
Change-Id: I65be92eda086af2f98da723828ff965047e87227 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86256 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-10xmloff: create AnimationsImport instances with an uno constructorMiklos Vajna
See tdf#74608 for motivation. Change-Id: I36a70b0657c4648a9f5cf69d67d4da4508099587 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86503 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-10unopkg: Remove too verbose loggingSamuel Mehrbrodt
This adds several lines of 'Extension x not found' when installing an extension with 'unopkg add'. Since it's expected that the extension is not yet there when installing it, remove this logging. Change-Id: Ifc2ea5fa04253a96fee60016a65505e0d1f2722c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86516 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2020-01-10oox: add missing nullptr checksXisco Fauli
See http://crashreport.libreoffice.org/stats/signature/oox::drawingml::chart::PlotAreaConverter::convertFromModel(oox::drawingml::chart::View3DModel%20&) Regression from 11473832b5717cb3222ce72baee885bc9e8e2386 Change-Id: I6cf08582fb384203ca1ce5736b88b85c11ff56da Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86483 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-10Sifr: Fix for tdf#127415, tdf#129846Rizal Muttaqin
- Add more 32px icons, especially in the default standard toolbar accross module and inserted stuff (table, picture, node/bezier & gluepoint) - Update address book icons to follow Adwaita monochrome - Update some Calc misslead icons - Remove duplicate same appearance icons and move to links.txt file - etc Change-Id: Ia81a7f28d24c010108c091dffc09762f0875f492 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86511 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2020-01-09lok: simplify jsdialog creation for sidebar panels.Michael Meeks
Remove some layers of nested and/or un-necessary content, also simplifies client-side JS. Change-Id: I67347035ceb9dbee9c62c99624b5084883d4e61a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86499 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-09tdf#115026: Add uitestXisco Fauli
Change-Id: Iaac2a1065c0c1c28e56db8a121cb28453e27d529 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86497 Tested-by: Jenkins Reviewed-by: Xisco Faulí <xiscofauli@libreoffice.org>
2020-01-09Introduce o3tl::make_unsigned to cast from signed to unsigned typeStephan Bergmann
...without having to spell out a specific type to cast to (and also making it more obvious what the intend of such a cast is) Change-Id: Id9c68b856a4ee52e5a40d15dc9d83e95d1c231cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86502 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-09Improve loplugin:redundantcast for sal_Int... vs. ::sal_Int...Stephan Bergmann
Change-Id: I1548a76fdc03afee68f1e5c01bc665e616f2edf2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86501 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-09tdf#90069 DOCX: fix character style of new table rowsLászló Németh
DOCX table import didn't set paragraph level character styles on paragraph level, only on text portions, resulting default character style in the newly inserted table rows instead of copying the style of the previous table row. Change-Id: Idb4438c767bdc7e0026fc6e0f0a795d8efdda3c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86429 Tested-by: Jenkins Reviewed-by: László Németh <nemeth@numbertext.org> Tested-by: László Németh <nemeth@numbertext.org>
2020-01-09python3: bundle libffi for GNU/Linux buildsMichael Stahl
CPython commit f40d4ddff3c800b3c956a5e8820aabe3aa87cddd "Closes #27979: Remove bundled copy of libffi" causes a bit of a problem because it turns out that libffi isn't all that stable; there's libffi.so.5 on CentOS 6, libffi.so.6 on CentOS 7 and libffi.so.7 on lo_daily_update_gandalf tinderbox. So we have to bundle it in LO; it's only used on GNU/Linux currently. CPython commit 32119e10b792ad7ee4e5f951a2d89ddbaf111cc5 "bpo-35947: Update Windows to the current version of libffi (GH-11797)" also removes the libffi for MSVC, so in a future python upgrade we will have to build libffi for MSVC too. The libffi fork for MacOSX is still in CPython git master. (regression from b10be5d48433076f0b7238d818020f708553e114) Change-Id: Ibc20cf8cd3614cf9941b6970662bd930496776b2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86493 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-09sw: fix confusing comment in CopyFlyInFlyImpl()Miklos Vajna
Change-Id: I7b9da4aecc7dce4b2a539455182e5a3f6a75a497 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86494 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-01-09sw: tolerate null ShadowOverlay object as the rest of the code does.Michael Meeks
Change-Id: I552c0f11b22212d36bcaee33432e2a10d4df58ac Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86473 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-09tdf#45636: test for no-alt and table split/merge access. checkTomaž Vajngerl
Change-Id: I6474b5e0db90143efa1ea066142961c2fe250ae6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86492 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-09tdf#45636 trigger accessibility check when exporting as PDF/UATomaž Vajngerl
This triggers the accessibility check, when we want to export the PDF with PDF/UA functionallity. If issues are found, it will show the issues. OK will continue with export despite the issues and cancel will cancel the whole PDF export. Change-Id: I2fde97381e08e9c2c79473888caa36e8dd828979 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86387 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-09add hook for on-demand welded toolbar popover creationCaolán McNamara
Change-Id: I662976a62281909e30d5b256e10ddcf2ceee2595 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86474 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09Resolves tdf#129836 - Alphabetize styles in the footnotes/endnotes dialogHeiko Tietze
List is sorted now Change-Id: Ie9bc4f63412dabd6032f0a9b7225384823f2f39a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86490 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-09tdf#129600 Delete "Formula bar" item from View-ToolbarsRoman Kuznetsov
Change-Id: Iec6c6c998a12aafdbf63bc1e5083cf577aefb437 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86354 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-09writerfilter: fix confusing typo, it's SDT (structured document tag)Michael Stahl
Change-Id: I70f8fa752ddac936de6d9f272eff8d36b83858a9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86445 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-09add setting to config_skia.h whether to use 32bpp bitmapsLuboš Luňák
As said in previous Skia commits about BackendCapabilities::mbSupportsBitmap32 this should be preferrably enabled, but there are still parts of LO code that have a problem with it, so make it easier to enable/disable this. Change-Id: Iae7a8d5fc77a27372c00f6745317d168e8b2a05b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86489 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-09fix Skia virtual device alpha blending (tdf#129865)Luboš Luňák
The blendBitmap()/blendAlphaBitmap() stuff coming from the OpenGL code is some undocumented crazy stuff (probably because the VirtualDevice alpha handling itself is rather crazy). Hopefully I've finally figured it out to work properly for Skia too. This separate alpha handling all over the place in VCL should be just nuked. Change-Id: I82615a9be7064e9ade00ec4970a131a80a543c14 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86488 Tested-by: Jenkins Reviewed-by: Luboš Luňák <l.lunak@collabora.com>
2020-01-09acc. check: move AccessibilityIssue from svx to sfx2Tomaž Vajngerl
Move AccessibilityIssue and AccessibilityIssueCollection from svx to sfx2 because we need to use them in sfx2, but svx is dependent on sfx2 so this creates a circular dependency. Change-Id: Ie71d12a018ddc65797f5115eb545f499b927ab40 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86444 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-01-09convert XMLAutoTextEventImport to FastParser APIsNoel Grandin
Change-Id: If0249a9987a42c700f994073bc649774ae84f510 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86477 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-09Use FastParser in SwXMLTextBlocksNoel Grandin
the underlying SvXMLImport subclass already has a FastParser inside it Change-Id: I4c33508fc28eac2c119361506158c1f4520162ce Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86476 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-09flatten SwXMLTextBlocks::GetMacroTableNoel Grandin
Change-Id: Ie3fcb4bb350796b10d0e10aadc58d57b71d480a3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86475 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-01-09pyuno: remove racy debug checkMichael Stahl
The use-after-free is easier to trigger than expected; i don't see how it's possible to check this without a race. Change-Id: I4afb7066d1bf6b34f4f56aa0f51be0643ae40a66 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86481 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-09cleanup tdf#129522: indentingJustin Luth
It is much easier to see what has changed if a commit does not include formatting changes. Since there were a couple of them, I separated it out into a separate patch. I don't normally do this, but it seems like a good idea, so I'm trying out the best way to do it. The bad-side would be an extra patch to backport, but I'm not expecting much desire to backport here. Change-Id: Icc0eae1a881af80c0b8230697b235d1901b55fe3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85871 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-09python3: fix 32-bit x86 buildMichael Stahl
The reinvented wheel needs another subst. Change-Id: I5bc01b0213f00d383cf971d34f0dc2a9e6817ab9 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86480 Tested-by: Jenkins Reviewed-by: Michael Stahl <michael.stahl@cib.de>
2020-01-09weld ParaPropertyPanelCaolán McNamara
Change-Id: Id486c73559e698979e223c7f1ca8a16caba3bbfd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86357 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09weld ParaLineSpacingControlCaolán McNamara
Change-Id: Idce812f348187fd35accc69fba8bdf293e267a74 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86457 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09-Werror,-Wwritable-strings (clang-cl)Stephan Bergmann
Change-Id: I67287498db35c60f224b095b00e6c058f53c10cf Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86471 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-01-09Options Dialog Calc General fix spacing according to HIGandreas kainz
Change-Id: I8776f40b6feccbbb304a02ef42a6163e0f52ce4b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86412 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2020-01-09ofz#19961 Invalid-enum-valueCaolán McNamara
Change-Id: I112d5cd9aa8e7169f7ff7e55ba93487c3d904b97 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86469 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09android: avoid expensive load of un-used sidebar icons on mobile.Michael Meeks
Change-Id: I34c24c40009eeb4e8edbac785f9367f1dc3d56c1 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86468 Tested-by: Jenkins Reviewed-by: Michael Meeks <michael.meeks@collabora.com>
2020-01-09tdf#129522 ooxmlexport: allow char shadow_NONE overrideJustin Luth
Normally we would NOT want to write out nil borders or shadows. However, if these would be inherited, NILs needs to be written out. This already worked for paragraphs, so it was just a matter of identifying the character styles and testing against them. I couldn't find anything that clearly stated that ChpIter is the CharStyle properties, but it appears to act that way, since the first check is for ISet (which seems to be direct properties) and the second check is usually for styles, and the Internet also suggests Fkp's are for styles. This is the last patch in a series, and provides the unit test for a previous import fix. import depends on commit ccfccf4365362b5ba1d82b5816d5fc81a67de548 which depends on commit 4ca73073a0d7c62b12a7354f76f8f80adc5d98c1 and for export depends on commit f84b33275f6cce21e93e5dd20f3de5df84df0276. Change-Id: I5230adc52196b9b610d7863397bf33143682370c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85870 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org> Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-09tdf#42949 Fix IWYU warnings in unoxml/Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I4457153dc4f2bfe932488b1c6e3af3cff58cb150 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/85787 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-09tdf#129468 Add uno command .uno:SetReminder to set a reminder bookmarkJim Raykowski
Replaces code in SwNavigationPI to set a reminder with call to uno command Change-Id: I2f14d88c99488b1dbfdecb9831f6716c95da7438 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86389 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2020-01-09use welded CurrencyList dropdown in all toolbarsCaolán McNamara
Change-Id: Ia6d285947ce8cbae50700ee95bba861884c7e030 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86434 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09also grab the keyboard under gtk when showing a temp floating windowCaolán McNamara
so keyboard focus in inside native gtk popovers for nonnative toolbar items Change-Id: I82073b3912698c32022eb4619c31d1b2f9d8a801 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86456 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09in gtk < 3.20.0 grab the keyboard like we are doing in >= 3.20.0Caolán McNamara
when showing a fallback GtkWindow window in place of a popover under X from GtkMenuButton so the keyboard focus is in that popup under X like it is by default under wayland Change-Id: Ifb89063a0352ad561076b2c3251229861712a566 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86455 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-01-09Get PDB files to work for soffice.bin and unopkg.binJuergen Funk
..by renaming them to *.bin.pdb, so WinDbg picks them up. Follow-up fix to commit 6ca3adf22b62b88b313c8fc9311183efdabe445a Change-Id: I5cb7b305c997b423cf0cd70835163811f75b3e25 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86465 Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2020-01-09use for jpeg quality everywhere 80andreas kainz
Change-Id: I1744cb5e281b5d36dc9a29c85c7685730e3fbb32 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86438 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-01-09Update git submodulesAndrea Gelmini
* Update helpcontent2 from branch 'master' to f7e63b6ebfb423647a70b5f1c6c7225729c1b142 - Fix typo Change-Id: I39c8ebc5a94f6cbd5e7af00418fd354630ecd527 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86466 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-01-09writerprefect: add missing braces around try-catchMiklos Vajna
Spelling them out helps readability. Change-Id: I878e1a258b7d15b673ff3dbb42e40147bf60b41a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86453 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-01-09Register spsupp*.dll during installationMike Kaganski
This registers SharePoint integration libraries using regsvr.exe. Both 32-bit and 64-bit libraries are registered; registration of LOSPSupport.OpenDocuments is unconditional. This introduces a new hidden MSI feature, which is disabled for installation: gm_SharePointSupport_SubstMSO. When installed, it registers SharePoint.OpenDocuments class in registry, thus overriding registration of this component by MS Office, allowing LibreOffice to serve as MS Office replacement working in IE with SharePoint. To install the feature, either a transform is needed setting the feature's level <= 100, or a command line: msiexec path-to-msi ADDLOCAL=gm_SharePointSupport_SubstMSO Change-Id: I5517bbb68dcc6db8bcb2bbc2368394ee4a62d741 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86452 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-01-08Update git submodulesSeth Chaiklin
* Update helpcontent2 from branch 'master' to 5f5d1373c85c9de0cc9a906e9d8c4a78dab64740 - tdf#94411 update help for Index page - grammatical correction - appearance of f/ff depends on locale/Language setting. Change-Id: I23b4ff2150cac5f5f6519018f7d3c29925bd8c77 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/86405 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-01-08tdf#129887: fix crash during scrolling down documentSerge Krot
regression from tdf#129708 Change-Id: I6c5d7eb90030234e899ab8ce5b3adec33e03962a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/86454 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
generated by cgit (git 2.34.1) at 2024-07-25 05:44:55 +0000