summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2019-04-19tdf#42949 Fix IWYU warnings in comphelperGabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Also re-evaluate some blacklisted headers and recheck include/comphelper/ Change-Id: Ib7eea5951e849c07cea2e2782be4e8945f71ad96 Reviewed-on: https://gerrit.libreoffice.org/70899 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19sc: Get rid of the Idle hack in the Special Filter Dialog.Jan Holesovsky
The problem is that with LOK, the creation of Idle here causes a deadlock when the dialog is being opened and its first paint is requested. No real idea what change now causes the problem (this used to work), but given that the use of the Idle is a hack in the first place, let's use the GetFocus/LoseFocus handlers instead, and act accordingly only when the focus of the interesting controls changes. Change-Id: Ib6c0267a064cb31438544e47fe3e0869b575ef7c Reviewed-on: https://gerrit.libreoffice.org/70948 Tested-by: Jenkins Reviewed-by: Jan Holesovsky <kendy@collabora.com>
2019-04-19drop some includesCaolán McNamara
Change-Id: I6f9765208e807da336146e55f0f1cbcb46316d4c Reviewed-on: https://gerrit.libreoffice.org/70935 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19crashtesting: tdf#122599 NSS_CMSMessage_CreateFromDER assertsCaolán McNamara
because NSS_Init wasn't called first Change-Id: Ib1b4c950dc2773af1fea7b64339b86566ee412e7 Reviewed-on: https://gerrit.libreoffice.org/70947 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-19vcl: Allow for rounding errors on Win32 in testAlphaVirtualDeviceTomaž Vajngerl
Windows Tinerbox fails because of rounding error in blending (but only in some environments), so allow for a small rounding error in colors. Change-Id: If45ae99a445e9d6f795d06d88c902a723913b9a6 Reviewed-on: https://gerrit.libreoffice.org/70932 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-19Remove redundant functions from FastSerializerHelperMike Kaganski
They are identical to what compiler autogenerates from templated overload Change-Id: I0b1361a5dae7e6520a1ec21d735fdebbe0c9a76e Reviewed-on: https://gerrit.libreoffice.org/70959 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19tdf#45904 Move XChartData Java tests to C++Jens Carl
Fix tdf#43309: Move XChartData Java tests to C++ for ScCellRangeObj. Change-Id: I6b57db53fdddab2ff382354d32809404224a2e1e Reviewed-on: https://gerrit.libreoffice.org/70956 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-19vcl: extend SVM (MetaFile) BitmapEx testsTomaž Vajngerl
Change-Id: I92ce3bbcd7e7d52c53b70a1b9339c2e110c2ccbb Reviewed-on: https://gerrit.libreoffice.org/70926 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2019-04-19Further cleanup to not use FSEND and useless string conversionsMike Kaganski
... in XclExpXmlStream::WriteAttributes Change-Id: Ideae6685e7f035970850d86bcaea74c525f1ec81 Reviewed-on: https://gerrit.libreoffice.org/70957 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19SAX_ARGS_ARG macro pack is unusedMike Kaganski
Change-Id: Icb7dca3456b3b355b68e8cb08f91f97b8504575a Reviewed-on: https://gerrit.libreoffice.org/70955 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-19tdf#124649 menubar: show icons for important items breeze, sifrandreas kainz
Change-Id: Ie3209121ade4b12c946dbe878ccc606199d02103 Reviewed-on: https://gerrit.libreoffice.org/70946 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-18tdf#45904 Remove already converted testsJens Carl
Change-Id: I0f7ed57336a4cfa5f143b3c49626dfa8dd590905 Reviewed-on: https://gerrit.libreoffice.org/70953 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2019-04-18C++11-ify XclExpXmlStream::WriteAttributesMike Kaganski
This gets rid of some macro mess; and also enables passing OUString as attribute values. Change-Id: I25a8af4adabd905e0016c604d6710c9c5d2f889d Reviewed-on: https://gerrit.libreoffice.org/70952 Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2019-04-18Resolves: tdf#115964 force password dialog to center on parent size requestCaolán McNamara
this is similar to... commit d17d9500a23705a315992ff42cb7c449894fc2ce Date: Tue Apr 16 14:49:46 2019 +0100 tdf#124597 template select dialog launched before parent gets final size where the dialog is launched before its parent window has got to its final size Change-Id: I0f54a8da482ed75fa939e230b69c0eb918782bf5 Reviewed-on: https://gerrit.libreoffice.org/70943 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Related: tdf#124809 cannot assume that icon size is same as checkbox sizeCaolán McNamara
cause can be using large icon size Change-Id: I4661199b658ff0d2013a7bbd7159b1c134ade043 Reviewed-on: https://gerrit.libreoffice.org/70942 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Resolves: tdf#124809 spacing ignored unless WB_ITEMBORDER is setCaolán McNamara
Change-Id: I29d63926c605d3f143c242337e31388123f22cff Reviewed-on: https://gerrit.libreoffice.org/70939 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18don't use SwSectionFormats hereNoel Grandin
since SwSectionFormats wants to own the things it points to, and we don't want to own here. The only reason it was working is because we call clear() on the horrible SwVectorModifyBase base class here, which removes the pointers without deleting the pointed-to objects. Change-Id: I8aba61e74ce1463ff4be439c0feb830d1aa8988e Reviewed-on: https://gerrit.libreoffice.org/70940 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18tdf#124822 CRASH: cutting and undoingNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I17312ca978a83a431dfaf6edda2c98e6302eb2d1 Reviewed-on: https://gerrit.libreoffice.org/70938 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18forcepoint#80 avoid crashCaolán McNamara
Change-Id: I7a96d2951fbcd5f53a2f7e65e8c07926fc035a11 Reviewed-on: https://gerrit.libreoffice.org/70936 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18forcepoint#79 FindStartEndOfRowSpanCell returning nullCaolán McNamara
Change-Id: I85f5b17b7dc2d3c4dfef92f64451fab451f58112 Reviewed-on: https://gerrit.libreoffice.org/70927 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18weld ScOptSolverDlgCaolán McNamara
Change-Id: Ie2b43377f950cb16e143f6e9ef7081bf92277088 Reviewed-on: https://gerrit.libreoffice.org/70903 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Update git submodulesStephan Bergmann
* Update helpcontent2 from branch 'master' - Don't set LANG env var by accident ...as setting a GNU Make LANG var exports it to recipes as an env var, and see e.g. 56bc0b1a376f62570a7287e9bb4193e00360c978 "Don't set locale env vars on macOS" for potential problems caused by that. This is the help half of a change spanning the core and help repos. Change-Id: Ib5faf612e9030db384f7408ecd4fd03e65120f17 Reviewed-on: https://gerrit.libreoffice.org/70930 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-18Don't set LANG env var by accidentStephan Bergmann
...as setting a GNU Make LANG var exports it to recipes as an env var, and see e.g. 56bc0b1a376f62570a7287e9bb4193e00360c978 "Don't set locale env vars on macOS" for potential problems caused by that. This is the core half of a change spanning the core and help repos. Change-Id: Ib7ae3b6edcef0b70e211a01aad4b3bd5c8905e06 Reviewed-on: https://gerrit.libreoffice.org/70929 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-18Disable OpenCL by default for LO FlatpakStephan Bergmann
...merging <https://github.com/flathub/org.libreoffice.LibreOffice/commit/ 2c72c8b2c9beb4995c5a57b4eedf05f6c7ff248d> "Disable OpenCL by default for LO Flatpak": "This fixes <https://github.com/flathub/org.libreoffice.LibreOffice/issues/82> 'LibreOffice cannot be launched with flatpak in normal mode on ASUS E402YA', where LO was found hanging (for as yet unclear exact reasons) on one machine when OpenCL was enabled. There have been other issues with OpenCL like <https://bugzilla.redhat.com/show_bug.cgi?id=1432468> 'LibreOffice crashes on startup' on Fedora, so for a Flatpak build targeting a wide range of distros, the conservative approach is probably to disable OpenCL by default and have users explicitly enable it instead." Change-Id: I887137d1ceb5d97f007f09cba636c59f197f1bff Reviewed-on: https://gerrit.libreoffice.org/70928 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-18tdf#124818 CRASH selecting all and switching spreadsheetNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: I033bcae2bdc97c3aae24557c5949c7759041b3bc Reviewed-on: https://gerrit.libreoffice.org/70925 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18tdf#43157 Clean up OSL_TRACE (replace with SAL_INFO)Jens Carl
Change-Id: Ifa196dec38d1b84ef14e9bb3a6b45d5ead72064a Reviewed-on: https://gerrit.libreoffice.org/70904 Reviewed-by: Stephan Bergmann <sbergman@redhat.com> Tested-by: Jenkins
2019-04-18tdf#124815 CRASH: inserting a columnNoel Grandin
regression from commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic. Change-Id: If82689218344d1fea025d7d6e409dd5ec9e2d3b3 Reviewed-on: https://gerrit.libreoffice.org/70924 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18forcepoint#78 large double cast to sal_Int32 wraps to negCaolán McNamara
Change-Id: I831d0dd62d0b28dc19b90b03de3eaa159984347c Reviewed-on: https://gerrit.libreoffice.org/70922 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2019-04-18Don't set locale env vars on macOSStephan Bergmann
macosx_getLocale (via getProcessLocale, both sal/osl/unx/osxlocale.cxx) obtains from the system a locale string like "en-DE". (Whether that is even a sane and recommended way to obtain the system locale on macOS I don't know; but lets leave it at that for now.) However, setting a locale env var (LANG, LC_ALL) to such a value causes a constructor call std::locale("") to throw a std::runtime_error "collate_byname<char>::collate_byname failed to construct for ", at least on macOS 10.14.4. And libdivvun (which might be bundled with a LO extension) is known to be hit by that, see <https://github.com/divvun/libdivvun/issues/28> "locale("") gives 'collate_byname<char>::collate_byname failed to construct for ' on LO on mac". The code setting LC_ALL/LC_CTYPE/LANG was there ever since 8737d1831b48acd8a4793c4728ad8563f77b5bf8 "INTEGRATION: CWS geordi2q14: #111934#: merge CWS ooo111fix2", but for unclear reasons. Lets assume that it had no purpose (any longer). Change-Id: I0b519ad567a713d61f662aa984791db1a91c708c Reviewed-on: https://gerrit.libreoffice.org/70918 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2019-04-18tdf#87459 bring back HyperlinkDialog againandreas kainz
Change-Id: I0938894681e73aaadf8bd353185dc4c6a125e0e2 Reviewed-on: https://gerrit.libreoffice.org/70920 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-18sw: fix missing includeMiklos Vajna
Change-Id: If6a50542e8e2c4899b1d89ba6456e0f39b4cf39a
2019-04-18Removed spurious charsAndrea Gelmini
Same thing as in commit e5efd197ad403619ac274c88e2e3be648886aa3d Change-Id: I84faa989387cefef18aa25fa813890d04858f7f2 Reviewed-on: https://gerrit.libreoffice.org/68987 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Fix typoAndrea Gelmini
Change-Id: Ia778edadc6ca4cf56868e250f0c29efeeef3ca9f Reviewed-on: https://gerrit.libreoffice.org/70909 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Removed duplicated includesAndrea Gelmini
Change-Id: Id0222c9f6a7ef04ed46dc5ceacd814619b4d7c21 Reviewed-on: https://gerrit.libreoffice.org/70912 Reviewed-by: Julien Nabet <serval2412@yahoo.fr> Tested-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Fix typoAndrea Gelmini
Change-Id: I4166a7aa9067907e563a98d76bd7f21c63370ce4 Reviewed-on: https://gerrit.libreoffice.org/70910 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Fix typoAndrea Gelmini
Change-Id: If0104ebab265a98982808fa5003a499deae542b6 Reviewed-on: https://gerrit.libreoffice.org/70908 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18tdf#42949 Fix IWYU warnings in sw/qa/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: Ia0c79c2455a3b40384332c8c35215671e257a07f Reviewed-on: https://gerrit.libreoffice.org/70847 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-18Fix typoAndrea Gelmini
Change-Id: I1021d7cfc2b27924e3a30d0f0d6a936e2bec99f9 Reviewed-on: https://gerrit.libreoffice.org/70907 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Fix typoAndrea Gelmini
Change-Id: Ief0343a128ae45ee62f7965a6ea77b2dcbd0ae49 Reviewed-on: https://gerrit.libreoffice.org/70911 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2019-04-18Add a test to check XPath testing facilities in XmlTestToolsMike Kaganski
... to guarantee that e.g. getXPath will always fail for non-empty non-existing attribute Change-Id: I22cf932eda020abf16608341fcd1769b35478883 Reviewed-on: https://gerrit.libreoffice.org/70891 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-18CppunitTest_sw_uiwriter2: use CPPUNIT_TEST_FIXTURE()Miklos Vajna
Change-Id: I169612264ef713027b38d1218ba71c86732da7f5 Reviewed-on: https://gerrit.libreoffice.org/70900 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2019-04-18crashtesting: failure on import of ooo6593-5.stcNoel Grandin
since commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: I858e61b3a1158bf47b5855e56d63c77cc87aa09b Reviewed-on: https://gerrit.libreoffice.org/70902 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18crashtesting: failure on export of ooo118068-1.ods to odsNoel Grandin
since commit 7282014e362a1529a36c88eb308df8ed359c2cfa Date: Fri Feb 1 15:15:16 2019 +0100 tdf#50916 Makes numbers of columns dynamic Change-Id: Ib8dc06b80beed81a2543f343483599c425e87369 Reviewed-on: https://gerrit.libreoffice.org/70901 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2019-04-18tdf#115600 Display not found message for Navigate by SelectionJim Raykowski
...if there is no selection found Change-Id: Ie4857e8d1bb98e41565aef47d3a794dcbe9bbd66 Reviewed-on: https://gerrit.libreoffice.org/70645 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-04-18tdf#106723 Improve visibility of not found search termRasmus Jonsson
Move SetSearchLabel definition to srchdlg.cxx Set control foreground to red on failed search and reset on text input modification. For the find & replace dialog, use set_entry_error for the same. Reset "not found" search label on modification of search term. Change-Id: Ia89d2e8d3ca35e2c184d5b7048af8267b57f2c17 Reviewed-on: https://gerrit.libreoffice.org/70662 Tested-by: Jenkins Reviewed-by: Heiko Tietze <tietze.heiko@gmail.com> Tested-by: Heiko Tietze <tietze.heiko@gmail.com> Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2019-04-17SharePoint connection: Better handling of encoded URLsTamás Zolnai
Handle %7c with small letters. Make sure that the output parameter's content is not affected by decoding. Change-Id: Ie3faad2461815497c0edfb04a589fc57aeb7d66b Reviewed-on: https://gerrit.libreoffice.org/70873 Tested-by: Jenkins Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2019-04-17Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - Fix PRODUCTNAME Change-Id: I11a5ac0e5c1a33eb6f28c32024dab0fceec91e14 Reviewed-on: https://gerrit.libreoffice.org/70888 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2019-04-17uitest for bug tdf#118540Zdeněk Crhonek
Change-Id: I71f479c00e47c277fe08329b4abd20dba8d68224 Reviewed-on: https://gerrit.libreoffice.org/70840 Tested-by: Jenkins Reviewed-by: Zdenek Crhonek <zcrhonek@gmail.com>
2019-04-17tdf#89884 add language support icons to breezeandreas kainz
Change-Id: I83b3559e9ba434bf32bd21608a591bd346779a33 Reviewed-on: https://gerrit.libreoffice.org/70882 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2019-04-17m_mapRefWindow is unneeded nowCaolán McNamara
Change-Id: I68811d64ed340f3b5f86d7c13289455009eea74e Reviewed-on: https://gerrit.libreoffice.org/70890 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
generated by cgit (git 2.34.1) at 2024-07-12 01:53:33 +0000