summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-10-31fix clang -fpermissive warnings in Qt5AccessibleWidgetNoel Grandin
error: converting to ‘bool’ from ‘std::nullptr_t’ requires direct-initialization Change-Id: Id002e2bf0363ddde1a1172cf6364180dbcac64ee
2018-10-31lok: new function to add certificate to certificate DBTomaž Vajngerl
Also needed to extend XCertificateCreator with a new method "addDERCertificateToTheDatabase". Change-Id: I7b4df65365893bd5a0628aeec30b3156584849fe Reviewed-on: https://gerrit.libreoffice.org/62273 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-31tdf#42949 Fix IWYU warnings in sc/inc; sc/source/filter/inc/Gabor Kelemen
Found with bin/find-unneeded-includes after recent improvements - remove UNO headers from blacklist - remove newly found unneeded fw declarations - fix up some not self contained headers Change-Id: I605656bc98a64640a78d2ff4de9c7c37326033cf Reviewed-on: https://gerrit.libreoffice.org/62264 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-31oox: remove dead QuickDiagrammingLayoutMiklos Vajna
This would create a com.sun.star.drawing.DiagramShape, and work with that, but nobody implements such a service. Change-Id: Iaaed3ace95d86e52ba50e059ab89698197709189 Reviewed-on: https://gerrit.libreoffice.org/62671 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-31sw: turn on clang-format for docxtablestyleexportMiklos Vajna
This had (consistent) manual formatting before, but recently I broke it. Change-Id: Ifd925797c5599aa55852b2e2fb7d16c5812cd159 Reviewed-on: https://gerrit.libreoffice.org/62673 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-31Fix qt5 build after 9078b0b8f48b161ad5b880c31a4413f9e706f01bSamuel Mehrbrodt
Change-Id: I4d8a2212006cb82a106c30b491b58e23a6e1aa7b Reviewed-on: https://gerrit.libreoffice.org/62680 Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-31qt5 a11y: Add table selection supportSamuel Mehrbrodt
Change-Id: I4e655a2b4c6a0057935ac5e47c93b16e763d4357 Reviewed-on: https://gerrit.libreoffice.org/62675 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-31qt5 a11y: Implement QAccessibleTableInterfaceSamuel Mehrbrodt
Change-Id: Ic632a2253afb960cda43f84905dd519e9052c0eb Reviewed-on: https://gerrit.libreoffice.org/62668 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-31lok: Get the object shell from the documentTomaž Vajngerl
Change-Id: Id62c0db3c9f404aaab70de0a73a20b2bb57b0393 Reviewed-on: https://gerrit.libreoffice.org/62272 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2018-10-31loplugin:useuniqueptr in ParagraphObj::ParagraphObjNoel Grandin
Change-Id: I4c5dcdad18988381b64479cad077234978437795 Reviewed-on: https://gerrit.libreoffice.org/62661 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in PPTTextObj::PPTTextObjNoel Grandin
Change-Id: Ib150ecf2dbcc0e3be1d7b1d4daba6065605597ee Reviewed-on: https://gerrit.libreoffice.org/62660 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in SfxSplitWindowNoel Grandin
Change-Id: I30ece3781df9f705c96f9fc69e2b2a943625f6b3 Reviewed-on: https://gerrit.libreoffice.org/62659 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in AcceleratorNoel Grandin
Change-Id: I4dbca6a57ea150067f734b2edb79e750b3ff9745 Reviewed-on: https://gerrit.libreoffice.org/62656 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in UcbLockBytes::SetSizeNoel Grandin
Change-Id: Ie968bedac6abb8f76705e30eaaebb74fed949883 Reviewed-on: https://gerrit.libreoffice.org/62655 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in ImplSysReadConfigNoel Grandin
Change-Id: I59fc342e480b6ace1bbe366692d834f1076abac2 Reviewed-on: https://gerrit.libreoffice.org/62653 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in SfxItemPoolCache::ApplyToNoel Grandin
Change-Id: Ica6ffb5bbaad5c941c65cae02bba7ea2380646f3 Reviewed-on: https://gerrit.libreoffice.org/62652 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in TypeWriter::createBlopNoel Grandin
Change-Id: Iafc9fdcaeb83d1a383ed60b3b610043d0325cde2 Reviewed-on: https://gerrit.libreoffice.org/62650 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in l10ntoolsNoel Grandin
Change-Id: Ib8dafdb2b3831cdd9481fd19b340ac377c8dc9db Reviewed-on: https://gerrit.libreoffice.org/62649 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in codemakerNoel Grandin
Change-Id: I1d6ec5a5c06a32242773c857444bb63b7b4207b6 Reviewed-on: https://gerrit.libreoffice.org/62648 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in oneToOneMappingWithFlagNoel Grandin
Change-Id: I729d6640c105ca43fdd2e3e702f6f62876db75e5 Reviewed-on: https://gerrit.libreoffice.org/62647 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in impl_getWindowDescriptorNoel Grandin
return by value, the usual C++ optimisations will make this efficient Change-Id: I7f9634b9663605504c69e0381a6ebc9c76061048 Reviewed-on: https://gerrit.libreoffice.org/62645 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31fix delete in MultiSelection::SetTotalRangeNoel Grandin
leftover from conversion to using std::vector<Range> instead of std::vector<Range*> Change-Id: Iaa2d81b0fac4551f4d1ed685d1e728d5e0ea6929 Reviewed-on: https://gerrit.libreoffice.org/62644 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31loplugin:useuniqueptr in DeletePrinterQueueInfoNoel Grandin
Change-Id: Ia124a4af642e449dc05f5bae2d5ca766bd67bd68 Reviewed-on: https://gerrit.libreoffice.org/62388 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-10-31Colibre Icons: update shadow to gray instead of yellowandreas kainz
Change-Id: I38bd2d434224f90374e088feb5a0f436e6f6a771 Reviewed-on: https://gerrit.libreoffice.org/62639 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-31writerfilter: implement formprotJustin Luth
The document properly opens with all sections protected because document protection (forms view) is enabled. However, when that setting was toggled off, all sections wrongly became unprotected, and remained unprotected when round-tripped (including in Word - so loss of configuration). Word does protection differently. It opens up in a forms only mode, but upon enabling editing mode, the individual sections can still be protected. Only when global enforcement is disabled do all sections become editable. So, if global enforcement is enabled, map the section protection to LO native protection. On startup, the sections will all be protected because of the global compatibility flag. If the flag is turned off, then you enter a similar mode to Word's "Edit document" where the sections are still protected. In LO, *each* section's protection must be turned off individually to fully disable enforcement. This patch keeps the same three-step process to fully edit the entire document, but the meanings take on a different form. "Compatability: Protect Form" changes from "enforcement" to "edit document" in concept. BTW, that matches how export works, where PROTECT_FORM is auto-enabled if any sections are protected. Section protection in LO can be disabled through Format - Sections - Write Protection. Patch initially developed to support tdf#120499. It depends on an earlier commit in order to round-trip. Change-Id: I8a2399f79640115d689ae9093792eecef7dbaeec Reviewed-on: https://gerrit.libreoffice.org/61918 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-31cppCheck RedundantAssignment variable bRefFoundZdibák Zoltán
Change-Id: I1b8e9d434a682717e09ae1d23470baef55935fe6 Reviewed-on: https://gerrit.libreoffice.org/62664 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable pMergeAttrZdibák Zoltán
Change-Id: I5dc87ec04a7c79359c947ba2786bbe067770904c Reviewed-on: https://gerrit.libreoffice.org/62665 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31uitest: add demo showing how to access the calc input windowMarkus Mohrhard
Change-Id: I5e1fc327a785e892e1c2f526cce8c58fe1ab928c Reviewed-on: https://gerrit.libreoffice.org/62413 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable pPatternZdibák Zoltán
Change-Id: Iba6eb684366bd60c19e4f28ec76c4d85bd1c4b64 Reviewed-on: https://gerrit.libreoffice.org/62666 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable p3DObjZdibák Zoltán
Change-Id: Ib423480bdb5d2cee183b5d1bda5b1a9ff05fdafc Reviewed-on: https://gerrit.libreoffice.org/62667 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31cppCheck RedundantAssignment variable bRecordingZdibák Zoltán
Change-Id: I2fb7c2ce3581bf6347a5b6ee85d7e603e2b58800 Reviewed-on: https://gerrit.libreoffice.org/62643 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31Reduced scope of the rDefaultElementType variableZdibák Zoltán
Change-Id: I6a18502c933937b50a78389b04c5545644d2e3ba Reviewed-on: https://gerrit.libreoffice.org/62638 Tested-by: Jenkins Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com>
2018-10-31RedundantAssignment variable aResult1Zdibák Zoltán
Change-Id: I9c8a40389cc9cc18a017f5ab98aa022856ef301d Reviewed-on: https://gerrit.libreoffice.org/62642 Reviewed-by: Markus Mohrhard <markus.mohrhard@googlemail.com> Tested-by: Jenkins
2018-10-31tdf#43671 creatCanvasFont with EmphasisMark.Mark Hung
Change-Id: I8c7592e9bdb212fcbb07655e81faadd07ed880f7 Reviewed-on: https://gerrit.libreoffice.org/62244 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-10-30svtools: fix up misleading indentationMiklos Vajna
The intention was to only conditionally warn. Thanks Noel for spotting my mistake. Change-Id: Iaa035dba1f834c13a179ef66c3f39777f3843bdb Reviewed-on: https://gerrit.libreoffice.org/62641 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-30toolbar impress and draw update for image and draw contextandreas kainz
Change-Id: I463441256f294185349177afb83936230a6c6dea Reviewed-on: https://gerrit.libreoffice.org/62636 Tested-by: Jenkins Reviewed-by: andreas_kainz <kainz.a@gmail.com>
2018-10-30Make SbiProcDef::Match more readableJan-Marek Glogowski
This reverts commit 02caaef29d60 ("loplugin:useuniqueptr in SbiProcDef") and is hopefully easier to follow. Change-Id: I46be2b3c7a933743795d89fe17a2c499c6983382 Reviewed-on: https://gerrit.libreoffice.org/62548 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-30qt5 a11y: Implement QAccessibleTextInterface::attributesSamuel Mehrbrodt
Only a few basic attributes for now Change-Id: I1147e4feaf9eac3664142a678e918a65e9a7b2a3 Reviewed-on: https://gerrit.libreoffice.org/62633 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-30XAccessibleText: Add reference to CharacterPropertiesSamuel Mehrbrodt
Change-Id: I367e0a38ca44b6577e79c1cf2c447a85582ce1e3 Reviewed-on: https://gerrit.libreoffice.org/62632 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-30Qt5 actually return the selectionJan-Marek Glogowski
This broke my Windows build with interesting error messages: Qt5AccessibleWidget.cxx(772): error C2440: "=": "sal_Int32 *" kann nicht in "int *" konvertiert werden Qt5AccessibleWidget.cxx(772): note: Die Typen, auf die verwiesen wird, sind nicht verknuepft; die Konvertierung erfordert einen reinterpret_cast-Operator oder eine Typumwandlung im C- oder Funktionsformat. Same for line 774. So actually return the selection parts depending on the provided int pointers. Change-Id: Iffbe4481883450b9dacefa867ba7035861d62cdf Reviewed-on: https://gerrit.libreoffice.org/62635 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-30Move SalGraphics glyph functions into FontInstanceJan-Marek Glogowski
As we already rely on the GlyphItem's font instance, consequently this removes the SalGraphics GlyphItem based functions. Also unifies the glyph bound rect cache handling. An interesting aspect is the rotated glyph bounding box handling moved from CairoTextRender to FreetypeFont. It doesn't look like an implementation detail for Cairo, so it may have been a bug. Change-Id: I81bbb5d8ee98fb77a1eee05568c456f9e4553023 Reviewed-on: https://gerrit.libreoffice.org/62503 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-30Fix typoAndrea Gelmini
Change-Id: I1d00e975eaf85b5233755abefb952ca1eeacbb4e Reviewed-on: https://gerrit.libreoffice.org/62630 Tested-by: Jenkins Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2018-10-30oox: missing <vector> includeMiklos Vajna
Change-Id: Ib0808750854c1d59f8d208dbbe4e95045ceb56d0
2018-10-30tdf#42949 Fix IWYU warnings in include/sax/*Gabor Kelemen
Found with bin/find-unneeded-includes Only removal proposals are dealt with here. Change-Id: I8061ef6a7a8c04baf350844fae1f97836ac03554 Reviewed-on: https://gerrit.libreoffice.org/62399 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk>
2018-10-30Fix SalLayoutGlyphs copy constructorJan-Marek Glogowski
Since we can't know the real SalLayoutGlyphsImpl type, we always have to clone and delete it on assignemt and in the copy constructor. Change-Id: I3e3aa1e0271c5ecbb1474a70fae5e63bd7124677 Reviewed-on: https://gerrit.libreoffice.org/62583 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-10-30Add comment about AquaSalGraphics::GetResolution() returning a DPI of 96Tor Lillqvist
Change-Id: I3b89cb6c24c263a1a8ea4e249ab24256a7d6f3f7
2018-10-304th parameter Flags for REGEX(), tdf#113977Eike Rathke
REGEX( Text ; Expression [ ; [ Replacement ] [ ; Flags ] ] ) REGEX(Text;Expression) extracts the first match of Expression in Text. If there is no match, #N/A is returned. REGEX(Text;Expression;Replacement) replaces the first match of Expression in Text, not extracted. If there is no match, Text is returned unmodified. REGEX(Text;Expression;Replacement;"g") replaces all matches of Expression in Text, not extracted. If there is no match, Text is returned unmodified. Change-Id: I9d26a48f40c64a2704d9d07576c8b1b98b2c7b84 Reviewed-on: https://gerrit.libreoffice.org/62545 Reviewed-by: Eike Rathke <erack@redhat.com> Tested-by: Jenkins
2018-10-30tdf#116989: add unit testMike Kaganski
Change-Id: Ia8b5478b0d2a15f91add4ee76455e73c2c970392 Reviewed-on: https://gerrit.libreoffice.org/62544 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-30svtools: fix lost replacement grpahic when updating it via OLE failsMiklos Vajna
How to reproduce the problem: 1) Create an ODT file which has an OLE object, where the native data i an OLE2 container, containing a Package stream, containing a DOCX file. 2) Install some external application on Windows which registers itself as a handler for the DOCX CSLID [ this is where writing a testcase for this bug is challenging ]. 3) Load the ODT file in hidden mode, e.g. connect to a ./soffice "--accept=socket,host=localhost,port=9999;urp;StarOffice.ServiceManager" process from remote Java, load the file with Hidden=true in the Arguments parameter of loadComponentFromURL(). 4) Save it in a format that reads the replacement graphic of OLE objects, like HTML or DOC. Expected result: the replacement graphic is there. Actual result: the <img> tag has no src attribute (HTML case). The root cause is that in case the document is loaded in hidden mode then the IDataObject::GetData() call in OleComponent::getTransferData() fails, so the OLE objects enters a state where it no longer has its old replacement graphic, but it doesn't have a new one, either. Fix the problem by making this update more transactional in svt::EmbeddedObjectRef::GetReplacement(), so the "document conversion" scenario (load in one format in hidden frame, save in other format) works. Change-Id: I624c372baea56a85fb949bd99046f3af1f258c36 Reviewed-on: https://gerrit.libreoffice.org/62549 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-10-30tdf#119020 always scale icons as 24bit RGBJan-Marek Glogowski
We don't really care for the palette or even lower bitness of the original icons, when scaling them. So just convert them to 24bit to get the best scaling quality. And also actually fail the OpenGL scaling for 8bit color icons, instead of handling them as a grayscale image, which results in "funny" luminance based color icons. Change-Id: I62ff9e7cd45dbffba81b0db5a0252737b6189059 Reviewed-on: https://gerrit.libreoffice.org/62505 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
generated by cgit (git 2.34.1) at 2024-07-18 15:53:44 +0000