summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-11-01tdf#92848: SvxTableShape doesn't implement css::text::XTextAppendStephan Bergmann
...so don't let it announce that in getTypes(). Change-Id: I91324615e6a1857d8deed055345982e41e5d45a2 Reviewed-on: https://gerrit.libreoffice.org/62739 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-01kde5: fix buildThorsten Behrens
Change-Id: Ife5a5075fcfbfd83425c021b9f535c1f5e3e8d7e Reviewed-on: https://gerrit.libreoffice.org/62740 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins Reviewed-by: Thorsten Behrens <Thorsten.Behrens@CIB.de>
2018-11-01elementary: fix for tdf#111950, update Calc sidebar, add condition icon, ↵Rizal Muttaqin
distribute, etc Change-Id: I7759aef51af2f400f3f5ec69854fd9133e845f48 Reviewed-on: https://gerrit.libreoffice.org/62730 Tested-by: Jenkins Reviewed-by: Rizal Muttaqin <riz_17_oke@yahoo.co.id>
2018-11-01Resolves: tdf#105081 and tdf#113420Caolán McNamara
separate translations for Spacing: vs Margins: separate translations for Inch vs cm Change-Id: I9a2d8fe3ad0edde5afefe00258f1309f898130e8 Reviewed-on: https://gerrit.libreoffice.org/62699 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-01tdf#43671 set emphasis mark of vcl::Font (opengl).Mark Hung
Change-Id: Ib61765b495c867bcb461ee7324eb7b92ed4da864 Reviewed-on: https://gerrit.libreoffice.org/62631 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-11-01tdf#43671 set emphasis mark of vcl::Font (windows).Mark Hung
Process extra font properties of the canvas font to set emphasis mark when creating vcl::Font. Change-Id: I18ea1aecdde92ed3c777b0db27fcee7976e88476 Reviewed-on: https://gerrit.libreoffice.org/62245 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2018-11-01tdf#121083: EDITOR UI Hatch background color not read back from editorTamás Zolnai
Change-Id: Ic64fda8184a4cac244fe992dd72db9d67d35870c Reviewed-on: https://gerrit.libreoffice.org/62735 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-01mysqlc: filter schema in getColumnsTamas Bunth
Filter schema in XDatabaseMetaData::getColumns so it would show correct results in case there are more tables with the same name in different schemas. Change-Id: I8a986a43a8b049db3615d7ec2585ce68ebe3340e Reviewed-on: https://gerrit.libreoffice.org/62696 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-11-01Fix build on HaikuKacper Kasper
Change-Id: I4a21258c2405bd6e5c539ec0206e28a316c6ce13 Reviewed-on: https://gerrit.libreoffice.org/60835 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-01Tweak stack protector checkKacper Kasper
* There were concerns that current program could fail if -Werror is enabled and incorrectly report stack protector availability. * Remove "return 0;" since configure adds it automatically. * Add -O0 to build options, otherwise the function is optimized away and it doesn't trigger linker failure. Change-Id: Ib540b583019d17fec1213ff3c364030b003a5f0f Reviewed-on: https://gerrit.libreoffice.org/60836 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-01clang-tidy: (WIP) bugprone-too-small-loop-variable findingsTamás Zolnai
Change-Id: Iaa255b39928ac45dec1ed37e368c149d6027f561 Reviewed-on: https://gerrit.libreoffice.org/62701 Reviewed-by: Tamás Zolnai <tamas.zolnai@collabora.com> Tested-by: Tamás Zolnai <tamas.zolnai@collabora.com>
2018-11-01Move PDF buildin font handling into extra fileJan-Marek Glogowski
Change-Id: If3f5f3872b4d97c4832f302cc63cd9f1601ca22a Reviewed-on: https://gerrit.libreoffice.org/62709 Tested-by: Jenkins Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2018-11-01tdf#121030 invalidate referenced FontInstancesJan-Marek Glogowski
This sets the FreetypeFont pointer of the FreetypeFontInstances to nullptr when clearing the cache. And it changes the interface functions of SalLayoutGlyphs to some variant different from std::vector. I don't know if we should prefer the mutable or the const font instance. With mutable at least one can invalidate the font instance when checking the IsValid(), so we can get rid of our referenced font instance. Change-Id: I6070cfcb3c549dbad3383bd4ec2b05b30645b753 Reviewed-on: https://gerrit.libreoffice.org/62688 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-01replace VclAbstractDialog2 with VclAbstractDialogCaolán McNamara
and drop Dialog::GetResult as a consequence Change-Id: Id80a9dc1eab1a23daf4489719b3bafec976bb048 Reviewed-on: https://gerrit.libreoffice.org/62700 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-11-01tdf#120728 support SvxShape for SdrShape if not insertedArmin Le Grand
Added a fallback to allow correct SvxShape construction when SdrObject is not yet inserted - or has no SdrPage yet. This is needed ue to the paradigm change that a SdrObject only has a SdrPage when it is inserted. For more info and a discussion, see added comments. Change-Id: I2c1a4b1bbb531501ee73ab1c98c13321c5c0b050 Reviewed-on: https://gerrit.libreoffice.org/62710 Tested-by: Jenkins Reviewed-by: Armin Le Grand <Armin.Le.Grand@cib.de>
2018-11-01tdf#49684 Don't focus on Navigator or Sidebar on showJim Raykowski
Change-Id: I21b36c3ed2e5b6fc574e00f86d2c48c352cf469c Reviewed-on: https://gerrit.libreoffice.org/62337 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-01tdf#119631 Keyboard navigation: Skip hidden tabs in sidebar tab barJim Raykowski
Change-Id: I6ac001c27d6947f379c9923ff8518f9983faa356 Reviewed-on: https://gerrit.libreoffice.org/62716 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-01Fix undocked window loses focusJim Raykowski
Use any method to undock a docked window and the window loses focus. This is a regression that began sometime after version 5.1.6.2 Change-Id: I91194db3cc23a24e805a90edaf1566f950ac129d Reviewed-on: https://gerrit.libreoffice.org/62270 Tested-by: Jenkins Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-11-01revert accidental renameNoel Grandin
in commit 15c86cadadcd389bfcf80ca285c1c298353d987f Date: Wed Oct 31 14:36:41 2018 +0200 rename RemoveX->Remove in SfxUndoArray Change-Id: I2353d087eb0afb833adb51186d6bad7a357c095a Reviewed-on: https://gerrit.libreoffice.org/62717 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01tdf#120777 KDE5: Dialogs get blank when they are resizedAleksei Nikiforov
On window resize qt5 only redraws changed parts of widgets. If resize is minor (i.e. height has increased by 1 pixel, for example), qt5 may consider most parts of widget not changed and skip redrawing them and redraw only certain widget elements. But if cairo is used for drawing, on resize previously drawed image of widget is discarded and new one of different size is created. New image is empty, but qt5 doesn't issue redraw for whole widget. To mitigate this issue, data from old image of widget should be copied over to image of new widget, qt5 will redraw it partially or fully if necessary. Change-Id: Id950074efece9072bbfc002dfcb6ead813d5aeff Reviewed-on: https://gerrit.libreoffice.org/62698 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Jenkins
2018-11-01Limit the unique_ptr scope to get rid of .reset()Mike Kaganski
Change-Id: I5d852f4d7f5de24ff49eaada6f53cd197ee2d0f7 Reviewed-on: https://gerrit.libreoffice.org/62715 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-11-01tdf#112614: Include all labels in the search in Customize dialogMuhammet Kara
For uno commands Change-Id: Ide7a30387b0ec354cd0d42ba11c78e115ec94989 Reviewed-on: https://gerrit.libreoffice.org/62693 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01tdf#120997 Crash after Ctrl+Tab to traverse points of object, more fixNoel Grandin
regression from commit b4fc996520b47a6212661a9de3a1c72ccfc379a4 loplugin:useuniqueptr in SdrHdlList Change-Id: I53e2adee9a1ad8ef73de5a9601238187a6002241 Reviewed-on: https://gerrit.libreoffice.org/62714 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01external/libnumbertext: Don't depend on en_US.UTF-8 localeStephan Bergmann
Change-Id: I1c8db3d16547d8891835d0e8e849a1f53335dbf1 Reviewed-on: https://gerrit.libreoffice.org/62711 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2018-11-01oox smartart, vertical bracket list: fix node counter conditionMiklos Vajna
The visible effect of this was that the 2nd level text nodes were missing from the layout result. The cause is that when it comes to counting nodes of a condition, we assumed that the current layout node is a presentation of a model node, but this is not necessarily true. Fix the problem doing a "first presentation child of", then a "presentation of" navigation in that case, which leads us to the correct model node, so counting its children works. (An alternative way of getting non-zero children would be a "presentation parent of" navigation, followed by a "presentation of" navigation, but that would lead us to the document root, so we would count the number of 1st level elements, not the correct 2nd level elements.) Change-Id: Iccebe0e2e56b7acb7fbe2c38a7c9ebb2abb309b9 Reviewed-on: https://gerrit.libreoffice.org/62703 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Jenkins
2018-11-01loplugin:useuniqueptr in SdPPTImportNoel Grandin
Change-Id: I843a2626c6351789bee3d68f0ab9debca9caa733 Reviewed-on: https://gerrit.libreoffice.org/62663 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01loplugin:useuniqueptr in SfxBindingsNoel Grandin
Change-Id: Ic0ede56795e0da48607e66e64ce7e6e69617b438 Reviewed-on: https://gerrit.libreoffice.org/62658 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01loplugin:useuniqueptr in VclBuilder::preloadNoel Grandin
Change-Id: Ifda987ce3e9f24fb9e985a01ed8e39232f61e997 Reviewed-on: https://gerrit.libreoffice.org/62657 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01loplugin:useuniqueptr in ContentImplHelperNoel Grandin
Change-Id: I56909fcaf8088a353bbd0bb783c88d51b9f0822f Reviewed-on: https://gerrit.libreoffice.org/62654 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01loplugin:useuniqueptr in SalFrame::PostEventNoel Grandin
Change-Id: Ib066b1d6df90f330f2f93ec639bd7bc59a08c024 Reviewed-on: https://gerrit.libreoffice.org/62507 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01use unique_ptr in markForDeletionNoel Grandin
Change-Id: I10e5ad02243c7045d51191c735163ee4a027126e Reviewed-on: https://gerrit.libreoffice.org/62695 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01rename RemoveX->Remove in SfxUndoArrayNoel Grandin
accidentally left it this way when doing commit 19e715973e15f9e7cf6e8237643dbbc14f8eb87a Date: Mon Oct 29 16:15:27 2018 +0200 loplugin:useuniqueptr in MarkedUndoAction Change-Id: I250676df7af27f485c5d34281ef0da1e127eb24c Reviewed-on: https://gerrit.libreoffice.org/62694 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01tdf#120920 Assertion failure when switching slide layouts with text enteredNoel Grandin
no need to call StartListening here, has already been done inside SdPage::CreatePresObj Change-Id: I590e51f7afeb336d562d3ad9ccc123f542897aae Reviewed-on: https://gerrit.libreoffice.org/62689 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01fix pyuno compile on Fedora29Noel Grandin
'PyUnicode_GetSize' is deprecated [-Werror,-Wdeprecated-declarations] Change-Id: Id298d6a2b0af9ce418f9124c9addda55fcdc0318 Reviewed-on: https://gerrit.libreoffice.org/62687 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01drop LISTBOX_ERRORNoel Grandin
almost nobody checks it, so rather just assert Change-Id: Ic3ad4c04c4f6013db3e8757559d3a773df020a1d Reviewed-on: https://gerrit.libreoffice.org/62684 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2018-11-01Clean up file by sorting entriesJens Carl
Change-Id: If24bcf1a3c6aaa6929230e379e364507a5d5fe9b Reviewed-on: https://gerrit.libreoffice.org/62713 Tested-by: Jenkins Reviewed-by: Jens Carl <j.carl43@gmx.de>
2018-10-31mysqlc: Add support for mediumnint and char typesTamas Bunth
When reading column types from information schema, it can be mediumint and char types as well. Mediumint should be 3 bytes long. We can use sal_Int32 for that. Change-Id: Id3507b1f38cabfb96800fc7743c911e36609a346 Reviewed-on: https://gerrit.libreoffice.org/62697 Tested-by: Jenkins Reviewed-by: Tamás Bunth <btomi96@gmail.com>
2018-10-31Re-introduce the functionality to look for multiple iOS SDK versionsTor Lillqvist
Currently, look for 12.1, 12.0 and 11.4. (But of course I recommend people keep their Xcode updated, and thus now build against the 12.1 SDK.) Also get rid of two AC_SUBST variables that were not used anywhere. Change-Id: Ic1abf3eb1d900c843263dc781fd4c9a8ab126f09
2018-10-31replace StartExecuteModal with StartExecuteAsyncCaolán McNamara
Change-Id: I2c0e0266f6bb468ebb5285f95d1824cf12100812 Reviewed-on: https://gerrit.libreoffice.org/62690 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com> Tested-by: Caolán McNamara <caolanm@redhat.com>
2018-10-31Handle also css::ucb::NameClashException>(aExceptionTor Lillqvist
Change-Id: I979a163e796418d9a693229698b638cec4bf2226
2018-10-31Current iOS SDK is 12.1Tor Lillqvist
It sucks that configure.ac nowadays looks for exactly one specific version of the iOS SDK. I don't understand why that was thought to be a good idea. Change-Id: I5b67e17c627735bbafffc8177f1422813a33e034
2018-10-31tdf#119630 Fix lost focus in Sidebar menuJim Raykowski
Focus to document after deck selection or customization from the sidebar menu. Change-Id: I315fecfe7bfaedf4c751b1c240e08b80daa77221 Reviewed-on: https://gerrit.libreoffice.org/62677 Tested-by: Jenkins Reviewed-by: Jim Raykowski <raykowj@gmail.com>
2018-10-31tdf#120540 draw/impress UI: add Format / Table submenuJustin Luth
Although these commands were available in context menus, there was no main menu access to these commands. Also: -cleanup unused context/popup labels related to table items. Change-Id: Ia574c3783bb279e869c2b8c716f6fb394aa21873 Reviewed-on: https://gerrit.libreoffice.org/61715 Tested-by: Jenkins Reviewed-by: Justin Luth <justin_luth@sil.org>
2018-10-31Fix xmlSecSize size mismatchMike Kaganski
Since commit 9630a2dfc79b08e3417e6e69b083f5124614499c, CppunitTest_xmlsecurity_signing on Win64 segfaults: === [CUT] xmlsecurity_signing /usr/bin/sh: line 1: 10188 Segmentation fault ( PATH="C:\lo\src\core\instdir\program;C:\lo\src\core\instdir\program;C:\lo\src\core\workdir\LinkTarget\Library;C:\lo\src\core\workdir\UnpackedTarball\cppunit\src\cppunit\DebugDll;$PATH" $W/LinkTarget/Executable/cppunittester.exe $W/LinkTarget/CppunitTest/test_xmlsecurity_signing.dll --headless "-env:BRAND_BASE_DIR=file:///$S/instdir" "-env:BRAND_SHARE_SUBDIR=share" "-env:BRAND_SHARE_RESOURCE_SUBDIR=program/resource" "-env:UserInstallation=file:///$W/CppunitTest/xmlsecurity_signing.test.user" "-env:CONFIGURATION_LAYERS=xcsxcu:file:///$I/share/registry xcsxcu:file:///$W/unittest/registry" "-env:UNO_TYPES=file:///$I/program/types.rdb file:///$I/program/types/offapi.rdb" "-env:UNO_SERVICES=file:///$W/Rdb/ure/services.rdb file:///$W/Rdb/services.rdb" -env:URE_INTERNAL_LIB_DIR=file:///$I/program -env:LO_LIB_DIR=file:///$I/program -env:LO_JAVA_DIR=file:///$I/program/classes --protector $W/LinkTarget/Library/unoexceptionprotector.dll unoexceptionprotector --protector $W/LinkTarget/Library/unobootstrapprotector.dll unobootstrapprotector --protector $W/LinkTarget/Library/vclbootstrapprotector.dll vclbootstrapprotector "-env:CPPUNITTESTTARGET=$W/CppunitTest/xmlsecurity_signing.test" ) > $W/CppunitTest/xmlsecurity_signing.test.log 2>&1 warn:sfx.appl:18084:18824:sfx2/source/appl/app.cxx:191: No DDE-Service possible. Error: 16399 warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1084: WinSalFrame::SetIcon(): Could not load large icon ! warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1085: WinSalFrame::SetIcon(): Could not load small icon ! warn:basic:18084:18824:basic/source/uno/namecont.cxx:973: Cannot access extensions! warn:basic:18084:18824:basic/source/uno/namecont.cxx:973: Cannot access extensions! warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:793: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL' Operation completed successfully. warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:508: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' ' Operation completed successfully. warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:291: xmlSecDSigCtxSign() '' 'xmlSecDSigCtxProcessSignatureNode' 1 ' ' Operation completed successfully. HEAP CORRUPTION DETECTED: after Normal block (#1570713) at 0x00000197AC7E5AB0. CRT detected that the application wrote to memory after end of heap buffer. warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:793: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL' Operation completed successfully. warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:508: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' ' Operation completed successfully. warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:346: xmlSecDSigCtxVerify() '' 'xmlSecDSigCtxProcessSignatureNode' 1 ' ' Operation completed successfully. HEAP CORRUPTION DETECTED: after Normal block (#1585431) at 0x00000197AC7E7BF0. CRT detected that the application wrote to memory after end of heap buffer. SigningTest::testDescription finished in: 3332ms warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1084: WinSalFrame::SetIcon(): Could not load large icon ! warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1085: WinSalFrame::SetIcon(): Could not load small icon ! SigningTest::testECDSA finished in: 550ms warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1084: WinSalFrame::SetIcon(): Could not load large icon ! warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1085: WinSalFrame::SetIcon(): Could not load small icon ! SigningTest::testECDSAOOXML finished in: 466ms warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1084: WinSalFrame::SetIcon(): Could not load large icon ! warn:vcl:18084:18824:vcl/win/window/salframe.cxx:1085: WinSalFrame::SetIcon(): Could not load small icon ! warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes! warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes! warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes! warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes! warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes! warn:vcl.gdi:18084:18824:vcl/source/outdev/map.cxx:694: Please record only relative MapModes! SigningTest::testECDSAPDF finished in: 433ms warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:793: xmlSecDSigCtxProcessKeyInfoNode() '' '' 45 'details=NULL' Operation completed successfully. warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:508: xmlSecDSigCtxProcessSignatureNode() '' 'xmlSecDSigCtxProcessKeyInfoNode' 1 ' ' Operation completed successfully. warn:xmlsecurity.xmlsec:18084:18824:xmlsecurity/source/xmlsec/errorcallback.cxx:51: ..\src\xmldsig.c:346: xmlSecDSigCtxVerify() '' 'xmlSecDSigCtxProcessSignatureNode' 1 ' ' Operation completed successfully. === The problem is mismatch between sizeof(xmlSecSize) in xmlsec and LO: xmlsec uses 32-bit integer, while LO uses 64-bit. Crash happens in XMLSignature_MSCryptImpl::validate(), when pDsigCtx->manifestReferences address is incorrectly retrieved and passed to xmlSecPtrListGetSize. Despite the comment in xmlsecurity/inc/xmlsec-wrapper.h mentioned that the XMLSEC_NO_SIZE_T isn't used in xmlsec for MSVC, it's actually used there since commit 1cf0cd6f0f19c34a23228f7de691187887081dff. So we need to enable it for MSVC, too. Change-Id: I05a4f4f6700c178d28886a7ac203469c41d7048b Reviewed-on: https://gerrit.libreoffice.org/62676 Reviewed-by: Miklos Vajna <vmiklos@collabora.co.uk> Tested-by: Mike Kaganski <mike.kaganski@collabora.com>
2018-10-31Update git submodulesAndras Timar
* Update dictionaries from branch 'master' - typo: Typographica -> Typographical Change-Id: I9e9dc28dcb27ec466a5beecb1141f82489c803b1
2018-10-31Translate German commentsJohnny_M
Change-Id: I94cdb753d01dfd0d5b8f78ede1819b281b840ab2 Reviewed-on: https://gerrit.libreoffice.org/62669 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-31Update mdds to 1.4.3.Kohei Yoshida
Change-Id: I26f06c230533ed72c2b60ce5c9230bbd0a0db2e4 Reviewed-on: https://gerrit.libreoffice.org/62679 Tested-by: Jenkins Reviewed-by: Kohei Yoshida <libreoffice@kohei.us>
2018-10-31Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' - tdf#121073 fix Presenter console shorcuts Change-Id: If932427763d8f4c352bd53b7d5a9161293188ad1 Reviewed-on: https://gerrit.libreoffice.org/62691 Tested-by: Jenkins Reviewed-by: Adolfo Jayme Barrientos <fitojb@ubuntu.com>
2018-10-31qt5 a11y: Implement QAccessibleEditableTextInterfaceSamuel Mehrbrodt
Change-Id: I21106ac31484c4bf47363e3805315c5fb698e172 Reviewed-on: https://gerrit.libreoffice.org/62682 Reviewed-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de> Tested-by: Samuel Mehrbrodt <Samuel.Mehrbrodt@cib.de>
2018-10-31-Werror,-Wunused-parameterStephan Bergmann
Change-Id: I32713889f92f56bd1ec711116ac8232a6a462163
generated by cgit (git 2.34.1) at 2024-07-08 07:46:16 +0000