summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-06-04loplugin:simplifypointertobool improve (2)Noel Grandin
to look for the x.get() == null pattern, which can be simplified to !x Change-Id: I0eddf93257ab53ab31949961d7c33ac2dd7288ea Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95400 Tested-by: Noel Grandin <noel.grandin@collabora.co.uk> Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-04Upcoming loplugin:elidestringvar: fpickerStephan Bergmann
Change-Id: I4591cbe91e58a7c1014f9862cca63180800a3f45 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95465 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Upcoming loplugin:elidestringvar: filterStephan Bergmann
Change-Id: Ic88f3ca8dffa416966734370ef01f8814eacdd05 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95433 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-04Use lokCallbackTypeToString to show value symbolicallyTor Lillqvist
Change-Id: Idb685e2807cc62bbaca117f5cf85fdda622caae8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95467 Tested-by: Jenkins Reviewed-by: Tor Lillqvist <tml@collabora.com>
2020-06-04sd: allow to change the search string between searchesTomaž Vajngerl
Before this was missing, so even with a different search string, it still searched using the old string, which was a bug. Change-Id: I1655cb421e216e30ae593aabd3ead3a2d5c06299 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95461 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04vcl: VectorGraphicSearch - support changing search stringTomaž Vajngerl
Initial implementation only allowed to set the search string once. This change allows to change the search string and still retain the last position of a found string, so the search continues from this positon forward or backwards. This mimicks how we search through the GUI (which is the main use for this functionallity anyway). Change-Id: I8a7aee4b6b6525f483f105feaa1f83c4a0ad9594 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95460 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: add support to search backwards in PDF searchTomaž Vajngerl
Change-Id: I2c7f75d16a430dcfa892d28fb6b4f64118705ad2 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95459 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: add test to search inside PDF in multiple pagesTomaž Vajngerl
Change-Id: I246508a22a4e324bae1bb10c6e292790c04da4c0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95458 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: rename testSearchInMixedObject(2) to more descriptive nameTomaž Vajngerl
testSearchInMixedObject -> testSearchIn2MixedObjects testSearchInMixedObject2 -> testSearchIn6MixedObjects Change-Id: Ifba20df38fd33bb86b072ba79085d123c914f916 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95457 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: PDF search - reset mpVectorGraphicSearch at more placesTomaž Vajngerl
and simplify the case when the search doesn't find a match in the vector graphic. Change-Id: I3e086e8e36f8a578711eed6d4dcca65c0c4c6268 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95456 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: Add another test of searching with mixed objectsTomaž Vajngerl
This is to make sure that we switch between different objects during the search correctly. Change-Id: I18aa5b251cbaadd3a9cb15a04ec1a1e5f267d2e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95455 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-04sd: fix issue when PDF search doesn't send a search result + testTomaž Vajngerl
This fixes the issue when PDF search doesn't send the search result, because of premature exit. Also add test which reproduces this issue and tests the behavior of searching in multiple objects. Change-Id: I3a676eeac36bde88c67e90a49583444b8595a346 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95454 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Improve COM library management in ADOJulien Nabet
Change-Id: I99a1c61068fec743847181b43f3d9278c85e95e3 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95174 Tested-by: Jenkins Reviewed-by: Mike Kaganski <mike.kaganski@collabora.com>
2020-06-03Upcoming loplugin:elidestringvar: extensionsStephan Bergmann
Change-Id: I318eebbdc79c503b10570061a298eb76d6555540 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95402 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: drawinglayerStephan Bergmann
Change-Id: Ic4f4a2d2d6d04b317a00c3c1b7eb005229c81bd5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95398 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: editengStephan Bergmann
Change-Id: Ia14a1391cbc40b98d24e37c3a54b16871441fc78 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95399 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03vcl: use HAVE_FEATURE_PDFIUM in VectorGraphicSearch impl.Tomaž Vajngerl
Change-Id: Id6c30e8f1c5bdb0481b0c7d4680554e3e8caa323 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95393 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03fix ubsan in SharedStringPoolNoel Grandin
with a slightly dodgy fix. regression from commit 3581f1d71ae0d431ba28c0f3b7b263ff6212ce7b optimize SharedStringPool::purge() and fix tests It's not ideal - we no longer have a way of purging uppercase keys that are longer in use. But that doesn't cost much memory, because we are sharing those strings. We could potentially identify them with extra book-keeping in either intern() or purge(), but since this class is performance-sensitive, best just to sacrifice some space in the map. Change-Id: I85a469448f5b36b1b6889da60280edd56bbcb083 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95432 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03uitest: tdf96432.py: assert changes in chartXisco Fauli
Change-Id: I7b3a93e049fc96f1f2221e64468eafdd9dc7d78c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95442 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-03skip unselectable entriesCaolán McNamara
Change-Id: I55b7d64f84e2a5b7ab2e1ee8ce6a2f22440b9cfe Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95445 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-03cui: extract signature line SVG template into a fileMiklos Vajna
It's much easier to inspect/edit the template this way. Change-Id: I797143871058bcc4715ca13e10b8d16b428dd10e Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95405 Reviewed-by: Miklos Vajna <vmiklos@collabora.com> Tested-by: Jenkins
2020-06-03vcl: VectorGraphicSearch - move SearchContext into ImplementationTomaž Vajngerl
Change-Id: I3bbf085fd8b8b66a56e364168c1e70b4ce986467 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95392 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Fix typosAndrea Gelmini
Change-Id: I111334adcf8b9b9553c585ab9669cf2cbdb909cc Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95444 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-03Removed executable permission on fileAndrea Gelmini
Change-Id: I2e798932ef5a76920afbe8ae3163b4b3056862d8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95443 Tested-by: Julien Nabet <serval2412@yahoo.fr> Reviewed-by: Julien Nabet <serval2412@yahoo.fr>
2020-06-03tdf#129587: sc: Add UItestXisco Fauli
Change-Id: I4e8080d80f7cba19772c480b316249783f70b945 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95439 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-03ofz#23016 Invalid-enum-valueCaolán McNamara
Change-Id: Ie3a783002b6ad82c6939b567cb53c3d4afbfac7b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95408 Tested-by: Jenkins Reviewed-by: Caolán McNamara <caolanm@redhat.com>
2020-06-03tdf#133633 winaccessibility: Add null checkMichael Weghorn
The call to 'AccObjectManagerAgent::GetIAccessibleFromResID' may set 'pImAcc' to nullptr here (s. 'AccObjectWinManager::GetIAccessibleFromResID', which is called from there), so handle that case gracefully. Change-Id: I0dbd48974fd012ff086835b147cd9b9cfc8a052b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95430 Tested-by: Jenkins Reviewed-by: Michael Weghorn <m.weghorn@posteo.de>
2020-06-03tdf#132420: sw: Add unittestXisco Fauli
Change-Id: Ic98667b688c8d865e637fb921913a2d8d57133f0 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95431 Tested-by: Jenkins Reviewed-by: Xisco Fauli <xiscofauli@libreoffice.org>
2020-06-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to 67026c44ece5d04b41eb1c2f2c3ebf086d558bbd - Improve readabilty of SERIESSUM Change-Id: Ia5f4c2ccd335f9be8606bb192cc88d703d80d00c Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95436 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-03vcl: allow BitmapFastScaleFilter for 1xN or Nx1 cases.Mark Hung
Limiting both side to be at least 2px is not necessary, so check for 1px and add test cases. Change-Id: I3c6f6ed5c8842bf24e7983bd8ed27fb8bb9568c8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/92117 Tested-by: Jenkins Reviewed-by: Mark Hung <marklh9@gmail.com>
2020-06-03Update git submodulesOlivier Hallot
* Update helpcontent2 from branch 'master' to c6409aa8d0e0c6342cb397f906ac602201581a27 - Fix [aria-hidden] topix in CSS Change-Id: Ifbc5d8d7a3ffc92965a78062c5943b5e94081bf0 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95434 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-03Upcoming loplugin:elidestringvar: desktopStephan Bergmann
Change-Id: I46295b47daaa590b053433e0232e85e9c7b1f3cd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95397 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03enable backtraces for unit tests on macosNoel Grandin
Change-Id: I4f07e1e7b35bccc217d78662a45ac5eaf5865ee7 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95394 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03Update git submodulesSteve Fanning
* Update helpcontent2 from branch 'master' to e04a83713f38be33d0c51cc35d0c457919a3f213 - Improve help information for ACCRINT() function to better explain the behaviour of the Par argument. Change-Id: Ia1fb54abe828dc9d0310e83f9552099759b96d40 Reviewed-on: https://gerrit.libreoffice.org/c/help/+/95329 Tested-by: Jenkins Reviewed-by: Olivier Hallot <olivier.hallot@libreoffice.org>
2020-06-03pdfium: only init pdfium library one and destroy on LO exitTomaž Vajngerl
With more and more usage of PDFium, it is hard to keep track of the life-time of the PDFium library, so it can happen that a FPDF_DestroyLibrary happens when we still have another instance where PDFium is still use. The result of this is a crash. To prevent this, just initialize the library once and delete, when on LO exit. This can be improved in the future to only keep the library active when in actual use. Change-Id: I5c7e5de7f8b97d10efb394c67c7a61b976c8d57c Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95391 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03vcl: VectorGraphicSearch - clean-up SearchContext member vars.Tomaž Vajngerl
Change-Id: I1740be5ed1b47235da3794fa46e3533b17ca1fb8 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95390 Tested-by: Tomaž Vajngerl <quikee@gmail.com> Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03sd: improve the test for LOKit search in PDF graphicTomaž Vajngerl
Record how many times we het the search result back, so we can be sure that the search happend and don't just read the old values. Assert the search result selection rectangles and text selection rectangles. Add tools:Rectangle support for CPPUnit into sdmodeltestbase.hxx Change-Id: I0b22d2d2f66abdc0dd0d5ac13a1bfebaa470749a Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95383 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03vcl: add search start position support for VectorGraphicSearchTomaž Vajngerl
By default we start at the begin of the page, but with this change make it possible to start at the end. This makes it possible to search in the backwards direction (set the start position at to the end and search with "previous"). Change-Id: I78fb1461b86bf9eab2f91c3b9a81cbb5c6557332 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95382 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Resolves tdf#130936 - Proper Icon Size for MIME type Icon in Start CenterHeiko Tietze
Icons are now in 48px Change-Id: I484458adf047999bc2ea0cbf16e7ff3fff131eec Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95028 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org>
2020-06-03Upcoming loplugin:elidestringvar: dbaccessStephan Bergmann
Change-Id: I5dc074a250ee169812f3ffd0cc4e598972ab87dd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95396 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03loplugin:simplifypointertobool improveNoel Grandin
to look for the x.get() != null pattern, which can be simplified to x I'll do the x.get() == nullptr pattern in a separate patch, to reduce the chances of a mistake Change-Id: I45e0d178e75359857cdf50d712039cb526016555 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95354 Tested-by: Jenkins Reviewed-by: Noel Grandin <noel.grandin@collabora.co.uk>
2020-06-03tdf#133569 rework the SwCommentRuler buttonJan-Marek Glogowski
The original design was planned in tdf#38246 and documented as: https://wiki.documentfoundation.org/Design/Whiteboards/Comments_Ruler_Control This patch includes the following changes: * use the correct highlight colors * use a down-pointing arrow for expanse with a stable position, like some tree view implementations * left-align the label in RTL for better us- / read-ability * dynamic sized arrow for HiDPI: * draw arrow using a polygon * calculate arrow size and padding based on font size * drop almost all constant values * fix the instable, mouse-over tooltip -> just show it always While at it, I found clang-format just added some minimal, additional changes, so I removed the file from the blacklist and included these. Change-Id: I6e0bade387639eae6bdaaf7960b2fe44c73adf65 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/75421 Tested-by: Jenkins Reviewed-by: Heiko Tietze <heiko.tietze@documentfoundation.org> Reviewed-by: Jan-Marek Glogowski <glogow@fbihome.de>
2020-06-03vcl: add "previous" search to VectorGraphicSearchTomaž Vajngerl
Previous moves backwards in the search matches. Change-Id: I88d402e0b8cb9dc4fd93e7f1ce5b08fb42aadd06 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95381 Tested-by: Jenkins Reviewed-by: Tomaž Vajngerl <quikee@gmail.com>
2020-06-03Upcoming loplugin:elidestringvar: comphelperStephan Bergmann
Change-Id: Id388af90ca2c3dff435a1a6261e3de0c3c0dbdbd Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95376 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: connectivityStephan Bergmann
Change-Id: I406486e13b822c34cd2329cc3828dd0567be30e5 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95385 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: basctlStephan Bergmann
Change-Id: Ia0411cad22c23f16d5d85b7cb65822d19f923b4f Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95373 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: avmediaStephan Bergmann
Change-Id: I792998688f0ac0853cd6fee7a92d7c00580cb51b Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95372 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03Upcoming loplugin:elidestringvar: chart2Stephan Bergmann
Change-Id: Ibc668f42f2779d8f3542054c92338c9f4f3efe68 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95375 Tested-by: Jenkins Reviewed-by: Stephan Bergmann <sbergman@redhat.com>
2020-06-03writerfilter: mark these as const to make it explicit they return a copyMiklos Vajna
I.e. move / scale doesn't modify the wrap polygon, it returns a modified copy. Change-Id: Ic0b23a1c9de0ce90032656351d9744dace2ef4e6 Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95384 Tested-by: Jenkins Reviewed-by: Miklos Vajna <vmiklos@collabora.com>
2020-06-03uitest: avoid defining the same object multiple time in in mathShiko
Change-Id: I1ee5cde133390ca285bb154e6a373e0e5bc1cbed Reviewed-on: https://gerrit.libreoffice.org/c/core/+/95334 Tested-by: Jenkins Reviewed-by: Ahmed ElShreif <aelshreif7@gmail.com>
generated by cgit (git 2.34.1) at 2024-08-02 21:37:19 +0000